trustformers-core 0.1.1

Core traits and utilities for TrustformeRS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
//! Integration between versioning and A/B testing systems

use anyhow::Result;
use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::sync::Arc;
use uuid::Uuid;

use super::{ModelVersionManager, VersionedModel};
use crate::ab_testing::{ABTestManager, ExperimentConfig, MetricType, MetricValue, Variant};

/// Enhanced A/B testing manager with versioning integration
pub struct VersionedABTestManager {
    version_manager: Arc<ModelVersionManager>,
    ab_test_manager: Arc<ABTestManager>,
    active_experiments: tokio::sync::RwLock<HashMap<String, VersionedExperiment>>,
}

impl VersionedABTestManager {
    /// Create a new versioned A/B test manager
    pub fn new(version_manager: Arc<ModelVersionManager>) -> Self {
        Self {
            version_manager,
            ab_test_manager: Arc::new(ABTestManager::new()),
            active_experiments: tokio::sync::RwLock::new(HashMap::new()),
        }
    }

    /// Create an A/B test between model versions
    pub async fn create_version_experiment(
        &self,
        config: VersionExperimentConfig,
    ) -> Result<String> {
        // Validate that all versions exist
        let control_version = self
            .version_manager
            .get_version(config.control_version_id)
            .await?
            .ok_or_else(|| anyhow::anyhow!("Control version not found"))?;

        let mut treatment_versions = Vec::new();
        for &version_id in &config.treatment_version_ids {
            let version = self
                .version_manager
                .get_version(version_id)
                .await?
                .ok_or_else(|| anyhow::anyhow!("Treatment version {} not found", version_id))?;
            treatment_versions.push(version);
        }

        // Create A/B test variants
        let control_variant = Variant::new("control", &control_version.qualified_name());

        let treatment_variants: Vec<Variant> = treatment_versions
            .iter()
            .enumerate()
            .map(|(i, v)| Variant::new(&format!("treatment_{}", i), &v.qualified_name()))
            .collect();

        // Create experiment config
        let experiment_config = ExperimentConfig {
            name: config.name.clone(),
            description: config.description.clone(),
            control_variant,
            treatment_variants,
            traffic_percentage: config.traffic_percentage,
            min_sample_size: config.min_sample_size,
            max_duration_hours: config.max_duration_hours,
        };

        // Create the experiment
        let experiment_id = self.ab_test_manager.create_experiment(experiment_config)?;

        // Track versioned experiment
        let versioned_experiment = VersionedExperiment {
            experiment_id: experiment_id.clone(),
            model_name: control_version.model_name().to_string(),
            control_version_id: config.control_version_id,
            treatment_version_ids: config.treatment_version_ids.clone(),
            config: config.clone(),
            started_at: Utc::now(),
            status: VersionedExperimentStatus::Running,
            metrics_collected: HashMap::new(),
        };

        {
            let mut experiments = self.active_experiments.write().await;
            experiments.insert(experiment_id.clone(), versioned_experiment);
        }

        tracing::info!(
            "Created versioned A/B test: {} ({})",
            config.name,
            experiment_id
        );
        Ok(experiment_id)
    }

    /// Route a request to the appropriate model version
    pub async fn route_request(
        &self,
        experiment_id: &str,
        user_id: &str,
    ) -> Result<ModelRoutingResult> {
        // Get the variant from A/B test manager
        let variant = self.ab_test_manager.route_request(experiment_id, user_id)?;

        // Get the versioned experiment
        let experiments = self.active_experiments.read().await;
        let versioned_experiment = experiments
            .get(experiment_id)
            .ok_or_else(|| anyhow::anyhow!("Versioned experiment not found"))?;

        // Map variant to version ID
        let version_id = if variant.name() == "control" {
            versioned_experiment.control_version_id
        } else {
            // Parse treatment index from variant name
            let treatment_index = variant
                .name()
                .strip_prefix("treatment_")
                .and_then(|s| s.parse::<usize>().ok())
                .ok_or_else(|| anyhow::anyhow!("Invalid treatment variant name"))?;

            *versioned_experiment
                .treatment_version_ids
                .get(treatment_index)
                .ok_or_else(|| anyhow::anyhow!("Treatment index out of bounds"))?
        };

        // Get the actual model version
        let model_version = self
            .version_manager
            .get_version(version_id)
            .await?
            .ok_or_else(|| anyhow::anyhow!("Model version not found"))?;

        Ok(ModelRoutingResult {
            experiment_id: experiment_id.to_string(),
            variant: variant.clone(),
            version_id,
            model_version,
            user_id: user_id.to_string(),
        })
    }

    /// Record metrics for a versioned experiment
    pub async fn record_version_metric(
        &self,
        experiment_id: &str,
        user_id: &str,
        metric_type: VersionMetricType,
        value: f64,
        metadata: Option<HashMap<String, String>>,
    ) -> Result<()> {
        // Get routing information to determine variant
        let routing_result = self.route_request(experiment_id, user_id).await?;

        // Convert to A/B test metric
        let ab_metric_type = match &metric_type {
            VersionMetricType::Latency => MetricType::Latency,
            VersionMetricType::Accuracy => MetricType::Accuracy,
            VersionMetricType::Throughput => MetricType::Throughput,
            VersionMetricType::ErrorRate => MetricType::ErrorRate,
            VersionMetricType::MemoryUsage => MetricType::MemoryUsage,
            VersionMetricType::CustomMetric(name) => MetricType::Custom(name.clone()),
        };

        let ab_metric_value = match metric_type {
            VersionMetricType::Latency => MetricValue::Duration(value as u64),
            _ => MetricValue::Numeric(value),
        };

        // Record in A/B test manager
        self.ab_test_manager.record_metric(
            experiment_id,
            &routing_result.variant,
            ab_metric_type,
            ab_metric_value,
        )?;

        // Update versioned experiment metrics
        {
            let mut experiments = self.active_experiments.write().await;
            if let Some(experiment) = experiments.get_mut(experiment_id) {
                let metric_key = format!("{}:{}", routing_result.variant.name(), metric_type);
                experiment.metrics_collected.entry(metric_key).or_default().push(
                    VersionMetricRecord {
                        value,
                        timestamp: Utc::now(),
                        user_id: user_id.to_string(),
                        metadata: metadata.unwrap_or_default(),
                    },
                );
            }
        }

        Ok(())
    }

    /// Analyze experiment results with version context
    pub async fn analyze_version_experiment(
        &self,
        experiment_id: &str,
    ) -> Result<VersionExperimentResult> {
        // Get A/B test results
        let ab_result = self.ab_test_manager.analyze_experiment(experiment_id)?;

        // Get versioned experiment
        let experiments = self.active_experiments.read().await;
        let versioned_experiment = experiments
            .get(experiment_id)
            .ok_or_else(|| anyhow::anyhow!("Versioned experiment not found"))?;

        // Get version details
        let control_version = self
            .version_manager
            .get_version(versioned_experiment.control_version_id)
            .await?
            .ok_or_else(|| anyhow::anyhow!("Control version not found"))?;

        let mut treatment_versions = Vec::new();
        for &version_id in &versioned_experiment.treatment_version_ids {
            let version = self
                .version_manager
                .get_version(version_id)
                .await?
                .ok_or_else(|| anyhow::anyhow!("Treatment version not found"))?;
            treatment_versions.push(version);
        }

        // Create version-enhanced result
        Ok(VersionExperimentResult {
            experiment_id: experiment_id.to_string(),
            model_name: versioned_experiment.model_name.clone(),
            control_version,
            treatment_versions,
            ab_test_result: ab_result,
            experiment_duration: Utc::now() - versioned_experiment.started_at,
            total_requests: versioned_experiment
                .metrics_collected
                .values()
                .map(|records| records.len())
                .sum(),
            version_performance_comparison: self
                .compare_version_performance(versioned_experiment)
                .await?,
        })
    }

    /// Promote winning version based on experiment results
    pub async fn promote_winning_version(&self, experiment_id: &str) -> Result<PromotionResult> {
        let result = self.analyze_version_experiment(experiment_id).await?;

        // Determine winner based on A/B test recommendation
        let winning_version_id = match &result.ab_test_result.recommendation {
            crate::ab_testing::TestRecommendation::AdoptTreatment { variant, .. } => {
                // Find the treatment version ID
                let treatment_index = variant
                    .strip_prefix("treatment_")
                    .and_then(|s| s.parse::<usize>().ok())
                    .ok_or_else(|| anyhow::anyhow!("Invalid treatment variant name"))?;

                result
                    .treatment_versions
                    .get(treatment_index)
                    .map(|v| v.id())
                    .ok_or_else(|| anyhow::anyhow!("Treatment index out of bounds"))?
            },
            crate::ab_testing::TestRecommendation::KeepControl { .. } => {
                result.control_version.id()
            },
            _ => {
                return Ok(PromotionResult {
                    promoted: false,
                    version_id: None,
                    reason: "No clear winner determined".to_string(),
                });
            },
        };

        // Promote the winning version to production
        self.version_manager.promote_to_production(winning_version_id).await?;

        // Mark experiment as concluded
        {
            let mut experiments = self.active_experiments.write().await;
            if let Some(experiment) = experiments.get_mut(experiment_id) {
                experiment.status = VersionedExperimentStatus::Concluded;
            }
        }

        Ok(PromotionResult {
            promoted: true,
            version_id: Some(winning_version_id),
            reason: "Version promoted based on A/B test results".to_string(),
        })
    }

    /// List active versioned experiments
    pub async fn list_experiments(&self) -> Result<Vec<VersionedExperiment>> {
        let experiments = self.active_experiments.read().await;
        Ok(experiments.values().cloned().collect())
    }

    /// Stop a versioned experiment
    pub async fn stop_experiment(&self, experiment_id: &str) -> Result<()> {
        let mut experiments = self.active_experiments.write().await;
        if let Some(experiment) = experiments.get_mut(experiment_id) {
            experiment.status = VersionedExperimentStatus::Stopped;
        }
        Ok(())
    }

    // Helper methods

    async fn compare_version_performance(
        &self,
        experiment: &VersionedExperiment,
    ) -> Result<HashMap<String, VersionPerformanceMetrics>> {
        let mut comparison = HashMap::new();

        for (metric_key, records) in &experiment.metrics_collected {
            let parts: Vec<&str> = metric_key.split(':').collect();
            if parts.len() == 2 {
                let variant_name = parts[0];
                let metric_type = parts[1];

                let values: Vec<f64> = records.iter().map(|r| r.value).collect();

                if !values.is_empty() {
                    let mean = values.iter().sum::<f64>() / values.len() as f64;
                    let variance = values.iter().map(|v| (v - mean).powi(2)).sum::<f64>()
                        / values.len() as f64;
                    let std_dev = variance.sqrt();
                    let min = values.iter().cloned().fold(f64::INFINITY, f64::min);
                    let max = values.iter().cloned().fold(f64::NEG_INFINITY, f64::max);

                    let metrics = VersionPerformanceMetrics {
                        metric_type: metric_type.to_string(),
                        sample_count: values.len(),
                        mean,
                        std_dev,
                        min,
                        max,
                        p95: calculate_percentile(&values, 0.95),
                        p99: calculate_percentile(&values, 0.99),
                    };

                    comparison.insert(format!("{}:{}", variant_name, metric_type), metrics);
                }
            }
        }

        Ok(comparison)
    }
}

/// Calculate percentile from a list of values
fn calculate_percentile(values: &[f64], percentile: f64) -> f64 {
    let mut sorted = values.to_vec();
    sorted.sort_by(|a, b| a.partial_cmp(b).expect("Partial comparison failed"));
    let index = (percentile * (sorted.len() - 1) as f64) as usize;
    sorted[index]
}

/// Configuration for version-based A/B test experiment
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct VersionExperimentConfig {
    pub name: String,
    pub description: String,
    pub control_version_id: Uuid,
    pub treatment_version_ids: Vec<Uuid>,
    pub traffic_percentage: f64,
    pub min_sample_size: usize,
    pub max_duration_hours: u64,
}

/// Status of a versioned experiment
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub enum VersionedExperimentStatus {
    Running,
    Stopped,
    Concluded,
    Failed,
}

/// A versioned A/B test experiment
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct VersionedExperiment {
    pub experiment_id: String,
    pub model_name: String,
    pub control_version_id: Uuid,
    pub treatment_version_ids: Vec<Uuid>,
    pub config: VersionExperimentConfig,
    pub started_at: DateTime<Utc>,
    pub status: VersionedExperimentStatus,
    pub metrics_collected: HashMap<String, Vec<VersionMetricRecord>>,
}

/// Metric types for version experiments
#[derive(Debug, Clone, Serialize, Deserialize)]
pub enum VersionMetricType {
    Latency,
    Accuracy,
    Throughput,
    ErrorRate,
    MemoryUsage,
    CustomMetric(String),
}

impl std::fmt::Display for VersionMetricType {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            VersionMetricType::Latency => write!(f, "latency"),
            VersionMetricType::Accuracy => write!(f, "accuracy"),
            VersionMetricType::Throughput => write!(f, "throughput"),
            VersionMetricType::ErrorRate => write!(f, "error_rate"),
            VersionMetricType::MemoryUsage => write!(f, "memory_usage"),
            VersionMetricType::CustomMetric(name) => write!(f, "{}", name),
        }
    }
}

/// Metric record for version experiments
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct VersionMetricRecord {
    pub value: f64,
    pub timestamp: DateTime<Utc>,
    pub user_id: String,
    pub metadata: HashMap<String, String>,
}

/// Result of routing a request to a model version
#[derive(Debug, Clone)]
pub struct ModelRoutingResult {
    pub experiment_id: String,
    pub variant: Variant,
    pub version_id: Uuid,
    pub model_version: VersionedModel,
    pub user_id: String,
}

/// Result of analyzing a version experiment
#[derive(Debug, Clone)]
pub struct VersionExperimentResult {
    pub experiment_id: String,
    pub model_name: String,
    pub control_version: VersionedModel,
    pub treatment_versions: Vec<VersionedModel>,
    pub ab_test_result: crate::ab_testing::TestResult,
    pub experiment_duration: chrono::Duration,
    pub total_requests: usize,
    pub version_performance_comparison: HashMap<String, VersionPerformanceMetrics>,
}

/// Performance metrics for a version
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct VersionPerformanceMetrics {
    pub metric_type: String,
    pub sample_count: usize,
    pub mean: f64,
    pub std_dev: f64,
    pub min: f64,
    pub max: f64,
    pub p95: f64,
    pub p99: f64,
}

/// Result of promoting a version
#[derive(Debug, Clone)]
pub struct PromotionResult {
    pub promoted: bool,
    pub version_id: Option<Uuid>,
    pub reason: String,
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::versioning::{
        metadata::{ModelMetadata, ModelTag},
        storage::InMemoryStorage,
    };

    async fn create_test_version_manager() -> Arc<ModelVersionManager> {
        let storage = Arc::new(InMemoryStorage::new());
        Arc::new(ModelVersionManager::new(storage))
    }

    async fn create_test_version(manager: &ModelVersionManager, name: &str, version: &str) -> Uuid {
        let metadata = ModelMetadata::builder()
            .description(format!("Test model {}", name))
            .created_by("test_user".to_string())
            .model_type("transformer".to_string())
            .tag(ModelTag::new("test"))
            .build();

        manager
            .register_version(name, version, metadata, vec![])
            .await
            .expect("async operation failed")
    }

    #[tokio::test]
    async fn test_version_experiment_creation() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        // Create test versions
        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        // Create experiment
        let config = VersionExperimentConfig {
            name: "Model v1.1 Test".to_string(),
            description: "Testing improved model".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 50.0,
            min_sample_size: 100,
            max_duration_hours: 24,
        };

        let experiment_id = ab_manager
            .create_version_experiment(config)
            .await
            .expect("async operation failed");
        assert!(!experiment_id.is_empty());

        // Check that experiment is tracked
        let experiments = ab_manager.list_experiments().await.expect("async operation failed");
        assert_eq!(experiments.len(), 1);
        assert_eq!(experiments[0].experiment_id, experiment_id);
    }

    #[tokio::test]
    async fn test_request_routing() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Routing Test".to_string(),
            description: "Test routing".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let experiment_id = ab_manager
            .create_version_experiment(config)
            .await
            .expect("async operation failed");

        // Route a request
        let routing_result = ab_manager
            .route_request(&experiment_id, "test_user")
            .await
            .expect("async operation failed");
        assert_eq!(routing_result.experiment_id, experiment_id);
        assert_eq!(routing_result.user_id, "test_user");
        assert!(
            routing_result.version_id == control_id || routing_result.version_id == treatment_id
        );
    }

    #[tokio::test]
    async fn test_metric_recording() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Metrics Test".to_string(),
            description: "Test metrics".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let experiment_id = ab_manager
            .create_version_experiment(config)
            .await
            .expect("async operation failed");

        // Record a metric
        ab_manager
            .record_version_metric(
                &experiment_id,
                "test_user",
                VersionMetricType::Latency,
                120.0,
                None,
            )
            .await
            .expect("operation failed in test");

        // Check that metric was recorded
        let experiments = ab_manager.list_experiments().await.expect("async operation failed");
        let experiment = &experiments[0];
        assert!(!experiment.metrics_collected.is_empty());
    }

    #[tokio::test]
    async fn test_list_experiments_initially_empty() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());
        let experiments = ab_manager.list_experiments().await.expect("async operation failed");
        assert!(experiments.is_empty());
    }

    #[tokio::test]
    async fn test_stop_experiment() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Stop Test".to_string(),
            description: "Test stopping".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 50.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let experiment_id = ab_manager
            .create_version_experiment(config)
            .await
            .expect("async operation failed");

        ab_manager.stop_experiment(&experiment_id).await.expect("stop failed");

        let experiments = ab_manager.list_experiments().await.expect("async operation failed");
        assert_eq!(experiments[0].status, VersionedExperimentStatus::Stopped);
    }

    #[tokio::test]
    async fn test_multiple_experiments() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let v1 = create_test_version(&version_manager, "model_a", "1.0.0").await;
        let v2 = create_test_version(&version_manager, "model_a", "1.1.0").await;
        let v3 = create_test_version(&version_manager, "model_a", "1.2.0").await;

        let config1 = VersionExperimentConfig {
            name: "Exp 1".to_string(),
            description: "First".to_string(),
            control_version_id: v1,
            treatment_version_ids: vec![v2],
            traffic_percentage: 50.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let config2 = VersionExperimentConfig {
            name: "Exp 2".to_string(),
            description: "Second".to_string(),
            control_version_id: v1,
            treatment_version_ids: vec![v3],
            traffic_percentage: 50.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let _id1 = ab_manager.create_version_experiment(config1).await.expect("create failed");
        let _id2 = ab_manager.create_version_experiment(config2).await.expect("create failed");

        let experiments = ab_manager.list_experiments().await.expect("list failed");
        assert_eq!(experiments.len(), 2);
    }

    #[tokio::test]
    async fn test_multiple_metric_types() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Multi Metrics".to_string(),
            description: "Test multiple metrics".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let experiment_id =
            ab_manager.create_version_experiment(config).await.expect("create failed");

        ab_manager
            .record_version_metric(
                &experiment_id,
                "user1",
                VersionMetricType::Latency,
                100.0,
                None,
            )
            .await
            .expect("record failed");

        ab_manager
            .record_version_metric(
                &experiment_id,
                "user2",
                VersionMetricType::Accuracy,
                0.95,
                None,
            )
            .await
            .expect("record failed");

        ab_manager
            .record_version_metric(
                &experiment_id,
                "user3",
                VersionMetricType::Throughput,
                500.0,
                None,
            )
            .await
            .expect("record failed");

        let experiments = ab_manager.list_experiments().await.expect("list failed");
        assert!(!experiments[0].metrics_collected.is_empty());
    }

    #[tokio::test]
    async fn test_experiment_config_fields() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Config Test".to_string(),
            description: "Config description".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 75.0,
            min_sample_size: 200,
            max_duration_hours: 48,
        };

        let _experiment_id = ab_manager
            .create_version_experiment(config.clone())
            .await
            .expect("create failed");

        let experiments = ab_manager.list_experiments().await.expect("list failed");
        assert_eq!(experiments[0].config.name, "Config Test");
        assert_eq!(experiments[0].config.traffic_percentage, 75.0);
        assert_eq!(experiments[0].config.min_sample_size, 200);
    }

    #[test]
    fn test_version_metric_type_display() {
        assert_eq!(format!("{}", VersionMetricType::Latency), "latency");
        assert_eq!(format!("{}", VersionMetricType::Accuracy), "accuracy");
        assert_eq!(format!("{}", VersionMetricType::Throughput), "throughput");
        assert_eq!(format!("{}", VersionMetricType::ErrorRate), "error_rate");
        assert_eq!(
            format!("{}", VersionMetricType::MemoryUsage),
            "memory_usage"
        );
        assert_eq!(
            format!(
                "{}",
                VersionMetricType::CustomMetric("custom_one".to_string())
            ),
            "custom_one"
        );
    }

    #[test]
    fn test_versioned_experiment_status_equality() {
        assert_eq!(
            VersionedExperimentStatus::Running,
            VersionedExperimentStatus::Running
        );
        assert_ne!(
            VersionedExperimentStatus::Running,
            VersionedExperimentStatus::Stopped
        );
    }

    #[test]
    fn test_calculate_percentile_basic() {
        let values = vec![1.0, 2.0, 3.0, 4.0, 5.0];
        let p50 = calculate_percentile(&values, 0.5);
        assert!((p50 - 3.0).abs() < 1e-10);
    }

    #[test]
    fn test_calculate_percentile_p0() {
        let values = vec![10.0, 20.0, 30.0];
        let p0 = calculate_percentile(&values, 0.0);
        assert!((p0 - 10.0).abs() < 1e-10);
    }

    #[test]
    fn test_calculate_percentile_p100() {
        let values = vec![10.0, 20.0, 30.0];
        let p100 = calculate_percentile(&values, 1.0);
        assert!((p100 - 30.0).abs() < 1e-10);
    }

    #[tokio::test]
    async fn test_routing_deterministic_for_same_user() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Deterministic Routing".to_string(),
            description: "Test deterministic routing".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let experiment_id =
            ab_manager.create_version_experiment(config).await.expect("create failed");

        let r1 = ab_manager
            .route_request(&experiment_id, "same_user")
            .await
            .expect("route failed");
        let r2 = ab_manager
            .route_request(&experiment_id, "same_user")
            .await
            .expect("route failed");

        // Same user should get routed to same version
        assert_eq!(r1.version_id, r2.version_id);
    }

    #[tokio::test]
    async fn test_analyze_experiment_with_data() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Analyze Test".to_string(),
            description: "Test analysis".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 1,
            max_duration_hours: 1,
        };

        let experiment_id =
            ab_manager.create_version_experiment(config).await.expect("create failed");

        // Add some metrics before analyzing
        for i in 0..5 {
            ab_manager
                .record_version_metric(
                    &experiment_id,
                    &format!("user_{}", i),
                    VersionMetricType::Latency,
                    100.0 + i as f64,
                    None,
                )
                .await
                .expect("record failed");
        }

        let result = ab_manager.analyze_version_experiment(&experiment_id).await;
        // Analysis may or may not succeed depending on internal logic
        let _ = result;
    }

    #[tokio::test]
    async fn test_promote_with_metrics() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Promote Test".to_string(),
            description: "Test promotion".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 100.0,
            min_sample_size: 1,
            max_duration_hours: 1,
        };

        let experiment_id =
            ab_manager.create_version_experiment(config).await.expect("create failed");

        // Add some metrics
        for i in 0..3 {
            ab_manager
                .record_version_metric(
                    &experiment_id,
                    &format!("user_{}", i),
                    VersionMetricType::Latency,
                    50.0 + i as f64,
                    None,
                )
                .await
                .expect("record failed");
        }

        let result = ab_manager.promote_winning_version(&experiment_id).await;
        // Promotion may or may not succeed depending on sufficient data
        let _ = result;
    }

    #[tokio::test]
    async fn test_experiment_initial_status_running() {
        let version_manager = create_test_version_manager().await;
        let ab_manager = VersionedABTestManager::new(version_manager.clone());

        let control_id = create_test_version(&version_manager, "test_model", "1.0.0").await;
        let treatment_id = create_test_version(&version_manager, "test_model", "1.1.0").await;

        let config = VersionExperimentConfig {
            name: "Status Test".to_string(),
            description: "Test status".to_string(),
            control_version_id: control_id,
            treatment_version_ids: vec![treatment_id],
            traffic_percentage: 50.0,
            min_sample_size: 10,
            max_duration_hours: 1,
        };

        let _id = ab_manager.create_version_experiment(config).await.expect("create failed");
        let experiments = ab_manager.list_experiments().await.expect("list failed");
        assert_eq!(experiments[0].status, VersionedExperimentStatus::Running);
    }
}