trine-kv 0.5.13

Embedded LSM MVCC key-value database.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
use std::{
    fs,
    panic::{AssertUnwindSafe, catch_unwind},
    path::PathBuf,
    sync::{Arc, Barrier, mpsc},
    thread,
    time::{Duration, SystemTime, UNIX_EPOCH},
};

use crate::{
    Db, KeyRange, WriteBatch,
    db::CommitTracker,
    error::Error,
    lsm::LsmTree,
    options::{DbOptions, WalShardPolicy, WriteOptions},
    transaction::{ReadKey, TransactionReadSet},
    types::Sequence,
    wal,
    write_batch::BatchOperation,
};

use super::{
    AcceptedWrite, AcceptedWriteState, DurabilityMode, PreparedShardId, WalAcceptState,
    WriteRequest, effective_durability,
};

fn publish_writer_state_for_test(
    db: &Db,
    writer_state: super::WriterLocalWriteState,
    publish: &super::PublishSequenceGuard<'_>,
) -> super::PublishedWrite {
    let sequenced = db
        .sequence_writer_local_state_under_barrier(writer_state, publish)
        .expect("sequence writer-local state");
    let sequenced = match sequenced {
        super::SequencedWriteState::Noop(_) => {
            panic!("test write should need a commit sequence")
        }
        super::SequencedWriteState::Pending(sequenced) => sequenced,
    };
    let durable = db
        .accept_deferred_wal_for_sequenced_write(sequenced)
        .expect("accept deferred WAL if needed");
    let _memtable_publish = db
        .inner
        .memtable_publish_lock
        .lock()
        .expect("memtable publish lock");
    db.publish_durable_writer_local_state_under_memtable_lock(durable)
        .expect("publish durable writer-local state")
}

#[test]
fn database_durability_is_a_write_floor() {
    assert_eq!(
        effective_durability(DurabilityMode::Buffered, DurabilityMode::SyncData),
        DurabilityMode::SyncData
    );
    assert_eq!(
        effective_durability(DurabilityMode::SyncAll, DurabilityMode::Buffered),
        DurabilityMode::SyncAll
    );
    // A database opened with the strict tier as its default makes every write
    // strict: a per-write request cannot quietly drop below F_FULLFSYNC.
    assert_eq!(
        effective_durability(DurabilityMode::SyncAllStrict, DurabilityMode::SyncAll),
        DurabilityMode::SyncAllStrict
    );
    // And a per-write request can still ask for the strict tier above a
    // weaker database default.
    assert_eq!(
        effective_durability(DurabilityMode::SyncData, DurabilityMode::SyncAllStrict),
        DurabilityMode::SyncAllStrict
    );
}

#[test]
fn commit_tracker_waits_for_prior_terminal_slot() {
    let tracker = CommitTracker::new(Sequence::ZERO);

    let first = tracker.reserve_slot().expect("reserve first slot");
    let second = tracker.reserve_slot().expect("reserve second slot");
    assert_eq!(first.sequence(), Sequence::new(1));
    assert_eq!(second.sequence(), Sequence::new(2));

    tracker.mark_visible(second).expect("mark second visible");
    assert_eq!(tracker.visible_sequence(), Sequence::ZERO);

    tracker.mark_skipped(first).expect("mark first skipped");
    assert_eq!(tracker.visible_sequence(), Sequence::new(2));

    let third = tracker.reserve_slot().expect("reserve third slot");
    assert_eq!(third.sequence(), Sequence::new(3));
}

#[test]
fn commit_tracker_rejects_second_terminal_transition() {
    let tracker = CommitTracker::new(Sequence::ZERO);
    let slot = tracker.reserve_slot().expect("reserve slot");

    tracker.mark_visible(slot).expect("mark slot visible");

    assert!(tracker.mark_skipped(slot).is_err());
    assert_eq!(tracker.visible_sequence(), Sequence::new(1));
}

#[test]
fn commit_tracker_sync_waiter_returns_only_after_contiguous_visibility() {
    let tracker = Arc::new(CommitTracker::new(Sequence::ZERO));
    let first = tracker.reserve_slot().expect("reserve first slot");
    let second = tracker.reserve_slot().expect("reserve second slot");
    tracker.mark_visible(second).expect("mark second visible");

    let (sent, received) = mpsc::channel();
    let waiting_tracker = Arc::clone(&tracker);
    let waiter = thread::spawn(move || {
        waiting_tracker
            .wait_until_visible(second.sequence())
            .expect("sync visibility wait succeeds");
        sent.send(()).expect("sync waiter reports completion");
    });
    assert!(matches!(
        received.recv_timeout(Duration::from_millis(20)),
        Err(mpsc::RecvTimeoutError::Timeout)
    ));

    tracker.mark_visible(first).expect("mark first visible");
    received
        .recv_timeout(Duration::from_secs(1))
        .expect("sync waiter wakes after gap closes");
    waiter.join().expect("sync waiter joins");
}

#[test]
fn commit_tracker_async_waiter_returns_only_after_contiguous_visibility() {
    let tracker = Arc::new(CommitTracker::new(Sequence::ZERO));
    let first = tracker.reserve_slot().expect("reserve first slot");
    let second = tracker.reserve_slot().expect("reserve second slot");
    tracker.mark_visible(second).expect("mark second visible");

    let (sent, received) = mpsc::channel();
    let waiting_tracker = Arc::clone(&tracker);
    let waiter = thread::spawn(move || {
        futures::executor::block_on(waiting_tracker.wait_until_visible_async(second.sequence()))
            .expect("async visibility wait succeeds");
        sent.send(()).expect("async waiter reports completion");
    });
    assert!(matches!(
        received.recv_timeout(Duration::from_millis(20)),
        Err(mpsc::RecvTimeoutError::Timeout)
    ));

    tracker.mark_visible(first).expect("mark first visible");
    received
        .recv_timeout(Duration::from_secs(1))
        .expect("async waiter wakes after gap closes");
    waiter.join().expect("async waiter joins");
}

#[test]
fn accepted_write_completion_delivers_success_result() {
    let db = Db::open_sync(DbOptions::memory()).expect("memory db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"k".to_vec(), b"v".to_vec());
    let request = WriteRequest::batch(batch, WriteOptions::default());
    let (accepted_write, waiter) = AcceptedWrite::accept(request);

    accepted_write.execute(&db);
    let commit = waiter.wait().expect("waiter receives commit result");

    assert_eq!(commit.sequence(), db.last_committed_sequence());
    assert_eq!(
        db.get_sync(b"k").expect("read committed key"),
        Some(b"v".to_vec())
    );
}

#[test]
fn accepted_write_completion_delivers_error_result() {
    let mut options = DbOptions::memory();
    options.read_only = true;
    let db = Db::open_sync(options).expect("read-only memory db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"k".to_vec(), b"v".to_vec());
    let request = WriteRequest::batch(batch, WriteOptions::default());
    let (accepted_write, waiter) = AcceptedWrite::accept(request);

    accepted_write.execute(&db);
    let error = waiter.wait().expect_err("waiter receives commit error");

    assert!(matches!(error, Error::ReadOnly));
    assert_eq!(db.get_sync(b"k").expect("read missing key"), None);
}

#[test]
fn write_rejects_key_over_configured_limit() {
    let options = DbOptions::memory().with_max_key_bytes(3);
    let db = Db::open_sync(options).expect("memory db opens");

    let error = db
        .put_sync(b"long", b"value")
        .expect_err("oversized key is rejected");

    assert!(
        matches!(error, Error::InvalidOptions { ref message } if message.contains("write key length 4 exceeds maximum 3")),
        "expected configured key limit error, got {error:?}"
    );
    assert_eq!(db.get_sync(b"long").expect("read missing key"), None);
}

#[test]
fn write_rejects_value_over_configured_limit() {
    let options = DbOptions::memory().with_max_value_bytes(3);
    let db = Db::open_sync(options).expect("memory db opens");

    let error = db
        .put_sync(b"key", b"value")
        .expect_err("oversized value is rejected");

    assert!(
        matches!(error, Error::InvalidOptions { ref message } if message.contains("write value length 5 exceeds maximum 3")),
        "expected configured value limit error, got {error:?}"
    );
    assert_eq!(db.get_sync(b"key").expect("read missing value"), None);
}

#[test]
fn range_delete_rejects_bound_over_configured_key_limit() {
    let options = DbOptions::memory().with_max_key_bytes(3);
    let db = Db::open_sync(options).expect("memory db opens");

    let error = db
        .delete_range_sync(KeyRange::half_open(b"a".to_vec(), b"long".to_vec()))
        .expect_err("oversized range bound is rejected");

    assert!(
        matches!(error, Error::InvalidOptions { ref message } if message.contains("write range bound length 4 exceeds maximum 3")),
        "expected configured range-bound limit error, got {error:?}"
    );
}

#[test]
fn open_rejects_invalid_write_byte_limits() {
    let error = Db::open_sync(DbOptions::memory().with_max_key_bytes(0))
        .expect_err("zero key limit is rejected");
    assert!(
        matches!(error, Error::InvalidOptions { ref message } if message.contains("max key size must be non-zero")),
        "expected zero key limit error, got {error:?}"
    );

    let error = Db::open_sync(
        DbOptions::memory().with_max_value_bytes(DbOptions::MAX_WRITE_FIELD_BYTES + 1),
    )
    .expect_err("oversized value limit is rejected");
    assert!(
        matches!(error, Error::InvalidOptions { ref message } if message.contains("max value size")),
        "expected value limit ceiling error, got {error:?}"
    );
}

#[test]
fn accepted_write_preflight_creates_writer_local_state_without_publication() {
    let db = Db::open_sync(DbOptions::memory()).expect("memory db opens");
    db.bucket_sync("events").expect("named bucket opens");
    let mut batch = WriteBatch::new();
    batch.put(b"default".to_vec(), b"v1".to_vec());
    batch
        .put_bucket("events", b"event".to_vec(), b"v2".to_vec())
        .expect("stage named bucket write");
    let request = WriteRequest::batch(batch, WriteOptions::default());

    let accepted_state = db
        .accept_write_request(request)
        .expect("write request is accepted");
    let AcceptedWriteState::Pending(writer_state) = accepted_state else {
        panic!("non-empty write must produce writer-local state");
    };

    let prepared = writer_state.prepared;
    assert_eq!(prepared.operation_count(), 2);
    assert!(prepared.transaction_reads.is_none());
    assert_eq!(
        prepared
            .wal_operations
            .iter()
            .map(BatchOperation::bucket)
            .collect::<Vec<_>>(),
        ["default", "events"]
    );
    assert_eq!(db.last_committed_sequence(), Sequence::ZERO);
    assert_eq!(
        db.get_sync(b"default").expect("preflight is not visible"),
        None
    );

    assert_eq!(prepared.deltas.len(), 2);
    assert_eq!(prepared.touched_states.len(), 2);
    assert_eq!(prepared.deltas[0].bucket, "default");
    assert_eq!(
        prepared.deltas[0].shard,
        PreparedShardId::CURRENT_SINGLE_SHARD
    );
    assert_eq!(prepared.deltas[0].operations[0].batch_index, 0);
    assert_eq!(
        prepared.deltas[0].operations[0].operation.bucket(),
        "default"
    );
    assert_eq!(
        prepared.deltas[0].key_bounds.lower.as_deref(),
        Some(b"default".as_slice())
    );
    assert_eq!(
        prepared.deltas[0].key_bounds.upper.as_deref(),
        Some(b"default".as_slice())
    );
    assert_eq!(prepared.deltas[1].bucket, "events");
    assert_eq!(prepared.deltas[1].operations[0].batch_index, 1);
    assert_eq!(
        prepared.deltas[1].operations[0].operation.bucket(),
        "events"
    );
    assert!(prepared.estimated_bytes > 0);
    assert!(
        prepared
            .deltas
            .iter()
            .all(|delta| delta.estimated_bytes > 0)
    );
    assert!(!Arc::ptr_eq(
        &prepared.deltas[0].state,
        &prepared.deltas[1].state
    ));
}

#[test]
fn partial_memtable_publication_failure_closes_database_handle() {
    let path = temp_db_path("partial-publish-failure");
    let db = Db::open_sync(DbOptions::new(&path)).expect("persistent db opens");
    db.bucket_sync("events").expect("named bucket opens");
    let events_state = db.bucket_state("events").expect("events bucket state");
    poison_active_memtable_entries(&events_state);

    let mut batch = WriteBatch::new();
    batch.put(b"default".to_vec(), b"v1".to_vec());
    batch
        .put_bucket("events", b"event".to_vec(), b"v2".to_vec())
        .expect("stage named bucket write");

    let error = db
        .write_sync(batch, WriteOptions::default())
        .expect_err("second bucket publish should fail");
    match error {
        Error::Corruption { message } => {
            assert!(message.contains("partially publishing in-memory state"));
            assert!(message.contains("database handle closed"));
        }
        other => panic!("expected corruption error, got {other:?}"),
    }

    assert!(matches!(db.get_sync(b"default"), Err(Error::Closed)));

    drop(db);
    cleanup_dir(&path);
}

#[test]
fn writer_local_preparation_groups_same_bucket_delta_with_bounds() {
    let db = Db::open_sync(DbOptions::memory()).expect("memory db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"b".to_vec(), b"v".to_vec());
    batch.delete(b"a".to_vec());
    batch.delete_range(crate::types::KeyRange::half_open(
        b"c".to_vec(),
        b"e".to_vec(),
    ));
    let request = WriteRequest::batch(batch, WriteOptions::default());

    let accepted_state = db
        .accept_write_request(request)
        .expect("write request is accepted");
    let AcceptedWriteState::Pending(writer_state) = accepted_state else {
        panic!("non-empty write must produce writer-local state");
    };
    let prepared = writer_state.prepared;

    assert_eq!(prepared.operation_count(), 3);
    assert_eq!(prepared.deltas.len(), 1);
    assert_eq!(prepared.touched_states.len(), 1);
    assert_eq!(prepared.deltas[0].bucket, "default");
    assert_eq!(
        prepared.deltas[0].shard,
        PreparedShardId::CURRENT_SINGLE_SHARD
    );
    assert_eq!(
        prepared.deltas[0]
            .operations
            .iter()
            .map(|operation| operation.batch_index)
            .collect::<Vec<_>>(),
        vec![0, 1, 2]
    );
    assert_eq!(
        prepared.deltas[0].key_bounds.lower.as_deref(),
        Some(b"a".as_slice())
    );
    assert_eq!(
        prepared.deltas[0].key_bounds.upper.as_deref(),
        Some(b"e".as_slice())
    );
    assert!(!prepared.deltas[0].key_bounds.lower_unbounded);
    assert!(!prepared.deltas[0].key_bounds.upper_unbounded);
    assert!(prepared.deltas[0].estimated_bytes > 0);
}

#[test]
fn persistent_blind_write_accepts_wal_before_publish_barrier() {
    let path = temp_db_path("preaccept-wal");
    let mut options = DbOptions::persistent(&path).with_durability(DurabilityMode::Flush);
    options.background_worker_count = 0;
    let db = Db::open_sync(options).expect("persistent db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"k".to_vec(), b"v".to_vec());
    let request = WriteRequest::batch(batch, WriteOptions::flush());

    let blocked_publish = db
        .inner
        .publish_barrier
        .enter_sequence()
        .expect("enter publish barrier");
    let accepted_state = db
        .accept_write_request(request)
        .expect("write request is accepted");
    let AcceptedWriteState::Pending(writer_state) = accepted_state else {
        panic!("non-empty write must produce writer-local state");
    };

    assert!(matches!(
        writer_state.wal_accept,
        WalAcceptState::Accepted(_)
    ));
    assert_eq!(db.last_committed_sequence(), Sequence::ZERO);
    assert_eq!(
        db.get_sync(b"k").expect("preaccepted write is not visible"),
        None
    );
    let wal_batches = wal::read_all_batches(&path).expect("WAL reads");
    assert_eq!(wal_batches.len(), 1);
    assert_eq!(wal_batches[0].sequence, Sequence::new(1));

    drop(blocked_publish);
    let publish = db
        .inner
        .publish_barrier
        .enter_sequence()
        .expect("enter publish barrier");
    let published = publish_writer_state_for_test(&db, writer_state, &publish);
    assert_eq!(published.commit_info.sequence(), Sequence::new(1));
    let visible_slot = published.visible_slot.expect("preaccepted commit has slot");
    db.inner
        .commit_tracker
        .mark_visible(visible_slot)
        .expect("mark preaccepted commit visible");
    assert_eq!(db.last_committed_sequence(), Sequence::new(1));
    assert_eq!(
        db.get_sync(b"k").expect("published write reads"),
        Some(b"v".to_vec())
    );

    drop(publish);
    drop(db);
    cleanup_dir(&path);
}

#[test]
fn sync_data_group_commit_writers_use_distinct_confirmed_marker_temps() {
    let path = temp_db_path("sync-data-group-commit");
    let mut options = DbOptions::persistent(&path).with_durability(DurabilityMode::SyncData);
    options.background_worker_count = 0;
    options.wal_shards = WalShardPolicy::Fixed(4);
    let db = Arc::new(Db::open_sync(options).expect("persistent db opens"));
    let concurrency = 8_usize;
    let writes_per_thread = 16_usize;
    let barrier = Arc::new(Barrier::new(concurrency));
    let mut handles = Vec::with_capacity(concurrency);

    for thread_index in 0..concurrency {
        let db = Arc::clone(&db);
        let barrier = Arc::clone(&barrier);
        handles.push(thread::spawn(move || {
            let bucket = db.default_bucket_sync().expect("default bucket opens");
            barrier.wait();
            for write_index in 0..writes_per_thread {
                let row = thread_index * writes_per_thread + write_index;
                let key = format!("k-{row:04}");
                let value = format!("v-{row:04}");
                bucket
                    .put_sync(key.into_bytes(), value.into_bytes())
                    .expect("durable put");
            }
        }));
    }

    for handle in handles {
        handle.join().expect("group commit writer joins");
    }

    assert_eq!(
        db.last_committed_sequence().get(),
        u64::try_from(concurrency * writes_per_thread).expect("write count fits u64")
    );
    drop(db);
    cleanup_dir(&path);
}

#[test]
fn persistent_transaction_accepts_wal_after_sequence_barrier_before_memory_publish() {
    let path = temp_db_path("transaction-wal-after-sequence");
    let mut options = DbOptions::persistent(&path).with_durability(DurabilityMode::Flush);
    options.background_worker_count = 0;
    let db = Db::open_sync(options).expect("persistent db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"k".to_vec(), b"txn".to_vec());
    let request = WriteRequest::transaction(
        Sequence::ZERO,
        TransactionReadSet {
            point_reads: vec![ReadKey {
                bucket: "default".to_owned(),
                key: b"k".to_vec(),
            }],
            range_reads: Vec::new(),
        },
        batch,
        WriteOptions::flush(),
    );
    let accepted_state = db
        .accept_write_request(request)
        .expect("transaction write request is accepted");
    let AcceptedWriteState::Pending(writer_state) = accepted_state else {
        panic!("transaction write must produce writer-local state");
    };
    assert!(matches!(writer_state.wal_accept, WalAcceptState::Deferred));
    assert!(
        wal::read_all_batches(&path).expect("WAL reads").is_empty(),
        "transaction WAL should wait for serialized read validation"
    );

    let publish = db
        .inner
        .publish_barrier
        .enter_sequence()
        .expect("enter publish barrier");
    let sequenced = db
        .sequence_writer_local_state_under_barrier(writer_state, &publish)
        .expect("transaction read set validates and slot reserves");
    let super::SequencedWriteState::Pending(sequenced) = sequenced else {
        panic!("transaction write should reserve a slot");
    };
    assert_eq!(db.stats().commit_open_slots, 1);
    assert!(
        wal::read_all_batches(&path).expect("WAL reads").is_empty(),
        "sequence reservation should not append WAL while barrier is held"
    );
    drop(publish);

    let durable = db
        .accept_deferred_wal_for_sequenced_write(sequenced)
        .expect("transaction WAL accepts outside publish barrier");
    let wal_batches = wal::read_all_batches(&path).expect("WAL reads");
    assert_eq!(wal_batches.len(), 1);
    assert_eq!(wal_batches[0].sequence, Sequence::new(1));
    assert_eq!(
        db.get_sync(b"k")
            .expect("WAL-accepted transaction is not visible"),
        None
    );

    let memtable_publish = db
        .inner
        .memtable_publish_lock
        .lock()
        .expect("memtable publish lock");
    let published = db
        .publish_durable_writer_local_state_under_memtable_lock(durable)
        .expect("publish transaction state");
    let visible_slot = published
        .visible_slot
        .expect("transaction has visible slot");
    db.inner
        .commit_tracker
        .mark_visible(visible_slot)
        .expect("mark transaction visible");
    assert_eq!(
        db.get_sync(b"k").expect("transaction write is visible"),
        Some(b"txn".to_vec())
    );

    drop(memtable_publish);
    drop(db);
    cleanup_dir(&path);
}

#[test]
fn writer_local_state_publishes_under_memtable_lock_after_sequence() {
    let db = Db::open_sync(DbOptions::memory()).expect("memory db opens");
    let mut batch = WriteBatch::new();
    batch.put(b"k".to_vec(), b"v".to_vec());
    let request = WriteRequest::batch(batch, WriteOptions::default());
    let accepted_state = db
        .accept_write_request(request)
        .expect("write request is accepted");
    let AcceptedWriteState::Pending(writer_state) = accepted_state else {
        panic!("non-empty write must produce writer-local state");
    };

    let publish = db
        .inner
        .publish_barrier
        .enter_sequence()
        .expect("enter publish barrier");
    let published = publish_writer_state_for_test(&db, writer_state, &publish);

    assert!(!published.request_flush);
    assert_eq!(published.commit_info.sequence(), Sequence::new(1));
    assert_eq!(db.last_committed_sequence(), Sequence::ZERO);
    assert_eq!(
        db.get_sync(b"k").expect("published slot is not visible"),
        None
    );
    let visible_slot = published.visible_slot.expect("published write has slot");
    db.inner
        .commit_tracker
        .mark_visible(visible_slot)
        .expect("mark published write visible");
    assert_eq!(db.last_committed_sequence(), Sequence::new(1));
    assert_eq!(
        db.get_sync(b"k").expect("read committed key"),
        Some(b"v".to_vec())
    );
    let state = db.bucket_state("default").expect("default bucket state");
    assert_eq!(
        state
            .active_memtable_bytes()
            .expect("active memtable bytes"),
        0
    );
    let (delta_count, point_delta_count, range_tombstone_count) =
        state.delta_debug_counts().expect("delta counts");
    assert_eq!(delta_count, 1);
    assert_eq!(point_delta_count, 1);
    assert_eq!(range_tombstone_count, 0);
    let db_stats = db.stats();
    assert!(db_stats.memtable_bytes > 0);
    assert_eq!(db_stats.immutable_memtables, 0);
}

#[test]
fn visible_sequence_waits_for_earlier_published_slot_completion() {
    let db = Db::open_sync(DbOptions::memory()).expect("memory db opens");
    let mut first_batch = WriteBatch::new();
    first_batch.put(b"k".to_vec(), b"v1".to_vec());
    let first_request = WriteRequest::batch(first_batch, WriteOptions::default());
    let AcceptedWriteState::Pending(first_state) = db
        .accept_write_request(first_request)
        .expect("first write request is accepted")
    else {
        panic!("first write must produce writer-local state");
    };

    let mut second_batch = WriteBatch::new();
    second_batch.put(b"k".to_vec(), b"v2".to_vec());
    let second_request = WriteRequest::batch(second_batch, WriteOptions::default());
    let AcceptedWriteState::Pending(second_state) = db
        .accept_write_request(second_request)
        .expect("second write request is accepted")
    else {
        panic!("second write must produce writer-local state");
    };

    let publish = db
        .inner
        .publish_barrier
        .enter_sequence()
        .expect("enter publish barrier");
    let first_published = publish_writer_state_for_test(&db, first_state, &publish);
    let second_published = publish_writer_state_for_test(&db, second_state, &publish);
    assert_eq!(first_published.commit_info.sequence(), Sequence::new(1));
    assert_eq!(second_published.commit_info.sequence(), Sequence::new(2));

    assert_eq!(db.last_committed_sequence(), Sequence::ZERO);
    assert_eq!(db.get_sync(b"k").expect("published writes are gated"), None);

    db.inner
        .commit_tracker
        .mark_visible(second_published.visible_slot.expect("second slot"))
        .expect("mark second slot visible");
    assert_eq!(db.last_committed_sequence(), Sequence::ZERO);
    assert_eq!(
        db.get_sync(b"k").expect("visible sequence waits for first"),
        None
    );

    db.inner
        .commit_tracker
        .mark_visible(first_published.visible_slot.expect("first slot"))
        .expect("mark first slot visible");
    assert_eq!(db.last_committed_sequence(), Sequence::new(2));
    assert_eq!(
        db.get_sync(b"k").expect("latest visible key"),
        Some(b"v2".to_vec())
    );
}

#[test]
fn in_memory_write_budget_merges_deltas_without_active_mirror() {
    let mut options = DbOptions::memory();
    options.write_buffer_bytes = 1;
    let db = Db::open_sync(options).expect("memory db opens");

    db.put_sync(b"k", b"v1").expect("first write");
    let snapshot = db.snapshot();
    db.put_sync(b"k", b"v2").expect("second write");

    assert_eq!(
        db.get_sync(b"k").expect("current read"),
        Some(b"v2".to_vec())
    );
    assert_eq!(
        snapshot
            .get_sync(&db.default_bucket_sync().expect("default bucket"), b"k")
            .expect("snapshot read"),
        Some(b"v1".to_vec())
    );

    let state = db.bucket_state("default").expect("default bucket state");
    assert_eq!(
        state
            .active_memtable_bytes()
            .expect("active memtable bytes"),
        0
    );
    let delta_stats = state.delta_debug_stats().expect("delta stats");
    assert_eq!(delta_stats.merged_epoch_count, 1);
    assert_eq!(delta_stats.max_shard_chain_len, 1);
    assert!(delta_stats.open_epoch_bytes > 0);
}

fn poison_active_memtable_entries(state: &LsmTree) {
    let active_memtable = state
        .active_memtable
        .read()
        .expect("active memtable pointer lock is not poisoned")
        .clone();
    let result = catch_unwind(AssertUnwindSafe(|| {
        let _entries = active_memtable
            .write_entries()
            .expect("memtable entries lock starts healthy");
        panic!("poison memtable entries for commit failure test");
    }));
    assert!(result.is_err());
}

fn temp_db_path(name: &str) -> PathBuf {
    let nonce = SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .expect("system time after epoch")
        .as_nanos();
    std::env::temp_dir().join(format!(
        "trine-kv-commit-{name}-{}-{nonce}",
        std::process::id()
    ))
}

fn cleanup_dir(path: &std::path::Path) {
    match fs::remove_dir_all(path) {
        Ok(()) => {}
        Err(error) if error.kind() == std::io::ErrorKind::NotFound => {}
        Err(error) => panic!("failed to remove {}: {error}", path.display()),
    }
}