triblespace-core 0.47.1

The triblespace core implementation.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
//! A transparent reader or active store which records its raw lookup interests.
//!
//! Misses and errors are dependencies too: a later exact record or physical
//! blob occurrence can change their answers. The tracker retains no payloads,
//! decoded values, or admission results. Clones share it so reads performed
//! while interpreting an already attached view remain part of that observation.
//! Snapshots and acquisitions of an observed active store share the same tracker.

use std::collections::BTreeSet;
use std::sync::{Arc, Mutex};

use crate::blob::encodings::UnknownBlob;
use crate::patch::{IdentitySchema, PATCH};
use crate::blob::{BlobEncoding, IntoBlob, TryFromBlob};
use crate::capability::{CapabilityProof, CapabilityProofId};
use crate::inline::encodings::hash::Handle;
use crate::inline::{Inline, InlineEncoding};
use crate::repo::async_store::AsyncBlobStoreAcquire;
use crate::repo::{
    BlobInfo, BlobMetadata, BlobStoreGet, BlobStoreList, BlobStoreMeta, BlobStorePut,
    CapabilityProofRead, CapabilityProofStore, SnapshotSource, StoreChanges, StoreDependencies,
    StoreSnapshot, WantRead,
};

use super::coverage::CoverageIndex;
use super::{
    CollectionHandle, CollectionRead, CollectionRecord, CollectionRecordSelector, CollectionStore,
    CoverageRead,
};

/// One read-set, shareable between every reader that should charge its
/// consultations to the same observation.
pub type DependencyTracker = Arc<Mutex<StoreDependencies>>;

/// Opt-in raw read-set observation without retaining interpreted results.
///
/// Reads, including misses and errors, accumulate across clones and snapshots.
/// Active writes forward unchanged; acquisitions record their exact handle
/// before forwarding. Drop the observer after an operation to bound this set,
/// and compare later snapshots with [`StoreSnapshot::changes_for`].
///
/// Provider availability and deadlines are not stored dependencies. A network
/// caller still owns its retry policy; this adapter performs no retries or WANT
/// publication of its own.
#[derive(Clone)]
pub struct ObservedStore<R> {
    inner: R,
    tracker: DependencyTracker,
}

impl<R> ObservedStore<R> {
    /// Start a fresh observation around a reader or an active store.
    pub fn new(inner: R) -> Self {
        Self::with_tracker(inner, Arc::new(Mutex::new(StoreDependencies::default())))
    }

    /// Read through `inner`, recording into a read-set another reader may
    /// share -- so that payloads an observation renders from a later snapshot
    /// still count as that observation's dependencies.
    pub fn with_tracker(inner: R, tracker: DependencyTracker) -> Self {
        Self { inner, tracker }
    }

    pub(crate) fn inner(&self) -> &R {
        &self.inner
    }

    /// Copy the raw interests collected so far, including failed lookups.
    pub fn dependencies(&self) -> StoreDependencies {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .clone()
    }

    /// Recover the wrapped reader or store without changing it.
    pub fn into_inner(self) -> R {
        self.inner
    }

    pub fn tracker(&self) -> DependencyTracker {
        Arc::clone(&self.tracker)
    }

    fn observe_blob<S>(&self, handle: Inline<Handle<S>>)
    where
        S: BlobEncoding,
        Handle<S>: InlineEncoding,
    {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .blobs
            .insert(Handle::<S>::to_hash(handle));
    }
}

impl<S: SnapshotSource> SnapshotSource for ObservedStore<S> {
    type Snapshot = ObservedStore<S::Snapshot>;
    type SnapshotError = S::SnapshotError;

    fn snapshot(&mut self) -> Result<Self::Snapshot, Self::SnapshotError> {
        let snapshot = self.inner.snapshot()?;
        Ok(Self::Snapshot::with_tracker(snapshot, self.tracker()))
    }
}

impl<S: BlobStorePut> BlobStorePut for ObservedStore<S> {
    type PutError = S::PutError;

    fn put<E, T>(&mut self, item: T) -> Result<Inline<Handle<E>>, Self::PutError>
    where
        E: BlobEncoding + 'static,
        T: IntoBlob<E>,
        Handle<E>: InlineEncoding,
    {
        self.inner.put(item)
    }
}

impl<S: CollectionStore> CollectionStore for ObservedStore<S> {
    type InsertError = S::InsertError;

    fn insert(&mut self, record: CollectionRecord) -> Result<(), Self::InsertError> {
        self.inner.insert(record)
    }
}

impl<S: CapabilityProofStore> CapabilityProofStore for ObservedStore<S> {
    type InsertError = S::InsertError;

    fn insert_proof(&mut self, proof: CapabilityProof) -> Result<(), Self::InsertError> {
        self.inner.insert_proof(proof)
    }
}

impl<S: AsyncBlobStoreAcquire> AsyncBlobStoreAcquire for ObservedStore<S> {
    type AcquireError = S::AcquireError;

    fn acquire(
        &mut self,
        handle: Inline<Handle<UnknownBlob>>,
    ) -> impl std::future::Future<Output = Result<Option<anybytes::Bytes>, Self::AcquireError>> + Send
    {
        self.observe_blob(handle);
        self.inner.acquire(handle)
    }

    fn acquires_remotely(&self) -> bool {
        self.inner.acquires_remotely()
    }
}

impl<R: StoreSnapshot> StoreSnapshot for ObservedStore<R> {
    fn changes_since(&self, previous: &Self) -> StoreChanges {
        self.inner.changes_since(&previous.inner)
    }

    fn changes_for(&self, previous: &Self, dependencies: &StoreDependencies) -> StoreChanges {
        self.inner.changes_for(&previous.inner, dependencies)
    }
}

impl<R: BlobStoreGet> BlobStoreGet for ObservedStore<R> {
    type GetError<E: std::error::Error + Send + Sync + 'static> = R::GetError<E>;

    fn get<T, S>(
        &self,
        handle: Inline<Handle<S>>,
    ) -> Result<T, Self::GetError<<T as TryFromBlob<S>>::Error>>
    where
        S: BlobEncoding + 'static,
        T: TryFromBlob<S>,
        Handle<S>: InlineEncoding,
    {
        self.observe_blob(handle);
        self.inner.get(handle)
    }
}

impl<R: BlobStoreList> BlobStoreList for ObservedStore<R> {
    type Iter<'a>
        = R::Iter<'a>
    where
        Self: 'a;
    type Err = R::Err;

    fn blobs<'a>(&'a self) -> Self::Iter<'a> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .all_blobs = true;
        self.inner.blobs()
    }

    fn contains_blob<S>(&self, handle: Inline<Handle<S>>) -> Result<bool, Self::Err>
    where
        S: BlobEncoding + 'static,
        Handle<S>: InlineEncoding,
    {
        self.observe_blob(handle);
        self.inner.contains_blob(handle)
    }

    fn blob_info<S>(&self, handle: Inline<Handle<S>>) -> Result<Option<BlobInfo>, Self::Err>
    where
        S: BlobEncoding + 'static,
        Handle<S>: InlineEncoding,
    {
        self.observe_blob(handle);
        self.inner.blob_info(handle)
    }

    fn blobs_diff<'a>(&'a self, old: &Self) -> Self::Iter<'a> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .all_blobs = true;
        self.inner.blobs_diff(&old.inner)
    }
}

impl<R: BlobStoreMeta> BlobStoreMeta for ObservedStore<R> {
    type MetaError = R::MetaError;

    fn metadata<S>(
        &self,
        handle: Inline<Handle<S>>,
    ) -> Result<Option<BlobMetadata>, Self::MetaError>
    where
        S: BlobEncoding + 'static,
        Handle<S>: InlineEncoding,
    {
        self.observe_blob(handle);
        self.inner.metadata(handle)
    }

    fn resident(
        &self,
        handles: &PATCH<32, IdentitySchema, ()>,
    ) -> Result<PATCH<32, IdentitySchema, ()>, Self::MetaError> {
        // Every handle asked about is a dependency, present or not: the
        // absent ones are what a later arrival changes.
        for key in handles.iter_ordered() {
            self.observe_blob(Inline::<Handle<UnknownBlob>>::new(*key));
        }
        self.inner.resident(handles)
    }
}

impl<R: CoverageRead> CoverageRead for ObservedStore<R> {
    /// Hand out the inner store's coverage and depend on the lineage rather
    /// than on everything.
    ///
    /// The dependency is a handful of `Collection` selectors, not
    /// `all_records`: the fold propagates only along a lineage, so a row the
    /// caller may consult changes only when a record arrives in one of the
    /// collections it named. Dropping the dependency entirely instead makes
    /// an observation miss the arrival that completes its own support,
    /// because a resolution selects its target and source but not the
    /// foundation the completing COMMIT lands in.
    fn index(
        &self,
        lineage: &BTreeSet<CollectionHandle>,
    ) -> Result<CoverageIndex, Self::RecordsError> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .records
            .extend(lineage.iter().copied().map(CollectionRecordSelector::Collection));
        self.inner.index(lineage)
    }
}

impl<R: CollectionRead> CollectionRead for ObservedStore<R> {
    type RecordsError = R::RecordsError;
    type RecordIter<'a>
        = R::RecordIter<'a>
    where
        Self: 'a;

    fn records<'a>(&'a self) -> Result<Self::RecordIter<'a>, Self::RecordsError> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .all_records = true;
        self.inner.records()
    }

    fn collections(&self) -> Result<Vec<CollectionHandle>, Self::RecordsError> {
        // A record naming a collection nobody had named before changes the
        // answer, so the listing depends on every record.
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .all_records = true;
        self.inner.collections()
    }

    fn select_records(
        &self,
        selectors: &BTreeSet<CollectionRecordSelector>,
    ) -> Result<Vec<CollectionRecord>, Self::RecordsError> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .records
            .extend(selectors.iter().copied());
        self.inner.select_records(selectors)
    }

    fn select_record_changes(
        &self,
        previous: &Self,
        selectors: &BTreeSet<CollectionRecordSelector>,
    ) -> Result<(Vec<CollectionRecord>, Vec<CollectionRecord>), Self::RecordsError> {
        for tracker in [&self.tracker, &previous.tracker] {
            tracker
                .lock()
                .expect("store dependency tracker is not poisoned")
                .records
                .extend(selectors.iter().copied());
        }
        self.inner.select_record_changes(&previous.inner, selectors)
    }
}

impl<R: CapabilityProofRead> CapabilityProofRead for ObservedStore<R> {
    type ProofsError = R::ProofsError;
    type ProofIter<'a>
        = R::ProofIter<'a>
    where
        Self: 'a;

    fn proofs<'a>(&'a self) -> Result<Self::ProofIter<'a>, Self::ProofsError> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .capability_proofs = true;
        self.inner.proofs()
    }

    fn proof(&self, id: CapabilityProofId) -> Result<Option<CapabilityProof>, Self::ProofsError> {
        self.tracker
            .lock()
            .expect("store dependency tracker is not poisoned")
            .capability_proofs = true;
        self.inner.proof(id)
    }
}

// WANT is not an input to passive collection interpretation. Forward it
// without expanding the observation's blob, record, or authority interests.
impl<R: WantRead> WantRead for ObservedStore<R> {
    type WantsError = R::WantsError;
    type WantIter<'a>
        = R::WantIter<'a>
    where
        Self: 'a;

    fn wants<'a>(&'a self) -> Result<Self::WantIter<'a>, Self::WantsError> {
        self.inner.wants()
    }
}

#[cfg(test)]
mod tests {
    use std::convert::Infallible;
    use std::sync::atomic::{AtomicUsize, Ordering};

    use anybytes::Bytes;
    use ed25519_dalek::SigningKey;

    use super::*;
    use crate::blob::encodings::UnknownBlob;
    use crate::blob::Blob;
    use crate::capability::CapabilityResource;
    use crate::collection::{
        empty_metadata_handle, read_capability, AdmissionPolicy, CollectionCommit,
        CollectionPolicy, CollectionStoreExt,
    };
    use crate::repo::memoryrepo::MemoryRepo;
    use crate::repo::{BlobStorePut, SnapshotSource};

    fn blob(text: &str) -> Blob<UnknownBlob> {
        Blob::new(Bytes::from_source(text.as_bytes().to_vec()))
    }

    #[test]
    fn missing_blob_reads_retain_every_exact_interest() {
        let mut store = MemoryRepo::default();
        let observed = ObservedStore::new(store.snapshot().unwrap());
        let handles = ["get", "contains", "info", "metadata"].map(|text| blob(text).get_handle());

        assert!(observed.get::<Blob<UnknownBlob>, _>(handles[0]).is_err());
        assert!(!observed.contains_blob(handles[1]).unwrap());
        assert!(observed.blob_info(handles[2]).unwrap().is_none());
        assert!(observed.metadata(handles[3]).unwrap().is_none());
        assert_eq!(
            observed.dependencies(),
            StoreDependencies {
                blobs: handles
                    .into_iter()
                    .map(Handle::<UnknownBlob>::to_hash)
                    .collect(),
                ..StoreDependencies::default()
            }
        );
    }

    #[test]
    fn clones_and_rebound_readers_share_interests_not_payloads() {
        let mut store = MemoryRepo::default();
        let resident = store.put(blob("resident")).unwrap();
        let absent = blob("absent").get_handle();
        let observed = ObservedStore::new(store.snapshot().unwrap());
        let cloned = observed.clone();
        let rebound = ObservedStore::with_tracker(observed.inner().clone(), observed.tracker());
        assert!(Arc::ptr_eq(&observed.tracker(), &cloned.tracker()));
        assert!(Arc::ptr_eq(&observed.tracker(), &rebound.tracker()));

        let bytes: Bytes = cloned.get(resident).unwrap();
        assert_eq!(bytes.as_ref(), b"resident");
        assert!(!rebound.contains_blob(absent).unwrap());
        let expected = StoreDependencies {
            blobs: [resident, absent]
                .into_iter()
                .map(Handle::<UnknownBlob>::to_hash)
                .collect(),
            ..StoreDependencies::default()
        };
        assert_eq!(observed.dependencies(), expected);
        assert_eq!(cloned.dependencies(), expected);
        assert_eq!(rebound.dependencies(), expected);
        assert!(ObservedStore::new(observed.inner().clone())
            .dependencies()
            .is_empty());
    }

    #[test]
    fn active_writes_forward_and_fresh_snapshots_share_only_read_interests() {
        let key = SigningKey::from_bytes(&[11; 32]);
        let mut store = MemoryRepo::default();
        let collection = store
            .collection(
                "observed active store",
                CollectionPolicy::new(
                    AdmissionPolicy::direct(key.verifying_key()),
                    AdmissionPolicy::direct(key.verifying_key()),
                ),
            )
            .unwrap();
        let mut observed = ObservedStore::new(&mut store);
        let before = observed.snapshot().unwrap();
        let handle = observed.put(blob("active member")).unwrap();
        let record = CollectionRecord::Commit(CollectionCommit::sign(
            &key,
            collection.handle(),
            Handle::<UnknownBlob>::to_hash(handle),
            empty_metadata_handle(),
        ));
        observed.insert(record).unwrap();
        let proof = CapabilityProof::new(
            CapabilityResource::from(collection.handle()),
            &key,
            read_capability(),
            SigningKey::from_bytes(&[12; 32]).verifying_key(),
        );
        observed.insert_proof(proof.clone()).unwrap();
        let after = observed.snapshot().unwrap();
        assert!(observed.dependencies().is_empty(), "writes are not reads");
        assert!(!before.contains_blob(handle).unwrap());
        assert_eq!(
            after.get::<Bytes, _>(handle).unwrap().as_ref(),
            b"active member"
        );
        let produced = BTreeSet::from([CollectionRecordSelector::ProducedMember(
            collection.handle(),
            Handle::<UnknownBlob>::to_hash(handle),
        )]);
        assert!(before.select_records(&produced).unwrap().is_empty());
        assert_eq!(after.select_records(&produced).unwrap(), vec![record]);
        assert!(before.proof(proof.id()).unwrap().is_none());
        assert_eq!(after.proof(proof.id()).unwrap(), Some(proof));
        let expected = StoreDependencies {
            blobs: BTreeSet::from([Handle::<UnknownBlob>::to_hash(handle)]),
            records: produced.clone(),
            capability_proofs: true,
            ..StoreDependencies::default()
        };
        assert_eq!(observed.dependencies(), expected);
        assert_eq!(before.dependencies(), expected);
        assert_eq!(after.dependencies(), expected);
        let native = after.into_inner();
        assert_eq!(native.select_records(&produced).unwrap(), vec![record]);
        assert_eq!(
            observed
                .into_inner()
                .snapshot()
                .unwrap()
                .wants()
                .unwrap()
                .count(),
            0
        );
    }

    #[test]
    fn acquisition_misses_errors_and_cancelled_futures_retain_exact_interest() {
        struct Acquirer {
            tracker: DependencyTracker,
            calls: Arc<AtomicUsize>,
            fail: bool,
        }

        impl AsyncBlobStoreAcquire for Acquirer {
            type AcquireError = std::io::Error;

            fn acquire(
                &mut self,
                handle: Inline<Handle<UnknownBlob>>,
            ) -> impl std::future::Future<Output = Result<Option<Bytes>, Self::AcquireError>> + Send
            {
                let interests = self
                    .tracker
                    .try_lock()
                    .expect("forward without holding lock");
                assert!(interests
                    .blobs
                    .contains(&Handle::<UnknownBlob>::to_hash(handle)));
                self.calls.fetch_add(1, Ordering::Relaxed);
                std::future::ready(if self.fail {
                    Err(std::io::Error::other("provider failed"))
                } else {
                    Ok(None)
                })
            }
        }

        for fail in [false, true] {
            let calls = Arc::new(AtomicUsize::new(0));
            let tracker = Arc::new(Mutex::new(StoreDependencies::default()));
            let mut observed = ObservedStore::with_tracker(
                Acquirer {
                    tracker: Arc::clone(&tracker),
                    calls: Arc::clone(&calls),
                    fail,
                },
                tracker,
            );
            let handle = blob("absent acquisition").get_handle();
            let result = futures::executor::block_on(observed.acquire(handle));
            if fail {
                assert_eq!(result.unwrap_err().to_string(), "provider failed");
            } else {
                assert!(result.unwrap().is_none());
            }
            let cancelled_handle = blob("cancelled acquisition").get_handle();
            drop(observed.acquire(cancelled_handle));
            assert_eq!(
                calls.load(Ordering::Relaxed),
                2,
                "one forwarding call per request"
            );
            assert_eq!(
                observed.dependencies(),
                StoreDependencies {
                    blobs: [handle, cancelled_handle]
                        .into_iter()
                        .map(Handle::<UnknownBlob>::to_hash)
                        .collect(),
                    ..StoreDependencies::default()
                }
            );
        }
    }

    #[test]
    fn missing_record_and_selected_routes_do_not_become_whole_record_reads() {
        let mut store = MemoryRepo::default();
        let key = SigningKey::from_bytes(&[7; 32]);
        let policy = CollectionPolicy::new(
            AdmissionPolicy::direct(key.verifying_key()),
            AdmissionPolicy::direct(key.verifying_key()),
        );
        let collection = store.collection("observed missing record", policy).unwrap();
        let unpublished = Handle::<UnknownBlob>::to_hash(blob("unpublished member").get_handle());
        let observed = ObservedStore::new(store.snapshot().unwrap());
        let produced = BTreeSet::from([CollectionRecordSelector::ProducedMember(
            collection.handle(),
            unpublished,
        )]);
        let selectors = BTreeSet::from([CollectionRecordSelector::Collection(collection.handle())]);

        assert!(observed.select_records(&produced).unwrap().is_empty());
        assert!(observed.select_records(&selectors).unwrap().is_empty());
        assert!(observed
            .select_records(&BTreeSet::new())
            .unwrap()
            .is_empty());
        assert_eq!(
            observed.dependencies(),
            StoreDependencies {
                records: BTreeSet::from([
                    CollectionRecordSelector::Collection(collection.handle()),
                    CollectionRecordSelector::ProducedMember(collection.handle(), unpublished),
                ]),
                ..StoreDependencies::default()
            }
        );

        let proof = CapabilityProof::new(
            CapabilityResource::from(collection.handle()),
            &key,
            read_capability(),
            SigningKey::from_bytes(&[8; 32]).verifying_key(),
        );
        assert!(observed.proof(proof.id()).unwrap().is_none());
        assert!(observed.dependencies().capability_proofs);
        assert!(!observed.dependencies().all_records);
    }

    #[test]
    fn selected_record_changes_track_both_observations_without_global_reads() {
        use crate::collection::CollectionStore;

        let mut store = MemoryRepo::default();
        let before = ObservedStore::new(store.snapshot().unwrap());
        let collection = crate::collection::CollectionHandle::new([73; 32]);
        let record = CollectionRecord::Commit(CollectionCommit::sign(
            &SigningKey::from_bytes(&[7; 32]),
            collection,
            crate::collection::CollectionData::new([74; 32]),
            empty_metadata_handle(),
        ));
        store.insert(record).unwrap();
        let after = ObservedStore::new(store.snapshot().unwrap());
        let selectors = BTreeSet::from([CollectionRecordSelector::Collection(collection)]);
        assert_eq!(
            after.select_record_changes(&before, &selectors).unwrap(),
            (vec![record], vec![]),
        );
        for observed in [&before, &after] {
            assert_eq!(
                observed.dependencies(),
                StoreDependencies {
                    records: selectors.clone(),
                    ..StoreDependencies::default()
                }
            );
        }
    }

    #[test]
    fn enumerations_mark_whole_components_but_wants_do_not() {
        let mut store = MemoryRepo::default();
        let before = store.snapshot().unwrap();
        let handle = store.put(blob("new member")).unwrap();
        let after = store.snapshot().unwrap();

        let listed = ObservedStore::new(after.clone());
        assert_eq!(listed.blobs().count(), 1);
        assert_eq!(
            listed.dependencies(),
            StoreDependencies {
                all_blobs: true,
                ..StoreDependencies::default()
            }
        );

        let delta = ObservedStore::new(after.clone());
        let old = ObservedStore::new(before);
        let new: Vec<_> = delta.blobs_diff(&old).map(Result::unwrap).collect();
        assert_eq!(new.len(), 1);
        assert_eq!(new[0].handle, handle);
        assert!(delta.dependencies().all_blobs);
        assert!(old.dependencies().is_empty());

        let records = ObservedStore::new(after.clone());
        assert_eq!(records.records().unwrap().count(), 0);
        assert_eq!(
            records.dependencies(),
            StoreDependencies {
                all_records: true,
                ..StoreDependencies::default()
            }
        );

        let proofs = ObservedStore::new(after.clone());
        assert_eq!(proofs.proofs().unwrap().count(), 0);
        assert_eq!(
            proofs.dependencies(),
            StoreDependencies {
                capability_proofs: true,
                ..StoreDependencies::default()
            }
        );

        let wants = ObservedStore::new(after);
        assert_eq!(wants.wants().unwrap().count(), 0);
        assert!(wants.dependencies().is_empty());
    }

    #[test]
    fn dependency_lock_is_released_before_backend_calls() {
        struct InspectLock(DependencyTracker);

        impl BlobStoreMeta for InspectLock {
            type MetaError = Infallible;

            fn metadata<S>(
                &self,
                _handle: Inline<Handle<S>>,
            ) -> Result<Option<BlobMetadata>, Self::MetaError>
            where
                S: BlobEncoding + 'static,
                Handle<S>: InlineEncoding,
            {
                assert!(
                    self.0.try_lock().is_ok(),
                    "read must not retain the tracker lock"
                );
                Ok(None)
            }
        }

        let tracker = Arc::new(Mutex::new(StoreDependencies::default()));
        let observed = ObservedStore::with_tracker(InspectLock(Arc::clone(&tracker)), tracker);
        let handle = blob("missing metadata").get_handle();
        assert!(observed.metadata(handle).unwrap().is_none());
        assert!(observed
            .dependencies()
            .blobs
            .contains(&Handle::<UnknownBlob>::to_hash(handle)));
    }

    #[test]
    fn snapshot_comparisons_delegate_without_recording_reads() {
        #[derive(Clone)]
        struct ScopedSnapshot(Arc<AtomicUsize>);

        impl StoreSnapshot for ScopedSnapshot {
            fn changes_since(&self, _previous: &Self) -> StoreChanges {
                StoreChanges::ALL
            }

            fn changes_for(
                &self,
                _previous: &Self,
                dependencies: &StoreDependencies,
            ) -> StoreChanges {
                assert!(dependencies.all_records);
                self.0.fetch_add(1, Ordering::Relaxed);
                StoreChanges::NONE
            }
        }

        let calls = Arc::new(AtomicUsize::new(0));
        let before = ObservedStore::new(ScopedSnapshot(Arc::clone(&calls)));
        let after = before.clone();
        let dependencies = StoreDependencies {
            all_records: true,
            ..StoreDependencies::default()
        };
        assert_eq!(after.changes_since(&before), StoreChanges::ALL);
        assert_eq!(
            after.changes_for(&before, &dependencies),
            StoreChanges::NONE
        );
        assert_eq!(calls.load(Ordering::Relaxed), 1);
        assert!(after.dependencies().is_empty());
    }
}