treadle 0.2.0

A persistent, resumable, human-in-the-loop workflow engine backed by a petgraph DAG
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
# Treadle Phase 2 Implementation Plan

## Phase 2: State Store Implementations

**Goal:** Two working StateStore backends — in-memory (for testing) and SQLite (for production).

**Prerequisites:**
- Phase 1 completed (all traits and types defined)
- `cargo build` and `cargo test` pass

---

## Milestone 2.1 — In-Memory StateStore

### Files to Create/Modify
- `src/state_store/mod.rs` (refactor from `src/state_store.rs`)
- `src/state_store/memory.rs` (new)
- `src/lib.rs` (update exports)

### Implementation Details

#### 2.1.1 Refactor to Module Structure

Convert `src/state_store.rs` to a directory module.

**`src/state_store/mod.rs`:**

```rust
//! State persistence for workflow execution.
//!
//! This module provides the [`StateStore`] trait and implementations
//! for persisting workflow execution state.

mod memory;

pub use memory::MemoryStateStore;

// Re-export the trait (move from original state_store.rs)
use async_trait::async_trait;
use std::collections::HashMap;

use crate::{Result, StageState, StageStatus, SubTaskStatus, WorkItem};

/// A persistent store for workflow execution state.
///
/// The `StateStore` trait abstracts over different storage backends
/// (in-memory, SQLite, etc.) for persisting the execution state of
/// work items as they progress through a workflow.
#[async_trait]
pub trait StateStore<W: WorkItem>: Send + Sync {
    /// Retrieves the status of a stage for a work item.
    async fn get_status(&self, item_id: &W::Id, stage: &str) -> Result<Option<StageStatus>>;

    /// Sets the status of a stage for a work item.
    async fn set_status(&self, item_id: &W::Id, stage: &str, status: StageStatus) -> Result<()>;

    /// Retrieves all stage statuses for a work item.
    async fn get_all_statuses(&self, item_id: &W::Id) -> Result<HashMap<String, StageStatus>>;

    /// Queries for work items in a specific state for a stage.
    async fn query_items(&self, stage: &str, state: StageState) -> Result<Vec<String>>;

    /// Retrieves all subtask statuses for a fan-out stage.
    async fn get_subtask_statuses(
        &self,
        item_id: &W::Id,
        stage: &str,
    ) -> Result<Vec<SubTaskStatus>>;

    /// Sets the status of a specific subtask.
    async fn set_subtask_status(
        &self,
        item_id: &W::Id,
        stage: &str,
        subtask: &str,
        status: SubTaskStatus,
    ) -> Result<()>;
}
```

#### 2.1.2 Create `src/state_store/memory.rs`

```rust
//! In-memory state store implementation.
//!
//! This module provides [`MemoryStateStore`], a thread-safe in-memory
//! implementation of [`StateStore`] suitable for testing and development.

use async_trait::async_trait;
use std::collections::HashMap;
use std::fmt::Display;
use std::hash::Hash;
use std::sync::Arc;
use tokio::sync::RwLock;

use crate::{Result, StageState, StageStatus, SubTaskStatus, WorkItem};
use super::StateStore;

/// Storage key for stage status.
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
struct StageKey {
    item_id: String,
    stage: String,
}

impl StageKey {
    fn new(item_id: impl Display, stage: impl Into<String>) -> Self {
        Self {
            item_id: item_id.to_string(),
            stage: stage.into(),
        }
    }
}

/// Storage key for subtask status.
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
struct SubTaskKey {
    item_id: String,
    stage: String,
    subtask: String,
}

impl SubTaskKey {
    fn new(item_id: impl Display, stage: impl Into<String>, subtask: impl Into<String>) -> Self {
        Self {
            item_id: item_id.to_string(),
            stage: stage.into(),
            subtask: subtask.into(),
        }
    }
}

/// Internal storage for the memory state store.
#[derive(Debug, Default)]
struct Storage {
    /// Stage statuses indexed by (item_id, stage).
    stages: HashMap<StageKey, StageStatus>,
    /// Subtask statuses indexed by (item_id, stage, subtask).
    subtasks: HashMap<SubTaskKey, SubTaskStatus>,
}

/// An in-memory implementation of [`StateStore`].
///
/// This implementation uses `Arc<RwLock<...>>` internally, making it
/// safe to clone and share across async tasks.
///
/// # Example
///
/// ```rust
/// use treadle::{MemoryStateStore, StateStore, StageStatus, WorkItem};
///
/// #[derive(Debug, Clone)]
/// struct MyItem { id: String }
///
/// impl WorkItem for MyItem {
///     type Id = String;
///     fn id(&self) -> &Self::Id { &self.id }
/// }
///
/// # async fn example() -> treadle::Result<()> {
/// let store = MemoryStateStore::<MyItem>::new();
///
/// // Store status
/// store.set_status(&"item-1".to_string(), "scan", StageStatus::completed()).await?;
///
/// // Retrieve status
/// let status = store.get_status(&"item-1".to_string(), "scan").await?;
/// assert!(status.is_some());
/// # Ok(())
/// # }
/// ```
#[derive(Debug, Clone)]
pub struct MemoryStateStore<W: WorkItem> {
    storage: Arc<RwLock<Storage>>,
    _marker: std::marker::PhantomData<W>,
}

impl<W: WorkItem> MemoryStateStore<W> {
    /// Creates a new, empty in-memory state store.
    pub fn new() -> Self {
        Self {
            storage: Arc::new(RwLock::new(Storage::default())),
            _marker: std::marker::PhantomData,
        }
    }

    /// Returns the number of stage status entries currently stored.
    ///
    /// Useful for testing.
    pub async fn stage_count(&self) -> usize {
        self.storage.read().await.stages.len()
    }

    /// Returns the number of subtask status entries currently stored.
    ///
    /// Useful for testing.
    pub async fn subtask_count(&self) -> usize {
        self.storage.read().await.subtasks.len()
    }

    /// Clears all stored data.
    ///
    /// Useful for resetting state between tests.
    pub async fn clear(&self) {
        let mut storage = self.storage.write().await;
        storage.stages.clear();
        storage.subtasks.clear();
    }
}

impl<W: WorkItem> Default for MemoryStateStore<W> {
    fn default() -> Self {
        Self::new()
    }
}

#[async_trait]
impl<W: WorkItem> StateStore<W> for MemoryStateStore<W> {
    async fn get_status(&self, item_id: &W::Id, stage: &str) -> Result<Option<StageStatus>> {
        let storage = self.storage.read().await;
        let key = StageKey::new(item_id, stage);
        Ok(storage.stages.get(&key).cloned())
    }

    async fn set_status(
        &self,
        item_id: &W::Id,
        stage: &str,
        status: StageStatus,
    ) -> Result<()> {
        let mut storage = self.storage.write().await;
        let key = StageKey::new(item_id, stage);
        storage.stages.insert(key, status);
        Ok(())
    }

    async fn get_all_statuses(&self, item_id: &W::Id) -> Result<HashMap<String, StageStatus>> {
        let storage = self.storage.read().await;
        let item_id_str = item_id.to_string();

        let result = storage
            .stages
            .iter()
            .filter(|(k, _)| k.item_id == item_id_str)
            .map(|(k, v)| (k.stage.clone(), v.clone()))
            .collect();

        Ok(result)
    }

    async fn query_items(&self, stage: &str, state: StageState) -> Result<Vec<String>> {
        let storage = self.storage.read().await;

        let result = storage
            .stages
            .iter()
            .filter(|(k, v)| k.stage == stage && v.state == state)
            .map(|(k, _)| k.item_id.clone())
            .collect();

        Ok(result)
    }

    async fn get_subtask_statuses(
        &self,
        item_id: &W::Id,
        stage: &str,
    ) -> Result<Vec<SubTaskStatus>> {
        let storage = self.storage.read().await;
        let item_id_str = item_id.to_string();

        let result = storage
            .subtasks
            .iter()
            .filter(|(k, _)| k.item_id == item_id_str && k.stage == stage)
            .map(|(_, v)| v.clone())
            .collect();

        Ok(result)
    }

    async fn set_subtask_status(
        &self,
        item_id: &W::Id,
        stage: &str,
        subtask: &str,
        status: SubTaskStatus,
    ) -> Result<()> {
        let mut storage = self.storage.write().await;
        let key = SubTaskKey::new(item_id, stage, subtask);
        storage.subtasks.insert(key, status);
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::work_item::test_helpers::TestItem;
    use crate::{ReviewData, StageState};

    type TestStore = MemoryStateStore<TestItem>;

    #[tokio::test]
    async fn test_new_store_is_empty() {
        let store = TestStore::new();
        assert_eq!(store.stage_count().await, 0);
        assert_eq!(store.subtask_count().await, 0);
    }

    #[tokio::test]
    async fn test_set_and_get_status() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        // Initially no status
        let status = store.get_status(&item_id, "scan").await.unwrap();
        assert!(status.is_none());

        // Set status
        store
            .set_status(&item_id, "scan", StageStatus::running())
            .await
            .unwrap();

        // Retrieve status
        let status = store.get_status(&item_id, "scan").await.unwrap();
        assert!(status.is_some());
        assert_eq!(status.unwrap().state, StageState::Running);
    }

    #[tokio::test]
    async fn test_set_status_overwrites() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        store
            .set_status(&item_id, "scan", StageStatus::pending())
            .await
            .unwrap();
        store
            .set_status(&item_id, "scan", StageStatus::completed())
            .await
            .unwrap();

        let status = store.get_status(&item_id, "scan").await.unwrap().unwrap();
        assert_eq!(status.state, StageState::Completed);
    }

    #[tokio::test]
    async fn test_get_all_statuses() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        store
            .set_status(&item_id, "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status(&item_id, "enrich", StageStatus::running())
            .await
            .unwrap();
        store
            .set_status(&item_id, "review", StageStatus::pending())
            .await
            .unwrap();

        let all = store.get_all_statuses(&item_id).await.unwrap();
        assert_eq!(all.len(), 3);
        assert_eq!(all.get("scan").unwrap().state, StageState::Completed);
        assert_eq!(all.get("enrich").unwrap().state, StageState::Running);
        assert_eq!(all.get("review").unwrap().state, StageState::Pending);
    }

    #[tokio::test]
    async fn test_get_all_statuses_different_items() {
        let store = TestStore::new();

        store
            .set_status(&"item-1".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status(&"item-2".to_string(), "scan", StageStatus::pending())
            .await
            .unwrap();

        let item1_statuses = store.get_all_statuses(&"item-1".to_string()).await.unwrap();
        let item2_statuses = store.get_all_statuses(&"item-2".to_string()).await.unwrap();

        assert_eq!(item1_statuses.len(), 1);
        assert_eq!(item2_statuses.len(), 1);
        assert_eq!(
            item1_statuses.get("scan").unwrap().state,
            StageState::Completed
        );
        assert_eq!(
            item2_statuses.get("scan").unwrap().state,
            StageState::Pending
        );
    }

    #[tokio::test]
    async fn test_query_items() {
        let store = TestStore::new();

        store
            .set_status(&"item-1".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status(&"item-2".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status(&"item-3".to_string(), "scan", StageStatus::pending())
            .await
            .unwrap();

        let completed = store
            .query_items("scan", StageState::Completed)
            .await
            .unwrap();
        let pending = store
            .query_items("scan", StageState::Pending)
            .await
            .unwrap();
        let failed = store.query_items("scan", StageState::Failed).await.unwrap();

        assert_eq!(completed.len(), 2);
        assert!(completed.contains(&"item-1".to_string()));
        assert!(completed.contains(&"item-2".to_string()));
        assert_eq!(pending.len(), 1);
        assert!(pending.contains(&"item-3".to_string()));
        assert!(failed.is_empty());
    }

    #[tokio::test]
    async fn test_query_items_different_stages() {
        let store = TestStore::new();

        store
            .set_status(&"item-1".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status(&"item-1".to_string(), "enrich", StageStatus::completed())
            .await
            .unwrap();

        let scan_completed = store
            .query_items("scan", StageState::Completed)
            .await
            .unwrap();
        let enrich_completed = store
            .query_items("enrich", StageState::Completed)
            .await
            .unwrap();

        assert_eq!(scan_completed.len(), 1);
        assert_eq!(enrich_completed.len(), 1);
    }

    #[tokio::test]
    async fn test_subtask_set_and_get() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        // Initially no subtasks
        let subtasks = store.get_subtask_statuses(&item_id, "enrich").await.unwrap();
        assert!(subtasks.is_empty());

        // Set subtask statuses
        store
            .set_subtask_status(
                &item_id,
                "enrich",
                "source-1",
                SubTaskStatus::pending("source-1"),
            )
            .await
            .unwrap();
        store
            .set_subtask_status(
                &item_id,
                "enrich",
                "source-2",
                SubTaskStatus::completed("source-2"),
            )
            .await
            .unwrap();

        // Retrieve subtasks
        let subtasks = store.get_subtask_statuses(&item_id, "enrich").await.unwrap();
        assert_eq!(subtasks.len(), 2);

        let names: Vec<_> = subtasks.iter().map(|s| s.name.as_str()).collect();
        assert!(names.contains(&"source-1"));
        assert!(names.contains(&"source-2"));
    }

    #[tokio::test]
    async fn test_subtask_overwrites() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        store
            .set_subtask_status(
                &item_id,
                "enrich",
                "source-1",
                SubTaskStatus::pending("source-1"),
            )
            .await
            .unwrap();
        store
            .set_subtask_status(
                &item_id,
                "enrich",
                "source-1",
                SubTaskStatus::completed("source-1"),
            )
            .await
            .unwrap();

        let subtasks = store.get_subtask_statuses(&item_id, "enrich").await.unwrap();
        assert_eq!(subtasks.len(), 1);
        assert_eq!(subtasks[0].state, StageState::Completed);
    }

    #[tokio::test]
    async fn test_subtasks_different_stages() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        store
            .set_subtask_status(
                &item_id,
                "enrich",
                "sub-1",
                SubTaskStatus::pending("sub-1"),
            )
            .await
            .unwrap();
        store
            .set_subtask_status(
                &item_id,
                "process",
                "sub-1",
                SubTaskStatus::completed("sub-1"),
            )
            .await
            .unwrap();

        let enrich_subtasks = store.get_subtask_statuses(&item_id, "enrich").await.unwrap();
        let process_subtasks = store.get_subtask_statuses(&item_id, "process").await.unwrap();

        assert_eq!(enrich_subtasks.len(), 1);
        assert_eq!(enrich_subtasks[0].state, StageState::Pending);
        assert_eq!(process_subtasks.len(), 1);
        assert_eq!(process_subtasks[0].state, StageState::Completed);
    }

    #[tokio::test]
    async fn test_missing_item_returns_none() {
        let store = TestStore::new();

        let status = store
            .get_status(&"nonexistent".to_string(), "scan")
            .await
            .unwrap();
        assert!(status.is_none());

        let all = store
            .get_all_statuses(&"nonexistent".to_string())
            .await
            .unwrap();
        assert!(all.is_empty());

        let subtasks = store
            .get_subtask_statuses(&"nonexistent".to_string(), "stage")
            .await
            .unwrap();
        assert!(subtasks.is_empty());
    }

    #[tokio::test]
    async fn test_clear() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        store
            .set_status(&item_id, "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_subtask_status(&item_id, "enrich", "sub-1", SubTaskStatus::pending("sub-1"))
            .await
            .unwrap();

        assert_eq!(store.stage_count().await, 1);
        assert_eq!(store.subtask_count().await, 1);

        store.clear().await;

        assert_eq!(store.stage_count().await, 0);
        assert_eq!(store.subtask_count().await, 0);
    }

    #[tokio::test]
    async fn test_concurrent_access() {
        let store = TestStore::new();
        let store = Arc::new(store);

        let mut handles = Vec::new();

        // Spawn 10 tasks writing different items
        for i in 0..10 {
            let store = Arc::clone(&store);
            let handle = tokio::spawn(async move {
                let item_id = format!("item-{}", i);
                store
                    .set_status(&item_id, "scan", StageStatus::running())
                    .await
                    .unwrap();
                store
                    .set_status(&item_id, "scan", StageStatus::completed())
                    .await
                    .unwrap();
            });
            handles.push(handle);
        }

        // Wait for all tasks
        for handle in handles {
            handle.await.unwrap();
        }

        // Verify all items were stored
        let completed = store
            .query_items("scan", StageState::Completed)
            .await
            .unwrap();
        assert_eq!(completed.len(), 10);
    }

    #[tokio::test]
    async fn test_status_with_review_data() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        let review = ReviewData::with_details(
            "Please verify entities",
            serde_json::json!({"entities": ["Person", "Place"]}),
        );
        let status = StageStatus::awaiting_review(review);

        store.set_status(&item_id, "review", status).await.unwrap();

        let retrieved = store
            .get_status(&item_id, "review")
            .await
            .unwrap()
            .unwrap();
        assert_eq!(retrieved.state, StageState::AwaitingReview);
        assert!(retrieved.review_data.is_some());
        assert_eq!(
            retrieved.review_data.unwrap().summary,
            "Please verify entities"
        );
    }

    #[tokio::test]
    async fn test_status_with_error() {
        let store = TestStore::new();
        let item_id = "item-1".to_string();

        let status = StageStatus::failed("connection timeout after 30s");
        store.set_status(&item_id, "fetch", status).await.unwrap();

        let retrieved = store
            .get_status(&item_id, "fetch")
            .await
            .unwrap()
            .unwrap();
        assert_eq!(retrieved.state, StageState::Failed);
        assert_eq!(
            retrieved.error,
            Some("connection timeout after 30s".to_string())
        );
    }

    #[tokio::test]
    async fn test_store_is_clone() {
        let store1 = TestStore::new();
        let store2 = store1.clone();

        store1
            .set_status(&"item-1".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();

        // Changes visible through clone
        let status = store2
            .get_status(&"item-1".to_string(), "scan")
            .await
            .unwrap();
        assert!(status.is_some());
    }
}
```

**Design Decisions:**
- `Arc<RwLock<Storage>>` for thread-safe concurrent access
- `Clone` on the store shares the same underlying storage
- `PhantomData<W>` to maintain generic association without storing `W`
- Separate key types for clarity and to avoid tuple confusion
- Helper methods (`stage_count`, `subtask_count`, `clear`) for testing

#### 2.1.3 Update `src/lib.rs`

```rust
mod error;
mod stage;
mod state_store;
mod work_item;

pub use error::{Result, TreadleError};
pub use stage::{
    ReviewData, Stage, StageContext, StageOutcome, StageState, StageStatus,
    SubTask, SubTaskStatus,
};
pub use state_store::{MemoryStateStore, StateStore};
pub use work_item::WorkItem;
```

### Verification Commands
```bash
cargo build
cargo test state_store::memory::tests
cargo clippy
```

---

## Milestone 2.2 — SQLite StateStore: Schema and Connection

### Files to Create/Modify
- `src/state_store/sqlite.rs` (new)
- `src/state_store/mod.rs` (update exports)

### Implementation Details

#### 2.2.1 Create `src/state_store/sqlite.rs`

```rust
//! SQLite-backed state store implementation.
//!
//! This module provides [`SqliteStateStore`], a persistent implementation
//! of [`StateStore`] backed by SQLite.

#![cfg(feature = "sqlite")]

use async_trait::async_trait;
use rusqlite::{Connection, params};
use std::collections::HashMap;
use std::path::Path;
use std::sync::Arc;
use tokio::sync::Mutex;

use crate::{Result, StageState, StageStatus, SubTaskStatus, TreadleError, WorkItem};
use super::StateStore;

/// Schema version for migrations.
const SCHEMA_VERSION: i32 = 1;

/// SQL for creating the stage_statuses table.
const CREATE_STAGE_STATUSES_TABLE: &str = r#"
    CREATE TABLE IF NOT EXISTS stage_statuses (
        item_id TEXT NOT NULL,
        stage TEXT NOT NULL,
        state TEXT NOT NULL,
        updated_at TEXT NOT NULL,
        error TEXT,
        review_data TEXT,
        PRIMARY KEY (item_id, stage)
    )
"#;

/// SQL for creating the subtask_statuses table.
const CREATE_SUBTASK_STATUSES_TABLE: &str = r#"
    CREATE TABLE IF NOT EXISTS subtask_statuses (
        item_id TEXT NOT NULL,
        stage TEXT NOT NULL,
        subtask_name TEXT NOT NULL,
        state TEXT NOT NULL,
        error TEXT,
        updated_at TEXT NOT NULL,
        PRIMARY KEY (item_id, stage, subtask_name)
    )
"#;

/// SQL for creating the schema_version table.
const CREATE_SCHEMA_VERSION_TABLE: &str = r#"
    CREATE TABLE IF NOT EXISTS schema_version (
        version INTEGER NOT NULL
    )
"#;

/// Index on stage_statuses for query_items queries.
const CREATE_STAGE_STATE_INDEX: &str = r#"
    CREATE INDEX IF NOT EXISTS idx_stage_state
    ON stage_statuses (stage, state)
"#;

/// A SQLite-backed implementation of [`StateStore`].
///
/// This store persists all workflow state to a SQLite database, making
/// it suitable for production use where state must survive process restarts.
///
/// # Thread Safety
///
/// The store wraps the SQLite connection in a `Mutex` and uses
/// `spawn_blocking` for all database operations, making it safe
/// for use in async contexts.
///
/// # Example
///
/// ```rust,ignore
/// use treadle::SqliteStateStore;
///
/// // Open or create a database file
/// let store = SqliteStateStore::open("workflow.db").await?;
///
/// // Or use an in-memory database for testing
/// let store = SqliteStateStore::open_in_memory().await?;
/// ```
pub struct SqliteStateStore {
    conn: Arc<Mutex<Connection>>,
}

impl SqliteStateStore {
    /// Opens a SQLite database at the given path.
    ///
    /// Creates the database and schema if they don't exist.
    ///
    /// # Errors
    ///
    /// Returns an error if the database cannot be opened or the
    /// schema cannot be created.
    pub async fn open(path: impl AsRef<Path>) -> Result<Self> {
        let path = path.as_ref().to_path_buf();

        let conn = tokio::task::spawn_blocking(move || {
            Connection::open(&path)
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("failed to open database: {}", e)))?;

        let store = Self {
            conn: Arc::new(Mutex::new(conn)),
        };

        store.run_migrations().await?;
        Ok(store)
    }

    /// Opens an in-memory SQLite database.
    ///
    /// Useful for testing. The database is lost when the store is dropped.
    ///
    /// # Errors
    ///
    /// Returns an error if the database cannot be created.
    pub async fn open_in_memory() -> Result<Self> {
        let conn = tokio::task::spawn_blocking(|| {
            Connection::open_in_memory()
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("failed to open in-memory database: {}", e)))?;

        let store = Self {
            conn: Arc::new(Mutex::new(conn)),
        };

        store.run_migrations().await?;
        Ok(store)
    }

    /// Runs schema migrations.
    async fn run_migrations(&self) -> Result<()> {
        let conn = Arc::clone(&self.conn);

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            // Create schema version table
            conn.execute(CREATE_SCHEMA_VERSION_TABLE, [])?;

            // Check current version
            let version: Option<i32> = conn
                .query_row(
                    "SELECT version FROM schema_version LIMIT 1",
                    [],
                    |row| row.get(0),
                )
                .ok();

            if version.is_none() || version.unwrap() < SCHEMA_VERSION {
                // Run migrations
                conn.execute(CREATE_STAGE_STATUSES_TABLE, [])?;
                conn.execute(CREATE_SUBTASK_STATUSES_TABLE, [])?;
                conn.execute(CREATE_STAGE_STATE_INDEX, [])?;

                // Update version
                conn.execute("DELETE FROM schema_version", [])?;
                conn.execute(
                    "INSERT INTO schema_version (version) VALUES (?1)",
                    params![SCHEMA_VERSION],
                )?;
            }

            Ok::<(), rusqlite::Error>(())
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("migration failed: {}", e)))?;

        Ok(())
    }

    /// Checks if the required tables exist.
    ///
    /// Useful for testing that the schema was created correctly.
    pub async fn tables_exist(&self) -> Result<bool> {
        let conn = Arc::clone(&self.conn);

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            let tables: Vec<String> = {
                let mut stmt = conn.prepare(
                    "SELECT name FROM sqlite_master WHERE type='table' AND name IN ('stage_statuses', 'subtask_statuses', 'schema_version')"
                )?;
                let rows = stmt.query_map([], |row| row.get(0))?;
                rows.filter_map(|r| r.ok()).collect()
            };

            Ok::<bool, rusqlite::Error>(tables.len() == 3)
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("table check failed: {}", e)))
    }
}

// Debug implementation that doesn't expose connection details
impl std::fmt::Debug for SqliteStateStore {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("SqliteStateStore").finish_non_exhaustive()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn test_open_in_memory() {
        let store = SqliteStateStore::open_in_memory().await;
        assert!(store.is_ok());
    }

    #[tokio::test]
    async fn test_tables_created() {
        let store = SqliteStateStore::open_in_memory().await.unwrap();
        assert!(store.tables_exist().await.unwrap());
    }

    #[tokio::test]
    async fn test_open_file_creates_db() {
        let temp_dir = std::env::temp_dir();
        let db_path = temp_dir.join(format!("treadle_test_{}.db", std::process::id()));

        // Ensure clean state
        let _ = std::fs::remove_file(&db_path);

        // Open creates the file
        let store = SqliteStateStore::open(&db_path).await.unwrap();
        assert!(store.tables_exist().await.unwrap());

        // Cleanup
        drop(store);
        let _ = std::fs::remove_file(&db_path);
    }

    #[tokio::test]
    async fn test_reopen_preserves_schema() {
        let temp_dir = std::env::temp_dir();
        let db_path = temp_dir.join(format!("treadle_test_reopen_{}.db", std::process::id()));

        let _ = std::fs::remove_file(&db_path);

        // First open
        {
            let store = SqliteStateStore::open(&db_path).await.unwrap();
            assert!(store.tables_exist().await.unwrap());
        }

        // Second open
        {
            let store = SqliteStateStore::open(&db_path).await.unwrap();
            assert!(store.tables_exist().await.unwrap());
        }

        let _ = std::fs::remove_file(&db_path);
    }
}
```

**Design Decisions:**
- `Arc<Mutex<Connection>>` for thread-safe access (rusqlite Connection is not Send)
- `spawn_blocking` for all database operations to avoid blocking async runtime
- Simple schema versioning for future migrations
- Index on `(stage, state)` for efficient `query_items` queries
- `blocking_lock()` from tokio's Mutex (designed for blocking code inside spawn_blocking)

#### 2.2.2 Update `src/state_store/mod.rs`

```rust
//! State persistence for workflow execution.

mod memory;

#[cfg(feature = "sqlite")]
mod sqlite;

pub use memory::MemoryStateStore;

#[cfg(feature = "sqlite")]
pub use sqlite::SqliteStateStore;

// ... rest of the trait definition
```

### Verification Commands
```bash
cargo build --features sqlite
cargo test state_store::sqlite::tests --features sqlite
cargo clippy --features sqlite
```

---

## Milestone 2.3 — SQLite StateStore: Full Implementation

### Files to Modify
- `src/state_store/sqlite.rs` (add StateStore impl)

### Implementation Details

#### 2.3.1 Add StateStore Implementation

Add to `src/state_store/sqlite.rs`:

```rust
/// Serializes a StageState to a string for storage.
fn state_to_string(state: StageState) -> &'static str {
    match state {
        StageState::Pending => "pending",
        StageState::Running => "running",
        StageState::Completed => "completed",
        StageState::Failed => "failed",
        StageState::AwaitingReview => "awaiting_review",
        StageState::Skipped => "skipped",
    }
}

/// Parses a StageState from a stored string.
fn string_to_state(s: &str) -> StageState {
    match s {
        "pending" => StageState::Pending,
        "running" => StageState::Running,
        "completed" => StageState::Completed,
        "failed" => StageState::Failed,
        "awaiting_review" => StageState::AwaitingReview,
        "skipped" => StageState::Skipped,
        _ => StageState::Pending, // Default fallback
    }
}

/// Serializes ReviewData to JSON string.
fn review_data_to_json(data: &crate::ReviewData) -> Result<String> {
    serde_json::to_string(data)
        .map_err(|e| TreadleError::StateStoreError(format!("failed to serialize review data: {}", e)))
}

/// Parses ReviewData from JSON string.
fn json_to_review_data(json: &str) -> Result<crate::ReviewData> {
    serde_json::from_str(json)
        .map_err(|e| TreadleError::StateStoreError(format!("failed to parse review data: {}", e)))
}

#[async_trait]
impl<W: WorkItem> StateStore<W> for SqliteStateStore {
    async fn get_status(&self, item_id: &W::Id, stage: &str) -> Result<Option<StageStatus>> {
        let conn = Arc::clone(&self.conn);
        let item_id = item_id.to_string();
        let stage = stage.to_string();

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            let result = conn.query_row(
                "SELECT state, updated_at, error, review_data FROM stage_statuses WHERE item_id = ?1 AND stage = ?2",
                params![item_id, stage],
                |row| {
                    let state_str: String = row.get(0)?;
                    let updated_at_str: String = row.get(1)?;
                    let error: Option<String> = row.get(2)?;
                    let review_data_json: Option<String> = row.get(3)?;
                    Ok((state_str, updated_at_str, error, review_data_json))
                },
            );

            match result {
                Ok((state_str, updated_at_str, error, review_data_json)) => {
                    let state = string_to_state(&state_str);
                    let updated_at = chrono::DateTime::parse_from_rfc3339(&updated_at_str)
                        .map(|dt| dt.with_timezone(&chrono::Utc))
                        .unwrap_or_else(|_| chrono::Utc::now());
                    let review_data = review_data_json
                        .as_ref()
                        .map(|json| json_to_review_data(json))
                        .transpose()?;

                    Ok(Some(StageStatus {
                        state,
                        updated_at,
                        error,
                        review_data,
                        subtasks: Vec::new(), // Subtasks loaded separately
                    }))
                }
                Err(rusqlite::Error::QueryReturnedNoRows) => Ok(None),
                Err(e) => Err(TreadleError::StateStoreError(format!("query failed: {}", e))),
            }
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
    }

    async fn set_status(&self, item_id: &W::Id, stage: &str, status: StageStatus) -> Result<()> {
        let conn = Arc::clone(&self.conn);
        let item_id = item_id.to_string();
        let stage = stage.to_string();
        let state = state_to_string(status.state);
        let updated_at = status.updated_at.to_rfc3339();
        let error = status.error;
        let review_data_json = status.review_data
            .as_ref()
            .map(review_data_to_json)
            .transpose()?;

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            conn.execute(
                "INSERT OR REPLACE INTO stage_statuses (item_id, stage, state, updated_at, error, review_data) VALUES (?1, ?2, ?3, ?4, ?5, ?6)",
                params![item_id, stage, state, updated_at, error, review_data_json],
            )?;

            Ok::<(), rusqlite::Error>(())
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("insert failed: {}", e)))?;

        Ok(())
    }

    async fn get_all_statuses(&self, item_id: &W::Id) -> Result<HashMap<String, StageStatus>> {
        let conn = Arc::clone(&self.conn);
        let item_id = item_id.to_string();

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            let mut stmt = conn.prepare(
                "SELECT stage, state, updated_at, error, review_data FROM stage_statuses WHERE item_id = ?1"
            )?;

            let rows = stmt.query_map(params![item_id], |row| {
                let stage: String = row.get(0)?;
                let state_str: String = row.get(1)?;
                let updated_at_str: String = row.get(2)?;
                let error: Option<String> = row.get(3)?;
                let review_data_json: Option<String> = row.get(4)?;
                Ok((stage, state_str, updated_at_str, error, review_data_json))
            })?;

            let mut result = HashMap::new();
            for row in rows {
                let (stage, state_str, updated_at_str, error, review_data_json) = row?;
                let state = string_to_state(&state_str);
                let updated_at = chrono::DateTime::parse_from_rfc3339(&updated_at_str)
                    .map(|dt| dt.with_timezone(&chrono::Utc))
                    .unwrap_or_else(|_| chrono::Utc::now());
                let review_data = review_data_json
                    .as_ref()
                    .map(|json| serde_json::from_str(json))
                    .transpose()
                    .ok()
                    .flatten();

                result.insert(stage, StageStatus {
                    state,
                    updated_at,
                    error,
                    review_data,
                    subtasks: Vec::new(),
                });
            }

            Ok::<HashMap<String, StageStatus>, rusqlite::Error>(result)
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("query failed: {}", e)))
    }

    async fn query_items(&self, stage: &str, state: StageState) -> Result<Vec<String>> {
        let conn = Arc::clone(&self.conn);
        let stage = stage.to_string();
        let state_str = state_to_string(state).to_string();

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            let mut stmt = conn.prepare(
                "SELECT item_id FROM stage_statuses WHERE stage = ?1 AND state = ?2"
            )?;

            let rows = stmt.query_map(params![stage, state_str], |row| {
                row.get(0)
            })?;

            let result: std::result::Result<Vec<String>, _> = rows.collect();
            result
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("query failed: {}", e)))
    }

    async fn get_subtask_statuses(
        &self,
        item_id: &W::Id,
        stage: &str,
    ) -> Result<Vec<SubTaskStatus>> {
        let conn = Arc::clone(&self.conn);
        let item_id = item_id.to_string();
        let stage = stage.to_string();

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            let mut stmt = conn.prepare(
                "SELECT subtask_name, state, error, updated_at FROM subtask_statuses WHERE item_id = ?1 AND stage = ?2"
            )?;

            let rows = stmt.query_map(params![item_id, stage], |row| {
                let name: String = row.get(0)?;
                let state_str: String = row.get(1)?;
                let error: Option<String> = row.get(2)?;
                let updated_at_str: String = row.get(3)?;
                Ok((name, state_str, error, updated_at_str))
            })?;

            let mut result = Vec::new();
            for row in rows {
                let (name, state_str, error, updated_at_str) = row?;
                let state = string_to_state(&state_str);
                let updated_at = chrono::DateTime::parse_from_rfc3339(&updated_at_str)
                    .map(|dt| dt.with_timezone(&chrono::Utc))
                    .unwrap_or_else(|_| chrono::Utc::now());

                result.push(SubTaskStatus {
                    name,
                    state,
                    error,
                    updated_at,
                });
            }

            Ok::<Vec<SubTaskStatus>, rusqlite::Error>(result)
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("query failed: {}", e)))
    }

    async fn set_subtask_status(
        &self,
        item_id: &W::Id,
        stage: &str,
        subtask: &str,
        status: SubTaskStatus,
    ) -> Result<()> {
        let conn = Arc::clone(&self.conn);
        let item_id = item_id.to_string();
        let stage = stage.to_string();
        let subtask = subtask.to_string();
        let state = state_to_string(status.state);
        let updated_at = status.updated_at.to_rfc3339();
        let error = status.error;

        tokio::task::spawn_blocking(move || {
            let conn = conn.blocking_lock();

            conn.execute(
                "INSERT OR REPLACE INTO subtask_statuses (item_id, stage, subtask_name, state, error, updated_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6)",
                params![item_id, stage, subtask, state, error, updated_at],
            )?;

            Ok::<(), rusqlite::Error>(())
        })
        .await
        .map_err(|e| TreadleError::StateStoreError(format!("spawn_blocking failed: {}", e)))?
        .map_err(|e| TreadleError::StateStoreError(format!("insert failed: {}", e)))?;

        Ok(())
    }
}

// Additional tests for full implementation
#[cfg(test)]
mod full_tests {
    use super::*;
    use crate::work_item::test_helpers::TestItem;
    use crate::ReviewData;

    type TestStore = SqliteStateStore;

    #[tokio::test]
    async fn test_set_and_get_status() {
        let store = TestStore::open_in_memory().await.unwrap();
        let item_id = "item-1".to_string();

        let status = store.get_status::<TestItem>(&item_id, "scan").await.unwrap();
        assert!(status.is_none());

        store
            .set_status::<TestItem>(&item_id, "scan", StageStatus::running())
            .await
            .unwrap();

        let status = store.get_status::<TestItem>(&item_id, "scan").await.unwrap();
        assert!(status.is_some());
        assert_eq!(status.unwrap().state, StageState::Running);
    }

    #[tokio::test]
    async fn test_get_all_statuses() {
        let store = TestStore::open_in_memory().await.unwrap();
        let item_id = "item-1".to_string();

        store
            .set_status::<TestItem>(&item_id, "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status::<TestItem>(&item_id, "enrich", StageStatus::running())
            .await
            .unwrap();

        let all = store.get_all_statuses::<TestItem>(&item_id).await.unwrap();
        assert_eq!(all.len(), 2);
        assert_eq!(all.get("scan").unwrap().state, StageState::Completed);
        assert_eq!(all.get("enrich").unwrap().state, StageState::Running);
    }

    #[tokio::test]
    async fn test_query_items() {
        let store = TestStore::open_in_memory().await.unwrap();

        store
            .set_status::<TestItem>(&"item-1".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status::<TestItem>(&"item-2".to_string(), "scan", StageStatus::completed())
            .await
            .unwrap();
        store
            .set_status::<TestItem>(&"item-3".to_string(), "scan", StageStatus::pending())
            .await
            .unwrap();

        let completed = store
            .query_items::<TestItem>("scan", StageState::Completed)
            .await
            .unwrap();
        assert_eq!(completed.len(), 2);

        let pending = store
            .query_items::<TestItem>("scan", StageState::Pending)
            .await
            .unwrap();
        assert_eq!(pending.len(), 1);
    }

    #[tokio::test]
    async fn test_subtask_status() {
        let store = TestStore::open_in_memory().await.unwrap();
        let item_id = "item-1".to_string();

        store
            .set_subtask_status::<TestItem>(
                &item_id,
                "enrich",
                "source-1",
                SubTaskStatus::pending("source-1"),
            )
            .await
            .unwrap();
        store
            .set_subtask_status::<TestItem>(
                &item_id,
                "enrich",
                "source-2",
                SubTaskStatus::completed("source-2"),
            )
            .await
            .unwrap();

        let subtasks = store
            .get_subtask_statuses::<TestItem>(&item_id, "enrich")
            .await
            .unwrap();
        assert_eq!(subtasks.len(), 2);
    }

    #[tokio::test]
    async fn test_status_with_review_data() {
        let store = TestStore::open_in_memory().await.unwrap();
        let item_id = "item-1".to_string();

        let review = ReviewData::with_details(
            "Please verify",
            serde_json::json!({"key": "value"}),
        );
        let status = StageStatus::awaiting_review(review);

        store
            .set_status::<TestItem>(&item_id, "review", status)
            .await
            .unwrap();

        let retrieved = store
            .get_status::<TestItem>(&item_id, "review")
            .await
            .unwrap()
            .unwrap();

        assert_eq!(retrieved.state, StageState::AwaitingReview);
        assert!(retrieved.review_data.is_some());
        assert_eq!(retrieved.review_data.unwrap().summary, "Please verify");
    }

    #[tokio::test]
    async fn test_persistence_across_reopens() {
        let temp_dir = std::env::temp_dir();
        let db_path = temp_dir.join(format!("treadle_persist_test_{}.db", std::process::id()));

        let _ = std::fs::remove_file(&db_path);

        // Write data
        {
            let store = TestStore::open(&db_path).await.unwrap();
            store
                .set_status::<TestItem>(
                    &"item-1".to_string(),
                    "scan",
                    StageStatus::completed(),
                )
                .await
                .unwrap();
        }

        // Read after reopen
        {
            let store = TestStore::open(&db_path).await.unwrap();
            let status = store
                .get_status::<TestItem>(&"item-1".to_string(), "scan")
                .await
                .unwrap();

            assert!(status.is_some());
            assert_eq!(status.unwrap().state, StageState::Completed);
        }

        let _ = std::fs::remove_file(&db_path);
    }

    #[tokio::test]
    async fn test_status_with_error() {
        let store = TestStore::open_in_memory().await.unwrap();
        let item_id = "item-1".to_string();

        let status = StageStatus::failed("connection timeout");
        store
            .set_status::<TestItem>(&item_id, "fetch", status)
            .await
            .unwrap();

        let retrieved = store
            .get_status::<TestItem>(&item_id, "fetch")
            .await
            .unwrap()
            .unwrap();

        assert_eq!(retrieved.state, StageState::Failed);
        assert_eq!(retrieved.error, Some("connection timeout".to_string()));
    }
}
```

**Design Decisions:**
- RFC 3339 format for datetime storage (ISO 8601 compatible)
- JSON serialization for ReviewData (flexible schema)
- `INSERT OR REPLACE` for upsert behavior
- Subtasks not auto-loaded with stage status (loaded separately when needed)

### Verification Commands
```bash
cargo build --features sqlite
cargo test state_store::sqlite --features sqlite
cargo clippy --features sqlite
```

---

## Milestone 2.4 — Re-exports and Module Organization

### Files to Modify
- `src/lib.rs` (final exports)
- `src/state_store/mod.rs` (final organization)

### Implementation Details

#### 2.4.1 Final `src/lib.rs`

```rust
//! # Treadle
//!
//! A persistent, resumable, human-in-the-loop workflow engine backed by a
//! [petgraph](https://docs.rs/petgraph) DAG.
//!
//! Treadle fills the gap between single-shot DAG executors and heavyweight
//! distributed workflow engines. It is designed for **local, single-process
//! pipelines** where:
//!
//! - Work items progress through a DAG of stages over time
//! - Each item's state is tracked persistently (survives restarts)
//! - Stages can pause for human review and resume later
//! - Fan-out stages track each subtask independently
//! - The full pipeline is inspectable at any moment
//!
//! ## Quick Start
//!
//! ```rust,ignore
//! use treadle::{Stage, StageOutcome, StageContext, Result, WorkItem};
//!
//! // Define your work item
//! #[derive(Debug, Clone)]
//! struct Document {
//!     id: String,
//!     content: String,
//! }
//!
//! impl WorkItem for Document {
//!     type Id = String;
//!     fn id(&self) -> &Self::Id { &self.id }
//! }
//!
//! // Define a stage
//! struct ScanStage;
//!
//! #[async_trait::async_trait]
//! impl Stage<Document> for ScanStage {
//!     fn name(&self) -> &str { "scan" }
//!
//!     async fn execute(&self, doc: &Document, ctx: &StageContext) -> Result<StageOutcome> {
//!         println!("Scanning document: {}", doc.id);
//!         Ok(StageOutcome::Completed)
//!     }
//! }
//! ```
//!
//! ## Feature Flags
//!
//! - `sqlite` (default): Enables [`SqliteStateStore`] for persistent storage

#![warn(missing_docs)]
#![warn(rustdoc::missing_crate_level_docs)]
#![forbid(unsafe_code)]

mod error;
mod stage;
mod state_store;
mod work_item;

// Error types
pub use error::{Result, TreadleError};

// Stage types and traits
pub use stage::{
    ReviewData, Stage, StageContext, StageOutcome, StageState, StageStatus,
    SubTask, SubTaskStatus,
};

// State store trait and implementations
pub use state_store::{MemoryStateStore, StateStore};

#[cfg(feature = "sqlite")]
pub use state_store::SqliteStateStore;

// Work item trait
pub use work_item::WorkItem;

/// Returns the crate version.
pub fn version() -> &'static str {
    env!("CARGO_PKG_VERSION")
}

#[cfg(test)]
mod api_tests {
    //! Tests verifying the public API surface.

    use super::*;

    #[test]
    fn test_version() {
        assert!(!version().is_empty());
    }

    #[test]
    fn test_public_types_are_exported() {
        // This test verifies that all expected types are publicly accessible.
        // If any of these fail to compile, the export is missing.
        fn _assert_exported() {
            let _: Option<TreadleError> = None;
            let _: Result<()> = Ok(());
            let _: StageState = StageState::Pending;
            let _: StageOutcome = StageOutcome::Completed;
            let _: StageStatus = StageStatus::pending();
            let _: ReviewData = ReviewData::new("test");
            let _: SubTask = SubTask::new("test");
            let _: SubTaskStatus = SubTaskStatus::pending("test");
            let _: StageContext = StageContext::new("item", "stage");
        }
    }

    #[test]
    fn test_memory_store_exported() {
        fn _assert_exported<W: WorkItem>() {
            let _store: MemoryStateStore<W>;
        }
    }

    #[cfg(feature = "sqlite")]
    #[test]
    fn test_sqlite_store_exported() {
        fn _assert_exported() {
            // SqliteStateStore is not generic, just needs to exist
            let _: Option<SqliteStateStore> = None;
        }
    }
}
```

#### 2.4.2 Final `src/state_store/mod.rs`

```rust
//! State persistence for workflow execution.
//!
//! This module provides the [`StateStore`] trait for persisting workflow
//! execution state, along with implementations:
//!
//! - [`MemoryStateStore`]: In-memory storage for testing
//! - [`SqliteStateStore`]: SQLite-backed persistent storage (requires `sqlite` feature)
//!
//! # Example
//!
//! ```rust
//! use treadle::{MemoryStateStore, StateStore, StageStatus, WorkItem};
//!
//! #[derive(Debug, Clone)]
//! struct MyItem { id: String }
//!
//! impl WorkItem for MyItem {
//!     type Id = String;
//!     fn id(&self) -> &Self::Id { &self.id }
//! }
//!
//! # async fn example() -> treadle::Result<()> {
//! let store = MemoryStateStore::<MyItem>::new();
//!
//! // Store and retrieve status
//! store.set_status(&"item-1".to_string(), "scan", StageStatus::completed()).await?;
//! let status = store.get_status(&"item-1".to_string(), "scan").await?;
//! # Ok(())
//! # }
//! ```

mod memory;

#[cfg(feature = "sqlite")]
mod sqlite;

pub use memory::MemoryStateStore;

#[cfg(feature = "sqlite")]
pub use sqlite::SqliteStateStore;

use async_trait::async_trait;
use std::collections::HashMap;

use crate::{Result, StageState, StageStatus, SubTaskStatus, WorkItem};

/// A persistent store for workflow execution state.
///
/// The `StateStore` trait abstracts over different storage backends
/// (in-memory, SQLite, etc.) for persisting the execution state of
/// work items as they progress through a workflow.
///
/// # Implementation Notes
///
/// - All methods are async to support both sync and async backends
/// - Implementations must be thread-safe (`Send + Sync`)
/// - Item IDs are serialized to strings using the `Display` trait
///
/// # Example Implementation
///
/// See [`MemoryStateStore`] for a reference implementation.
#[async_trait]
pub trait StateStore<W: WorkItem>: Send + Sync {
    /// Retrieves the status of a stage for a work item.
    ///
    /// Returns `Ok(None)` if no status has been recorded for this stage.
    async fn get_status(&self, item_id: &W::Id, stage: &str) -> Result<Option<StageStatus>>;

    /// Sets the status of a stage for a work item.
    ///
    /// This overwrites any existing status for the stage.
    async fn set_status(&self, item_id: &W::Id, stage: &str, status: StageStatus) -> Result<()>;

    /// Retrieves all stage statuses for a work item.
    ///
    /// Returns a map from stage name to status.
    async fn get_all_statuses(&self, item_id: &W::Id) -> Result<HashMap<String, StageStatus>>;

    /// Queries for work items in a specific state for a stage.
    ///
    /// Returns work item IDs as strings.
    async fn query_items(&self, stage: &str, state: StageState) -> Result<Vec<String>>;

    /// Retrieves all subtask statuses for a fan-out stage.
    async fn get_subtask_statuses(
        &self,
        item_id: &W::Id,
        stage: &str,
    ) -> Result<Vec<SubTaskStatus>>;

    /// Sets the status of a specific subtask.
    async fn set_subtask_status(
        &self,
        item_id: &W::Id,
        stage: &str,
        subtask: &str,
        status: SubTaskStatus,
    ) -> Result<()>;
}
```

### Verification Commands
```bash
# Test with all features
cargo build --all-features
cargo test --all-features
cargo clippy --all-features

# Test without sqlite feature
cargo build --no-default-features
cargo test --no-default-features

# Generate and verify documentation
cargo doc --no-deps --open
```

---

## Phase 2 Completion Checklist

- [ ] `cargo build --all-features` succeeds
- [ ] `cargo test --all-features` passes
- [ ] `cargo build --no-default-features` succeeds (no sqlite)
- [ ] `cargo test --no-default-features` passes
- [ ] `cargo clippy --all-features -- -D warnings` clean
- [ ] `cargo doc --no-deps` builds without warnings

### Public API After Phase 2

```rust
// Previously from Phase 1
treadle::TreadleError
treadle::Result<T>
treadle::WorkItem
treadle::Stage
treadle::StageContext
treadle::StageState
treadle::StageStatus
treadle::StageOutcome
treadle::SubTask
treadle::SubTaskStatus
treadle::ReviewData

// New in Phase 2
treadle::StateStore          // Trait
treadle::MemoryStateStore    // Implementation
treadle::SqliteStateStore    // Implementation (feature = "sqlite")
```

---

## Architecture After Phase 2

```
src/
├── lib.rs                  # Crate root, re-exports
├── error.rs                # TreadleError, Result
├── work_item.rs            # WorkItem trait
├── stage.rs                # Stage types and trait
└── state_store/
    ├── mod.rs              # StateStore trait, re-exports
    ├── memory.rs           # MemoryStateStore
    └── sqlite.rs           # SqliteStateStore (#[cfg(feature = "sqlite")])
```