travelagent-forge-github 1.10.2

GitHub forge backend for travelagent
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
use wiremock::matchers::{header, method, path};
use wiremock::{Mock, MockServer, ResponseTemplate};

use travelagent_core::error::TrvError;
use travelagent_core::forge::*;
use travelagent_forge_github::GitHubForge;

fn test_pr_id() -> PrId {
    PrId {
        owner: "octocat".into(),
        repo: "hello-world".into(),
        number: 42,
    }
}

async fn setup() -> (MockServer, GitHubForge) {
    let server = MockServer::start().await;
    // Wiremock listens on http://127.0.0.1:PORT which the production
    // `with_token` rejects (non-https / loopback). Use the explicit
    // insecure builder for tests.
    let forge = GitHubForge::with_token_insecure(&server.uri(), "test-token".into()).unwrap();
    (server, forge)
}

#[tokio::test]
async fn get_pr_returns_metadata() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42"))
        .and(header("authorization", "Bearer test-token"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "number": 42,
            "title": "Amazing feature",
            "body": "This is the PR body",
            "state": "open",
            "draft": false,
            "merged_at": null,
            "user": { "login": "alice", "id": 1 },
            "base": { "ref": "main", "sha": "base123" },
            "head": { "ref": "feat-branch", "sha": "head456" },
            "created_at": "2024-06-15T10:30:00Z",
            "mergeable_state": "clean",
            "mergeable": true
        })))
        .mount(&server)
        .await;

    let pr = forge.get_pr(&test_pr_id()).await.unwrap();
    assert_eq!(pr.title, "Amazing feature");
    assert_eq!(pr.body, "This is the PR body");
    assert_eq!(pr.author, "alice");
    assert_eq!(pr.state, PrState::Open);
    assert_eq!(pr.base_branch, "main");
    assert_eq!(pr.head_branch, "feat-branch");
    assert_eq!(pr.mergeable, Some(MergeableStatus::Clean));
    assert!(!pr.is_draft);
}

#[tokio::test]
async fn get_pr_merged_state() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "number": 42,
            "title": "Merged PR",
            "body": null,
            "state": "closed",
            "draft": null,
            "merged_at": "2024-06-16T12:00:00Z",
            "user": { "login": "bob", "id": 2 },
            "base": { "ref": "main", "sha": "aaa" },
            "head": { "ref": "fix", "sha": "bbb" },
            "created_at": "2024-06-15T10:30:00Z",
            "mergeable_state": null,
            "mergeable": null
        })))
        .mount(&server)
        .await;

    let pr = forge.get_pr(&test_pr_id()).await.unwrap();
    assert_eq!(pr.state, PrState::Merged);
    assert_eq!(pr.body, "");
}

#[tokio::test]
async fn get_pr_commits_with_pagination() {
    let (server, forge) = setup().await;

    let page2_url = format!(
        "{}/repos/octocat/hello-world/pulls/42/commits?per_page=100&page=2",
        server.uri()
    );

    // Page 2 (no Link header = last page) - mount FIRST so page 1 (mounted later) takes priority
    // for requests without page=2. Wiremock checks last-mounted first, but the more-specific
    // page 2 mock needs to be checked when page=2 is present.
    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42/commits"))
        .and(wiremock::matchers::query_param("page", "2"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([
            {
                "sha": "commit2sha000000000000000000000000000000",
                "commit": {
                    "message": "Second commit\n\nWith a body",
                    "author": { "name": "Bob", "date": "2024-06-15T11:00:00Z" }
                },
                "author": { "login": "bob", "id": 2 }
            }
        ])))
        .mount(&server)
        .await;

    // Page 1 with Link header pointing to page 2 - mount LAST so it is checked first by wiremock.
    // When the request has page=2, this mock also matches (it doesn't filter on query params),
    // but because it's checked first and the page 2 mock is more specific, we use up(1) to
    // limit it to a single match. Actually, wiremock checks last-mounted first, so this
    // (mounted last) is checked first for ALL requests. We need the opposite: page 2 should
    // be checked first. So we mount page 1 FIRST and page 2 LAST.
    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42/commits"))
        .respond_with(
            ResponseTemplate::new(200)
                .append_header("link", &format!("<{page2_url}>; rel=\"next\""))
                .set_body_json(serde_json::json!([
                    {
                        "sha": "commit1sha000000000000000000000000000000",
                        "commit": {
                            "message": "First commit",
                            "author": { "name": "Alice", "date": "2024-06-15T10:00:00Z" }
                        },
                        "author": { "login": "alice", "id": 1 }
                    }
                ])),
        )
        .up_to_n_times(1)
        .mount(&server)
        .await;

    let commits = forge.get_pr_commits(&test_pr_id()).await.unwrap();
    assert_eq!(commits.len(), 2);
    assert_eq!(commits[0].summary, "First commit");
    assert_eq!(commits[0].author, "alice");
    assert_eq!(commits[0].short_id, "commit1");
    assert_eq!(commits[1].summary, "Second commit");
    assert_eq!(commits[1].body, Some("With a body".into()));
    assert_eq!(commits[1].author, "bob");
}

#[tokio::test]
async fn get_comments_returns_review_comments() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42/comments"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([
            {
                "id": 100,
                "body": "Looks good here",
                "path": "src/main.rs",
                "line": 10,
                "start_line": null,
                "side": "RIGHT",
                "start_side": null,
                "commit_id": "abc123",
                "user": { "login": "reviewer", "id": 5 },
                "created_at": "2024-06-15T12:00:00Z",
                "in_reply_to_id": null
            },
            {
                "id": 101,
                "body": "Reply to above",
                "path": "src/main.rs",
                "line": 10,
                "start_line": null,
                "side": "RIGHT",
                "start_side": null,
                "commit_id": "abc123",
                "user": { "login": "author", "id": 1 },
                "created_at": "2024-06-15T13:00:00Z",
                "in_reply_to_id": 100
            }
        ])))
        .mount(&server)
        .await;

    // Also mock the issue comments endpoint (empty for this test)
    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/issues/42/comments"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([])))
        .mount(&server)
        .await;

    let comments = forge.get_comments(&test_pr_id()).await.unwrap();
    assert_eq!(comments.len(), 2);
    assert_eq!(comments[0].id, 100);
    assert_eq!(comments[0].author, "reviewer");
    assert_eq!(comments[0].body, "Looks good here");
    assert_eq!(comments[0].path, Some("src/main.rs".into()));
    assert_eq!(comments[0].line, Some(10));
    assert_eq!(comments[0].in_reply_to, None);
    assert_eq!(comments[1].id, 101);
    assert_eq!(comments[1].in_reply_to, Some(100));
}

#[tokio::test]
async fn current_user_returns_user() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/user"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "login": "octocat",
            "id": 42
        })))
        .mount(&server)
        .await;

    let user = forge.current_user().await.unwrap();
    assert_eq!(user.login, "octocat");
    assert_eq!(user.id, 42);
}

#[tokio::test]
async fn get_pr_returns_not_found_on_404() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42"))
        .respond_with(ResponseTemplate::new(404))
        .mount(&server)
        .await;

    let err = forge.get_pr(&test_pr_id()).await.unwrap_err();
    assert!(matches!(err, TrvError::NotFound(_)));
}

#[tokio::test]
async fn get_pr_returns_auth_error_on_401() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42"))
        .respond_with(ResponseTemplate::new(401))
        .mount(&server)
        .await;

    let err = forge.get_pr(&test_pr_id()).await.unwrap_err();
    assert!(matches!(err, TrvError::AuthError(_)));
}

#[tokio::test]
async fn get_pr_returns_rate_limited_on_403_with_header() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42"))
        .respond_with(ResponseTemplate::new(403).append_header("x-ratelimit-remaining", "0"))
        .mount(&server)
        .await;

    let err = forge.get_pr(&test_pr_id()).await.unwrap_err();
    assert!(matches!(err, TrvError::RateLimited));
}

#[tokio::test]
async fn check_permissions_parses_repo_response() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "permissions": {
                "push": true,
                "maintain": false,
                "admin": false
            },
            "allow_merge_commit": true,
            "allow_squash_merge": true,
            "allow_rebase_merge": false
        })))
        .mount(&server)
        .await;

    let perms = forge.check_permissions(&test_pr_id()).await.unwrap();
    assert!(perms.can_push);
    assert!(!perms.can_merge);
    assert_eq!(perms.allowed_merge_methods.len(), 2);
    assert!(perms.allowed_merge_methods.contains(&MergeMethod::Merge));
    assert!(perms.allowed_merge_methods.contains(&MergeMethod::Squash));
    assert!(!perms.allowed_merge_methods.contains(&MergeMethod::Rebase));
}

#[tokio::test]
async fn get_pr_files_parses_patches() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls/42/files"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([
            {
                "filename": "src/lib.rs",
                "status": "modified",
                "additions": 2,
                "deletions": 1,
                "patch": "@@ -1,3 +1,4 @@\n fn main() {\n-    old();\n+    new();\n+    extra();\n }",
                "previous_filename": null
            },
            {
                "filename": "new_file.rs",
                "status": "added",
                "additions": 3,
                "deletions": 0,
                "patch": "@@ -0,0 +1,3 @@\n+line1\n+line2\n+line3",
                "previous_filename": null
            }
        ])))
        .mount(&server)
        .await;

    let files = forge.get_pr_files(&test_pr_id()).await.unwrap();
    assert_eq!(files.len(), 2);

    // First file: modified
    assert_eq!(
        files[0].new_path,
        Some(std::path::PathBuf::from("src/lib.rs"))
    );
    assert_eq!(
        files[0].status,
        travelagent_core::model::FileStatus::Modified
    );
    assert_eq!(files[0].hunks.len(), 1);
    assert_eq!(files[0].hunks[0].lines.len(), 5);

    // Second file: added
    assert_eq!(
        files[1].new_path,
        Some(std::path::PathBuf::from("new_file.rs"))
    );
    assert_eq!(files[1].status, travelagent_core::model::FileStatus::Added);
    assert!(files[1].old_path.is_none());
    assert_eq!(files[1].hunks[0].lines.len(), 3);
}

#[tokio::test]
async fn forge_type_is_github() {
    let (_, forge) = setup().await;
    assert_eq!(forge.forge_type(), ForgeType::GitHub);
}

#[tokio::test]
async fn list_prs_returns_open_rows_with_review_request_flag() {
    let (server, forge) = setup().await;

    // Our user is "bob" so rows that include bob in requested_reviewers must
    // flip has_review_requested_from_me to true.
    Mock::given(method("GET"))
        .and(path("/user"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "login": "bob",
            "id": 2
        })))
        .mount(&server)
        .await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls"))
        .and(wiremock::matchers::query_param("state", "open"))
        .and(wiremock::matchers::query_param("sort", "updated"))
        .and(wiremock::matchers::query_param("direction", "desc"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([
            {
                "number": 101,
                "title": "Add thing",
                "state": "open",
                "draft": false,
                "merged_at": null,
                "user": { "login": "alice", "id": 1 },
                "base": { "ref": "main", "sha": "aaa" },
                "head": { "ref": "feat", "sha": "bbb" },
                "updated_at": "2024-06-15T10:30:00Z",
                "requested_reviewers": [{ "login": "bob", "id": 2 }],
                "comments": 1,
                "review_comments": 2
            },
            {
                "number": 102,
                "title": "Fix nit",
                "state": "open",
                "draft": true,
                "merged_at": null,
                "user": { "login": "alice", "id": 1 },
                "base": { "ref": "main", "sha": "aaa" },
                "head": { "ref": "nit", "sha": "ccc" },
                "updated_at": "2024-06-14T08:00:00Z",
                "requested_reviewers": [],
                "comments": 0,
                "review_comments": 0
            }
        ])))
        .mount(&server)
        .await;

    let filter = PrListFilter::default();
    let items = forge
        .list_prs("octocat", "hello-world", &filter)
        .await
        .unwrap();
    assert_eq!(items.len(), 2);
    assert_eq!(items[0].number, 101);
    assert_eq!(items[0].comment_count, 3);
    assert!(items[0].has_review_requested_from_me);
    assert_eq!(items[1].number, 102);
    assert!(items[1].is_draft);
    assert!(!items[1].has_review_requested_from_me);
}

#[tokio::test]
async fn list_prs_max_caps_items_returned() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/user"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "login": "anyone",
            "id": 9
        })))
        .mount(&server)
        .await;

    let rows: Vec<serde_json::Value> = (1..=10)
        .map(|i| {
            serde_json::json!({
                "number": i,
                "title": format!("PR {i}"),
                "state": "open",
                "draft": false,
                "merged_at": null,
                "user": { "login": "alice", "id": 1 },
                "base": { "ref": "main", "sha": "aaa" },
                "head": { "ref": format!("feat-{i}"), "sha": "bbb" },
                "updated_at": "2024-06-15T10:30:00Z",
                "requested_reviewers": [],
                "comments": 0,
                "review_comments": 0
            })
        })
        .collect();

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls"))
        .respond_with(ResponseTemplate::new(200).set_body_json(rows))
        .mount(&server)
        .await;

    let filter = PrListFilter {
        max: Some(3),
        ..PrListFilter::default()
    };
    let items = forge
        .list_prs("octocat", "hello-world", &filter)
        .await
        .unwrap();
    assert_eq!(items.len(), 3);
}

#[tokio::test]
async fn list_prs_client_side_author_filter_is_case_insensitive() {
    let (server, forge) = setup().await;

    Mock::given(method("GET"))
        .and(path("/user"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "login": "reader",
            "id": 1
        })))
        .mount(&server)
        .await;

    Mock::given(method("GET"))
        .and(path("/repos/octocat/hello-world/pulls"))
        .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!([
            {
                "number": 1,
                "title": "By alice",
                "state": "open",
                "draft": false,
                "merged_at": null,
                "user": { "login": "Alice", "id": 1 },
                "base": { "ref": "main", "sha": "aaa" },
                "head": { "ref": "feat", "sha": "bbb" },
                "updated_at": "2024-06-15T10:30:00Z",
                "requested_reviewers": [],
                "comments": 0,
                "review_comments": 0
            },
            {
                "number": 2,
                "title": "By bob",
                "state": "open",
                "draft": false,
                "merged_at": null,
                "user": { "login": "bob", "id": 2 },
                "base": { "ref": "main", "sha": "aaa" },
                "head": { "ref": "feat2", "sha": "ccc" },
                "updated_at": "2024-06-15T10:30:00Z",
                "requested_reviewers": [],
                "comments": 0,
                "review_comments": 0
            }
        ])))
        .mount(&server)
        .await;

    let filter = PrListFilter {
        author: Some("alice".into()),
        ..PrListFilter::default()
    };
    let items = forge
        .list_prs("octocat", "hello-world", &filter)
        .await
        .unwrap();
    assert_eq!(items.len(), 1);
    assert_eq!(items[0].author, "Alice");
}