torsh-series 0.1.2

Time series analysis components for ToRSh - powered by SciRS2
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
//! Outlier detection and treatment for time series
//!
//! This module provides various methods for detecting and treating outliers in time series data.
//! Outliers can significantly impact time series analysis and forecasting, so proper handling
//! is essential for robust models.

use crate::TimeSeries;
use scirs2_core::random::{thread_rng, Distribution, Uniform};
use torsh_core::error::Result;
use torsh_tensor::Tensor;

/// Outlier detection method
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum OutlierMethod {
    /// Interquartile Range (IQR) method
    /// Outliers are values outside [Q1 - k*IQR, Q3 + k*IQR]
    IQR,
    /// Z-score method
    /// Outliers are values with |z-score| > threshold
    ZScore,
    /// Modified Z-score using median absolute deviation
    /// More robust to outliers than standard Z-score
    ModifiedZScore,
    /// Isolation Forest
    /// Uses random forests to identify anomalous points
    IsolationForest,
}

/// Outlier treatment strategy
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum OutlierTreatment {
    /// Remove outliers from the series
    Remove,
    /// Replace outliers with mean
    Mean,
    /// Replace outliers with median
    Median,
    /// Replace outliers with nearest non-outlier value
    Clip,
    /// Replace outliers with interpolated values
    Interpolate,
}

/// Outlier detection result
#[derive(Debug, Clone)]
pub struct OutlierDetectionResult {
    /// Indices of detected outliers
    pub outlier_indices: Vec<usize>,
    /// Outlier values
    pub outlier_values: Vec<f32>,
    /// Outlier scores (method-dependent)
    pub scores: Vec<f64>,
    /// Detection method used
    pub method: OutlierMethod,
}

/// Outlier detector
pub struct OutlierDetector {
    method: OutlierMethod,
    threshold: f64,
}

impl OutlierDetector {
    /// Create a new outlier detector
    ///
    /// # Arguments
    /// * `method` - Detection method to use
    /// * `threshold` - Threshold parameter (interpretation depends on method)
    ///   - IQR: multiplier for IQR (typically 1.5)
    ///   - ZScore: maximum absolute z-score (typically 3.0)
    ///   - ModifiedZScore: maximum modified z-score (typically 3.5)
    ///   - IsolationForest: contamination rate (typically 0.1)
    pub fn new(method: OutlierMethod, threshold: f64) -> Self {
        Self { method, threshold }
    }

    /// Detect outliers in a time series
    pub fn detect(&self, series: &TimeSeries) -> Result<OutlierDetectionResult> {
        match self.method {
            OutlierMethod::IQR => self.detect_iqr(series),
            OutlierMethod::ZScore => self.detect_zscore(series),
            OutlierMethod::ModifiedZScore => self.detect_modified_zscore(series),
            OutlierMethod::IsolationForest => self.detect_isolation_forest(series),
        }
    }

    /// Detect outliers using IQR method
    fn detect_iqr(&self, series: &TimeSeries) -> Result<OutlierDetectionResult> {
        let data = series.values.to_vec()?;
        let n = data.len();

        if n < 4 {
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::IQR,
            });
        }

        // Sort data to compute quantiles
        let mut sorted_data = data.clone();
        sorted_data.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));

        // Compute Q1 (25th percentile) and Q3 (75th percentile)
        let q1_idx = n / 4;
        let q3_idx = (3 * n) / 4;
        let q1 = sorted_data[q1_idx] as f64;
        let q3 = sorted_data[q3_idx] as f64;

        // Compute IQR
        let iqr = q3 - q1;

        // Compute bounds
        let lower_bound = q1 - self.threshold * iqr;
        let upper_bound = q3 + self.threshold * iqr;

        // Find outliers
        let mut outlier_indices = Vec::new();
        let mut outlier_values = Vec::new();
        let mut scores = Vec::new();

        for (i, &value) in data.iter().enumerate() {
            let v = value as f64;
            if v < lower_bound || v > upper_bound {
                outlier_indices.push(i);
                outlier_values.push(value);
                // Score is distance from nearest bound in units of IQR
                let score = if v < lower_bound {
                    (lower_bound - v) / iqr
                } else {
                    (v - upper_bound) / iqr
                };
                scores.push(score);
            }
        }

        Ok(OutlierDetectionResult {
            outlier_indices,
            outlier_values,
            scores,
            method: OutlierMethod::IQR,
        })
    }

    /// Detect outliers using Z-score method
    fn detect_zscore(&self, series: &TimeSeries) -> Result<OutlierDetectionResult> {
        let data = series.values.to_vec()?;
        let n = data.len();

        if n == 0 {
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::ZScore,
            });
        }

        // Compute mean and standard deviation
        let mean = data.iter().map(|&x| x as f64).sum::<f64>() / n as f64;
        let variance = data
            .iter()
            .map(|&x| {
                let diff = (x as f64) - mean;
                diff * diff
            })
            .sum::<f64>()
            / n as f64;
        let std = variance.sqrt();

        if std < 1e-10 {
            // Constant series - no outliers
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::ZScore,
            });
        }

        // Compute z-scores and find outliers
        let mut outlier_indices = Vec::new();
        let mut outlier_values = Vec::new();
        let mut scores = Vec::new();

        for (i, &value) in data.iter().enumerate() {
            let z_score = ((value as f64) - mean) / std;
            if z_score.abs() > self.threshold {
                outlier_indices.push(i);
                outlier_values.push(value);
                scores.push(z_score.abs());
            }
        }

        Ok(OutlierDetectionResult {
            outlier_indices,
            outlier_values,
            scores,
            method: OutlierMethod::ZScore,
        })
    }

    /// Detect outliers using Modified Z-score (MAD-based)
    fn detect_modified_zscore(&self, series: &TimeSeries) -> Result<OutlierDetectionResult> {
        let data = series.values.to_vec()?;
        let n = data.len();

        if n == 0 {
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::ModifiedZScore,
            });
        }

        // Compute median
        let mut sorted_data = data.clone();
        sorted_data.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));
        let median = if n % 2 == 0 {
            ((sorted_data[n / 2 - 1] + sorted_data[n / 2]) / 2.0) as f64
        } else {
            sorted_data[n / 2] as f64
        };

        // Compute MAD (Median Absolute Deviation)
        let mut abs_deviations: Vec<f64> =
            data.iter().map(|&x| ((x as f64) - median).abs()).collect();
        abs_deviations.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));

        let mad = if n % 2 == 0 {
            (abs_deviations[n / 2 - 1] + abs_deviations[n / 2]) / 2.0
        } else {
            abs_deviations[n / 2]
        };

        if mad < 1e-10 {
            // Constant series - no outliers
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::ModifiedZScore,
            });
        }

        // Modified Z-score = 0.6745 * (x - median) / MAD
        // The constant 0.6745 is the 0.75th quantile of the standard normal distribution
        const SCALE_FACTOR: f64 = 0.6745;
        let mut outlier_indices = Vec::new();
        let mut outlier_values = Vec::new();
        let mut scores = Vec::new();

        for (i, &value) in data.iter().enumerate() {
            let modified_z = (SCALE_FACTOR * ((value as f64) - median) / mad).abs();
            if modified_z > self.threshold {
                outlier_indices.push(i);
                outlier_values.push(value);
                scores.push(modified_z);
            }
        }

        Ok(OutlierDetectionResult {
            outlier_indices,
            outlier_values,
            scores,
            method: OutlierMethod::ModifiedZScore,
        })
    }

    /// Detect outliers using Isolation Forest
    ///
    /// This is a simplified implementation using ensemble of random trees.
    /// The contamination parameter (threshold) controls the proportion of outliers expected.
    fn detect_isolation_forest(&self, series: &TimeSeries) -> Result<OutlierDetectionResult> {
        let data = series.values.to_vec()?;
        let n = data.len();

        if n < 10 {
            // Too few points for isolation forest
            return Ok(OutlierDetectionResult {
                outlier_indices: vec![],
                outlier_values: vec![],
                scores: vec![],
                method: OutlierMethod::IsolationForest,
            });
        }

        // Parameters
        let num_trees = 100;
        let subsample_size = std::cmp::min(256, n);
        let max_depth = (subsample_size as f64).log2().ceil() as usize;

        // Compute anomaly scores for each point
        let mut scores = vec![0.0; n];
        let mut rng = thread_rng();

        for _ in 0..num_trees {
            // Create random subsample
            let dist = Uniform::new(0, n).expect("distribution should succeed");
            let subsample_indices: Vec<usize> =
                (0..subsample_size).map(|_| dist.sample(&mut rng)).collect();

            // Build isolation tree (simplified: just track path lengths)
            for (i, &value) in data.iter().enumerate() {
                let path_length =
                    self.compute_path_length(value as f64, &subsample_indices, &data, 0, max_depth);
                scores[i] += path_length;
            }
        }

        // Average scores
        for score in &mut scores {
            *score /= num_trees as f64;
        }

        // Normalize scores to [0, 1] range
        let max_score = scores.iter().copied().fold(f64::NEG_INFINITY, f64::max);
        let min_score = scores.iter().copied().fold(f64::INFINITY, f64::min);
        let score_range = max_score - min_score;

        if score_range > 1e-10 {
            for score in &mut scores {
                *score = 1.0 - (*score - min_score) / score_range;
            }
        }

        // Determine threshold: use contamination parameter
        let mut sorted_scores = scores.clone();
        sorted_scores.sort_by(|a, b| b.partial_cmp(a).unwrap_or(std::cmp::Ordering::Equal));
        let threshold_idx = (self.threshold * n as f64) as usize;
        let score_threshold = if threshold_idx < sorted_scores.len() {
            sorted_scores[threshold_idx]
        } else {
            1.0
        };

        // Identify outliers
        let mut outlier_indices = Vec::new();
        let mut outlier_values = Vec::new();
        let mut outlier_scores = Vec::new();

        for (i, (&value, &score)) in data.iter().zip(scores.iter()).enumerate() {
            if score >= score_threshold {
                outlier_indices.push(i);
                outlier_values.push(value);
                outlier_scores.push(score);
            }
        }

        Ok(OutlierDetectionResult {
            outlier_indices,
            outlier_values,
            scores: outlier_scores,
            method: OutlierMethod::IsolationForest,
        })
    }

    /// Compute path length in isolation tree (simplified)
    fn compute_path_length(
        &self,
        value: f64,
        subsample_indices: &[usize],
        data: &[f32],
        depth: usize,
        max_depth: usize,
    ) -> f64 {
        if depth >= max_depth || subsample_indices.len() <= 1 {
            // Adjust for average path length
            return depth as f64 + self.average_path_length(subsample_indices.len());
        }

        // Find min and max in subsample
        let mut min_val = f64::INFINITY;
        let mut max_val = f64::NEG_INFINITY;
        for &idx in subsample_indices {
            let val = data[idx] as f64;
            min_val = min_val.min(val);
            max_val = max_val.max(val);
        }

        if (max_val - min_val).abs() < 1e-10 {
            // All values are the same
            return depth as f64 + self.average_path_length(subsample_indices.len());
        }

        // Random split point
        let mut rng = thread_rng();
        let dist = Uniform::new(min_val, max_val).expect("distribution should succeed");
        let split_point = dist.sample(&mut rng);

        // Recurse based on which side of split the value is on
        if value < split_point {
            depth as f64 + 1.0
        } else {
            depth as f64 + 1.0
        }
    }

    /// Average path length for unsuccessful search in BST
    fn average_path_length(&self, n: usize) -> f64 {
        if n <= 1 {
            return 0.0;
        }
        let n_f64 = n as f64;
        2.0 * ((n_f64 - 1.0).ln() + 0.5772156649) - 2.0 * (n_f64 - 1.0) / n_f64
    }

    /// Treat outliers in a time series
    pub fn treat(
        &self,
        series: &TimeSeries,
        detection: &OutlierDetectionResult,
        treatment: OutlierTreatment,
    ) -> Result<TimeSeries> {
        let mut data = series.values.to_vec()?;
        let n = data.len();

        if detection.outlier_indices.is_empty() {
            // No outliers to treat
            return Ok(TimeSeries::new(series.values.clone()));
        }

        match treatment {
            OutlierTreatment::Remove => {
                // Remove outliers (return series without outlier points)
                let mut filtered_data = Vec::new();
                for (i, &value) in data.iter().enumerate() {
                    if !detection.outlier_indices.contains(&i) {
                        filtered_data.push(value);
                    }
                }
                let tensor = Tensor::from_vec(filtered_data.clone(), &[filtered_data.len()])?;
                Ok(TimeSeries::new(tensor))
            }
            OutlierTreatment::Mean => {
                // Replace outliers with mean
                let mean = data.iter().map(|&x| x as f64).sum::<f64>() / n as f64;
                for &idx in &detection.outlier_indices {
                    data[idx] = mean as f32;
                }
                let tensor = Tensor::from_vec(data.clone(), &[n])?;
                Ok(TimeSeries::new(tensor))
            }
            OutlierTreatment::Median => {
                // Replace outliers with median
                let mut sorted = data.clone();
                sorted.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));
                let median = if n % 2 == 0 {
                    (sorted[n / 2 - 1] + sorted[n / 2]) / 2.0
                } else {
                    sorted[n / 2]
                };
                for &idx in &detection.outlier_indices {
                    data[idx] = median;
                }
                let tensor = Tensor::from_vec(data.clone(), &[n])?;
                Ok(TimeSeries::new(tensor))
            }
            OutlierTreatment::Clip => {
                // Clip outliers to nearest non-outlier value
                let mut sorted = data.clone();
                sorted.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));

                // Find bounds from non-outlier values
                let non_outlier_values: Vec<f32> = data
                    .iter()
                    .enumerate()
                    .filter(|(i, _)| !detection.outlier_indices.contains(i))
                    .map(|(_, &v)| v)
                    .collect();

                if non_outlier_values.is_empty() {
                    // All values are outliers - nothing to clip to
                    return Ok(TimeSeries::new(series.values.clone()));
                }

                let min_non_outlier = non_outlier_values
                    .iter()
                    .copied()
                    .fold(f32::INFINITY, f32::min);
                let max_non_outlier = non_outlier_values
                    .iter()
                    .copied()
                    .fold(f32::NEG_INFINITY, f32::max);

                for &idx in &detection.outlier_indices {
                    data[idx] = data[idx].clamp(min_non_outlier, max_non_outlier);
                }
                let tensor = Tensor::from_vec(data.clone(), &[n])?;
                Ok(TimeSeries::new(tensor))
            }
            OutlierTreatment::Interpolate => {
                // Replace outliers with linear interpolation
                for &idx in &detection.outlier_indices {
                    // Find nearest non-outlier neighbors
                    let mut left_idx = None;
                    let mut right_idx = None;

                    // Search left
                    for i in (0..idx).rev() {
                        if !detection.outlier_indices.contains(&i) {
                            left_idx = Some(i);
                            break;
                        }
                    }

                    // Search right
                    for i in (idx + 1)..n {
                        if !detection.outlier_indices.contains(&i) {
                            right_idx = Some(i);
                            break;
                        }
                    }

                    // Interpolate
                    let value = match (left_idx, right_idx) {
                        (Some(left), Some(right)) => {
                            // Linear interpolation
                            let t = (idx - left) as f32 / (right - left) as f32;
                            data[left] * (1.0 - t) + data[right] * t
                        }
                        (Some(left), None) => data[left], // Use left value
                        (None, Some(right)) => data[right], // Use right value
                        (None, None) => {
                            // All values are outliers
                            data[idx]
                        }
                    };
                    data[idx] = value;
                }
                let tensor = Tensor::from_vec(data.clone(), &[n])?;
                Ok(TimeSeries::new(tensor))
            }
        }
    }
}

/// Convenience function to detect and treat outliers in one step
pub fn detect_and_treat_outliers(
    series: &TimeSeries,
    method: OutlierMethod,
    threshold: f64,
    treatment: OutlierTreatment,
) -> Result<(TimeSeries, OutlierDetectionResult)> {
    let detector = OutlierDetector::new(method, threshold);
    let detection = detector.detect(series)?;
    let treated = detector.treat(series, &detection, treatment)?;
    Ok((treated, detection))
}

#[cfg(test)]
mod tests {
    use super::*;

    fn create_series_with_outliers() -> TimeSeries {
        // Normal values around 10, with outliers at 100 and -100
        let data = vec![
            10.0f32, 11.0, 9.0, 10.5, 100.0, // outlier
            9.5, 10.2, 10.1, -100.0, // outlier
            10.3, 9.8, 10.0,
        ];
        let tensor = Tensor::from_vec(data, &[12]).expect("Tensor should succeed");
        TimeSeries::new(tensor)
    }

    #[test]
    fn test_iqr_detection() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::IQR, 1.5);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        assert_eq!(result.method, OutlierMethod::IQR);
        assert!(result.outlier_indices.len() >= 2); // Should detect at least 2 outliers
        assert!(result.outlier_indices.contains(&4)); // 100.0
        assert!(result.outlier_indices.contains(&8)); // -100.0
    }

    #[test]
    fn test_zscore_detection() {
        let series = create_series_with_outliers();
        // Use a lenient threshold - extreme outliers affect mean/std calculation
        // which can make z-scores less extreme than expected
        let detector = OutlierDetector::new(OutlierMethod::ZScore, 2.0);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        assert_eq!(result.method, OutlierMethod::ZScore);
        // Should detect at least one extreme outlier
        assert!(
            !result.outlier_indices.is_empty(),
            "Expected to detect at least 1 outlier"
        );
        // Z-score should detect the most extreme values
        assert!(result.outlier_indices.len() >= 1);
    }

    #[test]
    fn test_modified_zscore_detection() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::ModifiedZScore, 3.5);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        assert_eq!(result.method, OutlierMethod::ModifiedZScore);
        assert!(result.outlier_indices.len() >= 2);
    }

    #[test]
    fn test_isolation_forest_detection() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::IsolationForest, 0.2);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        assert_eq!(result.method, OutlierMethod::IsolationForest);
        // Isolation forest should detect some outliers
        assert!(!result.outlier_indices.is_empty());
    }

    #[test]
    fn test_outlier_treatment_mean() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::ZScore, 3.0);
        let detection = detector
            .detect(&series)
            .expect("detection operation should succeed");
        let treated = detector
            .treat(&series, &detection, OutlierTreatment::Mean)
            .expect("operation should succeed");

        // Check that outliers were replaced
        let treated_data = treated
            .values
            .to_vec()
            .expect("tensor to_vec conversion should succeed");
        assert_eq!(treated_data.len(), series.len());
    }

    #[test]
    fn test_outlier_treatment_remove() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::IQR, 1.5);
        let detection = detector
            .detect(&series)
            .expect("detection operation should succeed");
        let treated = detector
            .treat(&series, &detection, OutlierTreatment::Remove)
            .expect("operation should succeed");

        // Series should be shorter after removing outliers
        assert!(treated.len() < series.len());
    }

    #[test]
    fn test_outlier_treatment_interpolate() {
        let series = create_series_with_outliers();
        let detector = OutlierDetector::new(OutlierMethod::ZScore, 3.0);
        let detection = detector
            .detect(&series)
            .expect("detection operation should succeed");
        let treated = detector
            .treat(&series, &detection, OutlierTreatment::Interpolate)
            .expect("operation should succeed");

        // Length should be preserved
        assert_eq!(treated.len(), series.len());

        // Outlier values should be changed
        let original_data = series
            .values
            .to_vec()
            .expect("tensor to_vec conversion should succeed");
        let treated_data = treated
            .values
            .to_vec()
            .expect("tensor to_vec conversion should succeed");
        for &idx in &detection.outlier_indices {
            assert_ne!(original_data[idx], treated_data[idx]);
        }
    }

    #[test]
    fn test_detect_and_treat_convenience() {
        let series = create_series_with_outliers();
        let (treated, detection) =
            detect_and_treat_outliers(&series, OutlierMethod::IQR, 1.5, OutlierTreatment::Median)
                .expect("operation should succeed");

        assert!(!detection.outlier_indices.is_empty());
        assert_eq!(treated.len(), series.len());
    }

    #[test]
    fn test_no_outliers() {
        // Normal series without outliers
        let data = vec![10.0f32, 10.1, 9.9, 10.2, 9.8, 10.0];
        let tensor = Tensor::from_vec(data, &[6]).expect("Tensor should succeed");
        let series = TimeSeries::new(tensor);

        let detector = OutlierDetector::new(OutlierMethod::ZScore, 3.0);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        assert!(result.outlier_indices.is_empty());
    }

    #[test]
    fn test_constant_series() {
        // Constant series
        let data = vec![10.0f32; 10];
        let tensor = Tensor::from_vec(data, &[10]).expect("Tensor should succeed");
        let series = TimeSeries::new(tensor);

        let detector = OutlierDetector::new(OutlierMethod::ZScore, 3.0);
        let result = detector
            .detect(&series)
            .expect("detection operation should succeed");

        // No outliers in constant series
        assert!(result.outlier_indices.is_empty());
    }
}