torc 0.22.0

Workflow management system
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
//! Remote worker commands for distributed execution via SSH.

use clap::Subcommand;
use log::{debug, info, warn};
use std::fs;
use std::path::{Path, PathBuf};

use crate::client::apis;
use crate::client::apis::configuration::Configuration;
use crate::client::commands::{get_env_user_name, select_workflow_interactively};
use crate::client::remote::{
    RemoteOperationResult, RemoteWorkerState, WorkerEntry, check_all_connectivity,
    check_ssh_connectivity, parallel_execute, parse_worker_content, parse_worker_file,
    scp_download, ssh_execute, ssh_execute_capture, verify_all_versions,
};
use crate::client::workflow_manager::WorkflowManager;
use crate::config::TorcConfig;

/// Remote worker execution commands.
#[derive(Subcommand)]
#[command(after_long_help = "\
EXAMPLES:
    # Add remote workers
    torc remote add-workers 123 user@host1 user@host2

    # List workers
    torc remote list-workers 123

    # Run workers via SSH
    torc remote run 123

    # Check worker status
    torc remote status 123

    # Stop all workers
    torc remote stop 123
")]
pub enum RemoteCommands {
    /// Add one or more remote workers to a workflow
    ///
    /// Workers are stored in the database and used by subsequent commands.
    /// Format: [user@]hostname[:port]
    #[command(
        name = "add-workers",
        after_long_help = "\
EXAMPLES:
    torc remote add-workers 123 user@host1 user@host2
    torc remote add-workers 123 host1 host2 host3
"
    )]
    AddWorkers {
        /// Workflow ID
        #[arg()]
        workflow_id: i64,

        /// Worker addresses (format: [user@]hostname[:port])
        #[arg(required = true, num_args = 1..)]
        workers: Vec<String>,

        /// Skip SSH connectivity check (for testing only)
        #[arg(long, hide = true)]
        skip_ssh_check: bool,
    },

    /// Add remote workers to a workflow from a file
    ///
    /// Each line in the file should be a worker address.
    /// Lines starting with # are comments.
    #[command(name = "add-workers-from-file")]
    AddWorkersFromFile {
        /// Path to worker file listing remote machines
        #[arg()]
        worker_file: PathBuf,

        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Skip SSH connectivity check (for testing only)
        #[arg(long, hide = true)]
        skip_ssh_check: bool,
    },

    /// Remove a remote worker from a workflow
    #[command(name = "remove-worker")]
    RemoveWorker {
        /// Worker address to remove
        #[arg()]
        worker: String,

        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,
    },

    /// List remote workers stored in the database for a workflow
    #[command(name = "list-workers")]
    ListWorkers {
        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,
    },

    /// Run workers on remote machines via SSH
    ///
    /// SSH into each stored worker and start a torc worker process.
    /// Workers run detached (via nohup) and survive SSH disconnection.
    /// Use add-workers first, or provide --workers to add and run in one step.
    Run {
        /// Workflow ID to run (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Path to worker file (optional - adds workers before running)
        #[arg(short, long)]
        workers: Option<PathBuf>,

        /// Output directory on remote machines (relative to home)
        #[arg(short, long, default_value = "torc_output")]
        output_dir: String,

        /// Maximum parallel SSH connections
        #[arg(long, default_value = "10")]
        max_parallel_ssh: usize,

        /// Poll interval in seconds for workers
        #[arg(short, long, default_value = "5.0")]
        poll_interval: f64,

        /// Maximum number of parallel jobs per worker
        #[arg(long)]
        max_parallel_jobs: Option<i64>,

        /// Number of CPUs per worker (auto-detect if not specified)
        #[arg(long)]
        num_cpus: Option<i64>,

        /// Memory in GB per worker (auto-detect if not specified)
        #[arg(long)]
        memory_gb: Option<f64>,

        /// Number of GPUs per worker (auto-detect if not specified)
        #[arg(long)]
        num_gpus: Option<i64>,

        /// Skip version check (not recommended)
        #[arg(long, default_value = "false")]
        skip_version_check: bool,
    },

    /// Check status of remote workers
    Status {
        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Remote output directory (must match what was used in run)
        #[arg(long, default_value = "torc_output")]
        output_dir: String,

        /// Maximum parallel SSH connections
        #[arg(long, default_value = "10")]
        max_parallel_ssh: usize,
    },

    /// Stop workers on remote machines
    Stop {
        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Remote output directory (must match what was used in run)
        #[arg(long, default_value = "torc_output")]
        output_dir: String,

        /// Maximum parallel SSH connections
        #[arg(long, default_value = "10")]
        max_parallel_ssh: usize,

        /// Force kill (SIGKILL instead of SIGTERM)
        #[arg(long, default_value = "false")]
        force: bool,
    },

    /// Collect logs from remote workers
    #[command(name = "collect-logs")]
    CollectLogs {
        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Local directory to save collected logs
        #[arg(short, long, default_value = "remote_logs")]
        local_output_dir: PathBuf,

        /// Remote output directory (must match what was used in run)
        #[arg(long, default_value = "torc_output")]
        remote_output_dir: String,

        /// Maximum parallel SSH connections
        #[arg(long, default_value = "10")]
        max_parallel_ssh: usize,

        /// Delete remote logs after successful collection
        #[arg(long, default_value = "false")]
        delete: bool,
    },

    /// Delete logs from remote workers
    ///
    /// Removes the output directory from all remote workers.
    /// Use collect-logs --delete to safely collect before deleting.
    #[command(name = "delete-logs")]
    DeleteLogs {
        /// Workflow ID (optional - will prompt if not provided)
        #[arg()]
        workflow_id: Option<i64>,

        /// Remote output directory to delete (must match what was used in run)
        #[arg(long, default_value = "torc_output")]
        remote_output_dir: String,

        /// Maximum parallel SSH connections
        #[arg(long, default_value = "10")]
        max_parallel_ssh: usize,
    },
}

/// Resolve optional workflow_id by prompting user if not provided.
fn resolve_workflow_id(config: &Configuration, workflow_id: Option<i64>) -> i64 {
    workflow_id.unwrap_or_else(|| {
        let user_name = get_env_user_name();
        select_workflow_interactively(config, &user_name).unwrap_or_else(|e| {
            eprintln!("Error selecting workflow: {}", e);
            std::process::exit(1);
        })
    })
}

/// Handle remote commands.
pub fn handle_remote_commands(config: &Configuration, command: &RemoteCommands) {
    match command {
        RemoteCommands::AddWorkers {
            workflow_id,
            workers,
            skip_ssh_check,
        } => {
            // AddWorkers requires workflow_id (not optional)
            handle_add_workers(config, *workflow_id, workers, *skip_ssh_check);
        }
        RemoteCommands::AddWorkersFromFile {
            workflow_id,
            worker_file,
            skip_ssh_check,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_add_workers_from_file(config, wf_id, worker_file, *skip_ssh_check);
        }
        RemoteCommands::RemoveWorker {
            workflow_id,
            worker,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_remove_worker(config, worker, wf_id);
        }
        RemoteCommands::ListWorkers { workflow_id } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_list_workers(config, wf_id);
        }
        RemoteCommands::Run {
            workflow_id,
            workers,
            output_dir,
            max_parallel_ssh,
            poll_interval,
            max_parallel_jobs,
            num_cpus,
            memory_gb,
            num_gpus,
            skip_version_check,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_run(
                config,
                wf_id,
                workers.as_ref(),
                output_dir,
                *max_parallel_ssh,
                *poll_interval,
                *max_parallel_jobs,
                *num_cpus,
                *memory_gb,
                *num_gpus,
                *skip_version_check,
            );
        }
        RemoteCommands::Status {
            workflow_id,
            output_dir,
            max_parallel_ssh,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_status(config, wf_id, output_dir, *max_parallel_ssh);
        }
        RemoteCommands::Stop {
            workflow_id,
            output_dir,
            max_parallel_ssh,
            force,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_stop(config, wf_id, output_dir, *max_parallel_ssh, *force);
        }
        RemoteCommands::CollectLogs {
            workflow_id,
            local_output_dir,
            remote_output_dir,
            max_parallel_ssh,
            delete,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_collect_logs(
                config,
                wf_id,
                local_output_dir,
                remote_output_dir,
                *max_parallel_ssh,
                *delete,
            );
        }
        RemoteCommands::DeleteLogs {
            workflow_id,
            remote_output_dir,
            max_parallel_ssh,
        } => {
            let wf_id = resolve_workflow_id(config, *workflow_id);
            handle_delete_logs(config, wf_id, remote_output_dir, *max_parallel_ssh);
        }
    }
}

/// Initialize workflow if all jobs are uninitialized.
///
/// This must be done on the manager before starting remote workers to avoid
/// race conditions where multiple workers try to initialize simultaneously.
fn initialize_workflow_if_needed(config: &Configuration, workflow_id: i64) {
    // Get workflow info
    let workflow = match apis::workflows_api::get_workflow(config, workflow_id) {
        Ok(w) => w,
        Err(e) => {
            eprintln!("Error getting workflow {}: {}", workflow_id, e);
            std::process::exit(1);
        }
    };

    // Check if workflow needs initialization
    match apis::workflows_api::is_workflow_uninitialized(config, workflow_id) {
        Ok(response) => {
            if let Some(is_uninitialized) =
                response.get("is_uninitialized").and_then(|v| v.as_bool())
                && is_uninitialized
            {
                info!(
                    "Workflow {} has all jobs uninitialized. Initializing on manager...",
                    workflow_id
                );
                let torc_config = TorcConfig::load().unwrap_or_default();
                let workflow_manager = WorkflowManager::new(config.clone(), torc_config, workflow);
                match workflow_manager.initialize(false) {
                    Ok(()) => {
                        info!("Successfully initialized workflow {}", workflow_id);
                    }
                    Err(e) => {
                        eprintln!("Error initializing workflow: {}", e);
                        std::process::exit(1);
                    }
                }
            }
        }
        Err(e) => {
            eprintln!("Error checking if workflow is uninitialized: {}", e);
            std::process::exit(1);
        }
    }
}

/// Start workers on remote machines.
#[allow(clippy::too_many_arguments)]
fn handle_run(
    config: &Configuration,
    workflow_id: i64,
    workers_file: Option<&PathBuf>,
    output_dir: &str,
    max_parallel_ssh: usize,
    poll_interval: f64,
    max_parallel_jobs: Option<i64>,
    num_cpus: Option<i64>,
    memory_gb: Option<f64>,
    num_gpus: Option<i64>,
    skip_version_check: bool,
) {
    // If a workers file is provided, validate SSH connectivity before adding to database
    if let Some(worker_file) = workers_file {
        let workers = match parse_worker_file(worker_file) {
            Ok(w) => w,
            Err(e) => {
                eprintln!("Error parsing worker file: {}", e);
                std::process::exit(1);
            }
        };

        if workers.is_empty() {
            eprintln!("No workers found in {}", worker_file.display());
            std::process::exit(1);
        }

        // Check SSH connectivity for each worker before adding to database
        let source = worker_file.display().to_string();
        let valid_workers = match validate_workers_ssh(&workers, max_parallel_ssh, Some(&source)) {
            Ok(workers) => workers,
            Err(e) => {
                eprintln!("Error: {}", e);
                std::process::exit(1);
            }
        };

        // Add only valid workers to the database
        println!("Adding {} worker(s) to database...", valid_workers.len());

        match apis::remote_workers_api::create_remote_workers(config, workflow_id, valid_workers) {
            Ok(created) => {
                info!(
                    "Added {} workers from {}",
                    created.len(),
                    worker_file.display()
                );
            }
            Err(e) => {
                eprintln!("Error adding workers from file: {}", e);
                std::process::exit(1);
            }
        }
    }

    // Fetch all workers from the database
    let workers = fetch_workers_from_db(config, workflow_id);
    if workers.is_empty() {
        eprintln!(
            "No workers configured for workflow {}. Use 'torc remote add-workers' or '--workers' flag.",
            workflow_id
        );
        std::process::exit(1);
    }

    println!(
        "Found {} worker(s) for workflow {}",
        workers.len(),
        workflow_id
    );

    // Check SSH connectivity
    if let Err(e) = check_all_connectivity(&workers, max_parallel_ssh) {
        eprintln!("Error: {}", e);
        std::process::exit(1);
    }

    // Version check
    if !skip_version_check {
        let local_version = env!("CARGO_PKG_VERSION");
        if let Err(e) = verify_all_versions(&workers, local_version, max_parallel_ssh) {
            eprintln!("Error: {}", e);
            std::process::exit(1);
        }
    } else {
        warn!("Skipping version check as requested");
    }

    // Initialize workflow on manager if needed (before starting workers to avoid race condition)
    initialize_workflow_if_needed(config, workflow_id);

    // Start workers
    println!("Starting workers...");

    let api_url = config.base_path.clone();
    let output_dir_owned = output_dir.to_string();

    let results: Vec<RemoteOperationResult> = parallel_execute(
        &workers,
        move |worker| {
            start_remote_worker(
                worker,
                &api_url,
                workflow_id,
                &output_dir_owned,
                poll_interval,
                max_parallel_jobs,
                num_cpus,
                memory_gb,
                num_gpus,
            )
        },
        max_parallel_ssh,
    );

    // Report results
    let mut success_count = 0;
    for result in &results {
        let status = if result.success { "OK" } else { "FAILED" };
        println!(
            "  [{}] {}: {}",
            status,
            result.worker.display_name(),
            result.message
        );
        if result.success {
            success_count += 1;
        }
    }

    println!("\nStarted {}/{} workers", success_count, workers.len());

    if success_count < workers.len() {
        std::process::exit(1);
    }
}

/// Start a single worker on a remote machine.
#[allow(clippy::too_many_arguments)]
fn start_remote_worker(
    worker: &WorkerEntry,
    api_url: &str,
    workflow_id: i64,
    output_dir: &str,
    poll_interval: f64,
    max_parallel_jobs: Option<i64>,
    num_cpus: Option<i64>,
    memory_gb: Option<f64>,
    num_gpus: Option<i64>,
) -> RemoteOperationResult {
    // Create output directory on remote
    let mkdir_cmd = format!("mkdir -p {}", output_dir);
    if let Err(e) = ssh_execute_capture(worker, &mkdir_cmd) {
        return RemoteOperationResult::failure(
            worker.clone(),
            format!("Failed to create output directory: {}", e),
        );
    }

    // Build the torc run command
    // --url is a global option that must come before the subcommand
    let mut torc_cmd = format!(
        "torc --url {} run {} --output-dir {} --poll-interval {}",
        api_url, workflow_id, output_dir, poll_interval
    );

    if let Some(cpus) = num_cpus {
        torc_cmd.push_str(&format!(" --num-cpus {}", cpus));
    }
    if let Some(mem) = memory_gb {
        torc_cmd.push_str(&format!(" --memory-gb {}", mem));
    }
    if let Some(gpus) = num_gpus {
        torc_cmd.push_str(&format!(" --num-gpus {}", gpus));
    }
    if let Some(max) = max_parallel_jobs {
        torc_cmd.push_str(&format!(" --max-parallel-jobs {}", max));
    }

    // PID file and log file paths
    let pid_file = format!("{}/torc_worker_{}.pid", output_dir, workflow_id);
    let log_file = format!("{}/torc_worker_{}.log", output_dir, workflow_id);

    // Start with nohup, redirect output, save PID
    // Use bash -c to ensure proper shell handling
    let start_cmd = format!(
        "bash -c 'nohup {} > {} 2>&1 & echo $! > {}; disown'",
        torc_cmd, log_file, pid_file
    );

    debug!(
        "Starting worker on {}: {}",
        worker.display_name(),
        start_cmd
    );

    if let Err(e) = ssh_execute(worker, &start_cmd, Some(60)) {
        return RemoteOperationResult::failure(
            worker.clone(),
            format!("Failed to start worker: {}", e),
        );
    }

    // Give it a moment to start
    std::thread::sleep(std::time::Duration::from_secs(2));

    // Read PID file
    let pid_cmd = format!("cat {}", pid_file);
    let pid_output = match ssh_execute_capture(worker, &pid_cmd) {
        Ok(output) => output,
        Err(e) => {
            return RemoteOperationResult::failure(
                worker.clone(),
                format!("Failed to read PID file: {}", e),
            );
        }
    };

    let pid: u32 = match pid_output.trim().parse() {
        Ok(p) => p,
        Err(_) => {
            return RemoteOperationResult::failure(
                worker.clone(),
                format!("Invalid PID in file: '{}'", pid_output.trim()),
            );
        }
    };

    // Verify process is running with retries
    // We check both kill -0 and the log file for evidence of startup
    const MAX_RETRIES: u32 = 5;
    const RETRY_DELAY_MS: u64 = 1000;

    for attempt in 0..MAX_RETRIES {
        // First try kill -0
        let check_cmd = format!(
            "kill -0 {} 2>/dev/null && echo running || echo stopped",
            pid
        );
        let check_output = ssh_execute_capture(worker, &check_cmd).unwrap_or_default();

        if check_output.trim() == "running" {
            return RemoteOperationResult::success(
                worker.clone(),
                format!("Started (PID {})", pid),
            );
        }

        // Also check if log file shows successful startup (job_runner logs this on start)
        let log_check_cmd = format!(
            "grep -q 'Starting torc job runner' {} 2>/dev/null && echo started || echo waiting",
            log_file
        );
        let log_check_output = ssh_execute_capture(worker, &log_check_cmd).unwrap_or_default();

        if log_check_output.trim() == "started" {
            // Log shows startup, verify process is still running with pgrep
            // Use word boundary pattern to avoid matching workflow 123 when looking for 12
            let pgrep_cmd = format!(
                "pgrep -f 'torc .* run {}( |$)' >/dev/null 2>&1 && echo running || echo stopped",
                workflow_id
            );
            let pgrep_output = ssh_execute_capture(worker, &pgrep_cmd).unwrap_or_default();

            if pgrep_output.trim() == "running" {
                return RemoteOperationResult::success(
                    worker.clone(),
                    format!("Started (PID {})", pid),
                );
            }
        }

        // If not the last attempt, wait and retry
        if attempt < MAX_RETRIES - 1 {
            std::thread::sleep(std::time::Duration::from_millis(RETRY_DELAY_MS));
        }
    }

    // All retries exhausted - process appears to have died
    let tail_cmd = format!(
        "tail -5 {} 2>/dev/null || echo 'No log available'",
        log_file
    );
    let log_output = ssh_execute_capture(worker, &tail_cmd).unwrap_or_default();
    RemoteOperationResult::failure(
        worker.clone(),
        format!("Process died immediately. Last log:\n{}", log_output.trim()),
    )
}

/// Check status of workers on remote machines.
fn handle_status(
    config: &Configuration,
    workflow_id: i64,
    output_dir: &str,
    max_parallel_ssh: usize,
) {
    let workers = fetch_workers_from_db(config, workflow_id);
    if workers.is_empty() {
        eprintln!(
            "No workers configured for workflow {}. Use 'torc remote add-workers' first.",
            workflow_id
        );
        std::process::exit(1);
    }

    let output_dir_owned = output_dir.to_string();

    let statuses: Vec<(WorkerEntry, RemoteWorkerState)> = parallel_execute(
        &workers,
        move |worker| {
            let state = check_remote_worker_status(worker, workflow_id, &output_dir_owned);
            (worker.clone(), state)
        },
        max_parallel_ssh,
    );

    // Print table
    println!("{:<30} {:<20}", "Host", "Status");
    println!("{}", "-".repeat(50));

    let mut running = 0;
    for (worker, status) in &statuses {
        println!("{:<30} {:<20}", worker.display_name(), status);
        if matches!(status, RemoteWorkerState::Running { .. }) {
            running += 1;
        }
    }

    println!("\n{}/{} workers running", running, workers.len());
}

/// Check status of a single remote worker.
fn check_remote_worker_status(
    worker: &WorkerEntry,
    workflow_id: i64,
    output_dir: &str,
) -> RemoteWorkerState {
    let pid_file = format!("{}/torc_worker_{}.pid", output_dir, workflow_id);

    // Read PID file
    let pid_cmd = format!("cat {} 2>/dev/null", pid_file);
    let pid_output = match ssh_execute_capture(worker, &pid_cmd) {
        Ok(output) => output,
        Err(_) => {
            // No PID file, but check if process is running anyway via pgrep
            return check_worker_via_pgrep(worker, workflow_id);
        }
    };

    let pid: u32 = match pid_output.trim().parse() {
        Ok(p) => p,
        Err(_) => {
            // Invalid PID file, fall back to pgrep
            return check_worker_via_pgrep(worker, workflow_id);
        }
    };

    // Check if process is running via kill -0
    let check_cmd = format!(
        "kill -0 {} 2>/dev/null && echo running || echo stopped",
        pid
    );
    match ssh_execute_capture(worker, &check_cmd) {
        Ok(output) => {
            if output.trim() == "running" {
                RemoteWorkerState::Running { pid }
            } else {
                // PID file exists with valid PID but process has exited - worker completed.
                RemoteWorkerState::NotRunning
            }
        }
        Err(_) => check_worker_via_pgrep(worker, workflow_id),
    }
}

/// Check if a torc worker is running via pgrep (fallback when PID check fails).
fn check_worker_via_pgrep(worker: &WorkerEntry, workflow_id: i64) -> RemoteWorkerState {
    // Use word boundary pattern to avoid matching workflow 123 when looking for 12
    let pgrep_cmd = format!(
        "pgrep -f 'torc .* run {}( |$)' 2>/dev/null | head -1",
        workflow_id
    );
    match ssh_execute_capture(worker, &pgrep_cmd) {
        Ok(output) => {
            let trimmed = output.trim();
            if let Ok(pid) = trimmed.parse::<u32>() {
                RemoteWorkerState::Running { pid }
            } else {
                RemoteWorkerState::NotRunning
            }
        }
        Err(_) => RemoteWorkerState::NotRunning,
    }
}

/// Stop workers on remote machines.
fn handle_stop(
    config: &Configuration,
    workflow_id: i64,
    output_dir: &str,
    max_parallel_ssh: usize,
    force: bool,
) {
    let workers = fetch_workers_from_db(config, workflow_id);
    if workers.is_empty() {
        eprintln!(
            "No workers configured for workflow {}. Use 'torc remote add-workers' first.",
            workflow_id
        );
        std::process::exit(1);
    }

    let output_dir_owned = output_dir.to_string();
    let signal = if force { "KILL" } else { "TERM" };

    println!(
        "Stopping workers (signal: {})...",
        if force { "SIGKILL" } else { "SIGTERM" }
    );

    let results: Vec<RemoteOperationResult> = parallel_execute(
        &workers,
        move |worker| stop_remote_worker(worker, workflow_id, &output_dir_owned, signal),
        max_parallel_ssh,
    );

    // Report results
    for result in &results {
        let status = if result.success { "OK" } else { "FAILED" };
        println!(
            "  [{}] {}: {}",
            status,
            result.worker.display_name(),
            result.message
        );
    }
}

/// Stop a single remote worker.
fn stop_remote_worker(
    worker: &WorkerEntry,
    workflow_id: i64,
    output_dir: &str,
    signal: &str,
) -> RemoteOperationResult {
    let pid_file = format!("{}/torc_worker_{}.pid", output_dir, workflow_id);

    // Read PID
    let pid_cmd = format!("cat {} 2>/dev/null", pid_file);
    let pid_output = match ssh_execute_capture(worker, &pid_cmd) {
        Ok(output) => output,
        Err(_) => {
            return RemoteOperationResult::success(worker.clone(), "No worker found (no PID file)");
        }
    };

    let pid: u32 = match pid_output.trim().parse() {
        Ok(p) => p,
        Err(_) => {
            return RemoteOperationResult::failure(worker.clone(), "Invalid PID file");
        }
    };

    // Send signal
    let kill_cmd = format!(
        "kill -{} {} 2>/dev/null && echo killed || echo not_found",
        signal, pid
    );
    match ssh_execute_capture(worker, &kill_cmd) {
        Ok(output) => {
            if output.trim() == "killed" {
                RemoteOperationResult::success(
                    worker.clone(),
                    format!("Sent SIG{} to PID {}", signal, pid),
                )
            } else {
                RemoteOperationResult::success(worker.clone(), "Process not running")
            }
        }
        Err(e) => RemoteOperationResult::failure(worker.clone(), format!("Failed: {}", e)),
    }
}

/// Collect logs from remote workers.
fn handle_collect_logs(
    config: &Configuration,
    workflow_id: i64,
    local_output_dir: &Path,
    remote_output_dir: &str,
    max_parallel_ssh: usize,
    delete_after: bool,
) {
    let workers = fetch_workers_from_db(config, workflow_id);
    if workers.is_empty() {
        eprintln!(
            "No workers configured for workflow {}. Use 'torc remote add-workers' first.",
            workflow_id
        );
        std::process::exit(1);
    }

    // Create local output directory
    if let Err(e) = fs::create_dir_all(local_output_dir) {
        eprintln!("Error creating output directory: {}", e);
        std::process::exit(1);
    }

    let action = if delete_after {
        "Collecting and deleting"
    } else {
        "Collecting"
    };
    println!(
        "{} logs from {} worker(s) to {}...",
        action,
        workers.len(),
        local_output_dir.display()
    );

    let local_dir = local_output_dir.to_path_buf();
    let remote_dir = remote_output_dir.to_string();

    let results: Vec<RemoteOperationResult> = parallel_execute(
        &workers,
        move |worker| {
            collect_worker_logs(worker, workflow_id, &local_dir, &remote_dir, delete_after)
        },
        max_parallel_ssh,
    );

    // Report results
    let mut success_count = 0;
    for result in &results {
        let status = if result.success { "OK" } else { "FAILED" };
        println!(
            "  [{}] {}: {}",
            status,
            result.worker.display_name(),
            result.message
        );
        if result.success {
            success_count += 1;
        }
    }

    let verb = if delete_after {
        "Collected and deleted"
    } else {
        "Collected"
    };
    println!(
        "\n{} logs from {}/{} workers",
        verb,
        success_count,
        workers.len()
    );
}

/// Collect logs from a single remote worker.
fn collect_worker_logs(
    worker: &WorkerEntry,
    workflow_id: i64,
    local_output_dir: &Path,
    remote_output_dir: &str,
    delete_after: bool,
) -> RemoteOperationResult {
    // Create tarball on remote
    let tarball_name = format!(
        "torc_logs_{}_{}.tar.gz",
        workflow_id,
        worker.host.replace('.', "_")
    );
    let remote_tarball = format!("/tmp/{}", tarball_name);

    // Check if remote directory exists
    let check_cmd = format!(
        "test -d {} && echo exists || echo missing",
        remote_output_dir
    );
    match ssh_execute_capture(worker, &check_cmd) {
        Ok(output) => {
            if output.trim() == "missing" {
                return RemoteOperationResult::success(worker.clone(), "No output directory found");
            }
        }
        Err(e) => {
            return RemoteOperationResult::failure(
                worker.clone(),
                format!("Failed to check directory: {}", e),
            );
        }
    }

    // Create tarball
    let tar_cmd = format!(
        "tar -czf {} -C {} . 2>/dev/null",
        remote_tarball, remote_output_dir
    );
    if let Err(e) = ssh_execute(worker, &tar_cmd, Some(300)) {
        return RemoteOperationResult::failure(
            worker.clone(),
            format!("Failed to create archive: {}", e),
        );
    }

    // SCP the tarball back
    let local_file = local_output_dir.join(&tarball_name);
    let local_file_str = local_file.to_string_lossy().to_string();

    match scp_download(worker, &remote_tarball, &local_file_str, Some(600)) {
        Ok(output) => {
            if !output.status.success() {
                let stderr = String::from_utf8_lossy(&output.stderr);
                return RemoteOperationResult::failure(
                    worker.clone(),
                    format!("SCP failed: {}", stderr.trim()),
                );
            }
        }
        Err(e) => {
            return RemoteOperationResult::failure(worker.clone(), format!("SCP error: {}", e));
        }
    }

    // Clean up remote tarball
    let rm_cmd = format!("rm -f {}", remote_tarball);
    let _ = ssh_execute(worker, &rm_cmd, None);

    // Delete remote output directory if requested
    if delete_after {
        let delete_cmd = format!("rm -rf {}", remote_output_dir);
        if let Err(e) = ssh_execute(worker, &delete_cmd, Some(60)) {
            return RemoteOperationResult::failure(
                worker.clone(),
                format!("Collected but failed to delete: {}", e),
            );
        }
        RemoteOperationResult::success(
            worker.clone(),
            format!("Saved to {} and deleted remote", local_file.display()),
        )
    } else {
        RemoteOperationResult::success(worker.clone(), format!("Saved to {}", local_file.display()))
    }
}

/// Delete logs from remote workers.
fn handle_delete_logs(
    config: &Configuration,
    workflow_id: i64,
    remote_output_dir: &str,
    max_parallel_ssh: usize,
) {
    let workers = fetch_workers_from_db(config, workflow_id);
    if workers.is_empty() {
        eprintln!(
            "No workers configured for workflow {}. Use 'torc remote add-workers' first.",
            workflow_id
        );
        std::process::exit(1);
    }

    println!("Deleting logs from {} worker(s)...", workers.len());

    let remote_dir = remote_output_dir.to_string();

    let results: Vec<RemoteOperationResult> = parallel_execute(
        &workers,
        move |worker| delete_worker_logs(worker, &remote_dir),
        max_parallel_ssh,
    );

    // Report results
    let mut success_count = 0;
    for result in &results {
        let status = if result.success { "OK" } else { "FAILED" };
        println!(
            "  [{}] {}: {}",
            status,
            result.worker.display_name(),
            result.message
        );
        if result.success {
            success_count += 1;
        }
    }

    println!(
        "\nDeleted logs from {}/{} workers",
        success_count,
        workers.len()
    );
}

/// Delete logs from a single remote worker.
fn delete_worker_logs(worker: &WorkerEntry, remote_output_dir: &str) -> RemoteOperationResult {
    // Check if remote directory exists
    let check_cmd = format!(
        "test -d {} && echo exists || echo missing",
        remote_output_dir
    );
    match ssh_execute_capture(worker, &check_cmd) {
        Ok(output) => {
            if output.trim() == "missing" {
                return RemoteOperationResult::success(
                    worker.clone(),
                    "No output directory found (already clean)",
                );
            }
        }
        Err(e) => {
            return RemoteOperationResult::failure(
                worker.clone(),
                format!("Failed to check directory: {}", e),
            );
        }
    }

    // Delete the directory
    let delete_cmd = format!("rm -rf {}", remote_output_dir);
    match ssh_execute(worker, &delete_cmd, Some(60)) {
        Ok(_) => {
            RemoteOperationResult::success(worker.clone(), format!("Deleted {}", remote_output_dir))
        }
        Err(e) => {
            RemoteOperationResult::failure(worker.clone(), format!("Failed to delete: {}", e))
        }
    }
}

/// List remote workers stored in the database for a workflow.
fn handle_list_workers(config: &Configuration, workflow_id: i64) {
    match apis::remote_workers_api::list_remote_workers(config, workflow_id) {
        Ok(workers) => {
            if workers.is_empty() {
                println!("No remote workers stored for workflow {}", workflow_id);
            } else {
                println!(
                    "Remote workers for workflow {} ({} total):",
                    workflow_id,
                    workers.len()
                );
                for worker in &workers {
                    println!("  {}", worker.worker);
                }
            }
        }
        Err(e) => {
            eprintln!("Error listing remote workers: {}", e);
            std::process::exit(1);
        }
    }
}

/// Default max parallel SSH connections for add-workers commands.
const DEFAULT_MAX_PARALLEL_SSH: usize = 10;

/// Validate workers by checking SSH connectivity and return only valid workers.
///
/// Returns the list of valid worker addresses (as strings) that passed SSH checks.
/// Prints error messages for workers that failed connectivity checks.
/// Returns an error if no workers pass the check.
///
/// # Arguments
/// * `workers` - The workers to validate
/// * `max_parallel_ssh` - Maximum number of parallel SSH connections
/// * `source` - Optional source description (e.g., file path) for log messages
fn validate_workers_ssh(
    workers: &[WorkerEntry],
    max_parallel_ssh: usize,
    source: Option<&str>,
) -> Result<Vec<String>, String> {
    if let Some(src) = source {
        println!(
            "Checking SSH connectivity for {} worker(s) from {}...",
            workers.len(),
            src
        );
    } else {
        println!(
            "Checking SSH connectivity for {} worker(s)...",
            workers.len()
        );
    }

    let results: Vec<Result<(), String>> =
        parallel_execute(workers, check_ssh_connectivity, max_parallel_ssh);

    let mut valid_workers: Vec<String> = Vec::new();
    let mut failed_workers: Vec<(String, String)> = Vec::new();

    for (worker, result) in workers.iter().zip(results) {
        match result {
            Ok(()) => {
                valid_workers.push(worker.original.clone());
            }
            Err(e) => {
                failed_workers.push((worker.display_name().to_string(), e));
            }
        }
    }

    // Report failed workers
    if !failed_workers.is_empty() {
        eprintln!(
            "SSH connectivity check failed for {} worker(s):",
            failed_workers.len()
        );
        for (host, error) in &failed_workers {
            eprintln!("  {}: {}", host, error);
        }
    }

    if valid_workers.is_empty() {
        return Err("No workers passed SSH connectivity check".to_string());
    }

    println!(
        "{}/{} workers passed SSH check",
        valid_workers.len(),
        workers.len()
    );

    Ok(valid_workers)
}

/// Add remote workers to the database.
fn handle_add_workers(
    config: &Configuration,
    workflow_id: i64,
    workers: &[String],
    skip_ssh_check: bool,
) {
    if workers.is_empty() {
        eprintln!("No workers specified");
        std::process::exit(1);
    }

    // Parse worker strings into WorkerEntry for SSH checking
    let worker_content = workers.join("\n");
    let parsed_workers = match parse_worker_content(&worker_content, "command line") {
        Ok(w) => w,
        Err(e) => {
            eprintln!("Error parsing worker addresses: {}", e);
            std::process::exit(1);
        }
    };

    let valid_workers = if skip_ssh_check {
        // Skip SSH check - add all workers directly
        parsed_workers.iter().map(|w| w.original.clone()).collect()
    } else {
        // Check SSH connectivity for each worker before adding to database
        match validate_workers_ssh(&parsed_workers, DEFAULT_MAX_PARALLEL_SSH, None) {
            Ok(workers) => workers,
            Err(e) => {
                eprintln!("Error: {}", e);
                std::process::exit(1);
            }
        }
    };

    match apis::remote_workers_api::create_remote_workers(config, workflow_id, valid_workers) {
        Ok(created) => {
            if created.is_empty() {
                println!("All workers already exist for workflow {}", workflow_id);
            } else {
                println!(
                    "Added {} worker(s) to workflow {}",
                    created.len(),
                    workflow_id
                );
                for worker in &created {
                    println!("  {}", worker.worker);
                }
            }
        }
        Err(e) => {
            eprintln!("Error adding workers: {}", e);
            std::process::exit(1);
        }
    }
}

/// Add remote workers from a file to the database.
fn handle_add_workers_from_file(
    config: &Configuration,
    workflow_id: i64,
    worker_file: &Path,
    skip_ssh_check: bool,
) {
    // Parse worker file
    let workers = match parse_worker_file(worker_file) {
        Ok(w) => w,
        Err(e) => {
            eprintln!("Error parsing worker file: {}", e);
            std::process::exit(1);
        }
    };

    if workers.is_empty() {
        eprintln!("No workers found in {}", worker_file.display());
        std::process::exit(1);
    }

    let valid_workers = if skip_ssh_check {
        // Skip SSH check - add all workers directly
        workers.iter().map(|w| w.original.clone()).collect()
    } else {
        // Check SSH connectivity for each worker before adding to database
        let source = worker_file.display().to_string();
        match validate_workers_ssh(&workers, DEFAULT_MAX_PARALLEL_SSH, Some(&source)) {
            Ok(workers) => workers,
            Err(e) => {
                eprintln!("Error: {}", e);
                std::process::exit(1);
            }
        }
    };

    match apis::remote_workers_api::create_remote_workers(config, workflow_id, valid_workers) {
        Ok(created) => {
            println!(
                "Added {} worker(s) from {} to workflow {}",
                created.len(),
                worker_file.display(),
                workflow_id
            );
            for worker in &created {
                println!("  {}", worker.worker);
            }
        }
        Err(e) => {
            eprintln!("Error adding workers: {}", e);
            std::process::exit(1);
        }
    }
}

/// Remove a remote worker from the database.
fn handle_remove_worker(config: &Configuration, worker: &str, workflow_id: i64) {
    match apis::remote_workers_api::delete_remote_worker(config, workflow_id, worker) {
        Ok(_) => {
            println!("Removed worker {} from workflow {}", worker, workflow_id);
        }
        Err(e) => {
            eprintln!("Error removing worker: {}", e);
            std::process::exit(1);
        }
    }
}

/// Fetch workers from the database and convert to WorkerEntry.
fn fetch_workers_from_db(config: &Configuration, workflow_id: i64) -> Vec<WorkerEntry> {
    match apis::remote_workers_api::list_remote_workers(config, workflow_id) {
        Ok(workers) => {
            workers
                .iter()
                .filter_map(|w| {
                    // Parse the worker string into a WorkerEntry
                    match parse_single_worker(&w.worker) {
                        Ok(entry) => Some(entry),
                        Err(e) => {
                            warn!("Failed to parse worker entry '{}': {}", w.worker, e);
                            None
                        }
                    }
                })
                .collect()
        }
        Err(e) => {
            eprintln!("Error fetching workers from database: {}", e);
            std::process::exit(1);
        }
    }
}

/// Parse a single worker string into a WorkerEntry.
fn parse_single_worker(line: &str) -> Result<WorkerEntry, String> {
    let line = line.trim();
    if line.is_empty() {
        return Err("Empty worker string".to_string());
    }

    let original = line.to_string();

    // Format: [user@]hostname[:port]
    // First, split off the user if present
    let (user, host_port) = if let Some(at_pos) = line.find('@') {
        let user = &line[..at_pos];
        let rest = &line[at_pos + 1..];

        if user.is_empty() {
            return Err("Empty username before '@'".to_string());
        }

        (Some(user.to_string()), rest)
    } else {
        (None, line)
    };

    // Now split off the port if present
    // Handle IPv6 addresses: [::1]:22 or [2001:db8::1]:22
    let (host, port) = if host_port.starts_with('[') {
        // IPv6 address in brackets
        if let Some(bracket_end) = host_port.find(']') {
            let ipv6 = &host_port[1..bracket_end];
            let rest = &host_port[bracket_end + 1..];
            if rest.is_empty() {
                (ipv6.to_string(), None)
            } else if let Some(port_str) = rest.strip_prefix(':') {
                let port: u16 = port_str
                    .parse()
                    .map_err(|_| format!("Invalid port '{}'", port_str))?;
                (ipv6.to_string(), Some(port))
            } else {
                return Err("Invalid format after IPv6 address".to_string());
            }
        } else {
            return Err("Unclosed bracket in IPv6 address".to_string());
        }
    } else {
        // Regular hostname or IPv4
        // Split on the last colon to handle port
        if let Some(colon_pos) = host_port.rfind(':') {
            let host = &host_port[..colon_pos];
            let port_str = &host_port[colon_pos + 1..];

            // Make sure port looks like a number (to avoid treating IPv6 as host:port)
            if port_str.chars().all(|c| c.is_ascii_digit()) && !port_str.is_empty() {
                let port: u16 = port_str
                    .parse()
                    .map_err(|_| format!("Invalid port '{}'", port_str))?;
                (host.to_string(), Some(port))
            } else {
                // Not a port, treat the whole thing as the host
                (host_port.to_string(), None)
            }
        } else {
            (host_port.to_string(), None)
        }
    };

    if host.is_empty() {
        return Err("Empty hostname".to_string());
    }

    Ok(WorkerEntry {
        original,
        user,
        host,
        port,
    })
}