use crate::semantic::fact::Fact;
use super::space::VersionedFact;
#[derive(Debug, Clone)]
pub enum Resolution {
Accept,
Reject,
Merge(Fact),
}
pub trait ConflictResolver: Send + Sync + 'static {
fn resolve(&self, existing: &VersionedFact, incoming: &Fact) -> Resolution;
}
#[derive(Debug, Clone, Default)]
pub struct LastWriteWins;
impl ConflictResolver for LastWriteWins {
fn resolve(&self, _existing: &VersionedFact, _incoming: &Fact) -> Resolution {
Resolution::Accept
}
}
#[derive(Debug, Clone, Default)]
pub struct HighestConfidenceWins;
impl ConflictResolver for HighestConfidenceWins {
fn resolve(&self, existing: &VersionedFact, incoming: &Fact) -> Resolution {
if incoming.confidence > existing.fact.confidence {
Resolution::Accept
} else {
Resolution::Reject
}
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::id::EntityId;
use crate::semantic::fact::{Fact, FactValue};
fn make_fact(confidence: f32) -> Fact {
Fact::new(
EntityId::new("e"),
"p",
FactValue::Text("v".into()),
confidence,
)
.unwrap()
}
fn versioned(fact: Fact) -> VersionedFact {
VersionedFact { fact, version: 1 }
}
#[test]
fn test_last_write_wins_always_accepts() {
let resolver = LastWriteWins;
let existing = versioned(make_fact(0.9));
let incoming = make_fact(0.1);
assert!(matches!(resolver.resolve(&existing, &incoming), Resolution::Accept));
}
#[test]
fn test_highest_confidence_wins_accepts_higher_confidence_incoming() {
let resolver = HighestConfidenceWins;
let existing = versioned(make_fact(0.5));
let incoming = make_fact(0.8);
assert!(matches!(resolver.resolve(&existing, &incoming), Resolution::Accept));
}
#[test]
fn test_shared_space_highest_confidence_wins_rejects_lower() {
let resolver = HighestConfidenceWins;
let existing = versioned(make_fact(0.9));
let incoming = make_fact(0.3);
assert!(matches!(resolver.resolve(&existing, &incoming), Resolution::Reject));
}
#[test]
fn test_highest_confidence_wins_rejects_equal_confidence() {
let resolver = HighestConfidenceWins;
let existing = versioned(make_fact(0.7));
let incoming = make_fact(0.7);
assert!(matches!(resolver.resolve(&existing, &incoming), Resolution::Reject));
}
}