tirith 0.3.3

use std::fs;
use std::path::Path;

use serde_json::{json, Value};

/// Merge a server entry into an MCP JSON config file under `"mcpServers"`.
/// Skips identical config; errors on drift unless `force`.
pub fn merge_mcp_json(
    path: &Path,
    server_name: &str,
    server_config: Value,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    merge_mcp_json_with_key(
        path,
        server_name,
        server_config,
        "mcpServers",
        force,
        dry_run,
    )
}

/// Like `merge_mcp_json` but with a custom top-level key (e.g. `"servers"` for VS Code).
pub fn merge_mcp_json_with_key(
    path: &Path,
    server_name: &str,
    server_config: Value,
    server_key: &str,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    let mut config: Value = if path.exists() {
        let raw = fs::read_to_string(path).map_err(|e| format!("read {}: {e}", path.display()))?;
        serde_json::from_str(&raw).map_err(|e| format!("parse {}: {e}", path.display()))?
    } else {
        json!({})
    };

    let servers = config
        .as_object_mut()
        .ok_or_else(|| format!("{} is not a JSON object", path.display()))?
        .entry(server_key)
        .or_insert_with(|| json!({}));

    let servers_obj = servers
        .as_object_mut()
        .ok_or_else(|| format!("{server_key} in {} is not an object", path.display()))?;

    if let Some(existing) = servers_obj.get(server_name) {
        if !force {
            if existing == &server_config {
                eprintln!(
                    "tirith: {server_name} already in {}, up to date",
                    path.display()
                );
                return Ok(());
            }
            if dry_run {
                eprintln!(
                    "[dry-run] would error: {server_name} in {} has different config — use --force to update",
                    path.display()
                );
                return Ok(());
            }
            return Err(format!(
                "tirith: {server_name} in {} has different config than expected — use --force to update",
                path.display()
            ));
        }
        // force: back up before overwriting user config (not in dry-run).
        if !dry_run {
            super::fs_helpers::create_backup(path, true)?;
        }
    }

    servers_obj.insert(server_name.to_string(), server_config);

    let content = serde_json::to_string_pretty(&config).map_err(|e| format!("serialize: {e}"))?;

    if dry_run {
        eprintln!(
            "[dry-run] would write {} ({} bytes)",
            path.display(),
            content.len()
        );
        return Ok(());
    }

    super::fs_helpers::atomic_write(path, &content, 0o644)?;
    eprintln!("tirith: wrote {}", path.display());
    Ok(())
}

/// Merge a hook entry into a hooks.json file (Cursor/Windsurf format).
/// Detects existing tirith hooks by the `marker` substring in each `command`.
pub fn merge_hooks_json(
    path: &Path,
    event_name: &str,
    hook_entry: Value,
    marker: &str,
    force: bool,
    dry_run: bool,
    require_version: bool,
) -> Result<(), String> {
    let mut config: Value = if path.exists() {
        let raw = fs::read_to_string(path).map_err(|e| format!("read {}: {e}", path.display()))?;
        serde_json::from_str(&raw).map_err(|e| format!("parse {}: {e}", path.display()))?
    } else if require_version {
        json!({"version": 1, "hooks": {}})
    } else {
        json!({"hooks": {}})
    };

    let hooks = config
        .as_object_mut()
        .ok_or_else(|| format!("{} is not a JSON object", path.display()))?
        .entry("hooks")
        .or_insert_with(|| json!({}));

    let hooks_obj = hooks
        .as_object_mut()
        .ok_or_else(|| format!("hooks in {} is not an object", path.display()))?;

    let event_arr = hooks_obj
        .entry(event_name)
        .or_insert_with(|| json!([]))
        .as_array_mut()
        .ok_or_else(|| format!("hooks.{event_name} in {} is not an array", path.display()))?;

    // All entries whose "command" field contains the marker.
    let matching_indices: Vec<usize> = event_arr
        .iter()
        .enumerate()
        .filter(|(_, entry)| {
            entry
                .get("command")
                .and_then(|v| v.as_str())
                .map(|cmd| cmd.contains(marker))
                .unwrap_or(false)
        })
        .map(|(i, _)| i)
        .collect();

    match matching_indices.len() {
        0 => {
            event_arr.push(hook_entry);
        }
        1 => {
            let idx = matching_indices[0];
            if !force {
                if event_arr[idx] == hook_entry {
                    eprintln!("tirith: hook in {}, up to date", path.display());
                    return Ok(());
                }
                if dry_run {
                    eprintln!(
                        "[dry-run] would error: hook entry in {} has different config — use --force to update",
                        path.display()
                    );
                    return Ok(());
                }
                return Err(format!(
                    "tirith: hook entry in {} has different config than expected — use --force to update",
                    path.display()
                ));
            }
            if !dry_run {
                super::fs_helpers::create_backup(path, true)?;
            }
            event_arr[idx] = hook_entry;
        }
        _ => {
            if !force {
                if dry_run {
                    eprintln!(
                        "[dry-run] would error: multiple tirith hook entries found in {} — use --force to deduplicate",
                        path.display()
                    );
                    return Ok(());
                }
                return Err(format!(
                    "tirith: multiple tirith hook entries found in {} — use --force to deduplicate",
                    path.display()
                ));
            }
            if !dry_run {
                super::fs_helpers::create_backup(path, true)?;
            }
            // Reverse order so earlier indices stay valid while removing.
            for &idx in matching_indices.iter().rev() {
                event_arr.remove(idx);
            }
            event_arr.push(hook_entry);
        }
    }

    let content = serde_json::to_string_pretty(&config).map_err(|e| format!("serialize: {e}"))?;

    if dry_run {
        eprintln!(
            "[dry-run] would write {} ({} bytes)",
            path.display(),
            content.len()
        );
        return Ok(());
    }

    super::fs_helpers::atomic_write(path, &content, 0o644)?;
    eprintln!("tirith: wrote {}", path.display());
    Ok(())
}

/// Merge a tirith MCP server into Claude Code's settings.json `mcpServers`.
/// Used for user-scope `--with-mcp` instead of `claude mcp add`, which deadlocks
/// inside an active Claude Code session. Same drift semantics as `merge_mcp_json`.
pub fn merge_claude_mcp_server(
    path: &Path,
    server_name: &str,
    server_config: Value,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    let mut config: Value = if path.exists() {
        let raw = fs::read_to_string(path).map_err(|e| format!("read {}: {e}", path.display()))?;
        serde_json::from_str(&raw).map_err(|e| format!("parse {}: {e}", path.display()))?
    } else {
        json!({})
    };

    let servers = config
        .as_object_mut()
        .ok_or_else(|| format!("{} is not a JSON object", path.display()))?
        .entry("mcpServers")
        .or_insert_with(|| json!({}));

    let servers_obj = servers
        .as_object_mut()
        .ok_or_else(|| format!("mcpServers in {} is not an object", path.display()))?;

    if let Some(existing) = servers_obj.get(server_name) {
        if !force {
            if existing == &server_config {
                eprintln!(
                    "tirith: {server_name} MCP server already in {}, up to date",
                    path.display()
                );
                return Ok(());
            }
            if dry_run {
                eprintln!(
                    "[dry-run] would error: {server_name} MCP server in {} has different config — use --force to update",
                    path.display()
                );
                return Ok(());
            }
            return Err(format!(
                "{server_name} MCP server in {} has different config than expected — use --force to update",
                path.display()
            ));
        }
        if !dry_run {
            super::fs_helpers::create_backup(path, true)?;
        }
    }

    servers_obj.insert(server_name.to_string(), server_config);

    let content = serde_json::to_string_pretty(&config).map_err(|e| format!("serialize: {e}"))?;

    if dry_run {
        eprintln!(
            "[dry-run] would write {} ({} bytes)",
            path.display(),
            content.len()
        );
        return Ok(());
    }

    super::fs_helpers::atomic_write(path, &content, 0o644)?;
    eprintln!(
        "tirith: registered {server_name} MCP server in {}",
        path.display()
    );
    Ok(())
}

/// Merge a tirith hook into a Claude Code / Gemini CLI settings.json
/// (`hooks.{event_name}[]` matcher entries, each with an inner `hooks[]`).
///
/// Operates at the individual hook-command level, preserving other hooks and
/// matchers. `marker` is a tool-specific filename substring used to detect the
/// existing tirith hook entry.
fn merge_hook_settings_inner(
    path: &Path,
    event_name: &str,
    matcher_name: &str,
    hook_command: &str,
    marker: &str,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    let mut config: Value = if path.exists() {
        let raw = fs::read_to_string(path).map_err(|e| format!("read {}: {e}", path.display()))?;
        serde_json::from_str(&raw).map_err(|e| format!("parse {}: {e}", path.display()))?
    } else {
        json!({})
    };

    let root = config
        .as_object_mut()
        .ok_or_else(|| format!("{} is not a JSON object", path.display()))?;

    let hooks = root.entry("hooks").or_insert_with(|| json!({}));
    let hooks_obj = hooks
        .as_object_mut()
        .ok_or_else(|| format!("hooks in {} is not an object", path.display()))?;

    let event_arr = hooks_obj.entry(event_name).or_insert_with(|| json!([]));
    let arr = event_arr
        .as_array_mut()
        .ok_or_else(|| format!("hooks.{event_name} in {} is not an array", path.display()))?;

    let new_hook_entry = json!({
        "type": "command",
        "command": hook_command
    });

    let has_marker = |h: &Value| -> bool {
        h.get("command")
            .and_then(|v| v.as_str())
            .map(|cmd| cmd.contains(marker))
            .unwrap_or(false)
    };

    // All matcher indices matching matcher_name.
    let matcher_indices: Vec<usize> = arr
        .iter()
        .enumerate()
        .filter(|(_, entry)| {
            entry
                .get("matcher")
                .and_then(|v| v.as_str())
                .map(|m| m == matcher_name)
                .unwrap_or(false)
        })
        .map(|(i, _)| i)
        .collect();

    match matcher_indices.len() {
        0 => {
            arr.push(json!({
                "matcher": matcher_name,
                "hooks": [new_hook_entry]
            }));
        }
        1 => {
            let idx = matcher_indices[0];

            // Marker-matching hook index within the matcher's inner hooks.
            let marker_hook_idx = arr[idx]
                .get("hooks")
                .and_then(|v| v.as_array())
                .and_then(|inner| inner.iter().position(&has_marker));

            match marker_hook_idx {
                Some(hi) => {
                    let existing = &arr[idx]["hooks"][hi];
                    if *existing == new_hook_entry {
                        eprintln!(
                            "tirith: {event_name} hook in {}, up to date",
                            path.display()
                        );
                        return Ok(());
                    }
                    if !force {
                        if dry_run {
                            eprintln!(
                                "[dry-run] would error: {event_name} hook in {} has different config — use --force to update",
                                path.display()
                            );
                            return Ok(());
                        }
                        return Err(format!(
                            "{event_name} hook in {} has different config than expected — use --force to update",
                            path.display()
                        ));
                    }
                    if !dry_run {
                        super::fs_helpers::create_backup(path, true)?;
                    }
                    arr[idx]["hooks"][hi] = new_hook_entry;
                }
                None => {
                    // Matcher exists but has no tirith hook: append to inner
                    // hooks[], replacing it if missing or non-array (e.g. null).
                    let obj = arr[idx]
                        .as_object_mut()
                        .ok_or_else(|| "matcher entry is not an object".to_string())?;
                    if !obj.get("hooks").is_some_and(|v| v.is_array()) {
                        obj.insert("hooks".to_string(), json!([]));
                    }
                    let inner_arr = obj["hooks"]
                        .as_array_mut()
                        .expect("just ensured hooks is an array");
                    inner_arr.push(new_hook_entry);
                }
            }
        }
        _ => {
            if !force {
                if dry_run {
                    eprintln!(
                        "[dry-run] would error: multiple {matcher_name} matcher entries in {} — use --force to deduplicate",
                        path.display()
                    );
                    return Ok(());
                }
                return Err(format!(
                    "multiple {matcher_name} matcher entries in {} — use --force to deduplicate",
                    path.display()
                ));
            }
            if !dry_run {
                super::fs_helpers::create_backup(path, true)?;
            }

            // Remove marker-matching hooks from all matchers; collect the
            // non-marker hooks from duplicates into the first matcher rather
            // than silently dropping them.
            let mut orphan_hooks: Vec<Value> = Vec::new();
            for (pos, &idx) in matcher_indices.iter().enumerate() {
                if let Some(inner) = arr[idx]["hooks"].as_array_mut() {
                    inner.retain(|h| !has_marker(h));
                    if pos > 0 {
                        orphan_hooks.append(inner);
                    }
                }
            }

            // Replace `hooks` if missing or non-array (e.g. null).
            let first = arr[matcher_indices[0]]
                .as_object_mut()
                .ok_or_else(|| "matcher entry is not an object".to_string())?;
            if !first.get("hooks").is_some_and(|v| v.is_array()) {
                first.insert("hooks".to_string(), json!([]));
            }
            let inner_arr = first["hooks"]
                .as_array_mut()
                .expect("just ensured hooks is an array");

            inner_arr.extend(orphan_hooks);
            inner_arr.push(new_hook_entry);

            for &idx in matcher_indices[1..].iter().rev() {
                arr.remove(idx);
            }
        }
    }

    let content = serde_json::to_string_pretty(&config).map_err(|e| format!("serialize: {e}"))?;

    if dry_run {
        eprintln!(
            "[dry-run] would write {} ({} bytes)",
            path.display(),
            content.len()
        );
        return Ok(());
    }

    super::fs_helpers::atomic_write(path, &content, 0o644)?;
    eprintln!("tirith: wrote {}", path.display());
    Ok(())
}

/// Merge a tirith PreToolUse hook into Claude Code's settings.json.
pub fn merge_claude_settings(
    path: &Path,
    hook_command: &str,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    merge_hook_settings_inner(
        path,
        "PreToolUse",
        "Bash",
        hook_command,
        "tirith-check.py",
        force,
        dry_run,
    )
}

/// Merge a tirith BeforeTool hook into Gemini CLI's settings.json.
pub fn merge_gemini_settings(
    path: &Path,
    hook_command: &str,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    merge_hook_settings_inner(
        path,
        "BeforeTool",
        "run_shell_command",
        hook_command,
        "tirith-security-guard-gemini.py",
        force,
        dry_run,
    )
}

/// Merge a tirith hook into VS Code's settings.json using a JSONC managed block.
/// Preserves all content outside the block byte-for-byte; errors (with manual
/// instructions) if a `"hooks"` key already exists outside the block.
pub fn merge_vscode_settings(
    path: &Path,
    hook_command: &str,
    force: bool,
    dry_run: bool,
) -> Result<(), String> {
    let raw = if path.exists() {
        fs::read_to_string(path).map_err(|e| format!("read {}: {e}", path.display()))?
    } else {
        "{\n}\n".to_string()
    };

    let begin_marker = "// BEGIN tirith-hooks";
    let end_marker = "// END tirith-hooks";

    let has_begin = raw.contains(begin_marker);

    if has_begin && !force {
        eprintln!("tirith: VS Code hooks in {}, up to date", path.display());
        return Ok(());
    }

    let already_backed_up;
    let working_text = if has_begin && force {
        if !dry_run {
            super::fs_helpers::create_backup(path, true)?;
            already_backed_up = true;
        } else {
            already_backed_up = false;
        }
        remove_managed_block(&raw, begin_marker, end_marker)?
    } else {
        already_backed_up = false;
        raw.clone()
    };

    let managed_block = format!(
        "\x20\x20{begin_marker}\n\
         \x20\x20\"hooks\": {{\n\
         \x20\x20\x20\x20\"PreToolUse\": [\n\
         \x20\x20\x20\x20\x20\x20{{\n\
         \x20\x20\x20\x20\x20\x20\x20\x20\"type\": \"command\",\n\
         \x20\x20\x20\x20\x20\x20\x20\x20\"command\": \"{hook_command}\"\n\
         \x20\x20\x20\x20\x20\x20}}\n\
         \x20\x20\x20\x20]\n\
         \x20\x20}},\n\
         \x20\x20{end_marker}"
    );

    // Scan for an existing "hooks" key outside the managed block.
    let hooks_key_re =
        regex::Regex::new(r#"^\s*"hooks"\s*:"#).map_err(|e| format!("regex compile: {e}"))?;

    let mut in_managed_block = false;
    for line in working_text.lines() {
        if line.contains(begin_marker) {
            in_managed_block = true;
            continue;
        }
        if line.contains(end_marker) {
            in_managed_block = false;
            continue;
        }
        if !in_managed_block && hooks_key_re.is_match(line) {
            println!(
                "Add the following to your hooks.PreToolUse array in {}:\n\
                 {{\n\
                 \x20\x20\"type\": \"command\",\n\
                 \x20\x20\"command\": \"{hook_command}\"\n\
                 }}",
                path.display()
            );
            return Err(format!(
                "tirith: {} already has a \"hooks\" key — cannot safely merge. \
                 Add the hook entry shown above manually.",
                path.display()
            ));
        }
    }

    // Insert the managed block before the file's closing brace.
    let insert_pos = working_text.rfind('}').ok_or_else(|| {
        println!(
            "Add the following to {}:\n{}",
            path.display(),
            managed_block
        );
        format!(
            "tirith: could not locate insertion point in {} — add hook manually",
            path.display()
        )
    })?;

    let before_brace = &working_text[..insert_pos];
    let mut result = String::new();

    // The last non-empty, non-comment line needs a trailing comma before the
    // managed block follows it in the same object.
    let needs_comma = before_brace
        .lines()
        .rev()
        .find(|line| {
            let trimmed = line.trim();
            !trimmed.is_empty() && !trimmed.starts_with("//")
        })
        .map(|line| {
            let trimmed = line.trim();
            !trimmed.ends_with(',') && !trimmed.ends_with('{')
        })
        .unwrap_or(false);

    if needs_comma {
        let lines: Vec<&str> = before_brace.lines().collect();
        for i in (0..lines.len()).rev() {
            let trimmed = lines[i].trim();
            if !trimmed.is_empty() && !trimmed.starts_with("//") {
                result = lines[..i].join("\n");
                if !result.is_empty() {
                    result.push('\n');
                }
                result.push_str(lines[i]);
                result.push(',');
                result.push('\n');
                if i + 1 < lines.len() {
                    result.push_str(&lines[i + 1..].join("\n"));
                    result.push('\n');
                }
                break;
            }
        }
        if result.is_empty() {
            result = before_brace.to_string();
        }
    } else {
        result = before_brace.to_string();
        if !result.ends_with('\n') {
            result.push('\n');
        }
    }

    result.push_str(&managed_block);
    result.push('\n');
    result.push_str(&working_text[insert_pos..]);

    if !result.ends_with('\n') {
        result.push('\n');
    }

    if dry_run {
        eprintln!(
            "[dry-run] would write {} ({} bytes)",
            path.display(),
            result.len()
        );
        return Ok(());
    }

    // High-value user content: always back up on first-time insertion (skip if
    // the force+remove path above already backed up this invocation).
    if path.exists() && !already_backed_up {
        super::fs_helpers::create_backup_always(path)?;
    }

    super::fs_helpers::atomic_write(path, &result, 0o644)?;
    eprintln!("tirith: wrote {}", path.display());
    Ok(())
}

/// Remove all lines between `begin_marker` and `end_marker` (inclusive).
fn remove_managed_block(
    text: &str,
    begin_marker: &str,
    end_marker: &str,
) -> Result<String, String> {
    let mut result = Vec::new();
    let mut suppressing = false;

    for line in text.lines() {
        if line.contains(begin_marker) {
            suppressing = true;
            continue;
        }
        if line.contains(end_marker) {
            if !suppressing {
                return Err("tirith: found END marker without BEGIN in managed block".to_string());
            }
            suppressing = false;
            continue;
        }
        if !suppressing {
            result.push(line);
        }
    }

    if suppressing {
        return Err(
            "tirith: corrupted tirith-hooks block — missing END marker, fix manually".to_string(),
        );
    }

    let mut out = result.join("\n");
    if !out.ends_with('\n') {
        out.push('\n');
    }
    Ok(out)
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::json;

    #[test]
    fn mcp_json_creates_new_file() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json(&path, "tirith", json!({"command": "tirith"}), false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["mcpServers"]["tirith"]["command"], "tirith");
    }

    #[test]
    fn mcp_json_preserves_existing_servers() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        fs::write(&path, r#"{"mcpServers":{"other":{"command":"other"}}}"#).unwrap();

        merge_mcp_json(&path, "tirith", json!({"command": "tirith"}), false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["mcpServers"]["other"]["command"], "other");
        assert_eq!(content["mcpServers"]["tirith"]["command"], "tirith");
    }

    #[test]
    fn mcp_json_skip_if_identical() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        let config = json!({"command": "tirith"});
        merge_mcp_json(&path, "tirith", config.clone(), false, false).unwrap();

        merge_mcp_json(&path, "tirith", config, false, false).unwrap();
    }

    #[test]
    fn mcp_json_drift_error_without_force() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json(&path, "tirith", json!({"command": "old"}), false, false).unwrap();

        let result = merge_mcp_json(&path, "tirith", json!({"command": "new"}), false, false);
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("different config"));
    }

    #[test]
    fn mcp_json_drift_warning_in_dry_run() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json(&path, "tirith", json!({"command": "old"}), false, false).unwrap();

        // dry_run + drift must not error.
        let result = merge_mcp_json(&path, "tirith", json!({"command": "new"}), false, true);
        assert!(result.is_ok());
    }

    #[test]
    fn mcp_json_force_replaces_entry() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json(&path, "tirith", json!({"command": "old"}), false, false).unwrap();

        merge_mcp_json(&path, "tirith", json!({"command": "new"}), true, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["mcpServers"]["tirith"]["command"], "new");
    }

    #[test]
    fn mcp_json_dry_run_no_write() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");

        merge_mcp_json(&path, "tirith", json!({"command": "tirith"}), false, true).unwrap();
        assert!(!path.exists());
    }

    #[test]
    fn mcp_json_dry_run_force_no_backup() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json(&path, "tirith", json!({"command": "old"}), false, false).unwrap();

        // dry-run + force must not create backup files.
        merge_mcp_json(&path, "tirith", json!({"command": "new"}), true, true).unwrap();

        let backup_count = fs::read_dir(dir.path())
            .unwrap()
            .filter(|e| {
                e.as_ref()
                    .unwrap()
                    .file_name()
                    .to_string_lossy()
                    .contains("tirith-backup")
            })
            .count();
        assert_eq!(backup_count, 0);
    }

    #[test]
    fn mcp_json_vscode_servers_key() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        merge_mcp_json_with_key(
            &path,
            "tirith-gateway",
            json!({"type": "stdio", "command": "tirith", "args": ["mcp-server"]}),
            "servers",
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["servers"]["tirith-gateway"]["type"], "stdio");
        assert_eq!(content["servers"]["tirith-gateway"]["command"], "tirith");
        // Must NOT have "mcpServers" key
        assert!(content.get("mcpServers").is_none());
    }

    #[test]
    fn mcp_json_vscode_preserves_existing_servers() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("mcp.json");
        fs::write(
            &path,
            r#"{"servers":{"other":{"type":"stdio","command":"other"}}}"#,
        )
        .unwrap();

        merge_mcp_json_with_key(
            &path,
            "tirith-gateway",
            json!({"type": "stdio", "command": "tirith"}),
            "servers",
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["servers"]["other"]["command"], "other");
        assert_eq!(content["servers"]["tirith-gateway"]["command"], "tirith");
    }

    #[test]
    fn hooks_json_creates_new_file_with_version() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("hooks.json");
        let entry = json!({"command": "hooks/tirith-hook.sh", "type": "command"});

        merge_hooks_json(
            &path,
            "beforeShellExecution",
            entry,
            "tirith-hook",
            false,
            false,
            true,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        assert_eq!(content["version"], 1);
        assert!(content["hooks"]["beforeShellExecution"].is_array());
    }

    #[test]
    fn hooks_json_skip_if_identical() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("hooks.json");
        let entry = json!({"command": "hooks/tirith-hook.sh"});

        merge_hooks_json(
            &path,
            "pre_run_command",
            entry.clone(),
            "tirith-hook",
            false,
            false,
            false,
        )
        .unwrap();
        // Idempotent
        merge_hooks_json(
            &path,
            "pre_run_command",
            entry,
            "tirith-hook",
            false,
            false,
            false,
        )
        .unwrap();
    }

    #[test]
    fn hooks_json_drift_error_without_force() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("hooks.json");
        merge_hooks_json(
            &path,
            "beforeShellExecution",
            json!({"command": "hooks/tirith-hook.sh", "timeout": 10}),
            "tirith-hook",
            false,
            false,
            true,
        )
        .unwrap();

        let result = merge_hooks_json(
            &path,
            "beforeShellExecution",
            json!({"command": "hooks/tirith-hook.sh", "timeout": 15}),
            "tirith-hook",
            false,
            false,
            true,
        );
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("different config"));
    }

    #[test]
    fn hooks_json_preserves_other_hooks() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("hooks.json");
        fs::write(
            &path,
            r#"{"hooks":{"beforeShellExecution":[{"command":"other.sh"}]}}"#,
        )
        .unwrap();

        merge_hooks_json(
            &path,
            "beforeShellExecution",
            json!({"command": "hooks/tirith-hook.sh"}),
            "tirith-hook",
            false,
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["beforeShellExecution"].as_array().unwrap();
        assert_eq!(arr.len(), 2);
    }

    #[test]
    fn claude_settings_creates_new() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        merge_claude_settings(&path, "python3 hook.py", false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["PreToolUse"].as_array().unwrap();
        assert_eq!(arr.len(), 1);
        assert_eq!(arr[0]["matcher"], "Bash");
    }

    #[test]
    fn claude_settings_preserves_other_matchers() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        fs::write(
            &path,
            r#"{"hooks":{"PreToolUse":[{"matcher":"Write","hooks":[]}]}}"#,
        )
        .unwrap();

        merge_claude_settings(&path, "python3 tirith.py", false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["PreToolUse"].as_array().unwrap();
        assert_eq!(arr.len(), 2);
    }

    #[test]
    fn vscode_settings_creates_managed_block() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false).unwrap();

        let content = fs::read_to_string(&path).unwrap();
        assert!(content.contains("// BEGIN tirith-hooks"));
        assert!(content.contains("// END tirith-hooks"));
        assert!(content.contains("tirith-hook.sh"));
    }

    #[test]
    fn vscode_settings_skip_if_block_exists() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false).unwrap();

        // Second call should skip
        merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false).unwrap();
    }

    #[test]
    fn vscode_settings_hard_error_on_existing_hooks_key() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        fs::write(&path, "{\n  \"hooks\": {\n    \"PreToolUse\": []\n  }\n}\n").unwrap();

        let result = merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false);
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("already has a \"hooks\" key"));
    }

    #[test]
    fn vscode_settings_preserves_content_outside_block() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        let original = "{\n  \"editor.fontSize\": 14\n}\n";
        fs::write(&path, original).unwrap();

        merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false).unwrap();

        let content = fs::read_to_string(&path).unwrap();
        assert!(content.contains("\"editor.fontSize\": 14"));
        assert!(content.contains("// BEGIN tirith-hooks"));
    }

    #[test]
    fn vscode_settings_preserves_jsonc_features() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // JSONC content: comments, trailing comma, URL string with "https://"
        let original = "\
{\n\
  // Editor configuration\n\
  \"editor.fontSize\": 14,\n\
  \"editor.tabSize\": 2,\n\
  // API endpoint (do not change)\n\
  \"myExtension.url\": \"https://x.com/api/v1\",\n\
}\n";
        fs::write(&path, original).unwrap();

        merge_vscode_settings(&path, "hooks/tirith-hook.sh", false, false).unwrap();

        let content = fs::read_to_string(&path).unwrap();
        // All original content preserved
        assert!(
            content.contains("// Editor configuration"),
            "comment preserved"
        );
        assert!(
            content.contains("\"editor.fontSize\": 14"),
            "fontSize preserved"
        );
        assert!(
            content.contains("\"editor.tabSize\": 2"),
            "tabSize preserved"
        );
        assert!(
            content.contains("// API endpoint (do not change)"),
            "second comment preserved"
        );
        assert!(
            content.contains("\"myExtension.url\": \"https://x.com/api/v1\""),
            "URL value preserved"
        );
        // Managed block inserted
        assert!(content.contains("// BEGIN tirith-hooks"));
        assert!(content.contains("// END tirith-hooks"));
        assert!(content.contains("tirith-hook.sh"));
    }

    #[test]
    fn vscode_settings_force_preserves_jsonc_outside_block() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        // First setup
        merge_vscode_settings(&path, "hooks/old-hook.sh", false, false).unwrap();

        // Manually add JSONC content outside the managed block
        let content = fs::read_to_string(&path).unwrap();
        let augmented = content.replace(
            "{\n",
            "{\n  // My custom comment\n  \"custom.setting\": true,\n",
        );
        fs::write(&path, &augmented).unwrap();

        // Force update should preserve content outside managed block
        merge_vscode_settings(&path, "hooks/new-hook.sh", true, false).unwrap();

        let result = fs::read_to_string(&path).unwrap();
        assert!(
            result.contains("// My custom comment"),
            "custom comment preserved after force"
        );
        assert!(
            result.contains("\"custom.setting\": true"),
            "custom setting preserved after force"
        );
        assert!(result.contains("new-hook.sh"), "new hook command present");
        assert!(!result.contains("old-hook.sh"), "old hook command removed");
    }

    #[test]
    fn remove_managed_block_removes_block() {
        let text = "before\n// BEGIN x\nstuff\n// END x\nafter\n";
        let result = remove_managed_block(text, "// BEGIN x", "// END x").unwrap();
        assert_eq!(result, "before\nafter\n");
    }

    #[test]
    fn remove_managed_block_errors_on_missing_end() {
        let text = "before\n// BEGIN x\nstuff\n";
        let result = remove_managed_block(text, "// BEGIN x", "// END x");
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("missing END"));
    }

    #[test]
    fn remove_managed_block_errors_on_orphan_end() {
        let text = "before\n// END x\nstuff\n";
        let result = remove_managed_block(text, "// BEGIN x", "// END x");
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("END marker without BEGIN"));
    }

    #[test]
    fn gemini_settings_creates_new() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 1);
        assert_eq!(arr[0]["matcher"], "run_shell_command");
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 1);
        assert_eq!(
            inner[0]["command"],
            "python3 tirith-security-guard-gemini.py"
        );
    }

    #[test]
    fn gemini_settings_preserves_other_matchers() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"other_tool","hooks":[]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 2);
    }

    #[test]
    fn gemini_settings_preserves_other_hooks_in_same_matcher() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Existing run_shell_command matcher with a non-tirith hook
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":[{"type":"command","command":"other-hook.py"}]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 1, "should still be one matcher entry");
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 2, "should have both hooks");
        assert_eq!(inner[0]["command"], "other-hook.py");
        assert_eq!(
            inner[1]["command"],
            "python3 tirith-security-guard-gemini.py"
        );
    }

    #[test]
    fn gemini_settings_skip_if_identical() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        let cmd = "python3 tirith-security-guard-gemini.py";
        merge_gemini_settings(&path, cmd, false, false).unwrap();
        // Second call should be idempotent
        merge_gemini_settings(&path, cmd, false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 1);
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 1, "no duplicate hooks");
    }

    #[test]
    fn gemini_settings_drift_error_without_force() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            false,
        )
        .unwrap();

        let result = merge_gemini_settings(
            &path,
            "python3 /new/tirith-security-guard-gemini.py",
            false,
            false,
        );
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("different config"));
    }

    #[test]
    fn gemini_settings_force_replaces_only_tirith_hook() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Matcher with tirith hook + another hook
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":[{"type":"command","command":"other-hook.py"},{"type":"command","command":"python3 tirith-security-guard-gemini.py"}]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 /new/path/tirith-security-guard-gemini.py",
            true,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let inner = content["hooks"]["BeforeTool"][0]["hooks"]
            .as_array()
            .unwrap();
        assert_eq!(inner.len(), 2, "both hooks present");
        assert_eq!(inner[0]["command"], "other-hook.py", "other hook preserved");
        assert_eq!(
            inner[1]["command"], "python3 /new/path/tirith-security-guard-gemini.py",
            "tirith hook updated"
        );
    }

    #[test]
    fn gemini_settings_multiple_matchers_error_without_force() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Two run_shell_command matcher entries
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":[{"type":"command","command":"a.py"}]},{"matcher":"run_shell_command","hooks":[{"type":"command","command":"b.py"}]}]}}"#,
        )
        .unwrap();

        let result = merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            false,
        );
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("multiple"));
    }

    #[test]
    fn gemini_settings_multiple_matchers_force_deduplicates() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Two run_shell_command matchers, both with a tirith hook
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":[{"type":"command","command":"python3 tirith-security-guard-gemini.py"}]},{"matcher":"run_shell_command","hooks":[{"type":"command","command":"python3 /old/tirith-security-guard-gemini.py"}]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 /new/tirith-security-guard-gemini.py",
            true,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        // All duplicates removed, consolidated into one
        assert_eq!(arr.len(), 1, "deduplicated to one matcher");
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 1);
        assert_eq!(
            inner[0]["command"],
            "python3 /new/tirith-security-guard-gemini.py"
        );
    }

    #[test]
    fn gemini_settings_force_consolidates_mixed_hooks_from_duplicates() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Two run_shell_command matchers: first has tirith + other hook, second has another hook
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":[{"type":"command","command":"python3 tirith-security-guard-gemini.py"},{"type":"command","command":"other-a.py"}]},{"matcher":"run_shell_command","hooks":[{"type":"command","command":"other-b.py"}]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 /new/tirith-security-guard-gemini.py",
            true,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 1, "consolidated to one matcher");
        let inner = arr[0]["hooks"].as_array().unwrap();
        // other-a from first, other-b from second (consolidated), then new tirith hook
        assert_eq!(inner.len(), 3, "all hooks consolidated");
        assert_eq!(inner[0]["command"], "other-a.py");
        assert_eq!(inner[1]["command"], "other-b.py");
        assert_eq!(
            inner[2]["command"],
            "python3 /new/tirith-security-guard-gemini.py"
        );

        // Running again without --force should succeed (convergent)
        merge_gemini_settings(
            &path,
            "python3 /new/tirith-security-guard-gemini.py",
            false,
            false,
        )
        .unwrap();
    }

    #[test]
    fn gemini_settings_force_handles_malformed_matcher_hooks() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Two matchers: first has hooks=null (malformed), second has a tirith hook
        fs::write(
            &path,
            r#"{"hooks":{"BeforeTool":[{"matcher":"run_shell_command","hooks":null},{"matcher":"run_shell_command","hooks":[{"type":"command","command":"python3 tirith-security-guard-gemini.py"}]}]}}"#,
        )
        .unwrap();

        merge_gemini_settings(
            &path,
            "python3 /new/tirith-security-guard-gemini.py",
            true,
            false,
        )
        .unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["BeforeTool"].as_array().unwrap();
        assert_eq!(arr.len(), 1, "consolidated to one matcher");
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 1);
        assert_eq!(
            inner[0]["command"], "python3 /new/tirith-security-guard-gemini.py",
            "tirith hook must be present after force"
        );
    }

    #[test]
    fn gemini_settings_dry_run_no_write() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        merge_gemini_settings(
            &path,
            "python3 tirith-security-guard-gemini.py",
            false,
            true,
        )
        .unwrap();
        assert!(!path.exists());
    }

    #[test]
    fn claude_inner_preserves_other_hooks_in_bash_matcher() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");
        // Bash matcher with a non-tirith hook
        fs::write(
            &path,
            r#"{"hooks":{"PreToolUse":[{"matcher":"Bash","hooks":[{"type":"command","command":"other-hook.py"}]}]}}"#,
        )
        .unwrap();

        merge_claude_settings(&path, "python3 tirith-check.py", false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let arr = content["hooks"]["PreToolUse"].as_array().unwrap();
        assert_eq!(arr.len(), 1, "single Bash matcher");
        let inner = arr[0]["hooks"].as_array().unwrap();
        assert_eq!(inner.len(), 2, "both hooks preserved");
        assert_eq!(inner[0]["command"], "other-hook.py");
        assert_eq!(inner[1]["command"], "python3 tirith-check.py");
    }

    #[test]
    fn claude_inner_idempotent() {
        let dir = tempfile::tempdir().unwrap();
        let path = dir.path().join("settings.json");

        let cmd = "python3 tirith-check.py";
        merge_claude_settings(&path, cmd, false, false).unwrap();
        merge_claude_settings(&path, cmd, false, false).unwrap();

        let content: Value = serde_json::from_str(&fs::read_to_string(&path).unwrap()).unwrap();
        let inner = content["hooks"]["PreToolUse"][0]["hooks"]
            .as_array()
            .unwrap();
        assert_eq!(inner.len(), 1, "no duplicate");
    }
}