throttlecrab 0.4.35

A high-performance GCRA (Generic Cell Rate Algorithm) rate limiter library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
use super::{PeriodicStore, RateLimiter};
use std::time::{Duration, SystemTime};

#[test]
fn test_basic_rate_limiting() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // First request should succeed
    let now = SystemTime::now();
    let (allowed, result) = limiter.rate_limit("test", 5, 10, 60, 1, now).unwrap();
    assert!(allowed);
    assert_eq!(result.limit, 5);
    assert_eq!(result.remaining, 4);
}

#[test]
fn test_burst_capacity() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Should allow burst capacity requests
    let now = SystemTime::now();
    for i in 0..5 {
        let (allowed, result) = limiter.rate_limit("burst_test", 5, 10, 60, 1, now).unwrap();
        assert!(allowed, "Request {} should be allowed", i + 1);
        assert_eq!(result.remaining, 5 - (i + 1) as i64);
    }

    // 6th request should be blocked
    let (allowed, result) = limiter.rate_limit("burst_test", 5, 10, 60, 1, now).unwrap();
    assert!(!allowed);
    assert_eq!(result.remaining, 0);
    assert!(result.retry_after.as_secs() > 0);
}

#[test]
fn test_rate_replenishment() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Use all burst capacity
    let now = SystemTime::now();
    let (allowed1, _) = limiter
        .rate_limit("replenish_test", 2, 60, 60, 1, now)
        .unwrap();
    let (allowed2, _) = limiter
        .rate_limit("replenish_test", 2, 60, 60, 1, now)
        .unwrap();
    assert!(allowed1);
    assert!(allowed2);

    // Should be blocked
    let (allowed3, _result) = limiter
        .rate_limit("replenish_test", 2, 60, 60, 1, now)
        .unwrap();
    assert!(!allowed3);

    // Should allow one more
    let later = now + Duration::from_secs(1);
    let (allowed4, _) = limiter
        .rate_limit("replenish_test", 2, 60, 60, 1, later)
        .unwrap();
    assert!(allowed4);
}

#[test]
fn test_different_keys() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Use a burst of 2 to make the test clearer
    // Different keys should have independent limits
    let now = SystemTime::now();
    let (allowed1, _) = limiter.rate_limit("key1", 2, 2, 60, 1, now).unwrap();
    let (allowed2, _) = limiter.rate_limit("key2", 2, 2, 60, 1, now).unwrap();
    assert!(allowed1);
    assert!(allowed2);

    // Use up remaining burst for key1
    let (allowed3, _) = limiter.rate_limit("key1", 2, 2, 60, 1, now).unwrap();
    assert!(allowed3);

    // Third request for key1 should be blocked
    let (allowed4, _) = limiter.rate_limit("key1", 2, 2, 60, 1, now).unwrap();
    assert!(!allowed4);

    // But key2 should still have one more
    let (allowed5, _) = limiter.rate_limit("key2", 2, 2, 60, 1, now).unwrap();
    assert!(allowed5);

    // Now key2 should also be blocked
    let (allowed6, _) = limiter.rate_limit("key2", 2, 2, 60, 1, now).unwrap();
    assert!(!allowed6);
}

#[test]
fn test_quantity_parameter() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Request with quantity 5
    let now = SystemTime::now();
    let (allowed1, result1) = limiter
        .rate_limit("quantity_test", 10, 10, 60, 5, now)
        .unwrap();
    assert!(allowed1);
    assert_eq!(result1.remaining, 5);

    // Request with quantity 6 should be blocked
    let (allowed2, result2) = limiter
        .rate_limit("quantity_test", 10, 10, 60, 6, now)
        .unwrap();
    assert!(!allowed2);
    assert_eq!(result2.remaining, 5);

    // Request with quantity 5 should succeed
    let (allowed3, result3) = limiter
        .rate_limit("quantity_test", 10, 10, 60, 5, now)
        .unwrap();
    assert!(allowed3);
    assert_eq!(result3.remaining, 0);
}

#[test]
fn test_negative_quantity_error() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    let now = SystemTime::now();
    let result = limiter.rate_limit("negative_test", 10, 10, 60, -1, now);
    assert!(result.is_err());
}

#[test]
fn test_invalid_parameters() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let now = SystemTime::now();

    // Test invalid burst
    let result = limiter.rate_limit("test", 0, 10, 60, 1, now);
    assert!(result.is_err());

    // Test invalid count
    let result = limiter.rate_limit("test", 10, 0, 60, 1, now);
    assert!(result.is_err());

    // Test invalid period
    let result = limiter.rate_limit("test", 10, 10, 0, 1, now);
    assert!(result.is_err());
}

#[test]
fn test_large_quantity_overflow_protection() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Test with very large quantity that could cause overflow
    let now = SystemTime::now();
    let result = limiter.rate_limit("overflow_test", 10, 10, 60, i64::MAX / 2, now);

    // Should not panic, should handle gracefully
    assert!(result.is_ok());
    let (allowed, _) = result.unwrap();
    // With such a large quantity, it should be rejected
    assert!(!allowed);
}

#[test]
fn test_saturating_arithmetic() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Test edge cases that could cause overflow
    let now = SystemTime::now();

    // Large burst capacity
    let result = limiter.rate_limit("saturate_test", i64::MAX / 1000, 100, 60, 1, now);
    assert!(result.is_ok());

    // Large count per period
    let result = limiter.rate_limit("saturate_test2", 10, i64::MAX / 1000, 60, 1, now);
    assert!(result.is_ok());
}

#[test]
fn test_remaining_count_accuracy() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let start_time = SystemTime::now();

    // Test parameters: burst=5, rate=10/60s (1 token per 6 seconds)
    let burst = 5;
    let rate = 10;
    let period = 60;

    // Test 1: First request should have burst-1 remaining
    let (allowed, result) = limiter
        .rate_limit("remaining_test", burst, rate, period, 1, start_time)
        .unwrap();
    assert!(allowed);
    assert_eq!(
        result.remaining, 4,
        "First request should leave 4 remaining"
    );

    // Test 2: Consume rest of burst capacity
    for i in 2..=5 {
        let (allowed, result) = limiter
            .rate_limit("remaining_test", burst, rate, period, 1, start_time)
            .unwrap();
        assert!(allowed, "Request {i} should be allowed");
        assert_eq!(
            result.remaining,
            (5 - i) as i64,
            "Request {} should leave {} remaining",
            i,
            5 - i
        );
    }

    // Test 3: Next request should be blocked with 0 remaining
    let (allowed, result) = limiter
        .rate_limit("remaining_test", burst, rate, period, 1, start_time)
        .unwrap();
    assert!(!allowed, "Should be rate limited after burst");
    assert_eq!(result.remaining, 0, "Should have 0 remaining when blocked");
    assert!(
        result.retry_after.as_secs() > 0,
        "Should have positive retry_after"
    );

    // Test 4: After token replenishment, should allow with 0 remaining
    // Wait for one token to replenish (6 seconds in this case)
    let after_replenish = start_time + Duration::from_secs(6);
    let (allowed, result) = limiter
        .rate_limit("remaining_test", burst, rate, period, 1, after_replenish)
        .unwrap();
    assert!(allowed, "Should allow after replenishment");
    assert_eq!(
        result.remaining, 0,
        "Should have 0 remaining after using replenished token"
    );

    // Test 5: Immediate next request should be blocked again
    let (allowed, result) = limiter
        .rate_limit("remaining_test", burst, rate, period, 1, after_replenish)
        .unwrap();
    assert!(!allowed, "Should be blocked again");
    assert_eq!(result.remaining, 0);

    // Test 6: Test with larger quantity
    let (allowed, result) = limiter
        .rate_limit("quantity_remaining", burst, rate, period, 3, start_time)
        .unwrap();
    assert!(allowed);
    assert_eq!(
        result.remaining, 2,
        "Using quantity=3 should leave 2 remaining"
    );

    // Test 7: Quantity larger than remaining should be blocked
    let (allowed, result) = limiter
        .rate_limit("quantity_remaining", burst, rate, period, 3, start_time)
        .unwrap();
    assert!(!allowed, "Quantity larger than remaining should be blocked");
    assert_eq!(
        result.remaining, 2,
        "Remaining should not change on blocked request"
    );

    // Test 8: But smaller quantity should work
    let (allowed, result) = limiter
        .rate_limit("quantity_remaining", burst, rate, period, 2, start_time)
        .unwrap();
    assert!(allowed, "Quantity equal to remaining should be allowed");
    assert_eq!(result.remaining, 0);

    // Test 9: Edge case - very high rate (multiple tokens per second)
    let (allowed, result) = limiter
        .rate_limit("high_rate", 10, 600, 60, 1, start_time)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 9);

    // After 1 second, should have replenished ~10 tokens
    let one_sec_later = start_time + Duration::from_secs(1);

    // Use up the burst
    for _ in 0..9 {
        limiter
            .rate_limit("high_rate", 10, 600, 60, 1, start_time)
            .unwrap();
    }

    // Should have replenished some tokens after 1 second
    let (allowed, result) = limiter
        .rate_limit("high_rate", 10, 600, 60, 1, one_sec_later)
        .unwrap();
    assert!(allowed, "Should have replenished tokens");
    assert!(
        result.remaining < 10,
        "Should not be at full capacity immediately"
    );
}

#[test]
fn test_remaining_count_all_stores() {
    use super::{AdaptiveStore, ProbabilisticStore};

    // Test the same scenario with all store types
    fn test_scenario<S: super::Store>(mut limiter: RateLimiter<S>) {
        let now = SystemTime::now();

        // Use burst of 3 for simpler testing
        let burst = 3;
        let rate = 6;
        let period = 60;

        // Consume all burst
        for i in 1..=3 {
            let (allowed, result) = limiter
                .rate_limit("test_key", burst, rate, period, 1, now)
                .unwrap();
            assert!(allowed, "Request {i} should be allowed");
            assert_eq!(result.remaining, (3 - i) as i64);
        }

        // Next should be blocked
        let (allowed, result) = limiter
            .rate_limit("test_key", burst, rate, period, 1, now)
            .unwrap();
        assert!(!allowed);
        assert_eq!(result.remaining, 0);

        // After 10 seconds (1 token replenished)
        let later = now + Duration::from_secs(10);
        let (allowed, result) = limiter
            .rate_limit("test_key", burst, rate, period, 1, later)
            .unwrap();
        assert!(allowed);
        assert_eq!(
            result.remaining, 0,
            "Should use the replenished token immediately"
        );
    }

    // Test with PeriodicStore
    test_scenario(RateLimiter::new(PeriodicStore::new()));

    // Test with AdaptiveStore
    test_scenario(RateLimiter::new(AdaptiveStore::new()));

    // Test with ProbabilisticStore
    test_scenario(RateLimiter::new(ProbabilisticStore::new()));
}

#[test]
fn test_edge_cases_zero_remaining() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let now = SystemTime::now();

    // Edge case 1: Exact token replenishment timing
    // burst=2, rate=120/60s = 2 per second
    let (allowed, result) = limiter
        .rate_limit("exact_timing", 2, 120, 60, 1, now)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 1);

    let (allowed, result) = limiter
        .rate_limit("exact_timing", 2, 120, 60, 1, now)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 0);

    // Exactly 0.5 seconds later - should have 1 token
    let half_sec = now + Duration::from_millis(500);
    let (allowed, result) = limiter
        .rate_limit("exact_timing", 2, 120, 60, 1, half_sec)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 0);

    // Edge case 2: Division by zero protection
    // This would cause emission_interval to be 0
    let result = limiter.rate_limit("zero_period", 10, 10, 0, 1, now);
    assert!(result.is_err(), "Zero period should error");

    // Edge case 3: Fractional tokens
    // burst=3, rate=7/60s means ~8.57 seconds per token
    let (allowed, result) = limiter.rate_limit("fractional", 3, 7, 60, 1, now).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 2);

    // Use all burst
    limiter.rate_limit("fractional", 3, 7, 60, 1, now).unwrap();
    limiter.rate_limit("fractional", 3, 7, 60, 1, now).unwrap();

    // After 8 seconds, should still not have a token
    let eight_sec = now + Duration::from_secs(8);
    let (allowed, _) = limiter
        .rate_limit("fractional", 3, 7, 60, 1, eight_sec)
        .unwrap();
    assert!(!allowed, "Should not have token after 8 seconds");

    // After 9 seconds, should have a token
    let nine_sec = now + Duration::from_secs(9);
    let (allowed, result) = limiter
        .rate_limit("fractional", 3, 7, 60, 1, nine_sec)
        .unwrap();
    assert!(allowed, "Should have token after 9 seconds");
    assert_eq!(result.remaining, 0);

    // Edge case 4: Maximum values
    let (allowed, result) = limiter
        .rate_limit("max_burst", i64::MAX / 1000, 100, 60, 1, now)
        .unwrap();
    assert!(allowed);
    assert!(result.remaining > 0, "Should handle large burst values");
}

#[test]
fn test_quantity_variations_and_replenishment() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let start_time = SystemTime::now();

    // Test 1: Consuming multiple tokens at once
    // burst=10, rate=60/60s = 1 per second
    let (allowed, result) = limiter
        .rate_limit("multi_quantity", 10, 60, 60, 5, start_time)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 5, "Should have 5 remaining after using 5");

    // Try to consume 6 tokens (should fail)
    let (allowed, result) = limiter
        .rate_limit("multi_quantity", 10, 60, 60, 6, start_time)
        .unwrap();
    assert!(!allowed, "Should not allow quantity larger than remaining");
    assert_eq!(
        result.remaining, 5,
        "Remaining should not change on failure"
    );

    // Consume exactly what's left
    let (allowed, result) = limiter
        .rate_limit("multi_quantity", 10, 60, 60, 5, start_time)
        .unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 0);

    // Test 2: Replenishment with different quantities
    // After 3 seconds, should have 3 tokens
    let three_sec = start_time + Duration::from_secs(3);
    let (allowed, result) = limiter
        .rate_limit("multi_quantity", 10, 60, 60, 2, three_sec)
        .unwrap();
    assert!(allowed, "Should have replenished tokens");
    assert_eq!(
        result.remaining, 1,
        "Should have 1 remaining after using 2 of 3"
    );

    // Test 3: Gradual replenishment over time
    // burst=5, rate=120/60s = 2 per second
    let key = "gradual_replenish";

    // Use all burst
    for _ in 0..5 {
        limiter.rate_limit(key, 5, 120, 60, 1, start_time).unwrap();
    }

    // Check replenishment at different intervals
    // We need to test each interval independently
    let test_cases = vec![
        (500, 1, 0),  // 0.5s = 1 token, use it, 0 remaining
        (1000, 2, 1), // 1s = 2 tokens, use 1, 1 remaining
        (1500, 3, 2), // 1.5s = 3 tokens, use 1, 2 remaining
        (2000, 4, 3), // 2s = 4 tokens, use 1, 3 remaining
        (2500, 5, 4), // 2.5s = 5 tokens (full), use 1, 4 remaining
    ];

    for (millis, expected_available, expected_remaining) in test_cases {
        // Create fresh key for each test
        let test_key = format!("gradual_replenish_{millis}");

        // Use all burst
        for _ in 0..5 {
            limiter
                .rate_limit(&test_key, 5, 120, 60, 1, start_time)
                .unwrap();
        }

        // Check at specific time
        let time = start_time + Duration::from_millis(millis);
        let (allowed, result) = limiter.rate_limit(&test_key, 5, 120, 60, 1, time).unwrap();

        if expected_available > 0 {
            assert!(allowed, "At {millis}ms should be allowed");
            assert_eq!(
                result.remaining, expected_remaining,
                "At {millis}ms, should have {expected_available} tokens available, {expected_remaining} remaining after use"
            );
        } else {
            assert!(!allowed, "At {millis}ms should be blocked");
        }
    }
}

#[test]
fn test_complex_replenishment_scenarios() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let start = SystemTime::now();

    // Scenario 1: Partial burst usage with replenishment
    // burst=8, rate=240/60s = 4 per second
    let key = "partial_burst";

    // Use 6 of 8 tokens
    let (allowed, result) = limiter.rate_limit(key, 8, 240, 60, 6, start).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 2);

    // After 0.5 seconds, should have 2 + 2 = 4 tokens
    let half_sec = start + Duration::from_millis(500);
    let (allowed, result) = limiter.rate_limit(key, 8, 240, 60, 1, half_sec).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 3);

    // After 1 more second, should have 3 + 4 = 7 tokens
    let one_half_sec = start + Duration::from_millis(1500);
    let (allowed, result) = limiter
        .rate_limit(key, 8, 240, 60, 1, one_half_sec)
        .unwrap();
    assert!(allowed);
    assert_eq!(
        result.remaining, 6,
        "Should have 6 remaining after using 1 of 7"
    );

    // Scenario 2: Slow replenishment rate
    // burst=3, rate=6/60s = 1 per 10 seconds
    let key2 = "slow_replenish";

    // Use all burst
    for _ in 0..3 {
        limiter.rate_limit(key2, 3, 6, 60, 1, start).unwrap();
    }

    // After 5 seconds, should still have 0
    let five_sec = start + Duration::from_secs(5);
    let (allowed, _) = limiter.rate_limit(key2, 3, 6, 60, 1, five_sec).unwrap();
    assert!(!allowed, "Should not have token after 5 seconds");

    // After 10 seconds, should have exactly 1
    let ten_sec = start + Duration::from_secs(10);
    let (allowed, result) = limiter.rate_limit(key2, 3, 6, 60, 1, ten_sec).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 0);

    // After 20 seconds from start, should have 1 more token
    let twenty_sec = start + Duration::from_secs(20);
    let (allowed, result) = limiter.rate_limit(key2, 3, 6, 60, 1, twenty_sec).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 0);

    // Scenario 3: Fractional token accumulation
    // burst=5, rate=100/60s = ~1.67 per second
    let key3 = "fractional_accumulation";

    // Use all burst
    for _ in 0..5 {
        limiter.rate_limit(key3, 5, 100, 60, 1, start).unwrap();
    }

    // Track exact replenishment - create fresh key for each test
    let replenish_tests = vec![
        (600, true, 0),  // 0.6s = 1 token (allowed, 0 remaining)
        (1200, true, 1), // 1.2s = 2 tokens, use 1, 1 remaining
        (1800, true, 2), // 1.8s = 3 tokens, use 1, 2 remaining
        (2400, true, 3), // 2.4s = 4 tokens, use 1, 3 remaining
        (3000, true, 4), // 3.0s = 5 tokens (full), use 1, 4 remaining
    ];

    for (millis, should_allow, expected_remaining) in replenish_tests {
        let test_key = format!("fractional_accumulation_{millis}");

        // Use all burst
        for _ in 0..5 {
            limiter.rate_limit(&test_key, 5, 100, 60, 1, start).unwrap();
        }

        let time = start + Duration::from_millis(millis);
        let (allowed, result) = limiter.rate_limit(&test_key, 5, 100, 60, 1, time).unwrap();
        assert_eq!(
            allowed,
            should_allow,
            "At {}ms, request should be {}",
            millis,
            if should_allow { "allowed" } else { "blocked" }
        );
        if allowed {
            assert_eq!(
                result.remaining, expected_remaining,
                "At {millis}ms, should have {expected_remaining} remaining"
            );
        }
    }
}

#[test]
fn test_quantity_edge_cases() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());
    let now = SystemTime::now();

    // Test 1: Zero quantity (currently allowed but essentially a no-op)
    let (allowed, result) = limiter
        .rate_limit("zero_quantity", 10, 100, 60, 0, now)
        .unwrap();
    assert!(allowed, "Zero quantity should be allowed");
    assert_eq!(result.remaining, 10, "Should not consume any tokens");

    // Test 2: Negative quantity (already tested but let's be explicit)
    let result = limiter.rate_limit("neg_quantity", 10, 100, 60, -5, now);
    assert!(result.is_err(), "Negative quantity should be invalid");

    // Test 3: Quantity larger than burst
    let (allowed, result) = limiter
        .rate_limit("large_quantity", 5, 100, 60, 10, now)
        .unwrap();
    assert!(!allowed, "Quantity larger than burst should be blocked");
    assert_eq!(
        result.remaining, 5,
        "Should still have full burst available"
    );

    // Test 4: Exact burst size quantity
    let (allowed, result) = limiter
        .rate_limit("exact_burst", 10, 100, 60, 10, now)
        .unwrap();
    assert!(allowed, "Should allow quantity equal to burst");
    assert_eq!(result.remaining, 0, "Should have 0 remaining");

    // Test 5: Replenishment with large quantity requests
    // burst=20, rate=600/60s = 10 per second
    let key = "large_quantity_replenish";

    // Use 15 tokens
    let (allowed, result) = limiter.rate_limit(key, 20, 600, 60, 15, now).unwrap();
    assert!(allowed);
    assert_eq!(result.remaining, 5);

    // After 1 second, should have 5 + 10 = 15 tokens
    let one_sec = now + Duration::from_secs(1);
    let (allowed, result) = limiter.rate_limit(key, 20, 600, 60, 12, one_sec).unwrap();
    assert!(allowed, "Should allow 12 of 15 available");
    assert_eq!(result.remaining, 3);

    // Try to take 5 (should fail, only 3 available)
    let (allowed, result) = limiter.rate_limit(key, 20, 600, 60, 5, one_sec).unwrap();
    assert!(!allowed);
    assert_eq!(result.remaining, 3);
}

#[test]
fn test_rapid_time_changes() {
    let mut limiter = RateLimiter::new(PeriodicStore::new());

    // Test rapid time changes that might occur during system clock adjustments
    let base_time = SystemTime::now();

    // Make a request at base time
    let (allowed1, _) = limiter
        .rate_limit("time_jump", 3, 10, 60, 1, base_time)
        .unwrap();
    assert!(allowed1);

    // Jump backward 5 seconds
    let time_back = base_time - Duration::from_secs(5);
    let result_back = limiter.rate_limit("time_jump", 3, 10, 60, 1, time_back);
    assert!(result_back.is_ok());

    // Jump forward 10 seconds from original
    let time_forward = base_time + Duration::from_secs(10);
    let (allowed2, _) = limiter
        .rate_limit("time_jump", 3, 10, 60, 1, time_forward)
        .unwrap();
    assert!(allowed2);

    // Multiple rapid changes
    for i in 0..5 {
        let jittered_time = if i % 2 == 0 {
            base_time + Duration::from_secs(i)
        } else {
            base_time - Duration::from_secs(i)
        };

        let result = limiter.rate_limit("time_jitter", 10, 10, 60, 1, jittered_time);
        // Should handle all time changes without panicking
        assert!(result.is_ok());
    }
}