1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
//! This library provides a way easily to implement Connection Pools for any [`thrift::TThriftClient`],
//! which can then be used alongside [`bb8`] and/or [`r2d2`]
//!
//! <br>
//!
//! ## Usage
//!
//! There are 2 possible use cases
//!
//! ### As a library
//!
//! If you're implementing a library that provides a (possibly generated) thrift client,
//! you should implement the [`ThriftConnection`] and [`FromProtocol`] traits
//! for that client
//!
//! ```rust
//! # use thrift::protocol::{TInputProtocol, TOutputProtocol};
//! # use thrift_pool::{FromProtocol, ThriftConnection};
//! #
//! // A typical generated client looks like this
//! struct MyThriftClient<Ip: TInputProtocol, Op: TOutputProtocol> {
//!     i_prot: Ip,
//!     o_prot: Op,
//! }
//!
//! impl<Ip: TInputProtocol, Op: TOutputProtocol> FromProtocol for MyThriftClient<Ip, Op> {
//!     type InputProtocol = Ip;
//!
//!     type OutputProtocol = Op;
//!
//!     fn from_protocol(
//!         input_protocol: Self::InputProtocol,
//!         output_protocol: Self::OutputProtocol,
//!     ) -> Self {
//!         MyThriftClient {
//!             i_prot: input_protocol,
//!             o_prot: output_protocol,
//!         }
//!     }
//! }
//!
//! impl<Ip: TInputProtocol, Op: TOutputProtocol> ThriftConnection for MyThriftClient<Ip, Op> {
//!     type Error = thrift::Error;
//!     fn is_valid(&mut self) -> Result<(), Self::Error> {
//!        Ok(())
//!     }
//!     fn has_broken(&mut self) -> bool {
//!        false
//!    }
//! }
//!
//! ```
//!
//! ### As an application
//!
//! If you're implementing an application that uses a (possibly generated) thrift client that
//! implements [`FromProtocol`] and [`ThriftConnection`] (see previous section), you can use
//! [`r2d2`] or [`bb8`] (make sure to read their documentations) along with
//! [`ThriftConnectionManager`] to create Connection Pools for the client
//!
//! ```rust should_panic
//! # use thrift::protocol::{TInputProtocol, TOutputProtocol};
//! # use thrift_pool::{FromProtocol, ThriftConnection};
//! #
//! # struct MyThriftClient<Ip: TInputProtocol, Op: TOutputProtocol> {
//! #     i_prot: Ip,
//! #     o_prot: Op,
//! # }
//! #
//! # impl<Ip: TInputProtocol, Op: TOutputProtocol> FromProtocol for MyThriftClient<Ip, Op> {
//! #     type InputProtocol = Ip;
//! #
//! #     type OutputProtocol = Op;
//! #
//! #     fn from_protocol(
//! #         input_protocol: Self::InputProtocol,
//! #         output_protocol: Self::OutputProtocol,
//! #     ) -> Self {
//! #         MyThriftClient {
//! #             i_prot: input_protocol,
//! #             o_prot: output_protocol,
//! #         }
//! #     }
//! # }
//! #
//! # impl<Ip: TInputProtocol, Op: TOutputProtocol> ThriftConnection for MyThriftClient<Ip, Op> {
//! #     type Error = thrift::Error;
//! #     fn is_valid(&mut self) -> Result<(), Self::Error> {
//! #        Ok(())
//! #     }
//! #     fn has_broken(&mut self) -> bool {
//! #        false
//! #    }
//! # }
//! # use thrift_pool::{MakeThriftConnectionFromAddrs};
//! # use thrift::protocol::{TCompactInputProtocol, TCompactOutputProtocol};
//! # use thrift::transport::{
//! #    ReadHalf, TFramedReadTransport, TFramedWriteTransport, TTcpChannel, WriteHalf,
//! # };
//! #
//! type Client = MyThriftClient<
//!     TCompactInputProtocol<TFramedReadTransport<ReadHalf<TTcpChannel>>>,
//!     TCompactOutputProtocol<TFramedWriteTransport<WriteHalf<TTcpChannel>>>,
//! >;
//!
//! # #[tokio::main]
//! # async fn main() -> Result<(), Box<dyn std::error::Error>> {
//!   // create a connection manager
//!   let manager = MakeThriftConnectionFromAddrs::<Client, _>::new("localhost:9090").into_connection_manager();
//!   
//!   // we're able to create bb8 and r2d2 Connection Pools
//!   let bb8 = bb8::Pool::builder().build(manager.clone()).await?;
//!   let r2d2 = r2d2::Pool::builder().build(manager)?;
//!
//!   // get a connection
//!   let conn1 = bb8.get().await?;
//!   let conn2 = r2d2.get()?;
//! #  Ok(())
//! # }
//! ```
//!
//! <br>
//!
//! ## More examples
//!
//! - [hbase-thrift](https://github.com/midnightexigent/hbase-thrift-rs) -- the project from which this
//! library was extracted. implements Connection Pools for the client generated from the
//! [HBase Thrift Spec](https://github.com/apache/hbase/tree/master/hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift)
//! - [thrift-pool-tutorial](https://github.com/midnightexigent/thrift-pool-tutorial-rs) -- implements
//! Connection Pools for the client used in the official
//! [thrift tutorial](https://github.com/apache/thrift/tree/master/tutorial)

use std::{
    io::{Read, Write},
    marker::PhantomData,
    net::ToSocketAddrs,
};

use thrift::{
    protocol::{
        TBinaryInputProtocol, TBinaryOutputProtocol, TCompactInputProtocol, TCompactOutputProtocol,
        TInputProtocol, TOutputProtocol,
    },
    transport::{
        ReadHalf, TBufferedReadTransport, TBufferedWriteTransport, TFramedReadTransport,
        TFramedWriteTransport, TIoChannel, TReadTransport, TTcpChannel, TWriteTransport, WriteHalf,
    },
};

/// Create self from a [`Read`]
pub trait FromRead: TReadTransport {
    type Read: Read;
    fn from_read(read: Self::Read) -> Self;
}

impl<R: Read> FromRead for TBufferedReadTransport<R> {
    type Read = R;
    fn from_read(read: R) -> Self {
        Self::new(read)
    }
}
impl<R: Read> FromRead for TFramedReadTransport<R> {
    type Read = R;
    fn from_read(read: R) -> Self {
        Self::new(read)
    }
}

/// Create self from a [`Write`]
pub trait FromWrite: TWriteTransport {
    type Write: Write;
    fn from_write(write: Self::Write) -> Self;
}

impl<W: Write> FromWrite for TBufferedWriteTransport<W> {
    type Write = W;
    fn from_write(write: W) -> Self {
        Self::new(write)
    }
}

impl<W: Write> FromWrite for TFramedWriteTransport<W> {
    type Write = W;

    fn from_write(write: Self::Write) -> Self {
        Self::new(write)
    }
}

/// Create self from a [`TReadTransport`]
pub trait FromReadTransport: TInputProtocol {
    type ReadTransport: TReadTransport;
    fn from_read_transport(r_tran: Self::ReadTransport) -> Self;
}

impl<Rt: TReadTransport> FromReadTransport for TBinaryInputProtocol<Rt> {
    type ReadTransport = Rt;

    fn from_read_transport(r_tran: Rt) -> Self {
        Self::new(r_tran, true)
    }
}

impl<Rt: TReadTransport> FromReadTransport for TCompactInputProtocol<Rt> {
    type ReadTransport = Rt;

    fn from_read_transport(r_tran: Rt) -> Self {
        Self::new(r_tran)
    }
}

/// Create self from a [`TWriteTransport`]
pub trait FromWriteTransport: TOutputProtocol {
    type WriteTransport: TWriteTransport;
    fn from_write_transport(w_tran: Self::WriteTransport) -> Self;
}

impl<Wt: TWriteTransport> FromWriteTransport for TBinaryOutputProtocol<Wt> {
    type WriteTransport = Wt;
    fn from_write_transport(w_tran: Wt) -> Self {
        Self::new(w_tran, true)
    }
}

impl<Wt: TWriteTransport> FromWriteTransport for TCompactOutputProtocol<Wt> {
    type WriteTransport = Wt;
    fn from_write_transport(w_tran: Wt) -> Self {
        Self::new(w_tran)
    }
}

/// Create self from a [`TInputProtocol`] and a [`TOutputProtocol`]
pub trait FromProtocol {
    type InputProtocol: TInputProtocol;
    type OutputProtocol: TOutputProtocol;

    fn from_protocol(
        input_protocol: Self::InputProtocol,
        output_protocol: Self::OutputProtocol,
    ) -> Self;
}

/// Checks the validity of the connection
///
/// Used by [`ThriftConnectionManager`] to implement parts of
/// [`bb8::ManageConnection`] and/or [`r2d2::ManageConnection`]
pub trait ThriftConnection {
    /// See [r2d2::ManageConnection::Error] and/or [bb8::ManageConnection::Error]
    type Error;
    /// See [r2d2::ManageConnection::is_valid] and/or [bb8::ManageConnection::is_valid]
    fn is_valid(&mut self) -> Result<(), Self::Error>;
    /// See [r2d2::ManageConnection::has_broken] and/or [bb8::ManageConnection::has_broken]
    fn has_broken(&mut self) -> bool {
        false
    }
}

/// A trait that creates new [`ThriftConnection`]s
///
/// Used by [`ThriftConnectionManager`] to implement
/// [`bb8::ManageConnection::connect`]
/// and/or [`r2d2::ManageConnection::connect`]
pub trait MakeThriftConnection {
    /// The error type returned when a connection creation fails
    type Error;
    /// The connection type the we are trying to create
    type Output;
    /// Attempt to create a new connection
    fn make_thrift_connection(&self) -> Result<Self::Output, Self::Error>;
}

/// A [`MakeThriftConnection`] that attempts to create new connections
/// from a [`ToSocketAddrs`] and a [`FromProtocol`]
///
/// The connection is accordance with the
/// [thrift rust tutorial](https://github.com/apache/thrift/tree/master/tutorial):
///
/// * Open a [`TTcpChannel`]
/// * Split it
/// * Create `TReadTransport` and `TWriteTransport`
/// * Create `TInputProtocol` and `TOutputProtocol`
/// * Create a client with `i_prot` and `o_prot`
///
/// For that to happen, `T` needs to be able
/// to create the `Read`/`Write` `Transport`s
/// and `Input`/`Output` `Protocol`s from
/// the `ReadHalf` and `WriteHalf` of the `TTcpChannel`.
/// Those contraints should be fairly easily satisfied
/// by implementing the relevant traits in the library
///
/// ```
///
/// use thrift_pool::{MakeThriftConnectionFromAddrs, FromProtocol};
///
/// use thrift::{
///     protocol::{TCompactInputProtocol, TCompactOutputProtocol, TInputProtocol, TOutputProtocol},
///     transport::{
///         ReadHalf, TFramedReadTransport, TFramedWriteTransport, TIoChannel, TReadTransport,
///         TTcpChannel, TWriteTransport, WriteHalf,
///     },
/// };
///
/// // A typical generated client looks like this
/// struct MyThriftClient<Ip: TInputProtocol, Op: TOutputProtocol> {
///     i_prot: Ip,
///     o_prot: Op,
/// }
/// impl<Ip: TInputProtocol, Op: TOutputProtocol> FromProtocol for MyThriftClient<Ip, Op> {
///     type InputProtocol = Ip;
///
///     type OutputProtocol = Op;
///
///     fn from_protocol(
///         input_protocol: Self::InputProtocol,
///         output_protocol: Self::OutputProtocol,
///     ) -> Self {
///         MyThriftClient {
///             i_prot: input_protocol,
///             o_prot: output_protocol,
///         }
///     }
/// }
/// type Client = MyThriftClient<
///     TCompactInputProtocol<TFramedReadTransport<ReadHalf<TTcpChannel>>>,
///     TCompactOutputProtocol<TFramedWriteTransport<WriteHalf<TTcpChannel>>>,
/// >;
///
/// // The Protocols/Transports used in this client implement the necessary traits so we can do this
/// let manager =
///     MakeThriftConnectionFromAddrs::<Client, _>::new("localhost:9090").into_connection_manager();
///
/// ```

pub struct MakeThriftConnectionFromAddrs<T, S> {
    addrs: S,
    conn: PhantomData<T>,
}

impl<T, S: std::fmt::Debug> std::fmt::Debug for MakeThriftConnectionFromAddrs<T, S> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("MakeThriftConnectionFromAddrs")
            .field("addrs", &self.addrs)
            .field("conn", &self.conn)
            .finish()
    }
}
impl<T, S: Clone> Clone for MakeThriftConnectionFromAddrs<T, S> {
    fn clone(&self) -> Self {
        Self {
            addrs: self.addrs.clone(),
            conn: PhantomData,
        }
    }
}

impl<T, S> MakeThriftConnectionFromAddrs<T, S> {
    pub fn new(addrs: S) -> Self {
        Self {
            addrs,
            conn: PhantomData,
        }
    }
}

impl<
        S: ToSocketAddrs + Clone,
        Rt: FromRead<Read = ReadHalf<TTcpChannel>>,
        Ip: FromReadTransport<ReadTransport = Rt>,
        Wt: FromWrite<Write = WriteHalf<TTcpChannel>>,
        Op: FromWriteTransport<WriteTransport = Wt>,
        T: FromProtocol<InputProtocol = Ip, OutputProtocol = Op>,
    > MakeThriftConnectionFromAddrs<T, S>
{
    pub fn into_connection_manager(self) -> ThriftConnectionManager<Self> {
        ThriftConnectionManager::new(self)
    }
}

impl<
        S: ToSocketAddrs + Clone,
        Rt: FromRead<Read = ReadHalf<TTcpChannel>>,
        Ip: FromReadTransport<ReadTransport = Rt>,
        Wt: FromWrite<Write = WriteHalf<TTcpChannel>>,
        Op: FromWriteTransport<WriteTransport = Wt>,
        T: FromProtocol<InputProtocol = Ip, OutputProtocol = Op>,
    > MakeThriftConnection for MakeThriftConnectionFromAddrs<T, S>
{
    type Error = thrift::Error;

    type Output = T;

    fn make_thrift_connection(&self) -> Result<Self::Output, Self::Error> {
        let mut channel = TTcpChannel::new();
        channel.open(self.addrs.clone())?;
        let (read, write) = channel.split()?;

        let read_transport = Rt::from_read(read);
        let input_protocol = Ip::from_read_transport(read_transport);

        let write_transport = Wt::from_write(write);
        let output_protocol = Op::from_write_transport(write_transport);

        Ok(T::from_protocol(input_protocol, output_protocol))
    }
}

/// An implementor of [`bb8::ManageConnection`] and/or [`r2d2::ManageConnection`].
/// `T` should a [`MakeThriftConnection`] and `T::Output` should be a [`ThriftConnection`]
pub struct ThriftConnectionManager<T>(T);

impl<T: Clone> Clone for ThriftConnectionManager<T> {
    fn clone(&self) -> Self {
        Self(self.0.clone())
    }
}
impl<T: std::fmt::Debug> std::fmt::Debug for ThriftConnectionManager<T> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_tuple("ThriftConnectionManager")
            .field(&self.0)
            .finish()
    }
}

impl<T> ThriftConnectionManager<T> {
    pub fn new(make_thrift_connection: T) -> Self {
        Self(make_thrift_connection)
    }
}

#[cfg(feature = "impl-bb8")]
#[async_trait::async_trait]
impl<
        E: Send + std::fmt::Debug + 'static,
        C: ThriftConnection<Error = E> + Send + 'static,
        T: MakeThriftConnection<Output = C, Error = E> + Send + Sync + 'static,
    > bb8::ManageConnection for ThriftConnectionManager<T>
{
    type Connection = C;

    type Error = E;

    async fn connect(&self) -> Result<Self::Connection, Self::Error> {
        self.0.make_thrift_connection()
    }

    fn has_broken(&self, conn: &mut Self::Connection) -> bool {
        conn.has_broken()
    }

    async fn is_valid(
        &self,
        conn: &mut bb8::PooledConnection<'_, Self>,
    ) -> Result<(), Self::Error> {
        conn.is_valid()
    }
}

#[cfg(feature = "impl-r2d2")]
impl<
        E: std::error::Error + 'static,
        C: ThriftConnection<Error = E> + Send + 'static,
        T: MakeThriftConnection<Output = C, Error = E> + Send + Sync + 'static,
    > r2d2::ManageConnection for ThriftConnectionManager<T>
{
    type Connection = C;

    type Error = E;

    fn connect(&self) -> Result<Self::Connection, Self::Error> {
        self.0.make_thrift_connection()
    }

    fn has_broken(&self, conn: &mut Self::Connection) -> bool {
        conn.has_broken()
    }

    fn is_valid(&self, conn: &mut Self::Connection) -> Result<(), Self::Error> {
        conn.is_valid()
    }
}