threers 0.0.3

Drop-in three.js replacement for Rust and WebAssembly (wgpu) — THREE.* API, scene graph, PBR, post-fx, mesh BVH, CSG, an OpenSCAD front end with a watertight exact-CSG kernel, headless render, and native media codecs
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
//! Robust mesh-arrangement boolean kernel — the watertight path that replaces the
//! three-bvh-csg float kernel for OpenSCAD-parity work.
//!
//! `boolean` resolves two triangle meshes in three stages:
//! 1. **Co-refinement** (`corefine`) — compute every triangle–triangle
//!    intersection segment (BVH broad phase), snap shared endpoints identically on
//!    both meshes, and re-triangulate each mesh one flat *face* at a time with the
//!    constrained-Delaunay routine in `cdt`, so the seam is subdivided the same
//!    way on both sides.
//! 2. **Classification** — keep each refined sub-triangle by the op and which side
//!    of the *other* solid it lies on (multi-ray parity, with a coincident-face
//!    rule for shared planar faces).
//! 3. **Verification** — accept the result only if it is a closed 2-manifold
//!    (welding + T-junction healing first, then a hard gate). If it can't be
//!    verified, return `BooleanOutcome::NeedsArrangement` so the caller falls
//!    back to the float kernel rather than trust an unproven mesh — the kernel is
//!    never wrong, only sometimes deferential.
//!
//! This resolves genuinely *curved∧curved* crossings — sphere∪sphere,
//! cylinder∩cylinder, cone/sphere/cylinder mixes — to watertight meshes (which the
//! float kernel cannot: its sphere∩sphere is degenerate). Predicates use exact
//! `orient2d`/`orient3d`; the remaining fallbacks are measure-zero degeneracies
//! (e.g. two identical primitives translated along an axis, whose mirror-coincident
//! seam facets a tiny perturbation would remove) and very large coplanar faces
//! (bounded by the CDT size guard).

mod arrangement;
mod bvh;
mod coplanar;
mod cdt;
pub mod metrics;
mod predicates;
mod split;
mod tri_intersect;
mod triangulate;
mod winding;

pub use arrangement::{intersection_segments, tri_tri_segment};
pub use coplanar::coplanar_clip;
pub use predicates::{coplanar, orient2d, orient3d};
pub use split::split_triangle_by_plane;
pub use tri_intersect::tri_tri_intersect;
pub use triangulate::triangulate_with_points;
pub use winding::{point_in_mesh, winding_number};

use crate::compute_vertex_normals;
use crate::core::{BufferAttribute, BufferGeometry};
use std::collections::HashMap;

/// A three-vector in f64 (the crate's `Vector3` is f32; winding sums want f64).
pub(crate) type V3 = [f64; 3];

pub(crate) fn sub(a: V3, b: V3) -> V3 {
    [a[0] - b[0], a[1] - b[1], a[2] - b[2]]
}
pub(crate) fn cross(a: V3, b: V3) -> V3 {
    [
        a[1] * b[2] - a[2] * b[1],
        a[2] * b[0] - a[0] * b[2],
        a[0] * b[1] - a[1] * b[0],
    ]
}
pub(crate) fn dot(a: V3, b: V3) -> f64 {
    a[0] * b[0] + a[1] * b[1] + a[2] * b[2]
}
pub(crate) fn norm(a: V3) -> f64 {
    dot(a, a).sqrt()
}
pub(crate) fn sqlen(a: V3) -> f64 {
    dot(a, a)
}
fn normalize(a: V3) -> V3 {
    let l = norm(a);
    if l < 1e-18 {
        a
    } else {
        [a[0] / l, a[1] / l, a[2] / l]
    }
}

/// The three boolean operations.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum Op {
    Union,
    Difference,
    Intersection,
}

/// Result of `boolean`.
#[derive(Debug)]
pub enum BooleanOutcome {
    /// Surfaces don't cross — this mesh is the exact boolean for that class.
    Exact(BufferGeometry),
    /// Surfaces cross; the arrangement (sub-triangulation) is required (M2).
    NeedsArrangement,
}

/// Read a geometry's triangles as f64 vertex triples (indexed or soup).
pub(crate) fn triangles(g: &BufferGeometry) -> Vec<[V3; 3]> {
    let pos = match g.get_attribute("position") {
        Some(p) => &p.array,
        None => return Vec::new(),
    };
    let v = |i: usize| -> V3 { [pos[i * 3] as f64, pos[i * 3 + 1] as f64, pos[i * 3 + 2] as f64] };
    let mut out = Vec::new();
    if let Some(idx) = &g.index {
        for t in idx.chunks_exact(3) {
            out.push([v(t[0] as usize), v(t[1] as usize), v(t[2] as usize)]);
        }
    } else {
        for k in 0..pos.len() / 9 {
            out.push([v(k * 3), v(k * 3 + 1), v(k * 3 + 2)]);
        }
    }
    out
}

fn centroid(t: &[V3; 3]) -> V3 {
    [
        (t[0][0] + t[1][0] + t[2][0]) / 3.0,
        (t[0][1] + t[1][1] + t[2][1]) / 3.0,
        (t[0][2] + t[1][2] + t[2][2]) / 3.0,
    ]
}

pub(crate) fn aabb(t: &[V3; 3]) -> (V3, V3) {
    let mut mn = t[0];
    let mut mx = t[0];
    for v in &t[1..] {
        for k in 0..3 {
            mn[k] = mn[k].min(v[k]);
            mx[k] = mx[k].max(v[k]);
        }
    }
    (mn, mx)
}

pub(crate) fn aabb_overlap(a: &(V3, V3), b: &(V3, V3)) -> bool {
    for k in 0..3 {
        if a.0[k] > b.1[k] || b.0[k] > a.1[k] {
            return false;
        }
    }
    true
}

/// Do the meshes interact at all — any transversal crossing or coplanar face
/// pair? BVH-accelerated broad phase; short-circuits on the first hit.
fn interacts(ta: &[[V3; 3]], tb: &[[V3; 3]], bvh_b: &bvh::Bvh) -> bool {
    let mut cand = Vec::new();
    for a in ta {
        bvh_b.overlaps(aabb(a), &mut cand);
        for &j in &cand {
            if tri_tri_intersect(a, &tb[j]) || coplanar(a, &tb[j]) {
                return true;
            }
        }
    }
    false
}

fn build_geometry(tris: &[[V3; 3]]) -> BufferGeometry {
    let mut pos = Vec::with_capacity(tris.len() * 9);
    for t in tris {
        for v in t {
            pos.push(v[0] as f32);
            pos.push(v[1] as f32);
            pos.push(v[2] as f32);
        }
    }
    let mut g = BufferGeometry::new();
    g.set_attribute("position", BufferAttribute::new(pos, 3));
    compute_vertex_normals(&mut g);
    g
}

/// Quantized undirected edge key on the fine weld grid.
type EdgeKey = (i64, i64, i64, i64, i64, i64);
fn ekey(a: V3, b: V3) -> EdgeKey {
    let k = |p: V3| ((p[0] * 1e5).round() as i64, (p[1] * 1e5).round() as i64, (p[2] * 1e5).round() as i64);
    let (ka, kb) = (k(a), k(b));
    let (lo, hi) = if ka <= kb { (ka, kb) } else { (kb, ka) };
    (lo.0, lo.1, lo.2, hi.0, hi.1, hi.2)
}

/// Oriented-plane key (normal + signed offset), quantized. Two triangles with the
/// same key are coplanar and same-facing — one flat *face* of the input.
fn plane_key(t: &[V3; 3]) -> (i64, i64, i64, i64) {
    let n = normalize(face_normal(t));
    let d = dot(n, t[0]);
    let q = |x: f64| (x * 1e4).round() as i64;
    (q(n[0]), q(n[1]), q(n[2]), q(d))
}

/// Re-triangulate a whole coplanar **face** (group of triangles) in one CDT — the
/// fix for T-junctions: cuts crossing a face's internal diagonals become shared
/// vertices instead of mismatched splits. `boundary` is the face's outline (edges
/// on the group's border), `segs` the cut segments on it, and `tj` the T-junction
/// points from neighbouring faces landing on this face's boundary. `None` on CDT
/// failure (→ caller falls back).
fn cdt_face(
    group: &[usize],
    tris: &[[V3; 3]],
    boundary: &[(V3, V3)],
    segs: &[(V3, V3)],
    xpts: &[V3],
) -> Option<Vec<[V3; 3]>> {
    let t0 = &tris[group[0]];
    let n = normalize(face_normal(t0));
    if sqlen(n) < 1e-18 {
        return None;
    }
    let origin = t0[0];
    let ux = normalize(sub(t0[1], t0[0]));
    let uy = cross(n, ux);
    let project = |p: V3| [dot(sub(p, origin), ux), dot(sub(p, origin), uy)];
    let lift = |q: [f64; 2]| {
        [
            origin[0] + q[0] * ux[0] + q[1] * uy[0],
            origin[1] + q[0] * ux[1] + q[1] * uy[1],
            origin[2] + q[0] * ux[2] + q[1] * uy[2],
        ]
    };

    // Reserve indices 0,1,2 for a super-triangle (filled once the face's 2D bbox is
    // known). Sentinel 3D coords keep find_or_add from ever welding a real point
    // onto a super-corner.
    let mut pts3: Vec<V3> = vec![[1e30, 1e30, 1e30], [2e30, 2e30, 2e30], [3e30, 3e30, 3e30]];
    let mut pts2: Vec<[f64; 2]> = vec![[0.0; 2], [0.0; 2], [0.0; 2]];
    // Register every point first (segment/boundary endpoints + T-junctions), so a
    // point that lands on another segment is available to split it below.
    let mut raw: Vec<(V3, V3)> = Vec::with_capacity(boundary.len() + segs.len());
    for &(a, b) in boundary.iter().chain(segs.iter()) {
        find_or_add(&mut pts3, &mut pts2, a, project(a));
        find_or_add(&mut pts3, &mut pts2, b, project(b));
        raw.push((a, b));
    }
    // Cross-face T-junction heal: any global intersection point that lies on this
    // face's plane AND strictly on one of its edges/cuts must be a vertex here too,
    // so the shared edge is split identically on both incident faces.
    for &p in xpts {
        if dot(sub(p, origin), n).abs() > 1e-7 {
            continue;
        }
        if raw.iter().any(|&(a, b)| on_segment_interior(a, b, p)) {
            find_or_add(&mut pts3, &mut pts2, p, project(p));
        }
    }
    // Build the enclosing super-triangle from the real points' 2D bounding box.
    let (mut mnx, mut mny, mut mxx, mut mxy) =
        (f64::INFINITY, f64::INFINITY, f64::NEG_INFINITY, f64::NEG_INFINITY);
    for q in &pts2[3..] {
        mnx = mnx.min(q[0]);
        mny = mny.min(q[1]);
        mxx = mxx.max(q[0]);
        mxy = mxy.max(q[1]);
    }
    if !mnx.is_finite() {
        return None;
    }
    let span = (mxx - mnx).max(mxy - mny).max(1.0);
    let d = span * 20.0;
    let (cx, cy) = ((mnx + mxx) * 0.5, (mny + mxy) * 0.5);
    let sv = [[cx - d, cy - d], [cx + d, cy - d], [cx, cy + d]];
    for k in 0..3 {
        pts2[k] = sv[k];
        pts3[k] = lift(sv[k]);
    }

    // Split each raw segment at every registered point lying on it, so no vertex is
    // ever strictly interior to a constraint (which recover_edge cannot heal). This
    // is what makes shared boundary edges and internal cuts conform without
    // T-junctions.
    let mut cons: Vec<[usize; 2]> = Vec::new();
    for &(a, b) in &raw {
        let (a2, b2) = (project(a), project(b));
        let ab = [b2[0] - a2[0], b2[1] - a2[1]];
        let len2 = ab[0] * ab[0] + ab[1] * ab[1];
        if len2 < 1e-18 {
            continue;
        }
        let tol = 1e-9 * len2; // squared perpendicular distance threshold
        let mut on: Vec<(f64, usize)> = Vec::new();
        for i in 3..pts2.len() {
            let q = pts2[i];
            let t = ((q[0] - a2[0]) * ab[0] + (q[1] - a2[1]) * ab[1]) / len2;
            if t < -1e-9 || t > 1.0 + 1e-9 {
                continue;
            }
            let proj = [a2[0] + t * ab[0], a2[1] + t * ab[1]];
            let d2 = (q[0] - proj[0]).powi(2) + (q[1] - proj[1]).powi(2);
            if d2 <= tol {
                on.push((t.clamp(0.0, 1.0), i));
            }
        }
        on.sort_by(|x, y| x.0.partial_cmp(&y.0).unwrap());
        on.dedup_by_key(|x| x.1);
        for w in on.windows(2) {
            if w[0].1 != w[1].1 {
                cons.push([w[0].1, w[1].1]);
            }
        }
    }

    let idx = cdt::triangulate_constrained(&pts2, &cons)?;

    // Keep the real (non-super) CDT triangles.
    let mut work: Vec<[usize; 3]> =
        idx.into_iter().filter(|t| t[0] >= 3 && t[1] >= 3 && t[2] >= 3).collect();

    // Heal T-junctions: the flip-based recovery can leave a vertex lying on the
    // *edge* of a neighbouring triangle (when a collinear split point wasn't routed
    // through both sides). Split any such triangle so every on-edge vertex becomes a
    // shared corner — otherwise dropping the resulting sliver would open a crack.
    let on_edge = |e0: usize, e1: usize, p: usize| -> bool {
        let (a, b, q) = (pts2[e0], pts2[e1], pts2[p]);
        if orient2d(a, b, q).abs() > 1e-9 {
            return false; // not collinear
        }
        let ab = [b[0] - a[0], b[1] - a[1]];
        let len2 = ab[0] * ab[0] + ab[1] * ab[1];
        if len2 < 1e-18 {
            return false;
        }
        let t = ((q[0] - a[0]) * ab[0] + (q[1] - a[1]) * ab[1]) / len2;
        t > 1e-7 && t < 1.0 - 1e-7
    };
    // Work-stack heal: pop a triangle, and if any registered point lies strictly on
    // one of its edges, split it there and re-process the two halves; otherwise it's
    // clean. Points are fixed (from pts2), so each triangle splits a bounded number
    // of times and both triangles sharing an edge split at the same point → no
    // T-junctions. The cap guards against a pathological blow-up (→ caller falls back).
    let np = pts2.len();
    let mut healed: Vec<[usize; 3]> = Vec::with_capacity(work.len());
    let cap = (work.len() + np) * 32 + 1024;
    while let Some(t) = work.pop() {
        if healed.len() + work.len() > cap {
            return None;
        }
        let mut split = None;
        'find: for e in 0..3 {
            let (u, v, w) = (t[e], t[(e + 1) % 3], t[(e + 2) % 3]);
            for p in 3..np {
                if p != u && p != v && p != w && on_edge(u, v, p) {
                    split = Some((u, v, w, p));
                    break 'find;
                }
            }
        }
        match split {
            Some((u, v, w, p)) => {
                work.push([u, p, w]);
                work.push([p, v, w]);
            }
            None => healed.push(t),
        }
    }
    let work = healed;

    // Group triangles in 2D, to reject CDT triangles outside a non-convex face.
    let face2: Vec<[[f64; 2]; 3]> = group.iter().map(|&i| {
        let t = &tris[i];
        [project(t[0]), project(t[1]), project(t[2])]
    }).collect();
    let mut out = Vec::with_capacity(work.len());
    for t in work {
        let (i0, i1, i2) = (t[0], t[1], t[2]);
        // Reject slivers: the flip-based recovery can leave a near-collinear triangle
        // straddling a split edge (all vertices ~on one line). It covers no real
        // surface but injects spurious/duplicate edges → non-manifold. Use a *relative*
        // test (min height vs longest edge) so it fires regardless of the face's scale
        // or the projection's obliqueness, where an absolute area threshold wouldn't.
        let area2 = orient2d(pts2[i0], pts2[i1], pts2[i2]).abs();
        let elen = [
            sqlen(sub(pts3[i1], pts3[i0])),
            sqlen(sub(pts3[i2], pts3[i1])),
            sqlen(sub(pts3[i0], pts3[i2])),
        ];
        let longest = elen[0].max(elen[1]).max(elen[2]).max(1e-30).sqrt();
        if area2 / longest < 1e-6 {
            continue; // min height < ~1e-6 → degenerate sliver
        }
        let c2 = [
            (pts2[i0][0] + pts2[i1][0] + pts2[i2][0]) / 3.0,
            (pts2[i0][1] + pts2[i1][1] + pts2[i2][1]) / 3.0,
        ];
        if !face2.iter().any(|f| point_in_tri_2d(f, c2)) {
            continue; // outside the face (convex-hull fill on a non-convex group)
        }
        let (a, b, c) = (pts3[i0], pts3[i1], pts3[i2]);
        if dot(cross(sub(b, a), sub(c, a)), n) >= 0.0 {
            out.push([a, b, c]);
        } else {
            out.push([a, c, b]);
        }
    }
    Some(out)
}

fn find_or_add(pts3: &mut Vec<V3>, pts2: &mut Vec<[f64; 2]>, p: V3, p2: [f64; 2]) -> usize {
    for (i, q) in pts3.iter().enumerate() {
        if sqlen(sub(*q, p)) < 1e-12 {
            return i;
        }
    }
    pts3.push(p);
    pts2.push(p2);
    pts3.len() - 1
}

/// Co-refine both meshes against **one shared** set of intersection segments, so
/// the seam vertices are bit-identical on both sides (the fix for curved seams —
/// each `tri_tri_segment`/coplanar-overlap is computed once and inserted into
/// both the A-triangle and the B-triangle it lies on).
fn corefine(
    ta: &[[V3; 3]],
    tb: &[[V3; 3]],
    bvh_b: &bvh::Bvh,
) -> Option<(Vec<[V3; 3]>, Vec<[V3; 3]>)> {
    let mut a_segs: Vec<Vec<(V3, V3)>> = vec![Vec::new(); ta.len()];
    let mut b_segs: Vec<Vec<(V3, V3)>> = vec![Vec::new(); tb.len()];
    let mut cand = Vec::new();
    for (i, a) in ta.iter().enumerate() {
        bvh_b.overlaps(aabb(a), &mut cand); // O(log M) candidate B-triangles
        for &j in &cand {
            let b = &tb[j];
            if let Some(s) = tri_tri_segment(a, b) {
                if sqlen(sub(s.1, s.0)) > 1e-18 {
                    a_segs[i].push(s);
                    b_segs[j].push(s);
                }
            } else if coplanar(a, b) {
                let poly = coplanar::coplanar_overlap_poly(a, b);
                for k in 0..poly.len() {
                    let s = (poly[k], poly[(k + 1) % poly.len()]);
                    if sqlen(sub(s.1, s.0)) > 1e-18 {
                        a_segs[i].push(s);
                        b_segs[j].push(s);
                    }
                }
            }
        }
    }
    // Global vertex/edge snapping. Intersection endpoints from `tri_tri_segment`
    // carry ~1e-6 error, which leaves a point a hair off the mesh edge it should
    // lie on — producing near-collinear slivers within a face *and*, worse, a seam
    // that doesn't quite coincide between the two meshes. Snapping every endpoint to
    // its canonical position (a nearby mesh vertex, else onto a nearby mesh edge)
    // fixes both, and — being a pure function of the point — snaps the *shared*
    // endpoint identically on both sides, so the seam stays watertight.
    let mut verts: Vec<V3> = Vec::new();
    let mut edges: Vec<(V3, V3)> = Vec::new();
    let mut eseen: std::collections::HashSet<EdgeKey> = std::collections::HashSet::new();
    let mut vseen: std::collections::HashSet<(i64, i64, i64)> = std::collections::HashSet::new();
    for t in ta.iter().chain(tb.iter()) {
        for k in 0..3 {
            let vk = ((t[k][0] * 1e6).round() as i64, (t[k][1] * 1e6).round() as i64, (t[k][2] * 1e6).round() as i64);
            if vseen.insert(vk) {
                verts.push(t[k]);
            }
            let (a, b) = (t[k], t[(k + 1) % 3]);
            if eseen.insert(ekey(a, b)) {
                edges.push((a, b));
            }
        }
    }
    // Global set of *all* intersection points (both meshes), snapped. A point where
    // one mesh's cuts meet (a segment endpoint there) can fall in the middle of the
    // other mesh's seam segment; feeding this global set to both refinements lets
    // each face split its seam at the other mesh's points too — so the shared seam
    // is subdivided identically on both sides (watertight across the meshes).
    let mut global_pts: Vec<V3> = Vec::new();
    for (a, b) in a_segs.iter().chain(b_segs.iter()).flatten() {
        global_pts.push(snap_to_mesh(*a, &verts, &edges));
        global_pts.push(snap_to_mesh(*b, &verts, &edges));
    }
    Some((
        refine_with(ta, &a_segs, &verts, &edges, &global_pts)?,
        refine_with(tb, &b_segs, &verts, &edges, &global_pts)?,
    ))
}

/// Snap a point to a coincident mesh vertex (within ~1e-4) if there is one, else
/// leave it. Seam consistency across the two meshes comes from `corefine` *sharing*
/// each intersection segment (so both sides carry the identical point); this only
/// welds a computed point that lands essentially on an existing mesh vertex. Edge
/// snapping is deliberately avoided — with a loose tolerance it misroutes points on
/// fine tessellations; within-face slivers are handled by the degeneracy filter and
/// the T-junction heal instead. `edges` is retained for signature stability.
fn snap_to_mesh(p: V3, verts: &[V3], _edges: &[(V3, V3)]) -> V3 {
    let mut best: Option<(f64, V3)> = None;
    for &v in verts {
        let d = sqlen(sub(p, v));
        if d < 1e-8 && best.map_or(true, |(bd, _)| d < bd) {
            best = Some((d, v));
        }
    }
    best.map_or(p, |(_, v)| v)
}

/// Refine a mesh against its cut segments, one flat **face** (coplanar group) at a
/// time. Doing the whole face in a single CDT — rather than each triangle
/// independently — means a cut crossing the face's internal diagonals produces
/// shared vertices, not T-junctions; and any cut endpoint that lands on a face's
/// boundary edge is inserted into the adjacent face too, so faces line up exactly.
fn refine_with(
    tris: &[[V3; 3]],
    segs: &[Vec<(V3, V3)>],
    verts: &[V3],
    edges: &[(V3, V3)],
    allpts: &[V3],
) -> Option<Vec<[V3; 3]>> {
    // Snap every cut endpoint to its canonical mesh position first. This removes the
    // ~1e-6 slop from tri_tri_segment (which otherwise leaves near-collinear slivers
    // within a face) and — because the snap is a pure function shared with the other
    // mesh's refinement — keeps the seam coincident on both sides.
    let segs: Vec<Vec<(V3, V3)>> = segs
        .iter()
        .map(|v| {
            v.iter()
                .map(|&(a, b)| (snap_to_mesh(a, verts, edges), snap_to_mesh(b, verts, edges)))
                .collect()
        })
        .collect();
    // Group triangles by their oriented plane (one entry per flat face); sorted for
    // deterministic output (HashMap iteration order is otherwise randomized).
    let mut groups: HashMap<(i64, i64, i64, i64), Vec<usize>> = HashMap::new();
    for (i, t) in tris.iter().enumerate() {
        groups.entry(plane_key(t)).or_default().push(i);
    }
    let mut groups: Vec<((i64, i64, i64, i64), Vec<usize>)> = groups.into_iter().collect();
    groups.sort_by_key(|(k, _)| *k);
    // `allpts` (passed in) is the global cut-point set from *both* meshes — a face
    // splits its edges at any of these that land on them, so shared edges between
    // faces (and across the two meshes) are subdivided identically (no T-junction).

    let mut out = Vec::new();
    for (_, group) in &groups {
        let group = group.as_slice();
        let gsegs: Vec<(V3, V3)> = group.iter().flat_map(|&i| segs[i].iter().copied()).collect();
        // The face's boundary = edges used by exactly one triangle of the group.
        let mut ecount: HashMap<EdgeKey, ((V3, V3), u32)> = HashMap::new();
        for &i in group {
            let t = &tris[i];
            for k in 0..3 {
                let (a, b) = (t[k], t[(k + 1) % 3]);
                ecount.entry(ekey(a, b)).or_insert(((a, b), 0)).1 += 1;
            }
        }
        let mut boundary: Vec<(V3, V3)> =
            ecount.values().filter(|(_, c)| *c == 1).map(|(e, _)| *e).collect();
        boundary.sort_by_key(|&(a, b)| ekey(a, b)); // deterministic CDT input order

        // Does any global cut point land on this face (on its plane and an edge)?
        let n = normalize(face_normal(&tris[group[0]]));
        let o = tris[group[0]][0];
        let touched = gsegs.is_empty()
            && allpts.iter().any(|&p| {
                dot(sub(p, o), n).abs() <= 1e-7
                    && boundary.iter().any(|&(a, b)| on_segment_interior(a, b, p))
            });

        if gsegs.is_empty() && !touched {
            for &i in group {
                out.push(tris[i]); // untouched face — pass through unchanged
            }
        } else {
            out.extend(cdt_face(group, tris, &boundary, &gsegs, &allpts)?);
        }
    }
    Some(out)
}


fn sgn(x: f64) -> i32 {
    (x > 0.0) as i32 - (x < 0.0) as i32
}

const RAY_DIRS: [V3; 6] = [
    [0.31, 0.53, 0.79],
    [0.71, 0.13, 0.69],
    [0.47, 0.87, 0.19],
    [0.91, 0.29, 0.33],
    [0.17, 0.61, 0.77],
    [0.83, 0.41, 0.23],
];

/// Exact ray-parity crossing count along one direction, over the BVH candidates
/// only. `None` if the ray is degenerate (grazes a plane/edge) → caller retries.
fn ray_parity(bvh: &bvh::Bvh, tris: &[[V3; 3]], p: V3, d: V3, cand: &mut Vec<usize>) -> Option<bool> {
    let far = [d[0] * 1e6, d[1] * 1e6, d[2] * 1e6];
    bvh.ray_leaves(p, far, cand);
    let q = [p[0] + far[0], p[1] + far[1], p[2] + far[2]];
    let mut crossings = 0u32;
    for &i in cand.iter() {
        let t = &tris[i];
        let s1 = sgn(orient3d(p, t[0], t[1], t[2]));
        let s2 = sgn(orient3d(q, t[0], t[1], t[2]));
        if s1 == 0 || s2 == 0 {
            return None;
        }
        if s1 == s2 {
            continue;
        }
        let a = sgn(orient3d(p, q, t[0], t[1]));
        let b = sgn(orient3d(p, q, t[1], t[2]));
        let c = sgn(orient3d(p, q, t[2], t[0]));
        if a == 0 || b == 0 || c == 0 {
            return None;
        }
        if a == b && b == c {
            crossings += 1;
        }
    }
    Some(crossings % 2 == 1)
}

/// Exact ray-parity inside test for a closed mesh, BVH-accelerated: only the
/// triangles whose AABB the ray crosses are tested, and each with exact
/// `orient3d`. Robust where winding is ambiguous (point on/near the surface).
fn point_inside(bvh: &bvh::Bvh, tris: &[[V3; 3]], p: V3) -> bool {
    let mut cand = Vec::new();
    for d in RAY_DIRS {
        if let Some(inside) = ray_parity(bvh, tris, p, d, &mut cand) {
            return inside;
        }
    }
    point_in_mesh(tris, p) // every direction grazed (practically impossible)
}

/// Is `v` strictly interior to segment `a→b` (collinear, between, not an endpoint)?
fn on_segment_interior(a: V3, b: V3, v: V3) -> bool {
    if sqlen(sub(v, a)) < 1e-14 || sqlen(sub(v, b)) < 1e-14 {
        return false;
    }
    let ab = sub(b, a);
    let ablen = sqlen(ab);
    if ablen < 1e-18 {
        return false;
    }
    if sqlen(cross(ab, sub(v, a))) > 1e-12 * ablen {
        return false; // not on the line
    }
    let t = dot(sub(v, a), ab) / ablen;
    t > 1e-9 && t < 1.0 - 1e-9
}



/// Weld coincident vertices (to a fine grid) and heal T-junctions, processing
/// **only boundary edges** (used once) — efficient because a near-watertight
/// mesh has few of those. Welding first collapses coincident-but-unmerged
/// vertices; then any vertex lying exactly on a boundary edge splits that edge.
/// Geometry-preserving (splits are on the edge; welds are within the grid).
fn repair(tris: &[[V3; 3]]) -> Vec<[V3; 3]> {
    let key = |p: V3| ((p[0] * 1e5).round() as i64, (p[1] * 1e5).round() as i64, (p[2] * 1e5).round() as i64);
    let mut vmap: HashMap<(i64, i64, i64), u32> = HashMap::new();
    let mut verts: Vec<V3> = Vec::new();
    let mut idx: Vec<[u32; 3]> = Vec::new();
    for tr in tris {
        let mut ix = [0u32; 3];
        for k in 0..3 {
            let ky = key(tr[k]);
            ix[k] = *vmap.entry(ky).or_insert_with(|| {
                verts.push(tr[k]);
                (verts.len() - 1) as u32
            });
        }
        if ix[0] != ix[1] && ix[1] != ix[2] && ix[2] != ix[0] {
            let (a, b, c) = (verts[ix[0] as usize], verts[ix[1] as usize], verts[ix[2] as usize]);
            let area = norm(cross(sub(b, a), sub(c, a)));
            let longest = sqlen(sub(b, a)).max(sqlen(sub(c, b))).max(sqlen(sub(a, c))).max(1e-30).sqrt();
            if area / longest >= 1e-6 {
                idx.push(ix); // drop collinear slivers up front so heal can converge
            }
        }
    }
    // Bound growth: a seam that can't be healed makes splits cascade (each pass can
    // spawn a fresh T-junction), so idx would blow up exponentially. If it grows past
    // this, give up — the caller's manifold gate then falls back to the float CSG.
    let cap = tris.len() * 4 + 256;
    for _ in 0..64 {
        if idx.len() > cap {
            break;
        }
        let mut ec: HashMap<(u32, u32), i32> = HashMap::new();
        for tr in &idx {
            for k in 0..3 {
                let (mut a, mut b) = (tr[k], tr[(k + 1) % 3]);
                if a > b {
                    std::mem::swap(&mut a, &mut b);
                }
                *ec.entry((a, b)).or_insert(0) += 1;
            }
        }
        if ec.values().all(|&c| c == 2) {
            break;
        }
        let mut next = Vec::with_capacity(idx.len());
        let mut changed = false;
        for tr in &idx {
            let mut split = None;
            for e in 0..3 {
                let (a, b) = (tr[e], tr[(e + 1) % 3]);
                let (mut x, mut y) = (a, b);
                if x > y {
                    std::mem::swap(&mut x, &mut y);
                }
                if ec.get(&(x, y)) == Some(&2) {
                    continue; // interior edge, fine
                }
                if let Some(vi) = verts.iter().enumerate().position(|(i, v)| {
                    i as u32 != a && i as u32 != b && on_segment_interior(verts[a as usize], verts[b as usize], *v)
                }) {
                    split = Some((e, vi as u32));
                    break;
                }
            }
            match split {
                Some((e, vi)) => {
                    let (a, b, c) = (tr[e], tr[(e + 1) % 3], tr[(e + 2) % 3]);
                    next.push([a, vi, c]);
                    next.push([vi, b, c]);
                    changed = true;
                }
                None => next.push(*tr),
            }
        }
        idx = next;
        if !changed {
            break;
        }
    }
    idx.iter()
        .map(|t| [verts[t[0] as usize], verts[t[1] as usize], verts[t[2] as usize]])
        .collect()
}

/// Is the triangle soup a closed 2-manifold (every welded edge used exactly
/// twice)? The safety gate: a boolean that fails this is refused, never emitted.
pub(crate) fn is_closed_manifold(tris: &[[V3; 3]]) -> bool {
    if tris.is_empty() {
        return false;
    }
    let key = |p: V3| -> (i64, i64, i64) {
        ((p[0] * 1e6).round() as i64, (p[1] * 1e6).round() as i64, (p[2] * 1e6).round() as i64)
    };
    let mut edges: HashMap<((i64, i64, i64), (i64, i64, i64)), i32> = HashMap::new();
    for t in tris {
        for k in 0..3 {
            let (mut u, mut v) = (key(t[k]), key(t[(k + 1) % 3]));
            if u > v {
                std::mem::swap(&mut u, &mut v);
            }
            *edges.entry((u, v)).or_insert(0) += 1;
        }
    }
    edges.values().all(|&c| c == 2)
}

fn face_normal(t: &[V3; 3]) -> V3 {
    cross(sub(t[1], t[0]), sub(t[2], t[0]))
}

fn point_in_tri_2d(o: &[[f64; 2]; 3], p: [f64; 2]) -> bool {
    let s0 = orient2d(o[0], o[1], p);
    let s1 = orient2d(o[1], o[2], p);
    let s2 = orient2d(o[2], o[0], p);
    (s0 >= 0.0 && s1 >= 0.0 && s2 >= 0.0) || (s0 <= 0.0 && s1 <= 0.0 && s2 <= 0.0)
}

/// If `t` lies fully within a coincident (exactly coplanar) face of `other`,
/// return that face's unnormalized outward normal; else `None`.
fn coincident_face(t: &[V3; 3], other: &[[V3; 3]], other_boxes: &[(V3, V3)]) -> Option<V3> {
    // Degenerate slivers (collinear verts) can read as "coplanar" with a face
    // whose plane they happen to lie on — classify those by winding as before.
    if sqlen(face_normal(t)) < 1e-12 {
        return None;
    }
    let bt = aabb(t);
    for (o, ob) in other.iter().zip(other_boxes) {
        if !aabb_overlap(&bt, ob) || !coplanar(o, t) {
            continue;
        }
        let n = face_normal(o);
        if sqlen(n) < 1e-18 {
            continue;
        }
        let ux = normalize(sub(o[1], o[0]));
        let uy = normalize(cross(n, ux));
        let origin = o[0];
        let pr = |p: V3| [dot(sub(p, origin), ux), dot(sub(p, origin), uy)];
        let o2 = [pr(o[0]), pr(o[1]), pr(o[2])];
        // Centroid test (not all-vertices): robust when the two faces are
        // tessellated with different diagonals. After refinement each sub-triangle
        // is wholly inside or outside the coincident region, so the centroid decides.
        if point_in_tri_2d(&o2, pr(centroid(t))) {
            return Some(n);
        }
    }
    None
}

/// Keep/drop rule for a sub-triangle coincident with the other solid's face.
/// `COPLANAR_ALIGNED` (same normal direction) keeps exactly one copy — by
/// convention the A operand's; `COPLANAR_OPPOSITE` drops both, except difference
/// keeps A's (its boundary survives the subtraction).
fn coplanar_keep(op: Op, is_a: bool, aligned: bool) -> bool {
    match (op, aligned) {
        (Op::Union, true) | (Op::Intersection, true) => is_a,
        (Op::Difference, false) => is_a,
        _ => false,
    }
}

/// Full mesh-arrangement boolean: refine both meshes along their intersection,
/// classify each sub-triangle by winding number, assemble. Returns `Some` only
/// when the result passes the closed-manifold gate; `None` otherwise (so the
/// caller reports `NeedsArrangement` rather than trusting an unverified mesh).
pub fn boolean_arrangement(a: &BufferGeometry, b: &BufferGeometry, op: Op) -> Option<BufferGeometry> {
    let ta = triangles(a);
    let tb = triangles(b);
    let bvh_a = bvh::Bvh::build(&ta);
    let bvh_b = bvh::Bvh::build(&tb);
    let (ra, rb) = corefine(&ta, &tb, &bvh_b)?;
    let ta_boxes: Vec<(V3, V3)> = ta.iter().map(aabb).collect();
    let tb_boxes: Vec<(V3, V3)> = tb.iter().map(aabb).collect();

    let mut out: Vec<[V3; 3]> = Vec::new();
    for t in &ra {
        let keep = if let Some(nf) = coincident_face(t, &tb, &tb_boxes) {
            coplanar_keep(op, true, dot(face_normal(t), nf) > 0.0)
        } else {
            let inside = point_inside(&bvh_b, &tb, centroid(t));
            match op {
                Op::Union | Op::Difference => !inside,
                Op::Intersection => inside,
            }
        };
        if keep {
            out.push(*t);
        }
    }
    for t in &rb {
        if let Some(nf) = coincident_face(t, &ta, &ta_boxes) {
            if coplanar_keep(op, false, dot(face_normal(t), nf) > 0.0) {
                out.push(*t);
            }
        } else {
            let inside = point_inside(&bvh_a, &ta, centroid(t));
            let (keep, flip) = match op {
                Op::Union => (!inside, false),
                Op::Intersection => (inside, false),
                Op::Difference => (inside, true),
            };
            if keep {
                out.push(if flip { [t[0], t[2], t[1]] } else { *t });
            }
        }
    }

    // Most results are already watertight. Otherwise weld + boundary-heal, and
    // accept it only if that actually closes the mesh (never emit an unverified
    // result — so we still fall back rather than trust a repair that didn't work).
    let out = if is_closed_manifold(&out) {
        out
    } else {
        let fixed = repair(&out);
        if is_closed_manifold(&fixed) {
            fixed
        } else {
            return None;
        }
    };
    Some(build_geometry(&out))
}

/// Try to make a mesh watertight by welding coincident vertices and healing
/// T-junctions (the seam cracks left by the float CSG on curved booleans).
/// Returns the repaired geometry **only if it is actually closed** — otherwise
/// `None`, so callers never trust a repair that didn't work.
pub fn repair_geometry(g: &BufferGeometry) -> Option<BufferGeometry> {
    let tris = triangles(g);
    if is_closed_manifold(&tris) {
        return None; // already watertight — nothing to do
    }
    let fixed = repair(&tris);
    is_closed_manifold(&fixed).then(|| build_geometry(&fixed))
}

/// Boolean of two solids by winding-number classification.
///
/// When surfaces don't cross, classifies whole triangles directly. When they do,
/// runs the mesh arrangement ([`boolean_arrangement`]) behind a closed-manifold
/// gate, reporting `BooleanOutcome::NeedsArrangement` only if that can't be
/// verified.
pub fn boolean(a: &BufferGeometry, b: &BufferGeometry, op: Op) -> BooleanOutcome {
    let ta = triangles(a);
    let tb = triangles(b);
    let bvh_b = bvh::Bvh::build(&tb);
    if interacts(&ta, &tb, &bvh_b) {
        return match boolean_arrangement(a, b, op) {
            Some(g) => BooleanOutcome::Exact(g),
            None => BooleanOutcome::NeedsArrangement,
        };
    }

    let mut out: Vec<[V3; 3]> = Vec::new();
    let bvh_a = bvh::Bvh::build(&ta);

    // A's triangles: keep the ones on the side the op wants.
    let keep_a_inside = op == Op::Intersection;
    for t in &ta {
        let inside = point_inside(&bvh_b, &tb, centroid(t));
        if inside == keep_a_inside {
            out.push(*t);
        }
    }

    // B's triangles: union keeps the outside; intersection/difference keep the
    // inside, and difference flips their winding (the void wall faces inward).
    for t in &tb {
        let inside = point_inside(&bvh_a, &ta, centroid(t));
        let (keep, flip) = match op {
            Op::Union => (!inside, false),
            Op::Intersection => (inside, false),
            Op::Difference => (inside, true),
        };
        if keep {
            out.push(if flip { [t[0], t[2], t[1]] } else { *t });
        }
    }

    BooleanOutcome::Exact(build_geometry(&out))
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{cube, sphere};

    fn box_tris(size: f32, at: [f32; 3]) -> Vec<[V3; 3]> {
        triangles(&cube([size, size, size]).translate(at).to_geometry())
    }

    fn signed_volume(g: &BufferGeometry) -> f64 {
        triangles(g)
            .iter()
            .map(|t| dot(t[0], cross(t[1], t[2])))
            .sum::<f64>()
            / 6.0
    }

    /// Curved∧curved exact CSG: two faceted surfaces genuinely crossing (spheres,
    /// cylinders, cones, and mixed pairs) resolve to a watertight mesh for all
    /// three ops — the case the float kernel can't do (its sphere∩sphere is
    /// degenerate). The oracle is *self-consistency* — V(A∪B)=V(A)+V(B)−V(A∩B) and
    /// V(A−B)=V(A)−V(A∩B) — plus watertightness, since the float result is the
    /// unreliable one here. (A perfectly symmetric identical-primitive-on-axis
    /// overlap is a measure-zero degeneracy that still falls back to float; every
    /// case here is a real transversal crossing.)
    #[test]
    fn curved_curved_booleans_are_exact() {
        use crate::{cone, cylinder, sphere_fn};
        type SolidFn = Box<dyn Fn() -> crate::Solid>;
        let cases: Vec<(&str, SolidFn, SolidFn)> = vec![
            ("sph∪sph deep asym", Box::new(|| sphere_fn(1.3, 32)), Box::new(|| sphere_fn(1.1, 32).translate([0.9, 0.17, 0.11]))),
            ("sph∪sph shallow", Box::new(|| sphere_fn(1.3, 32)), Box::new(|| sphere_fn(1.0, 32).translate([1.8, 0.2, 0.1]))),
            ("cyl∪cyl parallel", Box::new(|| cylinder(3.0, 1.0)), Box::new(|| cylinder(3.0, 1.0).translate([1.2, 0.0, 0.0]))),
            ("cyl⊥cyl cross", Box::new(|| cylinder(4.0, 0.8)), Box::new(|| cylinder(4.0, 0.8).rotate_x(1.5708))),
            ("sph∪cyl", Box::new(|| sphere_fn(1.5, 32)), Box::new(|| cylinder(4.0, 0.7))),
            ("cone∪cyl", Box::new(|| cone(3.0, 1.4, 0.2)), Box::new(|| cylinder(4.0, 0.6).translate([0.6, 0.0, 0.0]))),
        ];
        for (name, fa, fb) in &cases {
            let (a, b) = (fa().to_geometry(), fb().to_geometry());
            let (va, vb) = (signed_volume(&a).abs(), signed_volume(&b).abs());
            let vol = |op| match boolean(&a, &b, op) {
                BooleanOutcome::Exact(g) => {
                    assert!(is_closed_manifold(&triangles(&g)), "{name} {op:?}: not watertight");
                    signed_volume(&g).abs()
                }
                BooleanOutcome::NeedsArrangement => panic!("{name} {op:?}: fell back to float"),
            };
            let (uv, iv, dv) = (vol(Op::Union), vol(Op::Intersection), vol(Op::Difference));
            // Self-consistency across the three ops (float-oracle-independent).
            assert!((uv - (va + vb - iv)).abs() / va < 0.02, "{name}: union inconsistent");
            assert!((dv - (va - iv)).abs() / va < 0.02, "{name}: difference inconsistent");
            assert!(iv > 0.0 && iv < va.min(vb), "{name}: intersection out of range");
        }
    }

    #[test]
    fn arrangement_resolves_a_real_overlap() {
        // Sphere piercing a box — a genuine transversal overlap. The arrangement
        // resolves the difference to a watertight mesh whose volume matches the
        // existing float CsgEvaluator (used purely as an oracle).
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = sphere(1.3).to_geometry();
        let float = cube([2.0, 2.0, 2.0]).difference(sphere(1.3)).to_geometry();

        let g = boolean_arrangement(&a, &b, Op::Difference).expect("difference resolves + passes gate");
        let (va, vf) = (signed_volume(&g).abs(), signed_volume(&float).abs());
        assert!((va - vf).abs() / vf < 1e-3, "arrangement {va:.5} vs float {vf:.5}");
        assert!(is_closed_manifold(&triangles(&g)), "watertight");
        assert!(matches!(boolean(&a, &b, Op::Difference), BooleanOutcome::Exact(_)));
    }

    #[test]
    fn all_ops_watertight_on_oblique_boxes() {
        // Two obliquely-rotated boxes: a fully transversal, non-degenerate
        // overlap (no axis-aligned/coplanar faces, no polar slivers). All three
        // ops must resolve to a watertight mesh matching the float oracle —
        // proving union AND intersection work, not just difference.
        let a = cube([2.0, 2.0, 2.0]);
        let b = cube([2.0, 2.0, 2.0]).rotate_x(0.6).rotate_y(0.4).translate([0.7, 0.5, 0.3]);
        let (ga, gb) = (a.clone().to_geometry(), b.clone().to_geometry());
        for op in [Op::Difference, Op::Union, Op::Intersection] {
            let float = match op {
                Op::Difference => a.clone().difference(b.clone()),
                Op::Union => a.clone().union(b.clone()),
                Op::Intersection => a.clone().intersection(b.clone()),
            }
            .to_geometry();
            let g = boolean_arrangement(&ga, &gb, op)
                .unwrap_or_else(|| panic!("{op:?}: oblique boxes should resolve"));
            let (va, vf) = (signed_volume(&g).abs(), signed_volume(&float).abs());
            assert!((va - vf).abs() / vf < 1e-2, "{op:?}: arrangement {va:.4} vs float {vf:.4}");
            assert!(is_closed_manifold(&triangles(&g)), "{op:?}: watertight");
            assert!(matches!(boolean(&ga, &gb, op), BooleanOutcome::Exact(_)), "{op:?}: Exact");
        }
    }

    #[test]
    fn fuzz_boolean_volume_identities() {
        // Adversarial property test: many random obliquely-rotated box overlaps.
        // For every pair where all three ops resolve to Exact, the results must
        // satisfy the inclusion–exclusion identities exactly (oracle-free):
        //   V(A∪B) + V(A∩B) == V(A) + V(B)
        //   V(A−B) + V(A∩B) == V(A)
        // A boolean that miscounts a region breaks these by whole percent.
        let mut seed = 0x2545_F491_4F6C_DD1Du64;
        let mut rng = || {
            seed = seed
                .wrapping_mul(6364136223846793005)
                .wrapping_add(1442695040888963407);
            ((seed >> 40) as f64) / ((1u64 << 24) as f64) // [0,1)
        };
        let mut checked = 0;
        for _ in 0..60 {
            let sa = 1.6 + rng() * 0.8;
            let sb = 1.4 + rng() * 0.9;
            let a = cube([sa as f32, sa as f32, sa as f32]);
            let b = cube([sb as f32, sb as f32, sb as f32])
                .rotate_x((0.25 + rng() * 0.9) as f32)
                .rotate_y((0.25 + rng() * 0.9) as f32)
                .rotate_z((0.25 + rng() * 0.9) as f32)
                .translate([
                    (rng() * 1.4 - 0.7) as f32,
                    (rng() * 1.4 - 0.7) as f32,
                    (rng() * 1.4 - 0.7) as f32,
                ]);
            let (ga, gb) = (a.to_geometry(), b.to_geometry());
            let (u, d, i) = (
                boolean(&ga, &gb, Op::Union),
                boolean(&ga, &gb, Op::Difference),
                boolean(&ga, &gb, Op::Intersection),
            );
            if let (BooleanOutcome::Exact(gu), BooleanOutcome::Exact(gd), BooleanOutcome::Exact(gi)) =
                (u, d, i)
            {
                let va = signed_volume(&ga).abs();
                let vb = signed_volume(&gb).abs();
                let (vu, vd, vi) = (
                    signed_volume(&gu).abs(),
                    signed_volume(&gd).abs(),
                    signed_volume(&gi).abs(),
                );
                assert!(
                    ((vu + vi) - (va + vb)).abs() / va < 1e-2,
                    "inclusion-exclusion: u{vu:.4}+i{vi:.4} vs a{va:.4}+b{vb:.4}"
                );
                assert!(
                    ((vd + vi) - va).abs() / va < 1e-2,
                    "difference identity: d{vd:.4}+i{vi:.4} vs a{va:.4}"
                );
                for g in [&gu, &gd, &gi] {
                    assert!(is_closed_manifold(&triangles(g)), "Exact result must be watertight");
                }
                checked += 1;
            }
        }
        assert!(checked >= 8, "expected several fully-resolved random cases, got {checked}");
    }

    #[test]
    fn coplanar_keep_truth_table() {
        // Union/Intersection: aligned keeps A's copy only; opposite drops both.
        for op in [Op::Union, Op::Intersection] {
            assert!(coplanar_keep(op, true, true) && !coplanar_keep(op, false, true));
            assert!(!coplanar_keep(op, true, false) && !coplanar_keep(op, false, false));
        }
        // Difference: aligned drops both; opposite keeps A's boundary only.
        assert!(!coplanar_keep(Op::Difference, true, true));
        assert!(coplanar_keep(Op::Difference, true, false) && !coplanar_keep(Op::Difference, false, false));
    }

    #[test]
    fn coplanar_stacked_boxes_resolve() {
        // Two boxes sharing the z=1 face exactly (A's +z coincident-opposite B's −z).
        // A previously-refused coplanar case — now handled by the aligned/opposite rule.
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = cube([2.0, 2.0, 2.0]).translate([0.0, 0.0, 2.0]).to_geometry();
        // Union = 2×2×4 box (coincident-opposite faces dropped) → vol 16.
        match boolean(&a, &b, Op::Union) {
            BooleanOutcome::Exact(g) => {
                assert!((signed_volume(&g).abs() - 16.0).abs() < 1e-3, "stacked union = 2×2×4 box");
                assert!(is_closed_manifold(&triangles(&g)), "watertight");
            }
            BooleanOutcome::NeedsArrangement => panic!("stacked union should resolve"),
        }
        // Difference A−B: B only touches A (no volume overlap) → A−B = A, vol 8.
        // (Coincident-opposite: difference keeps A's face, drops B's.)
        match boolean(&a, &b, Op::Difference) {
            BooleanOutcome::Exact(g) => {
                assert!((signed_volume(&g).abs() - 8.0).abs() < 1e-3, "A−B = A, vol 8");
                assert!(is_closed_manifold(&triangles(&g)), "watertight");
            }
            BooleanOutcome::NeedsArrangement => panic!("stacked difference should resolve"),
        }
    }

    #[test]
    fn coplanar_overlapping_boxes_union_resolves() {
        // Two axis-aligned boxes overlapping in x∈[0,1] — the headline coplanar
        // case (partial coincidence). Union resolves via face-splitting along the
        // coincident boundary + the aligned rule.
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = cube([2.0, 2.0, 2.0]).translate([1.0, 0.0, 0.0]).to_geometry();
        // All three resolve (T-junction healing stitches the coincident seam):
        // union = 3×2×2 = 12, difference = 1×2×2 = 4, intersection = 1×2×2 = 4.
        for (op, want) in [(Op::Union, 12.0), (Op::Difference, 4.0), (Op::Intersection, 4.0)] {
            match boolean(&a, &b, op) {
                BooleanOutcome::Exact(g) => {
                    assert!((signed_volume(&g).abs() - want).abs() < 1e-3, "{op:?} volume = {want}");
                    assert!(is_closed_manifold(&triangles(&g)), "{op:?} watertight");
                }
                BooleanOutcome::NeedsArrangement => panic!("{op:?} overlapping boxes should resolve"),
            }
        }
    }

    #[test]
    fn square_through_hole_resolves() {
        // cube(10) minus a 4×4 box poking through z → a square hole, volume 840.
        let a = cube([10.0, 10.0, 10.0]).to_geometry();
        let b = cube([4.0, 4.0, 12.0]).to_geometry();
        match boolean(&a, &b, Op::Difference) {
            BooleanOutcome::Exact(g) => {
                assert!((signed_volume(&g).abs() - 840.0).abs() < 1e-2, "vol 840");
                assert!(is_closed_manifold(&triangles(&g)), "watertight hole");
            }
            BooleanOutcome::NeedsArrangement => panic!("square through-hole should resolve"),
        }
    }

    #[test]
    fn kernel_is_never_wrong_across_ops() {
        // Contract: for every op, the kernel either refuses (NeedsArrangement) or
        // returns a mesh that is watertight AND volume-matches the float oracle.
        // It must never emit a mesh that disagrees. (Union/Intersection currently
        // hit a few near-seam f64 misclassifications and are safely refused —
        // exact predicates in M2 will close that gap.)
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = sphere(1.3).to_geometry();
        let oracle = |op: Op| match op {
            Op::Difference => cube([2.0, 2.0, 2.0]).difference(sphere(1.3)).to_geometry(),
            Op::Union => cube([2.0, 2.0, 2.0]).union(sphere(1.3)).to_geometry(),
            Op::Intersection => cube([2.0, 2.0, 2.0]).intersection(sphere(1.3)).to_geometry(),
        };
        for op in [Op::Difference, Op::Union, Op::Intersection] {
            if let BooleanOutcome::Exact(g) = boolean(&a, &b, op) {
                let (va, vf) = (signed_volume(&g).abs(), signed_volume(&oracle(op)).abs());
                assert!((va - vf).abs() / vf < 1e-3, "{op:?} claimed Exact but volume disagrees");
                assert!(is_closed_manifold(&triangles(&g)), "{op:?} claimed Exact but not watertight");
            }
        }
    }

    #[test]
    fn winding_inside_and_outside_a_box() {
        let t = box_tris(2.0, [0.0, 0.0, 0.0]);
        assert!(point_in_mesh(&t, [0.0, 0.0, 0.0]), "origin is inside");
        assert!(!point_in_mesh(&t, [5.0, 0.0, 0.0]), "far point is outside");
        assert!((winding_number(&t, [0.0, 0.0, 0.0]).abs() - 1.0).abs() < 1e-6);
        assert!(winding_number(&t, [5.0, 0.0, 0.0]).abs() < 1e-6);
    }

    #[test]
    fn tri_tri_detects_crossing() {
        let a = [[0.0, 0.0, 0.0], [2.0, 0.0, 0.0], [0.0, 2.0, 0.0]];
        let crossing = [[0.5, 0.5, -1.0], [0.5, 0.5, 1.0], [1.5, 0.5, 1.0]];
        let apart = [[0.5, 0.5, 1.0], [0.5, 0.5, 2.0], [1.5, 0.5, 2.0]];
        assert!(tri_tri_intersect(&a, &crossing));
        assert!(!tri_tri_intersect(&a, &apart));
    }

    #[test]
    fn disjoint_union_keeps_all_triangles() {
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = cube([2.0, 2.0, 2.0]).translate([10.0, 0.0, 0.0]).to_geometry();
        let na = triangles(&a).len();
        let nb = triangles(&b).len();
        match boolean(&a, &b, Op::Union) {
            BooleanOutcome::Exact(g) => assert_eq!(triangles(&g).len(), na + nb),
            BooleanOutcome::NeedsArrangement => panic!("disjoint boxes should not straddle"),
        }
    }

    #[test]
    fn nested_difference_is_exact_and_hollow() {
        // Small box strictly inside a big box: surfaces don't touch.
        let big = cube([4.0, 4.0, 4.0]).to_geometry();
        let small = cube([1.0, 1.0, 1.0]).to_geometry();
        let (nb, ns) = (triangles(&big).len(), triangles(&small).len());
        match boolean(&big, &small, Op::Difference) {
            BooleanOutcome::Exact(g) => {
                // All of big's shell (outside small) + all of small's shell (inside big).
                assert_eq!(triangles(&g).len(), nb + ns);
            }
            BooleanOutcome::NeedsArrangement => panic!("nested boxes should not straddle"),
        }
    }

    #[test]
    fn nested_intersection_is_the_inner_solid() {
        let big = cube([4.0, 4.0, 4.0]).to_geometry();
        let small = cube([1.0, 1.0, 1.0]).to_geometry();
        let ns = triangles(&small).len();
        match boolean(&big, &small, Op::Intersection) {
            BooleanOutcome::Exact(g) => assert_eq!(triangles(&g).len(), ns),
            BooleanOutcome::NeedsArrangement => panic!("nested boxes should not straddle"),
        }
    }

    #[test]
    fn genuinely_degenerate_still_refused_or_correct() {
        // A zero-thickness (degenerate) overlap must never yield a wrong mesh.
        let a = cube([2.0, 2.0, 2.0]).to_geometry();
        let b = cube([2.0, 2.0, 0.0]).to_geometry(); // flat
        if let BooleanOutcome::Exact(g) = boolean(&a, &b, Op::Union) {
            assert!(is_closed_manifold(&triangles(&g)), "any Exact result must be watertight");
        }
    }
}



















#[cfg(test)]
mod coverage {
    use super::*;
    use crate::{cone, cube, frustum, linear_extrude, polyhedron, sphere_fn, Solid};

    fn svol(g: &BufferGeometry) -> f64 {
        triangles(g).iter().map(|t| dot(t[0], cross(t[1], t[2]))).sum::<f64>() / 6.0
    }
    fn tetra() -> Solid {
        let p = [[1.0, 1.0, 1.0], [-1.0, -1.0, 1.0], [-1.0, 1.0, -1.0], [1.0, -1.0, -1.0]];
        polyhedron(&p, &[vec![0, 1, 2], vec![0, 3, 1], vec![0, 2, 3], vec![1, 3, 2]])
    }

    /// Exercise every primitive shape against every other in all three booleans.
    /// Contract: every `Exact` result is watertight, and where all three ops of a
    /// pair resolve, the inclusion–exclusion volume identities hold. Prints a
    /// coverage map and guards a floor on the resolved count.
    #[test]
    fn all_shapes_all_ops_never_wrong() {
        let shapes: Vec<(&str, Solid)> = vec![
            ("cube", cube([2.0, 2.0, 2.0])),
            ("sphere", sphere_fn(1.2, 12)),
            ("cyl", frustum(2.0, 1.0, 1.0, 12)),
            ("cone", cone(2.0, 1.0, 0.0)),
            ("hex", frustum(2.0, 1.0, 1.0, 6)),
            ("pent", frustum(2.0, 1.0, 1.0, 5)),
            ("tri3", frustum(2.0, 1.0, 1.0, 3)),
            ("tet", tetra()),
            ("prism", linear_extrude(2.0, &[[-1.0, -0.8], [1.0, -0.8], [0.0, 1.0]]).translate([0.0, 0.0, -1.0])),
        ];
        let off = [0.7, 0.5, 0.3];
        let ops = [Op::Union, Op::Difference, Op::Intersection];
        let (mut resolved, mut total, mut identity_checks) = (0usize, 0usize, 0usize);

        for (na, a) in &shapes {
            for (nb, b) in &shapes {
                let ga = a.clone().to_geometry();
                let gb = b.clone().translate(off).to_geometry();
                let mut vols = [None; 3];
                for (k, &op) in ops.iter().enumerate() {
                    total += 1;
                    if let BooleanOutcome::Exact(g) = boolean(&ga, &gb, op) {
                        let t = triangles(&g);
                        assert!(is_closed_manifold(&t), "{na}∖{nb} {op:?}: Exact but not watertight");
                        vols[k] = Some(svol(&g).abs());
                        resolved += 1;
                    }
                }
                // If a pair fully resolves, the volume identities must hold exactly.
                if let [Some(vu), Some(vd), Some(vi)] = vols {
                    let (va, vb) = (svol(&ga).abs(), svol(&gb).abs());
                    assert!(((vu + vi) - (va + vb)).abs() / va < 2e-2, "{na}/{nb} incl-excl");
                    assert!(((vd + vi) - va).abs() / va < 2e-2, "{na}/{nb} difference identity");
                    identity_checks += 1;
                }
            }
        }
        println!(
            "COVERAGE: {resolved}/{total} shape×op combinations resolve exactly; \
             {identity_checks} pairs fully resolved (identities verified)"
        );
        assert!(resolved * 100 / total >= 40, "coverage regressed: {resolved}/{total}");
    }
}