thirdshift 0.22.0

Turn a GitHub issue into a ready-for-review pull request, unattended
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61

//! A pull request stays reserved through Review/Fix cleanup, even on interruption.

use anyhow::Result;

use super::PullRequestUrl;
use crate::claim::IN_PROGRESS;
use crate::git::Git;
use crate::github::GitHub;
use crate::labels::Edit;

pub(crate) struct Reservation {
    pr: PullRequestUrl,
    // Drop the label before the origin ref allows another owner in.
    _origin: crate::reservation::Reservation,
    // Earlier Review runs use the Pickup ref. Hold it until the new ref is
    // released too, so an older host cannot enter before its label is visible.
    _legacy: crate::reservation::Reservation,
}

impl Reservation {
    pub fn take(launch: &Git, github: &GitHub, pr: &PullRequestUrl) -> Result<Option<Self>> {
        let Some(legacy) = crate::reservation::Reservation::take(launch, &pr.issue)? else {
            return Ok(None);
        };
        let Some(origin) = crate::reservation::Reservation::pull_request(launch, pr)? else {
            return Ok(None);
        };
        let labels = github.review_labels(pr)?;
        if labels.has(IN_PROGRESS) {
            return Ok(None);
        }
        let held = Self {
            pr: pr.clone(),
            _origin: origin,
            _legacy: legacy,
        };
        // Arm cleanup before the write: a failed response may still have
        // applied the label remotely.
        Edit::of(&pr.issue, labels, &[], &[IN_PROGRESS]).apply(github)?;
        Ok(Some(held))
    }
}

impl Drop for Reservation {
    fn drop(&mut self) {
        let github = GitHub::new().completion();
        let ended = (|| {
            let labels = github.review_labels(&self.pr)?;
            Edit::of(&self.pr.issue, labels, &[IN_PROGRESS], &[]).apply(&github)
        })();
        if let Err(error) = ended {
            crate::progress::warn(
                &error,
                format_args!(
                    "could not remove in-progress from {}; remove it by hand",
                    self.pr.url
                ),
            );
        }
    }
}