thirdshift 0.16.1

Turn a GitHub issue into a ready-for-review pull request, unattended
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70

//! Independent Grader choices and the population a Scoring run samples.
use std::num::NonZeroUsize;

use anyhow::{Result, bail};
use serde::{Deserialize, Serialize};

use crate::harness::{Choice, ChosenBy, Harness};

#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
#[serde(default, deny_unknown_fields)]
pub struct Settings {
    pub owners: Vec<String>,
    pub sample_size: NonZeroUsize,
    pub harness: String,
    pub model: String,
    pub fallback_harness: String,
    pub fallback_model: String,
}

impl Default for Settings {
    fn default() -> Self {
        Self {
            owners: Vec::new(),
            sample_size: NonZeroUsize::new(10).unwrap(),
            harness: "claude".into(),
            model: String::new(),
            fallback_harness: "codex".into(),
            fallback_model: String::new(),
        }
    }
}

impl Settings {
    pub fn fallback_grader(&self) -> Choice {
        grader_choice(&self.fallback_harness, &self.fallback_model)
    }
    pub fn validate(&self) -> Result<()> {
        for owner in &self.owners {
            if owner.is_empty()
                || !owner
                    .bytes()
                    .all(|b| b.is_ascii_alphanumeric() || b == b'-')
            {
                bail!("scoring.owners must contain GitHub owner names: {owner:?}");
            }
        }
        for (key, name) in [
            ("harness", &self.harness),
            ("fallback_harness", &self.fallback_harness),
        ] {
            if Harness::named(name).is_none() {
                bail!("scoring.{key} must name a Harness: {name:?}");
            }
        }
        Ok(())
    }

    pub fn grader(&self) -> Choice {
        grader_choice(&self.harness, &self.model)
    }
}

fn grader_choice(harness: &str, model: &str) -> Choice {
    Choice {
        harness: Harness::named(harness).expect("validated Scoring Harness"),
        model: (!model.trim().is_empty()).then(|| model.to_owned()),
        effort: None,
        chosen_by: ChosenBy::UserConfig,
    }
}