thirdpass 0.4.0

A multi-ecosystem package code review system.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104

//! A module for data structures which are available to all super modules.
//!
//! This module contains data structures which are available to all super modules.
//! The number of data structures in this module should be minimized. The data structures
//! should be as simple as possible.
//!
//! Print statements are prohibited within this module. Logging is allowed.

use anyhow::Result;
use std::convert::TryFrom;
use std::hash::Hash;
pub static ROOT_ALIAS: &str = "root";

#[derive(Debug, Clone, Default, Hash, Eq, PartialEq)] //, Ord, PartialOrd)]
pub struct Peer {
    pub id: crate::common::index::ID,
    pub alias: String,
    pub git_url: crate::common::GitUrl,

    // Only the root peer can have None parent ID.
    pub parent_id: Option<crate::common::index::ID>,
}

impl Peer {
    pub fn is_root(&self) -> bool {
        self.alias.as_str() == ROOT_ALIAS && self.parent_id.is_none()
    }
}

impl Ord for Peer {
    /// Order on root status then git_url (which is unique).
    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
        if self.is_root() && !other.is_root() {
            std::cmp::Ordering::Less
        } else if self.is_root() && other.is_root() {
            std::cmp::Ordering::Equal
        } else if !self.is_root() && other.is_root() {
            std::cmp::Ordering::Greater
        } else {
            self.git_url.cmp(&other.git_url)
        }
    }
}

impl PartialOrd for Peer {
    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
        Some(self.cmp(other))
    }
}

pub fn public_user_peer(public_user_id: &str, api_base: &str) -> Result<Peer> {
    let alias = format!("public-user-{}", public_user_id);
    let base = crate::common::api::normalize_base(api_base)?;
    let public_user_url = crate::common::api::join(&base, &format!("users/{}", public_user_id))?;
    let git_url = crate::common::GitUrl::try_from(public_user_url.as_str())?;
    Ok(Peer {
        id: 0,
        alias,
        git_url,
        parent_id: None,
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use anyhow::Result;

    #[test]
    fn test_root_peer_greater_ordering() -> Result<()> {
        let root_peer = Peer {
            id: 0,
            alias: ROOT_ALIAS.to_string(),
            git_url: crate::common::GitUrl::try_from("http://localhost")?,
            parent_id: None,
        };
        let other_peer = Peer {
            id: 0,
            alias: "aA-other_peer".to_string(),
            git_url: crate::common::GitUrl::try_from("http://aA-localhost")?,
            parent_id: Some(42),
        };
        assert!(root_peer < other_peer);
        Ok(())
    }

    #[test]
    fn test_nonroot_peer_git_url_ordering() -> Result<()> {
        let peer_1 = Peer {
            id: 0,
            alias: "peer".to_string(),
            git_url: crate::common::GitUrl::try_from("http://localhost")?,
            parent_id: Some(42),
        };
        let peer_2 = Peer {
            id: 0,
            alias: "peer".to_string(),
            git_url: crate::common::GitUrl::try_from("http://aA-localhost")?,
            parent_id: Some(42),
        };
        assert!(peer_1 > peer_2);
        Ok(())
    }
}