things3-core 2.1.0

Core library for Things 3 database access and data models
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
//! Comprehensive tests for bulk operations

#![cfg(feature = "test-utils")]

use chrono::NaiveDate;
use things3_core::models::{
    BulkCompleteRequest, BulkDeleteRequest, BulkMoveRequest, BulkUpdateDatesRequest,
};
use things3_core::test_utils::{create_test_database_and_connect, TaskRequestBuilder};
use things3_core::{ThingsError, ThingsId};

// ============================================================================
// Bulk Move Tests
// ============================================================================

#[tokio::test]
async fn test_bulk_move_to_project() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create a project
    let project_request = things3_core::models::CreateProjectRequest {
        title: "Target Project".to_string(),
        notes: None,
        area_uuid: None,
        start_date: None,
        deadline: None,
        tags: None,
    };
    let project_uuid = db.create_project(project_request).await.unwrap();

    // Create 3 tasks
    let mut task_uuids = Vec::new();
    for i in 1..=3 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk move to project
    let bulk_request = BulkMoveRequest {
        task_uuids: task_uuids.clone(),
        project_uuid: Some(project_uuid.clone()),
        area_uuid: None,
    };

    let result = db.bulk_move(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 3);

    // Verify all tasks now have the project
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap().unwrap();
        assert_eq!(task.project_uuid, Some(project_uuid.clone()));
    }
}

#[tokio::test]
async fn test_bulk_move_to_area() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create an area
    let area_request = things3_core::models::CreateAreaRequest {
        title: "Target Area".to_string(),
    };
    let area_uuid = db.create_area(area_request).await.unwrap();

    // Create 3 tasks
    let mut task_uuids = Vec::new();
    for i in 1..=3 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk move to area
    let bulk_request = BulkMoveRequest {
        task_uuids: task_uuids.clone(),
        project_uuid: None,
        area_uuid: Some(area_uuid.clone()),
    };

    let result = db.bulk_move(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 3);

    // Verify all tasks now have the area
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap().unwrap();
        assert_eq!(task.area_uuid, Some(area_uuid.clone()));
    }
}

#[tokio::test]
async fn test_bulk_move_empty_uuids() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    let bulk_request = BulkMoveRequest {
        task_uuids: vec![],
        project_uuid: Some(ThingsId::new_v4()),
        area_uuid: None,
    };

    let result = db.bulk_move(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::Validation { .. })));
}

#[tokio::test]
async fn test_bulk_move_invalid_uuid() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create a project
    let project_request = things3_core::models::CreateProjectRequest {
        title: "Target Project".to_string(),
        notes: None,
        area_uuid: None,
        start_date: None,
        deadline: None,
        tags: None,
    };
    let project_uuid = db.create_project(project_request).await.unwrap();

    // Create one valid task
    let request = TaskRequestBuilder::new().title("Valid Task").build();
    let valid_uuid = db.create_task(request).await.unwrap();

    // Try to bulk move with one valid and one invalid UUID
    let invalid_uuid = ThingsId::new_v4(); // Doesn't exist in database
    let bulk_request = BulkMoveRequest {
        task_uuids: vec![valid_uuid.clone(), invalid_uuid],
        project_uuid: Some(project_uuid),
        area_uuid: None,
    };

    let result = db.bulk_move(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::TaskNotFound { .. })));

    // Verify the valid task was NOT moved (transaction rolled back)
    let task = db.get_task_by_uuid(&valid_uuid).await.unwrap().unwrap();
    assert_eq!(
        task.project_uuid, None,
        "Task should not be moved due to rollback"
    );
}

#[tokio::test]
async fn test_bulk_move_nonexistent_project() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create a task
    let request = TaskRequestBuilder::new().title("Test Task").build();
    let task_uuid = db.create_task(request).await.unwrap();

    // Try to move to non-existent project
    let fake_project_uuid = ThingsId::new_v4();
    let bulk_request = BulkMoveRequest {
        task_uuids: vec![task_uuid],
        project_uuid: Some(fake_project_uuid),
        area_uuid: None,
    };

    let result = db.bulk_move(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::ProjectNotFound { .. })));
}

// ============================================================================
// Bulk Update Dates Tests
// ============================================================================

#[tokio::test]
async fn test_bulk_update_dates_both() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create 3 tasks
    let mut task_uuids = Vec::new();
    for i in 1..=3 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk update dates
    let start_date = NaiveDate::from_ymd_opt(2024, 1, 1).unwrap();
    let deadline = NaiveDate::from_ymd_opt(2024, 12, 31).unwrap();
    let bulk_request = BulkUpdateDatesRequest {
        task_uuids: task_uuids.clone(),
        start_date: Some(start_date),
        deadline: Some(deadline),
        clear_start_date: false,
        clear_deadline: false,
    };

    let result = db.bulk_update_dates(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 3);

    // Verify all tasks have the new dates
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap().unwrap();
        assert_eq!(task.start_date, Some(start_date));
        assert_eq!(task.deadline, Some(deadline));
    }
}

#[tokio::test]
async fn test_bulk_update_dates_clear() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create tasks with dates
    let start_date = NaiveDate::from_ymd_opt(2024, 1, 1).unwrap();
    let deadline = NaiveDate::from_ymd_opt(2024, 12, 31).unwrap();
    let mut task_uuids = Vec::new();
    for i in 1..=2 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .start_date(start_date)
            .deadline(deadline)
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk clear dates
    let bulk_request = BulkUpdateDatesRequest {
        task_uuids: task_uuids.clone(),
        start_date: None,
        deadline: None,
        clear_start_date: true,
        clear_deadline: true,
    };

    let result = db.bulk_update_dates(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 2);

    // Verify dates are cleared
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap().unwrap();
        assert_eq!(task.start_date, None);
        assert_eq!(task.deadline, None);
    }
}

#[tokio::test]
async fn test_bulk_update_dates_invalid_range() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create a task
    let request = TaskRequestBuilder::new().title("Test Task").build();
    let task_uuid = db.create_task(request).await.unwrap();

    // Try to set deadline before start_date
    let bulk_request = BulkUpdateDatesRequest {
        task_uuids: vec![task_uuid],
        start_date: Some(NaiveDate::from_ymd_opt(2024, 12, 31).unwrap()),
        deadline: Some(NaiveDate::from_ymd_opt(2024, 1, 1).unwrap()),
        clear_start_date: false,
        clear_deadline: false,
    };

    let result = db.bulk_update_dates(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::DateValidation(_))));
}

#[tokio::test]
async fn test_bulk_update_dates_merge_validation() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create task with existing start date
    let start_date = NaiveDate::from_ymd_opt(2024, 6, 15).unwrap();
    let request = TaskRequestBuilder::new()
        .title("Test Task")
        .start_date(start_date)
        .build();
    let task_uuid = db.create_task(request).await.unwrap();

    // Try to set deadline before existing start_date
    let bulk_request = BulkUpdateDatesRequest {
        task_uuids: vec![task_uuid],
        start_date: None, // Don't update start_date
        deadline: Some(NaiveDate::from_ymd_opt(2024, 1, 1).unwrap()), // Before existing start
        clear_start_date: false,
        clear_deadline: false,
    };

    let result = db.bulk_update_dates(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::DateValidation(_))));
}

// ============================================================================
// Bulk Complete Tests
// ============================================================================

#[tokio::test]
async fn test_bulk_complete_multiple() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create 5 tasks
    let mut task_uuids = Vec::new();
    for i in 1..=5 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk complete
    let bulk_request = BulkCompleteRequest {
        task_uuids: task_uuids.clone(),
    };

    let result = db.bulk_complete(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 5);

    // Verify all tasks are completed
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap().unwrap();
        assert_eq!(task.status, things3_core::models::TaskStatus::Completed);
        assert!(task.stop_date.is_some());
    }
}

#[tokio::test]
async fn test_bulk_complete_already_completed() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create a task and complete it
    let request = TaskRequestBuilder::new().title("Task 1").build();
    let task_uuid = db.create_task(request).await.unwrap();
    db.complete_task(&task_uuid).await.unwrap();

    // Try to bulk complete again (should succeed, idempotent)
    let bulk_request = BulkCompleteRequest {
        task_uuids: vec![task_uuid],
    };

    let result = db.bulk_complete(bulk_request).await;
    assert!(result.is_ok());
}

// ============================================================================
// Bulk Delete Tests
// ============================================================================

#[tokio::test]
async fn test_bulk_delete_soft_delete() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create 3 tasks
    let mut task_uuids = Vec::new();
    for i in 1..=3 {
        let request = TaskRequestBuilder::new()
            .title(format!("Task {}", i))
            .build();
        let task_uuid = db.create_task(request).await.unwrap();
        task_uuids.push(task_uuid);
    }

    // Bulk delete
    let bulk_request = BulkDeleteRequest {
        task_uuids: task_uuids.clone(),
    };

    let result = db.bulk_delete(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 3);

    // Verify all tasks are soft-deleted (trashed)
    for uuid in &task_uuids {
        let task = db.get_task_by_uuid(uuid).await.unwrap();
        assert!(task.is_none(), "Deleted task should not be returned");
    }
}

#[tokio::test]
async fn test_bulk_delete_empty_uuids() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    let bulk_request = BulkDeleteRequest { task_uuids: vec![] };

    let result = db.bulk_delete(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::Validation { .. })));
}

// ============================================================================
// Transaction Rollback Tests
// ============================================================================

#[tokio::test]
async fn test_transaction_rollback_on_error() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create 2 valid tasks
    let request1 = TaskRequestBuilder::new().title("Task 1").build();
    let uuid1 = db.create_task(request1).await.unwrap();
    let request2 = TaskRequestBuilder::new().title("Task 2").build();
    let uuid2 = db.create_task(request2).await.unwrap();

    // Try to complete with one valid and one invalid UUID
    let invalid_uuid = ThingsId::new_v4();
    let bulk_request = BulkCompleteRequest {
        task_uuids: vec![uuid1.clone(), uuid2.clone(), invalid_uuid],
    };

    let result = db.bulk_complete(bulk_request).await;
    assert!(result.is_err());

    // Verify NO tasks were completed (transaction rolled back)
    let task1 = db.get_task_by_uuid(&uuid1).await.unwrap().unwrap();
    let task2 = db.get_task_by_uuid(&uuid2).await.unwrap().unwrap();
    assert_eq!(task1.status, things3_core::models::TaskStatus::Incomplete);
    assert_eq!(task2.status, things3_core::models::TaskStatus::Incomplete);
}

// ============================================================================
// Edge Case Tests
// ============================================================================

#[tokio::test]
async fn test_bulk_operations_with_single_task() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Create one task
    let request = TaskRequestBuilder::new().title("Single Task").build();
    let task_uuid = db.create_task(request).await.unwrap();

    // Test bulk complete with single task
    let bulk_request = BulkCompleteRequest {
        task_uuids: vec![task_uuid],
    };

    let result = db.bulk_complete(bulk_request).await.unwrap();
    assert!(result.success);
    assert_eq!(result.processed_count, 1);
}

#[tokio::test]
async fn test_bulk_move_exceeds_max_batch_size() {
    let (db, _temp_file) = create_test_database_and_connect().await.unwrap();

    // Try to move more than MAX_BULK_BATCH_SIZE (1000) tasks
    let mut task_uuids = Vec::new();
    for _ in 0..1001 {
        task_uuids.push(ThingsId::new_v4());
    }

    let bulk_request = BulkMoveRequest {
        task_uuids,
        project_uuid: Some(ThingsId::new_v4()),
        area_uuid: None,
    };

    let result = db.bulk_move(bulk_request).await;
    assert!(result.is_err());
    assert!(matches!(result, Err(ThingsError::Validation { .. })));
    if let Err(ThingsError::Validation { message }) = result {
        assert!(message.contains("exceeds maximum"));
        assert!(message.contains("1001"));
        assert!(message.contains("1000"));
    }
}