things3-cli 1.0.0

CLI tool for Things 3 with integrated MCP server
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
//! Integration tests for MCP middleware chain
//!
//! These tests verify that middleware components work correctly together
//! in realistic scenarios, complementing the unit tests in middleware.rs

use serde_json::json;
use std::sync::Arc;
use std::time::Duration;
use things3_cli::mcp::middleware::{
    AuthenticationMiddleware, LogLevel, LoggingMiddleware, MiddlewareChain, MiddlewareConfig,
    PerformanceMiddleware, RateLimitMiddleware, ValidationMiddleware,
};
use things3_cli::mcp::{CallToolRequest, CallToolResult, Content};

/// Helper to create a test handler that returns success
fn success_handler(
    _req: CallToolRequest,
) -> std::pin::Pin<
    Box<
        dyn std::future::Future<Output = Result<CallToolResult, things3_cli::mcp::McpError>> + Send,
    >,
> {
    Box::pin(async move {
        Ok(CallToolResult {
            content: vec![Content::Text {
                text: "Success".to_string(),
            }],
            is_error: false,
        })
    })
}

/// Helper to create a test handler that returns an error
fn error_handler(
    _req: CallToolRequest,
) -> std::pin::Pin<
    Box<
        dyn std::future::Future<Output = Result<CallToolResult, things3_cli::mcp::McpError>> + Send,
    >,
> {
    Box::pin(async move {
        Err(things3_cli::mcp::McpError::internal_error(
            "Test error".to_string(),
        ))
    })
}

// ============================================================================
// Middleware Chain Integration Tests
// ============================================================================

#[tokio::test]
async fn test_full_middleware_stack() {
    let chain = MiddlewareChain::new()
        .add_middleware(LoggingMiddleware::new(LogLevel::Debug))
        .add_middleware(ValidationMiddleware::lenient())
        .add_middleware(PerformanceMiddleware::with_threshold(Duration::from_secs(
            1,
        )));

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: Some(json!({"param": "value"})),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
    assert!(!result.unwrap().is_error);
}

#[tokio::test]
async fn test_middleware_chain_with_validation_strict() {
    let chain = MiddlewareChain::new()
        .add_middleware(ValidationMiddleware::strict())
        .add_middleware(LoggingMiddleware::info());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: Some(json!({"param": "value"})),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_middleware_chain_priority_ordering() {
    // Create middlewares with different priorities
    let logging = LoggingMiddleware::new(LogLevel::Info); // priority 100
    let validation = ValidationMiddleware::lenient(); // priority 10
    let performance = PerformanceMiddleware::with_threshold(Duration::from_millis(100)); // priority 50

    let chain = MiddlewareChain::new()
        .add_middleware(logging)
        .add_middleware(validation)
        .add_middleware(performance);

    // Chain should have 3 middlewares sorted by priority
    assert_eq!(chain.len(), 3);

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_middleware_chain_handles_handler_error() {
    let chain = MiddlewareChain::new()
        .add_middleware(LoggingMiddleware::info())
        .add_middleware(ValidationMiddleware::lenient());

    let request = CallToolRequest {
        name: "failing_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, error_handler).await;
    assert!(result.is_err());
}

#[tokio::test]
async fn test_middleware_chain_empty_arguments() {
    let chain = MiddlewareChain::new()
        .add_middleware(ValidationMiddleware::lenient())
        .add_middleware(LoggingMiddleware::debug());

    let request = CallToolRequest {
        name: "tool_without_args".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_middleware_chain_complex_arguments() {
    let chain = MiddlewareChain::new()
        .add_middleware(ValidationMiddleware::strict())
        .add_middleware(LoggingMiddleware::info());

    let request = CallToolRequest {
        name: "complex_tool".to_string(),
        arguments: Some(json!({
            "nested": {
                "array": [1, 2, 3],
                "object": {"key": "value"}
            },
            "string": "test",
            "number": 42,
            "boolean": true
        })),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

// ============================================================================
// Performance Middleware Integration Tests
// ============================================================================

#[tokio::test]
async fn test_performance_middleware_fast_request() {
    let chain = MiddlewareChain::new().add_middleware(PerformanceMiddleware::with_threshold(
        Duration::from_millis(100),
    ));

    let request = CallToolRequest {
        name: "fast_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_performance_middleware_with_slow_handler() {
    let chain = MiddlewareChain::new().add_middleware(PerformanceMiddleware::with_threshold(
        Duration::from_millis(10),
    ));

    let slow_handler = |_req: CallToolRequest| {
        Box::pin(async move {
            tokio::time::sleep(Duration::from_millis(50)).await;
            Ok(CallToolResult {
                content: vec![Content::Text {
                    text: "Slow response".to_string(),
                }],
                is_error: false,
            })
        })
    };

    let request = CallToolRequest {
        name: "slow_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, slow_handler).await;
    assert!(result.is_ok());
    // Performance middleware should log but not fail the request
}

// ============================================================================
// Logging Middleware Integration Tests
// ============================================================================

#[tokio::test]
async fn test_logging_middleware_all_levels() {
    let levels = vec![
        LogLevel::Debug,
        LogLevel::Info,
        LogLevel::Warn,
        LogLevel::Error,
    ];

    for level in levels {
        let chain = MiddlewareChain::new().add_middleware(LoggingMiddleware::new(level));

        let request = CallToolRequest {
            name: "test_tool".to_string(),
            arguments: Some(json!({"test": "data"})),
        };

        let result = chain.execute(request, success_handler).await;
        assert!(result.is_ok());
    }
}

#[tokio::test]
async fn test_logging_middleware_with_error() {
    let chain = MiddlewareChain::new().add_middleware(LoggingMiddleware::error());

    let request = CallToolRequest {
        name: "failing_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, error_handler).await;
    assert!(result.is_err());
    // Logging middleware should log the error but not suppress it
}

// ============================================================================
// Validation Middleware Integration Tests
// ============================================================================

#[tokio::test]
async fn test_validation_middleware_lenient_mode() {
    let chain = MiddlewareChain::new().add_middleware(ValidationMiddleware::lenient());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: Some(json!({"any": "data"})),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_validation_middleware_strict_mode() {
    let chain = MiddlewareChain::new().add_middleware(ValidationMiddleware::strict());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: Some(json!({"param": "value"})),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

// ============================================================================
// Security Middleware Integration Tests
// ============================================================================

#[tokio::test]
async fn test_authentication_middleware_permissive() {
    let chain = MiddlewareChain::new().add_middleware(AuthenticationMiddleware::permissive());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_rate_limit_middleware_basic() {
    let chain = MiddlewareChain::new().add_middleware(RateLimitMiddleware::new(100, 10)); // 100 req/min, burst 10

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: None,
    };

    // Should allow first request
    let result = chain.execute(request.clone(), success_handler).await;
    assert!(result.is_ok());

    // Should allow subsequent requests within limit
    for _ in 0..5 {
        let result = chain.execute(request.clone(), success_handler).await;
        assert!(result.is_ok());
    }
}

// ============================================================================
// Middleware Config Integration Tests
// ============================================================================

#[tokio::test]
async fn test_middleware_config_default() {
    let config = MiddlewareConfig::default();
    let chain = config.build_chain();

    // Default config should enable some middleware
    assert!(!chain.is_empty());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_middleware_config_all_enabled() {
    let config = MiddlewareConfig {
        logging: things3_cli::mcp::middleware::LoggingConfig {
            enabled: true,
            level: "debug".to_string(),
        },
        validation: things3_cli::mcp::middleware::ValidationConfig {
            enabled: true,
            strict_mode: false,
        },
        performance: things3_cli::mcp::middleware::PerformanceConfig {
            enabled: true,
            slow_request_threshold_ms: 1000,
        },
        security: things3_cli::mcp::middleware::SecurityConfig::default(),
    };

    let chain = config.build_chain();
    assert!(!chain.is_empty());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: Some(json!({"test": "data"})),
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_middleware_config_all_disabled() {
    let config = MiddlewareConfig {
        logging: things3_cli::mcp::middleware::LoggingConfig {
            enabled: false,
            level: "info".to_string(),
        },
        validation: things3_cli::mcp::middleware::ValidationConfig {
            enabled: false,
            strict_mode: false,
        },
        performance: things3_cli::mcp::middleware::PerformanceConfig {
            enabled: false,
            slow_request_threshold_ms: 1000,
        },
        security: things3_cli::mcp::middleware::SecurityConfig {
            authentication: things3_cli::mcp::middleware::AuthenticationConfig {
                enabled: false,
                require_auth: false,
                jwt_secret: "test".to_string(),
                api_keys: vec![],
                oauth: None,
            },
            rate_limiting: things3_cli::mcp::middleware::RateLimitingConfig {
                enabled: false,
                requests_per_minute: 60,
                burst_limit: 10,
                custom_limits: None,
            },
        },
    };

    let chain = config.build_chain();
    assert!(chain.is_empty());

    let request = CallToolRequest {
        name: "test_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(request, success_handler).await;
    assert!(result.is_ok());
}

// ============================================================================
// Complex Scenario Tests
// ============================================================================

#[tokio::test]
async fn test_middleware_chain_with_multiple_requests() {
    let chain = MiddlewareChain::new()
        .add_middleware(LoggingMiddleware::info())
        .add_middleware(ValidationMiddleware::lenient())
        .add_middleware(PerformanceMiddleware::with_threshold(
            Duration::from_millis(100),
        ));

    // Execute multiple requests through the same chain
    for i in 0..10 {
        let request = CallToolRequest {
            name: format!("tool_{}", i),
            arguments: Some(json!({"index": i})),
        };

        let result = chain.execute(request, success_handler).await;
        assert!(result.is_ok());
    }
}

#[tokio::test]
async fn test_middleware_chain_concurrent_requests() {
    let chain = Arc::new(
        MiddlewareChain::new()
            .add_middleware(LoggingMiddleware::info())
            .add_middleware(ValidationMiddleware::lenient()),
    );

    let mut handles = vec![];

    // Spawn multiple concurrent requests
    for i in 0..5 {
        let chain_clone = Arc::clone(&chain);
        let handle = tokio::spawn(async move {
            let request = CallToolRequest {
                name: format!("concurrent_tool_{}", i),
                arguments: Some(json!({"index": i})),
            };

            chain_clone.execute(request, success_handler).await
        });
        handles.push(handle);
    }

    // Wait for all requests to complete
    for handle in handles {
        let result = handle.await.unwrap();
        assert!(result.is_ok());
    }
}

#[tokio::test]
async fn test_middleware_chain_mixed_success_and_error() {
    let chain = MiddlewareChain::new()
        .add_middleware(LoggingMiddleware::info())
        .add_middleware(ValidationMiddleware::lenient());

    // Success request
    let success_request = CallToolRequest {
        name: "success_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(success_request, success_handler).await;
    assert!(result.is_ok());

    // Error request
    let error_request = CallToolRequest {
        name: "error_tool".to_string(),
        arguments: None,
    };

    let result = chain.execute(error_request, error_handler).await;
    assert!(result.is_err());
}