tensorlogic-train 0.1.0

Training loops, loss composition, and optimization schedules for TensorLogic
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
//! Learning rate schedulers.

use crate::Optimizer;

/// Trait for learning rate schedulers.
pub trait LrScheduler {
    /// Update learning rate based on current step/epoch.
    fn step(&mut self, optimizer: &mut dyn Optimizer);

    /// Get current learning rate.
    fn get_lr(&self) -> f64;

    /// Get scheduler state as a dictionary.
    fn state_dict(&self) -> std::collections::HashMap<String, f64>;

    /// Load scheduler state from a dictionary.
    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()>;
}

/// Step-based learning rate scheduler.
/// Decreases learning rate by a factor every `step_size` epochs.
#[derive(Debug, Clone)]
pub struct StepLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Step size (epochs).
    pub step_size: usize,
    /// Multiplicative factor of learning rate decay.
    pub gamma: f64,
    /// Current epoch counter.
    current_epoch: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl StepLrScheduler {
    /// Create a new step LR scheduler.
    pub fn new(initial_lr: f64, step_size: usize, gamma: f64) -> Self {
        Self {
            initial_lr,
            step_size,
            gamma,
            current_epoch: 0,
            current_lr: initial_lr,
        }
    }
}

impl LrScheduler for StepLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_epoch += 1;

        if self.current_epoch.is_multiple_of(self.step_size) {
            self.current_lr *= self.gamma;
            optimizer.set_lr(self.current_lr);
        }
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_epoch".to_string(), self.current_epoch as f64);
        state.insert("step_size".to_string(), self.step_size as f64);
        state.insert("gamma".to_string(), self.gamma);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_epoch) = state.get("current_epoch") {
            self.current_epoch = current_epoch as usize;
        }
        Ok(())
    }
}

/// Exponential learning rate scheduler.
/// Decreases learning rate by a factor of gamma every epoch.
#[derive(Debug, Clone)]
pub struct ExponentialLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Multiplicative factor of learning rate decay.
    pub gamma: f64,
    /// Current epoch counter.
    current_epoch: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl ExponentialLrScheduler {
    /// Create a new exponential LR scheduler.
    pub fn new(initial_lr: f64, gamma: f64) -> Self {
        Self {
            initial_lr,
            gamma,
            current_epoch: 0,
            current_lr: initial_lr,
        }
    }
}

impl LrScheduler for ExponentialLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_epoch += 1;
        self.current_lr = self.initial_lr * self.gamma.powi(self.current_epoch as i32);
        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_epoch".to_string(), self.current_epoch as f64);
        state.insert("gamma".to_string(), self.gamma);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_epoch) = state.get("current_epoch") {
            self.current_epoch = current_epoch as usize;
        }
        Ok(())
    }
}

/// Cosine annealing learning rate scheduler.
/// Anneals learning rate using a cosine schedule.
#[derive(Debug, Clone)]
pub struct CosineAnnealingLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Minimum learning rate.
    pub min_lr: f64,
    /// Total number of epochs.
    pub t_max: usize,
    /// Current epoch counter.
    current_epoch: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl CosineAnnealingLrScheduler {
    /// Create a new cosine annealing LR scheduler.
    pub fn new(initial_lr: f64, min_lr: f64, t_max: usize) -> Self {
        Self {
            initial_lr,
            min_lr,
            t_max,
            current_epoch: 0,
            current_lr: initial_lr,
        }
    }
}

impl LrScheduler for CosineAnnealingLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_epoch += 1;

        let progress = (self.current_epoch as f64) / (self.t_max as f64);
        let cosine_decay = 0.5 * (1.0 + (std::f64::consts::PI * progress).cos());
        self.current_lr = self.min_lr + (self.initial_lr - self.min_lr) * cosine_decay;

        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_epoch".to_string(), self.current_epoch as f64);
        state.insert("min_lr".to_string(), self.min_lr);
        state.insert("t_max".to_string(), self.t_max as f64);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_epoch) = state.get("current_epoch") {
            self.current_epoch = current_epoch as usize;
        }
        Ok(())
    }
}

/// Warmup scheduler that linearly increases learning rate.
#[derive(Debug, Clone)]
#[allow(dead_code)]
pub struct WarmupScheduler {
    /// Target learning rate after warmup.
    pub target_lr: f64,
    /// Number of warmup steps.
    pub warmup_steps: usize,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl WarmupScheduler {
    /// Create a new warmup scheduler.
    #[allow(dead_code)]
    pub fn new(target_lr: f64, warmup_steps: usize) -> Self {
        Self {
            target_lr,
            warmup_steps,
            current_step: 0,
            current_lr: 0.0,
        }
    }
}

impl LrScheduler for WarmupScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;

        if self.current_step < self.warmup_steps {
            self.current_lr =
                self.target_lr * (self.current_step as f64) / (self.warmup_steps as f64);
        } else {
            self.current_lr = self.target_lr;
        }

        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("target_lr".to_string(), self.target_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("warmup_steps".to_string(), self.warmup_steps as f64);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        Ok(())
    }
}

/// One-cycle learning rate scheduler.
/// Increases LR from initial to max, then decreases to min.
#[derive(Debug, Clone)]
pub struct OneCycleLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Maximum learning rate.
    pub max_lr: f64,
    /// Minimum learning rate (final).
    pub min_lr: f64,
    /// Total number of steps.
    pub total_steps: usize,
    /// Percentage of cycle spent increasing LR.
    pub pct_start: f64,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl OneCycleLrScheduler {
    /// Create a new one-cycle LR scheduler.
    pub fn new(
        initial_lr: f64,
        max_lr: f64,
        min_lr: f64,
        total_steps: usize,
        pct_start: f64,
    ) -> Self {
        Self {
            initial_lr,
            max_lr,
            min_lr,
            total_steps,
            pct_start,
            current_step: 0,
            current_lr: initial_lr,
        }
    }
}

impl LrScheduler for OneCycleLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;

        let step_num = self.current_step.min(self.total_steps);
        let pct = step_num as f64 / self.total_steps as f64;

        if pct < self.pct_start {
            // Increasing phase
            let phase_pct = pct / self.pct_start;
            self.current_lr = self.initial_lr + (self.max_lr - self.initial_lr) * phase_pct;
        } else {
            // Decreasing phase
            let phase_pct = (pct - self.pct_start) / (1.0 - self.pct_start);
            // Cosine annealing for smooth decay
            let cosine_decay = 0.5 * (1.0 + (std::f64::consts::PI * phase_pct).cos());
            self.current_lr = self.min_lr + (self.max_lr - self.min_lr) * cosine_decay;
        }

        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("max_lr".to_string(), self.max_lr);
        state.insert("min_lr".to_string(), self.min_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("total_steps".to_string(), self.total_steps as f64);
        state.insert("pct_start".to_string(), self.pct_start);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        Ok(())
    }
}

/// Polynomial decay learning rate scheduler.
#[derive(Debug, Clone)]
pub struct PolynomialDecayLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Final learning rate.
    pub final_lr: f64,
    /// Power of the polynomial.
    pub power: f64,
    /// Total number of decay steps.
    pub decay_steps: usize,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl PolynomialDecayLrScheduler {
    /// Create a new polynomial decay LR scheduler.
    pub fn new(initial_lr: f64, final_lr: f64, power: f64, decay_steps: usize) -> Self {
        Self {
            initial_lr,
            final_lr,
            power,
            decay_steps,
            current_step: 0,
            current_lr: initial_lr,
        }
    }
}

impl LrScheduler for PolynomialDecayLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;

        let step_num = self.current_step.min(self.decay_steps);
        let decay_factor = (1.0 - (step_num as f64 / self.decay_steps as f64)).powf(self.power);
        self.current_lr = (self.initial_lr - self.final_lr) * decay_factor + self.final_lr;

        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("final_lr".to_string(), self.final_lr);
        state.insert("power".to_string(), self.power);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("decay_steps".to_string(), self.decay_steps as f64);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        Ok(())
    }
}

/// Cyclic learning rate mode.
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum CyclicLrMode {
    /// Triangular (linear increase and decrease).
    Triangular,
    /// Triangular2 (amplitude decreases by half each cycle).
    Triangular2,
    /// Exponential range (amplitude decreases exponentially).
    ExpRange,
}

/// Cyclic learning rate scheduler.
#[derive(Debug, Clone)]
pub struct CyclicLrScheduler {
    /// Base learning rate.
    pub base_lr: f64,
    /// Maximum learning rate.
    pub max_lr: f64,
    /// Step size (half of cycle length).
    pub step_size: usize,
    /// Cyclic mode.
    pub mode: CyclicLrMode,
    /// Gamma for exponential range mode.
    pub gamma: f64,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
    /// Current cycle number.
    cycle: usize,
}

impl CyclicLrScheduler {
    /// Create a new cyclic LR scheduler.
    pub fn new(base_lr: f64, max_lr: f64, step_size: usize, mode: CyclicLrMode) -> Self {
        Self {
            base_lr,
            max_lr,
            step_size,
            mode,
            gamma: 0.99994,
            current_step: 0,
            current_lr: base_lr,
            cycle: 0,
        }
    }

    /// Create a new cyclic LR scheduler with exponential range mode.
    pub fn new_exp_range(base_lr: f64, max_lr: f64, step_size: usize, gamma: f64) -> Self {
        Self {
            base_lr,
            max_lr,
            step_size,
            mode: CyclicLrMode::ExpRange,
            gamma,
            current_step: 0,
            current_lr: base_lr,
            cycle: 0,
        }
    }
}

impl LrScheduler for CyclicLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;

        // Determine cycle position
        let cycle = (self.current_step - 1) / (2 * self.step_size);
        let x = ((self.current_step - 1) as f64 / self.step_size as f64).abs() % 2.0;

        // Calculate scaling factor based on mode
        let scale_fn = match self.mode {
            CyclicLrMode::Triangular => 1.0,
            CyclicLrMode::Triangular2 => 1.0 / 2.0_f64.powi(cycle as i32),
            CyclicLrMode::ExpRange => self.gamma.powi(self.current_step as i32),
        };

        // Calculate current LR
        if x <= 1.0 {
            // Increasing phase
            self.current_lr = self.base_lr + (self.max_lr - self.base_lr) * x * scale_fn;
        } else {
            // Decreasing phase
            self.current_lr = self.base_lr + (self.max_lr - self.base_lr) * (2.0 - x) * scale_fn;
        }

        self.cycle = cycle;
        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("base_lr".to_string(), self.base_lr);
        state.insert("max_lr".to_string(), self.max_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("step_size".to_string(), self.step_size as f64);
        state.insert("cycle".to_string(), self.cycle as f64);
        state.insert("gamma".to_string(), self.gamma);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        if let Some(&cycle) = state.get("cycle") {
            self.cycle = cycle as usize;
        }
        Ok(())
    }
}

/// Warmup with cosine annealing scheduler.
#[derive(Debug, Clone)]
pub struct WarmupCosineLrScheduler {
    /// Target learning rate after warmup.
    pub target_lr: f64,
    /// Minimum learning rate.
    pub min_lr: f64,
    /// Number of warmup steps.
    pub warmup_steps: usize,
    /// Total number of steps (including warmup).
    pub total_steps: usize,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl WarmupCosineLrScheduler {
    /// Create a new warmup cosine LR scheduler.
    pub fn new(target_lr: f64, min_lr: f64, warmup_steps: usize, total_steps: usize) -> Self {
        Self {
            target_lr,
            min_lr,
            warmup_steps,
            total_steps,
            current_step: 0,
            current_lr: 0.0,
        }
    }
}

impl LrScheduler for WarmupCosineLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;

        if self.current_step <= self.warmup_steps {
            // Warmup phase: linear increase
            self.current_lr =
                self.target_lr * (self.current_step as f64 / self.warmup_steps as f64);
        } else {
            // Cosine annealing phase
            let progress = (self.current_step - self.warmup_steps) as f64
                / (self.total_steps - self.warmup_steps) as f64;
            let cosine_decay = 0.5 * (1.0 + (std::f64::consts::PI * progress).cos());
            self.current_lr = self.min_lr + (self.target_lr - self.min_lr) * cosine_decay;
        }

        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("target_lr".to_string(), self.target_lr);
        state.insert("min_lr".to_string(), self.min_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("warmup_steps".to_string(), self.warmup_steps as f64);
        state.insert("total_steps".to_string(), self.total_steps as f64);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        Ok(())
    }
}

/// Noam scheduler (Transformer learning rate schedule).
///
/// This is the learning rate schedule used in "Attention is All You Need".
/// It increases linearly for warmup_steps, then decays proportionally to the
/// inverse square root of the step number.
///
/// Reference: Vaswani et al. "Attention is All You Need" (NIPS 2017)
#[derive(Debug, Clone)]
pub struct NoamScheduler {
    /// Model dimension (d_model) from the paper.
    model_dim: f64,
    /// Number of warmup steps.
    warmup_steps: usize,
    /// Scaling factor (typically 1.0).
    scale_factor: f64,
    /// Current step counter.
    current_step: usize,
    /// Current learning rate.
    current_lr: f64,
}

impl NoamScheduler {
    /// Create a new Noam scheduler.
    ///
    /// # Arguments
    /// * `model_dim` - Model dimension (d_model), typically 512 for Transformer
    /// * `warmup_steps` - Number of warmup steps, typically 4000
    /// * `scale_factor` - Scaling factor, typically 1.0 or 2.0
    pub fn new(model_dim: usize, warmup_steps: usize, scale_factor: f64) -> Self {
        let model_dim_f64 = model_dim as f64;
        let current_lr = scale_factor * model_dim_f64.powf(-0.5);

        Self {
            model_dim: model_dim_f64,
            warmup_steps,
            scale_factor,
            current_step: 0,
            current_lr,
        }
    }

    /// Compute learning rate for the current step.
    fn compute_lr(&self) -> f64 {
        let step = (self.current_step + 1) as f64; // +1 to avoid division by zero
        let warmup = self.warmup_steps as f64;

        // lr = scale * d_model^(-0.5) * min(step^(-0.5), step * warmup^(-1.5))
        self.scale_factor
            * self.model_dim.powf(-0.5)
            * step.powf(-0.5).min(step * warmup.powf(-1.5))
    }
}

impl LrScheduler for NoamScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_step += 1;
        self.current_lr = self.compute_lr();
        optimizer.set_lr(self.current_lr);
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("model_dim".to_string(), self.model_dim);
        state.insert("warmup_steps".to_string(), self.warmup_steps as f64);
        state.insert("scale_factor".to_string(), self.scale_factor);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("current_lr".to_string(), self.current_lr);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        Ok(())
    }
}

/// Multi-step learning rate scheduler.
///
/// Decays the learning rate by gamma at specified milestones (epochs).
/// This is useful when you know specific points where you want to reduce LR.
#[derive(Debug, Clone)]
pub struct MultiStepLrScheduler {
    /// Initial learning rate.
    pub initial_lr: f64,
    /// Milestones (epochs) at which to decay LR.
    pub milestones: Vec<usize>,
    /// Multiplicative factor of learning rate decay.
    pub gamma: f64,
    /// Current epoch counter.
    current_epoch: usize,
    /// Current learning rate.
    current_lr: f64,
    /// Index of next milestone to trigger.
    next_milestone_idx: usize,
}

impl MultiStepLrScheduler {
    /// Create a new multi-step LR scheduler.
    ///
    /// # Arguments
    /// * `initial_lr` - Initial learning rate
    /// * `milestones` - Epochs at which to decay (should be sorted)
    /// * `gamma` - Multiplicative decay factor
    pub fn new(initial_lr: f64, mut milestones: Vec<usize>, gamma: f64) -> Self {
        // Ensure milestones are sorted
        milestones.sort_unstable();

        Self {
            initial_lr,
            milestones,
            gamma,
            current_epoch: 0,
            current_lr: initial_lr,
            next_milestone_idx: 0,
        }
    }
}

impl LrScheduler for MultiStepLrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        self.current_epoch += 1;

        // Check if we've reached a milestone
        if self.next_milestone_idx < self.milestones.len()
            && self.current_epoch >= self.milestones[self.next_milestone_idx]
        {
            self.current_lr *= self.gamma;
            self.next_milestone_idx += 1;
            optimizer.set_lr(self.current_lr);
        }
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("initial_lr".to_string(), self.initial_lr);
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("current_epoch".to_string(), self.current_epoch as f64);
        state.insert("gamma".to_string(), self.gamma);
        state.insert(
            "next_milestone_idx".to_string(),
            self.next_milestone_idx as f64,
        );
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&current_epoch) = state.get("current_epoch") {
            self.current_epoch = current_epoch as usize;
        }
        if let Some(&next_milestone_idx) = state.get("next_milestone_idx") {
            self.next_milestone_idx = next_milestone_idx as usize;
        }
        Ok(())
    }
}

/// Reduce learning rate on plateau (metric-based adaptive scheduler).
///
/// Reduces learning rate when a metric (e.g., validation loss) has stopped improving.
/// This scheduler requires explicit metric updates via `step_with_metric()`.
#[derive(Debug, Clone)]
pub struct ReduceLROnPlateauScheduler {
    /// Current learning rate.
    current_lr: f64,
    /// Decay factor.
    pub factor: f64,
    /// Number of epochs with no improvement after which LR will be reduced.
    pub patience: usize,
    /// Minimum LR.
    pub min_lr: f64,
    /// Threshold for measuring improvement (relative).
    pub threshold: f64,
    /// Number of epochs to wait before resuming normal operation after LR reduction.
    pub cooldown: usize,
    /// Best metric value seen so far.
    best_metric: Option<f64>,
    /// Number of epochs with no improvement.
    num_bad_epochs: usize,
    /// Epochs remaining in cooldown period.
    cooldown_counter: usize,
    /// Mode: "min" (lower is better) or "max" (higher is better).
    mode: PlateauMode,
}

/// Mode for ReduceLROnPlateau scheduler.
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum PlateauMode {
    /// Lower metric values are better (e.g., loss).
    Min,
    /// Higher metric values are better (e.g., accuracy).
    Max,
}

impl ReduceLROnPlateauScheduler {
    /// Create a new ReduceLROnPlateau scheduler.
    ///
    /// # Arguments
    /// * `initial_lr` - Initial learning rate
    /// * `mode` - Whether to minimize or maximize the metric
    /// * `factor` - Factor by which to reduce LR (new_lr = lr * factor)
    /// * `patience` - Number of epochs with no improvement to wait
    /// * `threshold` - Threshold for measuring improvement (relative)
    /// * `min_lr` - Minimum LR (won't reduce below this)
    /// * `cooldown` - Cooldown epochs after LR reduction
    pub fn new(
        initial_lr: f64,
        mode: PlateauMode,
        factor: f64,
        patience: usize,
        threshold: f64,
        min_lr: f64,
        cooldown: usize,
    ) -> Self {
        Self {
            current_lr: initial_lr,
            factor,
            patience,
            min_lr,
            threshold,
            cooldown,
            best_metric: None,
            num_bad_epochs: 0,
            cooldown_counter: 0,
            mode,
        }
    }

    /// Step with a metric value.
    ///
    /// This should be called with the validation metric at the end of each epoch.
    pub fn step_with_metric(&mut self, optimizer: &mut dyn Optimizer, metric: f64) {
        // Check if in cooldown period
        if self.cooldown_counter > 0 {
            self.cooldown_counter -= 1;
            return;
        }

        // Check if metric has improved
        let is_better = match self.best_metric {
            None => true, // First metric always sets the baseline
            Some(best) => match self.mode {
                PlateauMode::Min => metric < best * (1.0 - self.threshold),
                PlateauMode::Max => metric > best * (1.0 + self.threshold),
            },
        };

        if is_better {
            // Metric improved
            self.best_metric = Some(metric);
            self.num_bad_epochs = 0;
        } else {
            // Metric didn't improve
            self.num_bad_epochs += 1;

            if self.num_bad_epochs >= self.patience {
                // Reduce learning rate
                let new_lr = (self.current_lr * self.factor).max(self.min_lr);

                if new_lr < self.current_lr {
                    self.current_lr = new_lr;
                    optimizer.set_lr(self.current_lr);
                    self.cooldown_counter = self.cooldown;
                    self.num_bad_epochs = 0;
                }
            }
        }
    }
}

impl LrScheduler for ReduceLROnPlateauScheduler {
    fn step(&mut self, _optimizer: &mut dyn Optimizer) {
        // This scheduler needs metrics, so the default step() does nothing.
        // Users should call step_with_metric() instead.
    }

    fn get_lr(&self) -> f64 {
        self.current_lr
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("current_lr".to_string(), self.current_lr);
        state.insert("factor".to_string(), self.factor);
        state.insert("patience".to_string(), self.patience as f64);
        state.insert("min_lr".to_string(), self.min_lr);
        state.insert("threshold".to_string(), self.threshold);
        state.insert("cooldown".to_string(), self.cooldown as f64);
        state.insert(
            "best_metric".to_string(),
            self.best_metric.unwrap_or(f64::NAN),
        );
        state.insert("num_bad_epochs".to_string(), self.num_bad_epochs as f64);
        state.insert("cooldown_counter".to_string(), self.cooldown_counter as f64);
        state.insert(
            "mode".to_string(),
            match self.mode {
                PlateauMode::Min => 0.0,
                PlateauMode::Max => 1.0,
            },
        );
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&current_lr) = state.get("current_lr") {
            self.current_lr = current_lr;
        }
        if let Some(&best_metric) = state.get("best_metric") {
            self.best_metric = if best_metric.is_nan() {
                None
            } else {
                Some(best_metric)
            };
        }
        if let Some(&num_bad_epochs) = state.get("num_bad_epochs") {
            self.num_bad_epochs = num_bad_epochs as usize;
        }
        if let Some(&cooldown_counter) = state.get("cooldown_counter") {
            self.cooldown_counter = cooldown_counter as usize;
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{OptimizerConfig, SgdOptimizer};

    #[test]
    fn test_step_lr_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = StepLrScheduler::new(0.1, 2, 0.5);

        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert_eq!(scheduler.get_lr(), 0.05);

        scheduler.step(&mut optimizer);
        assert_eq!(scheduler.get_lr(), 0.05);

        scheduler.step(&mut optimizer);
        assert_eq!(scheduler.get_lr(), 0.025);
    }

    #[test]
    fn test_exponential_lr_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = ExponentialLrScheduler::new(0.1, 0.9);

        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.09).abs() < 1e-6);

        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.081).abs() < 1e-6);
    }

    #[test]
    fn test_cosine_annealing_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = CosineAnnealingLrScheduler::new(0.1, 0.01, 10);

        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert!(scheduler.get_lr() < 0.1);
        assert!(scheduler.get_lr() > 0.01);

        // Step to halfway point
        for _ in 1..5 {
            scheduler.step(&mut optimizer);
        }
        let halfway_lr = scheduler.get_lr();
        assert!((halfway_lr - 0.055).abs() < 0.01); // Should be approximately at midpoint
    }

    #[test]
    fn test_warmup_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.0,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = WarmupScheduler::new(0.1, 10);

        assert_eq!(scheduler.get_lr(), 0.0);

        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.01).abs() < 1e-6);

        for _ in 1..10 {
            scheduler.step(&mut optimizer);
        }
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert_eq!(scheduler.get_lr(), 0.1); // Stays at target after warmup
    }

    #[test]
    fn test_one_cycle_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.01,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = OneCycleLrScheduler::new(0.01, 0.1, 0.001, 100, 0.3);

        assert_eq!(scheduler.get_lr(), 0.01);

        // Test increasing phase
        for _ in 0..30 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() > 0.01);
        assert!(scheduler.get_lr() <= 0.1);

        // Test decreasing phase
        for _ in 30..100 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() < 0.1);
    }

    #[test]
    fn test_polynomial_decay_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = PolynomialDecayLrScheduler::new(0.1, 0.001, 2.0, 100);

        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step(&mut optimizer);
        assert!(scheduler.get_lr() < 0.1);

        for _ in 1..100 {
            scheduler.step(&mut optimizer);
        }
        assert!((scheduler.get_lr() - 0.001).abs() < 1e-6);
    }

    #[test]
    fn test_cyclic_lr_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.01,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = CyclicLrScheduler::new(0.01, 0.1, 10, CyclicLrMode::Triangular);

        assert_eq!(scheduler.get_lr(), 0.01);

        // Test first cycle
        for _ in 0..10 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() > 0.01);

        for _ in 10..20 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() < 0.1);
    }

    #[test]
    fn test_warmup_cosine_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.0,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = WarmupCosineLrScheduler::new(0.1, 0.001, 10, 100);

        assert_eq!(scheduler.get_lr(), 0.0);

        // Test warmup phase
        for _ in 0..10 {
            scheduler.step(&mut optimizer);
        }
        assert!((scheduler.get_lr() - 0.1).abs() < 1e-6);

        // Test middle of cosine annealing phase
        for _ in 10..50 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() < 0.1);
        assert!(scheduler.get_lr() > 0.001);

        // Test near end of cosine annealing phase
        for _ in 50..100 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() < 0.1);
        // At the end, LR should be close to min_lr
        assert!((scheduler.get_lr() - 0.001).abs() < 0.01);
    }

    #[test]
    fn test_noam_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.0,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = NoamScheduler::new(512, 4000, 1.0);

        let initial_lr = scheduler.get_lr();
        assert!(initial_lr > 0.0);

        // Step once
        scheduler.step(&mut optimizer);
        let step1_lr = scheduler.get_lr();

        // After step, LR should change
        assert!(step1_lr != initial_lr);

        // At peak (warmup_steps), test decrease after that
        for _ in 1..4000 {
            scheduler.step(&mut optimizer);
        }
        let peak_lr = scheduler.get_lr();

        // After warmup, LR should decrease
        for _ in 4000..8000 {
            scheduler.step(&mut optimizer);
        }
        assert!(scheduler.get_lr() < peak_lr);
    }

    #[test]
    fn test_multistep_lr_scheduler() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = MultiStepLrScheduler::new(0.1, vec![10, 20, 30], 0.1);

        assert_eq!(scheduler.get_lr(), 0.1);

        // Before first milestone
        for _ in 0..9 {
            scheduler.step(&mut optimizer);
        }
        assert_eq!(scheduler.get_lr(), 0.1);

        // At first milestone (epoch 10)
        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.01).abs() < 1e-6);

        // Between first and second milestone
        for _ in 10..19 {
            scheduler.step(&mut optimizer);
        }
        assert!((scheduler.get_lr() - 0.01).abs() < 1e-6);

        // At second milestone (epoch 20)
        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.001).abs() < 1e-6);

        // At third milestone (epoch 30)
        for _ in 20..29 {
            scheduler.step(&mut optimizer);
        }
        scheduler.step(&mut optimizer);
        assert!((scheduler.get_lr() - 0.0001).abs() < 1e-6);
    }

    #[test]
    fn test_reduce_lr_on_plateau_min_mode() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = ReduceLROnPlateauScheduler::new(
            0.1,              // initial_lr
            PlateauMode::Min, // mode
            0.5,              // factor
            3,                // patience
            0.01,             // threshold
            0.001,            // min_lr
            2,                // cooldown
        );

        assert_eq!(scheduler.get_lr(), 0.1);

        // Metric improving - LR should not change
        scheduler.step_with_metric(&mut optimizer, 1.0);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step_with_metric(&mut optimizer, 0.9);
        assert_eq!(scheduler.get_lr(), 0.1);

        // Metric plateaus for patience epochs
        scheduler.step_with_metric(&mut optimizer, 0.9);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step_with_metric(&mut optimizer, 0.9);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step_with_metric(&mut optimizer, 0.9);
        // After patience epochs, LR should be reduced
        assert_eq!(scheduler.get_lr(), 0.05);

        // Test cooldown - LR shouldn't change during cooldown
        scheduler.step_with_metric(&mut optimizer, 1.0);
        assert_eq!(scheduler.get_lr(), 0.05);

        scheduler.step_with_metric(&mut optimizer, 1.0);
        assert_eq!(scheduler.get_lr(), 0.05);
    }

    #[test]
    fn test_reduce_lr_on_plateau_max_mode() {
        let config = OptimizerConfig {
            learning_rate: 0.1,
            ..Default::default()
        };
        let mut optimizer = SgdOptimizer::new(config);
        let mut scheduler = ReduceLROnPlateauScheduler::new(
            0.1,
            PlateauMode::Max, // Maximize metric (e.g., accuracy)
            0.1,
            2,
            0.01,
            0.001,
            0,
        );

        assert_eq!(scheduler.get_lr(), 0.1);

        // Metric improving (increasing) - LR should not change
        scheduler.step_with_metric(&mut optimizer, 0.5);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step_with_metric(&mut optimizer, 0.6);
        assert_eq!(scheduler.get_lr(), 0.1);

        // Metric plateaus
        scheduler.step_with_metric(&mut optimizer, 0.6);
        assert_eq!(scheduler.get_lr(), 0.1);

        scheduler.step_with_metric(&mut optimizer, 0.6);
        // After patience epochs, LR should be reduced
        assert!((scheduler.get_lr() - 0.01).abs() < 1e-6);
    }

    #[test]
    fn test_sgdr_scheduler() {
        let mut scheduler = SgdrScheduler::new(0.1, 0.001, 10, 2.0);
        let mut optimizer = SgdOptimizer::new(OptimizerConfig::default());

        // At start, should be at max_lr
        let initial_lr = scheduler.get_current_lr();
        assert!((initial_lr - 0.1).abs() < 1e-6);

        // Step through first period
        for _ in 0..5 {
            scheduler.step(&mut optimizer);
        }

        // Should be decreasing
        let mid_lr = scheduler.get_lr();
        assert!(mid_lr < initial_lr);

        // Complete first period and check restart
        for _ in 5..10 {
            scheduler.step(&mut optimizer);
        }

        // After restart, should be back to max_lr
        scheduler.step(&mut optimizer);
        let restart_lr = scheduler.get_lr();
        assert!(restart_lr > mid_lr); // Should have restarted

        // Period should have doubled
        assert_eq!(scheduler.current_period, 20);
    }
}

/// SGDR: Stochastic Gradient Descent with Warm Restarts scheduler.
///
/// Based on "SGDR: Stochastic Gradient Descent with Warm Restarts" (Loshchilov & Hutter, 2017).
/// Periodically resets the learning rate to a high value and then decays it using cosine annealing.
#[derive(Debug, Clone)]
pub struct SgdrScheduler {
    /// Initial learning rate (after restart).
    pub max_lr: f64,
    /// Minimum learning rate.
    pub min_lr: f64,
    /// Initial period length.
    pub t_0: usize,
    /// Period multiplication factor after each restart.
    pub t_mult: f64,
    /// Current step within the period.
    current_step: usize,
    /// Current period length.
    current_period: usize,
    /// Total steps taken.
    total_steps: usize,
}

impl SgdrScheduler {
    /// Create a new SGDR scheduler.
    ///
    /// # Arguments
    /// * `max_lr` - Maximum learning rate (used at restart)
    /// * `min_lr` - Minimum learning rate
    /// * `t_0` - Initial period length
    /// * `t_mult` - Period multiplication factor (typically 1.0 or 2.0)
    pub fn new(max_lr: f64, min_lr: f64, t_0: usize, t_mult: f64) -> Self {
        Self {
            max_lr,
            min_lr,
            t_0,
            t_mult,
            current_step: 0,
            current_period: t_0,
            total_steps: 0,
        }
    }

    /// Get current learning rate based on cosine annealing within the period.
    fn get_current_lr(&self) -> f64 {
        let progress = self.current_step as f64 / self.current_period as f64;
        let cosine_factor = (1.0 + (std::f64::consts::PI * progress).cos()) / 2.0;
        self.min_lr + (self.max_lr - self.min_lr) * cosine_factor
    }
}

impl LrScheduler for SgdrScheduler {
    fn step(&mut self, optimizer: &mut dyn Optimizer) {
        let lr = self.get_current_lr();
        optimizer.set_lr(lr);

        self.current_step += 1;
        self.total_steps += 1;

        // Check if we need to restart
        if self.current_step >= self.current_period {
            self.current_step = 0;
            self.current_period = (self.current_period as f64 * self.t_mult) as usize;
            // After restart, LR resets to max_lr
        }
    }

    fn get_lr(&self) -> f64 {
        self.get_current_lr()
    }

    fn state_dict(&self) -> std::collections::HashMap<String, f64> {
        let mut state = std::collections::HashMap::new();
        state.insert("max_lr".to_string(), self.max_lr);
        state.insert("min_lr".to_string(), self.min_lr);
        state.insert("t_0".to_string(), self.t_0 as f64);
        state.insert("t_mult".to_string(), self.t_mult);
        state.insert("current_step".to_string(), self.current_step as f64);
        state.insert("current_period".to_string(), self.current_period as f64);
        state.insert("total_steps".to_string(), self.total_steps as f64);
        state
    }

    fn load_state_dict(
        &mut self,
        state: &std::collections::HashMap<String, f64>,
    ) -> crate::TrainResult<()> {
        if let Some(&max_lr) = state.get("max_lr") {
            self.max_lr = max_lr;
        }
        if let Some(&min_lr) = state.get("min_lr") {
            self.min_lr = min_lr;
        }
        if let Some(&t_0) = state.get("t_0") {
            self.t_0 = t_0 as usize;
        }
        if let Some(&t_mult) = state.get("t_mult") {
            self.t_mult = t_mult;
        }
        if let Some(&current_step) = state.get("current_step") {
            self.current_step = current_step as usize;
        }
        if let Some(&current_period) = state.get("current_period") {
            self.current_period = current_period as usize;
        }
        if let Some(&total_steps) = state.get("total_steps") {
            self.total_steps = total_steps as usize;
        }
        Ok(())
    }
}