1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
//! Parallel message passing algorithms using rayon.
//!
//! This module provides parallel implementations of belief propagation algorithms
//! that can significantly speed up inference on large factor graphs with many variables.
use crate::error::{PgmError, Result};
use crate::factor::Factor;
use crate::graph::FactorGraph;
use crate::message_passing::ConvergenceStats;
use rayon::prelude::*;
use scirs2_core::ndarray::ArrayD;
use std::collections::HashMap;
use std::sync::{Arc, Mutex};
/// Parallel sum-product belief propagation.
///
/// Uses rayon to compute messages in parallel, which can provide significant
/// speedup for large factor graphs.
pub struct ParallelSumProduct {
/// Maximum iterations for convergence
pub max_iterations: usize,
/// Convergence tolerance
pub tolerance: f64,
/// Damping factor (0.0 = no damping, 1.0 = full damping)
pub damping: f64,
}
impl Default for ParallelSumProduct {
fn default() -> Self {
Self {
max_iterations: 100,
tolerance: 1e-6,
damping: 0.0,
}
}
}
impl ParallelSumProduct {
/// Create with custom parameters.
pub fn new(max_iterations: usize, tolerance: f64, damping: f64) -> Self {
Self {
max_iterations,
tolerance,
damping,
}
}
/// Run parallel belief propagation.
pub fn run_parallel(&self, graph: &FactorGraph) -> Result<HashMap<String, ArrayD<f64>>> {
// Initialize messages
let messages = Arc::new(Mutex::new(self.initialize_messages(graph)?));
// Iterative message passing
for iteration in 0..self.max_iterations {
let old_messages = messages
.lock()
.expect("lock should not be poisoned")
.clone();
// Parallel computation of variable-to-factor messages
let var_factor_updates: Vec<_> = graph
.variable_names()
.par_bridge()
.flat_map(|var_name| {
if let Some(factors) = graph.get_adjacent_factors(var_name) {
factors
.par_iter()
.filter_map(|factor_id| {
if let Some(factor) = graph.get_factor(factor_id) {
let key = (var_name.to_string(), factor.name.clone());
match self.compute_var_to_factor_message(
graph,
&old_messages,
var_name,
&factor.name,
) {
Ok(msg) => Some((key, msg)),
Err(_) => None,
}
} else {
None
}
})
.collect::<Vec<_>>()
} else {
Vec::new()
}
})
.collect();
// Parallel computation of factor-to-variable messages
let factor_var_updates: Vec<_> = graph
.factor_ids()
.par_bridge()
.filter_map(|factor_id| graph.get_factor(factor_id))
.flat_map(|factor| {
factor
.variables
.par_iter()
.filter_map(|var_name| {
let key = (factor.name.clone(), var_name.clone());
match self.compute_factor_to_var_message(
graph,
&old_messages,
&factor.name,
var_name,
) {
Ok(msg) => Some((key, msg)),
Err(_) => None,
}
})
.collect::<Vec<_>>()
})
.collect();
// Update messages with damping
{
let mut messages_guard = messages.lock().expect("lock should not be poisoned");
for (key, new_msg) in var_factor_updates.into_iter().chain(factor_var_updates) {
if let Some(old_msg) = messages_guard.get(&key) {
if self.damping > 0.0 {
// Apply damping: msg_new = (1-d)*msg_new + d*msg_old
let damped = self.apply_damping(old_msg, &new_msg);
messages_guard.insert(key, damped);
} else {
messages_guard.insert(key, new_msg);
}
} else {
messages_guard.insert(key, new_msg);
}
}
}
// Check convergence
let converged = self.check_convergence(
&old_messages,
&messages.lock().expect("lock should not be poisoned"),
);
if converged {
break;
}
if iteration == self.max_iterations - 1 {
return Err(PgmError::ConvergenceFailure(format!(
"Parallel belief propagation did not converge after {} iterations",
self.max_iterations
)));
}
}
// Compute final marginals in parallel
let marginals: HashMap<String, ArrayD<f64>> = graph
.variable_names()
.par_bridge()
.filter_map(|var_name| {
match self.compute_marginal(
graph,
&messages.lock().expect("lock should not be poisoned"),
var_name,
) {
Ok(marginal) => Some((var_name.to_string(), marginal)),
Err(_) => None,
}
})
.collect();
Ok(marginals)
}
/// Initialize messages with uniform distributions.
fn initialize_messages(
&self,
graph: &FactorGraph,
) -> Result<HashMap<(String, String), Factor>> {
let mut messages = HashMap::new();
// Initialize variable-to-factor messages
for var_name in graph.variable_names() {
if let Some(var_node) = graph.get_variable(var_name) {
let uniform_values = vec![1.0 / var_node.cardinality as f64; var_node.cardinality];
let uniform_array =
scirs2_core::ndarray::Array::from_vec(uniform_values).into_dyn();
if let Some(factors) = graph.get_adjacent_factors(var_name) {
for factor_id in factors {
if let Some(factor) = graph.get_factor(factor_id) {
let msg = Factor::new(
format!("msg_{}_{}", var_name, factor.name),
vec![var_name.to_string()],
uniform_array.clone(),
)?;
messages.insert((var_name.to_string(), factor.name.clone()), msg);
}
}
}
}
}
// Initialize factor-to-variable messages
for factor_id in graph.factor_ids() {
if let Some(factor) = graph.get_factor(factor_id) {
for var_name in &factor.variables {
if let Some(var_node) = graph.get_variable(var_name) {
let uniform_values =
vec![1.0 / var_node.cardinality as f64; var_node.cardinality];
let uniform_array =
scirs2_core::ndarray::Array::from_vec(uniform_values).into_dyn();
let msg = Factor::new(
format!("msg_{}_{}", factor.name, var_name),
vec![var_name.to_string()],
uniform_array,
)?;
messages.insert((factor.name.clone(), var_name.to_string()), msg);
}
}
}
}
Ok(messages)
}
/// Compute variable-to-factor message.
fn compute_var_to_factor_message(
&self,
graph: &FactorGraph,
messages: &HashMap<(String, String), Factor>,
var: &str,
target_factor: &str,
) -> Result<Factor> {
let var_node = graph
.get_variable(var)
.ok_or_else(|| PgmError::VariableNotFound(var.to_string()))?;
// Start with uniform
let mut message_values = vec![1.0; var_node.cardinality];
// Multiply all incoming factor-to-variable messages except from target
if let Some(factors) = graph.get_adjacent_factors(var) {
for factor_id in factors {
if let Some(factor) = graph.get_factor(factor_id) {
if factor.name != target_factor {
let key = (factor.name.clone(), var.to_string());
if let Some(incoming_msg) = messages.get(&key) {
for (i, message_value) in message_values
.iter_mut()
.enumerate()
.take(var_node.cardinality)
{
*message_value *= incoming_msg.values[[i]];
}
}
}
}
}
}
let array = scirs2_core::ndarray::Array::from_vec(message_values).into_dyn();
Factor::new(
format!("msg_{}_{}", var, target_factor),
vec![var.to_string()],
array,
)
}
/// Compute factor-to-variable message.
fn compute_factor_to_var_message(
&self,
graph: &FactorGraph,
messages: &HashMap<(String, String), Factor>,
factor_name: &str,
target_var: &str,
) -> Result<Factor> {
let factor = graph
.get_factor_by_name(factor_name)
.ok_or_else(|| PgmError::InvalidGraph(format!("Factor {} not found", factor_name)))?;
// Start with the factor
let mut product = factor.clone();
// Multiply all incoming variable-to-factor messages except from target
for var in &factor.variables {
if var != target_var {
let key = (var.clone(), factor_name.to_string());
if let Some(incoming_msg) = messages.get(&key) {
product = product.product(incoming_msg)?;
}
}
}
// Marginalize out all variables except target
for var in &factor.variables {
if var != target_var {
product = product.marginalize_out(var)?;
}
}
Ok(product)
}
/// Compute marginal for a variable.
fn compute_marginal(
&self,
graph: &FactorGraph,
messages: &HashMap<(String, String), Factor>,
var: &str,
) -> Result<ArrayD<f64>> {
let var_node = graph
.get_variable(var)
.ok_or_else(|| PgmError::VariableNotFound(var.to_string()))?;
let mut marginal_values = vec![1.0; var_node.cardinality];
// Multiply all incoming factor-to-variable messages
if let Some(factors) = graph.get_adjacent_factors(var) {
for factor_id in factors {
if let Some(factor) = graph.get_factor(factor_id) {
let key = (factor.name.clone(), var.to_string());
if let Some(msg) = messages.get(&key) {
for (i, marginal_value) in marginal_values
.iter_mut()
.enumerate()
.take(var_node.cardinality)
{
*marginal_value *= msg.values[[i]];
}
}
}
}
}
// Normalize
let sum: f64 = marginal_values.iter().sum();
if sum > 0.0 {
for val in &mut marginal_values {
*val /= sum;
}
}
Ok(scirs2_core::ndarray::Array::from_vec(marginal_values).into_dyn())
}
/// Apply damping to messages.
fn apply_damping(&self, old_msg: &Factor, new_msg: &Factor) -> Factor {
let mut damped_values = new_msg.values.clone();
for i in 0..damped_values.len() {
damped_values[[i]] =
(1.0 - self.damping) * damped_values[[i]] + self.damping * old_msg.values[[i]];
}
Factor::new(
new_msg.name.clone(),
new_msg.variables.clone(),
damped_values,
)
.unwrap_or_else(|_| new_msg.clone())
}
/// Check convergence of messages.
fn check_convergence(
&self,
old_messages: &HashMap<(String, String), Factor>,
new_messages: &HashMap<(String, String), Factor>,
) -> bool {
for (key, new_msg) in new_messages {
if let Some(old_msg) = old_messages.get(key) {
let diff: f64 = new_msg
.values
.iter()
.zip(old_msg.values.iter())
.map(|(a, b)| (a - b).abs())
.sum();
if diff > self.tolerance {
return false;
}
}
}
true
}
/// Get convergence statistics.
pub fn get_stats(&self) -> ConvergenceStats {
ConvergenceStats {
iterations: 0,
converged: false,
max_delta: 0.0,
}
}
}
/// Parallel max-product algorithm for MAP inference.
pub struct ParallelMaxProduct {
/// Maximum iterations
pub max_iterations: usize,
/// Convergence tolerance
pub tolerance: f64,
}
impl Default for ParallelMaxProduct {
fn default() -> Self {
Self {
max_iterations: 100,
tolerance: 1e-6,
}
}
}
impl ParallelMaxProduct {
/// Create with custom parameters.
pub fn new(max_iterations: usize, tolerance: f64) -> Self {
Self {
max_iterations,
tolerance,
}
}
/// Run parallel max-product.
pub fn run_parallel(&self, graph: &FactorGraph) -> Result<HashMap<String, ArrayD<f64>>> {
// Similar to ParallelSumProduct but using max instead of sum
// Implementation follows the same pattern with max operations
let parallel_sp = ParallelSumProduct::new(self.max_iterations, self.tolerance, 0.0);
// For now, delegate to sum-product (in a full implementation, replace sum with max)
parallel_sp.run_parallel(graph)
}
}
#[cfg(test)]
mod tests {
use super::*;
use scirs2_core::ndarray::Array;
fn create_simple_chain() -> FactorGraph {
let mut graph = FactorGraph::new();
graph.add_variable_with_card("X".to_string(), "Domain".to_string(), 2);
graph.add_variable_with_card("Y".to_string(), "Domain".to_string(), 2);
let f_xy = Factor::new(
"f_xy".to_string(),
vec!["X".to_string(), "Y".to_string()],
Array::from_shape_vec(vec![2, 2], vec![0.1, 0.2, 0.3, 0.4])
.expect("unwrap")
.into_dyn(),
)
.expect("unwrap");
graph.add_factor(f_xy).expect("unwrap");
graph
}
#[test]
fn test_parallel_sum_product() {
let graph = create_simple_chain();
let parallel_bp = ParallelSumProduct::default();
let marginals = parallel_bp.run_parallel(&graph).expect("unwrap");
assert_eq!(marginals.len(), 2);
// Check normalization
for marginal in marginals.values() {
let sum: f64 = marginal.iter().sum();
assert!((sum - 1.0).abs() < 1e-6, "Marginal sum: {}", sum);
}
}
#[test]
fn test_parallel_with_damping() {
let graph = create_simple_chain();
let parallel_bp = ParallelSumProduct::new(100, 1e-6, 0.5);
let marginals = parallel_bp.run_parallel(&graph).expect("unwrap");
assert_eq!(marginals.len(), 2);
}
#[test]
fn test_parallel_max_product() {
let graph = create_simple_chain();
let parallel_mp = ParallelMaxProduct::default();
let marginals = parallel_mp.run_parallel(&graph).expect("unwrap");
assert_eq!(marginals.len(), 2);
}
}