1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
//! Update-schedule implementations for Loopy BP: synchronous, sequential,
//! and residual (priority-queue) schedules.
use std::collections::{BinaryHeap, HashMap};
use crate::error::Result;
use crate::graph::FactorGraph;
use super::engine::{LogMessageStore, LoopyBeliefPropagation};
use super::types::{LbpConvergenceMonitor, LbpIterStats, LogMessage, MessageDirection};
impl LoopyBeliefPropagation {
// ── Synchronous schedule ─────────────────────────────────────────────────
pub(super) fn run_synchronous(
&self,
graph: &FactorGraph,
messages: &mut LogMessageStore,
monitor: &mut LbpConvergenceMonitor,
) -> Result<()> {
for iteration in 0..self.config.max_iterations {
// Compute all new messages from the *current* (old) messages.
let mut new_vtf: HashMap<(String, String), LogMessage> = HashMap::new();
let mut new_ftv: HashMap<(String, String), LogMessage> = HashMap::new();
// Variable → Factor messages.
for var_name in graph.variable_names() {
if let Some(fac_ids) = graph.get_adjacent_factors(var_name) {
for fac_id in fac_ids {
let new_msg =
self.compute_vtf_message(graph, messages, var_name, fac_id)?;
new_vtf.insert((var_name.clone(), fac_id.clone()), new_msg);
}
}
}
// Factor → Variable messages.
for fac_id in graph.factor_ids() {
if let Some(vars) = graph.get_adjacent_variables(fac_id) {
for var_name in vars {
let new_msg =
self.compute_ftv_message(graph, messages, fac_id, var_name)?;
new_ftv.insert((fac_id.clone(), var_name.clone()), new_msg);
}
}
}
// Compute residuals and apply damping.
let stats = self.apply_updates_and_track(messages, new_vtf, new_ftv, iteration);
monitor.record(stats, self.config.tolerance);
if monitor.is_converged() {
break;
}
}
Ok(())
}
// ── Sequential schedule ───────────────────────────────────────────────────
pub(super) fn run_sequential(
&self,
graph: &FactorGraph,
messages: &mut LogMessageStore,
monitor: &mut LbpConvergenceMonitor,
) -> Result<()> {
// Build a deterministic ordering of all (directed) messages.
let mut all_pairs: Vec<(MessageDirection, String, String)> = Vec::new();
for var_name in graph.variable_names() {
if let Some(fac_ids) = graph.get_adjacent_factors(var_name) {
for fac_id in fac_ids {
all_pairs.push((MessageDirection::VtoF, var_name.clone(), fac_id.clone()));
all_pairs.push((MessageDirection::FtoV, fac_id.clone(), var_name.clone()));
}
}
}
for iteration in 0..self.config.max_iterations {
let mut max_residual = 0.0_f64;
let mut sum_residual = 0.0_f64;
let mut active = 0usize;
for (dir, a, b) in &all_pairs {
match dir {
MessageDirection::VtoF => {
let new_msg = self.compute_vtf_message(graph, messages, a, b)?;
let old = messages.get_vtf(a, b).cloned();
let residual = old
.as_ref()
.map(|o| new_msg.residual_linf(o))
.unwrap_or(1.0);
let lambda = self.config.damping.effective_lambda(residual);
let final_msg = if let Some(o) = &old {
new_msg.damp(o, lambda)
} else {
new_msg
};
max_residual = max_residual.max(residual);
sum_residual += residual;
if residual >= self.config.tolerance {
active += 1;
}
messages.set_vtf(a.clone(), b.clone(), final_msg);
}
MessageDirection::FtoV => {
let new_msg = self.compute_ftv_message(graph, messages, a, b)?;
let old = messages.get_ftv(a, b).cloned();
let residual = old
.as_ref()
.map(|o| new_msg.residual_linf(o))
.unwrap_or(1.0);
let lambda = self.config.damping.effective_lambda(residual);
let final_msg = if let Some(o) = &old {
new_msg.damp(o, lambda)
} else {
new_msg
};
max_residual = max_residual.max(residual);
sum_residual += residual;
if residual >= self.config.tolerance {
active += 1;
}
messages.set_ftv(a.clone(), b.clone(), final_msg);
}
}
}
let mean_residual = if all_pairs.is_empty() {
0.0
} else {
sum_residual / all_pairs.len() as f64
};
let stats = LbpIterStats {
iteration,
max_residual,
mean_residual,
active_messages: active,
};
monitor.record(stats, self.config.tolerance);
if monitor.is_converged() {
break;
}
}
Ok(())
}
// ── Residual BP schedule ─────────────────────────────────────────────────
pub(super) fn run_residual(
&self,
graph: &FactorGraph,
messages: &mut LogMessageStore,
monitor: &mut LbpConvergenceMonitor,
) -> Result<()> {
// Use a max-heap keyed by residual. We use ordered floats via a wrapper.
#[derive(PartialEq)]
struct PQEntry {
residual: f64,
dir: MessageDirection,
from: String,
to: String,
}
impl Eq for PQEntry {}
impl PartialOrd for PQEntry {
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
Some(self.cmp(other))
}
}
impl Ord for PQEntry {
fn cmp(&self, other: &Self) -> std::cmp::Ordering {
self.residual
.partial_cmp(&other.residual)
.unwrap_or(std::cmp::Ordering::Equal)
.then_with(|| self.from.cmp(&other.from))
.then_with(|| self.to.cmp(&other.to))
}
}
// Initialise heap with all messages at residual 1.0.
let mut heap: BinaryHeap<PQEntry> = BinaryHeap::new();
for var_name in graph.variable_names() {
if let Some(fac_ids) = graph.get_adjacent_factors(var_name) {
for fac_id in fac_ids {
heap.push(PQEntry {
residual: 1.0,
dir: MessageDirection::VtoF,
from: var_name.clone(),
to: fac_id.clone(),
});
heap.push(PQEntry {
residual: 1.0,
dir: MessageDirection::FtoV,
from: fac_id.clone(),
to: var_name.clone(),
});
}
}
}
let total_messages = heap.len().max(1);
let mut global_iter = 0usize;
let mut steps_since_report = 0usize;
let mut max_residual = 1.0_f64;
let mut sum_residual = 0.0_f64;
let mut active = total_messages;
// Total budget in "message updates" mapped to sweeps.
let budget = self.config.max_iterations * total_messages;
let mut steps = 0usize;
while let Some(entry) = heap.pop() {
if steps >= budget {
break;
}
steps += 1;
steps_since_report += 1;
let (residual, new_neighbors) = match entry.dir {
MessageDirection::VtoF => {
let new_msg =
self.compute_vtf_message(graph, messages, &entry.from, &entry.to)?;
let old = messages.get_vtf(&entry.from, &entry.to).cloned();
let residual = old
.as_ref()
.map(|o| new_msg.residual_linf(o))
.unwrap_or(1.0);
let lambda = self.config.damping.effective_lambda(residual);
let final_msg = if let Some(o) = &old {
new_msg.damp(o, lambda)
} else {
new_msg
};
messages.set_vtf(entry.from.clone(), entry.to.clone(), final_msg);
// Neighbours to re-schedule: factor→var messages from entry.to.
let neighbors = graph
.get_adjacent_variables(&entry.to)
.cloned()
.unwrap_or_default();
(
residual,
neighbors
.into_iter()
.map(|v| (entry.to.clone(), v))
.collect::<Vec<_>>(),
)
}
MessageDirection::FtoV => {
let new_msg =
self.compute_ftv_message(graph, messages, &entry.from, &entry.to)?;
let old = messages.get_ftv(&entry.from, &entry.to).cloned();
let residual = old
.as_ref()
.map(|o| new_msg.residual_linf(o))
.unwrap_or(1.0);
let lambda = self.config.damping.effective_lambda(residual);
let final_msg = if let Some(o) = &old {
new_msg.damp(o, lambda)
} else {
new_msg
};
messages.set_ftv(entry.from.clone(), entry.to.clone(), final_msg);
// Neighbours to re-schedule: var→factor messages from entry.to.
let neighbors = graph
.get_adjacent_factors(&entry.to)
.cloned()
.unwrap_or_default();
(
residual,
neighbors
.into_iter()
.map(|f| (entry.to.clone(), f))
.collect::<Vec<_>>(),
)
}
};
// Re-add affected messages to the priority queue.
for (from, to) in new_neighbors {
// Compute prospective residual (from→to, FtoV direction since
// after a FtoV update, we perturb VtoF).
let dir = match entry.dir {
MessageDirection::VtoF => MessageDirection::FtoV,
MessageDirection::FtoV => MessageDirection::VtoF,
};
heap.push(PQEntry {
residual,
dir,
from,
to,
});
}
// Emit convergence statistics every `total_messages` steps.
if steps_since_report >= total_messages || heap.is_empty() {
steps_since_report = 0;
let stats = LbpIterStats {
iteration: global_iter,
max_residual,
mean_residual: sum_residual / total_messages as f64,
active_messages: active,
};
monitor.record(stats, self.config.tolerance);
global_iter += 1;
max_residual = 0.0;
sum_residual = 0.0;
active = 0;
if monitor.is_converged() {
break;
}
} else {
max_residual = max_residual.max(residual);
sum_residual += residual;
if residual >= self.config.tolerance {
active += 1;
}
}
}
Ok(())
}
}