tenflowers-dataset 0.1.1

Data pipeline and dataset utilities for TenfloweRS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
//! Data quality metrics and drift detection
//!
//! This module provides comprehensive data quality assessment including:
//! - Statistical quality metrics (completeness, validity, consistency)
//! - Data drift detection (distribution shift, concept drift)
//! - Outlier detection and anomaly analysis
//! - Data profiling and summary statistics

use crate::Dataset;
use std::collections::HashMap;
use tenflowers_core::{Result, Tensor, TensorError};

/// Comprehensive data quality metrics
#[derive(Debug, Clone)]
pub struct DataQualityMetrics {
    /// Dataset name or identifier
    pub dataset_name: String,
    /// Total number of samples
    pub total_samples: usize,
    /// Completeness metrics (percentage of non-null values)
    pub completeness: HashMap<String, f64>,
    /// Validity metrics (percentage of values passing validation rules)
    pub validity: HashMap<String, f64>,
    /// Consistency metrics (internal consistency checks)
    pub consistency_score: f64,
    /// Timeliness (data freshness indicators)
    pub timeliness_score: Option<f64>,
    /// Accuracy estimates
    pub accuracy_estimates: HashMap<String, f64>,
    /// Uniqueness metrics (duplicate detection)
    pub uniqueness_score: f64,
    /// Overall quality score (0.0 to 1.0)
    pub overall_quality_score: f64,
    /// Detected issues
    pub issues: Vec<DataQualityIssue>,
}

/// Data quality issue description
#[derive(Debug, Clone)]
pub struct DataQualityIssue {
    /// Issue severity
    pub severity: IssueSeverity,
    /// Issue category
    pub category: IssueCategory,
    /// Description of the issue
    pub description: String,
    /// Affected fields/columns
    pub affected_fields: Vec<String>,
    /// Number of affected samples
    pub affected_count: usize,
    /// Suggested remediation
    pub remediation: Option<String>,
}

/// Issue severity levels
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum IssueSeverity {
    /// Critical issue requiring immediate attention
    Critical,
    /// High priority issue
    High,
    /// Medium priority issue
    Medium,
    /// Low priority issue
    Low,
    /// Informational only
    Info,
}

/// Issue categories
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum IssueCategory {
    /// Missing data issues
    Completeness,
    /// Invalid values
    Validity,
    /// Inconsistent data
    Consistency,
    /// Duplicate data
    Uniqueness,
    /// Accuracy issues
    Accuracy,
    /// Timeliness issues
    Timeliness,
    /// Statistical anomalies
    StatisticalAnomaly,
}

/// Data drift detection configuration
#[derive(Debug, Clone)]
pub struct DriftDetectionConfig {
    /// Reference dataset size (for baseline)
    pub reference_window_size: usize,
    /// Detection threshold (0.0 to 1.0)
    pub detection_threshold: f64,
    /// Statistical test to use
    pub statistical_test: StatisticalTest,
    /// Minimum number of samples for detection
    pub min_samples: usize,
    /// Enable distribution visualization
    pub enable_visualization: bool,
}

impl Default for DriftDetectionConfig {
    fn default() -> Self {
        Self {
            reference_window_size: 1000,
            detection_threshold: 0.05, // 5% significance level
            statistical_test: StatisticalTest::KolmogorovSmirnov,
            min_samples: 100,
            enable_visualization: false,
        }
    }
}

/// Statistical tests for drift detection
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum StatisticalTest {
    /// Kolmogorov-Smirnov test
    KolmogorovSmirnov,
    /// Chi-squared test
    ChiSquared,
    /// Population Stability Index (PSI)
    PopulationStabilityIndex,
    /// Kullback-Leibler divergence
    KullbackLeibler,
    /// Jensen-Shannon divergence
    JensenShannon,
}

/// Data drift detection result
#[derive(Debug, Clone)]
pub struct DriftDetectionResult {
    /// Whether drift was detected
    pub drift_detected: bool,
    /// Drift score (higher means more drift)
    pub drift_score: f64,
    /// Statistical test p-value (if applicable)
    pub p_value: Option<f64>,
    /// Distribution distance metric
    pub distance_metric: f64,
    /// Drift type
    pub drift_type: DriftType,
    /// Detailed analysis
    pub analysis: String,
    /// Affected features
    pub affected_features: Vec<String>,
}

/// Types of detected drift
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum DriftType {
    /// No drift detected
    NoDrift,
    /// Covariate shift (feature distribution change)
    CovariateShift,
    /// Concept drift (relationship change)
    ConceptDrift,
    /// Label drift (target distribution change)
    LabelDrift,
    /// Combined drift
    CombinedDrift,
}

/// Data quality analyzer
pub struct DataQualityAnalyzer {
    /// Configuration for quality checks
    config: QualityAnalysisConfig,
}

/// Configuration for quality analysis
#[derive(Debug, Clone)]
pub struct QualityAnalysisConfig {
    /// Check for missing values
    pub check_completeness: bool,
    /// Check for invalid values
    pub check_validity: bool,
    /// Check for duplicates
    pub check_duplicates: bool,
    /// Check for outliers
    pub check_outliers: bool,
    /// Outlier detection method
    pub outlier_method: OutlierDetectionMethod,
    /// Outlier threshold (e.g., number of standard deviations)
    pub outlier_threshold: f64,
    /// Maximum number of unique values to track
    pub max_unique_values: usize,
}

impl Default for QualityAnalysisConfig {
    fn default() -> Self {
        Self {
            check_completeness: true,
            check_validity: true,
            check_duplicates: true,
            check_outliers: true,
            outlier_method: OutlierDetectionMethod::IQR,
            outlier_threshold: 1.5,
            max_unique_values: 10000,
        }
    }
}

/// Outlier detection methods
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum OutlierDetectionMethod {
    /// Interquartile Range (IQR) method
    IQR,
    /// Z-score method
    ZScore,
    /// Modified Z-score method
    ModifiedZScore,
    /// Isolation Forest
    IsolationForest,
}

impl DataQualityAnalyzer {
    /// Create a new data quality analyzer
    pub fn new(config: QualityAnalysisConfig) -> Self {
        Self { config }
    }

    /// Create with default configuration
    pub fn default() -> Self {
        Self::new(QualityAnalysisConfig::default())
    }

    /// Analyze data quality for a dataset
    pub fn analyze<T>(
        &self,
        dataset: &dyn Dataset<T>,
        dataset_name: impl Into<String>,
    ) -> Result<DataQualityMetrics>
    where
        T: Clone
            + Default
            + scirs2_core::numeric::Zero
            + scirs2_core::numeric::Float
            + Send
            + Sync
            + 'static,
    {
        let dataset_name = dataset_name.into();
        let total_samples = dataset.len();

        if total_samples == 0 {
            return Ok(DataQualityMetrics {
                dataset_name,
                total_samples: 0,
                completeness: HashMap::new(),
                validity: HashMap::new(),
                consistency_score: 0.0,
                timeliness_score: None,
                accuracy_estimates: HashMap::new(),
                uniqueness_score: 0.0,
                overall_quality_score: 0.0,
                issues: vec![DataQualityIssue {
                    severity: IssueSeverity::Critical,
                    category: IssueCategory::Completeness,
                    description: "Dataset is empty".to_string(),
                    affected_fields: vec![],
                    affected_count: 0,
                    remediation: Some("Add data to the dataset".to_string()),
                }],
            });
        }

        let mut metrics = DataQualityMetrics {
            dataset_name,
            total_samples,
            completeness: HashMap::new(),
            validity: HashMap::new(),
            consistency_score: 1.0,
            timeliness_score: None,
            accuracy_estimates: HashMap::new(),
            uniqueness_score: 1.0,
            overall_quality_score: 0.0,
            issues: Vec::new(),
        };

        // Check completeness
        if self.config.check_completeness {
            self.check_completeness(dataset, &mut metrics)?;
        }

        // Check for duplicates
        if self.config.check_duplicates {
            self.check_duplicates(dataset, &mut metrics)?;
        }

        // Check for outliers
        if self.config.check_outliers {
            self.check_outliers(dataset, &mut metrics)?;
        }

        // Calculate overall quality score
        metrics.overall_quality_score = self.calculate_overall_score(&metrics);

        Ok(metrics)
    }

    fn check_completeness<T>(
        &self,
        dataset: &dyn Dataset<T>,
        metrics: &mut DataQualityMetrics,
    ) -> Result<()>
    where
        T: Clone + Default + scirs2_core::numeric::Zero + PartialEq + Send + Sync + 'static,
    {
        let mut non_zero_count = 0;

        for i in 0..dataset.len().min(1000) {
            // Sample up to 1000 items
            if let Ok((features, _)) = dataset.get(i) {
                if let Some(data) = features.as_slice() {
                    if data.iter().any(|x| *x != T::zero()) {
                        non_zero_count += 1;
                    }
                }
            }
        }

        let samples_checked = dataset.len().min(1000);
        let completeness_score = if samples_checked > 0 {
            non_zero_count as f64 / samples_checked as f64
        } else {
            0.0
        };

        metrics
            .completeness
            .insert("features".to_string(), completeness_score);

        if completeness_score < 0.9 {
            metrics.issues.push(DataQualityIssue {
                severity: if completeness_score < 0.5 {
                    IssueSeverity::High
                } else {
                    IssueSeverity::Medium
                },
                category: IssueCategory::Completeness,
                description: format!("Low completeness score: {:.2}%", completeness_score * 100.0),
                affected_fields: vec!["features".to_string()],
                affected_count: ((1.0 - completeness_score) * samples_checked as f64) as usize,
                remediation: Some(
                    "Investigate missing data and apply imputation if appropriate".to_string(),
                ),
            });
        }

        Ok(())
    }

    fn check_duplicates<T>(
        &self,
        dataset: &dyn Dataset<T>,
        metrics: &mut DataQualityMetrics,
    ) -> Result<()>
    where
        T: Clone
            + Default
            + scirs2_core::numeric::Zero
            + scirs2_core::numeric::Float
            + Send
            + Sync
            + 'static,
    {
        use std::collections::HashSet;

        // Check for duplicate samples using approximate comparison for floats
        let samples_to_check = dataset.len().min(1000);
        let mut seen_samples: HashSet<String> = HashSet::new();
        let mut duplicate_count = 0usize;

        for i in 0..samples_to_check {
            if let Ok((features, _labels)) = dataset.get(i) {
                // Create a fingerprint from the tensor values
                if let Some(data_slice) = features.as_slice() {
                    // Create a deterministic string representation
                    // For floats, we round to a fixed precision to avoid precision issues
                    let fingerprint: String = data_slice
                        .iter()
                        .map(|v| {
                            let f = v.to_f64().unwrap_or(0.0);
                            format!("{:.6}", f) // 6 decimal places for fingerprinting
                        })
                        .collect::<Vec<_>>()
                        .join(",");

                    if !seen_samples.insert(fingerprint) {
                        duplicate_count += 1;
                    }
                }
            }
        }

        // Calculate uniqueness score: (unique samples) / (total samples checked)
        let unique_count = samples_to_check - duplicate_count;
        metrics.uniqueness_score = if samples_to_check > 0 {
            unique_count as f64 / samples_to_check as f64
        } else {
            1.0
        };

        Ok(())
    }

    fn check_outliers<T>(
        &self,
        dataset: &dyn Dataset<T>,
        metrics: &mut DataQualityMetrics,
    ) -> Result<()>
    where
        T: Clone
            + Default
            + scirs2_core::numeric::Zero
            + scirs2_core::numeric::Float
            + Send
            + Sync
            + 'static,
    {
        let mut values: Vec<f64> = Vec::new();

        // Collect values for outlier analysis
        for i in 0..dataset.len().min(1000) {
            if let Ok((features, _)) = dataset.get(i) {
                if let Some(data) = features.as_slice() {
                    for &val in data {
                        values.push(val.to_f64().unwrap_or(0.0));
                    }
                }
            }
        }

        if values.is_empty() {
            return Ok(());
        }

        // Calculate statistics
        let outlier_count = match self.config.outlier_method {
            OutlierDetectionMethod::IQR => self.detect_outliers_iqr(&values),
            OutlierDetectionMethod::ZScore => self.detect_outliers_zscore(&values),
            _ => 0,
        };

        if outlier_count > 0 {
            let outlier_percentage = outlier_count as f64 / values.len() as f64;
            if outlier_percentage > 0.05 {
                // More than 5% outliers
                metrics.issues.push(DataQualityIssue {
                    severity: IssueSeverity::Medium,
                    category: IssueCategory::StatisticalAnomaly,
                    description: format!(
                        "High percentage of outliers detected: {:.2}%",
                        outlier_percentage * 100.0
                    ),
                    affected_fields: vec!["features".to_string()],
                    affected_count: outlier_count,
                    remediation: Some(
                        "Review outlier values and consider outlier removal or transformation"
                            .to_string(),
                    ),
                });
            }
        }

        Ok(())
    }

    fn detect_outliers_iqr(&self, values: &[f64]) -> usize {
        if values.len() < 4 {
            return 0;
        }

        let mut sorted = values.to_vec();
        sorted.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));

        let q1_idx = sorted.len() / 4;
        let q3_idx = (3 * sorted.len()) / 4;
        let q1 = sorted[q1_idx];
        let q3 = sorted[q3_idx];
        let iqr = q3 - q1;

        let lower_bound = q1 - self.config.outlier_threshold * iqr;
        let upper_bound = q3 + self.config.outlier_threshold * iqr;

        values
            .iter()
            .filter(|&&v| v < lower_bound || v > upper_bound)
            .count()
    }

    fn detect_outliers_zscore(&self, values: &[f64]) -> usize {
        if values.is_empty() {
            return 0;
        }

        let mean = values.iter().sum::<f64>() / values.len() as f64;
        let variance =
            values.iter().map(|&v| (v - mean).powi(2)).sum::<f64>() / values.len() as f64;
        let std_dev = variance.sqrt();

        if std_dev == 0.0 {
            return 0;
        }

        values
            .iter()
            .filter(|&&v| ((v - mean) / std_dev).abs() > self.config.outlier_threshold)
            .count()
    }

    fn calculate_overall_score(&self, metrics: &DataQualityMetrics) -> f64 {
        let mut scores = Vec::new();

        // Completeness score
        if let Some(&completeness) = metrics.completeness.get("features") {
            scores.push(completeness);
        }

        // Uniqueness score
        scores.push(metrics.uniqueness_score);

        // Consistency score
        scores.push(metrics.consistency_score);

        // Reduce score based on issues
        let issue_penalty = metrics.issues.iter().fold(0.0, |acc, issue| {
            acc + match issue.severity {
                IssueSeverity::Critical => 0.3,
                IssueSeverity::High => 0.2,
                IssueSeverity::Medium => 0.1,
                IssueSeverity::Low => 0.05,
                IssueSeverity::Info => 0.0,
            }
        });

        let base_score = if scores.is_empty() {
            0.0
        } else {
            scores.iter().sum::<f64>() / scores.len() as f64
        };

        (base_score - issue_penalty).clamp(0.0, 1.0)
    }

    /// Generate a human-readable quality report
    pub fn generate_report(&self, metrics: &DataQualityMetrics) -> String {
        let mut report = format!(
            "Data Quality Report: {}\n\
             ================================\n\
             Total Samples: {}\n\
             Overall Quality Score: {:.2}%\n\n",
            metrics.dataset_name,
            metrics.total_samples,
            metrics.overall_quality_score * 100.0
        );

        // Completeness
        if !metrics.completeness.is_empty() {
            report.push_str("Completeness:\n");
            for (field, score) in &metrics.completeness {
                report.push_str(&format!("  {}: {:.2}%\n", field, score * 100.0));
            }
            report.push('\n');
        }

        // Uniqueness
        report.push_str(&format!(
            "Uniqueness Score: {:.2}%\n\n",
            metrics.uniqueness_score * 100.0
        ));

        // Issues
        if !metrics.issues.is_empty() {
            report.push_str(&format!("Detected Issues ({}):\n", metrics.issues.len()));
            for (i, issue) in metrics.issues.iter().enumerate() {
                report.push_str(&format!(
                    "  {}. [{:?}] [{:?}] {}\n",
                    i + 1,
                    issue.severity,
                    issue.category,
                    issue.description
                ));
                if !issue.affected_fields.is_empty() {
                    report.push_str(&format!(
                        "     Affected fields: {}\n",
                        issue.affected_fields.join(", ")
                    ));
                }
                if let Some(remediation) = &issue.remediation {
                    report.push_str(&format!("     Remediation: {}\n", remediation));
                }
            }
        } else {
            report.push_str("No issues detected.\n");
        }

        report
    }
}

/// Extension trait to add quality analysis to any dataset
pub trait DataQualityExt<T>: Dataset<T> + Sized {
    /// Analyze data quality
    fn analyze_quality(&self, name: impl Into<String>) -> Result<DataQualityMetrics>
    where
        T: Clone
            + Default
            + scirs2_core::numeric::Zero
            + scirs2_core::numeric::Float
            + Send
            + Sync
            + 'static,
    {
        let analyzer = DataQualityAnalyzer::default();
        analyzer.analyze(self, name)
    }

    /// Generate a quality report
    fn quality_report(&self, name: impl Into<String>) -> Result<String>
    where
        T: Clone
            + Default
            + scirs2_core::numeric::Zero
            + scirs2_core::numeric::Float
            + Send
            + Sync
            + 'static,
    {
        let metrics = self.analyze_quality(name)?;
        let analyzer = DataQualityAnalyzer::default();
        Ok(analyzer.generate_report(&metrics))
    }
}

// Blanket implementation for all datasets
impl<T, D: Dataset<T>> DataQualityExt<T> for D {}

// ──────────────────────────────────────────────────────────────────────────────
// Drift metrics: PSI, KS two-sample test, Jensen-Shannon divergence
// ──────────────────────────────────────────────────────────────────────────────

/// Drift analysis report combining multiple statistical measures.
#[derive(Debug, Clone)]
pub struct DriftReport {
    /// Population Stability Index (PSI). Values < 0.1 indicate stable, 0.1–0.2 moderate
    /// shift, > 0.2 significant shift.
    pub psi: f64,
    /// Kolmogorov-Smirnov two-sample test statistic (max |ECDF_a − ECDF_b|). Range [0, 1].
    pub ks_statistic: f64,
    /// Jensen-Shannon divergence (log base 2). Range [0, 1]; 0 = identical distributions.
    pub jsd: f64,
    /// `true` when PSI > 0.2 or KS > 0.1 — coarse flag for downstream alerting.
    pub is_significant_drift: bool,
}

/// Compute the Population Stability Index (PSI) between a reference and a current distribution.
///
/// Both slices are binned into `n_bins` equal-width bins spanning
/// `[min(all values), max(all values)]`.  Epsilon smoothing prevents log(0).
///
/// # Errors
/// Returns an error if either slice is empty or `n_bins == 0`.
pub fn population_stability_index(
    reference: &[f64],
    current: &[f64],
    n_bins: usize,
) -> Result<f64> {
    if reference.is_empty() {
        return Err(TensorError::invalid_argument(
            "reference slice is empty".to_string(),
        ));
    }
    if current.is_empty() {
        return Err(TensorError::invalid_argument(
            "current slice is empty".to_string(),
        ));
    }
    if n_bins == 0 {
        return Err(TensorError::invalid_argument(
            "n_bins must be > 0".to_string(),
        ));
    }

    let min_val = reference
        .iter()
        .chain(current.iter())
        .cloned()
        .fold(f64::INFINITY, f64::min);
    let max_val = reference
        .iter()
        .chain(current.iter())
        .cloned()
        .fold(f64::NEG_INFINITY, f64::max);

    if (max_val - min_val).abs() < f64::EPSILON {
        return Ok(0.0);
    }

    let bin_width = (max_val - min_val) / n_bins as f64;
    let epsilon = 1e-9_f64;

    let count_bins = |samples: &[f64]| -> Vec<f64> {
        let n = samples.len() as f64;
        let mut counts = vec![0_usize; n_bins];
        for &v in samples {
            let idx = ((v - min_val) / bin_width).floor() as usize;
            counts[idx.min(n_bins - 1)] += 1;
        }
        counts
            .into_iter()
            .map(|c| (c as f64 + epsilon) / (n + n_bins as f64 * epsilon))
            .collect()
    };

    let ref_pct = count_bins(reference);
    let cur_pct = count_bins(current);

    let psi = ref_pct
        .iter()
        .zip(cur_pct.iter())
        .map(|(&r, &c)| (c - r) * (c / r).ln())
        .sum::<f64>();

    Ok(psi)
}

/// Compute the Kolmogorov-Smirnov two-sample test statistic.
///
/// Returns `max |ECDF_a(x) − ECDF_b(x)|` over all observed values.
///
/// # Errors
/// Returns an error if either slice is empty.
pub fn ks_two_sample(sample_a: &[f64], sample_b: &[f64]) -> Result<f64> {
    if sample_a.is_empty() {
        return Err(TensorError::invalid_argument(
            "sample_a is empty".to_string(),
        ));
    }
    if sample_b.is_empty() {
        return Err(TensorError::invalid_argument(
            "sample_b is empty".to_string(),
        ));
    }

    let na = sample_a.len() as f64;
    let nb = sample_b.len() as f64;

    let mut sorted_a = sample_a.to_vec();
    let mut sorted_b = sample_b.to_vec();
    sorted_a.sort_by(|x, y| x.partial_cmp(y).unwrap_or(std::cmp::Ordering::Equal));
    sorted_b.sort_by(|x, y| x.partial_cmp(y).unwrap_or(std::cmp::Ordering::Equal));

    let mut ia = 0_usize;
    let mut ib = 0_usize;
    let mut max_diff = 0.0_f64;

    while ia < sorted_a.len() || ib < sorted_b.len() {
        let x = match (sorted_a.get(ia), sorted_b.get(ib)) {
            (Some(&a), Some(&b)) => a.min(b),
            (Some(&a), None) => a,
            (None, Some(&b)) => b,
            (None, None) => break,
        };

        while ia < sorted_a.len() && sorted_a[ia] <= x {
            ia += 1;
        }
        while ib < sorted_b.len() && sorted_b[ib] <= x {
            ib += 1;
        }

        let ecdf_a = ia as f64 / na;
        let ecdf_b = ib as f64 / nb;
        let diff = (ecdf_a - ecdf_b).abs();
        if diff > max_diff {
            max_diff = diff;
        }
    }

    Ok(max_diff)
}

/// Compute the Jensen-Shannon divergence (log base 2) between two distributions.
///
/// Both `p` and `q` are treated as un-normalised histograms; they are normalised
/// inside the function.  Returns a value in [0, 1] (0 = identical).
///
/// # Errors
/// Returns an error if either slice is empty or sums to zero, or if lengths differ.
pub fn jensen_shannon_divergence(p: &[f64], q: &[f64]) -> Result<f64> {
    if p.is_empty() || q.is_empty() {
        return Err(TensorError::invalid_argument(
            "p and q must be non-empty".to_string(),
        ));
    }
    if p.len() != q.len() {
        return Err(TensorError::invalid_argument(
            "p and q must have the same length".to_string(),
        ));
    }

    let sum_p: f64 = p.iter().sum();
    let sum_q: f64 = q.iter().sum();

    if sum_p <= 0.0 {
        return Err(TensorError::invalid_argument("p sums to zero".to_string()));
    }
    if sum_q <= 0.0 {
        return Err(TensorError::invalid_argument("q sums to zero".to_string()));
    }

    let norm_p: Vec<f64> = p.iter().map(|&v| v / sum_p).collect();
    let norm_q: Vec<f64> = q.iter().map(|&v| v / sum_q).collect();

    let m: Vec<f64> = norm_p
        .iter()
        .zip(norm_q.iter())
        .map(|(&pi, &qi)| (pi + qi) * 0.5)
        .collect();

    let kl_div = |dist: &[f64], mix: &[f64]| -> f64 {
        dist.iter()
            .zip(mix.iter())
            .filter(|(&pi, &mi)| pi > 0.0 && mi > 0.0)
            .map(|(&pi, &mi)| pi * (pi / mi).log2())
            .sum::<f64>()
    };

    let jsd = 0.5 * kl_div(&norm_p, &m) + 0.5 * kl_div(&norm_q, &m);
    Ok(jsd.clamp(0.0, 1.0))
}

/// Run PSI, KS, and JSD on a pair of 1-D sample arrays and return a combined `DriftReport`.
///
/// Drift is flagged as significant when PSI > 0.2 or KS > 0.1.
///
/// # Errors
/// Propagates errors from the underlying statistical functions.
pub fn compute_drift(reference: &[f64], current: &[f64]) -> Result<DriftReport> {
    let psi = population_stability_index(reference, current, 20)?;
    let ks_statistic = ks_two_sample(reference, current)?;

    let n_bins = 20_usize;
    let min_val = reference
        .iter()
        .chain(current.iter())
        .cloned()
        .fold(f64::INFINITY, f64::min);
    let max_val = reference
        .iter()
        .chain(current.iter())
        .cloned()
        .fold(f64::NEG_INFINITY, f64::max);

    let jsd = if (max_val - min_val).abs() < f64::EPSILON {
        0.0
    } else {
        let bin_width = (max_val - min_val) / n_bins as f64;
        let mut hist_ref = vec![0_f64; n_bins];
        let mut hist_cur = vec![0_f64; n_bins];

        for &v in reference {
            let idx = ((v - min_val) / bin_width).floor() as usize;
            hist_ref[idx.min(n_bins - 1)] += 1.0;
        }
        for &v in current {
            let idx = ((v - min_val) / bin_width).floor() as usize;
            hist_cur[idx.min(n_bins - 1)] += 1.0;
        }

        jensen_shannon_divergence(&hist_ref, &hist_cur)?
    };

    let is_significant_drift = psi > 0.2 || ks_statistic > 0.1;

    Ok(DriftReport {
        psi,
        ks_statistic,
        jsd,
        is_significant_drift,
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::TensorDataset;
    use tenflowers_core::Tensor;

    #[test]
    fn test_quality_analyzer_creation() {
        let analyzer = DataQualityAnalyzer::default();
        assert!(analyzer.config.check_completeness);
        assert!(analyzer.config.check_validity);
    }

    #[test]
    fn test_empty_dataset_quality() {
        let features =
            Tensor::<f32>::from_vec(vec![], &[0, 1]).expect("test: tensor creation should succeed");
        let labels =
            Tensor::<f32>::from_vec(vec![], &[0]).expect("test: tensor creation should succeed");
        let dataset = TensorDataset::new(features, labels);

        let analyzer = DataQualityAnalyzer::default();
        let metrics = analyzer
            .analyze(&dataset, "test_dataset")
            .expect("test: operation should succeed");

        assert_eq!(metrics.total_samples, 0);
        assert_eq!(metrics.overall_quality_score, 0.0);
        assert!(!metrics.issues.is_empty());
    }

    #[test]
    fn test_quality_extension_trait() {
        let features = Tensor::<f32>::from_vec(vec![1.0, 2.0, 3.0, 4.0], &[2, 2])
            .expect("test: tensor creation should succeed");
        let labels = Tensor::<f32>::from_vec(vec![0.0, 1.0], &[2])
            .expect("test: tensor creation should succeed");
        let dataset = TensorDataset::new(features, labels);

        let metrics = dataset
            .analyze_quality("test_dataset")
            .expect("test: operation should succeed");
        assert_eq!(metrics.total_samples, 2);
        assert!(metrics.overall_quality_score > 0.0);
    }

    #[test]
    fn test_outlier_detection_iqr() {
        let config = QualityAnalysisConfig::default();
        let analyzer = DataQualityAnalyzer::new(config);

        let values = vec![1.0, 2.0, 3.0, 4.0, 5.0, 100.0]; // 100.0 is an outlier
        let outlier_count = analyzer.detect_outliers_iqr(&values);

        assert!(outlier_count > 0);
    }

    #[test]
    fn test_drift_detection_config() {
        let config = DriftDetectionConfig::default();
        assert_eq!(config.reference_window_size, 1000);
        assert_eq!(config.detection_threshold, 0.05);
        assert_eq!(config.statistical_test, StatisticalTest::KolmogorovSmirnov);
    }

    #[test]
    fn test_psi_identical_distributions_is_zero() {
        let data: Vec<f64> = (0..100).map(|i| i as f64).collect();
        let psi =
            population_stability_index(&data, &data, 10).expect("PSI should compute without error");
        assert!(
            psi < 1e-6,
            "PSI of identical distributions should be < 1e-6, got {}",
            psi
        );
    }

    #[test]
    fn test_ks_identical_sorted_is_zero() {
        let data: Vec<f64> = (0..50).map(|i| i as f64).collect();
        let ks = ks_two_sample(&data, &data).expect("KS statistic should compute without error");
        assert!(
            ks < 1e-10,
            "KS of identical distributions should be 0, got {}",
            ks
        );
    }

    #[test]
    fn test_jsd_identical_is_zero() {
        let data: Vec<f64> = vec![0.1, 0.2, 0.3, 0.2, 0.1, 0.05, 0.05];
        let jsd =
            jensen_shannon_divergence(&data, &data).expect("JSD should compute without error");
        assert!(
            jsd < 1e-10,
            "JSD of identical distributions should be 0, got {}",
            jsd
        );
    }

    #[test]
    fn test_psi_shifted_distribution_positive() {
        let reference: Vec<f64> = (0..100).map(|i| i as f64 * 0.1).collect();
        let current: Vec<f64> = (0..100).map(|i| 50.0 + i as f64 * 0.1).collect();
        let psi = population_stability_index(&reference, &current, 10)
            .expect("PSI should compute without error");
        assert!(
            psi > 0.1,
            "PSI of shifted distributions should be > 0.1, got {}",
            psi
        );
    }
}