tempest-kv 0.0.2

Key-Value storage layer for TempestDB
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
use std::{cmp::Ordering, marker::PhantomData};

use bytes::{BufMut, Bytes, BytesMut};
use tempest_core::utils::ByteSize;
use zerocopy::{FromBytes, Immutable, IntoBytes, KnownLayout, LittleEndian, Ref, U32};

use crate::base::{Comparer, InternalKey, KeyKind, KeyTrailer};

#[derive(IntoBytes, FromBytes, KnownLayout, Immutable)]
#[repr(C)]
pub struct BlockEntryHeader {
    shared_key_len: U32<LittleEndian>,
    unshared_key_len: U32<LittleEndian>,
    value_len: U32<LittleEndian>,
}

#[derive(Debug, PartialEq, Eq)]
pub enum BlockBuilderStatus {
    Empty,
    Ok,
    Full,
}

#[derive(IntoBytes, FromBytes, KnownLayout, Immutable)]
#[repr(C)]
pub struct BlockFooter {
    restart_count: U32<LittleEndian>,
}

pub struct BlockBuilder {
    buf: BytesMut,
    entry_count: u32,
    last_key: BytesMut,
    restart_offsets: Vec<u32>,

    // config options
    target_size: usize,
    restart_interval: u32,
}

impl BlockBuilder {
    pub fn new(target_size: usize, restart_interval: u32) -> Self {
        Self {
            // NB: we multiply by 2 here, to ideally prevent reallocations, otherwise it end up
            // reallocating at least once when writing the footer in `finalize()`
            buf: BytesMut::with_capacity(target_size * 2),
            entry_count: 0,
            last_key: BytesMut::with_capacity(64),
            restart_offsets: Vec::new(),

            target_size,
            restart_interval,
        }
    }

    #[instrument(skip_all, level = "trace", fields(pos=self.buf.len(), entry_count=self.entry_count))]
    pub fn write_entry(
        &mut self,
        key: impl AsRef<[u8]>,
        trailer: KeyTrailer,
        value: impl AsRef<[u8]>,
    ) -> BlockBuilderStatus {
        let key = key.as_ref();
        let value = value.as_ref();
        trace!("writing entry");
        let restart_point_reached = self.entry_count % self.restart_interval == 0;
        if restart_point_reached {
            trace!("reached restart point");
            self.last_key.clear();
            self.restart_offsets.push(self.buf.len() as u32);
        }
        let shared_key_len = self.shared_key_len(key);

        let unshared_key_len = key.len() as u32 - shared_key_len;
        let value_len = value.len() as u32;

        let header = BlockEntryHeader {
            shared_key_len: shared_key_len.into(),
            unshared_key_len: unshared_key_len.into(),
            value_len: value_len.into(),
        };

        self.buf.put(header.as_bytes());
        self.buf.put(&key[shared_key_len as usize..]);
        self.buf.put(trailer.as_bytes());
        self.buf.put(value.as_ref());

        // store the bytes for shared prefix compression
        self.last_key.truncate(shared_key_len as usize);
        self.last_key
            .extend_from_slice(&key[shared_key_len as usize..]);
        self.entry_count += 1;

        self.get_status()
    }

    fn shared_key_len(&self, new_key: &[u8]) -> u32 {
        let mut pos = 0;
        let limit = self.last_key.len().min(new_key.len());
        while pos < limit {
            if self.last_key[pos] == new_key[pos] {
                pos += 1;
            } else {
                break;
            }
        }
        pos as u32
    }

    pub fn get_status(&self) -> BlockBuilderStatus {
        if self.buf.is_empty() {
            BlockBuilderStatus::Empty
        } else if self.buf.len() >= self.target_size {
            BlockBuilderStatus::Full
        } else {
            BlockBuilderStatus::Ok
        }
    }

    pub fn finalize(mut self) -> BytesMut {
        self.buf.put(self.restart_offsets.as_slice().as_bytes());
        let restart_count = self.restart_offsets.len() as u32;
        let footer = BlockFooter {
            restart_count: restart_count.into(),
        };
        self.buf.put(footer.as_bytes());
        self.buf
    }
}

fn parse_block(buf: &[u8]) -> (&[u8], &[U32<LittleEndian>]) {
    let footer_start = buf.len() - size_of::<BlockFooter>();
    let count = BlockFooter::read_from_bytes(&buf[footer_start..])
        .unwrap()
        .restart_count
        .get() as usize;
    let offsets_start = footer_start - count * size_of::<U32<LittleEndian>>();
    let entries = &buf[..offsets_start];
    let offsets = <[U32<LittleEndian>]>::ref_from_bytes(&buf[offsets_start..footer_start]).unwrap();
    (entries, offsets)
}

fn parse_offsets(buf: &[u8], entries_end: usize) -> &[U32<LittleEndian>] {
    let footer_start = buf.len() - size_of::<BlockFooter>();
    <[U32<LittleEndian>]>::ref_from_bytes(&buf[entries_end..footer_start]).unwrap()
}

pub struct BlockIterator<C: Comparer> {
    buf: Bytes,
    pos: usize,
    restart_count: usize,
    entries_end: usize,
    last_key: Vec<u8>,
    _marker: PhantomData<C>,
}

impl<C: Comparer> BlockIterator<C> {
    pub fn new(buf: Bytes) -> Self {
        let (entries, offsets) = parse_block(&buf);
        let restart_count = offsets.len();
        let entries_end = entries.len();
        Self {
            buf,
            pos: 0,
            restart_count,
            entries_end,
            last_key: Vec::new(),
            _marker: PhantomData,
        }
    }
}

impl<C: Comparer> Iterator for BlockIterator<C> {
    type Item = (InternalKey<C>, Bytes);

    fn next(&mut self) -> Option<Self::Item> {
        if self.pos >= self.entries_end {
            return None;
        }

        let entries = &self.buf[..self.entries_end];

        let (header, _) = Ref::<_, BlockEntryHeader>::from_prefix(&entries[self.pos..]).unwrap();
        let shared = header.shared_key_len.get() as usize;
        let unshared = header.unshared_key_len.get() as usize;
        let value_len = header.value_len.get() as usize;
        self.pos += size_of::<BlockEntryHeader>();

        // prefix decompress the user key
        self.last_key.truncate(shared);
        self.last_key
            .extend_from_slice(&entries[self.pos..self.pos + unshared]);
        self.pos += unshared;

        // read trailer
        let trailer_bytes: [u8; 8] = entries[self.pos..self.pos + size_of::<KeyTrailer>()]
            .try_into()
            .unwrap();
        let trailer =
            KeyTrailer::try_from(trailer_bytes).expect("invalid key trailer in CRC-verified block");
        self.pos += size_of::<KeyTrailer>();

        // zero-copy slice into the buffer for the value
        let value = self.buf.slice(self.pos..self.pos + value_len);
        self.pos += value_len;

        let key = InternalKey::new(Bytes::copy_from_slice(&self.last_key), trailer);
        Some((key, value))
    }
}

pub struct BlockReader<C: Comparer> {
    buf: Bytes,
    _marker: PhantomData<C>,
}

impl<C: Comparer> BlockReader<C> {
    pub fn new(buf: Bytes) -> Self {
        Self {
            buf,
            _marker: PhantomData,
        }
    }

    #[instrument(skip(self), level = "trace")]
    pub fn get(&self, search_key: &InternalKey<C, &[u8]>) -> Option<(KeyKind, Bytes)> {
        // parse the block into sections
        let (entries, offsets) = parse_block(&self.buf);
        trace!(
            entries_section_size = ?ByteSize(entries.len() as u64),
            offsets_count = offsets.len(),
            "parsed block"
        );

        // phase 1: binary search for the right restart interval
        let restart_key = |offset: usize| -> InternalKey<C, &[u8]> {
            let (header, rest) =
                Ref::<_, BlockEntryHeader>::from_prefix(&entries[offset..]).unwrap();
            // NB: for keys at restart points, we explicitly do not account for the shared part,
            // since restart keys will - by their nature - never have a shared prefix
            let unshared = header.unshared_key_len.get() as usize;
            let key = &rest[..unshared];
            let trailer_bytes: [u8; 8] = (&rest[unshared..unshared + size_of::<KeyTrailer>()])
                .try_into()
                .unwrap();
            let trailer = KeyTrailer::try_from(trailer_bytes)
                .expect("invalid key trailer in CRC-verified block");
            let key = InternalKey::new(key, trailer);
            trace!(offset, ?key, "parsed restart key");
            key
        };

        trace!("starting binary search");
        let start_i = match offsets.binary_search_by(|offset| {
            let restart_key = restart_key(offset.get() as usize);
            trace!("binary search: compare logical");
            let cmp = match restart_key.compare_logical(&search_key) {
                Ordering::Equal => {
                    trace!("binary search: logical equal, compare seqnum");
                    // NB: For binary search with trailer (seqnum->kind)
                    // tie break, the following rules apply:
                    // greater -> in range, find start, jump back => Greater
                    // equal -> top match, found start, return => Equal
                    // less -> out of range, continue, jump forward => Less
                    search_key.trailer().cmp(&restart_key.trailer())
                }
                other => other,
            };
            match cmp {
                Ordering::Less => trace!(?cmp, "binary search: jumping forth"),
                Ordering::Equal => trace!(?cmp, "binary search: found"),
                Ordering::Greater => trace!(?cmp, "binary search: jumping back"),
            }
            cmp
        }) {
            // if we found it, we start here (and will get it immediately)
            Ok(i) => i,
            // if we did not find it, start searching in the previous restart interval
            Err(i) => i.saturating_sub(1),
        };

        let start_offset = offsets[start_i].get() as usize;
        // NB: we would search the whole block, but break early if `found_key > search_key`.
        // This allows us to find keys where the seqnum is older than the search key, and that are
        // scattered across multiple restart intervals.
        let end_offset = entries.len();

        // phase 2: linearly search through this interval
        let mut pos = start_offset;
        let mut last_key: Vec<u8> = Vec::new();

        trace!("starting linear search");
        while pos < end_offset {
            let (header, _) = Ref::<_, BlockEntryHeader>::from_prefix(&entries[pos..]).unwrap();
            let shared = header.shared_key_len.get() as usize;
            let unshared = header.unshared_key_len.get() as usize;
            let value_len = header.value_len.get() as usize;
            pos += size_of::<BlockEntryHeader>();

            // prefix decompress the key
            last_key.truncate(shared);
            last_key.extend_from_slice(&entries[pos..pos + unshared]);
            pos += unshared;

            // read trailer
            let trailer_bytes: [u8; 8] = (&entries[pos..pos + size_of::<KeyTrailer>()])
                .try_into()
                .unwrap();
            let trailer = KeyTrailer::try_from(trailer_bytes)
                .expect("invalid key trailer in CRC-verified block");
            pos += size_of::<KeyTrailer>();

            // compare with the search key
            let current = InternalKey::<C, &[u8]>::new(&last_key, trailer);
            trace!(found=?current, ?search_key, "linear search: compare logical");
            match current.compare_logical(&search_key) {
                Ordering::Less => pos += value_len,
                Ordering::Equal => {
                    // only match if it is within MVCC range
                    if current.trailer().seqnum() <= search_key.trailer().seqnum() {
                        return Some((
                            current.trailer().kind(),
                            self.buf.slice(pos..pos + value_len),
                        ));
                    }
                    trace!(pos, "value too new, ignoring");
                    pos += value_len
                }
                Ordering::Greater => break,
            }
        }

        trace!("key not found during linear search");
        None
    }

    pub fn iter(&self) -> BlockIterator<C> {
        BlockIterator::new(self.buf.clone())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{
        base::{DefaultComparer, InternalKey, KeyKind, KeyTrailer, SeqNum},
        config::StorageConfig,
    };
    use bytes::Bytes;
    use tempest_core::test_utils::setup_tracing;

    fn make_trailer(seqnum: u64, kind: KeyKind) -> KeyTrailer {
        KeyTrailer::new(unsafe { SeqNum::new_unchecked(seqnum) }, kind)
    }

    fn make_key(s: &str, seqnum: u64) -> InternalKey<DefaultComparer, &[u8]> {
        InternalKey::new(s.as_ref(), make_trailer(seqnum, KeyKind::Put))
    }

    fn build_block<K: AsRef<[u8]>, V: AsRef<[u8]>>(entries: &[(K, u64, V)]) -> Bytes {
        let entries = entries
            .iter()
            .map(|(k, seqnum, v)| (k.as_ref(), *seqnum, v.as_ref()));
        let config = StorageConfig::for_testing().sst.write;
        let mut builder =
            BlockBuilder::new(config.block_target_size, config.block_restart_interval);
        for (key, seqnum, value) in entries {
            let trailer = make_trailer(seqnum, KeyKind::Put);
            builder.write_entry(key, trailer, value);
        }
        builder.finalize().freeze()
    }

    #[test]
    fn test_get_existing_key() {
        let buf = build_block(&[
            ("apple", 1, "fruit"),
            ("banana", 1, "yellow"),
            ("cherry", 1, "red"),
        ]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        let result = reader.get(&make_key("banana", 1));
        assert_eq!(result.unwrap().1, "yellow");
    }

    #[test]
    fn test_get_missing_key() {
        let buf = build_block(&[("apple", 1, "fruit"), ("cherry", 1, "red")]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert!(reader.get(&make_key("banana", 1)).is_none());
    }

    #[test]
    fn test_get_key_before_first() {
        let buf = build_block(&[("banana", 1, "yellow"), ("cherry", 1, "red")]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert!(reader.get(&make_key("apple", 1)).is_none());
    }

    #[test]
    fn test_get_key_after_last() {
        let buf = build_block(&[("apple", 1, "fruit"), ("banana", 1, "yellow")]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert!(reader.get(&make_key("cherry", 1)).is_none());
    }

    #[test]
    fn test_prefix_compression_across_restart_interval() {
        setup_tracing();

        // fill more than one restart interval to exercise prefix compression
        let mut entries: Vec<(String, u64, String)> = Vec::new();
        let restart_interval = StorageConfig::for_testing()
            .sst
            .write
            .block_restart_interval;
        let count = restart_interval + restart_interval / 2;
        info!(count, "filling block with entries");
        for i in 0..count {
            entries.push((format!("prefix:key:{:04}", i), 1, format!("value:{}", i)));
        }
        let entries_ref: Vec<(&str, u64, &str)> = entries
            .iter()
            .map(|(k, s, v)| (k.as_str(), *s, v.as_str()))
            .collect();

        let buf = build_block(&entries_ref);
        let reader = BlockReader::<DefaultComparer>::new(buf);

        // spot check a few entries across restart boundaries
        let spots = [
            0,                    // entry at start
            restart_interval / 2, // middle of interval
            restart_interval - 1, // entry right before restrt
            restart_interval,     // entry after restart
            count - 1,            // last entry
        ];
        info!(?spots, "checking a few entries within block");
        for i in spots {
            let key = format!("prefix:key:{:04}", i);
            let expected = format!("value:{}", i);
            let result = reader.get(&make_key(&key, 1));
            assert_eq!(result.unwrap().1, expected, "failed at index {}", i);
        }
    }

    #[test]
    fn test_restart_offsets_written_in_finalize() {
        // a block with exactly block_restart_interval + 1 entries should have 2 restart points
        let target_size = 4096;
        let restart_interval = 4;
        let mut builder = BlockBuilder::new(target_size, restart_interval);
        for i in 0..=restart_interval {
            let k = Bytes::copy_from_slice(format!("key:{:04}", i).as_bytes());
            let v = Bytes::from("v");
            builder.write_entry(&k, make_trailer(1, KeyKind::Put), &v);
        }
        let buf = builder.finalize().freeze();

        let (_, footer) = Ref::<_, BlockFooter>::from_suffix(buf.as_ref()).unwrap();
        assert_eq!(footer.restart_count.get(), 2);
    }

    #[test]
    fn test_get_first_and_last_entry() {
        let buf = build_block(&[
            ("aaa", 1, "first"),
            ("mmm", 1, "middle"),
            ("zzz", 1, "last"),
        ]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert_eq!(reader.get(&make_key("aaa", 1)).unwrap().1, "first");
        assert_eq!(reader.get(&make_key("zzz", 1)).unwrap().1, "last");
    }

    #[test]
    fn test_empty_value() {
        let buf = build_block(&[("key", 1, "")]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert_eq!(reader.get(&make_key("key", 1)).unwrap().1, "");
    }

    #[test]
    fn test_iterator_all_entries() {
        let buf = build_block(&[
            ("apple", 1, "fruit"),
            ("banana", 1, "yellow"),
            ("cherry", 1, "red"),
        ]);
        let iter = BlockIterator::<DefaultComparer>::new(buf);
        let results: Vec<_> = iter.map(|(k, v)| (k.key().clone(), v)).collect();

        assert_eq!(results[0], (Bytes::from("apple"), Bytes::from("fruit")));
        assert_eq!(results[1], (Bytes::from("banana"), Bytes::from("yellow")));
        assert_eq!(results[2], (Bytes::from("cherry"), Bytes::from("red")));
        assert_eq!(results.len(), 3);
    }

    #[test]
    fn test_iterator_prefix_compression() {
        // all keys share a long common prefix to stress prefix decompression
        let buf = build_block(&[
            ("tempest:key:0001", 1, "a"),
            ("tempest:key:0002", 1, "b"),
            ("tempest:key:0003", 1, "c"),
        ]);
        let iter = BlockIterator::<DefaultComparer>::new(buf);
        let keys: Vec<_> = iter.map(|(k, _)| k.key().clone()).collect();

        assert_eq!(keys[0], "tempest:key:0001");
        assert_eq!(keys[1], "tempest:key:0002");
        assert_eq!(keys[2], "tempest:key:0003");
    }

    #[test]
    fn test_iterator_across_restart_boundary() {
        let mut entries: Vec<(String, u64, String)> = Vec::new();
        for i in 0..40u32 {
            entries.push((format!("prefix:key:{:04}", i), 1, format!("val:{}", i)));
        }
        let buf = build_block(&entries);
        let results: Vec<_> = BlockIterator::<DefaultComparer>::new(buf)
            .map(|(k, v)| (k.key().clone(), v))
            .collect();

        assert_eq!(results.len(), 40);
        for i in 0..40usize {
            assert_eq!(
                results[i].0,
                Bytes::copy_from_slice(format!("prefix:key:{:04}", i).as_bytes())
            );
            assert_eq!(
                results[i].1,
                Bytes::copy_from_slice(format!("val:{}", i).as_bytes())
            );
        }
    }

    #[test]
    fn test_iterator_trailers_preserved() {
        let config = StorageConfig::for_testing().sst.write;
        let mut builder =
            BlockBuilder::new(config.block_target_size, config.block_restart_interval);
        let k = Bytes::from("key");
        let v = Bytes::from("val");
        let trailer = make_trailer(42, KeyKind::Put);
        builder.write_entry(&k, trailer, &v);
        let buf = builder.finalize().freeze();

        let mut iter = BlockIterator::<DefaultComparer>::new(buf);
        let (key, _) = iter.next().unwrap();
        assert_eq!(key.trailer().seqnum().get(), 42);
        assert_eq!(key.trailer().kind(), KeyKind::Put);
        assert!(iter.next().is_none());
    }

    #[test]
    fn test_iterator_empty_values() {
        let buf = build_block(&[("a", 1, ""), ("b", 1, ""), ("c", 1, "")]);
        let results: Vec<_> = BlockIterator::<DefaultComparer>::new(buf)
            .map(|(k, v)| (k.key().clone(), v))
            .collect();

        assert_eq!(results.len(), 3);
        for (_, v) in &results {
            assert_eq!(*v, Bytes::new());
        }
    }

    #[test]
    fn test_iterator_matches_get() {
        // every entry found by the iterator should also be found by get()
        let mut entries: Vec<(String, u64, String)> = Vec::new();
        for i in 0..20u32 {
            entries.push((format!("key:{:04}", i), 1, format!("val:{}", i)));
        }
        let entries_ref: Vec<(&str, u64, &str)> = entries
            .iter()
            .map(|(k, s, v)| (k.as_str(), *s, v.as_str()))
            .collect();

        let buf = build_block(&entries_ref);
        let reader = BlockReader::<DefaultComparer>::new(buf.clone());

        for (key, value) in BlockIterator::<DefaultComparer>::new(buf) {
            let found = reader.get(&key.slice_key());
            assert_eq!(found.unwrap().1, value);
        }
    }

    #[test]
    fn test_get_returns_newest_eligible_version() {
        setup_tracing();

        // three versions of "apple", newest first (as they'd be written to the SST)
        let buf = build_block(&[
            ("apple", 5, "v3"),
            ("apple", 3, "v2"),
            ("apple", 1, "v1"),
            ("banana", 2, "yellow"),
        ]);
        let reader = BlockReader::<DefaultComparer>::new(buf);

        // searching with seqnum=5 returns v3 (exact match)
        assert_eq!(reader.get(&make_key("apple", 5)).unwrap().1, "v3");
        // searching with seqnum=4 returns v2 (newest version <= 4)
        assert_eq!(reader.get(&make_key("apple", 4)).unwrap().1, "v2");
        // searching with seqnum=3 returns v2 (exact match)
        assert_eq!(reader.get(&make_key("apple", 3)).unwrap().1, "v2");
        // searching with seqnum=2 returns v1 (newest version <= 2)
        assert_eq!(reader.get(&make_key("apple", 2)).unwrap().1, "v1");
        // searching with seqnum=1 returns v1 (exact match)
        assert_eq!(reader.get(&make_key("apple", 1)).unwrap().1, "v1");
        // searching with seqnum=0 returns None (no version old enough)
        assert!(reader.get(&make_key("apple", 0)).is_none());

        // neighboring key is unaffected
        assert_eq!(reader.get(&make_key("banana", 2)).unwrap().1, "yellow");
    }

    #[test]
    fn test_get_snapshot_across_restart_boundary() {
        setup_tracing();

        // force versions of the same key to span a restart boundary
        let config = StorageConfig::for_testing().sst.write;
        let restart_interval = config.block_restart_interval;
        let mut builder = BlockBuilder::new(config.block_target_size, restart_interval);

        // fill up to just before a restart point with unrelated keys
        for i in 0..(restart_interval - 2) {
            let k = Bytes::copy_from_slice(format!("aaa:{:04}", i).as_bytes());
            let v = Bytes::from("x");
            builder.write_entry(&k, make_trailer(1, KeyKind::Put), &v);
        }
        // now write three versions of "zzz" straddling the restart boundary
        let k = Bytes::from("zzz");
        builder.write_entry(&k, make_trailer(5, KeyKind::Put), "new");
        builder.write_entry(&k, make_trailer(3, KeyKind::Put), "mid");
        builder.write_entry(&k, make_trailer(1, KeyKind::Put), "old");
        let buf = builder.finalize().freeze();

        let reader = BlockReader::<DefaultComparer>::new(buf);
        // seqnum=5 exact
        assert_eq!(reader.get(&make_key("zzz", 5)).unwrap().1, "new");
        // seqnum=4 will find seqnum=3 (newest at that timestamp)
        assert_eq!(reader.get(&make_key("zzz", 4)).unwrap().1, "mid");
        // seqnum=3 exact
        assert_eq!(reader.get(&make_key("zzz", 3)).unwrap().1, "mid");
        // seqnum=2 will find seqnum=1 (newest at that timestamp), but has to travel one interval
        assert_eq!(reader.get(&make_key("zzz", 2)).unwrap().1, "old");
        // seqnum=1 exact
        assert_eq!(reader.get(&make_key("zzz", 1)).unwrap().1, "old");
        // seqnum=0 - no eligible version
        assert!(reader.get(&make_key("zzz", 0)).is_none());
    }

    #[test]
    fn test_get_does_not_bleed_into_next_user_key() {
        // searching for a key that doesn't exist shouldn't return a value
        // from a different user key that happens to have a matching seqnum
        let buf = build_block(&[("apple", 5, "fruit"), ("cherry", 5, "red")]);
        let reader = BlockReader::<DefaultComparer>::new(buf);
        assert!(reader.get(&make_key("banana", 5)).is_none());
    }
}