telltale-machine 17.0.0

Protocol machine for choreographic session type protocols
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
// Topology event ingress, timeout management, and dispatch.
impl ProtocolMachine {
    fn next_timeout_witness(&mut self, site: &str, until_tick: u64) -> TimeoutWitness {
        let witness = TimeoutWitness {
            witness_id: self.next_authority_witness_id,
            site: site.to_string(),
            issued_at_tick: self.clock.tick,
            until_tick,
        };
        self.next_authority_witness_id = self.next_authority_witness_id.saturating_add(1);
        witness
    }

    fn audit_issued_timeout_witness(&mut self, witness: &TimeoutWitness) {
        self.authority_audit_log.push(
            AuthorityAuditRecord {
                tick: Some(self.clock.tick),
                artifact: AuthorityArtifact::Timeout(witness.clone()),
                event: AuthorityAuditEvent::Issued,
                reason: None,
            },
            &self.config.observability_retention,
        );
    }

    fn duration_to_ticks(&self, duration: Duration) -> u64 {
        let tick_nanos = self.config.tick_duration.as_nanos();
        if tick_nanos == 0 {
            return 1;
        }
        let duration_nanos = duration.as_nanos();
        let ticks = duration_nanos.div_ceil(tick_nanos);
        u64::try_from(ticks).unwrap_or(u64::MAX).max(1)
    }

    fn prune_expired_timeouts(&mut self) {
        let tick = self.clock.tick;
        let expired_witnesses: Vec<TimeoutWitness> = self
            .timed_out_sites
            .values()
            .filter_map(|witness| (witness.until_tick <= tick).then_some(witness.clone()))
            .collect();
        if !expired_witnesses.is_empty() {
            for witness in &expired_witnesses {
                self.timed_out_sites.remove(&witness.site);
                self.authority_audit_log.push(
                    AuthorityAuditRecord {
                        tick: Some(tick),
                        artifact: AuthorityArtifact::Timeout(witness.clone()),
                        event: AuthorityAuditEvent::Expired,
                        reason: Some("timeout horizon elapsed".to_string()),
                    },
                    &self.config.observability_retention,
                );
                let role = &witness.site;
                let coro_ids = self.role_coroutines.get(role).cloned().unwrap_or_default();
                for coro_id in coro_ids {
                    self.timed_out_coro_ids.remove(&coro_id);
                    self.sync_ready_eligibility_for(coro_id);
                }
            }
        }
    }

    fn is_site_timed_out(&self, site: &str) -> bool {
        self.timed_out_sites.contains_key(site)
    }

    fn is_site_crashed(&self, site: &str) -> bool {
        self.crashed_sites.contains(site)
    }

    fn is_edge_partitioned(&self, from: &str, to: &str) -> bool {
        self.partitioned_edges
            .contains(&(from.to_string(), to.to_string()))
    }

    fn edge_corruption(&self, edge: &Edge) -> Option<CorruptionType> {
        self.corrupted_edges
            .get(&(edge.sender.clone(), edge.receiver.clone()))
            .cloned()
    }

    fn apply_corruption(value: Value, corruption: CorruptionType) -> Value {
        match corruption {
            CorruptionType::BitFlip => match value {
                Value::Nat(v) => Value::Nat(v ^ 1),
                Value::Bool(v) => Value::Bool(!v),
                Value::Str(s) => {
                    let mut bytes = s.into_bytes();
                    if let Some(first) = bytes.first_mut() {
                        *first ^= 0x01;
                    }
                    Value::Str(String::from_utf8_lossy(&bytes).to_string())
                }
                Value::Prod(left, right) => {
                    Value::Prod(Box::new(Self::apply_corruption(*left, corruption)), right)
                }
                other => other,
            },
            CorruptionType::Truncation => match value {
                Value::Str(s) => Value::Str(s.chars().take(s.chars().count() / 2).collect()),
                _ => Value::Unit,
            },
            CorruptionType::PayloadErase => Value::Unit,
        }
    }

    fn normalize_topology_state(&mut self) {}

    fn apply_site_failure(&mut self, site: &str) {
        let reason = format!("site {site} crashed");

        let session_ids = self.sessions.session_ids();
        for sid in session_ids {
            let should_fault = self
                .sessions
                .get(sid)
                .is_some_and(|session| session.roles.iter().any(|role| role == site));
            if !should_fault {
                continue;
            }
            if let Some(session) = self.sessions.get_mut(sid) {
                if matches!(
                    session.status,
                    SessionStatus::Closed
                        | SessionStatus::Cancelled
                        | SessionStatus::Faulted { .. }
                ) {
                    continue;
                }
                session.status = SessionStatus::Faulted {
                    reason: reason.clone(),
                };
                self.invalidate_outstanding_effects_for_session(sid, &reason);
                self.monitor.remove_kind(sid);
            }
        }

        let mut faulted = Vec::new();
        for coro in &mut self.coroutines {
                if coro.role == site && !coro.is_terminal() {
                let fault = Fault::Invoke {
                    failure: EffectFailure::topology_disruption(reason.clone()),
                };
                coro.status = CoroStatus::Faulted(fault.clone());
                faulted.push((coro.id, fault));
            }
        }
        for (coro_id, fault) in faulted {
            self.sched.mark_done(coro_id);
            #[cfg(debug_assertions)]
            self.eligible_ready.remove(&coro_id);
            self.obs_trace.push(
                ObsEvent::Faulted {
                    tick: self.clock.tick,
                    coro_id,
                    fault,
                },
                &self.config.observability_retention,
            );
        }
    }

    fn charge_instruction_cost(&mut self, coro_idx: usize) -> Result<(), Fault> {
        let cost = self.config.instruction_cost;
        let budget = self.coroutines[coro_idx].cost_budget;
        if budget < cost {
            return Err(Fault::OutOfCredits);
        }
        self.coroutines[coro_idx].cost_budget = budget - cost;
        Ok(())
    }

    fn should_capture_effect_kind(&self, effect_kind: &str) -> bool {
        match self.config.effect_trace_capture_mode {
            EffectTraceCaptureMode::Full => true,
            EffectTraceCaptureMode::TopologyOnly => effect_kind == "topology_event",
            EffectTraceCaptureMode::Disabled => false,
        }
    }

    fn enforce_handler_identity_contract(&mut self, handler_identity: &str) -> Result<(), ProtocolMachineError> {
        if !self.config.host_contract_assertions.is_enforced() {
            return Ok(());
        }
        match &self.handler_identity_anchor {
            None => {
                self.handler_identity_anchor = Some(handler_identity.to_string());
                Ok(())
            }
            Some(anchor) if anchor == handler_identity => Ok(()),
            Some(anchor) => Err(ProtocolMachineError::HandlerError(EffectFailure::contract_violation(
                format!(
                    "[host-contract] handler_identity changed from '{anchor}' to '{handler_identity}'"
                ),
            ))),
        }
    }

    fn assert_topology_events_sorted(
        &self,
        tick: u64,
        events: &[TopologyPerturbation],
    ) -> Result<(), ProtocolMachineError> {
        if !self.config.host_contract_assertions.is_enforced() {
            return Ok(());
        }
        for idx in 1..events.len() {
            let prev_key = events[idx - 1].ordering_key();
            let next_key = events[idx].ordering_key();
            if prev_key > next_key {
                return Err(ProtocolMachineError::HandlerError(EffectFailure::contract_violation(
                    format!(
                        "[host-contract] topology_events at tick {tick} must be pre-sorted by ordering_key; out-of-order index {idx}"
                    ),
                )));
            }
        }
        Ok(())
    }

    fn assert_delegation_events_audited(&self, events: &[ObsEvent]) -> Result<(), ProtocolMachineError> {
        if !self.config.host_contract_assertions.is_enforced() {
            return Ok(());
        }
        for event in events {
            let ObsEvent::Transferred {
                session,
                role,
                from,
                to,
                ..
            } = event
            else {
                continue;
            };
            let expected_scope = OwnershipScope::Fragments(BTreeSet::from([role.clone()]));
            let found = self.delegation_audit_log.iter().rev().any(|audit| {
                audit.status == DelegationStatus::Committed
                    && audit.receipt.session == *session
                    && audit.receipt.endpoint.role == *role
                    && audit.receipt.from_coro == *from
                    && audit.receipt.to_coro == *to
                    && audit.receipt.scope == expected_scope
            });
            if !found {
                return Err(ProtocolMachineError::HandlerError(EffectFailure::contract_violation(
                    format!(
                        "[host-contract] transfer event for session {session} role {role} must have a matching committed delegation audit record"
                    ),
                )));
            }
        }
        Ok(())
    }

    fn apply_topology_event(&mut self, event: &TopologyPerturbation) {
        match event {
            TopologyPerturbation::Crash { site } => {
                self.crashed_sites.insert(site.clone());
                self.apply_site_failure(site);
                self.mark_eligibility_dirty();
            }
            TopologyPerturbation::Partition { from, to } => {
                self.partitioned_edges.insert((from.clone(), to.clone()));
                self.partitioned_edges.insert((to.clone(), from.clone()));
            }
            TopologyPerturbation::Heal { from, to } => {
                self.partitioned_edges.remove(&(from.clone(), to.clone()));
                self.partitioned_edges.remove(&(to.clone(), from.clone()));
                self.corrupted_edges.remove(&(from.clone(), to.clone()));
                self.corrupted_edges.remove(&(to.clone(), from.clone()));
            }
            TopologyPerturbation::Corrupt {
                from,
                to,
                corruption,
            } => {
                self.corrupted_edges
                    .insert((from.clone(), to.clone()), *corruption);
            }
            TopologyPerturbation::Timeout { site, duration } => {
                let until_tick = self
                    .clock
                    .tick
                    .saturating_add(self.duration_to_ticks(*duration));
                let witness = self.next_timeout_witness(site, until_tick);
                if let Some(previous) = self.timed_out_sites.remove(site) {
                    self.authority_audit_log.push(
                        AuthorityAuditRecord {
                            tick: Some(self.clock.tick),
                            artifact: AuthorityArtifact::Timeout(previous),
                            event: AuthorityAuditEvent::Invalidated,
                            reason: Some("replaced by newer timeout witness".to_string()),
                        },
                        &self.config.observability_retention,
                    );
                }
                self.audit_issued_timeout_witness(&witness);
                self.timed_out_sites.insert(site.clone(), witness.clone());
                self.obs_trace.push(
                    ObsEvent::TimeoutIssued {
                        tick: self.clock.tick,
                        site: site.clone(),
                        until_tick,
                        witness_id: witness.witness_id,
                    },
                    &self.config.observability_retention,
                );
                let coro_ids = self.role_coroutines.get(site).cloned().unwrap_or_default();
                for coro_id in coro_ids {
                    self.timed_out_coro_ids.insert(coro_id);
                    self.sync_ready_eligibility_for(coro_id);
                }
            }
        }
        self.normalize_topology_state();
    }

    fn ingest_topology_events(&mut self, handler: &dyn EffectHandler) -> Result<(), ProtocolMachineError> {
        let tick = self.clock.tick;
        let handler_identity = handler.handler_identity();
        self.enforce_handler_identity_contract(&handler_identity)?;
        let request = EffectRequest::topology_events(tick);
        self.ensure_effect_request_allowed(&request)
            .map_err(ProtocolMachineError::HandlerError)?;
        let predicted_effect_id = self.next_effect_id;
        let topology_outcome = handler.handle_effect(request.clone());
        self.record_effect_exchange(&request, &topology_outcome, &handler_identity, predicted_effect_id);
        let mut events = topology_outcome
            .into_topology()
            .unwrap_or_else(EffectResult::failure)
            .expect_success(|| {
                EffectFailure::contract_violation("topology_events returned blocked")
            })
            .map_err(ProtocolMachineError::HandlerError)?;
        self.assert_topology_events_sorted(tick, &events)?;
        events.sort_by_key(TopologyPerturbation::ordering_key);
        for event in events {
            self.apply_topology_event(&event);
            let effect_kind = "topology_event".to_string();
            let (effect_interface, effect_operation) =
                infer_effect_interface_and_operation(&effect_kind);
            let entry = EffectTraceEntry {
                effect_id: self.next_effect_id,
                effect_kind,
                inputs: json!({
                    "tick": tick,
                }),
                outputs: json!({
                    "status": "success",
                    "applied": true,
                    "topology": event,
                }),
                handler_identity: handler_identity.clone(),
                effect_interface,
                effect_operation,
                ordering_key: self.next_effect_id,
                topology: Some(event.clone()),
            };
            self.sync_runtime_effect_from_trace_entry(&entry);
            if self.should_capture_effect_kind("topology_event") {
                self.effect_trace
                    .push(entry, &self.config.observability_retention);
            }
            self.next_effect_id = self.next_effect_id.saturating_add(1);
        }
        Ok(())
    }

    /// Fault a session because the current owner died.
    ///
    /// # Errors
    ///
    /// Returns an `OwnershipError` if the live owner no longer matches.
    pub fn mark_owner_died(
        &mut self,
        sid: SessionId,
        owner_id: &str,
    ) -> Result<CancellationWitness, OwnershipError> {
        let witness = self.sessions_mut().mark_owner_died(sid, owner_id)?;
        self.invalidate_outstanding_effects_for_session(
            sid,
            &format!("ownership owner `{owner_id}` died"),
        );
        self.obs_trace.push(
            ObsEvent::SessionTerminal {
                tick: self.clock.tick,
                session: sid,
                reason: SessionTerminalReason::Faulted {
                    reason: format!("ownership owner `{owner_id}` died"),
                },
            },
            &self.config.observability_retention,
        );
        Ok(witness)
    }

    /// Cancel a session because a staged transfer was abandoned.
    ///
    /// # Errors
    ///
    /// Returns an `OwnershipError` if the receipt no longer matches the staged transfer.
    pub fn cancel_abandoned_transfer(
        &mut self,
        receipt: &OwnershipReceipt,
    ) -> Result<CancellationWitness, OwnershipError> {
        let requested_reason = OwnershipTerminalReason::TransferAbandoned {
            owner_id: receipt.from_owner_id.clone(),
            claim_id: receipt.claim_id,
        };
        let witness = self.sessions_mut().cancel_abandoned_transfer(receipt)?;
        self.invalidate_outstanding_effects_for_session(
            receipt.session_id,
            "ownership transfer abandoned",
        );
        self.obs_trace.push(
            ObsEvent::CancellationRequested {
                tick: self.clock.tick,
                session: receipt.session_id,
                witness_id: witness.witness_id,
                owner_id: receipt.from_owner_id.clone(),
                reason: requested_reason.clone(),
            },
            &self.config.observability_retention,
        );
        self.obs_trace.push(
            ObsEvent::Cancelled {
                tick: self.clock.tick,
                session: receipt.session_id,
                witness_id: witness.witness_id,
                reason: requested_reason.clone(),
            },
            &self.config.observability_retention,
        );
        self.obs_trace.push(
            ObsEvent::SessionTerminal {
                tick: self.clock.tick,
                session: receipt.session_id,
                reason: SessionTerminalReason::Cancelled {
                    reason: format!(
                        "ownership transfer {} abandoned by {}",
                        receipt.claim_id, receipt.from_owner_id
                    ),
                },
            },
            &self.config.observability_retention,
        );
        Ok(witness)
    }

    /// Fault a session because a staged transfer could not commit.
    ///
    /// # Errors
    ///
    /// Returns an `OwnershipError` if the receipt no longer matches the staged transfer.
    pub fn fault_failed_transfer_commit(
        &mut self,
        receipt: &OwnershipReceipt,
        reason: impl Into<String>,
    ) -> Result<(), OwnershipError> {
        let reason = reason.into();
        self.sessions_mut()
            .fault_failed_transfer_commit(receipt, reason.clone())?;
        self.invalidate_outstanding_effects_for_session(receipt.session_id, &reason);
        self.obs_trace.push(
            ObsEvent::SessionTerminal {
                tick: self.clock.tick,
                session: receipt.session_id,
                reason: SessionTerminalReason::Faulted {
                    reason: format!("ownership transfer commit failed: {reason}"),
                },
            },
            &self.config.observability_retention,
        );
        Ok(())
    }

    /// Try to unblock coroutines that are waiting on sends.
    fn try_unblock_senders(&mut self) {
        let blocked_ids = self.sched.blocked_ids();
        for coro_id in blocked_ids {
            let Some(idx) = self.coro_index(coro_id) else {
                continue;
            };
            let role = &self.coroutines[idx].role;
            if self.paused_roles.contains(role)
                || self.is_site_crashed(role)
                || self.is_site_timed_out(role)
            {
                continue;
            }
            let reason = self.sched.block_reason(coro_id).cloned();
            if let Some(BlockReason::Send { edge }) = reason {
                if self.is_site_crashed(&edge.sender)
                    || self.is_site_crashed(&edge.receiver)
                    || self.is_site_timed_out(&edge.sender)
                    || self.is_site_timed_out(&edge.receiver)
                    || self.is_edge_partitioned(&edge.sender, &edge.receiver)
                {
                    continue;
                }
                let can_send = self
                    .sessions
                    .get(edge.sid)
                    .and_then(|session| session.buffers.get(&edge))
                    .is_some_and(|buffer| !buffer.is_full());
                if can_send {
                    self.sched.unblock(coro_id);
                    self.sync_ready_eligibility_for(coro_id);
                }
            }
        }
    }

    /// Try to unblock coroutines that are waiting on receives.
    fn try_unblock_receivers(&mut self) {
        let blocked_ids = self.sched.blocked_ids();
        for coro_id in blocked_ids {
            let Some(idx) = self.coro_index(coro_id) else {
                continue;
            };
            let role = &self.coroutines[idx].role;
            if self.paused_roles.contains(role)
                || self.is_site_crashed(role)
                || self.is_site_timed_out(role)
            {
                continue;
            }
            let reason = self.sched.block_reason(coro_id).cloned();
            if let Some(BlockReason::Recv { token, .. }) = reason {
                if let Some(session) = self.sessions.get(token.sid) {
                    let has_msg = session.roles.iter().any(|sender| {
                        sender != &token.endpoint.role
                            && session.has_message(sender, &token.endpoint.role)
                    });
                    if has_msg {
                        self.sched.unblock(coro_id);
                        self.sync_ready_eligibility_for(coro_id);
                    }
                }
            }
        }
    }

    /// Execute one instruction for a coroutine.
    ///
    /// Follows the Lean `execInstr` pipeline:
    /// 1. Fetch instruction at PC
    /// 2. Dispatch to per-instruction step function (which owns type checking)
    /// 3. Commit the `StepPack` atomically
    fn exec_instr(
        &mut self,
        coro_id: usize,
        handler: &dyn EffectHandler,
    ) -> Result<ExecOutcome, Fault> {
        let handler_identity = handler.handler_identity();
        self.enforce_handler_identity_contract(&handler_identity)
            .map_err(|e| Fault::Invoke {
                failure: EffectFailure::contract_violation(e.to_string()),
            })?;
        let idx = self.coro_index(coro_id).ok_or_else(|| Fault::Speculation {
            message: format!("scheduler selected missing coroutine {coro_id}"),
        })?;
        let pc = self.coroutines[idx].pc;
        let sid = self.coroutines[idx].session_id;
        let role = self.coroutines[idx].role.clone();
        let fallback_ep = self.coroutines[idx]
            .owned_endpoints
            .first()
            .cloned()
            .unwrap_or(Endpoint {
                sid,
                role: role.clone(),
            });
        let program = self
            .programs
            .get(self.coroutines[idx].program_id)
            .ok_or(Fault::PcOutOfBounds)?;

        // 1. Fetch.
        if pc >= program.len() {
            return Err(Fault::PcOutOfBounds);
        }
        let instr = program[pc].clone();
        let monitor_ep = match &instr {
            Instr::Send { chan, .. }
            | Instr::Receive { chan, .. }
            | Instr::Offer { chan, .. }
            | Instr::Choose { chan, .. } => self
                .endpoint_from_reg(idx, *chan)
                .unwrap_or_else(|_| fallback_ep.clone()),
            Instr::Close { session } => self
                .endpoint_from_reg(idx, *session)
                .unwrap_or_else(|_| fallback_ep.clone()),
            _ => fallback_ep,
        };

        // 1.5 Monitor precheck and deterministic cost charge.
        self.monitor_precheck(&monitor_ep, &role, &instr)?;
        self.charge_instruction_cost(idx)?;

        // 2. Dispatch to per-instruction step function.
        let pack = exec::step_instr(self, idx, &monitor_ep, &role, sid, instr, handler)?;

        let output_hint = if pack.events.is_empty() {
            None
        } else {
            let request = EffectRequest::output_condition_hint(
                self.clock.tick,
                sid,
                None,
                &role,
                &self.coroutines[idx].regs,
            );
            match self.ensure_effect_request_allowed(&request) {
                Ok(()) => {
                    let predicted_effect_id = self.next_effect_id;
                    let outcome = handler.handle_effect(request.clone());
                    self.record_effect_exchange(
                        &request,
                        &outcome,
                        &handler_identity,
                        predicted_effect_id,
                    );
                    outcome.into_output_condition_hint().ok().flatten()
                }
                Err(_) => None,
            }
        };

        // 3. Commit atomically.
        self.commit_pack(idx, pack, output_hint, handler, &handler_identity)
    }

    // ---- Per-instruction step functions (each owns its type logic) ----

    /// Send: lookup type → match Send → compute payload → enqueue → StepPack with L'.
    #[allow(clippy::too_many_lines)]
    pub(crate) fn step_send(
        &mut self,
        coro_idx: usize,
        role: &str,
        chan: u16,
        val_reg: u16,
        handler: &dyn EffectHandler,
    ) -> Result<StepPack, Fault> {
        let ep = self.endpoint_from_reg(coro_idx, chan)?;
        if !self.coroutines[coro_idx].owned_endpoints.contains(&ep) {
            return Err(Fault::ChannelClosed { endpoint: ep });
        }
        let sid = ep.sid;

        // Type lookup — instruction owns this.
        let local_type = self
            .sessions
            .lookup_type(&ep)
            .ok_or_else(|| Fault::TypeViolation {
                expected: telltale_types::ValType::Unit,
                actual: telltale_types::ValType::Unit,
                message: format!("{role}: no type registered"),
            })?
            .clone();

        // Pattern match: must be Send.
        let (partner, branches) = match &local_type {
            LocalTypeR::Send {
                partner, branches, ..
            } => (partner.clone(), branches.clone()),
            other => {
                return Err(Fault::TypeViolation {
                    expected: telltale_types::ValType::Unit,
                    actual: telltale_types::ValType::Unit,
                    message: format!("{role}: expected Send, got {other:?}"),
                })
            }
        };

        // Extract continuation (L') from first branch.
        let (label, expected_type, continuation) = branches
            .first()
            .ok_or_else(|| Fault::TypeViolation {
                expected: telltale_types::ValType::Unit,
                actual: telltale_types::ValType::Unit,
                message: format!("{role}: send has no branches"),
            })?
            .clone();

        // Compute payload/decision via handler.
        let coro = &self.coroutines[coro_idx];
        let send_payload = self.read_reg_checked(coro_idx, val_reg)?;
        let handler_identity = handler.handler_identity();
        let effect_inputs = json!({
            "session": sid,
            "from": role,
            "to": partner,
            "label": label.name,
        });
        let request = EffectRequest::send_decision(
            self.clock.tick,
            sid,
            None,
            role,
            &partner,
            &label.name,
            &coro.regs,
            Some(send_payload),
        );
        self.ensure_effect_request_allowed(&request)
            .map_err(|failure| Fault::Invoke { failure })?;
        let predicted_effect_id = self.next_effect_id;
        let send_outcome = handler.handle_effect(request.clone());
        self.record_effect_exchange(&request, &send_outcome, &handler_identity, predicted_effect_id);
        let decision = match send_outcome
            .into_send_decision()
            .unwrap_or_else(EffectResult::failure)
        {
            EffectResult::Success(decision) => decision,
            EffectResult::Blocked => {
                let effect_id = self.issue_runtime_effect(
                    "send_decision",
                    Some(sid),
                    &handler_identity,
                    effect_inputs.clone(),
                );
                let failure =
                    EffectFailure::contract_violation("send_decision returned blocked");
                self.complete_runtime_effect(
                    effect_id,
                    OutstandingEffectStatus::Failed,
                    json!({
                        "status": "failure",
                        "failure": failure,
                    }),
                )
                .map_err(|err| Fault::Invoke {
                    failure: EffectFailure::contract_violation(err.to_string()),
                })?;
                return Err(Fault::Invoke { failure });
            }
            EffectResult::Failure(failure) => {
                let effect_id = self.issue_runtime_effect(
                    "send_decision",
                    Some(sid),
                    &handler_identity,
                    effect_inputs.clone(),
                );
                self.complete_runtime_effect(
                    effect_id,
                    OutstandingEffectStatus::Failed,
                    json!({
                        "status": "failure",
                        "failure": failure,
                    }),
                )
                .map_err(|err| Fault::Invoke {
                    failure: EffectFailure::contract_violation(err.to_string()),
                })?;
                return Err(Fault::Invoke { failure });
            }
        };

        let edge = Edge::new(sid, role.to_string(), partner.clone());

        if self.is_site_crashed(role)
            || self.is_site_crashed(&partner)
            || self.is_site_timed_out(role)
            || self.is_site_timed_out(&partner)
            || self.is_edge_partitioned(role, &partner)
        {
            self.override_effect_status(
                predicted_effect_id,
                OutstandingEffectStatus::Blocked,
                json!({
                    "status": "blocked",
                    "reason": "topology unavailable",
                }),
            )
            .map_err(|err| Fault::Invoke {
                failure: EffectFailure::contract_violation(err.to_string()),
            })?;
            return Ok(StepPack {
                coro_update: CoroUpdate::Block(BlockReason::Send { edge }),
                type_update: None,
                events: vec![],
            });
        }

        // Enqueue into per-edge signed session buffer (if delivered).
        let maybe_corruption = self.edge_corruption(&edge);
        if let SendDecision::Deliver(payload) = &decision {
            self.validate_payload(
                role,
                "send",
                &label.name,
                expected_type.as_ref(),
                payload,
                true,
            )?;
        }
        let enqueue = match decision {
            SendDecision::Deliver(payload) => {
                let sequence_no = self.allocate_send_sequence(&edge);
                let payload = if let Some(corruption) = maybe_corruption {
                    Self::apply_corruption(payload, corruption)
                } else {
                    payload
                };
                let session = self
                    .sessions
                    .get_mut(sid)
                    .ok_or_else(|| Fault::ChannelClosed {
                        endpoint: ep.clone(),
                    })?;
                session
                    .send_with_sequence(role, &partner, payload, sequence_no)
                    .map_err(|e| Fault::Invoke {
                        failure: EffectFailure::invalid_input(e),
                    })?
            }
            SendDecision::Drop | SendDecision::Defer => EnqueueResult::Dropped,
        };

        match enqueue {
            EnqueueResult::Ok => {}
            EnqueueResult::WouldBlock => {
                let effect_id = self.issue_runtime_effect(
                    "send_decision",
                    Some(sid),
                    &handler_identity,
                    effect_inputs,
                );
                self.complete_runtime_effect(
                    effect_id,
                    OutstandingEffectStatus::Blocked,
                    json!({
                        "status": "blocked",
                        "reason": "buffer would block",
                    }),
                )
                .map_err(|err| Fault::Invoke {
                    failure: EffectFailure::contract_violation(err.to_string()),
                })?;
                // Block — NO type advancement.
                return Ok(StepPack {
                    coro_update: CoroUpdate::Block(BlockReason::Send { edge }),
                    type_update: None,
                    events: vec![],
                });
            }
            EnqueueResult::Full => {
                return Err(Fault::BufferFull { endpoint: ep });
            }
            EnqueueResult::Dropped => {}
        }

        // Success: resolve continuation and advance type.
        let original = self.sessions.original_type(&ep).unwrap_or(&LocalTypeR::End);
        let (_resolved, type_update) = resolve_type_update(&continuation, original, &ep);

        Ok(StepPack {
            coro_update: CoroUpdate::AdvancePc,
            type_update,
            events: vec![ObsEvent::Sent {
                tick: self.clock.tick,
                edge,
                session: sid,
                from: role.to_string(),
                to: partner,
                label: label.name,
            }],
        })
    }

}