teksilo-widgets 0.9.2

// SPDX-License-Identifier: MPL-2.0
// SPDX-FileCopyrightText: 2026 FernTech

use super::*;
use teksilo_core::widget_tree::WidgetTree;
use teksilo_data::ListModel;

// ─── Helpers ──────────────────────────────────────────────────────

fn light_tree() -> WidgetTree {
    WidgetTree::new().with_theme(teksilo_core::presets::intui::light())
}

fn fruits() -> Vec<&'static str> {
    vec!["Apple", "Banana", "Cherry"]
}

// ─── Basic layout & role ──────────────────────────────────────────

#[test]
fn combo_box_builds_and_lays_out() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()).placeholder(lit!("Select...")));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    let bounds = tree.bounds(cb);
    assert!(bounds.width >= 120.0);
    assert!(bounds.height >= 36.0);
}

#[test]
fn combo_box_accessibility_role() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(vec!["A", "B"], selected.clone()));
    tree.layout(SizeProposal::exact(200.0, 50.0));
    let info = tree.accessibility_node(cb);
    assert_eq!(info.role(), teksilo_core::accesskit::Role::ComboBox);
    assert!(!info.is_expanded());
}

#[test]
fn accessibility_exposes_label_via_set_name() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb =
        tree.add(ComboBox::new(vec!["Apple", "Banana"], selected.clone()).label(lit!("Fruit")));
    tree.layout(SizeProposal::exact(200.0, 50.0));
    let info = tree.accessibility_node(cb);
    assert_eq!(info.name(), Some("Fruit"));
}

#[test]
fn accessibility_expanded_flips_on_open_close() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    assert!(!tree.accessibility_node(cb).is_expanded());

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(tree.accessibility_node(cb).is_expanded());

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(!tree.accessibility_node(cb).is_expanded());
}

#[test]
fn accessibility_expanded_resets_on_framework_dismiss() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(tree.accessibility_node(cb).is_expanded());

    let overlay_id = tree
        .active_overlays()
        .first()
        .copied()
        .expect("dropdown overlay should be active");
    tree.dismiss_overlay(overlay_id);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(
        !tree.accessibility_node(cb).is_expanded(),
        "framework overlay dismiss must reset is_expanded() to false"
    );
}

// ─── Keyboard ─────────────────────────────────────────────────────

#[test]
fn arrow_keys_cycle_selection() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Cherry"));

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Apple"));
}

#[test]
fn selected_updates_label() {
    let mut tree = light_tree();
    let selected = Signal::new(Some("Banana".to_string()));
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    assert!(tree.bounds(cb).width > 0.0);
}

#[test]
fn click_opens_overlay() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    assert!(tree.active_overlays().is_empty());

    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 200.0));

    assert_eq!(tree.active_overlays().len(), 1);
}

#[test]
fn access_click_opens_overlay() {
    // The node advertises `Action::Click`; an AT / automation click must
    // open the dropdown. No platform adapter sends `Expand`/`Collapse` —
    // every one funnels activation through `Click` — so this is the only
    // AT open path.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    assert!(tree.active_overlays().is_empty());

    tree.dispatch_event(teksilo_core::event::WidgetEvent::AccessAction {
        action: teksilo_core::accesskit::Action::Click,
        target: Some(cb),
        target_node: teksilo_core::accessibility::root_node_id(),
        data: None,
    });
    tree.layout(SizeProposal::exact(300.0, 200.0));

    assert_eq!(tree.active_overlays().len(), 1);
}

#[test]
fn type_ahead_jumps_to_matching_item() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry", "Blueberry"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::B, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.press_key(Key::L, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Blueberry"));
}

#[test]
fn type_ahead_with_character_key() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["100px", "200px", "300px"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::Character('2'), teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("200px"));
}

#[test]
fn type_ahead_case_insensitive() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::C, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Cherry"));
}

#[test]
fn type_ahead_no_match_keeps_selection() {
    let mut tree = light_tree();
    let selected = Signal::new(Some("Banana".to_string()));
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::Z, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));
}

#[test]
fn type_ahead_matches_accented_label() {
    // Regression: typed char was lowercased via `to_ascii_lowercase`
    // (a no-op on non-ASCII) while labels used full `to_lowercase`, so
    // accented input never matched an accented label.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "École", "Zürich"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    // Uppercase accented input matches the accented label.
    tree.press_key(Key::Character('É'), teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("École"));

    // Lowercase accented input matches too.
    let selected2 = Signal::new(None::<String>);
    let cb2 = tree.add(ComboBox::new(
        vec!["Apple", "école", "Zürich"],
        selected2.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb2);
    tree.press_key(Key::Character('é'), teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected2.get().as_deref(), Some("école"));
}

#[test]
fn type_ahead_timeout_zero_treats_each_keystroke_independently() {
    // With a zero reset window every keystroke starts a fresh prefix.
    // "B" selects Banana; the following "L" begins a new prefix "l"
    // (no item starts with it) instead of extending to "bl" → Blueberry.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(
        ComboBox::new(vec!["Apple", "Banana", "Blueberry"], selected.clone())
            .type_ahead_timeout(std::time::Duration::ZERO),
    );
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::B, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.press_key(Key::L, teksilo_core::event::Modifiers::NONE);
    // Prefix reset: "l" matches nothing, selection unchanged.
    assert_eq!(selected.get().as_deref(), Some("Banana"));
}

#[test]
fn enter_toggles_dropdown_open_close() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    assert!(tree.active_overlays().is_empty());
    assert_eq!(selected.get().as_deref(), Some("Banana"));
}

#[test]
fn escape_closes_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::Escape, teksilo_core::event::Modifiers::NONE);
    assert!(tree.active_overlays().is_empty());
}

#[test]
fn arrow_down_opens_dropdown_when_closed() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert_eq!(tree.active_overlays().len(), 1);
    assert_eq!(selected.get().as_deref(), Some("Banana"));
}

#[test]
fn type_ahead_highlights_in_open_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 300.0));
    tree.focus(cb);

    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 300.0));
    assert_eq!(tree.active_overlays().len(), 1);
    let frame_before = tree.render();

    tree.press_key(Key::B, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.layout(SizeProposal::exact(300.0, 300.0));
    let frame_after = tree.render();

    assert_ne!(frame_before.shapes, frame_after.shapes);
}

#[test]
fn below_preferred_opens_above_when_no_space() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 60.0));

    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 60.0));

    assert_eq!(tree.active_overlays().len(), 1);

    let content_ids = tree.overlay_manager().active_content_ids();
    let overlay_bounds = tree.bounds(content_ids[0]);
    let cb_bounds = tree.bounds(cb);

    assert!(
        overlay_bounds.y + overlay_bounds.height <= cb_bounds.y + 5.0,
        "overlay should be positioned above when no space below"
    );
}

// ─── Model-backed & typed selection (new) ─────────────────────────

#[derive(Clone, Debug, PartialEq)]
struct Fruit {
    name: &'static str,
    emoji: &'static str,
}

fn fruit_list() -> Vec<Fruit> {
    vec![
        Fruit {
            name: "Apple",
            emoji: "🍎",
        },
        Fruit {
            name: "Banana",
            emoji: "🍌",
        },
        Fruit {
            name: "Cherry",
            emoji: "🍒",
        },
    ]
}

#[test]
fn typed_combo_box_renders_with_item_label() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<Fruit>);
    let cb = tree.add(
        ComboBox::from_items(fruit_list(), selected.clone(), |f: &Fruit| {
            lit!(f.name.to_string())
        })
        .placeholder(lit!("Pick a fruit")),
    );
    tree.layout(SizeProposal::exact(300.0, 50.0));
    assert!(tree.bounds(cb).width >= 120.0);
}

#[test]
fn model_backed_combo_reflects_insertions_via_clicks() {
    // Strong form of the insertion test: insert a new item, then
    // click it in the open dropdown and verify `selected` reflects
    // the click. Exercises the full observer → panel rebuild →
    // click path, not just the signal plumbing.
    let mut tree = light_tree();
    let model = ListModel::from_vec(vec!["Apple".to_string(), "Cherry".to_string()]);
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::from_model(
        model.clone(),
        selected.clone(),
        |s: &String| lit!(s.clone()),
    ));
    tree.layout(SizeProposal::exact(300.0, 400.0));

    // Insert Banana between Apple and Cherry — model is now [Apple, Banana, Cherry].
    model.insert(1, "Banana".to_string());
    tree.layout(SizeProposal::exact(300.0, 400.0));

    // Open the dropdown.
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 400.0));
    assert_eq!(tree.active_overlays().len(), 1);

    // Find the newly-inserted "Banana" row via its accessibility name
    // and click it. If the panel did not rebuild on insertion, this
    // lookup would fail.
    let banana = tree
        .find_by_label("Banana")
        .expect("Banana row should be present in the dropdown");
    tree.click(banana);
    tree.layout(SizeProposal::exact(300.0, 400.0));

    assert_eq!(selected.get().as_deref(), Some("Banana"));
    // Clicking an item dismisses the overlay.
    assert!(tree.active_overlays().is_empty());
}

#[test]
fn model_backed_combo_resets_selection_on_remove() {
    let mut tree = light_tree();
    let model = ListModel::from_vec(vec![
        "Apple".to_string(),
        "Banana".to_string(),
        "Cherry".to_string(),
    ]);
    let selected = Signal::new(Some("Banana".to_string()));
    tree.add(ComboBox::from_model(
        model.clone(),
        selected.clone(),
        |s: &String| lit!(s.clone()),
    ));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    // Remove the selected item.
    model.remove(1);
    tree.layout(SizeProposal::exact(300.0, 200.0));

    // Selection should have been cleared by the observe hook.
    assert_eq!(selected.get(), None);
}

#[test]
fn typed_selection_survives_reorder() {
    let mut tree = light_tree();
    let model = ListModel::from_vec(fruit_list());
    let selected = Signal::new(Some(Fruit {
        name: "Banana",
        emoji: "🍌",
    }));
    tree.add(ComboBox::from_model(
        model.clone(),
        selected.clone(),
        |f: &Fruit| lit!(f.name.to_string()),
    ));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    // Move Banana from index 1 to index 0.
    model.move_item(1, 0);
    tree.layout(SizeProposal::exact(300.0, 200.0));

    // Selection unchanged — same T, regardless of index.
    assert_eq!(selected.get().map(|f| f.name), Some("Banana"));
}

#[test]
fn home_end_keys_jump_to_first_and_last() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry", "Date"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::End, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Date"));

    tree.press_key(Key::Home, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Apple"));
}

#[test]
fn dropdown_items_span_panel_width() {
    // Regression: DropdownItem::size_that_fits delegates to the root
    // ZStack, which queries children with UNSPECIFIED — so items
    // collapsed to the intrinsic width of their text label and
    // appeared as narrow centered stripes inside the wider dropdown
    // panel. The panel bg and RectWidgets filled the panel area but
    // the items (containing the labels) did not, producing a
    // visually-blank dropdown where only clicks that happened to
    // land on the narrow label strip changed the selection.
    //
    // Each item's bounds must match the panel's inner width
    // (accounting for the 4px outer padding on both sides).
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert_eq!(tree.active_overlays().len(), 1);

    let content_ids = tree.overlay_manager().active_content_ids();
    let panel_width = tree.bounds(content_ids[0]).width;
    assert!(panel_width > 100.0, "panel should be reasonably wide");

    for name in ["Apple", "Banana", "Cherry"] {
        let id = tree
            .find_by_label(name)
            .unwrap_or_else(|| panic!("dropdown should contain {name}"));
        let w = tree.bounds(id).width;
        // Panel has 4px padding on each side — items should fill
        // the inner width (panel_width - 8).
        assert!(
            w >= panel_width - 10.0,
            "row {name} should span panel width: item={}, panel={}",
            w,
            panel_width
        );
    }
}

#[test]
fn dropdown_items_have_nonzero_bounds_when_open() {
    // Regression guard for a rendering bug where the dropdown panel
    // showed a blank surface: the item rows must each occupy a visible
    // rectangle after the overlay opens. Without this, the widget-
    // catalog demo regressed to an empty-looking dropdown even though
    // the logic tests all passed.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 400.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 400.0));
    assert_eq!(tree.active_overlays().len(), 1);

    for name in ["Apple", "Banana", "Cherry"] {
        let id = tree
            .find_by_label(name)
            .unwrap_or_else(|| panic!("dropdown should contain {name}"));
        let b = tree.bounds(id);
        assert!(
            b.width > 0.0 && b.height > 0.0,
            "{name} row should have nonzero bounds, got {:?}",
            b
        );
    }
}

#[test]
fn tooltip_does_not_leak_onto_open_dropdown_rows() {
    // Regression: a tooltip attached to the ComboBox (or any ancestor)
    // must not re-trigger while the pointer is over the open dropdown's
    // option rows. The dropdown panel is an arena child of the combo
    // box (returned by `children()`), so a naive descendant walk in
    // `tooltip_pointer_enter` treated hovering a row as hovering the
    // anchor. The overlay-boundary gate in the tooltip machinery fixes
    // this for combo boxes, popovers, and menus alike.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    // Tooltip content is any dormant widget in the tree.
    let tip = tree.add(TextWidget::new(lit!("Pick a fruit")));
    tree.layout(SizeProposal::exact(300.0, 400.0));

    let delay = std::time::Duration::from_millis(200);
    tree.attach_tooltip(cb, tip, delay);

    // Sanity: hovering the closed trigger DOES show the tooltip.
    tree.pointer_move(tree.bounds(cb).center());
    tree.advance_time(delay + std::time::Duration::from_millis(50));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "tooltip should appear when hovering the closed combo trigger"
    );

    // Move the pointer away; the tooltip dismisses after the 100ms hoverable
    // grace (WCAG 1.4.13, audit G12), then open the dropdown.
    tree.pointer_move(teksilo_canvas::Point::new(1000.0, 1000.0));
    tree.advance_time(std::time::Duration::from_millis(150));
    assert!(tree.active_overlays().is_empty());

    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 400.0));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "only the dropdown overlay should be open"
    );

    // Hover a dropdown row and wait past the delay: the tooltip must
    // NOT appear — there should still be exactly one overlay (the
    // dropdown).
    let row = tree
        .find_by_label("Banana")
        .expect("dropdown should contain Banana");
    tree.pointer_move(tree.bounds(row).center());
    tree.advance_time(delay + std::time::Duration::from_millis(50));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "tooltip must not leak onto the open dropdown's option rows"
    );
}

#[test]
fn tooltip_builder_shows_on_trigger_and_does_not_leak() {
    // The `.tooltip(..)` builder anchors on the trigger chrome: it
    // appears when hovering the closed combo, and (thanks to the
    // framework's overlay-boundary gate) does NOT re-trigger over the
    // open dropdown's option rows.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()).tooltip(lit!("Pick a fruit")));
    tree.layout(SizeProposal::exact(300.0, 400.0));

    // Hover the closed trigger → the tooltip appears after the theme
    // delay (advance generously past any reasonable delay).
    tree.pointer_move(tree.bounds(cb).center());
    tree.advance_time(std::time::Duration::from_secs(1));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "tooltip should appear when hovering the closed trigger"
    );
    assert!(
        tree.find_by_label("Pick a fruit").is_some(),
        "the tooltip content should be present"
    );

    // Move away; the tooltip dismisses after the 100ms hoverable grace
    // (WCAG 1.4.13, audit G12), then open the dropdown.
    tree.pointer_move(teksilo_canvas::Point::new(1500.0, 1500.0));
    tree.advance_time(std::time::Duration::from_millis(150));
    assert!(tree.active_overlays().is_empty());

    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 400.0));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "only the dropdown overlay should be open"
    );

    // Hover a row and wait: no tooltip overlay should appear.
    let row = tree
        .find_by_label("Cherry")
        .expect("dropdown should contain Cherry");
    tree.pointer_move(tree.bounds(row).center());
    tree.advance_time(std::time::Duration::from_secs(1));
    assert_eq!(
        tree.active_overlays().len(),
        1,
        "the .tooltip() builder must not leak onto open dropdown rows"
    );
}

#[test]
fn many_items_scroll_without_overflow_past_overlay() {
    // More items than max_visible_items (default 8): the dropdown
    // must cap at roughly max_visible * item_height, not grow to
    // fit every row.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let many: Vec<String> = (0..20).map(|i| format!("Item {i}")).collect();
    let cb = tree.add(ComboBox::new(many, selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 800.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 800.0));

    let content_ids = tree.overlay_manager().active_content_ids();
    let panel_bounds = tree.bounds(content_ids[0]);
    // 20 rows × 32px = 640px uncapped; expect well under that.
    assert!(
        panel_bounds.height < 400.0,
        "panel should be capped, was {}",
        panel_bounds.height
    );
    assert!(
        panel_bounds.height > 0.0,
        "panel should have visible height"
    );
}

/// Walk the subtree rooted at `root` and count materialized
/// `DropdownItem` widgets. Uses `find_by_label` on each item's
/// generated "Item {i}" label as the identity check — robust against
/// the a11y wrapping ListView adds around each row (`ListItemWrapper`
/// shares the `ListBoxOption` role, so a raw role scan would double-
/// count).
fn count_materialized_items(tree: &WidgetTree, labels: &[String]) -> usize {
    labels
        .iter()
        .filter(|l| tree.find_by_label(l.as_str()).is_some())
        .count()
}

#[test]
fn large_combo_only_materializes_visible_rows() {
    // A 10 000-item combo must not build 10 000 DropdownItem widget
    // subtrees on open. With ListView virtualization, the materialized
    // row count should be bounded to roughly the viewport size plus
    // ListView's small buffer — nowhere near 10 000.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..10_000).map(|i| format!("Item {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 800.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 800.0));

    let content_ids = tree.overlay_manager().active_content_ids();
    assert_eq!(content_ids.len(), 1, "expected one open dropdown overlay");
    let materialized = count_materialized_items(&tree, &labels);
    // A non-virtualized 10 000-item combo would materialize all
    // 10 000 rows. The virtualized path caps at roughly
    // `viewport / item_height + buffer`. 100 is a generous ceiling
    // that still rings the regression alarm — the real count lands
    // well under 50 in practice.
    assert!(
        materialized < 100,
        "virtualized combo should materialize well under 100 rows, got {}",
        materialized
    );
    assert!(
        materialized >= 8,
        "virtualized combo should materialize at least the visible rows, got {}",
        materialized
    );
}

#[test]
fn small_combo_materializes_every_row() {
    // The small-list path (items <= max_visible_items) must keep the
    // eager VStack build — no ListView, no virtualization — so all
    // rows are in the tree for a11y and layout.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..5).map(|i| format!("Item {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 400.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 400.0));

    let materialized = count_materialized_items(&tree, &labels);
    assert_eq!(
        materialized, 5,
        "small combo should eagerly materialize every row"
    );
}

#[test]
fn virtualized_combo_reveals_new_rows_on_scroll() {
    // Sanity: when the user scrolls the virtualized viewport, a
    // different window of rows should be materialized. Item labels
    // are unique strings, so `find_by_label` tells us which rows made
    // it into the tree before and after the scroll.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let many: Vec<String> = (0..500).map(|i| format!("Row {i}")).collect();
    let cb = tree.add(ComboBox::new(many, selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 600.0));

    // Early rows are in view, late rows are not.
    assert!(tree.find_by_label("Row 0").is_some());
    assert!(
        tree.find_by_label("Row 400").is_none(),
        "Row 400 must not be materialized before scrolling"
    );

    // Synthesize a scroll event that lands well past the viewport.
    // ListView's on_scroll handler reads `Scroll { delta }` and
    // updates its internal scroll_y, which dirty-marks the ListView
    // so the next layout rebuilds the visible range.
    let content_ids = tree.overlay_manager().active_content_ids();
    let panel_bounds = tree.bounds(content_ids[0]);
    let panel_center = teksilo_canvas::Point::new(
        panel_bounds.x + panel_bounds.width * 0.5,
        panel_bounds.y + panel_bounds.height * 0.5,
    );
    tree.pointer_move(panel_center);
    tree.dispatch_event(WidgetEvent::Scroll {
        delta: teksilo_core::event::ScrollDelta::Pixels {
            x: 0.0,
            y: 15_000.0,
        },
        modifiers: Default::default(),
    });
    // Wheel scrolling is animated; advance past the animation so the
    // offset reaches its target before the visible range is asserted.
    tree.tick_animations(std::time::Duration::from_millis(200));
    tree.layout(SizeProposal::exact(300.0, 600.0));

    assert!(
        tree.find_by_label("Row 400").is_some() || tree.find_by_label("Row 499").is_some(),
        "after scrolling, late rows should be materialized"
    );
    assert!(
        tree.find_by_label("Row 0").is_none(),
        "after scrolling far down, Row 0 should no longer be materialized"
    );
}

#[test]
fn page_up_down_scrolls_by_viewport_in_virtualized_combo() {
    // Regression: PageDown/PageUp on a virtualized (ListView-backed)
    // combo were doing nothing because ComboBox's `on_key` handler
    // only covered Arrow/Home/End/Enter/Space. Expected behavior:
    // PageDown advances selection by `max_visible_items`, PageUp
    // retreats by the same. Clamps at both ends.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..200).map(|i| format!("Row {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()).max_visible_items(8));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.focus(cb);
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 600.0));

    tree.press_key(Key::PageDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(
        selected.get().as_deref(),
        Some("Row 8"),
        "first PageDown from unselected should jump to row max_visible_items"
    );

    tree.press_key(Key::PageDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(
        selected.get().as_deref(),
        Some("Row 16"),
        "second PageDown should advance by another page"
    );

    tree.press_key(Key::PageUp, teksilo_core::event::Modifiers::NONE);
    assert_eq!(
        selected.get().as_deref(),
        Some("Row 8"),
        "PageUp should retreat by one page"
    );

    // Clamp at 0 on repeated PageUp.
    for _ in 0..5 {
        tree.press_key(Key::PageUp, teksilo_core::event::Modifiers::NONE);
    }
    assert_eq!(
        selected.get().as_deref(),
        Some("Row 0"),
        "PageUp should clamp at the first row"
    );
}

#[test]
fn scrollbar_thumb_drag_survives_midflight_rebuild() {
    // Regression: during a thumb drag, ListView rebuilds whenever the
    // scroll crosses the buffer boundary (the observer bumps a
    // `Rebuild` binding). If the scrollbar lived as a child of
    // ListView, rebuild would destroy it mid-drag, the gesture arena
    // would vanish, and subsequent PointerMove events would be
    // dropped — the user sees the thumb freeze partway down the
    // track. The fix mounts the scrollbar as a sibling of the
    // ListView so it outlives each rebuild.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..2_000).map(|i| format!("Row {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()).max_visible_items(8));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.render();

    let content_ids = tree.overlay_manager().active_content_ids();
    let panel_root = content_ids[0];
    let sb_id = find_scrollbar_like(&tree, panel_root)
        .expect("virtualized panel must expose a scrollbar sibling");
    let sb_bounds = tree.bounds(sb_id);
    let thumb_cx = sb_bounds.x + sb_bounds.width / 2.0;
    let thumb_start_y = sb_bounds.y + 4.0;

    tree.pointer_move(teksilo_canvas::Point::new(thumb_cx, thumb_start_y));
    tree.dispatch_event(WidgetEvent::PointerDown {
        position: teksilo_canvas::Point::new(thumb_cx, thumb_start_y),
        button: teksilo_core::event::PointerButton::Primary,
        modifiers: teksilo_core::event::Modifiers::NONE,
    });
    tree.dispatch_event(WidgetEvent::PointerMove {
        position: teksilo_canvas::Point::new(thumb_cx, thumb_start_y + 10.0),
    });

    // Step the drag in small increments, running layout between each
    // step to simulate the real app's per-frame layout cycle. A
    // large-enough cumulative drag crosses the buffer boundary and
    // would previously tear the scrollbar down mid-drag.
    let mut y = thumb_start_y + 10.0;
    let end_y = sb_bounds.y + sb_bounds.height - 4.0;
    let step = 20.0;
    while y + step < end_y {
        y += step;
        tree.dispatch_event(WidgetEvent::PointerMove {
            position: teksilo_canvas::Point::new(thumb_cx, y),
        });
        tree.layout(SizeProposal::exact(300.0, 600.0));
    }
    tree.dispatch_event(WidgetEvent::PointerMove {
        position: teksilo_canvas::Point::new(thumb_cx, end_y),
    });
    tree.dispatch_event(WidgetEvent::PointerUp {
        position: teksilo_canvas::Point::new(thumb_cx, end_y),
        button: teksilo_core::event::PointerButton::Primary,
        modifiers: teksilo_core::event::Modifiers::NONE,
    });
    tree.layout(SizeProposal::exact(300.0, 600.0));

    let any_late = (1900..2000).any(|i| tree.find_by_label(&format!("Row {i}")).is_some());
    let any_early = (0..100).any(|i| tree.find_by_label(&format!("Row {i}")).is_some());
    // Late rows should be visible — if the scrollbar had been torn
    // down mid-drag, scroll_y would be frozen partway through.
    assert!(
        any_late,
        "thumb drag-to-bottom should have reached the last rows"
    );
    assert!(
        !any_early,
        "after dragging to the bottom, early rows should no longer be materialized"
    );
}

#[test]
fn wheel_keeps_targeting_list_after_scroll_driven_rebuild() {
    // Regression: when the wheel scrolls the virtualized combo list
    // far enough that a rebuild destroys the hovered row under a
    // stationary cursor, the next wheel event used to fall back to
    // `focused` (the combo trigger) and bubble up to whichever
    // scrollable ancestor happened to be there (in the demo, the
    // page's `ScrollArea`). The fix: after a rebuild, re-hit-test
    // at the cached pointer position so the wheel keeps targeting
    // the item row the user is actually pointing at.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..2_000).map(|i| format!("Row {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()).max_visible_items(8));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 600.0));

    // Hover over an early row so `hovered` points inside the panel.
    let row0 = tree
        .find_by_label("Row 0")
        .expect("Row 0 should be materialized initially");
    let row0_bounds = tree.bounds(row0);
    let hover_x = row0_bounds.x + row0_bounds.width / 2.0;
    let hover_y = row0_bounds.y + row0_bounds.height / 2.0;
    tree.pointer_move(teksilo_canvas::Point::new(hover_x, hover_y));

    // Wheel-scroll enough pixels that the visible range crosses the
    // buffer boundary and the ListView rebuilds. On a 24-px-row
    // ListView with an 8-row viewport, ~16 rows is the buffer; scroll
    // past that.
    tree.dispatch_event(WidgetEvent::Scroll {
        delta: teksilo_core::event::ScrollDelta::Pixels { x: 0.0, y: 1_000.0 },
        modifiers: Default::default(),
    });
    // Wheel scrolling is animated; complete the animation before reading
    // the materialized range.
    tree.tick_animations(std::time::Duration::from_millis(200));
    tree.layout(SizeProposal::exact(300.0, 600.0));

    // The cursor never moved, but the row under it should now be a
    // different (freshly materialized) item. If the bug is present,
    // `hovered` would either be `None` or the stale/destroyed Row 0.
    // A second wheel event must reach the list and scroll it further,
    // NOT fall through to a surrounding scrollable.
    // Sample a set of "middle" rows that were NOT materialized after
    // the first wheel but WOULD be after the second (scroll total
    // 3 000 px → row ~125 visible).
    let before = materialized_range(&tree, 100..200);
    tree.dispatch_event(WidgetEvent::Scroll {
        delta: teksilo_core::event::ScrollDelta::Pixels { x: 0.0, y: 2_000.0 },
        modifiers: Default::default(),
    });
    tree.tick_animations(std::time::Duration::from_millis(200));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    let after = materialized_range(&tree, 100..200);

    assert!(
        after > before,
        "second wheel event must advance the visible range: \
         materialized rows in 100..200 before={} after={}",
        before,
        after
    );
}

fn materialized_range(tree: &WidgetTree, range: std::ops::Range<usize>) -> usize {
    range
        .filter(|i| tree.find_by_label(&format!("Row {i}")).is_some())
        .count()
}

#[test]
fn scrollbar_thumb_drag_scrolls_virtualized_combo() {
    // Regression: grabbing and dragging the scrollbar thumb in a
    // virtualized combo panel didn't move the scroll — the user could
    // only wheel or track-click. Under the hood this exercises the
    // ListView's internal ScrollBar's `on_drag` handler.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let labels: Vec<String> = (0..500).map(|i| format!("Row {i}")).collect();
    let cb = tree.add(ComboBox::new(labels.clone(), selected.clone()).max_visible_items(8));
    tree.layout(SizeProposal::exact(300.0, 600.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 600.0));
    // A render pass is needed so the ScrollBar's paint caches its
    // bounds — otherwise its thumb hit-test can't find the thumb.
    tree.render();

    // Before drag: early rows visible.
    assert!(tree.find_by_label("Row 0").is_some());
    assert!(tree.find_by_label("Row 499").is_none());

    // Find the scrollbar by walking the overlay content. It lives at
    // the far right of the ListView's viewport as the last child.
    let content_ids = tree.overlay_manager().active_content_ids();
    let panel_root = content_ids[0];
    // The virtualized panel mounts its scrollbar as a sibling of the
    // ListView (so it survives rebuilds) — the ScrollBar is the widget
    // the user actually grabs. ScrollBar widgets intentionally hide
    // themselves from AT, so `find_by_role(ScrollBar)` won't find them.
    // Instead, look for a thin narrow child by scanning for a widget
    // whose bounds width is exactly the scroll-bar thickness.
    let sb_id = find_scrollbar_like(&tree, panel_root)
        .expect("virtualized panel must expose a scrollbar sibling");
    let sb_bounds = tree.bounds(sb_id);
    assert!(
        sb_bounds.width > 0.0,
        "scrollbar should have positive width"
    );
    assert!(
        sb_bounds.height > 0.0,
        "scrollbar should have positive height"
    );

    // Press on the thumb (top of the bar), cross the drag threshold,
    // then drag down across most of the track.
    let thumb_cx = sb_bounds.x + sb_bounds.width / 2.0;
    let thumb_cy = sb_bounds.y + 4.0;
    tree.pointer_move(teksilo_canvas::Point::new(thumb_cx, thumb_cy));
    tree.dispatch_event(WidgetEvent::PointerDown {
        position: teksilo_canvas::Point::new(thumb_cx, thumb_cy),
        button: teksilo_core::event::PointerButton::Primary,
        modifiers: teksilo_core::event::Modifiers::NONE,
    });
    tree.dispatch_event(WidgetEvent::PointerMove {
        position: teksilo_canvas::Point::new(thumb_cx, thumb_cy + 10.0),
    });
    tree.dispatch_event(WidgetEvent::PointerMove {
        position: teksilo_canvas::Point::new(thumb_cx, sb_bounds.y + sb_bounds.height - 4.0),
    });
    tree.dispatch_event(WidgetEvent::PointerUp {
        position: teksilo_canvas::Point::new(thumb_cx, sb_bounds.y + sb_bounds.height - 4.0),
        button: teksilo_core::event::PointerButton::Primary,
        modifiers: teksilo_core::event::Modifiers::NONE,
    });
    tree.layout(SizeProposal::exact(300.0, 600.0));

    // After a full-track drag, late rows should be materialized.
    let row_0_still_there = tree.find_by_label("Row 0").is_some();
    let row_499_visible = tree.find_by_label("Row 499").is_some();
    assert!(
        !row_0_still_there && row_499_visible,
        "thumb drag to the bottom should scroll to the end: row_0_still_there={}, row_499_visible={}",
        row_0_still_there,
        row_499_visible
    );
}

/// Locate the `ScrollBar` inside an open combo panel. `ScrollBar`
/// sets `set_hidden()` in its a11y tree so a role scan won't find
/// it — identify it by its signature 8-px width (matches
/// `ScrollBar::new`'s default `thickness`).
fn find_scrollbar_like(tree: &WidgetTree, root: WidgetId) -> Option<WidgetId> {
    let mut stack = vec![root];
    while let Some(id) = stack.pop() {
        let b = tree.bounds(id);
        if (b.width - 8.0).abs() < 0.01 && b.height > 20.0 {
            return Some(id);
        }
        for c in tree.children(id) {
            stack.push(c);
        }
    }
    None
}

#[allow(dead_code)]
fn collect_descendants_by_role(
    tree: &WidgetTree,
    root: WidgetId,
    role: teksilo_core::accesskit::Role,
    out: &mut Vec<WidgetId>,
) {
    if tree.accessibility_node(root).role() == role {
        out.push(root);
    }
    for c in tree.children(root) {
        collect_descendants_by_role(tree, c, role, out);
    }
}

#[test]
fn render_item_closure_receives_selection_snapshot_at_build() {
    // Documents current behavior: the `bool selected` passed to
    // `render_item` reflects the selection state at the moment the
    // dropdown panel was built. It is NOT automatically re-fired when
    // the selection changes while the dropdown is open — consumers
    // that need a reactive appearance should close over a Signal and
    // bind primitives directly. See `.render_item()` rustdoc.
    use std::sync::Mutex;
    let observed: Rc<Mutex<Vec<(String, bool)>>> = Rc::new(Mutex::new(Vec::new()));

    let mut tree = light_tree();
    let selected = Signal::new(Some("Banana".to_string()));
    let items = vec!["Apple".to_string(), "Banana".to_string()];
    let obs = observed.clone();
    let cb = tree.add(
        ComboBox::from_items(items, selected.clone(), |s: &String| lit!(s.clone())).render_item(
            move |item, is_selected| {
                obs.lock().unwrap().push((item.clone(), is_selected));
                Box::new(crate::primitives::MinSize::new(10.0, 10.0))
            },
        ),
    );
    tree.layout(SizeProposal::exact(300.0, 300.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 300.0));

    let calls = observed.lock().unwrap().clone();
    assert!(
        calls.contains(&("Apple".to_string(), false)),
        "Apple row should have been rendered with selected=false; got {:?}",
        calls
    );
    assert!(
        calls.contains(&("Banana".to_string(), true)),
        "Banana row should have been rendered with selected=true; got {:?}",
        calls
    );
}

#[test]
fn custom_render_item_used() {
    use std::sync::atomic::{AtomicUsize, Ordering};
    static CALLS: AtomicUsize = AtomicUsize::new(0);
    CALLS.store(0, Ordering::SeqCst);

    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(
        ComboBox::new(fruits(), selected.clone()).render_item(|_item, _selected| {
            CALLS.fetch_add(1, Ordering::SeqCst);
            // A distinctive leaf — a small fixed rect is enough to show
            // that our closure was called instead of the default row.
            Box::new(crate::primitives::MinSize::new(10.0, 10.0))
        }),
    );
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 200.0));

    assert!(
        CALLS.load(Ordering::SeqCst) >= 3,
        "render_item should have been called at least once per item"
    );
}

// ─── Accessibility gap fixes ──────────────────────────────────────

/// Invoke `Widget::accessibility` on the widget at `id` and return the
/// resulting raw `accesskit::Node` for inspection of properties not
/// surfaced by `AccessibilityInfo` (placeholder, controls, auto_complete).
fn build_raw_a11y_node(tree: &mut WidgetTree, id: WidgetId) -> teksilo_core::accesskit::Node {
    use teksilo_core::accessibility::widget_id_to_node_id;
    let update = tree.sync_accessibility();
    let target = widget_id_to_node_id(id);
    update
        .nodes
        .into_iter()
        .find(|(node_id, _)| *node_id == target)
        .map(|(_, n)| n)
        .expect("accessibility node should be present for widget")
}

#[test]
fn accessibility_trigger_controls_popup() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    // controls() is only populated while the popup is open — the listbox node
    // is absent from the tree when closed, so pointing at it would be a
    // dangling reference that crashes VoiceOver.
    let node = build_raw_a11y_node(&mut tree, cb);
    assert!(
        node.controls().is_empty(),
        "closed combo box must not have dangling controls() reference"
    );

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));

    let node = build_raw_a11y_node(&mut tree, cb);
    assert!(
        !node.controls().is_empty(),
        "open combo box trigger should point at its listbox via aria-controls"
    );
}

#[test]
fn accessibility_placeholder_when_no_selection() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb =
        tree.add(ComboBox::new(fruits(), selected.clone()).placeholder(lit!("Select a fruit")));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    let node = build_raw_a11y_node(&mut tree, cb);
    assert_eq!(node.placeholder(), Some("Select a fruit"));
    assert_eq!(node.value(), None);
}

#[test]
fn accessibility_value_when_selection_present() {
    let mut tree = light_tree();
    let selected = Signal::new(Some("Banana".to_string()));
    let cb =
        tree.add(ComboBox::new(fruits(), selected.clone()).placeholder(lit!("Select a fruit")));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    let node = build_raw_a11y_node(&mut tree, cb);
    assert_eq!(node.value(), Some("Banana"));
    assert_eq!(node.placeholder(), None);
}

#[test]
fn render_selected_rebuilds_on_selection_and_excludes_from_a11y() {
    let mut tree = light_tree();
    let selected = Signal::new(Some("Banana".to_string()));
    let seen = Rc::new(RefCell::new(Vec::<String>::new()));
    let seen_h = seen.clone();
    let cb = tree.add(
        ComboBox::new(fruits(), selected.clone())
            .label(lit!("Fruit"))
            .render_selected(move |v: &String| {
                seen_h.borrow_mut().push(v.clone());
                Box::new(TextWidget::new(lit!(v.clone())))
            }),
    );
    tree.layout(SizeProposal::exact(300.0, 50.0));

    // The custom trigger renderer ran for the initial selection.
    assert_eq!(seen.borrow().as_slice(), &["Banana".to_string()]);

    // a11y still reports the selected value via the ComboBox node — the
    // custom trigger content is excluded from the AT tree, so it can never
    // double-announce.
    let node = build_raw_a11y_node(&mut tree, cb);
    assert_eq!(node.value(), Some("Banana"));

    // Changing the selection rebuilds the trigger with the new value.
    selected.set(Some("Cherry".to_string()));
    tree.layout(SizeProposal::exact(300.0, 50.0));
    assert_eq!(
        seen.borrow().as_slice(),
        &["Banana".to_string(), "Cherry".to_string()]
    );
}

// ─── Searchable mode ──────────────────────────────────────────────

#[test]
fn searchable_filters_list_to_matching_items() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree.add(
        ComboBox::new(
            vec!["Apple", "Banana", "Blueberry", "Cherry"],
            selected.clone(),
        )
        .search_query(query.clone()),
    );
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));

    // All four items visible initially.
    for name in ["Apple", "Banana", "Blueberry", "Cherry"] {
        assert!(
            tree.find_by_label(name).is_some(),
            "expected {name} before filtering",
        );
    }

    // Set the query to "B" — only Banana and Blueberry should remain.
    query.set("B".to_string());
    tree.layout(SizeProposal::exact(400.0, 500.0));

    assert!(
        tree.find_by_label("Apple").is_none(),
        "Apple should be filtered out"
    );
    assert!(
        tree.find_by_label("Cherry").is_none(),
        "Cherry should be filtered out"
    );
    assert!(
        tree.find_by_label("Banana").is_some(),
        "Banana should still be visible"
    );
    assert!(
        tree.find_by_label("Blueberry").is_some(),
        "Blueberry should still be visible"
    );
}

#[test]
fn searchable_custom_filter_is_consulted() {
    // Filter is called with (query, item). Route every item through
    // a closure that accepts only items whose label length equals
    // the query length — a contrived but easily-asserted predicate.
    use std::sync::atomic::{AtomicUsize, Ordering};
    static CALLS: AtomicUsize = AtomicUsize::new(0);
    CALLS.store(0, Ordering::SeqCst);

    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree.add(
        ComboBox::new(vec!["ab", "abc", "abcd"], selected.clone())
            .search_query(query.clone())
            .filter(|q, v: &String| {
                CALLS.fetch_add(1, Ordering::SeqCst);
                v.len() == q.len()
            }),
    );
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));

    query.set("xyz".to_string()); // length 3 → only "abc" matches
    tree.layout(SizeProposal::exact(400.0, 500.0));

    assert!(
        CALLS.load(Ordering::SeqCst) >= 3,
        "filter should have been called per item"
    );
    assert!(tree.find_by_label("ab").is_none());
    assert!(tree.find_by_label("abc").is_some());
    assert!(tree.find_by_label("abcd").is_none());
}

#[test]
fn accessibility_searchable_sets_autocomplete() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()).searchable(true));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    let node = build_raw_a11y_node(&mut tree, cb);
    assert_eq!(
        node.auto_complete(),
        Some(teksilo_core::accesskit::AutoComplete::List),
        "searchable combobox must expose aria-autocomplete=list",
    );
}

/// A bare focusable leaf — Tab needs somewhere to *go* before it can be said
/// to have left anything.
#[derive(Debug)]
struct FocusableLeaf;
impl teksilo_core::widget::Widget for FocusableLeaf {
    fn build(
        &mut self,
        ctx: &mut teksilo_core::build_context::BuildContext,
    ) -> Vec<teksilo_core::widget_id::WidgetId> {
        ctx.apply_self_handlers(teksilo_core::widget_builder::HandlerSet::new().focusable(true));
        vec![]
    }
    fn layout_response(
        &self,
        proposal: SizeProposal,
        _ctx: &teksilo_core::widget::LayoutContext,
    ) -> teksilo_core::widget::LayoutResponse {
        proposal.resolve(12.0, 12.0).into()
    }
}

#[test]
fn tab_dismisses_open_simple_dropdown() {
    // Non-searchable combos keep focus on the trigger itself while the dropdown
    // is open — focus is never *inside* the overlay. The framework's focus-out
    // rule still covers them because it treats an overlay's **anchor** as part
    // of its orbit; leaving the trigger is leaving the dropdown.
    //
    // Tab is no longer consumed, so one press both closes the popup and moves
    // on — a combobox is an ordinary tab stop, not a two-press detour.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry"],
        selected.clone(),
    ));
    let after = tree.add(FocusableLeaf);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::Tab, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(
        tree.active_overlays().is_empty(),
        "Tab must close the non-searchable dropdown too"
    );
    assert_eq!(
        tree.focused(),
        Some(after),
        "and the same press must move on, not park back on the trigger"
    );
}

#[test]
fn shift_tab_dismisses_open_simple_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let before = tree.add(FocusableLeaf);
    let cb = tree.add(ComboBox::new(
        vec!["Apple", "Banana", "Cherry"],
        selected.clone(),
    ));
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.focus(cb);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    tree.press_key(Key::Tab, teksilo_core::event::Modifiers::SHIFT);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    assert!(tree.active_overlays().is_empty());
    assert_eq!(tree.focused(), Some(before));
}

#[test]
fn tab_dismisses_open_searchable_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree.add(
        ComboBox::new(vec!["Apple", "Banana", "Cherry"], selected.clone())
            .search_query(query.clone()),
    );
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::Tab, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert!(
        tree.active_overlays().is_empty(),
        "Tab should dismiss the open dropdown so focus can leave the popup"
    );
}

#[test]
fn shift_tab_dismisses_open_searchable_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree.add(
        ComboBox::new(vec!["Apple", "Banana", "Cherry"], selected.clone())
            .search_query(query.clone()),
    );
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::Tab, teksilo_core::event::Modifiers::SHIFT);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert!(
        tree.active_overlays().is_empty(),
        "Shift+Tab should also dismiss the open dropdown"
    );
}

#[test]
fn arrow_keys_navigate_filtered_list_from_search() {
    // Regression: while typing in the search field, ArrowDown /
    // ArrowUp must advance the selection through the currently
    // filtered items. Previously the arrow handling lived only on
    // the combo trigger, so bubble events from the search input
    // fell through the framework without moving the highlight.
    //
    // Home / End are deliberately NOT asserted here: `TextInput`
    // consumes them for caret-to-start / caret-to-end, which is
    // the expected text-field behavior.
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree.add(
        ComboBox::new(
            vec!["Apple", "Banana", "Blueberry", "Cherry"],
            selected.clone(),
        )
        .search_query(query.clone()),
    );
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));

    // Narrow the filter to just the B-items, then navigate.
    query.set("B".to_string());
    tree.layout(SizeProposal::exact(400.0, 500.0));

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Blueberry"));

    tree.press_key(Key::ArrowUp, teksilo_core::event::Modifiers::NONE);
    assert_eq!(selected.get().as_deref(), Some("Banana"));
}

#[test]
fn enter_from_search_field_closes_dropdown() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree
        .add(ComboBox::new(vec!["Apple", "Banana"], selected.clone()).search_query(query.clone()));
    tree.layout(SizeProposal::exact(400.0, 500.0));
    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert_eq!(tree.active_overlays().len(), 1);

    tree.press_key(Key::Enter, teksilo_core::event::Modifiers::NONE);
    tree.layout(SizeProposal::exact(400.0, 500.0));
    assert!(
        tree.active_overlays().is_empty(),
        "Enter from the search field should close the dropdown"
    );
}

#[test]
fn searchable_opens_with_focus_in_search_field() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let query = Signal::new(String::new());
    let cb = tree
        .add(ComboBox::new(vec!["Apple", "Banana"], selected.clone()).search_query(query.clone()));
    tree.layout(SizeProposal::exact(400.0, 500.0));

    tree.click(cb);
    tree.layout(SizeProposal::exact(400.0, 500.0));

    let focused = tree
        .focused()
        .expect("something inside the dropdown should be focused after open");
    assert_ne!(focused, cb, "focus must leave the combo trigger");
    // The focused widget should be inside the overlay content subtree.
    let overlay_root = tree.overlay_manager().active_content_ids()[0];
    let mut cur = Some(focused);
    let mut in_overlay = false;
    while let Some(id) = cur {
        if id == overlay_root {
            in_overlay = true;
            break;
        }
        cur = tree.parent(id);
    }
    assert!(
        in_overlay,
        "focused widget should be inside the dropdown panel"
    );
}

#[test]
fn accessibility_non_searchable_omits_autocomplete() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let cb = tree.add(ComboBox::new(fruits(), selected.clone()));
    tree.layout(SizeProposal::exact(300.0, 200.0));

    let node = build_raw_a11y_node(&mut tree, cb);
    assert_eq!(
        node.auto_complete(),
        None,
        "non-searchable combobox must not advertise autocomplete",
    );
}

// ─── on_select callback ───────────────────────────────────────────

#[test]
fn on_select_fires_once_on_keyboard_pick() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let picks = Rc::new(RefCell::new(Vec::<String>::new()));
    let picks_h = picks.clone();
    let cb = tree.add(
        ComboBox::new(fruits(), selected.clone())
            .on_select(move |v: &String, _ctx| picks_h.borrow_mut().push(v.clone())),
    );
    tree.layout(SizeProposal::exact(300.0, 50.0));
    tree.focus(cb);

    tree.press_key(Key::ArrowDown, teksilo_core::event::Modifiers::NONE);

    assert_eq!(selected.get().as_deref(), Some("Banana"));
    assert_eq!(
        *picks.borrow(),
        vec!["Banana".to_string()],
        "keyboard pick must fire on_select exactly once with the chosen value"
    );
}

#[test]
fn on_select_fires_once_on_row_tap() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let picks = Rc::new(RefCell::new(Vec::<String>::new()));
    let picks_h = picks.clone();
    let cb = tree.add(
        ComboBox::new(fruits(), selected.clone())
            .on_select(move |v: &String, _ctx| picks_h.borrow_mut().push(v.clone())),
    );
    tree.layout(SizeProposal::exact(300.0, 200.0));

    // Open the dropdown, then tap the first row (Apple).
    tree.click(cb);
    tree.layout(SizeProposal::exact(300.0, 200.0));
    let row = tree
        .find_by_role(teksilo_core::accesskit::Role::ListBoxOption)
        .expect("an open dropdown should expose a ListBoxOption row");
    tree.click(row);

    assert_eq!(selected.get().as_deref(), Some("Apple"));
    assert_eq!(
        *picks.borrow(),
        vec!["Apple".to_string()],
        "row tap must fire on_select exactly once with the tapped value"
    );
}

#[test]
fn on_select_not_fired_on_external_signal_write() {
    let mut tree = light_tree();
    let selected = Signal::new(None::<String>);
    let picks = Rc::new(RefCell::new(Vec::<String>::new()));
    let picks_h = picks.clone();
    let _cb = tree.add(
        ComboBox::new(fruits(), selected.clone())
            .on_select(move |v: &String, _ctx| picks_h.borrow_mut().push(v.clone())),
    );
    tree.layout(SizeProposal::exact(300.0, 50.0));

    // Programmatic write to the bound signal is NOT a user commit.
    selected.set(Some("Cherry".to_string()));
    tree.layout(SizeProposal::exact(300.0, 50.0));

    assert!(
        picks.borrow().is_empty(),
        "on_select must fire only on user-driven commits, not external signal writes"
    );
}