teamy-figue 2.0.1

//! Parser that converts `ConfigValue` trees into `ParseEvent` streams for deserialization.
//!
//! This allows us to deserialize `ConfigValue` into arbitrary Facet types using the
//! standard `facet-format` deserializer infrastructure.

use std::vec::Vec;

use facet_core::{Facet, Shape, Type, UserType};
// Note: Shape is still used by fill_defaults_from_shape and coerce_types_from_shape
use facet_format::{
    ContainerKind, FieldKey, FieldLocationHint, FormatDeserializer, FormatParser, ParseError,
    ParseEvent, ParseEventKind, SavePoint, ScalarValue,
};
use facet_reflect::Span;
use indexmap::IndexMap;

use crate::config_value::{ConfigValue, Sourced};
use crate::provenance::Provenance;

/// Deserialize a `ConfigValue` into a Facet type.
///
/// This is the main entry point for converting merged configuration values
/// into strongly-typed structs.
///
/// # Example
///
/// ```ignore
/// use figue::config_value::ConfigValue;
/// use figue::config_value_parser::from_config_value;
///
/// #[derive(facet::Facet)]
/// struct Config {
///     port: u16,
///     host: String,
/// }
///
/// let config_value = /* ... merged from CLI/env/file ... */;
/// let config: Config = from_config_value(&config_value)?;
/// ```
pub fn from_config_value<T>(value: &ConfigValue) -> Result<T, ConfigValueDeserializeError>
where
    T: Facet<'static>,
{
    tracing::trace!(
        shape = T::SHAPE.type_identifier,
        ?value,
        "from_config_value: starting"
    );

    // First, fill in defaults for missing fields based on the target shape
    let value_with_defaults = fill_defaults_from_shape(value, T::SHAPE);
    tracing::trace!(
        ?value_with_defaults,
        "from_config_value: after fill_defaults_from_shape"
    );

    // Coerce string values to their target types (CLI/env values come in as strings)
    let value_coerced = crate::reflection::coerce_types_from_shape(&value_with_defaults, T::SHAPE);
    tracing::trace!(
        ?value_coerced,
        "from_config_value: after coerce_types_from_shape"
    );

    let mut parser = ConfigValueParser::new(&value_coerced);
    let mut deserializer = FormatDeserializer::new_owned(&mut parser);
    deserializer
        .deserialize()
        .map_err(ConfigValueDeserializeError::Deserialize)
}

/// Walk the shape and insert default values for missing fields in the ConfigValue tree.
/// This allows proper provenance tracking (defaults are marked as coming from Default).
pub(crate) fn fill_defaults_from_shape(value: &ConfigValue, shape: &'static Shape) -> ConfigValue {
    fill_defaults_from_shape_recursive(value, shape, "")
}

// ============================================================================
// Schema-based default filling (cleaner approach that reuses Schema's
// pre-computed field information for flatten, Option, etc.)
// ============================================================================

use crate::schema::{
    ArgLevelSchema, ConfigEnumSchema, ConfigStructSchema, ConfigValueSchema, Schema, Subcommand,
    ValueSchema,
};

/// Walk the schema and insert default values for missing fields in the ConfigValue tree.
/// This is the schema-based approach that reuses the Schema's pre-computed field information.
pub(crate) fn fill_defaults_from_schema(value: &ConfigValue, schema: &Schema) -> ConfigValue {
    let ConfigValue::Object(sourced) = value else {
        return value.clone();
    };

    let mut new_map = sourced.value.clone();

    // Fill defaults for args-level fields (already flattened in schema.args())
    fill_defaults_from_arg_level(&mut new_map, schema.args(), "");

    // Fill defaults for config field if present
    if let Some(config_schema) = schema.config() {
        let config_field_name = config_schema.field_name().unwrap_or("config").to_string();

        if let Some(config_value) = new_map.get(&config_field_name) {
            let filled = fill_defaults_from_config_struct(config_value, config_schema, "");
            new_map.insert(config_field_name, filled);
        } else {
            // Config field missing - create it with defaults
            let filled = fill_defaults_from_config_struct(
                &ConfigValue::Object(Sourced::new(IndexMap::default())),
                config_schema,
                "",
            );
            new_map.insert(config_field_name, filled);
        }
    }

    ConfigValue::Object(Sourced {
        value: new_map,
        span: sourced.span,
        provenance: sourced.provenance.clone(),
    })
}

/// Fill defaults for args-level fields based on ArgLevelSchema.
fn fill_defaults_from_arg_level(
    map: &mut IndexMap<String, ConfigValue, std::hash::RandomState>,
    arg_level: &ArgLevelSchema,
    path_prefix: &str,
) {
    // The schema's args() already has flattened fields at the right level
    for (field_name, arg_schema) in arg_level.args() {
        if !map.contains_key(field_name) {
            // First check for explicit default from #[facet(default)] stored in schema
            if let Some(explicit_default) = arg_schema.default() {
                tracing::trace!(
                    field = field_name,
                    ?explicit_default,
                    "fill_defaults_from_arg_level: inserting explicit default for missing field"
                );
                map.insert(field_name.clone(), explicit_default.clone());
            } else if let Some(implicit_default) =
                get_default_from_value_schema(arg_schema.value(), path_prefix)
            {
                // Fall back to implicit defaults (Option → null, bool → false, struct → empty object)
                tracing::trace!(
                    field = field_name,
                    ?implicit_default,
                    "fill_defaults_from_arg_level: inserting implicit default for missing field"
                );
                map.insert(field_name.clone(), implicit_default);
            }
        }
    }

    // Handle subcommand fields - if present, fill defaults in the variant's args
    if let Some(subcommand_field_name) = arg_level.subcommand_field_name()
        && let Some(ConfigValue::Enum(enum_sourced)) = map.get(subcommand_field_name)
        && let Some(subcommand) = arg_level.subcommands().get(&enum_sourced.value.variant)
    {
        let mut new_fields = enum_sourced.value.fields.clone();

        // Fill defaults for the subcommand's args (which may include flattened tuple args)
        fill_defaults_from_subcommand(&mut new_fields, subcommand, path_prefix);

        let new_enum = ConfigValue::Enum(Sourced {
            value: crate::config_value::EnumValue {
                variant: enum_sourced.value.variant.clone(),
                fields: new_fields,
            },
            span: enum_sourced.span,
            provenance: enum_sourced.provenance.clone(),
        });
        map.insert(subcommand_field_name.to_string(), new_enum);
    }

    // Recursively fill defaults in nested arg values
    for (field_name, arg_schema) in arg_level.args() {
        if let Some(val) = map.get(field_name) {
            let field_path = if path_prefix.is_empty() {
                field_name.clone()
            } else {
                format!("{}.{}", path_prefix, field_name)
            };
            let filled = fill_defaults_from_value_schema(val, arg_schema.value(), &field_path);
            map.insert(field_name.clone(), filled);
        }
    }
}

/// Fill defaults for a subcommand variant based on its ArgLevelSchema.
fn fill_defaults_from_subcommand(
    fields: &mut IndexMap<String, ConfigValue, std::hash::RandomState>,
    subcommand: &Subcommand,
    path_prefix: &str,
) {
    // Fill defaults for the subcommand's args (already flattened)
    for (arg_name, arg_schema) in subcommand.args().args() {
        if !fields.contains_key(arg_name) {
            // First check for explicit default from #[facet(default)] stored in schema
            if let Some(explicit_default) = arg_schema.default() {
                fields.insert(arg_name.clone(), explicit_default.clone());
            } else if let Some(implicit_default) =
                get_default_from_value_schema(arg_schema.value(), path_prefix)
            {
                // Fall back to implicit defaults
                fields.insert(arg_name.clone(), implicit_default);
            }
        }
    }

    // Recursively process nested subcommands if any
    if subcommand.args().has_subcommands()
        && let Some(nested_subcommand_field) = subcommand.args().subcommand_field_name()
        && let Some(ConfigValue::Enum(enum_sourced)) = fields.get(nested_subcommand_field)
        && let Some(nested_subcommand) = subcommand
            .args()
            .subcommands()
            .get(&enum_sourced.value.variant)
    {
        let mut new_fields = enum_sourced.value.fields.clone();
        fill_defaults_from_subcommand(&mut new_fields, nested_subcommand, path_prefix);

        let new_enum = ConfigValue::Enum(Sourced {
            value: crate::config_value::EnumValue {
                variant: enum_sourced.value.variant.clone(),
                fields: new_fields,
            },
            span: enum_sourced.span,
            provenance: enum_sourced.provenance.clone(),
        });
        fields.insert(nested_subcommand_field.to_string(), new_enum);
    }

    // Recursively fill defaults in nested arg values
    for (arg_name, arg_schema) in subcommand.args().args() {
        if let Some(val) = fields.get(arg_name) {
            let field_path = if path_prefix.is_empty() {
                arg_name.clone()
            } else {
                format!("{}.{}", path_prefix, arg_name)
            };
            let filled = fill_defaults_from_value_schema(val, arg_schema.value(), &field_path);
            fields.insert(arg_name.clone(), filled);
        }
    }
}

/// Fill defaults based on ValueSchema (used for arg-level values).
fn fill_defaults_from_value_schema(
    value: &ConfigValue,
    schema: &ValueSchema,
    path_prefix: &str,
) -> ConfigValue {
    match schema {
        ValueSchema::Option { value: inner, .. } => {
            fill_defaults_from_value_schema(value, inner, path_prefix)
        }
        ValueSchema::Vec { element, .. } => {
            if let ConfigValue::Array(sourced) = value {
                let items: Vec<_> = sourced
                    .value
                    .iter()
                    .map(|item| fill_defaults_from_value_schema(item, element, path_prefix))
                    .collect();
                ConfigValue::Array(Sourced {
                    value: items,
                    span: sourced.span,
                    provenance: sourced.provenance.clone(),
                })
            } else {
                value.clone()
            }
        }
        ValueSchema::Struct { fields, .. } => {
            fill_defaults_from_config_struct(value, fields, path_prefix)
        }
        ValueSchema::Leaf(_) => value.clone(),
    }
}

/// Get a default ConfigValue based on ValueSchema.
///
/// This provides implicit CLI-friendly defaults only:
/// - Option<T> → null (implicit None)
/// - Struct → empty object (for recursive filling)
/// - bool → false (CLI flags default to off)
///
/// Note: Field-level `#[facet(default)]` attributes are not accessible from the Schema,
/// so those defaults are handled by facet's deserializer, not here.
/// We do NOT fill integers with 0 here because fields may have explicit defaults.
fn get_default_from_value_schema(schema: &ValueSchema, _path_prefix: &str) -> Option<ConfigValue> {
    match schema {
        ValueSchema::Option { .. } => {
            // Don't fill Option fields - let facet handle the default
            // Fields may have #[facet(default)] that we can't see from the Schema
            None
        }
        ValueSchema::Vec { .. } => {
            // Vec without explicit default - don't provide one
            None
        }
        ValueSchema::Struct { .. } => {
            // Create empty object for recursive filling
            Some(ConfigValue::Object(Sourced {
                value: IndexMap::default(),
                span: None,
                provenance: Some(Provenance::Default),
            }))
        }
        ValueSchema::Leaf(leaf) => {
            let shape = leaf.shape;

            // Only provide implicit default for bool (CLI flags default to off)
            // We don't fill integers because fields may have explicit #[facet(default = N)]
            // that we can't see from the Schema
            use facet_core::ScalarType;
            if let Some(ScalarType::Bool) = shape.scalar_type() {
                return Some(ConfigValue::Bool(Sourced {
                    value: false,
                    span: None,
                    provenance: Some(Provenance::Default),
                }));
            }

            None
        }
    }
}

/// Fill defaults for a struct based on ConfigStructSchema.
/// The schema already has flattened fields at the right level.
fn fill_defaults_from_config_struct(
    value: &ConfigValue,
    struct_schema: &ConfigStructSchema,
    path_prefix: &str,
) -> ConfigValue {
    let ConfigValue::Object(sourced) = value else {
        return value.clone();
    };

    let mut new_map = sourced.value.clone();

    // The schema's fields() already has flattened fields merged in at the right level
    for (field_name, field_schema) in struct_schema.fields() {
        if !new_map.contains_key(field_name) {
            // First check for explicit default from #[facet(default)] stored in schema
            if let Some(explicit_default) = field_schema.default() {
                tracing::trace!(
                    field = field_name,
                    ?explicit_default,
                    "fill_defaults_from_config_struct: inserting explicit default for missing field"
                );
                new_map.insert(field_name.clone(), explicit_default.clone());
            } else if let Some(implicit_default) =
                get_default_from_config_value_schema(&field_schema.value, path_prefix)
            {
                // Fall back to implicit defaults (struct → empty object, bool → false)
                tracing::trace!(
                    field = field_name,
                    ?implicit_default,
                    "fill_defaults_from_config_struct: inserting implicit default for missing field"
                );
                new_map.insert(field_name.clone(), implicit_default);
            }
        }
    }

    // Recursively process nested values
    for (key, val) in new_map.iter_mut() {
        if let Some(field_schema) = struct_schema.fields().get(key) {
            let field_path = if path_prefix.is_empty() {
                key.clone()
            } else {
                format!("{}.{}", path_prefix, key)
            };
            *val = fill_defaults_from_config_value_schema(val, &field_schema.value, &field_path);
        }
    }

    ConfigValue::Object(Sourced {
        value: new_map,
        span: sourced.span,
        provenance: sourced.provenance.clone(),
    })
}

/// Fill defaults for a value based on ConfigValueSchema.
fn fill_defaults_from_config_value_schema(
    value: &ConfigValue,
    schema: &ConfigValueSchema,
    path_prefix: &str,
) -> ConfigValue {
    match schema {
        ConfigValueSchema::Option { value: inner, .. } => {
            // For Option types, recurse with the inner schema
            fill_defaults_from_config_value_schema(value, inner, path_prefix)
        }
        ConfigValueSchema::Struct(struct_schema) => {
            fill_defaults_from_config_struct(value, struct_schema, path_prefix)
        }
        ConfigValueSchema::Vec(vec_schema) => {
            // Arrays: recursively process elements
            if let ConfigValue::Array(sourced) = value {
                let items: Vec<_> = sourced
                    .value
                    .iter()
                    .map(|item| {
                        fill_defaults_from_config_value_schema(
                            item,
                            vec_schema.element(),
                            path_prefix,
                        )
                    })
                    .collect();
                ConfigValue::Array(Sourced {
                    value: items,
                    span: sourced.span,
                    provenance: sourced.provenance.clone(),
                })
            } else {
                value.clone()
            }
        }
        ConfigValueSchema::Enum(enum_schema) => {
            fill_defaults_from_config_enum(value, enum_schema, path_prefix)
        }
        ConfigValueSchema::Leaf(_) => {
            // Leaf values don't have nested structure to fill
            value.clone()
        }
    }
}

/// Fill defaults for an enum value based on ConfigEnumSchema.
fn fill_defaults_from_config_enum(
    value: &ConfigValue,
    enum_schema: &ConfigEnumSchema,
    path_prefix: &str,
) -> ConfigValue {
    let ConfigValue::Enum(sourced) = value else {
        return value.clone();
    };

    // Find the variant in the schema
    let Some(variant_schema) = enum_schema.get_variant(&sourced.value.variant) else {
        return value.clone();
    };

    // Fill defaults in the variant's fields
    let mut new_fields = sourced.value.fields.clone();

    // The schema's variant fields already have flattened fields merged in
    for (field_name, field_schema) in variant_schema.fields() {
        if !new_fields.contains_key(field_name) {
            // First check for explicit default from #[facet(default)] stored in schema
            if let Some(explicit_default) = field_schema.default() {
                new_fields.insert(field_name.clone(), explicit_default.clone());
            } else {
                // Fall back to implicit defaults
                let field_path = if path_prefix.is_empty() {
                    field_name.clone()
                } else {
                    format!("{}.{}", path_prefix, field_name)
                };
                if let Some(implicit_default) =
                    get_default_from_config_value_schema(&field_schema.value, &field_path)
                {
                    new_fields.insert(field_name.clone(), implicit_default);
                }
            }
        }
    }

    // Recursively fill defaults in nested values
    for (key, val) in new_fields.iter_mut() {
        if let Some(field_schema) = variant_schema.fields().get(key) {
            let field_path = if path_prefix.is_empty() {
                key.clone()
            } else {
                format!("{}.{}", path_prefix, key)
            };
            *val = fill_defaults_from_config_value_schema(val, &field_schema.value, &field_path);
        }
    }

    ConfigValue::Enum(Sourced {
        value: crate::config_value::EnumValue {
            variant: sourced.value.variant.clone(),
            fields: new_fields,
        },
        span: sourced.span,
        provenance: sourced.provenance.clone(),
    })
}

/// Get a default ConfigValue based on ConfigValueSchema.
///
/// This provides implicit CLI-friendly defaults only:
/// - Struct → empty object (for recursive filling)
/// - bool → false (CLI flags default to off)
/// - integers → 0 (counted flags default to 0)
///
/// For Option types: we do NOT fill with Null here because fields may have
/// explicit `#[facet(default)]` attributes that we can't see from the Schema.
/// Leaving Option fields missing allows facet's deserializer to apply field defaults.
///
/// Note: Field-level `#[facet(default)]` attributes are not accessible from the Schema,
/// so those defaults are handled by facet's deserializer, not here.
fn get_default_from_config_value_schema(
    schema: &ConfigValueSchema,
    _path_prefix: &str,
) -> Option<ConfigValue> {
    match schema {
        ConfigValueSchema::Option { .. } => {
            // Don't fill Option fields - let facet handle the default
            // Fields may have #[facet(default)] that we can't see from the Schema
            None
        }
        ConfigValueSchema::Struct(_) => {
            // Create empty object for recursive filling
            Some(ConfigValue::Object(Sourced {
                value: IndexMap::default(),
                span: None,
                provenance: Some(Provenance::Default),
            }))
        }
        ConfigValueSchema::Vec(_) => {
            // Vec without explicit field default - don't provide one
            None
        }
        ConfigValueSchema::Enum(_) => {
            // Enums need a variant to be selected - can't provide implicit default
            None
        }
        ConfigValueSchema::Leaf(leaf_schema) => {
            let shape = leaf_schema.shape;

            // Only provide implicit default for bool
            // We don't fill integers because fields may have explicit #[facet(default = N)]
            // that we can't see from the Schema
            use facet_core::ScalarType;
            if let Some(ScalarType::Bool) = shape.scalar_type() {
                return Some(ConfigValue::Bool(Sourced {
                    value: false,
                    span: None,
                    provenance: Some(Provenance::Default),
                }));
            }

            None
        }
    }
}

fn fill_defaults_from_shape_recursive(
    value: &ConfigValue,
    shape: &'static Shape,
    path_prefix: &str,
) -> ConfigValue {
    tracing::trace!(
        shape = shape.type_identifier,
        path_prefix,
        "fill_defaults_from_shape_recursive: entering"
    );

    // Special handling for Option types: unwrap to inner type
    if let Ok(option_def) = shape.def.into_option() {
        // For Option types, if the value is an Object, recurse with the inner type
        return fill_defaults_from_shape_recursive(value, option_def.t, path_prefix);
    }

    match value {
        ConfigValue::Object(sourced) => {
            // Get struct fields from shape
            let fields = match &shape.ty {
                Type::User(UserType::Struct(s)) => &s.fields,
                _ => return value.clone(),
            };

            let mut new_map = sourced.value.clone();

            // Helper function to collect all flattened fields recursively
            fn collect_flattened_fields<'a>(
                fields: &'a [facet_core::Field],
                result: &mut Vec<&'a facet_core::Field>,
            ) {
                for field in fields.iter() {
                    if field.is_flattened() {
                        let inner_shape = field.shape.get();
                        if let Type::User(UserType::Struct(s)) = &inner_shape.ty {
                            collect_flattened_fields(s.fields, result);
                        }
                    } else {
                        result.push(field);
                    }
                }
            }

            // For each field in the struct shape, check if it's missing in the ConfigValue
            for field in fields.iter() {
                // Handle flattened fields: their inner fields should appear at the
                // CURRENT level, not nested under the field name.
                // The facet-format deserializer handles collecting them into the nested struct.
                if field.is_flattened() {
                    let inner_shape = field.shape.get();
                    let inner_fields = match &inner_shape.ty {
                        Type::User(UserType::Struct(s)) => &s.fields,
                        _ => continue, // Skip if not a struct (shouldn't happen for flatten)
                    };

                    // Collect ALL flattened fields recursively (handles flatten inside flatten)
                    let mut all_inner_fields = Vec::new();
                    collect_flattened_fields(inner_fields, &mut all_inner_fields);

                    // For each inner field, add default if missing at the CURRENT level
                    for inner_field in all_inner_fields {
                        if !new_map.contains_key(inner_field.name) {
                            let inner_path = if path_prefix.is_empty() {
                                inner_field.name.to_string()
                            } else {
                                format!("{}.{}", path_prefix, inner_field.name)
                            };
                            if let Some(default_value) =
                                get_default_config_value(inner_field, &inner_path)
                            {
                                tracing::trace!(
                                    field = inner_field.name,
                                    parent_field = field.name,
                                    shape = shape.type_identifier,
                                    ?default_value,
                                    "fill_defaults_from_shape_recursive: inserting default for flattened field"
                                );
                                new_map.insert(inner_field.name.to_string(), default_value);
                            }
                        }
                    }
                    // Don't create a nested object for flattened fields
                    continue;
                }

                if !new_map.contains_key(field.name) {
                    // Field is missing - get default or create Missing marker
                    // Returns None if the field has a default that can't be serialized -
                    // in that case we don't insert anything and let facet handle the default
                    if let Some(default_value) = get_default_config_value(field, path_prefix) {
                        tracing::trace!(
                            field = field.name,
                            shape = shape.type_identifier,
                            ?default_value,
                            "fill_defaults_from_shape_recursive: inserting default for missing field"
                        );
                        new_map.insert(field.name.to_string(), default_value);
                    } else {
                        tracing::trace!(
                            field = field.name,
                            shape = shape.type_identifier,
                            "fill_defaults_from_shape_recursive: field has unserializable default, letting facet handle it"
                        );
                    }
                }
            }

            // Recursively process nested objects
            for (key, val) in new_map.iter_mut() {
                // Find the corresponding field shape
                // First check direct (non-flattened) fields
                if let Some(field) = fields.iter().find(|f| f.name == key && !f.is_flattened()) {
                    let field_path = if path_prefix.is_empty() {
                        key.to_string()
                    } else {
                        format!("{}.{}", path_prefix, key)
                    };
                    *val = fill_defaults_from_shape_recursive(val, field.shape.get(), &field_path);
                } else {
                    // Check if key matches an inner field of a flattened struct
                    for field in fields.iter().filter(|f| f.is_flattened()) {
                        let inner_shape = field.shape.get();
                        if let Type::User(UserType::Struct(s)) = &inner_shape.ty
                            && let Some(inner_field) = s.fields.iter().find(|f| f.name == key)
                        {
                            let field_path = if path_prefix.is_empty() {
                                key.to_string()
                            } else {
                                format!("{}.{}", path_prefix, key)
                            };
                            *val = fill_defaults_from_shape_recursive(
                                val,
                                inner_field.shape.get(),
                                &field_path,
                            );
                            break;
                        }
                    }
                }
            }

            let result = ConfigValue::Object(Sourced {
                value: new_map,
                span: sourced.span,
                provenance: sourced.provenance.clone(),
            });
            tracing::trace!(
                shape = shape.type_identifier,
                "fill_defaults_from_shape: completed Object"
            );
            result
        }
        ConfigValue::Array(sourced) => {
            // Recursively process array items
            // TODO: get element shape from array def
            let items: Vec<_> = sourced.value.to_vec();

            ConfigValue::Array(Sourced {
                value: items,
                span: sourced.span,
                provenance: sourced.provenance.clone(),
            })
        }
        ConfigValue::Enum(sourced) => {
            // For enum variants, fill defaults in the variant's fields
            // First, find the variant in the enum type
            let enum_type = match &shape.ty {
                Type::User(UserType::Enum(e)) => *e,
                _ => return value.clone(),
            };

            // Find the variant by name - check effective_name since that's what ConfigValue uses
            let variant = enum_type
                .variants
                .iter()
                .find(|v| v.effective_name() == sourced.value.variant);

            let Some(variant) = variant else {
                return value.clone();
            };

            // Get the variant's fields (if any)
            let variant_fields = variant.data.fields;

            // Unit variants have no fields to fill
            if variant_fields.is_empty() {
                return value.clone();
            }

            // Helper to check if a field should be treated as flattened
            // This includes explicit #[facet(flatten)] AND tuple variant fields
            // (tuple variants like Bench(BenchArgs) have a "0" field containing a struct)
            let is_effectively_flattened = |field: &facet_core::Field| -> bool {
                if field.is_flattened() {
                    return true;
                }
                // Tuple variant: field name is a number and contains a struct
                if field.name.chars().all(|c| c.is_ascii_digit())
                    && let Type::User(UserType::Struct(_)) = &field.shape.get().ty
                {
                    return true;
                }
                false
            };

            // Create a new fields map with defaults filled in
            let mut new_fields = sourced.value.fields.clone();

            // Helper function to collect all flattened fields recursively
            fn collect_flattened_fields_enum<'a>(
                fields: &'a [facet_core::Field],
                result: &mut Vec<&'a facet_core::Field>,
                is_effectively_flattened: &impl Fn(&facet_core::Field) -> bool,
            ) {
                for field in fields.iter() {
                    if is_effectively_flattened(field) {
                        let inner_shape = field.shape.get();
                        if let Type::User(UserType::Struct(s)) = &inner_shape.ty {
                            collect_flattened_fields_enum(
                                s.fields,
                                result,
                                is_effectively_flattened,
                            );
                        }
                    } else if field.is_flattened() {
                        // Regular flatten (not tuple variant)
                        let inner_shape = field.shape.get();
                        if let Type::User(UserType::Struct(s)) = &inner_shape.ty {
                            collect_flattened_fields_enum(
                                s.fields,
                                result,
                                is_effectively_flattened,
                            );
                        }
                    } else {
                        result.push(field);
                    }
                }
            }

            for field in variant_fields.iter() {
                // Handle flattened fields: their inner fields appear at the CURRENT level
                if is_effectively_flattened(field) {
                    let inner_shape = field.shape.get();
                    if let Type::User(UserType::Struct(s)) = &inner_shape.ty {
                        // Collect ALL flattened fields recursively
                        let mut all_inner_fields = Vec::new();
                        collect_flattened_fields_enum(
                            s.fields,
                            &mut all_inner_fields,
                            &is_effectively_flattened,
                        );

                        for inner_field in all_inner_fields {
                            if !new_fields.contains_key(inner_field.name) {
                                let field_path = if path_prefix.is_empty() {
                                    inner_field.name.to_string()
                                } else {
                                    format!("{}.{}", path_prefix, inner_field.name)
                                };
                                if let Some(default_value) =
                                    get_default_config_value(inner_field, &field_path)
                                {
                                    new_fields.insert(inner_field.name.to_string(), default_value);
                                }
                            }
                        }
                    }
                    continue;
                }

                if !new_fields.contains_key(field.name) {
                    let field_path = if path_prefix.is_empty() {
                        field.name.to_string()
                    } else {
                        format!("{}.{}", path_prefix, field.name)
                    };
                    if let Some(default_value) = get_default_config_value(field, &field_path) {
                        new_fields.insert(field.name.to_string(), default_value);
                    }
                }
            }

            // Recursively fill defaults in nested values
            for (key, val) in new_fields.iter_mut() {
                // First check non-flattened fields
                if let Some(field) = variant_fields
                    .iter()
                    .find(|f| f.name == key && !is_effectively_flattened(f))
                {
                    let field_path = if path_prefix.is_empty() {
                        key.to_string()
                    } else {
                        format!("{}.{}", path_prefix, key)
                    };
                    *val = fill_defaults_from_shape_recursive(val, field.shape.get(), &field_path);
                } else {
                    // Check if key matches an inner field of a flattened struct
                    for field in variant_fields
                        .iter()
                        .filter(|f| is_effectively_flattened(f))
                    {
                        let inner_shape = field.shape.get();
                        if let Type::User(UserType::Struct(s)) = &inner_shape.ty
                            && let Some(inner_field) = s.fields.iter().find(|f| f.name == key)
                        {
                            let field_path = if path_prefix.is_empty() {
                                key.to_string()
                            } else {
                                format!("{}.{}", path_prefix, key)
                            };
                            *val = fill_defaults_from_shape_recursive(
                                val,
                                inner_field.shape.get(),
                                &field_path,
                            );
                            break;
                        }
                    }
                }
            }

            ConfigValue::Enum(Sourced {
                value: crate::config_value::EnumValue {
                    variant: sourced.value.variant.clone(),
                    fields: new_fields,
                },
                span: sourced.span,
                provenance: sourced.provenance.clone(),
            })
        }
        _ => value.clone(),
    }
}

/// Get a default ConfigValue for a field.
///
/// For fields with #[facet(default)], calls the default function and serializes to ConfigValue.
/// For Option<T> types, provides None (null) as implicit default.
/// For scalar fields without defaults, provides CLI-friendly defaults (false/0).
/// For struct fields without defaults, creates an empty Object for recursive filling.
/// For required fields without defaults, returns ConfigValue::Missing with field info.
///
/// Returns None when the field has a default but it can't be serialized to ConfigValue.
/// In that case, the caller should skip inserting the field and let facet's deserializer
/// apply the field's default function directly.
fn get_default_config_value(
    field: &'static facet_core::Field,
    _path_prefix: &str,
) -> Option<ConfigValue> {
    use facet_core::ScalarType;

    let shape = field.shape.get();

    // If field has explicit default, invoke it and serialize to ConfigValue
    if let Some(default_source) = &field.default {
        tracing::trace!(
            field = field.name,
            "get_default_config_value: field has default, invoking"
        );

        if let Ok(config_value) = serialize_default_to_config_value(default_source, shape) {
            // Check if serialization actually produced a useful value
            // (not null for non-nullable types)
            if !matches!(config_value, ConfigValue::Null(_)) {
                tracing::trace!(
                    field = field.name,
                    ?config_value,
                    "get_default_config_value: successfully serialized default"
                );
                return Some(config_value);
            }
            // Null result for a type that has a default but can't serialize -
            // fall through to let facet handle the default during deserialization
            tracing::trace!(
                field = field.name,
                "get_default_config_value: serialized to null, letting facet handle default"
            );
        } else {
            // Serialization failed - the type has a default but can't be represented
            // as ConfigValue. Let facet handle it during deserialization.
            tracing::trace!(
                field = field.name,
                "get_default_config_value: serialization failed, letting facet handle default"
            );
        }
        // The field has a default but we can't represent it as ConfigValue.
        // Return None so the caller skips inserting this field, letting facet's
        // deserializer apply the field's default function.
        return None;
    }

    // Option<T> implicitly has Default semantics (None)
    // Check type_identifier for "Option" - handles both std::option::Option and core::option::Option
    if shape.type_identifier.contains("Option") {
        return Some(ConfigValue::Null(Sourced {
            value: (),
            span: None,
            provenance: Some(Provenance::Default),
        }));
    }

    // For struct types without explicit defaults, create empty object for recursive filling
    if let Type::User(UserType::Struct(_)) = &shape.ty {
        return Some(ConfigValue::Object(Sourced {
            value: IndexMap::default(),
            span: None,
            provenance: Some(Provenance::Default),
        }));
    }

    // For scalar types without explicit defaults, emit CLI-friendly defaults
    if let Some(scalar_type) = shape.scalar_type() {
        return Some(match scalar_type {
            ScalarType::Bool => ConfigValue::Bool(Sourced {
                value: false,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarType::U8
            | ScalarType::U16
            | ScalarType::U32
            | ScalarType::U64
            | ScalarType::U128
            | ScalarType::USize
            | ScalarType::I8
            | ScalarType::I16
            | ScalarType::I32
            | ScalarType::I64
            | ScalarType::I128
            | ScalarType::ISize => ConfigValue::Integer(Sourced {
                value: 0,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            _ => {
                // No sensible default for other scalar types - don't fill
                return None;
            }
        });
    }

    // No default available - don't fill, let schema-driven logic handle missing fields
    None
}

/// Serialize a default value to ConfigValue by invoking the default function
/// and using a ConfigValueSerializer.
///
/// This is used both during schema building (to pre-compute field defaults) and
/// during default-filling (for Shape-based code paths).
#[allow(unsafe_code)]
pub(crate) fn serialize_default_to_config_value(
    default_source: &facet_core::DefaultSource,
    shape: &'static facet_core::Shape,
) -> Result<ConfigValue, String> {
    use facet_core::{DefaultSource, TypeOps};

    // Allocate space for the default value
    let mut storage: [u8; 1024] = [0; 1024]; // Stack buffer for small types
    let ptr = storage.as_mut_ptr() as *mut ();

    // Call the appropriate default function to initialize the value
    match default_source {
        DefaultSource::FromTrait => {
            // Get default_in_place from type_ops
            let type_ops = shape
                .type_ops
                .ok_or_else(|| format!("Shape {} has no type_ops", shape.type_identifier))?;

            match type_ops {
                TypeOps::Direct(ops) => {
                    let default_fn = ops.default_in_place.ok_or_else(|| {
                        format!("Shape {} has no default function", shape.type_identifier)
                    })?;
                    // Direct ops default: unsafe fn(*mut ()) - initializes in place, no return value
                    unsafe { default_fn(ptr) };
                }
                TypeOps::Indirect(_) => {
                    Err(
                        "Indirect type ops not yet supported for default serialization".to_string(),
                    )?;
                }
            }
        }
        DefaultSource::Custom(fn_ptr) => {
            // Custom default: unsafe fn(PtrUninit) -> PtrMut
            unsafe {
                let ptr_uninit = facet_core::PtrUninit::new_sized(ptr);
                (*fn_ptr)(ptr_uninit);
            }
        }
    }

    // Create a Peek from the initialized value
    let peek = unsafe {
        let ptr_const = facet_core::PtrConst::new_sized(ptr as *const ());
        facet_reflect::Peek::unchecked_new(ptr_const, shape)
    };

    // Serialize to ConfigValue using our serializer
    let mut serializer = ConfigValueSerializer::new();
    facet_format::serialize_root(&mut serializer, peek)
        .map_err(|e| format!("Serialization failed: {:?}", e))?;

    let result = serializer.finish();

    // If serialization returned Null but the type has Display, use the string representation.
    // This handles opaque types like IpAddr, PathBuf, etc. that don't serialize natively
    // but can be represented as strings for CLI/env/config purposes.
    if matches!(result, ConfigValue::Null(_)) && shape.vtable.has_display() {
        let string_value = peek.to_string();
        return Ok(ConfigValue::String(Sourced {
            value: string_value,
            span: None,
            provenance: Some(Provenance::Default),
        }));
    }

    Ok(result)
}

/// Errors that can occur during ConfigValue deserialization.
#[derive(Debug)]
pub enum ConfigValueDeserializeError {
    /// Error during deserialization.
    Deserialize(facet_format::DeserializeError),
}

impl core::fmt::Display for ConfigValueDeserializeError {
    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
        match self {
            ConfigValueDeserializeError::Deserialize(e) => {
                // Format kind, and add nicely-formatted path if present
                write!(f, "{}", e.kind)?;
                if let Some(ref path) = e.path
                    && !path.is_empty()
                {
                    write!(f, " at {}", path)?;
                }
                Ok(())
            }
        }
    }
}

impl core::error::Error for ConfigValueDeserializeError {
    fn source(&self) -> Option<&(dyn core::error::Error + 'static)> {
        match self {
            ConfigValueDeserializeError::Deserialize(e) => Some(e),
        }
    }
}

impl ConfigValueDeserializeError {
    /// Get the span associated with this error, if any.
    pub fn span(&self) -> Option<facet_reflect::Span> {
        match self {
            ConfigValueDeserializeError::Deserialize(e) => e.span,
        }
    }
}

/// Parser that emits events from a `ConfigValue` tree.
///
/// This is a simple parser that just emits what's in the ConfigValue.
/// It does NOT do any Shape-based transformations - that's the deserializer's job.
#[derive(Clone)]
pub struct ConfigValueParser<'input> {
    /// Stack of values to process.
    stack: Vec<StackFrame<'input>>,
    /// The most recent span (for error reporting).
    last_span: Option<Span>,
    /// Peeked event (cached for peek_event).
    peeked: Option<ParseEvent<'input>>,
    /// Saved parser state for save/restore.
    saved_state: Option<Box<ConfigValueParser<'input>>>,
}

/// A frame on the parsing stack.
#[derive(Clone)]
enum StackFrame<'input> {
    /// Processing an object - emit key-value pairs.
    Object {
        entries: Vec<(&'input str, &'input ConfigValue)>,
        index: usize,
    },
    /// Processing an array - emit items in sequence.
    Array {
        items: &'input [ConfigValue],
        index: usize,
    },
    /// A single value to emit.
    Value(&'input ConfigValue),
    /// Processing an enum variant - externally tagged format: {"VariantName": {...}}
    /// Phase 0: emit FieldKey with variant name
    /// Phase 1: emit variant content (struct with fields, or Unit for unit variants)
    /// Phase 2: emit StructEnd
    Enum {
        variant: &'input str,
        fields: Vec<(&'input str, &'input ConfigValue)>,
        phase: u8,
        /// Whether this is a unit variant (no fields) vs struct/tuple variant
        is_unit: bool,
    },
}

impl<'input> ConfigValueParser<'input> {
    /// Create a new parser from a `ConfigValue`.
    pub fn new(value: &'input ConfigValue) -> Self {
        Self {
            stack: vec![StackFrame::Value(value)],
            last_span: None,
            peeked: None,
            saved_state: None,
        }
    }

    /// Update the last span from a `Sourced` wrapper.
    fn update_span<T>(&mut self, sourced: &Sourced<T>) {
        if let Some(span) = sourced.span {
            self.last_span = Some(span);
        }
    }
}

impl<'input> FormatParser<'input> for ConfigValueParser<'input> {
    fn next_event(&mut self) -> Result<Option<ParseEvent<'input>>, ParseError> {
        // If we have a peeked event, return it
        if let Some(event) = self.peeked.take() {
            return Ok(Some(event));
        }

        loop {
            let frame = match self.stack.pop() {
                Some(f) => f,
                None => return Ok(None), // Done
            };

            match frame {
                StackFrame::Value(value) => {
                    return Ok(Some(self.emit_value(value)));
                }
                StackFrame::Object { entries, index } => {
                    if index < entries.len() {
                        // Emit the next key-value pair
                        let (key, value) = entries[index];

                        // Push continuation for next entry
                        self.stack.push(StackFrame::Object {
                            entries: entries.clone(),
                            index: index + 1,
                        });

                        // Push value to process after key
                        self.stack.push(StackFrame::Value(value));

                        // Emit key as-is (no Shape-based translation)
                        return Ok(Some(self.event(ParseEventKind::FieldKey(FieldKey::new(
                            key,
                            FieldLocationHint::KeyValue,
                        )))));
                    } else {
                        // Object entries done
                        return Ok(Some(self.event(ParseEventKind::StructEnd)));
                    }
                }
                StackFrame::Array { items, index } => {
                    if index < items.len() {
                        // Push continuation for next item
                        self.stack.push(StackFrame::Array {
                            items,
                            index: index + 1,
                        });

                        // Push item to process
                        self.stack.push(StackFrame::Value(&items[index]));

                        // Continue to process the value
                        continue;
                    } else {
                        // Array is done
                        return Ok(Some(self.event(ParseEventKind::SequenceEnd)));
                    }
                }
                StackFrame::Enum {
                    variant,
                    fields,
                    phase,
                    is_unit,
                } => {
                    match phase {
                        0 => {
                            // Phase 0: emit FieldKey with variant name, then continue to phase 1
                            self.stack.push(StackFrame::Enum {
                                variant,
                                fields,
                                phase: 1,
                                is_unit,
                            });
                            return Ok(Some(self.event(ParseEventKind::FieldKey(FieldKey::new(
                                variant,
                                FieldLocationHint::KeyValue,
                            )))));
                        }
                        1 => {
                            // Phase 1: emit variant content
                            // Push phase 2 to emit StructEnd after content
                            self.stack.push(StackFrame::Enum {
                                variant,
                                fields: Vec::new(), // no longer needed
                                phase: 2,
                                is_unit: true, // not used in phase 2
                            });

                            if is_unit {
                                // Unit variant: emit Unit scalar
                                return Ok(Some(
                                    self.event(ParseEventKind::Scalar(ScalarValue::Unit)),
                                ));
                            } else {
                                // Struct/tuple variant: emit StructStart and push Object processing
                                self.stack.push(StackFrame::Object {
                                    entries: fields,
                                    index: 0,
                                });
                                return Ok(Some(
                                    self.event(ParseEventKind::StructStart(ContainerKind::Object)),
                                ));
                            }
                        }
                        _ => {
                            // Phase 2: emit outer StructEnd (the enum wrapper)
                            return Ok(Some(self.event(ParseEventKind::StructEnd)));
                        }
                    }
                }
            }
        }
    }

    fn peek_event(&mut self) -> Result<Option<ParseEvent<'input>>, ParseError> {
        if self.peeked.is_none() {
            self.peeked = self.next_event()?;
        }
        Ok(self.peeked.clone())
    }

    fn skip_value(&mut self) -> Result<(), ParseError> {
        // Pop and discard the next value
        self.next_event()?;
        Ok(())
    }

    fn save(&mut self) -> SavePoint {
        // Clone the current parser state (without saved_state to avoid recursion)
        let mut clone = self.clone();
        clone.saved_state = None;
        self.saved_state = Some(Box::new(clone));
        SavePoint(0)
    }

    fn restore(&mut self, _save_point: SavePoint) {
        if let Some(saved) = self.saved_state.take() {
            *self = *saved;
        }
    }

    fn current_span(&self) -> Option<Span> {
        // Return the last span we saw - this is a "virtual" span that maps back
        // to the real source location via the SpanRegistry
        self.last_span
    }
}

/// Helper methods for emitting values.
impl<'input> ConfigValueParser<'input> {
    /// Create a ParseEvent with the current span.
    fn event(&self, kind: ParseEventKind<'input>) -> ParseEvent<'input> {
        ParseEvent::new(kind, self.last_span.unwrap_or_default())
    }

    /// Emit an event for a single value.
    fn emit_value(&mut self, value: &'input ConfigValue) -> ParseEvent<'input> {
        match value {
            ConfigValue::Null(sourced) => {
                self.update_span(sourced);
                self.event(ParseEventKind::Scalar(ScalarValue::Null))
            }
            ConfigValue::Bool(sourced) => {
                self.update_span(sourced);
                self.event(ParseEventKind::Scalar(ScalarValue::Bool(sourced.value)))
            }
            ConfigValue::Integer(sourced) => {
                self.update_span(sourced);
                self.event(ParseEventKind::Scalar(ScalarValue::I64(sourced.value)))
            }
            ConfigValue::Float(sourced) => {
                self.update_span(sourced);
                self.event(ParseEventKind::Scalar(ScalarValue::F64(sourced.value)))
            }
            ConfigValue::String(sourced) => {
                self.update_span(sourced);
                self.event(ParseEventKind::Scalar(ScalarValue::Str(
                    std::borrow::Cow::Borrowed(&sourced.value),
                )))
            }
            ConfigValue::Array(sourced) => {
                self.update_span(sourced);

                // Push array processing
                self.stack.push(StackFrame::Array {
                    items: &sourced.value,
                    index: 0,
                });

                self.event(ParseEventKind::SequenceStart(ContainerKind::Array))
            }
            ConfigValue::Object(sourced) => {
                self.update_span(sourced);

                // Collect entries - just emit what's in the ConfigValue
                let entries: Vec<(&str, &ConfigValue)> =
                    sourced.value.iter().map(|(k, v)| (k.as_str(), v)).collect();

                // Push object processing
                self.stack.push(StackFrame::Object { entries, index: 0 });

                self.event(ParseEventKind::StructStart(ContainerKind::Object))
            }
            ConfigValue::Enum(sourced) => {
                self.update_span(sourced);

                // Collect entries - just emit what's in the ConfigValue
                let fields: Vec<(&str, &ConfigValue)> = sourced
                    .value
                    .fields
                    .iter()
                    .map(|(k, v)| (k.as_str(), v))
                    .collect();

                // Always treat enum variants as struct variants (emit StructStart/StructEnd).
                // We can't distinguish unit variants from struct variants with all-default fields
                // based on empty `fields` alone. The facet deserializer can handle empty structs.
                let is_unit = false;

                // Push enum processing frame (phase 0)
                // This emits: StructStart, FieldKey(variant), content, StructEnd
                // which is the externally-tagged format: {"VariantName": {...}}
                self.stack.push(StackFrame::Enum {
                    variant: &sourced.value.variant,
                    fields,
                    phase: 0,
                    is_unit,
                });

                // Emit the outer struct start (the enum wrapper)
                self.event(ParseEventKind::StructStart(ContainerKind::Object))
            }
        }
    }
}

/// Serializer that builds a ConfigValue tree.
pub struct ConfigValueSerializer {
    stack: Vec<BuildFrame>,
}

impl Default for ConfigValueSerializer {
    fn default() -> Self {
        Self {
            stack: vec![BuildFrame::Root(None)],
        }
    }
}

enum BuildFrame {
    Root(Option<ConfigValue>),
    Object {
        map: IndexMap<String, ConfigValue, std::hash::RandomState>,
    },
    Array {
        items: Vec<ConfigValue>,
    },
    PendingField {
        map: IndexMap<String, ConfigValue, std::hash::RandomState>,
        key: String,
    },
}

impl ConfigValueSerializer {
    /// Create a new ConfigValueSerializer.
    pub fn new() -> Self {
        Default::default()
    }

    /// Finish serialization and return the final ConfigValue.
    pub fn finish(mut self) -> ConfigValue {
        match self.stack.pop() {
            Some(BuildFrame::Root(Some(value))) if self.stack.is_empty() => value,
            Some(BuildFrame::Root(None)) if self.stack.is_empty() => {
                // No value was serialized, return null
                ConfigValue::Null(Sourced {
                    value: (),
                    span: None,
                    provenance: Some(Provenance::Default),
                })
            }
            _ => panic!("Serializer finished in unexpected state"),
        }
    }

    fn attach_value(&mut self, value: ConfigValue) -> Result<(), String> {
        let parent = self.stack.pop().ok_or("Stack underflow")?;
        match parent {
            BuildFrame::Root(None) => {
                self.stack.push(BuildFrame::Root(Some(value)));
                Ok(())
            }
            BuildFrame::Root(Some(_)) => Err("Root already has a value")?,
            BuildFrame::PendingField { mut map, key } => {
                map.insert(key, value);
                self.stack.push(BuildFrame::Object { map });
                Ok(())
            }
            BuildFrame::Array { mut items } => {
                items.push(value);
                self.stack.push(BuildFrame::Array { items });
                Ok(())
            }
            BuildFrame::Object { .. } => {
                Err("Cannot attach value directly to Object without field_key")?
            }
        }
    }
}

impl facet_format::FormatSerializer for ConfigValueSerializer {
    type Error = String;

    fn begin_struct(&mut self) -> Result<(), Self::Error> {
        self.stack.push(BuildFrame::Object {
            map: IndexMap::default(),
        });
        Ok(())
    }

    fn field_key(&mut self, key: &str) -> Result<(), Self::Error> {
        let frame = self.stack.pop().ok_or("Stack underflow")?;
        match frame {
            BuildFrame::Object { map } => {
                self.stack.push(BuildFrame::PendingField {
                    map,
                    key: key.to_string(),
                });
                Ok(())
            }
            _ => Err("field_key called outside of struct")?,
        }
    }

    fn end_struct(&mut self) -> Result<(), Self::Error> {
        let frame = self.stack.pop().ok_or("Stack underflow")?;
        match frame {
            BuildFrame::Object { map } => {
                let value = ConfigValue::Object(Sourced {
                    value: map,
                    span: None,
                    provenance: Some(Provenance::Default),
                });
                self.attach_value(value)
            }
            _ => Err("end_struct called without matching begin_struct")?,
        }
    }

    fn begin_seq(&mut self) -> Result<(), Self::Error> {
        self.stack.push(BuildFrame::Array { items: Vec::new() });
        Ok(())
    }

    fn end_seq(&mut self) -> Result<(), Self::Error> {
        let frame = self.stack.pop().ok_or("Stack underflow")?;
        match frame {
            BuildFrame::Array { items } => {
                let value = ConfigValue::Array(Sourced {
                    value: items,
                    span: None,
                    provenance: Some(Provenance::Default),
                });
                self.attach_value(value)
            }
            _ => Err("end_seq called without matching begin_seq")?,
        }
    }

    fn scalar(&mut self, value: facet_format::ScalarValue) -> Result<(), Self::Error> {
        use facet_format::ScalarValue;

        let config_value = match value {
            ScalarValue::Unit | ScalarValue::Null => ConfigValue::Null(Sourced {
                value: (),
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::Bool(b) => ConfigValue::Bool(Sourced {
                value: b,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::I64(i) => ConfigValue::Integer(Sourced {
                value: i,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::U64(u) => ConfigValue::Integer(Sourced {
                value: u as i64,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::I128(i) => ConfigValue::Integer(Sourced {
                value: i as i64,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::U128(u) => ConfigValue::Integer(Sourced {
                value: u as i64,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::F64(f) => ConfigValue::Float(Sourced {
                value: f,
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::Char(c) => ConfigValue::String(Sourced {
                value: c.to_string(),
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::Str(s) => ConfigValue::String(Sourced {
                value: s.into_owned(),
                span: None,
                provenance: Some(Provenance::Default),
            }),
            ScalarValue::Bytes(_) => {
                return Err("Bytes not supported in ConfigValue")?;
            }
        };

        self.attach_value(config_value)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::string::ToString;

    #[test]
    fn test_parse_null() {
        let value = ConfigValue::Null(Sourced::new(()));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::Null),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(event.is_none());
    }

    #[test]
    fn test_parse_bool() {
        let value = ConfigValue::Bool(Sourced::new(true));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::Bool(true)),
                ..
            })
        ));
    }

    #[test]
    fn test_parse_integer() {
        let value = ConfigValue::Integer(Sourced::new(42));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::I64(42)),
                ..
            })
        ));
    }

    #[test]
    fn test_parse_string() {
        let value = ConfigValue::String(Sourced::new("hello".to_string()));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        if let Some(ParseEvent {
            kind: ParseEventKind::Scalar(ScalarValue::Str(s)),
            ..
        }) = event
        {
            assert_eq!(s.as_ref(), "hello");
        } else {
            panic!("expected string scalar");
        }
    }

    #[test]
    fn test_parse_empty_array() {
        let value = ConfigValue::Array(Sourced::new(vec![]));
        let mut parser = ConfigValueParser::new(&value);

        // Should emit SequenceStart, then SequenceEnd
        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::SequenceStart(ContainerKind::Array),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::SequenceEnd,
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(event.is_none());
    }

    #[test]
    fn test_parse_array_with_items() {
        let value = ConfigValue::Array(Sourced::new(vec![
            ConfigValue::Integer(Sourced::new(1)),
            ConfigValue::Integer(Sourced::new(2)),
            ConfigValue::Integer(Sourced::new(3)),
        ]));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::SequenceStart(_),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::I64(1)),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::I64(2)),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::I64(3)),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::SequenceEnd,
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(event.is_none());
    }

    #[test]
    fn test_parse_empty_object() {
        let value = ConfigValue::Object(Sourced::new(indexmap::IndexMap::default()));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::StructStart(ContainerKind::Object),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::StructEnd,
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(event.is_none());
    }

    #[test]
    fn test_parse_object_with_fields() {
        let mut map = IndexMap::default();
        map.insert(
            "name".to_string(),
            ConfigValue::String(Sourced::new("Alice".to_string())),
        );
        map.insert("age".to_string(), ConfigValue::Integer(Sourced::new(30)));

        let value = ConfigValue::Object(Sourced::new(map));
        let mut parser = ConfigValueParser::new(&value);

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::StructStart(_),
                ..
            })
        ));

        // First field
        let event = parser.next_event().unwrap();
        if let Some(ParseEvent {
            kind: ParseEventKind::FieldKey(key),
            ..
        }) = event
        {
            assert_eq!(key.name().as_ref().map(|c| c.as_ref()), Some("name"));
        } else {
            panic!("expected FieldKey");
        }

        let event = parser.next_event().unwrap();
        if let Some(ParseEvent {
            kind: ParseEventKind::Scalar(ScalarValue::Str(s)),
            ..
        }) = event
        {
            assert_eq!(s.as_ref(), "Alice");
        } else {
            panic!("expected string value");
        }

        // Second field
        let event = parser.next_event().unwrap();
        if let Some(ParseEvent {
            kind: ParseEventKind::FieldKey(key),
            ..
        }) = event
        {
            assert_eq!(key.name().as_ref().map(|c| c.as_ref()), Some("age"));
        } else {
            panic!("expected FieldKey");
        }

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::Scalar(ScalarValue::I64(30)),
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(matches!(
            event,
            Some(ParseEvent {
                kind: ParseEventKind::StructEnd,
                ..
            })
        ));

        let event = parser.next_event().unwrap();
        assert!(event.is_none());
    }

    #[test]
    fn test_from_config_value_simple() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq)]
        struct SimpleConfig {
            port: i64,
            enabled: bool,
        }

        let mut map = IndexMap::default();
        map.insert("port".to_string(), ConfigValue::Integer(Sourced::new(8080)));
        map.insert("enabled".to_string(), ConfigValue::Bool(Sourced::new(true)));

        let value = ConfigValue::Object(Sourced::new(map));
        let config: SimpleConfig = from_config_value(&value).expect("should deserialize");

        assert_eq!(config.port, 8080);
        assert!(config.enabled);
    }

    #[test]
    fn test_from_config_value_nested() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq)]
        struct SmtpConfig {
            host: String,
            port: i64,
        }

        #[derive(Debug, Facet, PartialEq)]
        struct ServerConfig {
            port: i64,
            smtp: SmtpConfig,
        }

        // Build nested config value
        let mut smtp_map = IndexMap::default();
        smtp_map.insert(
            "host".to_string(),
            ConfigValue::String(Sourced::new("smtp.example.com".to_string())),
        );
        smtp_map.insert("port".to_string(), ConfigValue::Integer(Sourced::new(587)));

        let mut server_map = IndexMap::default();
        server_map.insert("port".to_string(), ConfigValue::Integer(Sourced::new(8080)));
        server_map.insert(
            "smtp".to_string(),
            ConfigValue::Object(Sourced::new(smtp_map)),
        );

        let value = ConfigValue::Object(Sourced::new(server_map));
        let config: ServerConfig = from_config_value(&value).expect("should deserialize");

        assert_eq!(config.port, 8080);
        assert_eq!(config.smtp.host, "smtp.example.com");
        assert_eq!(config.smtp.port, 587);
    }

    // ========================================================================
    // Tests: fill_defaults_from_shape
    // ========================================================================

    #[test]
    fn test_fill_defaults_simple_struct() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq)]
        struct Config {
            #[facet(default)]
            enabled: bool,
            port: i64,
        }

        // Input has port but not enabled
        let mut map = IndexMap::default();
        map.insert("port".to_string(), ConfigValue::Integer(Sourced::new(8080)));
        let input = ConfigValue::Object(Sourced::new(map));

        let result = fill_defaults_from_shape(&input, Config::SHAPE);

        // Should have both fields
        if let ConfigValue::Object(obj) = result {
            assert!(obj.value.contains_key("port"), "should have port");
            assert!(
                obj.value.contains_key("enabled"),
                "should have enabled with default"
            );
            if let ConfigValue::Bool(b) = &obj.value["enabled"] {
                assert!(!b.value, "enabled default should be false");
            } else {
                panic!("enabled should be a bool");
            }
        } else {
            panic!("expected object");
        }
    }

    #[test]
    fn test_fill_defaults_with_flatten() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq, Default)]
        struct CommonOpts {
            #[facet(default)]
            verbose: bool,
            #[facet(default)]
            debug: bool,
        }

        #[derive(Debug, Facet, PartialEq)]
        struct Config {
            name: String,
            #[facet(flatten)]
            common: CommonOpts,
        }

        // Input has only name - common fields should be flattened as defaults
        let mut map = IndexMap::default();
        map.insert(
            "name".to_string(),
            ConfigValue::String(Sourced::new("test".to_string())),
        );
        let input = ConfigValue::Object(Sourced::new(map));

        let result = fill_defaults_from_shape(&input, Config::SHAPE);

        // For flattened fields, the defaults should be at the TOP level
        // (verbose, debug) NOT nested under "common"
        if let ConfigValue::Object(obj) = result {
            assert!(obj.value.contains_key("name"), "should have name");

            // The key insight: flattened fields should NOT create a nested "common" object.
            // Instead, verbose and debug should be at the top level.
            assert!(
                obj.value.contains_key("verbose"),
                "should have verbose at top level (flattened)"
            );
            assert!(
                obj.value.contains_key("debug"),
                "should have debug at top level (flattened)"
            );
            assert!(
                !obj.value.contains_key("common"),
                "should NOT have nested 'common' object"
            );
        } else {
            panic!("expected object");
        }
    }

    #[test]
    fn test_fill_defaults_flatten_preserves_existing() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq, Default)]
        struct CommonOpts {
            #[facet(default)]
            verbose: bool,
            #[facet(default)]
            debug: bool,
        }

        #[derive(Debug, Facet, PartialEq)]
        struct Config {
            name: String,
            #[facet(flatten)]
            common: CommonOpts,
        }

        // Input has name and verbose (already provided)
        let mut map = IndexMap::default();
        map.insert(
            "name".to_string(),
            ConfigValue::String(Sourced::new("test".to_string())),
        );
        map.insert("verbose".to_string(), ConfigValue::Bool(Sourced::new(true)));
        let input = ConfigValue::Object(Sourced::new(map));

        let result = fill_defaults_from_shape(&input, Config::SHAPE);

        if let ConfigValue::Object(obj) = result {
            // verbose should be preserved as true
            if let ConfigValue::Bool(b) = &obj.value["verbose"] {
                assert!(b.value, "verbose should be true (preserved)");
            }
            // debug should be filled with default false
            assert!(obj.value.contains_key("debug"), "should have debug");
            if let ConfigValue::Bool(b) = &obj.value["debug"] {
                assert!(!b.value, "debug should be false (default)");
            }
        } else {
            panic!("expected object");
        }
    }

    #[test]
    fn test_fill_defaults_subcommand_with_flatten() {
        use facet::Facet;

        // This reproduces the exact issue from GitHub #3

        #[derive(Debug, Facet, PartialEq, Default)]
        struct Builtins {
            #[facet(default)]
            help: bool,
            #[facet(default)]
            version: bool,
        }

        #[derive(Debug, Facet, PartialEq)]
        #[repr(u8)]
        enum Command {
            Build { release: bool },
        }

        #[derive(Debug, Facet)]
        struct Args {
            command: Command,
            #[facet(flatten)]
            builtins: Builtins,
        }

        // Input: command is present, builtins fields should be flattened
        let mut fields = IndexMap::default();
        fields.insert("release".to_string(), ConfigValue::Bool(Sourced::new(true)));
        let enum_value = ConfigValue::Enum(Sourced::new(crate::config_value::EnumValue {
            variant: "Build".to_string(),
            fields,
        }));

        let mut map = IndexMap::default();
        map.insert("command".to_string(), enum_value);
        let input = ConfigValue::Object(Sourced::new(map));

        let result = fill_defaults_from_shape(&input, Args::SHAPE);

        if let ConfigValue::Object(obj) = result {
            // command should be preserved
            assert!(obj.value.contains_key("command"), "should have command");

            // builtins fields should be flattened at top level
            assert!(
                obj.value.contains_key("help"),
                "should have help at top level"
            );
            assert!(
                obj.value.contains_key("version"),
                "should have version at top level"
            );
            assert!(
                !obj.value.contains_key("builtins"),
                "should NOT have nested 'builtins'"
            );
        } else {
            panic!("expected object");
        }
    }

    #[facet_testhelpers::test]
    fn test_full_deserialization_with_flatten() {
        use facet::Facet;

        #[derive(Debug, Facet, PartialEq, Default)]
        struct CommonOpts {
            #[facet(default)]
            verbose: bool,
        }

        #[derive(Debug, Facet, PartialEq)]
        struct Config {
            name: String,
            #[facet(flatten)]
            common: CommonOpts,
        }

        // Build ConfigValue with flattened structure (as CLI parser would produce)
        let mut map = indexmap::IndexMap::default();
        map.insert(
            "name".to_string(),
            ConfigValue::String(Sourced::new("test".to_string())),
        );
        map.insert("verbose".to_string(), ConfigValue::Bool(Sourced::new(true)));
        let input = ConfigValue::Object(Sourced::new(map));

        // This should deserialize correctly with flattened fields at top level
        let config: Config = from_config_value(&input).expect("should deserialize");

        assert_eq!(config.name, "test");
        assert!(config.common.verbose);
    }
}

#[cfg(test)]
mod fill_defaults_tests {
    use super::*;
    use crate::config_value::Sourced;
    use facet::Facet;

    // Test 1: Simple struct with scalar defaults
    #[derive(Facet, Debug)]
    struct SimpleStruct {
        #[facet(default)]
        flag: bool,
        #[facet(default)]
        count: i64,
    }

    #[test]
    fn test_fill_defaults_simple_struct() {
        let input = ConfigValue::Object(Sourced::new(IndexMap::default()));
        let result = fill_defaults_from_shape(&input, SimpleStruct::SHAPE);

        if let ConfigValue::Object(obj) = result {
            assert!(obj.value.contains_key("flag"), "should have flag");
            assert!(obj.value.contains_key("count"), "should have count");
        } else {
            panic!("expected object");
        }
    }

    // Test 2: Struct with flattened field
    #[derive(Facet, Debug, Default)]
    struct Inner {
        #[facet(default)]
        inner_flag: bool,
    }

    #[derive(Facet, Debug)]
    struct StructWithFlatten {
        #[facet(default)]
        outer_flag: bool,
        #[facet(flatten)]
        inner: Inner,
    }

    #[test]
    fn test_fill_defaults_flattened_struct() {
        let input = ConfigValue::Object(Sourced::new(indexmap::IndexMap::default()));
        let result = fill_defaults_from_shape(&input, StructWithFlatten::SHAPE);

        if let ConfigValue::Object(obj) = result {
            assert!(
                obj.value.contains_key("outer_flag"),
                "should have outer_flag at top level"
            );
            assert!(
                obj.value.contains_key("inner_flag"),
                "should have inner_flag at top level (flattened)"
            );
            assert!(
                !obj.value.contains_key("inner"),
                "should NOT have nested 'inner' object"
            );
        } else {
            panic!("expected object");
        }
    }

    // Test 3: Enum with struct variant
    #[derive(Facet, Debug)]
    #[repr(u8)]
    #[allow(dead_code)]
    enum EnumWithStructVariant {
        Variant {
            #[facet(default)]
            field: bool,
        },
    }

    #[test]
    fn test_fill_defaults_enum_struct_variant() {
        let fields = IndexMap::default();
        let input = ConfigValue::Enum(Sourced::new(crate::config_value::EnumValue {
            variant: "Variant".to_string(),
            fields,
        }));
        let result = fill_defaults_from_shape(&input, EnumWithStructVariant::SHAPE);

        if let ConfigValue::Enum(e) = result {
            assert!(e.value.fields.contains_key("field"), "should have field");
        } else {
            panic!("expected enum");
        }
    }

    // Test 4: Enum with tuple variant (like Bench(BenchArgs))
    #[derive(Facet, Debug, Default)]
    struct TuplePayload {
        #[facet(default)]
        payload_flag: bool,
    }

    #[derive(Facet, Debug)]
    #[repr(u8)]
    #[allow(dead_code)]
    enum EnumWithTupleVariant {
        TupleVar(TuplePayload),
    }

    #[test]
    fn test_fill_defaults_enum_tuple_variant() {
        // Tuple variant fields should be flattened - payload_flag at top level, not under "0"
        let fields = IndexMap::default();
        let input = ConfigValue::Enum(Sourced::new(crate::config_value::EnumValue {
            variant: "TupleVar".to_string(),
            fields,
        }));
        let result = fill_defaults_from_shape(&input, EnumWithTupleVariant::SHAPE);

        if let ConfigValue::Enum(e) = result {
            assert!(
                e.value.fields.contains_key("payload_flag"),
                "should have payload_flag at top level"
            );
            assert!(
                !e.value.fields.contains_key("0"),
                "should NOT have '0' wrapper"
            );
        } else {
            panic!("expected enum");
        }
    }

    // Test 5: Enum with flattened field inside variant
    #[derive(Facet, Debug, Default)]
    struct FlattenedOpts {
        #[facet(default)]
        opt_a: bool,
        #[facet(default)]
        opt_b: bool,
    }

    #[derive(Facet, Debug)]
    #[repr(u8)]
    #[allow(dead_code)]
    enum EnumWithFlattenInVariant {
        Cmd {
            #[facet(flatten)]
            opts: FlattenedOpts,
            #[facet(default)]
            other: bool,
        },
    }

    #[test]
    fn test_fill_defaults_enum_flatten_in_variant() {
        let fields = IndexMap::default();
        let input = ConfigValue::Enum(Sourced::new(crate::config_value::EnumValue {
            variant: "Cmd".to_string(),
            fields,
        }));
        let result = fill_defaults_from_shape(&input, EnumWithFlattenInVariant::SHAPE);

        if let ConfigValue::Enum(e) = result {
            assert!(
                e.value.fields.contains_key("opt_a"),
                "should have opt_a (flattened)"
            );
            assert!(
                e.value.fields.contains_key("opt_b"),
                "should have opt_b (flattened)"
            );
            assert!(e.value.fields.contains_key("other"), "should have other");
            assert!(
                !e.value.fields.contains_key("opts"),
                "should NOT have 'opts' wrapper"
            );
        } else {
            panic!("expected enum");
        }
    }

    // Test 6: Deep flatten - flatten inside flatten
    #[derive(Facet, Debug, Default)]
    struct DeepInner {
        #[facet(default)]
        deep_flag: bool,
    }

    #[derive(Facet, Debug, Default)]
    struct MiddleLayer {
        #[facet(default)]
        middle_flag: bool,
        #[facet(flatten)]
        deep: DeepInner,
    }

    #[derive(Facet, Debug)]
    struct DeepFlattenStruct {
        #[facet(default)]
        top_flag: bool,
        #[facet(flatten)]
        middle: MiddleLayer,
    }

    #[test]
    fn test_fill_defaults_deep_flatten() {
        let input = ConfigValue::Object(Sourced::new(IndexMap::default()));
        let result = fill_defaults_from_shape(&input, DeepFlattenStruct::SHAPE);

        if let ConfigValue::Object(obj) = result {
            eprintln!("Result keys: {:?}", obj.value.keys().collect::<Vec<_>>());
            assert!(obj.value.contains_key("top_flag"), "should have top_flag");
            assert!(
                obj.value.contains_key("middle_flag"),
                "should have middle_flag (flattened)"
            );
            assert!(
                obj.value.contains_key("deep_flag"),
                "should have deep_flag (double flattened)"
            );
            assert!(
                !obj.value.contains_key("middle"),
                "should NOT have 'middle' wrapper"
            );
            assert!(
                !obj.value.contains_key("deep"),
                "should NOT have 'deep' wrapper"
            );
        } else {
            panic!("expected object");
        }
    }

    // Test 7: Renamed enum variant
    #[derive(Facet, Debug)]
    #[repr(u8)]
    #[allow(dead_code)]
    enum RenamedVariantEnum {
        #[facet(rename = "ls")]
        List {
            #[facet(default)]
            all: bool,
        },
    }

    #[test]
    fn test_fill_defaults_renamed_variant() {
        // ConfigValue uses effective name "ls", not "List"
        let fields = IndexMap::default();
        let input = ConfigValue::Enum(Sourced::new(crate::config_value::EnumValue {
            variant: "ls".to_string(), // effective name
            fields,
        }));
        let result = fill_defaults_from_shape(&input, RenamedVariantEnum::SHAPE);

        if let ConfigValue::Enum(e) = result {
            assert_eq!(e.value.variant, "ls", "variant name should be preserved");
            assert!(e.value.fields.contains_key("all"), "should have all field");
        } else {
            panic!("expected enum");
        }
    }
}