tasmor_lib 0.6.0

Rust library to control Tasmota devices via MQTT and HTTP
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
// SPDX-License-Identifier: MPL-2.0
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at https://mozilla.org/MPL/2.0/.

//! Parser for Tasmota STATE telemetry messages.

use std::time::Duration;

use serde::Deserialize;
use serde::de::{self, Deserializer};

use crate::error::ParseError;
use crate::state::StateChange;
use crate::types::{
    ColorTemperature, Dimmer, FadeDuration, HsbColor, PowerState, Scheme, parse_uptime,
};

/// Deserializes a boolean from either "ON"/"OFF" string or 0/1 integer.
fn deserialize_bool_or_int<'de, D>(deserializer: D) -> Result<Option<bool>, D::Error>
where
    D: Deserializer<'de>,
{
    use serde::de::Visitor;

    struct BoolOrIntVisitor;

    impl Visitor<'_> for BoolOrIntVisitor {
        type Value = Option<bool>;

        fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            formatter.write_str("a boolean, string 'ON'/'OFF', or integer 0/1")
        }

        fn visit_bool<E>(self, v: bool) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            Ok(Some(v))
        }

        fn visit_i64<E>(self, v: i64) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            Ok(Some(v != 0))
        }

        fn visit_u64<E>(self, v: u64) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            Ok(Some(v != 0))
        }

        fn visit_str<E>(self, v: &str) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            match v.to_uppercase().as_str() {
                "ON" | "TRUE" | "1" => Ok(Some(true)),
                "OFF" | "FALSE" | "0" => Ok(Some(false)),
                _ => Err(de::Error::invalid_value(de::Unexpected::Str(v), &self)),
            }
        }

        fn visit_none<E>(self) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            Ok(None)
        }

        fn visit_unit<E>(self) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            Ok(None)
        }
    }

    deserializer.deserialize_any(BoolOrIntVisitor)
}

/// Parsed state from a `tele/<topic>/STATE` message.
///
/// This struct represents the device state as reported in periodic
/// telemetry messages. Not all fields are present in every message.
///
/// # Examples
///
/// ```
/// use tasmor_lib::telemetry::TelemetryState;
///
/// let json = r#"{"POWER":"ON","Dimmer":75,"CT":326}"#;
/// let state: TelemetryState = serde_json::from_str(json).unwrap();
///
/// assert_eq!(state.power(), Some(tasmor_lib::PowerState::On));
/// assert_eq!(state.dimmer(), Some(75));
/// assert_eq!(state.color_temp(), Some(326));
/// ```
#[derive(Debug, Clone, Default, Deserialize)]
pub struct TelemetryState {
    /// Power state for relay 1 (or single relay).
    #[serde(rename = "POWER", default)]
    power: Option<String>,

    /// Power state for relay 1 (alternative format).
    #[serde(rename = "POWER1", default)]
    power1: Option<String>,

    /// Power state for relay 2.
    #[serde(rename = "POWER2", default)]
    power2: Option<String>,

    /// Power state for relay 3.
    #[serde(rename = "POWER3", default)]
    power3: Option<String>,

    /// Power state for relay 4.
    #[serde(rename = "POWER4", default)]
    power4: Option<String>,

    /// Power state for relay 5.
    #[serde(rename = "POWER5", default)]
    power5: Option<String>,

    /// Power state for relay 6.
    #[serde(rename = "POWER6", default)]
    power6: Option<String>,

    /// Power state for relay 7.
    #[serde(rename = "POWER7", default)]
    power7: Option<String>,

    /// Power state for relay 8.
    #[serde(rename = "POWER8", default)]
    power8: Option<String>,

    /// Dimmer level (0-100).
    #[serde(rename = "Dimmer", default)]
    dimmer: Option<u8>,

    /// Color temperature in mireds (153-500).
    #[serde(rename = "CT", default)]
    ct: Option<u16>,

    /// HSB color as comma-separated string (e.g., "180,100,75").
    #[serde(rename = "HSBColor", default)]
    hsb_color: Option<String>,

    /// RGB color as hex string (e.g., "FF0000").
    #[serde(rename = "Color", default)]
    color: Option<String>,

    /// White channel value (0-100).
    #[serde(rename = "White", default)]
    white: Option<u8>,

    /// Fade setting ("ON"/"OFF" or 0/1).
    #[serde(rename = "Fade", default, deserialize_with = "deserialize_bool_or_int")]
    fade: Option<bool>,

    /// Transition speed (1-40).
    #[serde(rename = "Speed", default)]
    speed: Option<u8>,

    /// Color scheme (0 = single color, 1-4 = patterns).
    #[serde(rename = "Scheme", default)]
    scheme: Option<u8>,

    /// Device uptime as string (e.g., "17T04:02:54").
    #[serde(rename = "Uptime", default)]
    uptime: Option<String>,

    /// Device uptime in seconds.
    #[serde(rename = "UptimeSec", default)]
    uptime_sec: Option<u64>,

    /// Wi-Fi information.
    #[serde(rename = "Wifi", default)]
    wifi: Option<WifiInfo>,
}

/// Wi-Fi connection information from telemetry.
#[derive(Debug, Clone, Default, Deserialize)]
pub struct WifiInfo {
    /// SSID of the connected network.
    #[serde(rename = "SSId", default)]
    pub ssid: Option<String>,

    /// RSSI (signal strength percentage, 0-100).
    #[serde(rename = "RSSI", default)]
    pub rssi: Option<i32>,

    /// Signal strength in dBm.
    #[serde(rename = "Signal", default)]
    pub signal: Option<i32>,

    /// Wi-Fi channel.
    #[serde(rename = "Channel", default)]
    pub channel: Option<u8>,

    /// Number of reconnections.
    #[serde(rename = "LinkCount", default)]
    pub link_count: Option<u32>,
}

impl TelemetryState {
    /// Returns the power state for the primary relay.
    #[must_use]
    pub fn power(&self) -> Option<PowerState> {
        self.power
            .as_ref()
            .or(self.power1.as_ref())
            .and_then(|s| s.parse().ok())
    }

    /// Returns the power state for a specific relay (1-8).
    #[must_use]
    pub fn power_index(&self, index: u8) -> Option<PowerState> {
        let power_str = match index {
            1 => self.power.as_ref().or(self.power1.as_ref()),
            2 => self.power2.as_ref(),
            3 => self.power3.as_ref(),
            4 => self.power4.as_ref(),
            5 => self.power5.as_ref(),
            6 => self.power6.as_ref(),
            7 => self.power7.as_ref(),
            8 => self.power8.as_ref(),
            _ => None,
        };
        power_str.and_then(|s| s.parse().ok())
    }

    /// Returns all power states as (index, state) pairs.
    #[must_use]
    pub fn all_power_states(&self) -> Vec<(u8, PowerState)> {
        (1..=8)
            .filter_map(|i| self.power_index(i).map(|s| (i, s)))
            .collect()
    }

    /// Returns the dimmer level (0-100).
    #[must_use]
    pub fn dimmer(&self) -> Option<u8> {
        self.dimmer
    }

    /// Returns the color temperature in mireds.
    #[must_use]
    pub fn color_temp(&self) -> Option<u16> {
        self.ct
    }

    /// Returns the HSB color if present.
    #[must_use]
    pub fn hsb_color(&self) -> Option<HsbColor> {
        let hsb_str = self.hsb_color.as_ref()?;
        let parts: Vec<&str> = hsb_str.split(',').collect();
        if parts.len() != 3 {
            return None;
        }

        let hue: u16 = parts[0].parse().ok()?;
        let saturation: u8 = parts[1].parse().ok()?;
        let brightness: u8 = parts[2].parse().ok()?;

        HsbColor::new(hue, saturation, brightness).ok()
    }

    /// Returns the RGB color hex string.
    #[must_use]
    pub fn rgb_color(&self) -> Option<&str> {
        self.color.as_deref()
    }

    /// Returns the white channel value (0-100).
    #[must_use]
    pub fn white(&self) -> Option<u8> {
        self.white
    }

    /// Returns whether fade is enabled.
    #[must_use]
    pub fn fade_enabled(&self) -> Option<bool> {
        self.fade
    }

    /// Returns the transition speed (1-40).
    #[must_use]
    pub fn speed(&self) -> Option<u8> {
        self.speed
    }

    /// Returns the color scheme (0 = single color, 1-4 = patterns).
    #[must_use]
    pub fn scheme(&self) -> Option<u8> {
        self.scheme
    }

    /// Returns the device uptime as a [`Duration`].
    ///
    /// This method tries to parse the uptime in this order:
    /// 1. Parse the `Uptime` string (e.g., "17T04:02:54")
    /// 2. Fall back to `UptimeSec` field if string parsing fails
    ///
    /// # Examples
    ///
    /// ```
    /// use std::time::Duration;
    /// use tasmor_lib::telemetry::TelemetryState;
    ///
    /// let json = r#"{"Uptime":"1T23:46:58","UptimeSec":172018}"#;
    /// let state: TelemetryState = serde_json::from_str(json).unwrap();
    ///
    /// assert_eq!(state.uptime(), Some(Duration::from_secs(172018)));
    /// ```
    #[must_use]
    pub fn uptime(&self) -> Option<Duration> {
        // Try parsing the string format first
        if let Some(uptime_str) = &self.uptime
            && let Ok(duration) = parse_uptime(uptime_str)
        {
            return Some(duration);
        }
        // Fall back to seconds field
        self.uptime_sec.map(Duration::from_secs)
    }

    /// Returns the Wi-Fi information.
    #[must_use]
    pub fn wifi(&self) -> Option<&WifiInfo> {
        self.wifi.as_ref()
    }

    /// Converts the telemetry state into a list of state changes.
    #[must_use]
    pub fn to_state_changes(&self) -> Vec<StateChange> {
        let mut changes = Vec::new();

        // Power states
        for (index, state) in self.all_power_states() {
            changes.push(StateChange::Power { index, state });
        }

        // Dimmer
        if let Some(dimmer) = self.dimmer {
            changes.push(StateChange::Dimmer(Dimmer::clamped(dimmer)));
        }

        // Color temperature
        if let Some(ct) = self.ct
            && let Ok(color_temp) = ColorTemperature::new(ct)
        {
            changes.push(StateChange::ColorTemperature(color_temp));
        }

        // HSB Color
        if let Some(hsb) = self.hsb_color() {
            changes.push(StateChange::HsbColor(hsb));
        }

        // Scheme
        if let Some(scheme_value) = self.scheme
            && let Ok(scheme) = Scheme::new(scheme_value)
        {
            changes.push(StateChange::Scheme(scheme));
        }

        // Fade enabled
        if let Some(fade) = self.fade {
            changes.push(StateChange::FadeEnabled(fade));
        }

        // Fade duration
        if let Some(speed_value) = self.speed
            && let Ok(duration) = FadeDuration::from_raw(speed_value)
        {
            changes.push(StateChange::FadeDuration(duration));
        }

        // If we have multiple changes, wrap in a batch
        if changes.len() > 1 {
            vec![StateChange::Batch(changes)]
        } else {
            changes
        }
    }

    /// Extracts system information from telemetry.
    ///
    /// This creates a [`crate::state::SystemInfo`] containing the uptime and Wi-Fi signal
    /// strength from the telemetry message. The heap memory is not available
    /// in STATE telemetry (only in STATUS responses).
    ///
    /// # Examples
    ///
    /// ```
    /// use std::time::Duration;
    /// use tasmor_lib::telemetry::TelemetryState;
    ///
    /// let json = r#"{"UptimeSec":172800,"Wifi":{"Signal":-55}}"#;
    /// let state: TelemetryState = serde_json::from_str(json).unwrap();
    ///
    /// let info = state.to_system_info();
    /// assert_eq!(info.uptime(), Some(Duration::from_secs(172800)));
    /// assert_eq!(info.wifi_rssi(), Some(-55));
    /// ```
    #[must_use]
    pub fn to_system_info(&self) -> crate::state::SystemInfo {
        let mut info = crate::state::SystemInfo::new();

        if let Some(uptime) = self.uptime() {
            info = info.with_uptime(uptime);
        }

        // Use signal (dBm) rather than rssi (percentage) as it's more useful
        if let Some(wifi) = &self.wifi
            && let Some(signal) = wifi.signal
        {
            // Saturate i32 to i8 range - truncation is safe after clamping
            #[allow(clippy::cast_possible_truncation)]
            let rssi = signal.clamp(i32::from(i8::MIN), i32::from(i8::MAX)) as i8;
            info = info.with_wifi_rssi(rssi);
        }

        info
    }
}

/// Parses a STATE telemetry JSON payload.
pub(crate) fn parse_state(payload: &str) -> Result<TelemetryState, ParseError> {
    serde_json::from_str(payload).map_err(ParseError::Json)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn parse_simple_power_state() {
        let json = r#"{"POWER":"ON"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power(), Some(PowerState::On));
    }

    #[test]
    fn parse_power_off() {
        let json = r#"{"POWER":"OFF"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power(), Some(PowerState::Off));
    }

    #[test]
    fn parse_power1_format() {
        let json = r#"{"POWER1":"ON"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power(), Some(PowerState::On));
        assert_eq!(state.power_index(1), Some(PowerState::On));
    }

    #[test]
    fn parse_multiple_relays() {
        let json = r#"{"POWER1":"ON","POWER2":"OFF","POWER3":"ON"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power_index(1), Some(PowerState::On));
        assert_eq!(state.power_index(2), Some(PowerState::Off));
        assert_eq!(state.power_index(3), Some(PowerState::On));
        assert_eq!(state.power_index(4), None);

        let all = state.all_power_states();
        assert_eq!(all.len(), 3);
    }

    #[test]
    fn parse_dimmer() {
        let json = r#"{"POWER":"ON","Dimmer":75}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.dimmer(), Some(75));
    }

    #[test]
    fn parse_color_temp() {
        let json = r#"{"POWER":"ON","CT":326}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.color_temp(), Some(326));
    }

    #[test]
    fn parse_hsb_color() {
        let json = r#"{"HSBColor":"180,100,75"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let hsb = state.hsb_color().unwrap();
        assert_eq!(hsb.hue(), 180);
        assert_eq!(hsb.saturation(), 100);
        assert_eq!(hsb.brightness(), 75);
    }

    #[test]
    fn parse_full_light_state() {
        let json = r#"{
            "POWER": "ON",
            "Dimmer": 50,
            "CT": 400,
            "HSBColor": "120,80,50",
            "Color": "80FF80",
            "White": 0,
            "Fade": 1,
            "Speed": 10,
            "Scheme": 0
        }"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power(), Some(PowerState::On));
        assert_eq!(state.dimmer(), Some(50));
        assert_eq!(state.color_temp(), Some(400));
        assert!(state.hsb_color().is_some());
        assert_eq!(state.rgb_color(), Some("80FF80"));
        assert_eq!(state.white(), Some(0));
        assert_eq!(state.fade_enabled(), Some(true));
        assert_eq!(state.speed(), Some(10));
    }

    #[test]
    fn parse_with_wifi_info() {
        let json = r#"{
            "POWER": "ON",
            "Wifi": {
                "SSId": "MyNetwork",
                "RSSI": 80,
                "Signal": -60,
                "Channel": 6,
                "LinkCount": 5
            }
        }"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let wifi = state.wifi().unwrap();
        assert_eq!(wifi.ssid, Some("MyNetwork".to_string()));
        assert_eq!(wifi.rssi, Some(80));
        assert_eq!(wifi.signal, Some(-60));
        assert_eq!(wifi.channel, Some(6));
        assert_eq!(wifi.link_count, Some(5));
    }

    #[test]
    fn to_state_changes_single_power() {
        let json = r#"{"POWER":"ON"}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let changes = state.to_state_changes();
        assert_eq!(changes.len(), 1);
        assert!(matches!(
            &changes[0],
            StateChange::Power {
                index: 1,
                state: PowerState::On
            }
        ));
    }

    #[test]
    fn to_state_changes_multiple() {
        let json = r#"{"POWER":"ON","Dimmer":75,"CT":326}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let changes = state.to_state_changes();
        // Should be wrapped in a batch since multiple changes
        assert_eq!(changes.len(), 1);
        if let StateChange::Batch(batch) = &changes[0] {
            assert_eq!(batch.len(), 3); // power, dimmer, ct
        } else {
            panic!("Expected batch");
        }
    }

    #[test]
    fn parse_uptime_from_string() {
        let json = r#"{"Uptime":"17T04:02:54","UptimeSec":1483374}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        // Should parse from Uptime string: 17 * 86400 + 4 * 3600 + 2 * 60 + 54 = 1483374
        assert_eq!(state.uptime(), Some(Duration::from_secs(1_483_374)));
    }

    #[test]
    fn parse_uptime_from_seconds_only() {
        let json = r#"{"UptimeSec":172800}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        // Falls back to UptimeSec when Uptime string is not present
        assert_eq!(state.uptime(), Some(Duration::from_secs(172_800)));
    }

    #[test]
    fn parse_fade_as_string() {
        // Tasmota can send Fade as "ON"/"OFF" string
        let json = r#"{"POWER":"ON","Fade":"ON","Speed":2}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.fade_enabled(), Some(true));
        assert_eq!(state.speed(), Some(2));
    }

    #[test]
    fn parse_fade_as_int() {
        // Tasmota can also send Fade as 0/1 integer
        let json = r#"{"POWER":"ON","Fade":1,"Speed":2}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.fade_enabled(), Some(true));
    }

    #[test]
    fn parse_real_tasmota_result() {
        // This is the actual format from a real Tasmota device
        let json = r#"{
            "Time":"2025-12-24T12:52:52",
            "Uptime":"1T22:15:47",
            "UptimeSec":166547,
            "Heap":25,
            "SleepMode":"Dynamic",
            "Sleep":50,
            "LoadAvg":19,
            "MqttCount":1,
            "POWER":"OFF",
            "Dimmer":100,
            "Color":"FF00000000",
            "HSBColor":"360,100,100",
            "White":0,
            "CT":153,
            "Channel":[100,0,0,0,0],
            "Scheme":0,
            "Fade":"ON",
            "Speed":2,
            "LedTable":"ON",
            "Wifi":{"AP":1,"SSId":"test","Channel":11}
        }"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        assert_eq!(state.power(), Some(PowerState::Off));
        assert_eq!(state.dimmer(), Some(100));
        assert_eq!(state.color_temp(), Some(153));

        // Verify HSBColor parsing
        let hsb = state.hsb_color().expect("HSBColor should be present");
        assert_eq!(hsb.hue(), 360);
        assert_eq!(hsb.saturation(), 100);
        assert_eq!(hsb.brightness(), 100);

        assert_eq!(state.fade_enabled(), Some(true));
        assert_eq!(state.speed(), Some(2));

        // Should produce state changes (wrapped in batch since multiple)
        let changes = state.to_state_changes();
        assert_eq!(changes.len(), 1);
        if let StateChange::Batch(batch) = &changes[0] {
            // Should contain: power, dimmer, color_temp, hsb_color, scheme, fade_enabled, fade_duration
            assert!(
                batch.len() >= 7,
                "Expected at least 7 changes, got {}",
                batch.len()
            );

            // Verify HsbColor is in the batch
            let has_hsb = batch.iter().any(|c| matches!(c, StateChange::HsbColor(_)));
            assert!(has_hsb, "HsbColor should be in the batch");

            // Verify FadeEnabled is in the batch
            let has_fade = batch
                .iter()
                .any(|c| matches!(c, StateChange::FadeEnabled(true)));
            assert!(has_fade, "FadeEnabled(true) should be in the batch");

            // Verify FadeDuration is in the batch
            let has_duration = batch
                .iter()
                .any(|c| matches!(c, StateChange::FadeDuration(_)));
            assert!(has_duration, "FadeDuration should be in the batch");
        } else {
            panic!("Expected batch with multiple changes");
        }
    }

    // ========== to_system_info() Tests ==========

    #[test]
    fn to_system_info_with_uptime() {
        let json = r#"{"UptimeSec":172800}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let info = state.to_system_info();
        assert_eq!(info.uptime(), Some(Duration::from_secs(172800)));
        assert!(info.wifi_rssi().is_none());
        assert!(info.heap().is_none());
    }

    #[test]
    fn to_system_info_with_wifi_signal() {
        let json = r#"{"Wifi":{"Signal":-55}}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let info = state.to_system_info();
        assert!(info.uptime().is_none());
        assert_eq!(info.wifi_rssi(), Some(-55));
    }

    #[test]
    fn to_system_info_with_all_fields() {
        let json = r#"{"UptimeSec":172800,"Wifi":{"Signal":-60,"RSSI":80}}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let info = state.to_system_info();
        assert_eq!(info.uptime(), Some(Duration::from_secs(172800)));
        assert_eq!(info.wifi_rssi(), Some(-60)); // Uses Signal (dBm), not RSSI (%)
    }

    #[test]
    fn to_system_info_empty_when_no_system_data() {
        let json = r#"{"POWER":"ON","Dimmer":75}"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let info = state.to_system_info();
        assert!(info.is_empty());
    }

    #[test]
    fn to_system_info_from_real_tasmota_payload() {
        // 1T23:46:58 = 1 * 86400 + 23 * 3600 + 46 * 60 + 58 = 172018
        let json = r#"{
            "Time":"2025-12-24T14:24:03",
            "Uptime":"1T23:46:58",
            "UptimeSec":172018,
            "Heap":25,
            "POWER":"OFF",
            "Wifi":{"AP":1,"SSId":"test","Signal":-52,"Channel":11}
        }"#;
        let state: TelemetryState = serde_json::from_str(json).unwrap();

        let info = state.to_system_info();
        assert_eq!(info.uptime(), Some(Duration::from_secs(172018)));
        assert_eq!(info.wifi_rssi(), Some(-52));
        // Note: Heap is not extracted from TelemetryState (only available via Status)
        assert!(info.heap().is_none());
    }
}