taskvisor 0.8.0

In-process Tokio task supervisor with retries, graceful shutdown, reliable final outcomes, and per-key admission control
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
//! Limits how many user-owned values one supervisor can retain.
//!
//! [`CapacityBroker`] sits between a started cleanup executor and [`DropReservation`](super::bundle::DropReservation) creation.
//! A request receives every requested unit or none. Dropping a healthy [`OwnershipPermit`] returns its units.
//! Cleanup that panics or is marked poisoned retires them.

use std::{
    collections::VecDeque,
    num::NonZeroUsize,
    sync::{
        Arc, Mutex,
        atomic::{AtomicU8, Ordering as AtomicOrdering},
    },
};

use tokio::sync::Notify;

use super::error::DropCapacityError;

/// A request remains in the broker queue.
const CAPACITY_WAITING: u8 = 0;

/// A complete grant waits for its request future to observe it.
const CAPACITY_GRANTED: u8 = 1;

/// The broker closed before the future took its grant.
const CAPACITY_CLOSED: u8 = 2;

/// The request future converted its grant into a permit.
const CAPACITY_TAKEN: u8 = 3;

/// Cancellation removed a queued request or returned an unobserved grant.
const CAPACITY_CANCELED: u8 = 4;

/// Atomic result state and wake signal for one waiting future.
struct CapacitySignal {
    /// One of the capacity state constants above.
    status: AtomicU8,
    /// Wakes the future after a grant or closure.
    changed: Notify,
}

impl CapacitySignal {
    /// Initializes a signal before the request enters the queue.
    fn waiting() -> Self {
        Self {
            status: AtomicU8::new(CAPACITY_WAITING),
            changed: Notify::new(),
        }
    }
}

/// Queue entry for one all-or-nothing request.
struct CapacityWaiter {
    /// Number of units that must be granted together.
    units: usize,
    /// Units granted past this request while it could not fit.
    bypassed_units: usize,
    /// Result state shared with the waiting future.
    signal: Arc<CapacitySignal>,
}

/// Mutable accounting for one configured ownership limit.
struct LimitedCapacityState {
    /// Units that are not granted or held by permits.
    available: usize,
    /// Units that remain usable after permanent retirement.
    effective_capacity: usize,
    /// Pending requests in arrival order.
    waiters: VecDeque<CapacityWaiter>,
}

/// Accounting selected by the public ownership-capacity setting.
enum CapacityMode {
    /// Admission follows the configured finite limit.
    Limited(LimitedCapacityState),
    /// Every non-zero request is admitted without capacity accounting.
    Unlimited,
}

/// Mutable admission state protected by the broker mutex.
struct CapacityState {
    /// Whether the broker rejects all new requests.
    closed: bool,
    /// Finite accounting or explicit unlimited admission.
    mode: CapacityMode,
}

/// Cancellation-safe ownership admission with bounded bypass.
///
/// An older request may be bypassed while it cannot fit. Each older request counts the units granted past it.
/// Newer requests may pass only while that count stays within the current effective capacity.
/// Once the count reaches the limit, released capacity accumulates for the older request.
pub(super) struct CapacityBroker {
    /// Original finite limit, or `None` for unlimited admission.
    limit: Option<NonZeroUsize>,
    /// Admission mode, closure, and any finite-capacity waiters.
    state: Mutex<CapacityState>,
}

/// Result of attempting admission before a future waits.
enum CapacityStart {
    /// The complete permit was available without queueing.
    Ready(OwnershipPermit),
    /// The request entered the bounded queue.
    Waiting(CapacityRequest),
}

/// Wait state that returns an abandoned grant to the broker.
struct CapacityRequest {
    /// Broker that owns the request queue.
    broker: Arc<CapacityBroker>,
    /// Units that must transfer together.
    units: usize,
    /// Result state registered with the broker queue.
    signal: Arc<CapacitySignal>,
    /// Whether `Drop` must remove the request or return its grant.
    active: bool,
}

impl CapacityRequest {
    /// Converts a complete asynchronous grant into a permit.
    ///
    /// The notification is enabled before reading the atomic state.
    /// This keeps a concurrent grant or close from being missed.
    ///
    /// # Errors
    ///
    /// Returns an error when admission closes before the complete grant is taken.
    async fn wait(mut self) -> Result<OwnershipPermit, DropCapacityError> {
        loop {
            let changed = self.signal.changed.notified();
            tokio::pin!(changed);
            changed.as_mut().enable();
            match self.signal.status.load(AtomicOrdering::Acquire) {
                CAPACITY_WAITING => changed.await,
                CAPACITY_GRANTED => {
                    self.signal
                        .status
                        .store(CAPACITY_TAKEN, AtomicOrdering::Release);
                    self.active = false;
                    return Ok(OwnershipPermit::new(Arc::clone(&self.broker), self.units));
                }
                CAPACITY_CLOSED => {
                    self.active = false;
                    return Err(self.broker.error());
                }
                _invalid => {
                    self.broker.close();
                    self.active = false;
                    return Err(self.broker.error());
                }
            }
        }
    }
}

impl Drop for CapacityRequest {
    /// Returns any grant that was not transferred into a permit.
    fn drop(&mut self) {
        if self.active {
            self.broker.cancel(self.units, &self.signal);
        }
    }
}

impl CapacityBroker {
    /// Opens a broker in finite or unlimited admission mode.
    pub(super) fn new(limit: Option<NonZeroUsize>) -> Arc<Self> {
        let mode = match limit {
            Some(limit) => CapacityMode::Limited(LimitedCapacityState {
                available: limit.get(),
                effective_capacity: limit.get(),
                waiters: VecDeque::new(),
            }),
            None => CapacityMode::Unlimited,
        };
        Arc::new(Self {
            limit,
            state: Mutex::new(CapacityState {
                closed: false,
                mode,
            }),
        })
    }

    /// Builds the typed rejection for this broker's admission mode.
    fn error(&self) -> DropCapacityError {
        DropCapacityError::new(self.limit)
    }

    /// Waits until every requested unit can move into one permit.
    ///
    /// # Errors
    ///
    /// Returns an error for an invalid request, a closed broker, an impossible
    /// request after capacity retirement, or a full waiter queue.
    pub(super) async fn acquire(
        self: &Arc<Self>,
        units: usize,
    ) -> Result<OwnershipPermit, DropCapacityError> {
        match self.start_acquire(units)? {
            CapacityStart::Ready(permit) => Ok(permit),
            CapacityStart::Waiting(request) => request.wait().await,
        }
    }

    /// Grants the complete request only when it can proceed immediately.
    ///
    /// # Errors
    ///
    /// Returns an error when the request is invalid, admission is closed, an
    /// older request is waiting, or the complete capacity is unavailable.
    pub(super) fn try_acquire(
        self: &Arc<Self>,
        units: usize,
    ) -> Result<OwnershipPermit, DropCapacityError> {
        if units == 0 || self.limit.is_some_and(|limit| units > limit.get()) {
            return Err(self.error());
        }
        let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        if state.closed {
            return Err(self.error());
        }
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return Ok(OwnershipPermit::new(Arc::clone(self), units));
        };
        if units > limited.effective_capacity
            || !limited.waiters.is_empty()
            || limited.available < units
        {
            return Err(self.error());
        }
        limited.available -= units;
        Ok(OwnershipPermit::new(Arc::clone(self), units))
    }

    /// Chooses immediate admission or registers one cancellation-safe waiter.
    ///
    /// Pending request metadata is limited to the original broker capacity.
    ///
    /// # Errors
    ///
    /// Returns an error for an invalid or impossible request, a closed broker, or a full waiter queue.
    fn start_acquire(self: &Arc<Self>, units: usize) -> Result<CapacityStart, DropCapacityError> {
        if units == 0 || self.limit.is_some_and(|limit| units > limit.get()) {
            return Err(self.error());
        }
        let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        if state.closed {
            return Err(self.error());
        }
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return Ok(CapacityStart::Ready(OwnershipPermit::new(
                Arc::clone(self),
                units,
            )));
        };
        if units > limited.effective_capacity {
            return Err(self.error());
        }
        if limited.waiters.is_empty() && limited.available >= units {
            limited.available -= units;
            return Ok(CapacityStart::Ready(OwnershipPermit::new(
                Arc::clone(self),
                units,
            )));
        }
        let capacity = self
            .limit
            .expect("limited capacity mode has a configured limit")
            .get();
        if limited.waiters.len() >= capacity {
            return Err(self.error());
        }

        let signal = Arc::new(CapacitySignal::waiting());
        limited.waiters.push_back(CapacityWaiter {
            units,
            bypassed_units: 0,
            signal: Arc::clone(&signal),
        });
        let (ready, valid) = Self::dispatch_limited(limited);
        if !valid {
            state.closed = true;
            let closed = Self::close_waiters_locked(&mut state);
            drop(state);
            Self::notify(closed);
            return Err(self.error());
        }
        drop(state);
        Self::notify(ready);
        Ok(CapacityStart::Waiting(CapacityRequest {
            broker: Arc::clone(self),
            units,
            signal,
            active: true,
        }))
    }

    /// Returns healthy units and dispatches newly feasible requests.
    fn release(&self, units: usize) {
        if units == 0 {
            return;
        }
        let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        let ready = if Self::return_capacity_locked(&mut state, units) {
            Self::dispatch_locked(&mut state)
        } else {
            Self::close_waiters_locked(&mut state)
        };
        drop(state);
        Self::notify(ready);
    }

    /// Permanently removes units whose cleanup cannot safely return them.
    ///
    /// Requests above the new effective limit are rejected.
    /// Feasible requests continue against the remaining units.
    fn retire(&self, units: usize) {
        if units == 0 {
            return;
        }
        let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        if state.closed {
            return;
        }
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return;
        };
        let mut rejected = Vec::new();
        let close = if let Some(effective_capacity) = limited.effective_capacity.checked_sub(units)
        {
            if limited.available > effective_capacity {
                true
            } else {
                limited.effective_capacity = effective_capacity;
                limited.waiters.retain(|waiter| {
                    if waiter.units <= effective_capacity {
                        true
                    } else {
                        waiter
                            .signal
                            .status
                            .store(CAPACITY_CLOSED, AtomicOrdering::Release);
                        rejected.push(Arc::clone(&waiter.signal));
                        false
                    }
                });
                effective_capacity == 0
            }
        } else {
            true
        };
        if close {
            state.closed = true;
            rejected.extend(Self::close_waiters_locked(&mut state));
        } else {
            rejected.extend(Self::dispatch_locked(&mut state));
        }
        drop(state);
        Self::notify(rejected);
    }

    /// Removes a waiting request or returns its unobserved grant.
    fn cancel(&self, units: usize, signal: &Arc<CapacitySignal>) {
        let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        match signal.status.load(AtomicOrdering::Acquire) {
            CAPACITY_WAITING => {
                let CapacityMode::Limited(limited) = &mut state.mode else {
                    state.closed = true;
                    signal
                        .status
                        .store(CAPACITY_CANCELED, AtomicOrdering::Release);
                    return;
                };
                if let Some(position) = limited
                    .waiters
                    .iter()
                    .position(|waiter| Arc::ptr_eq(&waiter.signal, signal))
                {
                    limited.waiters.remove(position);
                }
            }
            CAPACITY_GRANTED => {
                if !Self::return_capacity_locked(&mut state, units) {
                    signal
                        .status
                        .store(CAPACITY_CANCELED, AtomicOrdering::Release);
                    let closed = Self::close_waiters_locked(&mut state);
                    drop(state);
                    Self::notify(closed);
                    return;
                }
            }
            CAPACITY_CLOSED => {}
            CAPACITY_TAKEN | CAPACITY_CANCELED => return,
            _invalid => {
                state.closed = true;
                signal
                    .status
                    .store(CAPACITY_CANCELED, AtomicOrdering::Release);
                let closed = Self::close_waiters_locked(&mut state);
                drop(state);
                Self::notify(closed);
                return;
            }
        }
        signal
            .status
            .store(CAPACITY_CANCELED, AtomicOrdering::Release);
        let ready = Self::dispatch_locked(&mut state);
        drop(state);
        Self::notify(ready);
    }

    /// Rejects future admission and wakes every queued request.
    pub(super) fn close(&self) {
        let signals = {
            let mut state = self.state.lock().unwrap_or_else(|error| error.into_inner());
            if state.closed {
                return;
            }
            state.closed = true;
            Self::close_waiters_locked(&mut state)
        };
        Self::notify(signals);
    }

    /// Adds returned units while enforcing the effective limit.
    fn return_capacity_locked(state: &mut CapacityState, units: usize) -> bool {
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return true;
        };
        let Some(available) = limited.available.checked_add(units) else {
            state.closed = true;
            return false;
        };
        if available > limited.effective_capacity {
            state.closed = true;
            return false;
        }
        limited.available = available;
        true
    }

    /// Marks every queued request closed before removing it.
    fn close_waiters_locked(state: &mut CapacityState) -> Vec<Arc<CapacitySignal>> {
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return Vec::new();
        };
        limited
            .waiters
            .drain(..)
            .map(|waiter| {
                waiter
                    .signal
                    .status
                    .store(CAPACITY_CLOSED, AtomicOrdering::Release);
                waiter.signal
            })
            .collect()
    }

    /// Grants feasible requests without exceeding each older bypass budget.
    fn dispatch_locked(state: &mut CapacityState) -> Vec<Arc<CapacitySignal>> {
        if state.closed {
            return Vec::new();
        }
        let CapacityMode::Limited(limited) = &mut state.mode else {
            return Vec::new();
        };
        let (mut ready, valid) = Self::dispatch_limited(limited);
        if !valid {
            state.closed = true;
            ready.extend(Self::close_waiters_locked(state));
        }
        ready
    }

    /// Dispatches finite-capacity waiters and reports whether queue accounting remained valid.
    fn dispatch_limited(limited: &mut LimitedCapacityState) -> (Vec<Arc<CapacitySignal>>, bool) {
        let effective_capacity = limited.effective_capacity;
        let mut ready = Vec::new();
        loop {
            let mut selected = None;
            for (index, waiter) in limited.waiters.iter().enumerate() {
                if waiter.units <= limited.available {
                    let exceeds_bypass_budget = limited.waiters.iter().take(index).any(|older| {
                        older.bypassed_units.saturating_add(waiter.units) > effective_capacity
                    });
                    if exceeds_bypass_budget {
                        break;
                    }
                    selected = Some(index);
                    break;
                }
                if waiter.bypassed_units >= effective_capacity {
                    break;
                }
            }
            let Some(index) = selected else {
                break;
            };
            let granted_units = limited.waiters[index].units;
            for waiter in limited.waiters.iter_mut().take(index) {
                waiter.bypassed_units = waiter.bypassed_units.saturating_add(granted_units);
            }
            let Some(waiter) = limited.waiters.remove(index) else {
                return (ready, false);
            };
            limited.available -= waiter.units;
            waiter
                .signal
                .status
                .store(CAPACITY_GRANTED, AtomicOrdering::Release);
            ready.push(waiter.signal);
        }
        (ready, true)
    }

    /// Sends wakeups after the caller releases the broker mutex.
    fn notify(signals: Vec<Arc<CapacitySignal>>) {
        for signal in signals {
            signal.changed.notify_waiters();
        }
    }

    /// Reports currently uncharged units to white-box tests.
    #[cfg(test)]
    pub(super) fn available(&self) -> usize {
        let state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        let CapacityMode::Limited(limited) = &state.mode else {
            panic!("unlimited capacity has no available-unit count");
        };
        limited.available
    }

    /// Reports the post-retirement limit to white-box tests.
    #[cfg(test)]
    pub(super) fn effective_capacity(&self) -> usize {
        let state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        let CapacityMode::Limited(limited) = &state.mode else {
            panic!("unlimited capacity has no effective-unit count");
        };
        limited.effective_capacity
    }

    /// Reports the number of queued finite-capacity waiters to white-box tests.
    #[cfg(test)]
    pub(super) fn waiter_count(&self) -> usize {
        let state = self.state.lock().unwrap_or_else(|error| error.into_inner());
        match &state.mode {
            CapacityMode::Limited(limited) => limited.waiters.len(),
            CapacityMode::Unlimited => 0,
        }
    }
}

/// Capacity charged to one atomic admission result.
pub(super) struct OwnershipPermit {
    /// Broker that must receive release or retirement.
    broker: Arc<CapacityBroker>,
    /// Units still owned by this permit.
    units: usize,
}

impl OwnershipPermit {
    /// Records an all-or-nothing grant from the broker.
    fn new(broker: Arc<CapacityBroker>, units: usize) -> Self {
        Self { broker, units }
    }

    /// Moves one unit into an independent permit.
    pub(super) fn split_one(&mut self) -> Option<Self> {
        if self.units == 0 {
            return None;
        }
        self.units -= 1;
        Some(Self::new(Arc::clone(&self.broker), 1))
    }

    /// Retires every remaining unit in this permit.
    pub(super) fn retire(mut self) {
        let units = std::mem::take(&mut self.units);
        self.broker.retire(units);
    }

    /// Closes admission when this permit cannot reach a cleanup worker.
    pub(super) fn close_without_release(mut self) {
        self.units = 0;
        self.broker.close();
    }
}

impl Drop for OwnershipPermit {
    /// Returns every remaining healthy unit to the broker.
    fn drop(&mut self) {
        let units = std::mem::take(&mut self.units);
        self.broker.release(units);
    }
}