target-gen 0.29.0

use anyhow::{Context, Result, bail};
use probe_rs_target::{
    ArmCoreAccessOptions, Chip, ChipFamily, Core, CoreAccessOptions, CoreType, MemoryAccess,
    MemoryRange as _, MemoryRegion, NvmRegion, RamRegion, RawFlashAlgorithm,
    TargetDescriptionSource,
};
use std::{
    borrow::Cow,
    collections::HashMap,
    fmt::Write,
    fs::{File, OpenOptions},
    io::Write as _,
    ops::Range,
    path::Path,
};

use crate::parser::extract_flash_algo;

/// Prepare a target config based on an ELF file containing a flash algorithm.
pub fn cmd_elf(
    file: &Path,
    fixed_load_address: bool,
    output: Option<&Path>,
    update: bool,
    name: Option<String>,
) -> Result<()> {
    let elf_file = std::fs::read(file)
        .with_context(|| format!("Failed to open ELF file {}", file.display()))?;

    let mut algorithm = extract_flash_algo(None, &elf_file, file, true, fixed_load_address)?;

    if let Some(name) = &name {
        algorithm.name = name.clone();
    }

    if update {
        // Update an existing target file

        let target_description_file = output.unwrap(); // Argument is checked by structopt, so we now its present.

        let target_description = File::open(target_description_file).context(format!(
            "Unable to open target specification '{}'",
            target_description_file.display()
        ))?;

        let mut family: ChipFamily = serde_yaml::from_reader(target_description)?;

        let Some(algorithm_to_update) = family
            .flash_algorithms
            .iter()
            .position(|old_algorithm| old_algorithm.name == algorithm.name)
        else {
            bail!(
                "Unable to update flash algorithm in target description file '{}'. Did not find an existing algorithm with name '{}'",
                target_description_file.display(),
                &algorithm.name
            )
        };

        let current = &family.flash_algorithms[algorithm_to_update];
        // Re-extract the algorithm, keeping existing values in the target definition
        let mut algorithm = extract_flash_algo(
            Some(current.clone()),
            &elf_file,
            file,
            true,
            fixed_load_address,
        )?;
        if let Some(name) = name {
            algorithm.name = name;
        }

        // if a load address was specified, use it in the replacement
        if let Some(load_addr) = current.load_address {
            algorithm.load_address = Some(load_addr);
            algorithm.data_section_offset = algorithm.data_section_offset.saturating_sub(load_addr);
        }
        // core access cannot be determined, use the current value
        algorithm.cores.clone_from(&current.cores);
        algorithm.description.clone_from(&current.description);

        family.flash_algorithms[algorithm_to_update] = algorithm;

        let output_yaml = serialize_to_yaml_string(&family)?;
        std::fs::write(target_description_file, output_yaml)?;
    } else {
        // Create a complete target specification, with place holder values
        let algorithm_name = algorithm.name.clone();
        algorithm.cores = vec!["main".to_owned()];

        let chip_family = ChipFamily {
            name: "<family name>".to_owned(),
            manufacturer: None,
            generated_from_pack: false,
            chip_detection: vec![],
            pack_file_release: None,
            variants: vec![Chip {
                cores: vec![Core {
                    name: "main".to_owned(),
                    core_type: CoreType::Armv6m,
                    core_access_options: CoreAccessOptions::Arm(ArmCoreAccessOptions {
                        ap: probe_rs_target::ApAddress::V1(0),
                        targetsel: None,
                        debug_base: None,
                        cti_base: None,
                        jtag_tap: None,
                    }),
                }],
                part: None,
                svd: None,
                documentation: HashMap::new(),
                package_variants: vec![],
                name: "<chip name>".to_owned(),
                memory_map: vec![
                    MemoryRegion::Nvm(NvmRegion {
                        access: None,
                        range: 0..0x2000,
                        cores: vec!["main".to_owned()],
                        name: None,
                        is_alias: false,
                    }),
                    MemoryRegion::Ram(RamRegion {
                        range: 0x1_0000..0x2_0000,
                        cores: vec!["main".to_owned()],
                        name: None,
                        access: Some(MemoryAccess {
                            boot: true,
                            ..Default::default()
                        }),
                    }),
                ],
                flash_algorithms: vec![algorithm_name],
                rtt_scan_ranges: None,
                jtag: None,
                default_binary_format: None,
            }],
            flash_algorithms: vec![algorithm],
            source: TargetDescriptionSource::BuiltIn,
        };

        let output_yaml = serialize_to_yaml_string(&chip_family)?;
        match output {
            Some(output) => {
                // Ensure we don't overwrite an existing file
                let mut file = OpenOptions::new()
                    .write(true)
                    .create_new(true)
                    .open(output)
                    .context(format!(
                        "Failed to create target file '{}'.",
                        output.display()
                    ))?;

                file.write_all(output_yaml.as_bytes())?;
            }
            None => println!("{output_yaml}"),
        }
    }

    Ok(())
}

fn compact(family: &ChipFamily) -> ChipFamily {
    let mut out = family.clone();

    sort_memory_regions(&mut out);
    compact_flash_algos(&mut out);

    out
}

fn sort_memory_regions(out: &mut ChipFamily) {
    for variant in &mut out.variants {
        variant
            .memory_map
            .sort_by_key(|region| region.address_range().start);
    }
}

fn compact_flash_algos(out: &mut ChipFamily) {
    fn comparable_algo(algo: &RawFlashAlgorithm) -> RawFlashAlgorithm {
        let mut algo = algo.clone();
        algo.flash_properties.address_range.end = 0;
        algo.description = String::new();
        algo.name = String::new();
        algo
    }

    let mut renames = std::collections::HashMap::<String, String>::new();

    let algos = std::mem::take(&mut out.flash_algorithms);
    let mut algos_iter = algos.iter();
    while let Some(algo) = algos_iter.next() {
        if renames.contains_key(&algo.name) {
            continue;
        }

        // Collect renames because the new name may change during looping
        let mut renamed = vec![algo.name.clone()];

        // Find the algo with the widest address range and replace all others with it.
        let algo_template = comparable_algo(algo);
        let mut widest_algo = algo.clone();
        for algo_b in algos_iter.clone() {
            if renames.contains_key(&algo_b.name) {
                continue;
            }

            if algo_template == comparable_algo(algo_b) {
                renamed.push(algo_b.name.clone());

                if algo_b.flash_properties.address_range.end
                    > widest_algo.flash_properties.address_range.end
                {
                    widest_algo = algo_b.clone();
                }
            }
        }

        for renamed in renamed {
            renames.insert(renamed, widest_algo.name.clone());
        }
        if widest_algo.name != algo.name {
            // Keep the original algo, too. We will remove these if no uses remain.
            out.flash_algorithms.push(algo.clone());
        }
        out.flash_algorithms.push(widest_algo);
    }

    fn memory_range_of_algo(algo_name: &str, algos: &[RawFlashAlgorithm]) -> Option<Range<u64>> {
        algos
            .iter()
            .find(|a| a.name == algo_name)
            .map(|a| &a.flash_properties.address_range)
            .cloned()
    }

    // Now walk through the target variants' flash algo map and apply the renames
    for variant in &mut out.variants {
        for algo_name in &mut variant.flash_algorithms {
            let Some(replacement_name) = renames.get(algo_name) else {
                continue;
            };

            // Only algos that have memory regions in the memory map are subject to renaming.
            let memory_range = memory_range_of_algo(algo_name, &algos)
                .unwrap_or_else(|| panic!("Flash algorithm {algo_name} not found."));

            if !variant
                .memory_map
                .iter()
                .any(|region| region.address_range().intersects_range(&memory_range))
            {
                // This flash algo has no memory region, so we conjure up one ourselves. We can
                // only deduplicate these algos if the replacement has the same size.
                let replacement_memory_range = memory_range_of_algo(replacement_name, &algos)
                    .unwrap_or_else(|| panic!("Flash algorithm {replacement_name} not found."));

                if replacement_memory_range != memory_range {
                    continue;
                }
            }

            // Apply rename.
            algo_name.clone_from(replacement_name);
        }
    }

    // Remove flash algos with no uses
    out.flash_algorithms.retain(|algo| {
        out.variants
            .iter()
            .any(|variant| variant.flash_algorithms.contains(&algo.name))
    });
}

/// Some optimizations to improve the readability of the `serde_yaml` output:
/// - If `Option<T>` is `None`, it is serialized as `null` ... we want to omit it.
/// - If `Vec<T>` is empty, it is serialized as `[]` ... we want to omit it.
/// - `serde_yaml` serializes hex formatted integers as single quoted strings, e.g. '0x1234' ... we need to remove the single quotes so that it round-trips properly.
pub fn serialize_to_yaml_string(family: &ChipFamily) -> Result<String> {
    let family = compact(family);
    let raw_yaml_string = serde_yaml::to_string(&family)?;

    let mut yaml_string = String::with_capacity(raw_yaml_string.len());
    for reader_line in raw_yaml_string.lines() {
        let trimmed_line = reader_line.trim();
        if reader_line.ends_with(": null")
            || reader_line.ends_with(": []")
            || reader_line.ends_with(": {}")
            || reader_line.ends_with(": false")
        {
            // Some fields have default-looking, but significant values that we want to keep.
            let keep_default = [
                "rtt_scan_ranges: []",
                "read: false",
                "write: false",
                "execute: false",
                "stack_overflow_check: false",
            ];
            if !keep_default.contains(&trimmed_line) {
                // Skip the line
                continue;
            }
        } else {
            // Some fields have different default values than the type may indicate.
            let trim_nondefault = [
                "read: true",
                "write: true",
                "execute: true",
                "stack_overflow_check: true",
            ];
            if trim_nondefault.contains(&trimmed_line) {
                // Skip the line
                continue;
            }
        }

        let mut reader_line = Cow::Borrowed(reader_line);
        if (reader_line.contains("'0x") || reader_line.contains("'0X"))
            && (reader_line.ends_with('\'') || reader_line.contains("':"))
        {
            // Remove the single quotes
            reader_line = reader_line.replace('\'', "").into();
        }

        yaml_string.write_str(&reader_line)?;
        yaml_string.push('\n');
    }

    // Second pass: remove empty `access:` objects
    let mut output = String::with_capacity(yaml_string.len());
    let mut lines = yaml_string.lines().peekable();
    while let Some(line) = lines.next() {
        if line.trim() == "access:" {
            let Some(next) = lines.peek() else {
                // No other lines, access is empty, skip it
                continue;
            };

            let indent_level = line.find(|c: char| c != ' ').unwrap_or(0);
            let next_indent_level = next.find(|c: char| c != ' ').unwrap_or(0);
            if next_indent_level <= indent_level {
                // Access is empty, skip it
                continue;
            }
        }

        output.push_str(line);
        output.push('\n');
    }

    Ok(output)
}

#[cfg(test)]
mod test {
    use probe_rs_target::TargetDescriptionSource;

    use super::*;

    #[test]
    fn test_serialize_to_yaml_string_cuts_off_unnecessary_defaults() {
        let mut chip = Chip::generic_arm("Test Chip", CoreType::Armv8m);

        chip.memory_map.push(MemoryRegion::Ram(RamRegion {
            range: 0x20000000..0x20004000,
            cores: vec!["main".to_owned()],
            name: Some(String::from("SRAM")),
            access: Some(MemoryAccess::default()),
        }));
        chip.memory_map.push(MemoryRegion::Ram(RamRegion {
            range: 0x20004000..0x20008000,
            cores: vec!["main".to_owned()],
            name: Some(String::from("CCMRAM")),
            access: Some(MemoryAccess {
                boot: false,
                read: true,
                write: true,
                execute: false,
            }),
        }));
        chip.memory_map.push(MemoryRegion::Nvm(NvmRegion {
            range: 0x8000000..0x8010000,
            cores: vec!["main".to_owned()],
            name: Some(String::from("Flash")),
            access: None,
            is_alias: false,
        }));

        let family = ChipFamily {
            name: "Test Family".to_owned(),
            manufacturer: None,
            generated_from_pack: false,
            chip_detection: vec![],
            pack_file_release: None,
            variants: vec![chip],
            flash_algorithms: vec![],
            source: TargetDescriptionSource::BuiltIn,
        };
        let yaml_string = serialize_to_yaml_string(&family).unwrap();
        insta::assert_snapshot!("serialization_cleanup", yaml_string);
    }
}