tap-agent 0.7.0

Rust implementation of the Transaction Authorization Protocol (TAP)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
//! Key storage functionality for TAP Agent
//!
//! This module provides utilities for persisting agent keys to disk
//! and loading them later. This allows for persistent agent identities
//! across multiple runs.

use crate::did::{GeneratedKey, KeyType};
use crate::error::{Error, Result};
use crate::key_manager::{Secret, SecretMaterial, SecretType};
use base64::Engine;
use dirs::home_dir;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::env;
use std::fs;
use std::path::{Path, PathBuf};

/// Default directory for TAP configuration and keys
pub const DEFAULT_TAP_DIR: &str = ".tap";
/// Default filename for the keys file
pub const DEFAULT_KEYS_FILE: &str = "keys.json";

/// A structure representing a stored key
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct StoredKey {
    /// The DID for this key
    pub did: String,
    /// Human-friendly label for this key
    #[serde(default)]
    pub label: String,
    /// The key type (e.g., Ed25519, P256)
    #[serde(with = "key_type_serde")]
    pub key_type: KeyType,
    /// Base64-encoded private key
    pub private_key: String,
    /// Base64-encoded public key
    pub public_key: String,
    /// Optional metadata for this key
    #[serde(default)]
    pub metadata: HashMap<String, String>,
}

/// Serialization helper for KeyType
mod key_type_serde {
    use super::KeyType;
    use serde::{Deserialize, Deserializer, Serializer};

    pub fn serialize<S>(key_type: &KeyType, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer,
    {
        let s = match key_type {
            #[cfg(feature = "crypto-ed25519")]
            KeyType::Ed25519 => "Ed25519",
            #[cfg(feature = "crypto-p256")]
            KeyType::P256 => "P256",
            #[cfg(feature = "crypto-secp256k1")]
            KeyType::Secp256k1 => "Secp256k1",
        };
        serializer.serialize_str(s)
    }

    pub fn deserialize<'de, D>(deserializer: D) -> Result<KeyType, D::Error>
    where
        D: Deserializer<'de>,
    {
        let s = String::deserialize(deserializer)?;
        match s.as_str() {
            #[cfg(feature = "crypto-ed25519")]
            "Ed25519" => Ok(KeyType::Ed25519),
            #[cfg(feature = "crypto-p256")]
            "P256" => Ok(KeyType::P256),
            #[cfg(feature = "crypto-secp256k1")]
            "Secp256k1" => Ok(KeyType::Secp256k1),
            _ => Err(serde::de::Error::custom(format!(
                "Unknown or disabled key type: {}",
                s
            ))),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use serial_test::serial;
    use std::env;
    use tempfile::TempDir;

    #[test]
    #[serial]
    fn test_tap_home_environment_variable() {
        // Save current env vars
        let old_home = env::var("TAP_HOME").ok();
        let old_test = env::var("TAP_TEST_DIR").ok();

        // Clear env vars
        env::remove_var("TAP_HOME");
        env::remove_var("TAP_TEST_DIR");

        // Create a temporary directory
        let temp_dir = TempDir::new().unwrap();
        let temp_path = temp_dir.path().to_path_buf();

        // Set TAP_HOME
        env::set_var("TAP_HOME", &temp_path);

        // Get the default key path
        let key_path = KeyStorage::default_key_path().unwrap();

        // Verify it uses TAP_HOME
        assert_eq!(key_path, temp_path.join(DEFAULT_KEYS_FILE));

        // Restore env vars
        env::remove_var("TAP_HOME");
        if let Some(val) = old_home {
            env::set_var("TAP_HOME", val);
        }
        if let Some(val) = old_test {
            env::set_var("TAP_TEST_DIR", val);
        }
    }

    #[test]
    #[serial]
    fn test_tap_test_dir_environment_variable() {
        // Save current env vars
        let old_home = env::var("TAP_HOME").ok();
        let old_test = env::var("TAP_TEST_DIR").ok();

        // Clear env vars
        env::remove_var("TAP_HOME");
        env::remove_var("TAP_TEST_DIR");

        // Create a temporary directory and keep it alive
        let temp_dir = TempDir::new().unwrap();
        let temp_path = temp_dir.path().to_path_buf();

        // Set TAP_TEST_DIR
        env::set_var("TAP_TEST_DIR", &temp_path);

        // Get the default key path
        let key_path = KeyStorage::default_key_path().unwrap();

        // Verify it uses TAP_TEST_DIR/.tap
        let expected_path = temp_path.join(DEFAULT_TAP_DIR).join(DEFAULT_KEYS_FILE);
        assert_eq!(key_path, expected_path);

        // Restore env vars
        env::remove_var("TAP_TEST_DIR");
        if let Some(val) = old_home {
            env::set_var("TAP_HOME", val);
        }
        if let Some(val) = old_test {
            env::set_var("TAP_TEST_DIR", val);
        }

        // Keep temp_dir alive until the end of the test
        drop(temp_dir);
    }

    #[test]
    #[serial]
    fn test_environment_variable_priority() {
        // Save current env vars
        let old_home = env::var("TAP_HOME").ok();
        let old_test = env::var("TAP_TEST_DIR").ok();

        // Create temporary directories
        let home_dir = TempDir::new().unwrap();
        let test_dir = TempDir::new().unwrap();

        let home_path = home_dir.path().to_path_buf();
        let test_path = test_dir.path().to_path_buf();

        // Set both TAP_HOME and TAP_TEST_DIR
        env::set_var("TAP_HOME", &home_path);
        env::set_var("TAP_TEST_DIR", &test_path);

        // Get the default key path
        let key_path = KeyStorage::default_key_path().unwrap();

        // Verify TAP_HOME takes priority
        assert_eq!(key_path, home_path.join(DEFAULT_KEYS_FILE));

        // Restore env vars
        env::remove_var("TAP_HOME");
        env::remove_var("TAP_TEST_DIR");
        if let Some(val) = old_home {
            env::set_var("TAP_HOME", val);
        }
        if let Some(val) = old_test {
            env::set_var("TAP_TEST_DIR", val);
        }
    }

    #[test]
    #[serial]
    fn test_agent_directory_with_tap_home() {
        // Save current env vars
        let old_home = env::var("TAP_HOME").ok();
        let old_test = env::var("TAP_TEST_DIR").ok();

        // Clear env vars
        env::remove_var("TAP_HOME");
        env::remove_var("TAP_TEST_DIR");

        // Create a temporary directory
        let temp_dir = TempDir::new().unwrap();
        let temp_path = temp_dir.path().to_path_buf();

        // Set TAP_HOME
        env::set_var("TAP_HOME", &temp_path);

        // Create a storage instance
        let storage = KeyStorage::new();

        // Get agent directory (function expects pre-sanitized DID)
        let sanitized = sanitize_did("did:key:test123");
        let agent_dir = storage.get_agent_directory(&sanitized).unwrap();

        // Verify it uses TAP_HOME with sanitized DID
        assert_eq!(agent_dir, temp_path.join("did_key_test123"));

        // Restore env vars
        env::remove_var("TAP_HOME");
        if let Some(val) = old_home {
            env::set_var("TAP_HOME", val);
        }
        if let Some(val) = old_test {
            env::set_var("TAP_TEST_DIR", val);
        }
    }

    #[test]
    #[serial]
    fn test_storage_persistence_with_temp_dir() {
        use crate::test_utils::TestStorage;

        // Use TestStorage for complete isolation - no environment variable manipulation needed
        let test_storage = TestStorage::new().unwrap();

        // Create and save storage using the isolated test environment
        let mut storage = KeyStorage::new();
        storage.add_key(StoredKey {
            did: "did:key:test".to_string(),
            label: "test-key".to_string(),
            key_type: KeyType::Ed25519,
            private_key: "test-private".to_string(),
            public_key: "test-public".to_string(),
            metadata: HashMap::new(),
        });

        // Save using the test storage's path (isolated from global state)
        test_storage.save(&storage).unwrap();

        // Verify file was created
        assert!(
            test_storage.path().exists(),
            "Keys file should exist at: {:?}",
            test_storage.path()
        );

        // Load it back using the same isolated storage
        let loaded = test_storage.load().unwrap();
        assert_eq!(
            loaded.keys.len(),
            1,
            "Should have exactly 1 key in loaded storage"
        );
        assert!(
            loaded.keys.contains_key("did:key:test"),
            "Should contain the test key"
        );
    }

    #[cfg(unix)]
    #[test]
    #[serial]
    fn test_key_storage_file_permissions() {
        use crate::test_utils::TestStorage;
        use std::os::unix::fs::PermissionsExt;

        // Use TestStorage for complete isolation
        let test_storage = TestStorage::new().unwrap();

        // Create and save storage
        let mut storage = KeyStorage::new();
        storage.add_key(StoredKey {
            did: "did:key:test".to_string(),
            label: "test-key".to_string(),
            key_type: KeyType::Ed25519,
            private_key: "test-private-key-material".to_string(),
            public_key: "test-public".to_string(),
            metadata: HashMap::new(),
        });

        // Save to create the file
        test_storage.save(&storage).unwrap();

        // Verify file permissions are 0o600 (owner read/write only)
        let metadata = fs::metadata(test_storage.path()).unwrap();
        let permissions = metadata.permissions();
        let mode = permissions.mode() & 0o777; // Mask to get just permission bits

        assert_eq!(
            mode, 0o600,
            "Key storage file should have permissions 0o600 (owner read/write only), got {:o}",
            mode
        );
    }
}

/// A collection of stored keys
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct KeyStorage {
    /// A map of DIDs to their stored keys
    pub keys: HashMap<String, StoredKey>,
    /// The default DID to use when not specified
    pub default_did: Option<String>,
    /// Creation timestamp
    #[serde(default = "chrono::Utc::now")]
    pub created_at: chrono::DateTime<chrono::Utc>,
    /// Last update timestamp
    #[serde(default = "chrono::Utc::now")]
    pub updated_at: chrono::DateTime<chrono::Utc>,
    /// Base directory for agent subdirectories (not serialized, runtime only)
    #[serde(skip)]
    base_directory: Option<PathBuf>,
}

impl KeyStorage {
    /// Create a new empty key storage
    pub fn new() -> Self {
        Default::default()
    }

    /// Add a key to the storage
    pub fn add_key(&mut self, mut key: StoredKey) {
        // Generate default label if not provided
        if key.label.is_empty() {
            key.label = self.generate_default_label();
        }

        // Ensure label is unique
        let final_label = self.ensure_unique_label(&key.label, Some(&key.did));
        key.label = final_label.clone();

        // If this is the first key, make it the default
        if self.keys.is_empty() {
            self.default_did = Some(key.did.clone());
        }

        self.keys.insert(key.did.clone(), key);
        self.updated_at = chrono::Utc::now();
    }

    /// Generate a default label in the format agent-{n}
    fn generate_default_label(&self) -> String {
        let mut counter = 1;
        loop {
            let label = format!("agent-{}", counter);
            if !self.keys.values().any(|key| key.label == label) {
                return label;
            }
            counter += 1;
        }
    }

    /// Ensure a label is unique, modifying it if necessary
    fn ensure_unique_label(&self, desired_label: &str, exclude_did: Option<&str>) -> String {
        // Check if the label exists in any key
        if let Some(existing_key) = self.keys.values().find(|key| key.label == desired_label) {
            // If it belongs to the same DID we're updating, it's fine
            if exclude_did.is_some() && existing_key.did == exclude_did.unwrap() {
                return desired_label.to_string();
            }
        } else {
            // Label doesn't exist, so it's available
            return desired_label.to_string();
        }

        // Generate a unique label by appending a number
        let mut counter = 2;
        loop {
            let new_label = format!("{}-{}", desired_label, counter);
            if !self.keys.values().any(|key| key.label == new_label) {
                return new_label;
            }
            counter += 1;
        }
    }

    /// Find a key by label
    pub fn find_by_label(&self, label: &str) -> Option<&StoredKey> {
        self.keys.values().find(|key| key.label == label)
    }

    /// Update a key's label
    pub fn update_label(&mut self, did: &str, new_label: &str) -> Result<()> {
        // First ensure the key exists
        if !self.keys.contains_key(did) {
            return Err(Error::Storage(format!("Key with DID '{}' not found", did)));
        }

        // Ensure new label is unique
        let final_label = self.ensure_unique_label(new_label, Some(did));

        // Update the key's label
        if let Some(key) = self.keys.get_mut(did) {
            key.label = final_label;
        }

        self.updated_at = chrono::Utc::now();
        Ok(())
    }

    /// Get the default key path
    pub fn default_key_path() -> Option<PathBuf> {
        // Check for TAP_HOME environment variable first (useful for tests)
        if let Ok(tap_home) = env::var("TAP_HOME") {
            return Some(PathBuf::from(tap_home).join(DEFAULT_KEYS_FILE));
        }

        // Check for TAP_TEST_DIR environment variable (for tests/examples)
        if let Ok(test_dir) = env::var("TAP_TEST_DIR") {
            return Some(
                PathBuf::from(test_dir)
                    .join(DEFAULT_TAP_DIR)
                    .join(DEFAULT_KEYS_FILE),
            );
        }

        // Default to home directory
        home_dir().map(|home| home.join(DEFAULT_TAP_DIR).join(DEFAULT_KEYS_FILE))
    }

    /// Load keys from the default location
    pub fn load_default() -> Result<Self> {
        let path = Self::default_key_path().ok_or_else(|| {
            Error::Storage("Could not determine home directory for default key path".to_string())
        })?;
        Self::load_from_path(&path)
    }

    /// Load keys from a specific path
    pub fn load_from_path(path: &Path) -> Result<Self> {
        let mut storage = if !path.exists() {
            Self::new()
        } else {
            let contents = fs::read_to_string(path)
                .map_err(|e| Error::Storage(format!("Failed to read key storage file: {}", e)))?;

            let mut storage: KeyStorage = serde_json::from_str(&contents)
                .map_err(|e| Error::Storage(format!("Failed to parse key storage file: {}", e)))?;

            // Ensure all keys have labels (for backward compatibility)
            storage.ensure_all_keys_have_labels();

            storage
        };

        // Set base directory from the path for agent subdirectories
        if let Some(parent) = path.parent() {
            storage.base_directory = Some(parent.to_path_buf());
        }

        Ok(storage)
    }

    /// Ensure all keys have labels (for backward compatibility)
    fn ensure_all_keys_have_labels(&mut self) {
        let mut keys_to_update = Vec::new();

        for (did, key) in &self.keys {
            if key.label.is_empty() {
                keys_to_update.push(did.clone());
            }
        }

        for did in keys_to_update {
            let new_label = self.generate_default_label();
            if let Some(key) = self.keys.get_mut(&did) {
                key.label = new_label;
            }
        }
    }

    /// Save keys to the default location
    pub fn save_default(&self) -> Result<()> {
        let path = Self::default_key_path().ok_or_else(|| {
            Error::Storage("Could not determine home directory for default key path".to_string())
        })?;

        // Ensure directory exists
        if let Some(parent) = path.parent() {
            fs::create_dir_all(parent).map_err(|e| {
                Error::Storage(format!("Failed to create key storage directory: {}", e))
            })?;
        }

        self.save_to_path(&path)
    }

    /// Save keys to a specific path
    ///
    /// On Unix systems, the file is created with restrictive permissions (0o600)
    /// to protect private key material from unauthorized access.
    pub fn save_to_path(&self, path: &Path) -> Result<()> {
        let contents = serde_json::to_string_pretty(self)
            .map_err(|e| Error::Storage(format!("Failed to serialize key storage: {}", e)))?;

        fs::write(path, &contents)
            .map_err(|e| Error::Storage(format!("Failed to write key storage file: {}", e)))?;

        // Set restrictive permissions on Unix systems (owner read/write only)
        set_secure_file_permissions(path)?;

        Ok(())
    }

    /// Convert a GeneratedKey to a StoredKey
    pub fn from_generated_key(key: &GeneratedKey) -> StoredKey {
        StoredKey {
            did: key.did.clone(),
            label: String::new(), // Will be set when added to storage
            key_type: key.key_type,
            private_key: base64::engine::general_purpose::STANDARD.encode(&key.private_key),
            public_key: base64::engine::general_purpose::STANDARD.encode(&key.public_key),
            metadata: HashMap::new(),
        }
    }

    /// Convert a GeneratedKey to a StoredKey with a specific label
    pub fn from_generated_key_with_label(key: &GeneratedKey, label: &str) -> StoredKey {
        StoredKey {
            did: key.did.clone(),
            label: label.to_string(),
            key_type: key.key_type,
            private_key: base64::engine::general_purpose::STANDARD.encode(&key.private_key),
            public_key: base64::engine::general_purpose::STANDARD.encode(&key.public_key),
            metadata: HashMap::new(),
        }
    }

    /// Convert a StoredKey to a Secret
    pub fn to_secret(key: &StoredKey) -> Secret {
        Secret {
            id: key.did.clone(),
            type_: SecretType::JsonWebKey2020,
            secret_material: SecretMaterial::JWK {
                private_key_jwk: generate_jwk_for_key(key),
            },
        }
    }
    /// Create agent directory and save policies/metadata files
    ///
    /// On Unix systems, files are created with restrictive permissions (0o600)
    /// to protect sensitive agent configuration from unauthorized access.
    pub fn create_agent_directory(
        &self,
        did: &str,
        policies: &[String],
        metadata: &HashMap<String, String>,
    ) -> Result<()> {
        let sanitized_did = sanitize_did(did);
        let agent_dir = self.get_agent_directory(&sanitized_did)?;

        // Create the agent directory
        fs::create_dir_all(&agent_dir).map_err(|e| {
            Error::Storage(format!(
                "Failed to create agent directory {}: {}",
                agent_dir.display(),
                e
            ))
        })?;

        // Set restrictive permissions on the agent directory (owner rwx only)
        #[cfg(unix)]
        {
            use std::os::unix::fs::PermissionsExt;
            let dir_permissions = fs::Permissions::from_mode(0o700);
            fs::set_permissions(&agent_dir, dir_permissions).map_err(|e| {
                Error::Storage(format!("Failed to set agent directory permissions: {}", e))
            })?;
        }

        // Save policies.json
        let policies_file = agent_dir.join("policies.json");
        let policies_json = serde_json::to_string_pretty(policies)
            .map_err(|e| Error::Storage(format!("Failed to serialize policies: {}", e)))?;
        fs::write(&policies_file, &policies_json)
            .map_err(|e| Error::Storage(format!("Failed to write policies file: {}", e)))?;
        set_secure_file_permissions(&policies_file)?;

        // Save metadata.json
        let metadata_file = agent_dir.join("metadata.json");
        let metadata_json = serde_json::to_string_pretty(metadata)
            .map_err(|e| Error::Storage(format!("Failed to serialize metadata: {}", e)))?;
        fs::write(&metadata_file, &metadata_json)
            .map_err(|e| Error::Storage(format!("Failed to write metadata file: {}", e)))?;
        set_secure_file_permissions(&metadata_file)?;

        Ok(())
    }

    /// Load policies from agent directory
    pub fn load_agent_policies(&self, did: &str) -> Result<Vec<String>> {
        let sanitized_did = sanitize_did(did);
        let agent_dir = self.get_agent_directory(&sanitized_did)?;
        let policies_file = agent_dir.join("policies.json");

        if !policies_file.exists() {
            return Ok(vec![]);
        }

        let content = fs::read_to_string(&policies_file)
            .map_err(|e| Error::Storage(format!("Failed to read policies file: {}", e)))?;

        serde_json::from_str(&content)
            .map_err(|e| Error::Storage(format!("Failed to parse policies file: {}", e)))
    }

    /// Load metadata from agent directory
    pub fn load_agent_metadata(&self, did: &str) -> Result<HashMap<String, String>> {
        let sanitized_did = sanitize_did(did);
        let agent_dir = self.get_agent_directory(&sanitized_did)?;
        let metadata_file = agent_dir.join("metadata.json");

        if !metadata_file.exists() {
            return Ok(HashMap::new());
        }

        let content = fs::read_to_string(&metadata_file)
            .map_err(|e| Error::Storage(format!("Failed to read metadata file: {}", e)))?;

        serde_json::from_str(&content)
            .map_err(|e| Error::Storage(format!("Failed to parse metadata file: {}", e)))
    }

    /// Get the agent directory path for a given DID
    fn get_agent_directory(&self, sanitized_did: &str) -> Result<PathBuf> {
        let base_dir = if let Some(ref base) = self.base_directory {
            base.clone()
        } else {
            // Check for TAP_HOME environment variable first
            if let Ok(tap_home) = env::var("TAP_HOME") {
                PathBuf::from(tap_home)
            } else if let Ok(test_dir) = env::var("TAP_TEST_DIR") {
                // For tests, use TAP_TEST_DIR/.tap
                PathBuf::from(test_dir).join(DEFAULT_TAP_DIR)
            } else {
                let home = home_dir().ok_or_else(|| {
                    Error::Storage("Could not determine home directory".to_string())
                })?;
                home.join(DEFAULT_TAP_DIR)
            }
        };
        Ok(base_dir.join(sanitized_did))
    }
}

/// Sanitize a DID for use as a directory name (same as TAP Node)
fn sanitize_did(did: &str) -> String {
    did.replace(':', "_")
}

/// Set restrictive file permissions (owner read/write only) on Unix systems
///
/// This is a no-op on non-Unix systems.
#[allow(unused_variables)]
fn set_secure_file_permissions(path: &Path) -> Result<()> {
    #[cfg(unix)]
    {
        use std::os::unix::fs::PermissionsExt;
        let permissions = fs::Permissions::from_mode(0o600);
        fs::set_permissions(path, permissions).map_err(|e| {
            Error::Storage(format!(
                "Failed to set secure permissions on {}: {}",
                path.display(),
                e
            ))
        })?;
    }
    Ok(())
}

/// Generate a JWK for a stored key
fn generate_jwk_for_key(key: &StoredKey) -> serde_json::Value {
    // Generate the proper key ID based on DID type
    let kid = if key.did.starts_with("did:key:") {
        // For did:key, extract the multibase key and use it as fragment
        // did:key:z6Mk... -> did:key:z6Mk...#z6Mk...
        let key_part = &key.did[8..]; // Skip "did:key:"
        format!("{}#{}", key.did, key_part)
    } else {
        // For other DID methods, use #keys-1 as default
        format!("{}#keys-1", key.did)
    };

    match key.key_type {
        #[cfg(feature = "crypto-ed25519")]
        KeyType::Ed25519 => {
            serde_json::json!({
                "kty": "OKP",
                "crv": "Ed25519",
                "x": key.public_key,
                "d": key.private_key,
                "kid": kid
            })
        }
        #[cfg(feature = "crypto-p256")]
        KeyType::P256 => {
            serde_json::json!({
                "kty": "EC",
                "crv": "P-256",
                "x": key.public_key,
                "d": key.private_key,
                "kid": kid
            })
        }
        #[cfg(feature = "crypto-secp256k1")]
        KeyType::Secp256k1 => {
            serde_json::json!({
                "kty": "EC",
                "crv": "secp256k1",
                "x": key.public_key,
                "d": key.private_key,
                "kid": kid
            })
        }
    }
}