tandem-server 0.7.2

HTTP server for Tandem engine APIs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
// Copyright (c) 2026 Frumu LTD
// Licensed under the Business Source License 1.1

use super::*;
use sha2::Digest;

fn direct_loopback_request() -> axum::http::request::Builder {
    Request::builder().extension(axum::extract::ConnectInfo(
        "127.0.0.1:39731"
            .parse::<std::net::SocketAddr>()
            .expect("loopback socket address"),
    ))
}

fn verified_channel_actor(
    tenant_context: tandem_types::TenantContext,
    actor_id: &str,
    deployment_admin: bool,
) -> tandem_types::VerifiedTenantContext {
    let now = crate::now_ms();
    tandem_types::VerifiedTenantContext {
        tenant_context,
        human_actor: tandem_types::HumanActor::tandem_user(actor_id),
        authority_chain: tandem_types::AuthorityChain::from_request(
            tandem_types::RequestPrincipal::authenticated_user(actor_id, "channel-test"),
        ),
        roles: Vec::new(),
        org_units: Vec::new(),
        capabilities: deployment_admin
            .then(|| vec!["deployment.admin".to_string()])
            .unwrap_or_default(),
        policy_version: None,
        strict_projection: None,
        issuer: "channel-test".to_string(),
        audience: "tandem".to_string(),
        issued_at_ms: now,
        expires_at_ms: now.saturating_add(60_000),
        assertion_id: format!("channel-test-{actor_id}-{now}"),
        assertion_key_id: None,
    }
}

pub(super) fn channel_tenant_request(
    method: &str,
    uri: &str,
    org_id: &str,
    workspace_id: &str,
    actor_id: &str,
    deployment_admin: bool,
    body: Value,
) -> Request<Body> {
    let tenant =
        tandem_types::TenantContext::explicit_user_workspace(org_id, workspace_id, None, actor_id);
    Request::builder()
        .extension(axum::extract::ConnectInfo(
            "198.51.100.44:443"
                .parse::<std::net::SocketAddr>()
                .expect("remote socket address"),
        ))
        .extension(verified_channel_actor(tenant, actor_id, deployment_admin))
        .method(method)
        .uri(uri)
        .header("content-type", "application/json")
        .header("x-tandem-org-id", org_id)
        .header("x-tandem-workspace-id", workspace_id)
        .header("x-tandem-actor-id", actor_id)
        .body(Body::from(body.to_string()))
        .expect("channel tenant request")
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_config_returns_non_secret_shape() {
    let state = test_state().await;
    let _ = state
        .config
        .patch_project(json!({
            "channels": {
                "telegram": {
                    "bot_token": "tg-secret",
                    "allowed_users": ["@alice", "@bob"],
                    "mention_only": true,
                    "strict_kb_grounding": true
                },
                "discord": {
                    "bot_token": "dc-secret",
                    "allowed_users": ["*"],
                    "mention_only": false,
                    "guild_id": "1234",
                    "strict_kb_grounding": true,
                    "model_provider_id": "openai",
                    "model_id": "gpt-4.1-mini"
                },
                "slack": {
                    "bot_token": "sl-secret",
                    "channel_id": "C123",
                    "allowed_users": ["U1"],
                    "mention_only": true,
                    "strict_kb_grounding": false
                }
            }
        }))
        .await
        .expect("patch project");
    let app = app_router(state);

    let req = direct_loopback_request()
        .method("GET")
        .uri("/channels/config")
        .body(Body::empty())
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let body = to_bytes(resp.into_body(), usize::MAX)
        .await
        .expect("response body");
    let payload: Value = serde_json::from_slice(&body).expect("json body");
    assert_eq!(
        payload
            .get("telegram")
            .and_then(|v| v.get("has_token"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("telegram")
            .and_then(|v| v.get("token_masked"))
            .and_then(Value::as_str),
        Some("****")
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("token_masked"))
            .and_then(Value::as_str),
        Some("****")
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("strict_kb_grounding"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("telegram")
            .and_then(|v| v.get("strict_kb_grounding"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_provider_id"))
            .and_then(Value::as_str),
        Some("openai")
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_id"))
            .and_then(Value::as_str),
        Some("gpt-4.1-mini")
    );
    assert_eq!(
        payload
            .get("slack")
            .and_then(|v| v.get("token_masked"))
            .and_then(Value::as_str),
        Some("****")
    );
    assert!(payload
        .get("telegram")
        .and_then(Value::as_object)
        .is_some_and(|obj| !obj.contains_key("bot_token")));
    assert!(payload
        .get("discord")
        .and_then(Value::as_object)
        .is_some_and(|obj| !obj.contains_key("bot_token")));
    assert!(payload
        .get("slack")
        .and_then(Value::as_object)
        .is_some_and(|obj| !obj.contains_key("bot_token")));
    assert_eq!(
        payload
            .get("slack")
            .and_then(|v| v.get("mention_only"))
            .and_then(Value::as_bool),
        Some(true)
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_roundtrips_model_override() {
    let state = test_state().await;
    let app = app_router(state.clone());

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/discord")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "bot_token": "dc-secret",
                "allowed_users": ["*"],
                "mention_only": true,
                "guild_id": "1234",
                "strict_kb_grounding": true,
                "model_provider_id": "openai",
                "model_id": "gpt-4.1-mini"
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let config_req = direct_loopback_request()
        .method("GET")
        .uri("/channels/config")
        .body(Body::empty())
        .expect("request");
    let config_resp = app.clone().oneshot(config_req).await.expect("response");
    assert_eq!(config_resp.status(), StatusCode::OK);

    let body = to_bytes(config_resp.into_body(), usize::MAX)
        .await
        .expect("response body");
    let payload: Value = serde_json::from_slice(&body).expect("json body");
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("strict_kb_grounding"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_provider_id"))
            .and_then(Value::as_str),
        Some("openai")
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_id"))
            .and_then(Value::as_str),
        Some("gpt-4.1-mini")
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_preserves_existing_token_when_only_model_changes() {
    let state = test_state().await;
    let _ = state
        .config
        .patch_project(json!({
            "channels": {
                "discord": {
                    "bot_token": "dc-secret",
                    "allowed_users": ["*"],
                    "mention_only": true,
                    "guild_id": "1234"
                }
            }
        }))
        .await
        .expect("patch project");
    let app = app_router(state.clone());

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/discord")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "allowed_users": ["*"],
                "mention_only": true,
                "guild_id": "1234",
                "strict_kb_grounding": true,
                "model_provider_id": "openai",
                "model_id": "gpt-4.1-mini"
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let config_req = direct_loopback_request()
        .method("GET")
        .uri("/channels/config")
        .body(Body::empty())
        .expect("request");
    let config_resp = app.clone().oneshot(config_req).await.expect("response");
    assert_eq!(config_resp.status(), StatusCode::OK);

    let body = to_bytes(config_resp.into_body(), usize::MAX)
        .await
        .expect("response body");
    let payload: Value = serde_json::from_slice(&body).expect("json body");
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("strict_kb_grounding"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("has_token"))
            .and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_provider_id"))
            .and_then(Value::as_str),
        Some("openai")
    );
    assert_eq!(
        payload
            .get("discord")
            .and_then(|v| v.get("model_id"))
            .and_then(Value::as_str),
        Some("gpt-4.1-mini")
    );
}

/// PR #1910 review: `GET /channels/config` exposes Slack connections only as
/// a `connections_summary` (never under the real `connections` config key),
/// and a PUT that echoes such a sanitized snapshot back must not wipe the
/// stored installation identity, secrets, or per-connection bindings.
#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_echoing_sanitized_config_preserves_slack_connections() {
    let state = test_state().await;
    let _ = state
        .config
        .patch_project(json!({
            "channels": {
                "slack": {
                    "bot_token": "xoxb-secret",
                    "channel_id": "C_MAIN",
                    "signing_secret": "shhh",
                    "events_enabled": true,
                    "team_id": "T1",
                    "app_id": "A1",
                    "tenant": { "org_id": "acme", "workspace_id": "hq" },
                    "connections": [
                        { "channel_id": "C_SALES", "org_units": ["sales"] }
                    ]
                }
            }
        }))
        .await
        .expect("patch project");
    let app = app_router(state.clone());

    // The config snapshot must carry the summary under a non-config key.
    let config_req = direct_loopback_request()
        .method("GET")
        .uri("/channels/config")
        .body(Body::empty())
        .expect("request");
    let config_resp = app.clone().oneshot(config_req).await.expect("response");
    let body = to_bytes(config_resp.into_body(), usize::MAX)
        .await
        .expect("response body");
    let payload: Value = serde_json::from_slice(&body).expect("json body");
    let slack = payload.get("slack").expect("slack entry");
    assert!(
        slack.get("connections").is_none(),
        "the sanitized snapshot must not expose a `connections` config key"
    );
    assert_eq!(
        slack.get("allowed_users"),
        Some(&json!([])),
        "a missing Slack allowlist is deny-all on signed ingress and must \
         not be reported as a '*' wildcard"
    );
    let summary = slack
        .get("connections_summary")
        .and_then(Value::as_array)
        .expect("connections_summary rows");
    assert_eq!(summary.len(), 2, "top-level + per-connection entries");

    // Echo a sanitized snapshot back (the Channels page Reconnect shape):
    // no secrets, no connections, the snapshot's (empty) allowlist, plus
    // the summary key the server ignores.
    let put_req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "channel_id": "C_MAIN",
                "allowed_users": slack.get("allowed_users"),
                "mention_only": false,
                "connections_summary": summary,
            })
            .to_string(),
        ))
        .expect("request");
    let put_resp = app.clone().oneshot(put_req).await.expect("response");
    assert_eq!(put_resp.status(), StatusCode::OK);

    let stored = state.config.get_project_value().await;
    let slack = stored
        .pointer("/channels/slack")
        .expect("stored slack config");
    assert_eq!(
        slack.pointer("/signing_secret").and_then(Value::as_str),
        Some("shhh"),
        "echoed sanitized config must not wipe the signing secret"
    );
    assert_eq!(
        slack.pointer("/team_id").and_then(Value::as_str),
        Some("T1")
    );
    assert_eq!(
        slack.pointer("/events_enabled").and_then(Value::as_bool),
        Some(true)
    );
    assert_eq!(
        slack.pointer("/tenant/org_id").and_then(Value::as_str),
        Some("acme")
    );
    assert_eq!(
        slack
            .pointer("/connections/0/channel_id")
            .and_then(Value::as_str),
        Some("C_SALES"),
        "echoed sanitized config must not wipe per-connection entries"
    );
    assert!(
        slack
            .get("allowed_users")
            .and_then(Value::as_array)
            .is_none_or(Vec::is_empty),
        "echoing the snapshot must not widen a deny-all allowlist to '*'"
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_verify_discord_without_token_returns_setup_hint() {
    let state = test_state().await;
    let app = app_router(state);

    let req = direct_loopback_request()
        .method("POST")
        .uri("/channels/discord/verify")
        .body(Body::empty())
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let body = to_bytes(resp.into_body(), usize::MAX)
        .await
        .expect("response body");
    let payload: Value = serde_json::from_slice(&body).expect("json body");
    assert_eq!(
        payload.get("ok").and_then(Value::as_bool),
        Some(false),
        "verify should fail without token"
    );
    assert_eq!(
        payload.get("channel").and_then(Value::as_str),
        Some("discord")
    );
    assert!(
        payload
            .get("hints")
            .and_then(Value::as_array)
            .is_some_and(|arr| !arr.is_empty()),
        "verify should include setup hints"
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_normalizes_empty_allowed_users_to_wildcard() {
    let state = test_state().await;
    let app = app_router(state.clone());

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/telegram")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "bot_token": "tg-secret",
                "allowed_users": [],
                "mention_only": false
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let effective = state.config.get_effective_value().await;
    assert_eq!(
        effective
            .get("channels")
            .and_then(|v| v.get("telegram"))
            .and_then(|v| v.get("allowed_users"))
            .and_then(Value::as_array)
            .cloned(),
        Some(vec![Value::String("*".to_string())])
    );
}

/// PR #1910 review: a FRESH Slack save (nothing stored) that omits
/// `allowed_users` must persist an explicit empty allowlist — not
/// `SlackConfigFile`'s legacy `["*"]` serde default, which would open
/// signed Events ingress to every Slack user.
#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_fresh_slack_save_without_allowlist_stays_deny_all() {
    let state = test_state().await;
    let app = app_router(state.clone());

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "bot_token": "xoxb-fresh",
                "channel_id": "C_FRESH"
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let stored = state.config.get_project_value().await;
    assert_eq!(
        stored.pointer("/channels/slack/allowed_users"),
        Some(&json!([])),
        "a fresh save without an allowlist must not persist the '*' wildcard"
    );
}

/// PR #1910 review (round 19): a save that CHANGES the Slack installation
/// identity must not carry the previous installation's secrets across — the
/// preservation block reads the effective config (keystore-injected
/// secrets), and re-hoisting them under the new identity would let app B
/// verify with app A's credentials instead of failing closed.
#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_migrating_installation_does_not_carry_secrets() {
    let state = test_state().await;
    let _ = state
        .config
        .patch_project(json!({
            "channels": {
                "slack": {
                    "bot_token": "xoxb-top",
                    "channel_id": "C_MAIN",
                    "team_id": "T1",
                    "app_id": "A_OLD",
                    "signing_secret": "shh-old",
                    "events_enabled": true,
                    "connections": [
                        { "channel_id": "C_SALES", "bot_token": "xoxb-sales" }
                    ]
                }
            }
        }))
        .await
        .expect("patch project");
    let app = app_router(state.clone());

    // Sanity: the effective config resolves the old installation's secrets.
    let effective = state.config.get_effective_value().await;
    let old_signing_secret_id = tandem_core::slack_signing_secret_store_id(
        effective
            .pointer("/channels/slack")
            .and_then(Value::as_object)
            .expect("stored Slack config"),
    );
    assert!(
        tandem_core::load_provider_auth().contains_key(&old_signing_secret_id),
        "sanity: the old installation signing secret is stored"
    );
    let connections = crate::config::channels::slack_connections_from_effective_config(&effective);
    assert!(connections
        .iter()
        .any(|connection| connection.channel_id == "C_SALES"
            && connection.bot_token.as_deref() == Some("xoxb-sales")));

    // Sanitized echo that migrates the app identity WITHOUT credentials: the
    // old installation's bot token must not be carried under the new
    // identity, so the save has no usable connection left and fails closed
    // instead of appearing usable while delivery is broken.
    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "channel_id": "C_MAIN",
                "team_id": "T1",
                "app_id": "A_NEW",
                "allowed_users": []
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(
        resp.status(),
        StatusCode::BAD_REQUEST,
        "a migrating save without new credentials must be rejected"
    );

    // The same migration WITH the new installation's bot token succeeds —
    // and still must not carry the old app's secrets.
    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "channel_id": "C_MAIN",
                "team_id": "T1",
                "app_id": "A_NEW",
                "bot_token": "xoxb-new",
                "allowed_users": []
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let effective = state.config.get_effective_value().await;
    assert_eq!(
        effective
            .pointer("/channels/slack/bot_token")
            .and_then(Value::as_str),
        Some("xoxb-new"),
        "the migrated installation must run on the newly supplied token"
    );
    assert!(
        effective
            .pointer("/channels/slack/signing_secret")
            .and_then(Value::as_str)
            .is_none_or(|secret| secret != "shh-old"),
        "the old app's signing secret must not follow the new identity"
    );
    let connections = crate::config::channels::slack_connections_from_effective_config(&effective);
    let sales = connections
        .iter()
        .find(|connection| connection.channel_id == "C_SALES")
        .expect("connection structure preserved");
    assert!(
        sales.bot_token.as_deref() != Some("xoxb-sales"),
        "an inheriting connection must not carry the old installation's token"
    );
    assert!(
        sales.signing_secret.is_none(),
        "the migrated installation must fail closed until its own secret is set"
    );
    assert!(
        !tandem_core::load_provider_auth().contains_key(&old_signing_secret_id),
        "the old installation signing secret must be purged after config persistence"
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_protected_audit_records_shape_without_raw_credentials() {
    let state = test_state().await;
    let app = app_router(state.clone());
    let token = "tg-channel-audit-secret-canary";

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/telegram")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "bot_token": token,
                "allowed_users": ["@alice"],
                "mention_only": true
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let audit = tokio::fs::read_to_string(&state.protected_audit_path)
        .await
        .expect("protected audit file");
    assert!(audit.contains("channel_config_update"));
    assert!(
        !audit.contains(token),
        "channel administrative audit must contain field names, never raw credentials"
    );
    let _ = tandem_core::delete_provider_auth("channel::telegram::bot_token");
}

/// PR #1910 review: a migrating save that stays valid through a
/// self-declared connection must REVOKE the stored top-level bot token —
/// deleting it from the keystore — or injection would resurrect the old
/// app's token under the new installation identity on the next read.
#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_migrating_installation_revokes_stored_top_level_token() {
    let state = test_state().await;
    let _ = state
        .config
        .patch_project(json!({
            "channels": {
                "slack": {
                    "bot_token": "xoxb-top",
                    "channel_id": "C_MAIN",
                    "team_id": "T1",
                    "app_id": "A_OLD",
                    "connections": [
                        {
                            "channel_id": "C_SALES",
                            "team_id": "T2",
                            "app_id": "A2",
                            "bot_token": "xoxb-sales"
                        }
                    ]
                }
            }
        }))
        .await
        .expect("patch project");
    let app = app_router(state.clone());

    // Sanity: the stored top-level token is injected into the effective config.
    let effective = state.config.get_effective_value().await;
    assert_eq!(
        effective
            .pointer("/channels/slack/bot_token")
            .and_then(Value::as_str),
        Some("xoxb-top")
    );

    // Migrate the installation without a new token: the save stays valid
    // because C_SALES self-declares its installation and token.
    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "channel_id": "C_MAIN",
                "team_id": "T1",
                "app_id": "A_NEW",
                "allowed_users": []
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::OK);

    let effective = state.config.get_effective_value().await;
    assert!(
        effective
            .pointer("/channels/slack/bot_token")
            .and_then(Value::as_str)
            .is_none_or(|token| token.trim().is_empty()),
        "the old installation's stored token must not resurface under the new identity"
    );
    let connections = crate::config::channels::slack_connections_from_effective_config(&effective);
    assert!(
        connections
            .iter()
            .any(|connection| connection.channel_id == "C_SALES"
                && connection.bot_token.as_deref() == Some("xoxb-sales")),
        "the self-declared connection keeps its own credentials"
    );
}

// PR #1910 review: a fresh multi-connection config that carries channel_id
/// and bot_token only inside `connections[]` is a valid save — startability
/// is judged on the resolved connections, not the legacy top-level fields.
#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_accepts_connection_only_slack_configs() {
    let state = test_state().await;
    let app = app_router(state.clone());

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "team_id": "T1",
                "app_id": "A1",
                "signing_secret": "shh",
                "events_enabled": true,
                "connections": [
                    { "channel_id": "C_SALES", "bot_token": "xoxb-sales" }
                ]
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(
        resp.status(),
        StatusCode::OK,
        "connection-only Slack configs must be accepted"
    );
    let effective = state.config.get_effective_value().await;
    let connections = crate::config::channels::slack_connections_from_effective_config(&effective);
    assert!(
        connections
            .iter()
            .any(|connection| connection.channel_id == "C_SALES"
                && connection.bot_token.as_deref() == Some("xoxb-sales")),
        "the resolved connection must be usable after the save"
    );

    // `GET /channels/config` reports `channel_id: null` for connection-only
    // configs; a client echoing that snapshot back (the Channels page
    // Reconnect) must not 400 on the explicit null before the preserved
    // `connections[]` can make the config startable.
    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "channel_id": null,
                "events_enabled": true,
                "mention_only": false,
                "allowed_users": []
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(
        resp.status(),
        StatusCode::OK,
        "echoing the sanitized snapshot's channel_id: null must not 400"
    );
    let effective = state.config.get_effective_value().await;
    let connections = crate::config::channels::slack_connections_from_effective_config(&effective);
    assert!(
        connections
            .iter()
            .any(|connection| connection.channel_id == "C_SALES"
                && connection.bot_token.as_deref() == Some("xoxb-sales")),
        "the preserved connection must survive a null-channel_id echo"
    );

    // A config with no usable connection anywhere is still rejected (fresh
    // state, so nothing stored can be inherited to make it startable).
    let state = test_state().await;
    let app = app_router(state.clone());
    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/slack")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({
                "team_id": "T1",
                "connections": [ { "channel_id": "C_TOKENLESS" } ]
            })
            .to_string(),
        ))
        .expect("request");
    let resp = app.oneshot(req).await.expect("response");
    assert_eq!(
        resp.status(),
        StatusCode::BAD_REQUEST,
        "a config with no usable connection must still be rejected"
    );
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_put_unknown_channel_returns_not_found() {
    let state = test_state().await;
    let app = app_router(state);

    let req = direct_loopback_request()
        .method("PUT")
        .uri("/channels/unknown")
        .header("content-type", "application/json")
        .body(Body::from(json!({ "bot_token": "x" }).to_string()))
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::NOT_FOUND);
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_delete_unknown_channel_returns_not_found() {
    let state = test_state().await;
    let app = app_router(state);

    let req = direct_loopback_request()
        .method("DELETE")
        .uri("/channels/unknown")
        .body(Body::empty())
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::NOT_FOUND);
}

#[tokio::test]
async fn channel_identity_authority_is_admin_only_tenant_exact_and_locally_compatible() {
    let state = test_state().await;
    let app = app_router(state.clone());

    let low_privilege = channel_tenant_request(
        "POST",
        "/channels/step-up",
        "org-a",
        "workspace-a",
        "member-a",
        false,
        json!({
            "channel": "slack",
            "user_id": "U-EXACT",
            "tenant_org_id": "org-a",
            "tenant_workspace_id": "workspace-a"
        }),
    );
    let response = app.clone().oneshot(low_privilege).await.expect("response");
    assert_eq!(response.status(), StatusCode::FORBIDDEN);

    let cross_tenant = channel_tenant_request(
        "POST",
        "/channels/step-up",
        "org-a",
        "workspace-a",
        "admin-a",
        true,
        json!({
            "channel": "slack",
            "user_id": "U-EXACT",
            "tenant_org_id": "org-b",
            "tenant_workspace_id": "workspace-b"
        }),
    );
    let response = app.clone().oneshot(cross_tenant).await.expect("response");
    assert_eq!(response.status(), StatusCode::FORBIDDEN);
    assert!(
        !state
            .channel_step_up_active("slack", "U-EXACT", Some(("org-b", "workspace-b")))
            .await
    );

    let exact_tenant = channel_tenant_request(
        "POST",
        "/channels/step-up",
        "org-a",
        "workspace-a",
        "admin-a",
        true,
        json!({
            "channel": "slack",
            "user_id": "U-EXACT",
            "tenant_org_id": "org-a",
            "tenant_workspace_id": "workspace-a"
        }),
    );
    let response = app.clone().oneshot(exact_tenant).await.expect("response");
    assert_eq!(response.status(), StatusCode::OK);
    assert!(
        state
            .channel_step_up_active("slack", "U-EXACT", Some(("org-a", "workspace-a")))
            .await
    );

    let issue = channel_tenant_request(
        "POST",
        "/channels/enroll",
        "org-a",
        "workspace-a",
        "admin-a",
        true,
        json!({
            "action": "issue",
            "channel": "telegram",
            "user_id": "4242",
            "tier": "approve",
            "issued_by": "spoofed-actor",
            "tenant_org_id": "org-a",
            "tenant_workspace_id": "workspace-a"
        }),
    );
    let response = app.clone().oneshot(issue).await.expect("response");
    assert_eq!(response.status(), StatusCode::OK);
    let body = to_bytes(response.into_body(), usize::MAX)
        .await
        .expect("response body");
    let issued: Value = serde_json::from_slice(&body).expect("issue response");
    let pairing_code = issued
        .get("pairing_code")
        .and_then(Value::as_str)
        .expect("pairing code")
        .to_string();
    let pending = state
        .pending_channel_enrollment_code(&pairing_code)
        .await
        .expect("pending enrollment");
    assert_eq!(pending.issued_by.as_deref(), Some("admin-a"));
    assert_eq!(pending.tenant_org_id.as_deref(), Some("org-a"));

    for candidate in ["NOT-A-REAL-CODE", pairing_code.as_str()] {
        let ordinary_confirm = channel_tenant_request(
            "POST",
            "/channels/enroll",
            "org-a",
            "workspace-a",
            "member-a",
            false,
            json!({
                "action": "confirm",
                "pairing_code": candidate,
                "enrolled_by": "member-a"
            }),
        );
        let response = app
            .clone()
            .oneshot(ordinary_confirm)
            .await
            .expect("response");
        assert_eq!(response.status(), StatusCode::FORBIDDEN);
    }
    assert!(state
        .pending_channel_enrollment_code(&pairing_code)
        .await
        .is_some());

    let wrong_tenant_confirm = channel_tenant_request(
        "POST",
        "/channels/enroll",
        "org-b",
        "workspace-b",
        "admin-b",
        true,
        json!({
            "action": "confirm",
            "pairing_code": pairing_code,
            "enrolled_by": "admin-b"
        }),
    );
    let response = app
        .clone()
        .oneshot(wrong_tenant_confirm)
        .await
        .expect("response");
    assert_eq!(response.status(), StatusCode::FORBIDDEN);
    assert!(state
        .pending_channel_enrollment_code(&pairing_code)
        .await
        .is_some());

    let exact_confirm = channel_tenant_request(
        "POST",
        "/channels/enroll",
        "org-a",
        "workspace-a",
        "admin-a",
        true,
        json!({
            "action": "confirm",
            "pairing_code": pairing_code,
            "enrolled_by": "spoofed-actor"
        }),
    );
    let response = app.clone().oneshot(exact_confirm).await.expect("response");
    assert_eq!(response.status(), StatusCode::OK);
    assert!(state
        .pending_channel_enrollment_code(&pairing_code)
        .await
        .is_none());
    let audit = tokio::fs::read_to_string(&state.protected_audit_path)
        .await
        .expect("protected audit file");
    let code_resource = format!(
        "code-sha256:{:x}",
        sha2::Sha256::digest(pairing_code.trim().to_ascii_uppercase().as_bytes())
    );
    assert!(audit.contains(&code_resource));
    assert!(
        !audit.contains(&pairing_code),
        "channel enrollment audit must identify the code by digest, never reveal it"
    );

    let local_state = test_state().await;
    let local_app = app_router(local_state.clone());
    let local_step_up = direct_loopback_request()
        .method("POST")
        .uri("/channels/step-up")
        .header("content-type", "application/json")
        .body(Body::from(
            json!({"channel": "slack", "user_id": "U-LOCAL"}).to_string(),
        ))
        .expect("local request");
    let response = local_app.oneshot(local_step_up).await.expect("response");
    assert_eq!(response.status(), StatusCode::OK);
    assert!(
        local_state
            .channel_step_up_active("slack", "U-LOCAL", None)
            .await
    );
}

#[tokio::test]
async fn slack_sender_inventory_requires_deployment_admin() {
    let state = test_state().await;
    let app = app_router(state);
    let member = channel_tenant_request(
        "GET",
        "/channels/slack/senders",
        "org-a",
        "workspace-a",
        "member-a",
        false,
        json!({}),
    );
    let response = app.clone().oneshot(member).await.expect("response");
    assert_eq!(response.status(), StatusCode::FORBIDDEN);

    let admin = channel_tenant_request(
        "GET",
        "/channels/slack/senders",
        "org-a",
        "workspace-a",
        "admin-a",
        true,
        json!({}),
    );
    let response = app.oneshot(admin).await.expect("response");
    assert_eq!(response.status(), StatusCode::OK);
}

#[tokio::test]
#[serial_test::serial(channel_provider_auth)]
async fn channels_verify_unknown_channel_returns_not_found() {
    let state = test_state().await;
    let app = app_router(state);

    let req = direct_loopback_request()
        .method("POST")
        .uri("/channels/unknown/verify")
        .body(Body::empty())
        .expect("request");
    let resp = app.clone().oneshot(req).await.expect("response");
    assert_eq!(resp.status(), StatusCode::NOT_FOUND);
}