tandem-memory 0.6.9

Memory storage and embedding utilities for Tandem
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
#[tokio::test]
async fn test_preflight_knowledge_stale_requires_refresh() {
    let (manager, _temp) = setup_test_manager().await;
    let now = chrono::Utc::now().timestamp_millis() as u64;

    let space = KnowledgeSpaceRecord {
        id: "space-preflight-2".to_string(),
        scope: KnowledgeScope::Project,
        project_id: Some("project-1".to_string()),
        namespace: Some("ops/runbooks".to_string()),
        title: Some("Ops runbooks".to_string()),
        description: Some("Reusable ops guidance".to_string()),
        trust_level: KnowledgeTrustLevel::Promoted,
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_space(&space).await.unwrap();

    let item = KnowledgeItemRecord {
        id: "item-preflight-2".to_string(),
        space_id: space.id.clone(),
        coverage_key: tandem_orchestrator::build_knowledge_coverage_key(
            "project-1",
            Some("ops/runbooks"),
            "restart",
            "stale service",
        ),
        dedupe_key: "dedupe-preflight-2".to_string(),
        item_type: "runbook".to_string(),
        title: "Restart stale service".to_string(),
        summary: Some("Restart and verify health.".to_string()),
        payload: serde_json::json!({"action":"restart"}),
        trust_level: KnowledgeTrustLevel::Promoted,
        status: crate::types::KnowledgeItemStatus::Promoted,
        run_id: Some("run-2".to_string()),
        artifact_refs: vec![],
        source_memory_ids: vec![],
        freshness_expires_at_ms: Some(now - 1000),
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_item(&item).await.unwrap();

    let request = KnowledgePreflightRequest {
        project_id: "project-1".to_string(),
        task_family: "restart".to_string(),
        subject: "stale service".to_string(),
        binding: KnowledgeBinding {
            namespace: Some("ops/runbooks".to_string()),
            freshness_ms: Some(10_000),
            ..Default::default()
        },
    };

    let result = manager.preflight_knowledge(&request).await.unwrap();
    assert_eq!(result.decision, KnowledgeReuseDecision::RefreshRequired);
    assert!(result.freshness_reason.is_some());
    assert!(!result.items.is_empty());
    assert!(!result.is_reusable());
}

#[tokio::test]
async fn test_preflight_knowledge_no_prior_knowledge() {
    let (manager, _temp) = setup_test_manager().await;

    let request = KnowledgePreflightRequest {
        project_id: "project-1".to_string(),
        task_family: "support".to_string(),
        subject: "triage".to_string(),
        binding: KnowledgeBinding {
            reuse_mode: KnowledgeReuseMode::Preflight,
            ..Default::default()
        },
    };

    let result = manager.preflight_knowledge(&request).await.unwrap();
    assert_eq!(result.decision, KnowledgeReuseDecision::NoPriorKnowledge);
    assert!(result.skip_reason.is_some());
}

#[tokio::test]
async fn test_preflight_knowledge_requires_explicit_namespace_when_project_has_many() {
    let (manager, _temp) = setup_test_manager().await;
    let now = chrono::Utc::now().timestamp_millis() as u64;

    let spaces = [
        ("space-alpha", "engineering/debugging", "Delay retries"),
        ("space-beta", "ops/runbooks", "Restart safely"),
    ];
    for (id, namespace, title) in spaces {
        manager
            .upsert_knowledge_space(&KnowledgeSpaceRecord {
                id: id.to_string(),
                scope: KnowledgeScope::Project,
                project_id: Some("project-1".to_string()),
                namespace: Some(namespace.to_string()),
                title: Some(title.to_string()),
                description: None,
                trust_level: KnowledgeTrustLevel::Promoted,
                metadata: None,
                created_at_ms: now,
                updated_at_ms: now,
            })
            .await
            .unwrap();
    }

    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-1".to_string(),
            task_family: "debugging".to_string(),
            subject: "startup race".to_string(),
            binding: KnowledgeBinding::default(),
        })
        .await
        .unwrap();

    assert_eq!(result.decision, KnowledgeReuseDecision::NoPriorKnowledge);
    assert!(result.items.is_empty());
    assert!(result
        .skip_reason
        .as_deref()
        .is_some_and(|reason| reason.contains("no reusable knowledge spaces")));
}

#[tokio::test]
async fn test_preflight_knowledge_infers_single_project_namespace() {
    let (manager, _temp) = setup_test_manager().await;
    let now = chrono::Utc::now().timestamp_millis() as u64;

    let space = KnowledgeSpaceRecord {
        id: "space-single-namespace".to_string(),
        scope: KnowledgeScope::Project,
        project_id: Some("project-1".to_string()),
        namespace: Some("engineering/debugging".to_string()),
        title: Some("Engineering debugging".to_string()),
        description: None,
        trust_level: KnowledgeTrustLevel::Promoted,
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_space(&space).await.unwrap();

    let item = KnowledgeItemRecord {
        id: "item-single-namespace".to_string(),
        space_id: space.id.clone(),
        coverage_key: tandem_orchestrator::build_knowledge_coverage_key(
            "project-1",
            Some("engineering/debugging"),
            "debugging",
            "startup race",
        ),
        dedupe_key: "dedupe-single-namespace".to_string(),
        item_type: "decision".to_string(),
        title: "Delay startup retries".to_string(),
        summary: Some("Wait for startup completion.".to_string()),
        payload: serde_json::json!({"action":"delay_retry"}),
        trust_level: KnowledgeTrustLevel::Promoted,
        status: crate::types::KnowledgeItemStatus::Promoted,
        run_id: Some("run-single-namespace".to_string()),
        artifact_refs: vec![],
        source_memory_ids: vec![],
        freshness_expires_at_ms: Some(now + 86_400_000),
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_item(&item).await.unwrap();

    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-1".to_string(),
            task_family: "debugging".to_string(),
            subject: "startup race".to_string(),
            binding: KnowledgeBinding::default(),
        })
        .await
        .unwrap();

    assert_eq!(result.decision, KnowledgeReuseDecision::ReusePromoted);
    assert_eq!(result.namespace.as_deref(), Some("engineering/debugging"));
    assert_eq!(result.items.len(), 1);
}

#[tokio::test]
async fn test_knowledge_preflight_disabled_binding_returns_disabled() {
    let (manager, _temp) = setup_test_manager().await;
    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-1".to_string(),
            task_family: "debugging".to_string(),
            subject: "startup race".to_string(),
            binding: tandem_orchestrator::KnowledgeBinding {
                enabled: false,
                ..Default::default()
            },
        })
        .await
        .unwrap();
    assert_eq!(
        result.decision,
        tandem_orchestrator::KnowledgeReuseDecision::Disabled
    );
    assert!(result.items.is_empty());
    assert!(result
        .skip_reason
        .as_deref()
        .is_some_and(|reason| reason.contains("disabled")));
}

#[tokio::test]
async fn test_knowledge_preflight_fresh_item_is_reusable() {
    let (manager, _temp) = setup_test_manager().await;
    let now = chrono::Utc::now().timestamp_millis() as u64;

    let space = KnowledgeSpaceRecord {
        id: "space-preflight-1".to_string(),
        scope: tandem_orchestrator::KnowledgeScope::Project,
        project_id: Some("project-1".to_string()),
        namespace: Some("engineering/debugging".to_string()),
        title: Some("Engineering debugging".to_string()),
        description: None,
        trust_level: tandem_orchestrator::KnowledgeTrustLevel::Promoted,
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_space(&space).await.unwrap();

    let item = KnowledgeItemRecord {
        id: "item-preflight-1".to_string(),
        space_id: space.id.clone(),
        coverage_key: tandem_orchestrator::build_knowledge_coverage_key(
            "project-1",
            Some("engineering/debugging"),
            "debugging",
            "startup race",
        ),
        dedupe_key: "dedupe-preflight-1".to_string(),
        item_type: "decision".to_string(),
        title: "Delay startup retries".to_string(),
        summary: Some("Wait for startup completion before retrying.".to_string()),
        payload: serde_json::json!({"action":"delay_retry"}),
        trust_level: tandem_orchestrator::KnowledgeTrustLevel::Promoted,
        status: crate::types::KnowledgeItemStatus::Promoted,
        run_id: Some("run-preflight-1".to_string()),
        artifact_refs: vec!["artifact://run-preflight-1/report".to_string()],
        source_memory_ids: vec!["memory-preflight-1".to_string()],
        freshness_expires_at_ms: Some(now + 86_400_000),
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_item(&item).await.unwrap();

    let coverage = KnowledgeCoverageRecord {
        coverage_key: item.coverage_key.clone(),
        space_id: space.id.clone(),
        latest_item_id: Some(item.id.clone()),
        latest_dedupe_key: Some(item.dedupe_key.clone()),
        last_seen_at_ms: now,
        last_promoted_at_ms: Some(now),
        freshness_expires_at_ms: Some(now + 86_400_000),
        metadata: None,
    };
    manager.upsert_knowledge_coverage(&coverage).await.unwrap();

    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-1".to_string(),
            task_family: "debugging".to_string(),
            subject: "startup race".to_string(),
            binding: tandem_orchestrator::KnowledgeBinding {
                namespace: Some("engineering/debugging".to_string()),
                ..Default::default()
            },
        })
        .await
        .unwrap();
    assert_eq!(
        result.decision,
        tandem_orchestrator::KnowledgeReuseDecision::ReusePromoted
    );
    assert!(result.is_reusable());
    assert!(!result.items.is_empty());
    assert!(result
        .reuse_reason
        .as_deref()
        .is_some_and(|reason| reason.contains("reusing")));
}

#[tokio::test]
async fn test_knowledge_preflight_stale_item_requests_refresh() {
    let (manager, _temp) = setup_test_manager().await;
    let now = chrono::Utc::now().timestamp_millis() as u64;

    let space = KnowledgeSpaceRecord {
        id: "space-preflight-2".to_string(),
        scope: tandem_orchestrator::KnowledgeScope::Project,
        project_id: Some("project-2".to_string()),
        namespace: Some("support/runbooks".to_string()),
        title: Some("Support runbooks".to_string()),
        description: None,
        trust_level: tandem_orchestrator::KnowledgeTrustLevel::Promoted,
        metadata: None,
        created_at_ms: now,
        updated_at_ms: now,
    };
    manager.upsert_knowledge_space(&space).await.unwrap();

    let item = KnowledgeItemRecord {
        id: "item-preflight-2".to_string(),
        space_id: space.id.clone(),
        coverage_key: tandem_orchestrator::build_knowledge_coverage_key(
            "project-2",
            Some("support/runbooks"),
            "runbooks",
            "restart service",
        ),
        dedupe_key: "dedupe-preflight-2".to_string(),
        item_type: "runbook".to_string(),
        title: "Restart stale service".to_string(),
        summary: Some("Restart before retrying.".to_string()),
        payload: serde_json::json!({"action":"restart"}),
        trust_level: tandem_orchestrator::KnowledgeTrustLevel::Promoted,
        status: crate::types::KnowledgeItemStatus::Promoted,
        run_id: Some("run-preflight-2".to_string()),
        artifact_refs: vec![],
        source_memory_ids: vec![],
        freshness_expires_at_ms: Some(now.saturating_sub(1)),
        metadata: None,
        created_at_ms: now.saturating_sub(86_400_000),
        updated_at_ms: now,
    };
    manager.upsert_knowledge_item(&item).await.unwrap();

    let coverage = KnowledgeCoverageRecord {
        coverage_key: item.coverage_key.clone(),
        space_id: space.id.clone(),
        latest_item_id: Some(item.id.clone()),
        latest_dedupe_key: Some(item.dedupe_key.clone()),
        last_seen_at_ms: now,
        last_promoted_at_ms: Some(now.saturating_sub(1)),
        freshness_expires_at_ms: Some(now.saturating_sub(1)),
        metadata: None,
    };
    manager.upsert_knowledge_coverage(&coverage).await.unwrap();

    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-2".to_string(),
            task_family: "runbooks".to_string(),
            subject: "restart service".to_string(),
            binding: tandem_orchestrator::KnowledgeBinding {
                namespace: Some("support/runbooks".to_string()),
                freshness_ms: Some(86_400_000),
                ..Default::default()
            },
        })
        .await
        .unwrap();
    assert_eq!(
        result.decision,
        tandem_orchestrator::KnowledgeReuseDecision::RefreshRequired
    );
    assert!(!result.is_reusable());
    assert!(result.items.is_empty() || result.freshness_reason.is_some());
    assert!(result
        .freshness_reason
        .as_deref()
        .is_some_and(|reason| reason.contains("expired") || reason.contains("freshness")));
}

#[tokio::test]
async fn test_knowledge_preflight_no_prior_knowledge_returns_no_prior() {
    let (manager, _temp) = setup_test_manager().await;
    let result = manager
        .preflight_knowledge(&KnowledgePreflightRequest {
            project_id: "project-3".to_string(),
            task_family: "ops".to_string(),
            subject: "incident triage".to_string(),
            binding: Default::default(),
        })
        .await
        .unwrap();
    assert_eq!(
        result.decision,
        tandem_orchestrator::KnowledgeReuseDecision::NoPriorKnowledge
    );
    assert!(result.items.is_empty());
    assert!(result
        .skip_reason
        .as_deref()
        .is_some_and(|reason| reason.contains("no reusable knowledge spaces")
            || reason.contains("no active promoted knowledge")));
}

#[tokio::test]
async fn context_tree_is_tenant_scoped() {
    let (manager, _temp) = setup_test_manager().await;
    let scope_a = crate::types::MemoryTenantScope {
        org_id: "org-a".to_string(),
        workspace_id: "workspace-a".to_string(),
        deployment_id: None,
    };
    let scope_b = crate::types::MemoryTenantScope {
        org_id: "org-b".to_string(),
        workspace_id: "workspace-b".to_string(),
        deployment_id: None,
    };

    let node_id = manager
        .store_content_with_layers(
            "tandem://resources/proj-a/notes.md",
            "tenant A secret notes",
            None,
            &scope_a,
        )
        .await
        .unwrap();

    // The owner resolves the node and reads its layer.
    let node = manager
        .resolve_uri("tandem://resources/proj-a/notes.md", &scope_a)
        .await
        .unwrap()
        .expect("owner resolves node");
    assert_eq!(node.id, node_id);
    let layer = manager
        .get_context_layer(&node_id, crate::types::LayerType::L2, &scope_a)
        .await
        .unwrap();
    assert!(layer.is_some(), "owner reads L2 layer");

    // A different tenant sees nothing — same URI, same node id, no signal
    // distinguishing a foreign node from a missing one.
    assert!(manager
        .resolve_uri("tandem://resources/proj-a/notes.md", &scope_b)
        .await
        .unwrap()
        .is_none());
    assert!(manager
        .get_context_layer(&node_id, crate::types::LayerType::L2, &scope_b)
        .await
        .unwrap()
        .is_none());
    assert!(manager
        .tree("tandem://resources/proj-a", 3, &scope_b)
        .await
        .unwrap()
        .is_empty());
    assert!(manager
        .list_directory("tandem://resources/proj-a", &scope_b)
        .await
        .unwrap()
        .nodes
        .is_empty());

    // Writing a layer onto a foreign node id fails like a missing node.
    let err = manager
        .db()
        .create_layer(
            &node_id,
            crate::types::LayerType::L0,
            "injected",
            1,
            None,
            &scope_b,
        )
        .await
        .expect_err("cross-tenant layer write is rejected");
    assert!(matches!(err, crate::types::MemoryError::NotFound(_)));

    // The owner still traverses their own tree.
    let tree = manager
        .tree("tandem://resources/proj-a", 3, &scope_a)
        .await
        .unwrap();
    assert_eq!(tree.len(), 1);
    assert_eq!(tree[0].node.uri, "tandem://resources/proj-a/notes.md");
}

#[tokio::test]
async fn context_tree_same_uri_coexists_across_tenants() {
    let (manager, _temp) = setup_test_manager().await;
    let scope_a = crate::types::MemoryTenantScope {
        org_id: "org-a".to_string(),
        workspace_id: "workspace-a".to_string(),
        deployment_id: None,
    };
    let scope_b = crate::types::MemoryTenantScope {
        org_id: "org-b".to_string(),
        workspace_id: "workspace-b".to_string(),
        deployment_id: None,
    };

    // The legacy schema had a global UNIQUE(uri); per-tenant trees must be
    // able to own the same URI independently.
    let id_a = manager
        .store_content_with_layers(
            "tandem://user/profile.md",
            "tenant A profile",
            None,
            &scope_a,
        )
        .await
        .unwrap();
    let id_b = manager
        .store_content_with_layers(
            "tandem://user/profile.md",
            "tenant B profile",
            None,
            &scope_b,
        )
        .await
        .unwrap();
    assert_ne!(id_a, id_b);

    let content_a = manager
        .get_layer_content(&id_a, crate::types::LayerType::L2, &scope_a)
        .await
        .unwrap()
        .expect("tenant A content");
    let content_b = manager
        .get_layer_content(&id_b, crate::types::LayerType::L2, &scope_b)
        .await
        .unwrap()
        .expect("tenant B content");
    assert_eq!(content_a, "tenant A profile");
    assert_eq!(content_b, "tenant B profile");

    // Duplicate URI within the SAME tenant is still rejected.
    assert!(manager
        .store_content_with_layers("tandem://user/profile.md", "dup", None, &scope_a)
        .await
        .is_err());
}

#[tokio::test]
async fn legacy_memory_nodes_table_migrates_to_tenant_scoped_schema() {
    let temp_dir = TempDir::new().unwrap();
    let db_path = temp_dir.path().join("legacy.db");
    // Pre-create the pre-tenancy table shape: global UNIQUE(uri), no tenant
    // columns. Opening the manager must rebuild it in place.
    {
        let conn = rusqlite::Connection::open(&db_path).unwrap();
        conn.execute_batch(
            "CREATE TABLE memory_nodes (
                    id TEXT PRIMARY KEY,
                    uri TEXT NOT NULL UNIQUE,
                    parent_uri TEXT,
                    node_type TEXT NOT NULL,
                    created_at TEXT NOT NULL,
                    updated_at TEXT NOT NULL,
                    metadata TEXT
                );
                INSERT INTO memory_nodes
                    (id, uri, parent_uri, node_type, created_at, updated_at, metadata)
                VALUES
                    ('legacy-node', 'tandem://resources/legacy/doc.md',
                     'tandem://resources/legacy', 'file',
                     '2026-01-01T00:00:00Z', '2026-01-01T00:00:00Z', NULL);",
        )
        .unwrap();
    }

    let manager = MemoryManager::new(&db_path).await.unwrap();

    // Legacy rows are backfilled into the local tenant scope.
    let node = manager
        .resolve_uri(
            "tandem://resources/legacy/doc.md",
            &crate::types::MemoryTenantScope::local(),
        )
        .await
        .unwrap()
        .expect("legacy node visible under local scope");
    assert_eq!(node.id, "legacy-node");

    // Other tenants cannot see the migrated row, and the former global
    // UNIQUE(uri) no longer blocks them from owning the same URI.
    let scope_b = crate::types::MemoryTenantScope {
        org_id: "org-b".to_string(),
        workspace_id: "workspace-b".to_string(),
        deployment_id: None,
    };
    assert!(manager
        .resolve_uri("tandem://resources/legacy/doc.md", &scope_b)
        .await
        .unwrap()
        .is_none());
    manager
        .store_content_with_layers(
            "tandem://resources/legacy/doc.md",
            "tenant B copy",
            None,
            &scope_b,
        )
        .await
        .expect("same URI storable by another tenant after migration");

    // Re-opening does not re-run the rebuild (migration is idempotent).
    drop(manager);
    let reopened = MemoryManager::new(&db_path).await.unwrap();
    let node = reopened
        .resolve_uri(
            "tandem://resources/legacy/doc.md",
            &crate::types::MemoryTenantScope::local(),
        )
        .await
        .unwrap()
        .expect("legacy node survives reopen");
    assert_eq!(node.id, "legacy-node");
}

#[tokio::test]
async fn chunk_subject_round_trips_through_store_and_search() {
    let (manager, _temp) = setup_deterministic_test_manager().await;
    let scope = crate::types::MemoryTenantScope {
        org_id: "org-a".to_string(),
        workspace_id: "workspace-a".to_string(),
        deployment_id: None,
    };
    let request = StoreMessageRequest {
        content: "subject scoped archived exchange about deployment windows".to_string(),
        tier: MemoryTier::Global,
        session_id: None,
        project_id: None,
        source: "chat_exchange".to_string(),
        source_path: None,
        source_mtime: None,
        source_size: None,
        source_hash: None,
        tenant_scope: scope.clone(),
        subject: Some("user-a".to_string()),
        metadata: None,
    };
    let ids = manager.store_message(request).await.unwrap();
    assert!(!ids.is_empty());

    let access_filter =
        crate::types::MemoryAccessFilter::local_noop(chrono::Utc::now().timestamp_millis() as u64)
            .with_caller_subject("user-a");
    let results = manager
        .search_for_tenant_with_access_filter(
            "deployment windows",
            Some(MemoryTier::Global),
            None,
            None,
            &scope,
            Some(5),
            Some(&access_filter),
        )
        .await
        .unwrap();
    assert!(!results.is_empty());
    assert_eq!(results[0].chunk.subject.as_deref(), Some("user-a"));
}

#[tokio::test]
async fn subject_chunks_survive_topk_ranking_against_other_subjects() {
    let (manager, _temp) = setup_deterministic_test_manager().await;
    let scope = crate::types::MemoryTenantScope {
        org_id: "org-a".to_string(),
        workspace_id: "workspace-a".to_string(),
        deployment_id: None,
    };
    let store = |content: String, subject: &str| StoreMessageRequest {
        content,
        tier: MemoryTier::Global,
        session_id: None,
        project_id: None,
        source: "chat_exchange".to_string(),
        source_path: None,
        source_mtime: None,
        source_size: None,
        source_hash: None,
        tenant_scope: scope.clone(),
        subject: Some(subject.to_string()),
        metadata: None,
    };

    // Fill the candidate window (limit * ACCESS_FILTER_CANDIDATE_MULTIPLIER)
    // with another subject's chunks that match the query at least as well.
    let query = "quarterly infrastructure budget planning";
    for i in 0..12 {
        manager
            .store_message(store(format!("{query} details volume {i}"), "user-b"))
            .await
            .unwrap();
    }
    manager
        .store_message(store(format!("{query} owner note"), "user-a"))
        .await
        .unwrap();

    // Governed search as user-a: their chunk must reach the results even
    // though user-b's closer chunks would otherwise fill the top-k window.
    let tenant = tandem_enterprise_contract::TenantContext::explicit_user_workspace(
        "org-a",
        "workspace-a",
        None,
        "user-a",
    );
    let principal =
        tandem_enterprise_contract::RequestPrincipal::authenticated_user("user-a", "test");
    let strict = tandem_enterprise_contract::StrictTenantContext::new(
        tenant,
        tandem_enterprise_contract::PrincipalRef::human_user("user-a"),
        tandem_enterprise_contract::AuthorityChain::from_request(principal),
        tandem_enterprise_contract::ResourceScope::root(
            tandem_enterprise_contract::ResourceRef::new(
                "org-a",
                "workspace-a",
                tandem_enterprise_contract::ResourceKind::Workspace,
                "workspace-a",
            ),
        ),
        tandem_enterprise_contract::AssertionMetadata::new(
            "issuer",
            "runtime",
            1_000,
            9_999_999_999_999,
            "assertion-a",
        ),
    );
    let filter =
        crate::types::MemoryAccessFilter::strict(strict, 2_000).with_caller_subject("user-a");
    let results = manager
        .search_for_tenant_with_access_filter(
            query,
            Some(MemoryTier::Global),
            None,
            None,
            &scope,
            Some(2),
            Some(&filter),
        )
        .await
        .unwrap();
    assert!(
        results
            .iter()
            .all(|result| result.chunk.subject.as_deref() != Some("user-b")),
        "no foreign-subject chunks in governed results"
    );
    assert!(
        results
            .iter()
            .any(|result| result.chunk.subject.as_deref() == Some("user-a")),
        "owner's chunk must not be starved out of the candidate window"
    );
}