talos-agent 0.8.0

Core orchestration logic and the agent turn loop
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
use super::constants::{
    CIRCUIT_BREAKER_THRESHOLD, COLLAPSE_TURN_THRESHOLD, MAX_TOOL_RESULT_CHARS, PRESERVED_TURNS,
    TRIM_TURN_THRESHOLD, TRUNCATION_SUFFIX,
};
use super::*;
use crate::token::TokenEstimator;
use async_trait::async_trait;
use talos_core::message::{AgentEvent, Message, MessageToolResult, ToolCall, Usage};
use talos_core::provider::{LanguageModel, ProviderError, ProviderResult};
use tokio::sync::mpsc;

type Receiver<T> = mpsc::Receiver<T>;

/// Helper: create a tool result message.
fn tool_msg(id: &str, content: &str) -> Message {
    Message::Tool {
        result: MessageToolResult {
            tool_use_id: id.into(),
            content: content.into(),
            is_error: false,
        },
    }
}

/// Helper: create a user message.
fn user_msg(content: &str) -> Message {
    Message::User {
        content: content.into(),
    }
}

/// Helper: create an assistant message.
fn assistant_msg(content: &str) -> Message {
    Message::Assistant {
        content: content.into(),
        tool_calls: vec![],
        reasoning: None,
    }
}

/// Helper: create an assistant message with tool calls.
fn assistant_with_tools(content: &str, tools: Vec<ToolCall>) -> Message {
    Message::Assistant {
        content: content.into(),
        tool_calls: tools,
        reasoning: None,
    }
}

/// Helper: create a full turn (user + assistant + tool results).
fn make_turn(
    user_content: &str,
    assistant_content: &str,
    tool_results: Vec<(&str, &str)>,
) -> Vec<Message> {
    let mut msgs = vec![user_msg(user_content)];
    let tool_calls: Vec<ToolCall> = tool_results
        .iter()
        .map(|(id, _)| ToolCall {
            id: id.to_string(),
            name: "test_tool".into(),
            input: serde_json::json!({}),
        })
        .collect();
    msgs.push(assistant_with_tools(assistant_content, tool_calls));
    for (id, content) in tool_results {
        msgs.push(tool_msg(id, content));
    }
    msgs
}

// --- Mock provider that returns a fixed summary ---

struct SummaryMockProvider {
    summary: String,
}

impl SummaryMockProvider {
    fn new(summary: &str) -> Self {
        Self {
            summary: summary.into(),
        }
    }
}

#[async_trait]
impl LanguageModel for SummaryMockProvider {
    async fn stream(&self, _messages: &[Message]) -> ProviderResult<Receiver<AgentEvent>> {
        let (tx, rx) = mpsc::channel(32);
        let summary = self.summary.clone();
        tokio::spawn(async move {
            let _ = tx.send(AgentEvent::TurnStart).await;
            let _ = tx.send(AgentEvent::TextDelta { delta: summary }).await;
            let _ = tx
                .send(AgentEvent::TurnEnd {
                    stop_reason: talos_core::message::StopReason::EndTurn,
                    usage: Usage::default(),
                })
                .await;
        });
        Ok(rx)
    }
}

// --- Mock provider that always fails ---

struct FailingProvider;

#[async_trait]
impl LanguageModel for FailingProvider {
    async fn stream(&self, _messages: &[Message]) -> ProviderResult<Receiver<AgentEvent>> {
        Err(ProviderError::ServerError("mock failure".into()))
    }
}

// ========== Layer 1: Budget ==========

#[test]
fn test_layer1_budget_truncates_long_tool_result() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let long_content = "x".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 1);
    if let Message::Tool { result: tr } = &result[0] {
        assert!(tr.content.len() <= MAX_TOOL_RESULT_CHARS + TRUNCATION_SUFFIX.len());
        assert!(tr.content.ends_with(TRUNCATION_SUFFIX));
    } else {
        panic!("expected Tool message");
    }
}

#[test]
fn test_layer1_budget_preserves_short_tool_result() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let short_content = "short result";
    let messages = vec![tool_msg("call_1", short_content)];

    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 1);
    if let Message::Tool { result: tr } = &result[0] {
        assert_eq!(tr.content, short_content);
    } else {
        panic!("expected Tool message");
    }
}

#[test]
fn test_layer1_budget_truncates_multibyte_content_on_char_boundary() {
    // Regression: byte-slicing at index 4000 panicked when the boundary
    // fell inside a 3-byte char like '责'. Truncation must count chars.
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let long_content = "".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 1);
    if let Message::Tool { result: tr } = &result[0] {
        let body = tr
            .content
            .strip_suffix(TRUNCATION_SUFFIX)
            .expect("operation should succeed");
        assert_eq!(body.chars().count(), MAX_TOOL_RESULT_CHARS);
        assert!(tr.content.ends_with(TRUNCATION_SUFFIX));
    } else {
        panic!("expected Tool message");
    }
}

#[test]
fn test_layer1_budget_preserves_short_multibyte_result() {
    // 3000 CJK chars = 9000 bytes: over the byte count but under the char
    // threshold, so it must survive untouched (threshold is char-based).
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let short_content = "".repeat(3000);
    let messages = vec![tool_msg("call_1", &short_content)];

    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 1);
    if let Message::Tool { result: tr } = &result[0] {
        assert_eq!(tr.content, short_content);
    } else {
        panic!("expected Tool message");
    }
}

#[test]
fn test_layer1_budget_does_not_affect_other_messages() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = vec![
        user_msg("Hello"),
        assistant_msg("Hi there"),
        tool_msg("call_1", "short"),
    ];

    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 3);
    assert!(matches!(&result[0], Message::User { .. }));
    assert!(matches!(&result[1], Message::Assistant { .. }));
    assert!(matches!(&result[2], Message::Tool { .. }));
}

// ========== Layer 2: Trim ==========

#[test]
fn test_layer2_trim_removes_old_tool_results() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let mut messages = Vec::new();

    // Create 25 turns
    for i in 0..25 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let result = compactor.apply_trim(messages);

    // Tool results from turns 1-5 should be empty (trimmed)
    // Turns 6-25 should be preserved
    let mut trimmed_count = 0;
    let mut preserved_count = 0;
    for msg in &result {
        if let Message::Tool { result: tr } = msg {
            if tr.content.is_empty() {
                trimmed_count += 1;
            } else {
                preserved_count += 1;
            }
        }
    }

    assert_eq!(trimmed_count, 5); // First 5 turns trimmed
    assert_eq!(preserved_count, 20); // Last 20 turns preserved
}

#[test]
fn test_layer2_trim_no_op_when_under_threshold() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = make_turn("query", "response", vec![("call_1", "result")]);

    let result = compactor.apply_trim(messages.clone());

    assert_eq!(result, messages);
}

// ========== Layer 3: Microcompact ==========

#[test]
fn test_layer3_microcompact_keeps_last_result_per_id() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = vec![
        tool_msg("call_1", "first result"),
        tool_msg("call_2", "other result"),
        tool_msg("call_1", "second result"),
        tool_msg("call_2", "final result"),
    ];

    let result = compactor.apply_microcompact(messages);

    let contents: Vec<_> = result
        .iter()
        .filter_map(|m| {
            if let Message::Tool { result: tr } = m {
                Some(tr.content.clone())
            } else {
                None
            }
        })
        .collect();

    // call_1: first should be empty, second preserved
    // call_2: first should be empty, final preserved
    assert_eq!(contents[0], ""); // call_1 first → emptied
    assert_eq!(contents[1], ""); // call_2 first → emptied
    assert_eq!(contents[2], "second result"); // call_1 last → kept
    assert_eq!(contents[3], "final result"); // call_2 last → kept
}

#[test]
fn test_layer3_microcompact_no_duplicates() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = vec![
        tool_msg("call_1", "unique result"),
        tool_msg("call_2", "another result"),
    ];

    let result = compactor.apply_microcompact(messages.clone());

    assert_eq!(result, messages);
}

// ========== Layer 4: Collapse ==========

#[tokio::test]
async fn test_layer4_collapse_summarizes_old_turns() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let mut messages = Vec::new();

    // Create 15 turns
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let provider = SummaryMockProvider::new("Summary of old turns");
    let result = compactor
        .apply_collapse(messages, &provider)
        .await
        .expect("operation should succeed");

    // First message should be the summary
    assert!(
        matches!(&result[0], Message::User { content } if content.contains("Conversation summary"))
    );
    assert!(
        matches!(&result[0], Message::User { content } if content.contains("Summary of old turns"))
    );

    // Remaining messages should be the last 10 turns (30 messages: 10 * 3)
    let recent_count = result.len() - 1;
    assert_eq!(recent_count, 30); // 10 turns * 3 messages each
}

#[tokio::test]
async fn test_layer4_collapse_no_op_when_under_threshold() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = make_turn("query", "response", vec![("call_1", "result")]);

    let provider = SummaryMockProvider::new("summary");
    let result = compactor
        .apply_collapse(messages.clone(), &provider)
        .await
        .expect("operation should succeed");

    assert_eq!(result, messages);
}

// ========== Layer 5: Autocompact ==========

#[tokio::test]
async fn test_layer5_autocompact_summarizes_all_old_turns() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let mut messages = Vec::new();

    // Create 15 turns
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let provider = SummaryMockProvider::new("Full conversation summary");
    let result = compactor
        .apply_autocompact(messages, &provider)
        .await
        .expect("operation should succeed");

    // First message should be the summary
    assert!(
        matches!(&result[0], Message::User { content } if content.contains("Full conversation summary"))
    );

    // Remaining messages should be the last 10 turns
    let recent_count = result.len() - 1;
    assert_eq!(recent_count, 30); // 10 turns * 3 messages each
}

#[tokio::test]
async fn test_layer5_autocompact_no_op_when_under_threshold() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = make_turn("query", "response", vec![("call_1", "result")]);

    let provider = SummaryMockProvider::new("summary");
    let result = compactor
        .apply_autocompact(messages.clone(), &provider)
        .await
        .expect("operation should succeed");

    assert_eq!(result, messages);
}

// ========== should_compact ==========

#[test]
fn test_should_compact_returns_true_at_80_percent() {
    // model_limit = 1000, threshold = 0.8 → trigger at > 800 tokens
    let compactor = Compactor::new(TokenEstimator::new(), 1000);

    // Create messages that estimate to ~801 tokens
    // ASCII: 4 chars per token → need ~3204 chars
    let long_content = "x".repeat(3204);
    let messages = vec![user_msg(&long_content)];

    assert!(compactor.should_compact(&messages));
}

#[test]
fn test_should_compact_returns_false_below_threshold() {
    let compactor = Compactor::new(TokenEstimator::new(), 1000);

    // Small message: well under 800 tokens
    let messages = vec![user_msg("Hello, world!")];

    assert!(!compactor.should_compact(&messages));
}

#[test]
fn test_should_compact_custom_threshold() {
    let compactor = Compactor::new(TokenEstimator::new(), 1000).with_threshold(0.5);

    // 500 token threshold → need > 500 tokens → ~2001 chars
    let content = "x".repeat(2001);
    let messages = vec![user_msg(&content)];

    assert!(compactor.should_compact(&messages));
}

// ========== Circuit Breaker ==========

#[tokio::test]
async fn test_circuit_breaker_trips_after_3_failures() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 1);
    let mut messages = Vec::new();
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let provider = FailingProvider;

    for _ in 0..3 {
        let result = compactor.compact(messages.clone(), &provider).await;
        assert!(result.is_err(), "Expected failure");
    }

    assert_eq!(compactor.failure_count(), 3);

    let result = compactor.compact(messages.clone(), &provider).await;
    assert!(matches!(
        result.expect_err("operation should fail"),
        CompactionError::CircuitBreakerTripped
    ));
}

// ========== Recent turns preservation ==========

#[tokio::test]
async fn test_recent_turns_preserved_verbatim() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let mut messages = Vec::new();

    // Create 15 turns with unique content
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("unique_query_{i}"),
            &format!("unique_response_{i}"),
            vec![(&format!("call_{i}"), &format!("unique_result_{i}"))],
        ));
    }

    let provider = SummaryMockProvider::new("summary");
    let result = compactor
        .compact(messages.clone(), &provider)
        .await
        .expect("operation should succeed");

    // The last 30 messages (10 turns * 3) should match the original last 30
    let original_recent = &messages[messages.len() - 30..];
    let result_recent = &result[result.len() - 30..];

    assert_eq!(original_recent, result_recent);
}

// ========== Seamless continuation ==========

#[tokio::test]
async fn test_compaction_continues_conversation_seamlessly() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 160);
    let mut messages = Vec::new();

    for i in 0..15 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let provider = SummaryMockProvider::new("Summary: user asked about files, assistant read them");
    let compacted = compactor
        .compact(messages, &provider)
        .await
        .expect("operation should succeed");

    assert!(compacted.len() > 1);
    if let Message::User { content } = &compacted[0] {
        assert!(
            content.contains("Summary"),
            "first message content: {content}"
        );
    } else {
        panic!("first message is not User: {:?}", compacted[0]);
    }
    assert!(matches!(compacted.last(), Some(Message::Tool { .. })));

    let mut continued = compacted;
    continued.push(user_msg("Follow-up question"));
    assert!(matches!(continued.last(), Some(Message::User { .. })));
}

// ========== Full compact flow ==========

#[tokio::test]
async fn test_compact_stops_early_when_budget_layer_suffices() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let long_content = "x".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    // Budget layer should truncate and make it fit
    let result = compactor
        .compact(messages, &FailingProvider)
        .await
        .expect("operation should succeed");

    assert_eq!(result.len(), 1);
    if let Message::Tool { result: tr } = &result[0] {
        assert!(tr.content.len() < 5000);
        assert!(tr.content.ends_with(TRUNCATION_SUFFIX));
    }
}

#[tokio::test]
async fn test_compact_provider_error_propagates() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 1);
    let mut messages = Vec::new();

    // Create enough turns to trigger collapse layer
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("query {i}"),
            &format!("response {i}"),
            vec![(&format!("call_{i}"), &format!("result {i}"))],
        ));
    }

    let provider = FailingProvider;
    let result = compactor.compact(messages, &provider).await;

    assert!(result.is_err());
    assert!(matches!(
        result.expect_err("operation should fail"),
        CompactionError::ProviderError(_)
    ));
}

// ========== Edge cases ==========

#[test]
fn test_empty_messages() {
    let compactor = Compactor::new(TokenEstimator::new(), 1000);
    let messages: Vec<Message> = vec![];

    assert!(!compactor.should_compact(&messages));
}

#[test]
fn test_apply_budget_exact_boundary() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let exact_content = "x".repeat(MAX_TOOL_RESULT_CHARS);
    let messages = vec![tool_msg("call_1", &exact_content)];

    let result = compactor.apply_budget(messages);

    // Exactly at boundary should NOT be truncated
    if let Message::Tool { result: tr } = &result[0] {
        assert_eq!(tr.content.len(), MAX_TOOL_RESULT_CHARS);
        assert!(!tr.content.ends_with(TRUNCATION_SUFFIX));
    }
}

#[test]
fn test_apply_budget_one_over_boundary() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let over_content = "x".repeat(MAX_TOOL_RESULT_CHARS + 1);
    let messages = vec![tool_msg("call_1", &over_content)];

    let result = compactor.apply_budget(messages);

    if let Message::Tool { result: tr } = &result[0] {
        assert!(tr.content.ends_with(TRUNCATION_SUFFIX));
    }
}

#[tokio::test]
async fn test_compact_resets_failure_count_on_success() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let long_content = "x".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    // This should succeed (budget layer is enough)
    let result = compactor.compact(messages, &FailingProvider).await;
    assert!(result.is_ok());

    // Failure count should be reset to 0
    assert_eq!(compactor.failure_count(), 0);
}

// ========== MEM-005-A: CompactionPolicy ==========

#[test]
fn test_policy_defaults_match_constants() {
    let policy = CompactionPolicy::default();
    assert_eq!(policy.trigger_threshold, 0.8);
    assert_eq!(policy.max_tool_result_chars, MAX_TOOL_RESULT_CHARS);
    assert_eq!(policy.preserved_turns, PRESERVED_TURNS);
    assert_eq!(policy.trim_turn_threshold, TRIM_TURN_THRESHOLD);
    assert_eq!(policy.collapse_turn_threshold, COLLAPSE_TURN_THRESHOLD);
    assert_eq!(policy.circuit_breaker_threshold, CIRCUIT_BREAKER_THRESHOLD);
    assert_eq!(policy.output_reserve, 0);
}

#[test]
fn test_policy_trigger_tokens_calculation() {
    let policy = CompactionPolicy::default();
    assert_eq!(policy.trigger_tokens(128_000), 102_400);
    assert_eq!(policy.trigger_tokens(100_000), 80_000);

    let policy_with_reserve = CompactionPolicy {
        output_reserve: 4096,
        ..Default::default()
    };
    assert_eq!(policy_with_reserve.trigger_tokens(100_000), 80_000 - 4096);
}

#[test]
fn test_policy_trigger_tokens_saturates_on_small_limit() {
    let policy = CompactionPolicy {
        output_reserve: 100_000,
        ..Default::default()
    };
    assert_eq!(policy.trigger_tokens(1000), 0);
}

// ========== MEM-005-A: compact_deterministic ==========

#[test]
fn test_compact_deterministic_applies_budget_when_sufficient() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let long_content = "x".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    let (result, status) = compactor.compact_deterministic(messages);

    assert!(matches!(status, CompactionStatus::Applied { .. }));
    if let CompactionStatus::Applied { layers_applied, .. } = &status {
        assert_eq!(layers_applied, &vec!["budget"]);
    }
    assert_eq!(result.len(), 1);
}

#[test]
fn test_compact_deterministic_returns_skipped_when_insufficient() {
    let compactor = Compactor::new(TokenEstimator::new(), 1);
    let mut messages = Vec::new();
    for i in 0..5 {
        messages.extend(make_turn(
            &format!("q{i}"),
            &format!("r{i}"),
            vec![(&format!("c{i}"), &format!("d{i}"))],
        ));
    }

    let (_result, status) = compactor.compact_deterministic(messages);

    assert!(matches!(
        status,
        CompactionStatus::Skipped {
            reason: "deterministic layers insufficient; LLM layers required",
            ..
        }
    ));
}

// ========== MEM-005-A: manual_compact ==========

#[tokio::test]
async fn test_manual_compact_skipped_below_threshold() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = vec![user_msg("Hello")];

    let (_result, status) = compactor.manual_compact(messages, &FailingProvider).await;

    assert!(matches!(
        status,
        CompactionStatus::Skipped {
            reason: "below trigger threshold",
            ..
        }
    ));
}

#[tokio::test]
async fn test_manual_compact_applied_when_over_threshold() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 1100);
    let long_content = "x".repeat(5000);
    let messages = vec![tool_msg("call_1", &long_content)];

    let (_result, status) = compactor.manual_compact(messages, &FailingProvider).await;

    assert!(matches!(status, CompactionStatus::Applied { .. }));
}

#[tokio::test]
async fn test_manual_compact_failed_on_provider_error() {
    let mut compactor = Compactor::new(TokenEstimator::new(), 1);
    let mut messages = Vec::new();
    for i in 0..15 {
        messages.extend(make_turn(
            &format!("q{i}"),
            &format!("r{i}"),
            vec![(&format!("c{i}"), &format!("d{i}"))],
        ));
    }

    let original = messages.clone();
    let (result, status) = compactor.manual_compact(messages, &FailingProvider).await;

    assert!(matches!(status, CompactionStatus::Failed { .. }));
    assert_eq!(
        result, original,
        "manual compaction failure must preserve original context"
    );
}

// ========== MEM-005-A: hidden-output guard ==========

#[test]
fn test_compaction_status_never_contains_tool_content() {
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let messages = vec![tool_msg("call_1", "SECRET_TOOL_OUTPUT_12345")];

    let (_result, status) = compactor.compact_deterministic(messages);

    let status_str = format!("{status:?}");
    assert!(
        !status_str.contains("SECRET_TOOL_OUTPUT_12345"),
        "CompactionStatus must never expose tool result content"
    );
}

// ── TOOL-021 error propagation fixtures: compaction preserves is_error ──

fn error_tool_msg(id: &str, content: &str) -> Message {
    Message::Tool {
        result: MessageToolResult {
            tool_use_id: id.into(),
            content: content.into(),
            is_error: true,
        },
    }
}

#[test]
fn fixture_budget_truncation_preserves_is_error() {
    // F6: budget truncation preserves is_error flag even when content is truncated
    let large_content = "x".repeat(MAX_TOOL_RESULT_CHARS + 1000);
    let messages = vec![error_tool_msg("call_1", &large_content)];
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let result = compactor.apply_budget(messages);

    assert_eq!(result.len(), 1);
    if let Message::Tool { result } = &result[0] {
        assert!(result.is_error, "is_error must survive budget truncation");
        assert!(
            result.content.ends_with(TRUNCATION_SUFFIX),
            "content must be truncated with suffix"
        );
        assert!(
            result.content.len() <= MAX_TOOL_RESULT_CHARS + TRUNCATION_SUFFIX.len(),
            "truncated content must be within budget"
        );
    } else {
        panic!("expected Tool message");
    }
}

#[test]
fn fixture_trim_preserves_is_error() {
    // F7: trim compaction empties content but preserves is_error
    let mut messages = Vec::new();
    for turn in 0..(TRIM_TURN_THRESHOLD + 5) {
        messages.push(Message::User {
            content: format!("turn {turn}"),
        });
        messages.push(Message::Assistant {
            content: format!("reply {turn}"),
            tool_calls: vec![],
            reasoning: None,
        });
        messages.push(error_tool_msg(&format!("call_{turn}"), "error happened"));
    }
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let result = compactor.apply_trim(messages);

    // First few turns should have emptied tool content but preserved is_error
    let first_tool = result
        .iter()
        .find_map(|m| {
            if let Message::Tool { result } = m {
                Some(result)
            } else {
                None
            }
        })
        .expect("at least one tool message");
    assert!(
        first_tool.is_error,
        "is_error must survive trim even when content is emptied"
    );
    assert!(
        first_tool.content.is_empty(),
        "trimmed old tool content must be empty"
    );
}

#[test]
fn fixture_microcompact_preserves_is_error() {
    // F8: microcompact deduplicates by tool_use_id, preserves is_error on kept entry
    let messages = vec![
        error_tool_msg("dup_1", "first error"),
        error_tool_msg("dup_1", "second error"),
    ];
    let compactor = Compactor::new(TokenEstimator::new(), 100_000);
    let result = compactor.apply_microcompact(messages);

    assert_eq!(result.len(), 2);
    // First (older) should have content emptied
    if let Message::Tool { result } = &result[0] {
        assert!(result.is_error, "is_error preserved on deduped entry");
        assert!(result.content.is_empty(), "older duplicate content emptied");
    } else {
        panic!("expected Tool message");
    }
    // Second (newer) should retain content
    if let Message::Tool { result } = &result[1] {
        assert!(result.is_error, "is_error preserved on kept entry");
        assert_eq!(result.content, "second error");
    } else {
        panic!("expected Tool message");
    }
}