takeaway 0.1.4

An efficient work-stealing task queue with prioritization and batching.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
//! Workers.

use alloc::{rc::Rc, vec::Vec};
use core::{
    ops::ControlFlow,
    task::{Poll, Waker},
};

use crate::{
    Enqueuer, Queue, Task, TaskPriority, batch::Batch, control::Control,
};

//----------- Worker -----------------------------------------------------------

/// A thread-local view of the task queue.
///
/// This is the primary interface to `takeaway`.  It manages a set of pending
/// tasks, communicating with the global [`Queue`] to distribute tasks across
/// the system, and provides methods for adding and retrieving tasks.
///
/// # Usage
///
/// You can obtain a [`Worker`] from [`Worker::new()`].  To enqueue tasks,
/// use [`Worker::enqueue()`].  To retrieve tasks, use [`Worker::next()`].  In
/// either case, lower-level interfaces are provided for more control.
///
/// ```no_run
/// # use takeaway::{Queue, Worker};
/// #
/// # async fn worker(queue: &Queue<()>, id: usize) {
/// // Construct the 'Worker'.
/// let mut worker = Worker::new(queue, id);
///
/// // Enqueue some initial tasks.
/// worker.enqueue_one(todo!());
///
/// // Process tasks.
/// while let Some(task) = worker.next().await {
///     // Execute the task.
///     //...
///
///     // Enqueue sub-tasks as necessary.
///     worker.enqueue_one(todo!());
/// }
///
/// // The task queue has shut down.
/// # }
/// ```
pub struct Worker<'q, T: Task> {
    /// The ID of this worker.
    id: usize,

    /// The global task queue.
    queue: &'q Queue<T>,

    /// The associated enqueuer.
    enqueuer: Rc<Enqueuer<T>>,

    /// Postponed tasks.
    ///
    /// These tasks are not part of the current batch, and are sorted in
    /// ascending order of priority.
    postponed: Vec<T>,

    /// The current batch of tasks.
    batch: Batch<T>,

    /// The control state of the worker.
    control: Control,
}

impl<'q, T: Task> Worker<'q, T> {
    /// Construct a new [`Worker`].
    ///
    /// The worker will be assigned the specified ID.
    ///
    /// ## Panics
    ///
    /// - Panics if `id >= queue.config().num_workers().get()`.
    /// - Panics if another worker has been assigned this ID already.
    pub fn new(queue: &'q Queue<T>, id: usize) -> Self {
        assert!(id < queue.config.num_workers.get());

        // Lock this ID.
        queue.control[id].initialize();

        Self {
            id,
            queue,
            enqueuer: Rc::new(Enqueuer::new()),
            postponed: Vec::new(),
            // SAFETY: This worker uses 'id' and 'global'.
            batch: unsafe { Batch::new(id, &queue.config) },
            control: Control::Running,
        }
    }

    /// The ID of this worker.
    ///
    /// This is the value assigned to the worker in [`Worker::new()`].
    #[inline]
    pub const fn id(&self) -> usize {
        self.id
    }

    /// The associated global queue.
    #[inline]
    pub const fn queue(&self) -> &'q Queue<T> {
        self.queue
    }

    /// The associated [`Enqueuer`].
    #[inline]
    pub const fn enqueuer(&self) -> &Rc<Enqueuer<T>> {
        &self.enqueuer
    }

    /// Enqueue a set of tasks.
    ///
    /// The tasks will be added to a thread-local [`Vec`], where they will
    /// remain until they are used in the [`Worker`]'s batch.
    ///
    /// This is a shorthand for `self.enqueuer().extend(tasks)`.  If the worker
    /// is borrowed mutably, the [`Enqueuer`] can be used directly by cloning
    /// the [`Rc`] returned by [`Worker::enqueuer()`].
    #[inline]
    pub fn enqueue(&self, tasks: impl IntoIterator<Item = T>) {
        self.enqueuer.extend(tasks)
    }

    /// Enqueue a single task.
    ///
    /// The task will be added to a thread-local [`Vec`], where it will remain
    /// until it is used in the [`Worker`]'s batch.
    ///
    /// This is a shorthand for `self.enqueuer().add(task)`.
    #[inline]
    pub fn enqueue_one(&self, task: T) {
        self.enqueuer.add(task);
    }

    /// Retrieve a single task asynchronously.
    ///
    /// If [`None`] is returned, the task queue has been shut down.
    pub async fn next(&mut self) -> Option<T> {
        core::future::poll_fn(|cx| self.poll(cx.waker())).await
    }

    /// Poll for a single task.
    ///
    /// If [`None`] is returned, the task queue has been shut down.
    #[inline]
    pub fn poll(&mut self, waker: &Waker) -> Poll<Option<T>> {
        // Get a task from the batch, or refresh it.
        if let Some(task) = unsafe { self.batch.next(self.id, self.queue) } {
            debug_assert_eq!(self.control, Control::Running);
            return Poll::Ready(Some(task));
        }

        self.poll_slow(waker)
    }

    #[cold]
    fn poll_slow(&mut self, waker: &Waker) -> Poll<Option<T>> {
        if self.control == Control::Running {
            self.refresh_and_poll(waker)
        } else if self.control == Control::Asleep {
            let control = &self.queue.control[self.id];
            let waker_slot = &self.queue.waker_slot[self.id];

            // First, check for recently enqueued tasks.
            if self.enqueuer.take_waker().is_none() {
                // Mark the worker as awake.
                // SAFETY: The state is currently Asleep.
                unsafe { control.set_self_awake(waker_slot) };
                self.control = Control::Running;
            } else {
                // Poll the control state.
                // SAFETY: The state is currently Asleep.
                self.control =
                    unsafe { control.poll_asleep(waker, waker_slot) };
            }

            // React to the updated state.
            if matches!(self.control, Control::Asleep) {
                self.enqueuer.set_waker(waker.clone());

                Poll::Pending
            } else {
                if self.queue.queue_control.mark_awake().is_break() {
                    self.control = Control::ShuttingDown;
                    return Poll::Ready(None);
                }

                self.poll(waker)
            }
        } else if self.control == Control::Initialized {
            // Mark the worker as running.
            self.control = Control::Running;

            self.poll(waker)
        } else {
            // The queue is shutting down.
            Poll::Ready(None)
        }
    }

    /// Refresh the batch and retrieve the next task to execute.
    fn refresh_and_poll(&mut self, waker: &Waker) -> Poll<Option<T>> {
        if self.queue.queue_control.has_shut_down() {
            return Poll::Ready(None);
        }

        self.collect();

        let task = self.postponed.pop();

        unsafe {
            self.batch.fill(
                task.is_some() as usize,
                &mut self.postponed,
                self.id,
                self.queue,
            )
        };

        match task {
            Some(task) => Poll::Ready(Some(task)),

            None => {
                // Mark the worker as asleep.
                let control = &self.queue.control[self.id];
                let waker_slot = &self.queue.waker_slot[self.id];
                // SAFETY: 'sleep_state' and 'control' correspond.
                unsafe { control.set_self_asleep(waker_slot, waker.clone()) };
                self.enqueuer.set_waker(waker.clone());
                self.control = match self.queue.queue_control.mark_asleep() {
                    ControlFlow::Continue(0) if self.queue.config.oneshot => {
                        self.queue.shutdown();
                        Control::ShuttingDown
                    }
                    ControlFlow::Continue(_) => Control::Asleep,
                    ControlFlow::Break(_) => Control::ShuttingDown,
                };

                match self.control {
                    Control::Asleep => Poll::Pending,
                    Control::ShuttingDown => Poll::Ready(None),
                    _ => unreachable!(),
                }
            }
        }
    }

    /// Collect tasks into the local queue.
    fn collect(&mut self) {
        // Drain the current batch of tasks.
        unsafe { self.batch.drain(&mut self.postponed, self.id, self.queue) };

        // Approximate the highest-available priority thus far.
        //
        // Both the local and public queues are sorted in ascending order of
        // priority, and the last elements of the two have comparable priorities
        // (since they were adjacent when previously sorted), so the last task
        // in the local queue right now, after the appending the public queue,
        // is almost exactly the highest-priority task known.  This ignores any
        // recently-enqueued tasks, but we only need an approximation here.
        let max_priority = self.postponed.last().map(|t| t.priority());

        // Collect recently-enqueued tasks.
        self.enqueuer.drain(&mut self.postponed);

        // Steal higher-priority tasks from the global queue.
        let pq = self.batch.pub_queue.id(&self.queue.config);
        // SAFETY:
        // - We just took ownership of the public queue 'pq'.
        // - 'pq' does not contain any tasks.
        // - We set our public priority to 'None'.
        if let Some(pq) = unsafe { self.queue.steal(max_priority, pq) } {
            // Update the public queue details, even if nobody can see them.
            let stealer = &self.queue.stealer[self.id];
            // SAFETY:
            // - Our public priority is 'None'.
            // - 'stealer' currently contains 'last_pubqueue'.
            unsafe { stealer.set(self.batch.pub_queue, pq) };
            self.batch.pub_queue = pq;

            // Locate the public queue contents.
            let pq = self.batch.pub_queue.id(&self.queue.config);
            let len = self.batch.pub_queue.len(&self.queue.config);
            let pq = &self.queue.pq_contents[pq];

            // Move the tasks out of the public queue.
            // SAFETY:
            // - 'len <= pq_size' as per 'PubQueue::len()'.
            // - We just stole 'pq', and it had 'len' elements at the time of
            //   the theft, and we have not changed it.
            // - This worker owns 'pq' so nobody will write to it.
            unsafe { pq.move_to(len.get(), &mut self.postponed) };
        }

        // Sort the now-filled local queue by priority.
        let batch_size = self.queue.config.batch_size.get();
        if <T::Priority as TaskPriority>::TRIVIAL {
            // Don't sort the queue at all.
        } else if self.postponed.len() > batch_size * 2 {
            // Only sort the used elements of the queue.
            let sort_offset = self.postponed.len() - batch_size * 2;
            self.postponed
                .select_nth_unstable_by_key(sort_offset, |task| {
                    task.priority()
                });
            self.postponed[sort_offset..]
                .sort_unstable_by_key(|task| task.priority());
        } else {
            // The queue is not saturated; sort it completely.
            self.postponed.sort_unstable_by_key(|task| task.priority());
        }

        debug_assert!(self.batch.counter.is_empty());
        debug_assert!(self.batch.local.is_empty());
        debug_assert!(self.batch.pq_priority.is_none());
    }
}

impl<T: Task> Drop for Worker<'_, T> {
    fn drop(&mut self) {
        // Collect tasks from the public queue, as the global 'Queue' does not
        // know whether they exist.
        unsafe { self.batch.drain(&mut self.postponed, self.id, self.queue) };
    }
}

//----------- Tests ------------------------------------------------------------

#[cfg(test)]
mod test {
    use core::{
        convert::Infallible,
        iter,
        num::{NonZeroU8, NonZeroUsize},
        task::{Poll, Waker},
    };

    use crate::{Config, Task, Worker};

    #[test]
    fn new() {
        let workers = 8.try_into().unwrap();
        let batch_size = NonZeroUsize::MIN;
        let queue = Config::new(workers)
            .with_batch_size(batch_size)
            .build::<Infallible>();
        for id in 0..8 {
            let _ = Worker::new(&queue, id);
        }
    }

    #[test]
    #[should_panic]
    fn new_too_many() {
        let workers = 4.try_into().unwrap();
        let batch_size = NonZeroUsize::MIN;
        let queue = Config::new(workers)
            .with_batch_size(batch_size)
            .build::<Infallible>();
        for id in 0..5 {
            let _ = Worker::new(&queue, id);
        }
    }

    #[test]
    fn next_single() {
        struct Foo(u8);

        impl Task for Foo {
            type Priority = ();

            fn priority(&self) -> Self::Priority {}
        }

        let workers = 1.try_into().unwrap();
        let batch_size = NonZeroUsize::MIN;
        let queue = Config::new(workers).with_batch_size(batch_size).build();
        let mut worker = Worker::new(&queue, 0);

        // Enqueue the tasks.
        worker.enqueuer().extend((0..4).map(Foo));

        // Execute the tasks.
        let mut seen = [false; 4];
        let waker = Waker::noop();
        while let Poll::Ready(Some(task)) = worker.poll(waker) {
            let Foo(index) = task;
            assert!(!seen[index as usize]);
            seen[index as usize] = true;
        }

        assert_eq!(seen, [true; 4]);
    }

    #[test]
    fn priority() {
        struct Foo(NonZeroU8);

        impl Task for Foo {
            type Priority = NonZeroU8;

            fn priority(&self) -> Self::Priority {
                self.0
            }
        }

        let workers = 1.try_into().unwrap();
        let batch_size = NonZeroUsize::MIN;
        let queue = Config::new(workers).with_batch_size(batch_size).build();
        let mut worker = Worker::new(&queue, 0);

        // Enqueue the tasks.
        worker
            .enqueuer()
            .extend((1..5).rev().map(|i| Foo(NonZeroU8::new(i).unwrap())));

        // Execute the tasks.
        let waker = Waker::noop();
        assert!(
            iter::from_fn(|| match worker.poll(waker) {
                Poll::Ready(Some(t)) => Some(t),
                _ => None,
            })
            .map(|t| t.0.get())
            .eq((1..5).rev())
        );
    }
}