tael-server 0.3.2

AI-agent-native observability server — OTLP trace ingestion with DuckDB storage
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
use std::path::Path;
use std::sync::Mutex;

use anyhow::Result;
use chrono::{DateTime, NaiveDateTime, Utc};
use duckdb::{params, Connection};

use super::models::{
    Anomaly, AnomalyReport, CorrelateReport, ErrorOperation, LogQuery, LogRecord, LogSeverity,
    LogSummary, MetricPoint, MetricQuery, MetricSummary, MetricType, ServiceSummary, Span,
    SpanStatus, SummaryReport, TraceComment, TraceQuery, TraceSummary,
};

/// Build a JSON path expression for a single top-level attribute key.
/// Quoting `$."<key>"` lets dotted keys (e.g. `http.method`) work, since the
/// unquoted form `$.http.method` would walk into a nested object.
fn json_path_for_key(key: &str) -> String {
    let escaped = key.replace('\\', r"\\").replace('"', r#"\""#);
    format!(r#"$."{escaped}""#)
}

fn parse_timestamp(s: &str) -> DateTime<Utc> {
    NaiveDateTime::parse_from_str(s, "%Y-%m-%d %H:%M:%S%.f")
        .or_else(|_| NaiveDateTime::parse_from_str(s, "%Y-%m-%d %H:%M:%S"))
        .map(|dt| dt.and_utc())
        .unwrap_or_default()
}

fn row_to_span(row: &duckdb::Row<'_>) -> duckdb::Result<Span> {
    let attrs_str: String = row.get(9)?;
    let events_str: String = row.get(10)?;
    let status_str: String = row.get(8)?;
    let parent: Option<String> = row.get(2)?;
    let start_str: String = row.get(5)?;
    let end_str: String = row.get(6)?;

    Ok(Span {
        trace_id: row.get(0)?,
        span_id: row.get(1)?,
        parent_span_id: if parent.as_deref() == Some("") {
            None
        } else {
            parent
        },
        service: row.get(3)?,
        operation: row.get(4)?,
        start_time: parse_timestamp(&start_str),
        end_time: parse_timestamp(&end_str),
        duration_ms: row.get(7)?,
        status: SpanStatus::from_str(&status_str),
        attributes: serde_json::from_str(&attrs_str).unwrap_or_default(),
        events: serde_json::from_str(&events_str).unwrap_or_default(),
    })
}

pub struct DuckDbStore {
    conn: Mutex<Connection>,
}

impl DuckDbStore {
    pub fn new(data_dir: &str) -> Result<Self> {
        std::fs::create_dir_all(data_dir)?;
        let db_path = Path::new(data_dir).join("tael.duckdb");
        let conn = Connection::open(db_path)?;
        let store = Self {
            conn: Mutex::new(conn),
        };
        store.init_schema()?;
        Ok(store)
    }

    fn init_schema(&self) -> Result<()> {
        let conn = self.conn.lock().unwrap();
        conn.execute_batch(
            "
            CREATE TABLE IF NOT EXISTS spans (
                trace_id       VARCHAR NOT NULL,
                span_id        VARCHAR NOT NULL,
                parent_span_id VARCHAR,
                service        VARCHAR NOT NULL,
                operation      VARCHAR NOT NULL,
                start_time     TIMESTAMP NOT NULL,
                end_time       TIMESTAMP NOT NULL,
                duration_ms    DOUBLE NOT NULL,
                status         VARCHAR NOT NULL DEFAULT 'unset',
                attributes     JSON,
                events         JSON,
                PRIMARY KEY (trace_id, span_id)
            );

            CREATE INDEX IF NOT EXISTS idx_spans_service ON spans(service);
            CREATE INDEX IF NOT EXISTS idx_spans_start_time ON spans(start_time);
            CREATE INDEX IF NOT EXISTS idx_spans_trace_id ON spans(trace_id);
            CREATE INDEX IF NOT EXISTS idx_spans_status ON spans(status);

            CREATE TABLE IF NOT EXISTS trace_comments (
                id         VARCHAR NOT NULL PRIMARY KEY,
                trace_id   VARCHAR NOT NULL,
                span_id    VARCHAR,
                author     VARCHAR NOT NULL,
                body       VARCHAR NOT NULL,
                created_at TIMESTAMP NOT NULL DEFAULT current_timestamp::TIMESTAMP
            );

            CREATE INDEX IF NOT EXISTS idx_comments_trace_id ON trace_comments(trace_id);

            CREATE TABLE IF NOT EXISTS logs (
                timestamp          TIMESTAMP NOT NULL,
                observed_timestamp TIMESTAMP NOT NULL,
                trace_id           VARCHAR,
                span_id            VARCHAR,
                severity           VARCHAR NOT NULL DEFAULT 'unspecified',
                severity_text      VARCHAR NOT NULL DEFAULT '',
                body               VARCHAR NOT NULL DEFAULT '',
                service            VARCHAR NOT NULL,
                attributes         JSON
            );

            CREATE INDEX IF NOT EXISTS idx_logs_service ON logs(service);
            CREATE INDEX IF NOT EXISTS idx_logs_timestamp ON logs(timestamp);
            CREATE INDEX IF NOT EXISTS idx_logs_severity ON logs(severity);
            CREATE INDEX IF NOT EXISTS idx_logs_trace_id ON logs(trace_id);

            CREATE TABLE IF NOT EXISTS metrics (
                timestamp   TIMESTAMP NOT NULL,
                service     VARCHAR NOT NULL,
                name        VARCHAR NOT NULL,
                metric_type VARCHAR NOT NULL DEFAULT 'unknown',
                value       DOUBLE NOT NULL,
                unit        VARCHAR NOT NULL DEFAULT '',
                attributes  JSON
            );

            CREATE INDEX IF NOT EXISTS idx_metrics_service ON metrics(service);
            CREATE INDEX IF NOT EXISTS idx_metrics_name ON metrics(name);
            CREATE INDEX IF NOT EXISTS idx_metrics_timestamp ON metrics(timestamp);
            ",
        )?;
        Ok(())
    }

    pub fn insert_spans(&self, spans: &[Span]) -> Result<()> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "INSERT OR REPLACE INTO spans
             (trace_id, span_id, parent_span_id, service, operation,
              start_time, end_time, duration_ms, status, attributes, events)
             VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)",
        )?;

        for span in spans {
            let attrs = serde_json::to_string(&span.attributes)?;
            let events = serde_json::to_string(&span.events)?;
            stmt.execute(params![
                span.trace_id,
                span.span_id,
                span.parent_span_id,
                span.service,
                span.operation,
                span.start_time.format("%Y-%m-%d %H:%M:%S%.6f").to_string(),
                span.end_time.format("%Y-%m-%d %H:%M:%S%.6f").to_string(),
                span.duration_ms,
                span.status.to_string(),
                attrs,
                events,
            ])?;
        }
        Ok(())
    }

    pub fn query_traces(&self, query: &TraceQuery) -> Result<Vec<Span>> {
        let conn = self.conn.lock().unwrap();

        let mut sql = String::from(
            "SELECT trace_id, span_id, parent_span_id, service, operation,
                    start_time::VARCHAR, end_time::VARCHAR, duration_ms, status, attributes, events
             FROM spans WHERE 1=1",
        );
        let mut param_values: Vec<Box<dyn duckdb::ToSql>> = Vec::new();

        if let Some(ref svc) = query.service {
            sql.push_str(" AND service = ?");
            param_values.push(Box::new(svc.clone()));
        }
        if let Some(ref op) = query.operation {
            sql.push_str(" AND operation LIKE ?");
            param_values.push(Box::new(format!("%{op}%")));
        }
        if let Some(min) = query.min_duration_ms {
            sql.push_str(" AND duration_ms >= ?");
            param_values.push(Box::new(min));
        }
        if let Some(max) = query.max_duration_ms {
            sql.push_str(" AND duration_ms <= ?");
            param_values.push(Box::new(max));
        }
        if let Some(ref status) = query.status {
            sql.push_str(" AND status = ?");
            param_values.push(Box::new(status.clone()));
        }
        if let Some(secs) = query.last_seconds {
            sql.push_str(&format!(" AND start_time >= current_timestamp::TIMESTAMP - INTERVAL '{secs} seconds'"));
        }
        for (k, v) in &query.attributes {
            sql.push_str(" AND json_extract_string(attributes, ?) = ?");
            param_values.push(Box::new(json_path_for_key(k)));
            param_values.push(Box::new(v.clone()));
        }

        sql.push_str(" ORDER BY start_time DESC");

        let limit = query.limit.unwrap_or(100);
        sql.push_str(&format!(" LIMIT {limit}"));

        let params_ref: Vec<&dyn duckdb::ToSql> = param_values.iter().map(|p| p.as_ref()).collect();
        let mut stmt = conn.prepare(&sql)?;
        let rows = stmt.query_map(params_ref.as_slice(), row_to_span)?;

        let mut spans = Vec::new();
        for row in rows {
            spans.push(row?);
        }
        Ok(spans)
    }

    pub fn get_trace(&self, trace_id: &str) -> Result<Vec<Span>> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "SELECT trace_id, span_id, parent_span_id, service, operation,
                    start_time::VARCHAR, end_time::VARCHAR, duration_ms, status, attributes, events
             FROM spans
             WHERE trace_id = ?
             ORDER BY start_time ASC",
        )?;

        let rows = stmt.query_map(params![trace_id], row_to_span)?;

        let mut spans = Vec::new();
        for row in rows {
            spans.push(row?);
        }
        Ok(spans)
    }

    pub fn add_comment(
        &self,
        trace_id: &str,
        span_id: Option<&str>,
        author: &str,
        body: &str,
    ) -> Result<TraceComment> {
        let conn = self.conn.lock().unwrap();
        let id = uuid::Uuid::new_v4().to_string();
        conn.execute(
            "INSERT INTO trace_comments (id, trace_id, span_id, author, body)
             VALUES (?, ?, ?, ?, ?)",
            params![id, trace_id, span_id, author, body],
        )?;

        let mut stmt = conn.prepare(
            "SELECT id, trace_id, span_id, author, body, created_at::VARCHAR
             FROM trace_comments WHERE id = ?",
        )?;
        let comment = stmt.query_row(params![id], |row| {
            Ok(TraceComment {
                id: row.get(0)?,
                trace_id: row.get(1)?,
                span_id: row.get(2)?,
                author: row.get(3)?,
                body: row.get(4)?,
                created_at: row.get(5)?,
            })
        })?;
        Ok(comment)
    }

    pub fn get_comments(&self, trace_id: &str) -> Result<Vec<TraceComment>> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "SELECT id, trace_id, span_id, author, body, created_at::VARCHAR
             FROM trace_comments
             WHERE trace_id = ?
             ORDER BY created_at ASC",
        )?;
        let rows = stmt.query_map(params![trace_id], |row| {
            Ok(TraceComment {
                id: row.get(0)?,
                trace_id: row.get(1)?,
                span_id: row.get(2)?,
                author: row.get(3)?,
                body: row.get(4)?,
                created_at: row.get(5)?,
            })
        })?;
        let mut comments = Vec::new();
        for row in rows {
            comments.push(row?);
        }
        Ok(comments)
    }

    pub fn list_services(&self) -> Result<Vec<ServiceInfo>> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "SELECT service,
                    COUNT(*) as span_count,
                    COUNT(DISTINCT trace_id) as trace_count,
                    AVG(duration_ms) as avg_duration,
                    SUM(CASE WHEN status = 'error' THEN 1 ELSE 0 END)::DOUBLE / COUNT(*)::DOUBLE as error_rate
             FROM spans
             GROUP BY service
             ORDER BY span_count DESC",
        )?;

        let rows = stmt.query_map([], |row| {
            Ok(ServiceInfo {
                name: row.get(0)?,
                span_count: row.get(1)?,
                trace_count: row.get(2)?,
                avg_duration_ms: row.get(3)?,
                error_rate: row.get(4)?,
            })
        })?;

        let mut services = Vec::new();
        for row in rows {
            services.push(row?);
        }
        Ok(services)
    }

    // ── Log storage ─────────────────────────────────────────────────

    pub fn insert_logs(&self, logs: &[LogRecord]) -> Result<()> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "INSERT INTO logs
             (timestamp, observed_timestamp, trace_id, span_id, severity,
              severity_text, body, service, attributes)
             VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)",
        )?;

        for log in logs {
            let attrs = serde_json::to_string(&log.attributes)?;
            stmt.execute(params![
                log.timestamp.format("%Y-%m-%d %H:%M:%S%.6f").to_string(),
                log.observed_timestamp.format("%Y-%m-%d %H:%M:%S%.6f").to_string(),
                log.trace_id,
                log.span_id,
                log.severity.to_string(),
                log.severity_text,
                log.body,
                log.service,
                attrs,
            ])?;
        }
        Ok(())
    }

    pub fn query_logs(&self, query: &LogQuery) -> Result<Vec<LogRecord>> {
        let conn = self.conn.lock().unwrap();

        let mut sql = String::from(
            "SELECT timestamp::VARCHAR, observed_timestamp::VARCHAR, trace_id, span_id,
                    severity, severity_text, body, service, attributes
             FROM logs WHERE 1=1",
        );
        let mut param_values: Vec<Box<dyn duckdb::ToSql>> = Vec::new();

        if let Some(ref svc) = query.service {
            sql.push_str(" AND service = ?");
            param_values.push(Box::new(svc.clone()));
        }
        if let Some(ref sev) = query.severity {
            sql.push_str(" AND severity = ?");
            param_values.push(Box::new(sev.clone()));
        }
        if let Some(ref body) = query.body_contains {
            sql.push_str(" AND body LIKE ?");
            param_values.push(Box::new(format!("%{body}%")));
        }
        if let Some(ref tid) = query.trace_id {
            sql.push_str(" AND trace_id = ?");
            param_values.push(Box::new(tid.clone()));
        }
        if let Some(secs) = query.last_seconds {
            sql.push_str(&format!(
                " AND timestamp >= current_timestamp::TIMESTAMP - INTERVAL '{secs} seconds'"
            ));
        }

        sql.push_str(" ORDER BY timestamp DESC");

        let limit = query.limit.unwrap_or(100);
        sql.push_str(&format!(" LIMIT {limit}"));

        let params_ref: Vec<&dyn duckdb::ToSql> =
            param_values.iter().map(|p| p.as_ref()).collect();
        let mut stmt = conn.prepare(&sql)?;
        let rows = stmt.query_map(params_ref.as_slice(), |row| {
            let ts_str: String = row.get(0)?;
            let obs_str: String = row.get(1)?;
            let attrs_str: String = row.get(8)?;
            let severity_str: String = row.get(4)?;

            Ok(LogRecord {
                timestamp: parse_timestamp(&ts_str),
                observed_timestamp: parse_timestamp(&obs_str),
                trace_id: row.get(2)?,
                span_id: row.get(3)?,
                severity: LogSeverity::from_str(&severity_str),
                severity_text: row.get(5)?,
                body: row.get(6)?,
                service: row.get(7)?,
                attributes: serde_json::from_str(&attrs_str).unwrap_or_default(),
            })
        })?;

        let mut logs = Vec::new();
        for row in rows {
            logs.push(row?);
        }
        Ok(logs)
    }

    // ── Metric storage ──────────────────────────────────────────────

    pub fn insert_metrics(&self, metrics: &[MetricPoint]) -> Result<()> {
        let conn = self.conn.lock().unwrap();
        let mut stmt = conn.prepare(
            "INSERT INTO metrics
             (timestamp, service, name, metric_type, value, unit, attributes)
             VALUES (?, ?, ?, ?, ?, ?, ?)",
        )?;

        for m in metrics {
            let attrs = serde_json::to_string(&m.attributes)?;
            stmt.execute(params![
                m.timestamp.format("%Y-%m-%d %H:%M:%S%.6f").to_string(),
                m.service,
                m.name,
                m.metric_type.to_string(),
                m.value,
                m.unit,
                attrs,
            ])?;
        }
        Ok(())
    }

    pub fn query_metrics(&self, query: &MetricQuery) -> Result<Vec<MetricPoint>> {
        let conn = self.conn.lock().unwrap();

        let mut sql = String::from(
            "SELECT timestamp::VARCHAR, service, name, metric_type, value, unit, attributes
             FROM metrics WHERE 1=1",
        );
        let mut param_values: Vec<Box<dyn duckdb::ToSql>> = Vec::new();

        if let Some(ref svc) = query.service {
            sql.push_str(" AND service = ?");
            param_values.push(Box::new(svc.clone()));
        }
        if let Some(ref name) = query.name {
            sql.push_str(" AND name = ?");
            param_values.push(Box::new(name.clone()));
        }
        if let Some(ref mt) = query.metric_type {
            sql.push_str(" AND metric_type = ?");
            param_values.push(Box::new(mt.clone()));
        }
        if let Some(secs) = query.last_seconds {
            sql.push_str(&format!(
                " AND timestamp >= current_timestamp::TIMESTAMP - INTERVAL '{secs} seconds'"
            ));
        }

        sql.push_str(" ORDER BY timestamp DESC");

        let limit = query.limit.unwrap_or(500);
        sql.push_str(&format!(" LIMIT {limit}"));

        let params_ref: Vec<&dyn duckdb::ToSql> =
            param_values.iter().map(|p| p.as_ref()).collect();
        let mut stmt = conn.prepare(&sql)?;
        let rows = stmt.query_map(params_ref.as_slice(), |row| {
            let ts_str: String = row.get(0)?;
            let mt_str: String = row.get(3)?;
            let attrs_str: String = row.get(6)?;

            Ok(MetricPoint {
                timestamp: parse_timestamp(&ts_str),
                service: row.get(1)?,
                name: row.get(2)?,
                metric_type: MetricType::from_str(&mt_str),
                value: row.get(4)?,
                unit: row.get(5)?,
                attributes: serde_json::from_str(&attrs_str).unwrap_or_default(),
            })
        })?;

        let mut metrics = Vec::new();
        for row in rows {
            metrics.push(row?);
        }
        Ok(metrics)
    }

    pub fn query_summary(
        &self,
        last_seconds: i64,
        service: Option<&str>,
    ) -> Result<SummaryReport> {
        let conn = self.conn.lock().unwrap();

        let span_time_clause = format!(
            "start_time >= current_timestamp::TIMESTAMP - INTERVAL '{last_seconds} seconds'"
        );
        let ts_time_clause = format!(
            "timestamp >= current_timestamp::TIMESTAMP - INTERVAL '{last_seconds} seconds'"
        );

        let svc_clause = if service.is_some() { " AND service = ?" } else { "" };
        let svc_owned = service.map(|s| s.to_string());
        let build_params = || -> Vec<&dyn duckdb::ToSql> {
            match &svc_owned {
                Some(s) => vec![s as &dyn duckdb::ToSql],
                None => vec![],
            }
        };

        // ── Traces aggregate ─────────────────────────────────────────
        let traces_sql = format!(
            "SELECT
                COUNT(*)::BIGINT,
                COUNT(DISTINCT trace_id)::BIGINT,
                SUM(CASE WHEN status='error' THEN 1 ELSE 0 END)::BIGINT,
                COALESCE(AVG(duration_ms), 0.0),
                COALESCE(MAX(duration_ms), 0.0),
                COALESCE(quantile_cont(duration_ms, 0.5), 0.0),
                COALESCE(quantile_cont(duration_ms, 0.95), 0.0),
                COALESCE(quantile_cont(duration_ms, 0.99), 0.0)
             FROM spans WHERE {span_time_clause}{svc_clause}"
        );
        let mut stmt = conn.prepare(&traces_sql)?;
        let traces: TraceSummary = stmt.query_row(build_params().as_slice(), |row| {
            let span_count: i64 = row.get::<_, Option<i64>>(0)?.unwrap_or(0);
            let error_count: i64 = row.get::<_, Option<i64>>(2)?.unwrap_or(0);
            let error_rate = if span_count > 0 {
                error_count as f64 / span_count as f64
            } else {
                0.0
            };
            Ok(TraceSummary {
                span_count,
                trace_count: row.get::<_, Option<i64>>(1)?.unwrap_or(0),
                error_count,
                error_rate,
                avg_ms: row.get(3)?,
                max_ms: row.get(4)?,
                p50_ms: row.get(5)?,
                p95_ms: row.get(6)?,
                p99_ms: row.get(7)?,
            })
        })?;
        drop(stmt);

        // ── Top services by span count ───────────────────────────────
        let top_svc_sql = format!(
            "SELECT service,
                    COUNT(*)::BIGINT,
                    SUM(CASE WHEN status='error' THEN 1 ELSE 0 END)::DOUBLE / NULLIF(COUNT(*), 0)::DOUBLE,
                    COALESCE(quantile_cont(duration_ms, 0.95), 0.0)
             FROM spans WHERE {span_time_clause}{svc_clause}
             GROUP BY service
             ORDER BY 2 DESC
             LIMIT 5"
        );
        let mut stmt = conn.prepare(&top_svc_sql)?;
        let top_services: Vec<ServiceSummary> = stmt
            .query_map(build_params().as_slice(), |row| {
                Ok(ServiceSummary {
                    service: row.get(0)?,
                    span_count: row.get(1)?,
                    error_rate: row.get::<_, Option<f64>>(2)?.unwrap_or(0.0),
                    p95_ms: row.get(3)?,
                })
            })?
            .collect::<duckdb::Result<_>>()?;
        drop(stmt);

        // ── Top error operations ─────────────────────────────────────
        let err_op_sql = format!(
            "SELECT service, operation, COUNT(*)::BIGINT
             FROM spans
             WHERE status='error' AND {span_time_clause}{svc_clause}
             GROUP BY service, operation
             ORDER BY 3 DESC
             LIMIT 5"
        );
        let mut stmt = conn.prepare(&err_op_sql)?;
        let top_error_operations: Vec<ErrorOperation> = stmt
            .query_map(build_params().as_slice(), |row| {
                Ok(ErrorOperation {
                    service: row.get(0)?,
                    operation: row.get(1)?,
                    error_count: row.get(2)?,
                })
            })?
            .collect::<duckdb::Result<_>>()?;
        drop(stmt);

        // ── Logs aggregate ───────────────────────────────────────────
        let logs_sql = format!(
            "SELECT
                COUNT(*)::BIGINT,
                SUM(CASE WHEN severity IN ('error','fatal') THEN 1 ELSE 0 END)::BIGINT,
                SUM(CASE WHEN severity='warn' THEN 1 ELSE 0 END)::BIGINT,
                SUM(CASE WHEN severity='info' THEN 1 ELSE 0 END)::BIGINT,
                SUM(CASE WHEN severity IN ('debug','trace') THEN 1 ELSE 0 END)::BIGINT
             FROM logs WHERE {ts_time_clause}{svc_clause}"
        );
        let mut stmt = conn.prepare(&logs_sql)?;
        let logs: LogSummary = stmt.query_row(build_params().as_slice(), |row| {
            Ok(LogSummary {
                total: row.get::<_, Option<i64>>(0)?.unwrap_or(0),
                error: row.get::<_, Option<i64>>(1)?.unwrap_or(0),
                warn: row.get::<_, Option<i64>>(2)?.unwrap_or(0),
                info: row.get::<_, Option<i64>>(3)?.unwrap_or(0),
                debug: row.get::<_, Option<i64>>(4)?.unwrap_or(0),
            })
        })?;
        drop(stmt);

        // ── Metrics aggregate ────────────────────────────────────────
        let metrics_sql = format!(
            "SELECT COUNT(*)::BIGINT, COUNT(DISTINCT name)::BIGINT
             FROM metrics WHERE {ts_time_clause}{svc_clause}"
        );
        let mut stmt = conn.prepare(&metrics_sql)?;
        let metrics: MetricSummary = stmt.query_row(build_params().as_slice(), |row| {
            Ok(MetricSummary {
                point_count: row.get::<_, Option<i64>>(0)?.unwrap_or(0),
                unique_names: row.get::<_, Option<i64>>(1)?.unwrap_or(0),
            })
        })?;
        drop(stmt);

        Ok(SummaryReport {
            window_seconds: last_seconds,
            service_filter: service.map(|s| s.to_string()),
            traces,
            top_services,
            top_error_operations,
            logs,
            metrics,
        })
    }

    pub fn query_anomalies(
        &self,
        current_seconds: i64,
        baseline_seconds: i64,
        service: Option<&str>,
    ) -> Result<AnomalyReport> {
        let conn = self.conn.lock().unwrap();
        let svc_owned = service.map(|s| s.to_string());
        let svc_clause = if service.is_some() { " AND service = ?" } else { "" };

        // Per-service stats for a window whose end = now and start = now - window.
        let stats_sql = |window: i64| -> String {
            format!(
                "SELECT service,
                        COUNT(*)::BIGINT AS span_count,
                        SUM(CASE WHEN status='error' THEN 1 ELSE 0 END)::DOUBLE
                            / NULLIF(COUNT(*), 0)::DOUBLE AS error_rate,
                        COALESCE(quantile_cont(duration_ms, 0.95), 0.0) AS p95_ms
                 FROM spans
                 WHERE start_time >= current_timestamp::TIMESTAMP - INTERVAL '{window} seconds'{svc_clause}
                 GROUP BY service"
            )
        };

        let build_params = || -> Vec<&dyn duckdb::ToSql> {
            match &svc_owned {
                Some(s) => vec![s as &dyn duckdb::ToSql],
                None => vec![],
            }
        };

        let mut current_stats: std::collections::HashMap<String, (i64, f64, f64)> =
            std::collections::HashMap::new();
        let mut stmt = conn.prepare(&stats_sql(current_seconds))?;
        let rows = stmt.query_map(build_params().as_slice(), |row| {
            Ok((
                row.get::<_, String>(0)?,
                row.get::<_, i64>(1)?,
                row.get::<_, Option<f64>>(2)?.unwrap_or(0.0),
                row.get::<_, f64>(3)?,
            ))
        })?;
        for r in rows {
            let (svc, span_count, error_rate, p95) = r?;
            current_stats.insert(svc, (span_count, error_rate, p95));
        }
        drop(stmt);

        let mut baseline_stats: std::collections::HashMap<String, (i64, f64, f64)> =
            std::collections::HashMap::new();
        let mut stmt = conn.prepare(&stats_sql(baseline_seconds))?;
        let rows = stmt.query_map(build_params().as_slice(), |row| {
            Ok((
                row.get::<_, String>(0)?,
                row.get::<_, i64>(1)?,
                row.get::<_, Option<f64>>(2)?.unwrap_or(0.0),
                row.get::<_, f64>(3)?,
            ))
        })?;
        for r in rows {
            let (svc, span_count, error_rate, p95) = r?;
            baseline_stats.insert(svc, (span_count, error_rate, p95));
        }
        drop(stmt);

        let mut anomalies = Vec::new();
        for (svc, (cur_count, cur_err, cur_p95)) in &current_stats {
            if *cur_count < 5 {
                continue;
            }
            let (base_count, base_err, base_p95) =
                baseline_stats.get(svc).copied().unwrap_or((0, 0.0, 0.0));

            let err_delta = cur_err - base_err;
            if err_delta >= 0.05 && *cur_err > 0.0 {
                let severity = if err_delta >= 0.25 {
                    "critical"
                } else if err_delta >= 0.10 {
                    "warning"
                } else {
                    "info"
                };
                anomalies.push(Anomaly {
                    service: svc.clone(),
                    kind: "error_rate".into(),
                    severity: severity.into(),
                    current: *cur_err,
                    baseline: base_err,
                    delta: err_delta,
                    description: format!(
                        "Error rate rose {:.1}% → {:.1}% (baseline {:.1}%, {} spans)",
                        base_err * 100.0,
                        cur_err * 100.0,
                        base_err * 100.0,
                        cur_count
                    ),
                });
            }

            if base_p95 > 0.0 && base_count >= 5 {
                let ratio = cur_p95 / base_p95;
                if ratio >= 1.5 && *cur_p95 > 50.0 {
                    let severity = if ratio >= 3.0 {
                        "critical"
                    } else if ratio >= 2.0 {
                        "warning"
                    } else {
                        "info"
                    };
                    anomalies.push(Anomaly {
                        service: svc.clone(),
                        kind: "latency_p95".into(),
                        severity: severity.into(),
                        current: *cur_p95,
                        baseline: base_p95,
                        delta: cur_p95 - base_p95,
                        description: format!(
                            "p95 latency {:.1}ms → {:.1}ms ({:.1}× baseline)",
                            base_p95, cur_p95, ratio
                        ),
                    });
                }
            }
        }

        anomalies.sort_by(|a, b| {
            let rank = |s: &str| match s {
                "critical" => 0,
                "warning" => 1,
                _ => 2,
            };
            rank(&a.severity).cmp(&rank(&b.severity))
        });

        Ok(AnomalyReport {
            current_seconds,
            baseline_seconds,
            service_filter: svc_owned,
            anomalies,
        })
    }

    pub fn query_correlate(&self, trace_id: &str) -> Result<Option<CorrelateReport>> {
        let spans = self.get_trace(trace_id)?;
        if spans.is_empty() {
            return Ok(None);
        }

        let start_time = spans
            .iter()
            .map(|s| s.start_time)
            .min()
            .unwrap_or_else(Utc::now);
        let end_time = spans
            .iter()
            .map(|s| s.end_time)
            .max()
            .unwrap_or_else(Utc::now);
        let duration_ms = (end_time - start_time).num_milliseconds() as f64;
        let error_count = spans
            .iter()
            .filter(|s| matches!(s.status, SpanStatus::Error))
            .count() as i64;

        let mut services: Vec<String> =
            spans.iter().map(|s| s.service.clone()).collect();
        services.sort();
        services.dedup();

        let logs = self.query_logs(&LogQuery {
            trace_id: Some(trace_id.to_string()),
            limit: Some(500),
            ..Default::default()
        })?;

        // Metrics overlapping the trace's time range, scoped to touched services.
        let metrics = {
            let conn = self.conn.lock().unwrap();
            let start = start_time
                .naive_utc()
                .format("%Y-%m-%d %H:%M:%S%.6f")
                .to_string();
            let end = end_time
                .naive_utc()
                .format("%Y-%m-%d %H:%M:%S%.6f")
                .to_string();

            let placeholders = std::iter::repeat("?")
                .take(services.len())
                .collect::<Vec<_>>()
                .join(",");
            let sql = format!(
                "SELECT timestamp::VARCHAR, service, name, metric_type, value, unit, attributes
                 FROM metrics
                 WHERE timestamp BETWEEN ?::TIMESTAMP AND ?::TIMESTAMP
                   AND service IN ({placeholders})
                 ORDER BY timestamp ASC
                 LIMIT 500"
            );
            let mut stmt = conn.prepare(&sql)?;
            let mut params_vec: Vec<&dyn duckdb::ToSql> =
                vec![&start as &dyn duckdb::ToSql, &end as &dyn duckdb::ToSql];
            for s in &services {
                params_vec.push(s as &dyn duckdb::ToSql);
            }
            let rows = stmt.query_map(params_vec.as_slice(), |row| {
                let ts_str: String = row.get(0)?;
                let mt_str: String = row.get(3)?;
                let attrs_str: String = row.get(6)?;
                Ok(MetricPoint {
                    timestamp: parse_timestamp(&ts_str),
                    service: row.get(1)?,
                    name: row.get(2)?,
                    metric_type: MetricType::from_str(&mt_str),
                    value: row.get(4)?,
                    unit: row.get(5)?,
                    attributes: serde_json::from_str(&attrs_str).unwrap_or_default(),
                })
            })?;
            let mut out = Vec::new();
            for r in rows {
                out.push(r?);
            }
            out
        };

        Ok(Some(CorrelateReport {
            trace_id: trace_id.to_string(),
            span_count: spans.len(),
            services,
            start_time: start_time.to_rfc3339(),
            end_time: end_time.to_rfc3339(),
            duration_ms,
            error_count,
            logs,
            metrics,
        }))
    }
}

#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct ServiceInfo {
    pub name: String,
    pub span_count: i64,
    pub trace_count: i64,
    pub avg_duration_ms: f64,
    pub error_rate: f64,
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::collections::HashMap;

    fn span(trace_id: &str, attrs: &[(&str, &str)]) -> Span {
        let now = Utc::now();
        let mut attributes = HashMap::new();
        for (k, v) in attrs {
            attributes.insert((*k).to_string(), (*v).to_string());
        }
        Span {
            trace_id: trace_id.into(),
            span_id: format!("{trace_id}-span"),
            parent_span_id: None,
            service: "svc".into(),
            operation: "op".into(),
            start_time: now,
            end_time: now,
            duration_ms: 1.0,
            status: SpanStatus::Ok,
            attributes,
            events: vec![],
        }
    }

    fn store() -> DuckDbStore {
        let dir = tempfile::tempdir().unwrap();
        DuckDbStore::new(dir.path().to_str().unwrap()).unwrap()
    }

    #[test]
    fn attribute_filter_matches_dotted_key() {
        let s = store();
        s.insert_spans(&[
            span("a", &[("http.method", "GET"), ("http.status_code", "200")]),
            span("b", &[("http.method", "POST"), ("http.status_code", "500")]),
        ])
        .unwrap();

        let q = TraceQuery {
            attributes: vec![("http.method".into(), "GET".into())],
            ..Default::default()
        };
        let got = s.query_traces(&q).unwrap();
        assert_eq!(got.len(), 1);
        assert_eq!(got[0].trace_id, "a");
    }

    #[test]
    fn attribute_filters_are_anded() {
        let s = store();
        s.insert_spans(&[
            span("a", &[("http.method", "GET"), ("http.status_code", "200")]),
            span("b", &[("http.method", "GET"), ("http.status_code", "500")]),
        ])
        .unwrap();

        let q = TraceQuery {
            attributes: vec![
                ("http.method".into(), "GET".into()),
                ("http.status_code".into(), "500".into()),
            ],
            ..Default::default()
        };
        let got = s.query_traces(&q).unwrap();
        assert_eq!(got.len(), 1);
        assert_eq!(got[0].trace_id, "b");
    }

    #[test]
    fn attribute_filter_misses_when_value_differs() {
        let s = store();
        s.insert_spans(&[span("a", &[("env", "prod")])]).unwrap();

        let q = TraceQuery {
            attributes: vec![("env".into(), "staging".into())],
            ..Default::default()
        };
        assert!(s.query_traces(&q).unwrap().is_empty());
    }
}