sz-orm-limit 1.0.0

Rate limiting: token bucket, sliding window, per-user/IP/endpoint quotas
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
//! # SZ-ORM Limit — 限流器
//!
//! 提供令牌桶与滑动窗口限流,内置 OOM 防护(默认 max_keys=10000)。
//!
//! ## 主要类型
//!
//! - [`RateLimiter`] trait — 限流器接口
//! - `TokenBucketLimiter` — 令牌桶实现
//! - `SlidingWindowLimiter` — 滑动窗口实现
//!
//! v0.2.1 修复 Critical S-3:引入 `DEFAULT_MAX_KEYS` 防止无限 key 导致 OOM。

use std::collections::HashMap;
use std::sync::{Arc, RwLock};
use std::time::{Duration, Instant};

/// 默认最大 key 数量(v0.2.1 新增,修复 Critical S-3 OOM DoS)
///
/// 当 entries.len() 超过此值时,会强制淘汰一个 entry。
/// 调用方可通过 `with_max_keys()` 调整。
pub const DEFAULT_MAX_KEYS: usize = 10_000;

pub trait RateLimiter: Send + Sync {
    fn acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError>;
    fn try_acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError>;
    fn reset(&self, key: &str) -> Result<(), RateLimitError>;
}

#[derive(Debug, Clone)]
pub struct RateLimitResult {
    pub allowed: bool,
    pub remaining: u64,
    pub reset_at: i64,
}

impl RateLimitResult {
    pub fn allowed(remaining: u64, reset_at: i64) -> Self {
        Self {
            allowed: true,
            remaining,
            reset_at,
        }
    }

    pub fn rejected(remaining: u64, reset_at: i64) -> Self {
        Self {
            allowed: false,
            remaining,
            reset_at,
        }
    }
}

pub struct SlidingWindowRateLimiter {
    max_requests: u64,
    window_size: Duration,
    entries: Arc<RwLock<HashMap<String, SlidingWindowEntry>>>,
    /// 最大 key 数量(v0.2.1 新增,修复 Critical S-3 OOM DoS)
    max_keys: usize,
}

#[derive(Clone)]
struct SlidingWindowEntry {
    requests: Vec<Instant>,
}

impl SlidingWindowRateLimiter {
    pub fn new(max_requests: u64, window_size: Duration) -> Self {
        Self {
            max_requests,
            window_size,
            entries: Arc::new(RwLock::new(HashMap::new())),
            max_keys: DEFAULT_MAX_KEYS,
        }
    }

    /// 配置最大 key 数量(v0.2.1 新增,修复 Critical S-3 OOM DoS)
    ///
    /// 当 entries.len() 超过 `max_keys` 时,会强制淘汰一个最旧的 entry。
    /// 默认值为 `DEFAULT_MAX_KEYS`(10000)。
    pub fn with_max_keys(mut self, max_keys: usize) -> Self {
        self.max_keys = max_keys;
        self
    }

    fn cleanup_old_requests(&self, entry: &mut SlidingWindowEntry) {
        let now = Instant::now();
        entry
            .requests
            .retain(|&time| now.duration_since(time) < self.window_size);
    }

    /// 强制淘汰超出 `max_keys` 的最旧 entry(v0.2.1 新增,修复 Critical S-3)
    ///
    /// 策略:遍历所有 entry,找到 `requests[0]`(窗口内最早请求时间)最小的那个并删除。
    /// 复杂度 O(n),但仅在 `entries.len() > max_keys` 时触发。
    fn enforce_max_keys(&self, entries: &mut HashMap<String, SlidingWindowEntry>) {
        while entries.len() > self.max_keys {
            // 找到最旧的 entry(requests.first() 时间最早)
            let now = Instant::now();
            let oldest_key = entries
                .iter()
                .min_by_key(|(_, e)| e.requests.first().copied().unwrap_or(now))
                .map(|(k, _)| k.clone());
            match oldest_key {
                Some(k) => {
                    entries.remove(&k);
                }
                None => break,
            }
        }
    }
}

impl RateLimiter for SlidingWindowRateLimiter {
    fn acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError> {
        let mut entries = self
            .entries
            .write()
            .map_err(|e| RateLimitError::Internal(e.to_string()))?;

        // v0.2.1 修复 Critical S-3:写入前强制淘汰超出 max_keys 的 entry
        if entries.len() >= self.max_keys && !entries.contains_key(key) {
            self.enforce_max_keys(&mut entries);
        }

        let entry = entries
            .entry(key.to_string())
            .or_insert_with(|| SlidingWindowEntry {
                requests: Vec::new(),
            });

        self.cleanup_old_requests(entry);

        if entry.requests.len() < self.max_requests as usize {
            entry.requests.push(Instant::now());
            let remaining = self.max_requests - entry.requests.len() as u64;
            let reset_at = now_timestamp() + self.window_size.as_millis() as i64;
            Ok(RateLimitResult::allowed(remaining, reset_at))
        } else {
            let oldest = entry
                .requests
                .first()
                .map(|t| {
                    let elapsed = t.elapsed().as_millis() as i64;
                    let window_ms = self.window_size.as_millis() as i64;
                    now_timestamp() + (window_ms - elapsed)
                })
                .unwrap_or(now_timestamp());

            let remaining = 0;
            Ok(RateLimitResult::rejected(remaining, oldest))
        }
    }

    fn try_acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError> {
        self.acquire(key)
    }

    fn reset(&self, key: &str) -> Result<(), RateLimitError> {
        let mut entries = self
            .entries
            .write()
            .map_err(|e| RateLimitError::Internal(e.to_string()))?;
        entries.remove(key);
        Ok(())
    }
}

pub struct TokenBucketRateLimiter {
    capacity: f64,
    refill_rate: f64,
    entries: Arc<RwLock<HashMap<String, TokenBucketEntry>>>,
    /// 最大 key 数量(v0.2.1 新增,修复 Critical S-3 OOM DoS)
    max_keys: usize,
}

#[derive(Clone)]
struct TokenBucketEntry {
    tokens: f64,
    last_refill: Instant,
}

impl TokenBucketRateLimiter {
    pub fn new(capacity: u64, refill_per_second: f64) -> Self {
        Self {
            capacity: capacity as f64,
            refill_rate: refill_per_second,
            entries: Arc::new(RwLock::new(HashMap::new())),
            max_keys: DEFAULT_MAX_KEYS,
        }
    }

    /// 配置最大 key 数量(v0.2.1 新增,修复 Critical S-3 OOM DoS)
    pub fn with_max_keys(mut self, max_keys: usize) -> Self {
        self.max_keys = max_keys;
        self
    }

    fn refill(&self, entry: &mut TokenBucketEntry) {
        let now = Instant::now();
        let elapsed = now.duration_since(entry.last_refill).as_secs_f64();
        // 修复:refill_rate <= 0.0 时不补充令牌(也不消耗)
        // 避免负数 refill_rate 导致 tokens 递减
        let tokens_to_add = if self.refill_rate > 0.0 {
            elapsed * self.refill_rate
        } else {
            0.0
        };

        entry.tokens = (entry.tokens + tokens_to_add).min(self.capacity);
        entry.last_refill = now;
    }

    /// 强制淘汰超出 `max_keys` 的最旧 entry(v0.2.1 新增,修复 Critical S-3)
    ///
    /// 策略:找到 `last_refill` 最早的 entry(即最久未访问的)并删除。
    /// 复杂度 O(n),但仅在 `entries.len() > max_keys` 时触发。
    fn enforce_max_keys(&self, entries: &mut HashMap<String, TokenBucketEntry>) {
        while entries.len() > self.max_keys {
            let oldest_key = entries
                .iter()
                .min_by_key(|(_, e)| e.last_refill)
                .map(|(k, _)| k.clone());
            match oldest_key {
                Some(k) => {
                    entries.remove(&k);
                }
                None => break,
            }
        }
    }
}

impl RateLimiter for TokenBucketRateLimiter {
    fn acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError> {
        let mut entries = self
            .entries
            .write()
            .map_err(|e| RateLimitError::Internal(e.to_string()))?;

        // v0.2.1 修复 Critical S-3:写入前强制淘汰超出 max_keys 的 entry
        if entries.len() >= self.max_keys && !entries.contains_key(key) {
            self.enforce_max_keys(&mut entries);
        }

        let entry = entries
            .entry(key.to_string())
            .or_insert_with(|| TokenBucketEntry {
                tokens: self.capacity,
                last_refill: Instant::now(),
            });

        self.refill(entry);

        if entry.tokens >= 1.0 {
            entry.tokens -= 1.0;
            let remaining = entry.tokens.floor() as u64;
            // 修复:refill_rate <= 0.0 时令牌不补充,reset_at 设为远期时间
            // 避免除零产生 inf,inf as i64 触发 panic
            let reset_at = if self.refill_rate > 0.0 {
                now_timestamp() + (1000.0 / self.refill_rate) as i64
            } else {
                // 令牌永不补充,reset_at 设为远期时间(约 292 年后的 i64::MAX)
                i64::MAX
            };
            Ok(RateLimitResult::allowed(remaining, reset_at))
        } else {
            // 修复:refill_rate <= 0.0 时令牌不补充,永远等待
            let reset_at = if self.refill_rate > 0.0 {
                let wait_time = ((1.0 - entry.tokens) / self.refill_rate * 1000.0) as i64;
                now_timestamp() + wait_time
            } else {
                // 令牌永不补充,永远等待
                i64::MAX
            };
            Ok(RateLimitResult::rejected(0, reset_at))
        }
    }

    fn try_acquire(&self, key: &str) -> Result<RateLimitResult, RateLimitError> {
        self.acquire(key)
    }

    fn reset(&self, key: &str) -> Result<(), RateLimitError> {
        let mut entries = self
            .entries
            .write()
            .map_err(|e| RateLimitError::Internal(e.to_string()))?;
        entries.remove(key);
        Ok(())
    }
}

#[derive(Debug)]
pub enum RateLimitError {
    KeyNotFound(String),
    Internal(String),
}

impl std::fmt::Display for RateLimitError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            RateLimitError::KeyNotFound(key) => write!(f, "Key not found: {}", key),
            RateLimitError::Internal(msg) => write!(f, "Internal error: {}", msg),
        }
    }
}

impl std::error::Error for RateLimitError {}

impl serde::Serialize for RateLimitError {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        serializer.serialize_str(&self.to_string())
    }
}

fn now_timestamp() -> i64 {
    use std::time::{SystemTime, UNIX_EPOCH};
    SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .unwrap_or_default()
        .as_millis() as i64
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_rate_limit_result_allowed() {
        let result = RateLimitResult::allowed(5, 1000);
        assert!(result.allowed);
        assert_eq!(result.remaining, 5);
        assert_eq!(result.reset_at, 1000);
    }

    #[test]
    fn test_rate_limit_result_rejected() {
        let result = RateLimitResult::rejected(0, 2000);
        assert!(!result.allowed);
        assert_eq!(result.remaining, 0);
    }

    #[test]
    fn test_sliding_window_limiter_new() {
        let limiter = SlidingWindowRateLimiter::new(10, Duration::from_secs(60));
        let result = limiter.acquire("test-key");
        assert!(result.is_ok());
        assert!(result.unwrap().allowed);
    }

    #[test]
    fn test_sliding_window_limiter_full() {
        let limiter = SlidingWindowRateLimiter::new(2, Duration::from_secs(60));

        let r1 = limiter.acquire("key1").unwrap();
        assert!(r1.allowed);

        let r2 = limiter.acquire("key1").unwrap();
        assert!(r2.allowed);

        let r3 = limiter.acquire("key1").unwrap();
        assert!(!r3.allowed);
    }

    #[test]
    fn test_sliding_window_different_keys() {
        let limiter = SlidingWindowRateLimiter::new(1, Duration::from_secs(60));

        let r1 = limiter.acquire("key-a").unwrap();
        assert!(r1.allowed);

        let r2 = limiter.acquire("key-b").unwrap();
        assert!(r2.allowed);
    }

    #[test]
    fn test_sliding_window_reset() {
        let limiter = SlidingWindowRateLimiter::new(1, Duration::from_secs(60));

        limiter.acquire("reset-key").unwrap();
        limiter.acquire("reset-key").unwrap();

        limiter.reset("reset-key").unwrap();

        let result = limiter.acquire("reset-key").unwrap();
        assert!(result.allowed);
    }

    #[test]
    fn test_token_bucket_limiter_new() {
        let limiter = TokenBucketRateLimiter::new(10, 1.0);
        let result = limiter.acquire("test-key");
        assert!(result.is_ok());
        assert!(result.unwrap().allowed);
    }

    #[test]
    fn test_token_bucket_limiter_depletes() {
        let limiter = TokenBucketRateLimiter::new(2, 1.0);

        let r1 = limiter.acquire("key1").unwrap();
        assert!(r1.allowed);
        assert_eq!(r1.remaining, 1);

        let r2 = limiter.acquire("key1").unwrap();
        assert!(r2.allowed);
        assert_eq!(r2.remaining, 0);

        let r3 = limiter.acquire("key1").unwrap();
        assert!(!r3.allowed);
    }

    #[test]
    fn test_token_bucket_different_keys() {
        let limiter = TokenBucketRateLimiter::new(1, 1.0);

        let r1 = limiter.acquire("key-a").unwrap();
        assert!(r1.allowed);

        let r2 = limiter.acquire("key-b").unwrap();
        assert!(r2.allowed);
    }

    #[test]
    fn test_token_bucket_reset() {
        let limiter = TokenBucketRateLimiter::new(1, 1.0);

        limiter.acquire("reset-key").unwrap();
        limiter.acquire("reset-key").unwrap();

        limiter.reset("reset-key").unwrap();

        let result = limiter.acquire("reset-key").unwrap();
        assert!(result.allowed);
    }

    #[test]
    fn test_limiter_try_acquire() {
        let limiter = SlidingWindowRateLimiter::new(1, Duration::from_secs(60));

        let r1 = limiter.try_acquire("key").unwrap();
        assert!(r1.allowed);

        let r2 = limiter.try_acquire("key").unwrap();
        assert!(!r2.allowed);
    }

    // ===== TDD RED:refill_rate=0 panic 修复测试 =====

    #[test]
    fn test_token_bucket_zero_refill_rate_does_not_panic() {
        // refill_rate=0.0 表示令牌永不补充
        // capacity=1,第一次 acquire 应允许,第二次应拒绝且不 panic
        let limiter = TokenBucketRateLimiter::new(1, 0.0);

        let r1 = limiter.acquire("zero-refill").unwrap();
        assert!(r1.allowed, "first acquire should be allowed");

        // 第二次 acquire:令牌耗尽且不补充,应拒绝而非 panic
        let r2 = limiter.acquire("zero-refill").unwrap();
        assert!(!r2.allowed, "second acquire should be rejected");
        // reset_at 应为一个合理的远期时间(令牌不补充,永远等待)
        assert!(
            r2.reset_at > 0,
            "reset_at should be a valid timestamp, got: {}",
            r2.reset_at
        );
    }

    #[test]
    fn test_token_bucket_negative_refill_rate_does_not_panic() {
        // refill_rate=-1.0 是错误配置,应被当作 0.0 处理而非 panic
        let limiter = TokenBucketRateLimiter::new(1, -1.0);

        let r1 = limiter.acquire("neg-refill").unwrap();
        assert!(r1.allowed, "first acquire should be allowed");

        let r2 = limiter.acquire("neg-refill").unwrap();
        assert!(!r2.allowed, "second acquire should be rejected");
        assert!(
            r2.reset_at > 0,
            "reset_at should be a valid timestamp, got: {}",
            r2.reset_at
        );
    }
}