syster-base 0.4.0-alpha

Core library for SysML v2 and KerML parsing, AST, and semantic analysis
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
//! Typed metaclass views over [`Model`].
//!
//! Zero-copy borrowed views that provide metamodel-faithful navigation
//! over the interchange model graph. Each view type corresponds to a
//! SysML v2 / KerML metaclass and exposes its features as methods.
//!
//! ## Usage
//!
//! ```ignore
//! use syster::interchange::{Model, model_from_symbols};
//! use syster::interchange::views::ElementView;
//!
//! let view = ElementView::new(&element, &model);
//! for child in view.owned_members() {
//!     println!("{}: {:?}", child.name().unwrap_or("?"), child.kind());
//! }
//! ```

use super::model::{Element, ElementId, ElementKind, Model};

// ============================================================================
// CORE VIEW
// ============================================================================

/// A borrowed view over any model element with metamodel-faithful accessors.
///
/// This is the primary entry point for navigating the model graph.
/// All navigation methods return further views, keeping the API
/// uniform and avoiding raw ID lookups in user code.
#[derive(Clone, Copy)]
pub struct ElementView<'m> {
    pub element: &'m Element,
    pub model: &'m Model,
}

impl<'m> ElementView<'m> {
    /// Create a new view over an element.
    pub fn new(element: &'m Element, model: &'m Model) -> Self {
        Self { element, model }
    }

    /// Create a view from an element ID. Returns None if the ID is not in the model.
    pub fn from_id(id: &ElementId, model: &'m Model) -> Option<Self> {
        model.get(id).map(|element| Self { element, model })
    }

    // ── Identity ────────────────────────────────────────────────────

    /// The element's unique ID.
    pub fn id(&self) -> &'m ElementId {
        &self.element.id
    }

    /// The declared name (may be None for anonymous elements).
    pub fn name(&self) -> Option<&'m str> {
        self.element.name.as_deref()
    }

    /// The short name alias (e.g., `<R10>`).
    pub fn short_name(&self) -> Option<&'m str> {
        self.element.short_name.as_deref()
    }

    /// The fully qualified name.
    pub fn qualified_name(&self) -> Option<&'m str> {
        self.element.qualified_name.as_deref()
    }

    /// The metaclass kind.
    pub fn kind(&self) -> ElementKind {
        self.element.kind
    }

    // ── Ownership navigation ────────────────────────────────────────

    /// The logical owning element (None for root elements).
    ///
    /// Skips through `OwningMembership`/`FeatureMembership` wrappers to
    /// return the "real" parent.  For example, in a wrapped model where
    /// `Package → OwningMembership → PartDef`, calling `owner()` on
    /// `PartDef` returns the `Package`, not the membership.
    pub fn owner(&self) -> Option<ElementView<'m>> {
        let raw_owner_id = self.element.owner.as_ref()?;
        let raw_owner = Self::from_id(raw_owner_id, self.model)?;
        // If the raw owner is a membership, return its owner instead
        if raw_owner.element.kind.is_membership() {
            return raw_owner.owner();
        }
        Some(raw_owner)
    }

    /// The raw (structural) owning element, including membership wrappers.
    pub fn raw_owner(&self) -> Option<ElementView<'m>> {
        self.element
            .owner
            .as_ref()
            .and_then(|id| Self::from_id(id, self.model))
    }

    /// All directly owned members (non-relationship content elements).
    ///
    /// Looks through `OwningMembership`/`FeatureMembership` wrappers to
    /// return the actual content children.  Works with both wrapped
    /// (XMI-parsed / Phase 6) and unwrapped (legacy) models.
    pub fn owned_members(&self) -> Vec<ElementView<'m>> {
        self.model
            .owned_members(&self.element.id)
            .into_iter()
            .filter_map(|e| Self::from_id(&e.id, self.model))
            .collect()
    }

    /// All directly owned elements (including relationship elements).
    pub fn owned_elements(&self) -> Vec<ElementView<'m>> {
        self.element
            .owned_elements
            .iter()
            .filter_map(|id| Self::from_id(id, self.model))
            .collect()
    }

    /// Documentation text (from owned Documentation element or field).
    pub fn documentation(&self) -> Option<&'m str> {
        // First check the element's own documentation field
        if let Some(doc) = self.element.documentation.as_deref() {
            return Some(doc);
        }
        // Then look for an owned Documentation element
        self.owned_elements().into_iter().find_map(|child| {
            if child.kind() == ElementKind::Documentation {
                child.element.documentation.as_deref()
            } else {
                None
            }
        })
    }

    // ── Boolean properties ──────────────────────────────────────────

    pub fn is_abstract(&self) -> bool {
        self.element.is_abstract
    }

    pub fn is_variation(&self) -> bool {
        self.element.is_variation
    }

    pub fn is_derived(&self) -> bool {
        self.element.is_derived
    }

    pub fn is_readonly(&self) -> bool {
        self.element.is_readonly
    }

    pub fn is_end(&self) -> bool {
        self.element.is_end
    }

    pub fn is_ordered(&self) -> bool {
        self.element.is_ordered
    }

    pub fn is_nonunique(&self) -> bool {
        self.element.is_nonunique
    }

    pub fn is_portion(&self) -> bool {
        self.element.is_portion
    }

    pub fn is_individual(&self) -> bool {
        self.element.is_individual
    }

    // ── Relationships ───────────────────────────────────────────────

    /// All relationship elements where this element is the source.
    pub fn relationships_from(&self) -> Vec<&'m Element> {
        self.model.rel_elements_from(&self.element.id).collect()
    }

    /// All relationship elements where this element is the target.
    pub fn relationships_to(&self) -> Vec<&'m Element> {
        self.model.rel_elements_to(&self.element.id).collect()
    }

    /// Relationship elements of a specific kind from this element.
    pub fn relationships_of_kind(&self, kind: ElementKind) -> Vec<&'m Element> {
        self.model
            .rel_elements_of_kind(&self.element.id, kind)
            .collect()
    }

    // ── Element-based relationship navigation (Phase 3) ─────────────

    /// Relationship *elements* where this element is the source.
    pub fn rel_elements_from(&self) -> impl Iterator<Item = &'m Element> {
        self.model.rel_elements_from(&self.element.id)
    }

    /// Relationship elements of a specific `ElementKind` from this element.
    pub fn rel_elements_of_kind(&self, kind: ElementKind) -> impl Iterator<Item = &'m Element> {
        self.model.rel_elements_of_kind(&self.element.id, kind)
    }

    /// Resolve which views this element targets via a relationship kind.
    fn resolve_targets_by_kind(&self, kind: ElementKind) -> Vec<ElementView<'m>> {
        self.rel_elements_of_kind(kind)
            .filter_map(|re| re.target().and_then(|tid| Self::from_id(tid, self.model)))
            .collect()
    }

    // ── Typing (Feature → Type) ─────────────────────────────────────

    /// The type(s) this element is typed by (FeatureTyping relationships).
    /// For a usage like `part w: Wheel`, returns the view of `Wheel`.
    pub fn typing(&self) -> Vec<ElementView<'m>> {
        self.resolve_targets_by_kind(ElementKind::FeatureTyping)
    }

    /// Convenience: the first (and usually only) type.
    pub fn typed_by(&self) -> Option<ElementView<'m>> {
        self.typing().into_iter().next()
    }

    // ── Specialization ──────────────────────────────────────────────

    /// Types this element specializes (Specialization relationships).
    pub fn supertypes(&self) -> Vec<ElementView<'m>> {
        self.resolve_targets_by_kind(ElementKind::Specialization)
    }

    /// Types this element redefines (Redefinition relationships).
    pub fn redefined_features(&self) -> Vec<ElementView<'m>> {
        self.resolve_targets_by_kind(ElementKind::Redefinition)
    }

    /// Types this element subsets (Subsetting relationships).
    pub fn subsetted_features(&self) -> Vec<ElementView<'m>> {
        self.resolve_targets_by_kind(ElementKind::Subsetting)
    }

    // ── Downcast to typed views ─────────────────────────────────────

    /// Try to interpret this element as a package.
    pub fn as_package(&self) -> Option<PackageView<'m>> {
        match self.element.kind {
            ElementKind::Package | ElementKind::LibraryPackage => {
                Some(PackageView { inner: *self })
            }
            _ => None,
        }
    }

    /// Try to interpret this element as a definition (any kind).
    pub fn as_definition(&self) -> Option<DefinitionView<'m>> {
        if self.element.kind.is_definition() {
            Some(DefinitionView { inner: *self })
        } else {
            None
        }
    }

    /// Try to interpret this element as a usage (any kind).
    pub fn as_usage(&self) -> Option<UsageView<'m>> {
        if self.element.kind.is_usage() {
            Some(UsageView { inner: *self })
        } else {
            None
        }
    }

    /// Try to interpret this element as a connection usage.
    pub fn as_connection(&self) -> Option<ConnectionView<'m>> {
        match self.element.kind {
            ElementKind::ConnectionUsage
            | ElementKind::InterfaceUsage
            | ElementKind::FlowConnectionUsage => Some(ConnectionView {
                inner: UsageView { inner: *self },
            }),
            _ => None,
        }
    }

    /// Try to interpret this element as a requirement (def or usage).
    pub fn as_requirement(&self) -> Option<RequirementView<'m>> {
        match self.element.kind {
            ElementKind::RequirementDefinition | ElementKind::RequirementUsage => {
                Some(RequirementView { inner: *self })
            }
            _ => None,
        }
    }

    /// Try to interpret this element as a port (def or usage).
    pub fn as_port(&self) -> Option<PortView<'m>> {
        match self.element.kind {
            ElementKind::PortDefinition | ElementKind::PortUsage => Some(PortView { inner: *self }),
            _ => None,
        }
    }

    /// Try to interpret this element as a state (def or usage).
    pub fn as_state(&self) -> Option<StateView<'m>> {
        match self.element.kind {
            ElementKind::StateDefinition | ElementKind::StateUsage => {
                Some(StateView { inner: *self })
            }
            _ => None,
        }
    }

    /// Try to interpret this element as an action (def or usage).
    pub fn as_action(&self) -> Option<ActionView<'m>> {
        match self.element.kind {
            ElementKind::ActionDefinition | ElementKind::ActionUsage => {
                Some(ActionView { inner: *self })
            }
            _ => None,
        }
    }
}

impl<'m> std::fmt::Debug for ElementView<'m> {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("ElementView")
            .field("id", &self.element.id.as_str())
            .field("name", &self.name())
            .field("kind", &self.kind())
            .finish()
    }
}

// ============================================================================
// PACKAGE VIEW
// ============================================================================

/// View over a Package or LibraryPackage element.
#[derive(Clone, Copy, Debug)]
pub struct PackageView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> PackageView<'m> {
    /// Package name.
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    /// Whether this is a library package.
    pub fn is_library(&self) -> bool {
        self.inner.kind() == ElementKind::LibraryPackage
    }

    /// All owned members (definitions, usages, nested packages, etc.).
    pub fn owned_members(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Only the definitions owned by this package.
    pub fn definitions(&self) -> Vec<ElementView<'m>> {
        self.inner
            .owned_members()
            .into_iter()
            .filter(|v| v.kind().is_definition())
            .collect()
    }

    /// Only the usages owned by this package.
    pub fn usages(&self) -> Vec<ElementView<'m>> {
        self.inner
            .owned_members()
            .into_iter()
            .filter(|v| v.kind().is_usage())
            .collect()
    }

    /// Nested packages.
    pub fn packages(&self) -> Vec<PackageView<'m>> {
        self.inner
            .owned_members()
            .into_iter()
            .filter_map(|v| v.as_package())
            .collect()
    }

    /// Import relationships from this package.
    pub fn imports(&self) -> Vec<&'m Element> {
        self.inner
            .rel_elements_from()
            .filter(|e| {
                e.kind == ElementKind::NamespaceImport
                    || e.kind == ElementKind::Import
                    || e.kind == ElementKind::MembershipImport
            })
            .collect()
    }
}

// ============================================================================
// DEFINITION VIEW
// ============================================================================

/// View over any definition element (PartDefinition, ActionDefinition, etc.).
#[derive(Clone, Copy, Debug)]
pub struct DefinitionView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> DefinitionView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    pub fn kind(&self) -> ElementKind {
        self.inner.kind()
    }

    pub fn is_abstract(&self) -> bool {
        self.inner.is_abstract()
    }

    pub fn is_variation(&self) -> bool {
        self.inner.is_variation()
    }

    /// Features owned by this definition (its body members).
    pub fn owned_features(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Supertypes (definitions this one specializes).
    pub fn supertypes(&self) -> Vec<ElementView<'m>> {
        self.inner.supertypes()
    }

    /// Documentation text.
    pub fn documentation(&self) -> Option<&'m str> {
        self.inner.documentation()
    }
}

// ============================================================================
// USAGE VIEW
// ============================================================================

/// View over any usage element (PartUsage, AttributeUsage, etc.).
#[derive(Clone, Copy, Debug)]
pub struct UsageView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> UsageView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    pub fn kind(&self) -> ElementKind {
        self.inner.kind()
    }

    /// The definition this usage is typed by.
    /// E.g., for `part w: Wheel`, returns the view of `Wheel`.
    pub fn typed_by(&self) -> Option<ElementView<'m>> {
        self.inner.typed_by()
    }

    /// All types (for multi-typed usages).
    pub fn typing(&self) -> Vec<ElementView<'m>> {
        self.inner.typing()
    }

    /// Whether this is an end feature (connector endpoint).
    pub fn is_end(&self) -> bool {
        self.inner.is_end()
    }

    /// Whether this is derived.
    pub fn is_derived(&self) -> bool {
        self.inner.is_derived()
    }

    /// Whether this is readonly.
    pub fn is_readonly(&self) -> bool {
        self.inner.is_readonly()
    }

    /// Whether values are ordered.
    pub fn is_ordered(&self) -> bool {
        self.inner.is_ordered()
    }

    /// Whether values are nonunique.
    pub fn is_nonunique(&self) -> bool {
        self.inner.is_nonunique()
    }

    /// Whether this is a portion.
    pub fn is_portion(&self) -> bool {
        self.inner.is_portion()
    }

    /// Redefined features.
    pub fn redefines(&self) -> Vec<ElementView<'m>> {
        self.inner.redefined_features()
    }

    /// Subsetted features.
    pub fn subsets(&self) -> Vec<ElementView<'m>> {
        self.inner.subsetted_features()
    }

    /// Owned sub-features (attributes, ports nested inside this usage).
    pub fn owned_features(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Documentation text.
    pub fn documentation(&self) -> Option<&'m str> {
        self.inner.documentation()
    }
}

// ============================================================================
// CONNECTION VIEW
// ============================================================================

/// View over a connection usage (ConnectionUsage, InterfaceUsage, FlowConnectionUsage).
#[derive(Clone, Copy, Debug)]
pub struct ConnectionView<'m> {
    pub inner: UsageView<'m>,
}

impl<'m> ConnectionView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    /// The endpoint usages of this connection (end features).
    pub fn ends(&self) -> Vec<UsageView<'m>> {
        self.inner
            .inner
            .owned_members()
            .into_iter()
            .filter(|v| v.is_end())
            .filter_map(|v| v.as_usage())
            .collect()
    }

    /// The definition this connection is typed by.
    pub fn typed_by(&self) -> Option<ElementView<'m>> {
        self.inner.typed_by()
    }

    /// All owned features (including ends and body members).
    pub fn owned_features(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_features()
    }
}

// ============================================================================
// REQUIREMENT VIEW
// ============================================================================

/// View over a requirement (RequirementDefinition or RequirementUsage).
#[derive(Clone, Copy, Debug)]
pub struct RequirementView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> RequirementView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    pub fn short_name(&self) -> Option<&'m str> {
        self.inner.short_name()
    }

    /// The subject usage of this requirement (if any).
    /// Searches for a member with name "subject" or typed with the subject pattern.
    pub fn subject(&self) -> Option<ElementView<'m>> {
        // Look for a child element that acts as the subject
        // In the metamodel, subject is a usage with a specific redefinition.
        // In practice, we look for a member named via the `subject` keyword.
        self.inner.owned_members().into_iter().find(|v| {
            // Check name or qualified name ends with "subject"
            v.name()
                .map(|n| n == "subject" || n.ends_with("::subject"))
                .unwrap_or(false)
        })
    }

    /// The requirement text (from documentation).
    pub fn text(&self) -> Option<&'m str> {
        self.inner.documentation()
    }

    /// Owned constraint / requirement members.
    pub fn owned_members(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Whether this is a requirement definition (vs usage).
    pub fn is_definition(&self) -> bool {
        self.inner.kind() == ElementKind::RequirementDefinition
    }

    /// Supertypes / satisfied requirements.
    pub fn supertypes(&self) -> Vec<ElementView<'m>> {
        self.inner.supertypes()
    }
}

// ============================================================================
// PORT VIEW
// ============================================================================

/// View over a port (PortDefinition or PortUsage).
#[derive(Clone, Copy, Debug)]
pub struct PortView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> PortView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    /// The definition this port is typed by.
    pub fn typed_by(&self) -> Option<ElementView<'m>> {
        self.inner.typed_by()
    }

    /// Whether this is a port definition (vs usage).
    pub fn is_definition(&self) -> bool {
        self.inner.kind() == ElementKind::PortDefinition
    }

    /// Owned features (flow properties, attributes inside the port).
    pub fn owned_features(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }
}

// ============================================================================
// STATE VIEW
// ============================================================================

/// View over a state (StateDefinition or StateUsage).
#[derive(Clone, Copy, Debug)]
pub struct StateView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> StateView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    /// Whether this is a parallel state.
    pub fn is_parallel(&self) -> bool {
        self.inner.element.is_parallel
    }

    /// Whether this is a state definition (vs usage).
    pub fn is_definition(&self) -> bool {
        self.inner.kind() == ElementKind::StateDefinition
    }

    /// Owned sub-states and other members.
    pub fn owned_members(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Transitions from this state (Succession relationships).
    pub fn transitions(&self) -> Vec<&'m Element> {
        self.inner
            .rel_elements_of_kind(ElementKind::Succession)
            .collect()
    }
}

// ============================================================================
// ACTION VIEW
// ============================================================================

/// View over an action (ActionDefinition or ActionUsage).
#[derive(Clone, Copy, Debug)]
pub struct ActionView<'m> {
    pub inner: ElementView<'m>,
}

impl<'m> ActionView<'m> {
    pub fn name(&self) -> Option<&'m str> {
        self.inner.name()
    }

    /// Whether this is an action definition (vs usage).
    pub fn is_definition(&self) -> bool {
        self.inner.kind() == ElementKind::ActionDefinition
    }

    /// Owned sub-actions and other members.
    pub fn owned_members(&self) -> Vec<ElementView<'m>> {
        self.inner.owned_members()
    }

    /// Succession relationships (then/first chains).
    pub fn successions(&self) -> Vec<&'m Element> {
        self.inner
            .rel_elements_of_kind(ElementKind::Succession)
            .collect()
    }
}

// ============================================================================
// MODEL EXTENSION — Root views
// ============================================================================

impl Model {
    /// Get views over all root elements.
    pub fn root_views(&self) -> Vec<ElementView<'_>> {
        self.roots
            .iter()
            .filter_map(|id| ElementView::from_id(id, self))
            .collect()
    }

    /// Get a view of a specific element by ID.
    pub fn view(&self, id: &ElementId) -> Option<ElementView<'_>> {
        ElementView::from_id(id, self)
    }

    /// Find elements by name (searches all elements).
    pub fn find_by_name(&self, name: &str) -> Vec<ElementView<'_>> {
        self.elements
            .values()
            .filter(|e| e.name.as_deref() == Some(name))
            .map(|e| ElementView::new(e, self))
            .collect()
    }

    /// Find elements by kind.
    pub fn find_by_kind(&self, kind: ElementKind) -> Vec<ElementView<'_>> {
        self.elements
            .values()
            .filter(|e| e.kind == kind)
            .map(|e| ElementView::new(e, self))
            .collect()
    }

    /// Find an element by qualified name.
    pub fn find_by_qualified_name(&self, qn: &str) -> Option<ElementView<'_>> {
        self.elements
            .values()
            .find(|e| e.qualified_name.as_deref() == Some(qn))
            .map(|e| ElementView::new(e, self))
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// Helper: build a Model from SysML source text via the full pipeline.
    fn model_from_text(source: &str) -> Model {
        use crate::base::FileId;
        use crate::hir::{FileText, RootDatabase, file_symbols_from_text};
        use crate::interchange::model_from_symbols;

        let db = RootDatabase::new();
        let file_text = FileText::new(&db, FileId::new(0), source.to_string());
        let symbols = file_symbols_from_text(&db, file_text);
        model_from_symbols(&symbols)
    }

    #[test]
    fn view_package_owned_members() {
        let model = model_from_text("package X { part def A; part b: A; }");
        let roots = model.root_views();
        assert_eq!(roots.len(), 1);

        let pkg = roots[0].as_package().expect("root should be a package");
        assert_eq!(pkg.name(), Some("X"));

        let members = pkg.owned_members();
        assert!(members.len() >= 2, "should have at least A and b");

        let a = members.iter().find(|m| m.name() == Some("A"));
        assert!(a.is_some(), "should find definition A");
        assert_eq!(a.unwrap().kind(), ElementKind::PartDefinition);

        let b = members.iter().find(|m| m.name() == Some("b"));
        assert!(b.is_some(), "should find usage b");
        assert_eq!(b.unwrap().kind(), ElementKind::PartUsage);
    }

    #[test]
    fn view_usage_typing() {
        let model = model_from_text("package P { part def Wheel; part w: Wheel; }");

        let w_views = model.find_by_name("w");
        assert_eq!(w_views.len(), 1);

        let w = w_views[0].as_usage().expect("w should be a usage");
        let typed_by = w.typed_by();
        assert!(typed_by.is_some(), "w should be typed by Wheel");
        assert_eq!(typed_by.unwrap().name(), Some("Wheel"));
    }

    #[test]
    fn view_definition_supertypes() {
        let model = model_from_text("package P { part def Vehicle; part def Car :> Vehicle; }");

        let car_views = model.find_by_name("Car");
        assert_eq!(car_views.len(), 1);

        let car = car_views[0]
            .as_definition()
            .expect("Car should be a definition");
        let supers = car.supertypes();
        assert_eq!(supers.len(), 1);
        assert_eq!(supers[0].name(), Some("Vehicle"));
    }

    #[test]
    fn view_ownership_navigation() {
        let model = model_from_text("package Outer { part def Inner; }");

        let inner_views = model.find_by_name("Inner");
        assert_eq!(inner_views.len(), 1);

        let inner = &inner_views[0];
        let owner = inner.owner();
        assert!(owner.is_some(), "Inner should have an owner");
        assert_eq!(owner.unwrap().name(), Some("Outer"));

        // Bidirectional check
        let outer = owner.unwrap();
        let members = outer.owned_members();
        assert!(
            members.iter().any(|m| m.name() == Some("Inner")),
            "Outer should own Inner"
        );
    }

    #[test]
    fn view_package_definitions_and_usages() {
        let model =
            model_from_text("package P { part def A; part def B; part x: A; attribute y; }");

        let pkg = model.root_views()[0]
            .as_package()
            .expect("root should be a package");

        let defs = pkg.definitions();
        assert_eq!(defs.len(), 2, "should have 2 definitions (A, B)");

        let usages = pkg.usages();
        assert!(usages.len() >= 2, "should have at least x and y");
    }

    #[test]
    fn view_find_by_kind() {
        let model = model_from_text("package P { part def A; part def B; part x: A; }");

        let part_defs = model.find_by_kind(ElementKind::PartDefinition);
        assert_eq!(part_defs.len(), 2);

        let part_usages = model.find_by_kind(ElementKind::PartUsage);
        assert_eq!(part_usages.len(), 1);
        assert_eq!(part_usages[0].name(), Some("x"));
    }

    #[test]
    fn view_find_by_qualified_name() {
        let model = model_from_text("package Outer { part def Inner; }");

        let found = model.find_by_qualified_name("Outer::Inner");
        assert!(found.is_some(), "should find Outer::Inner");
        assert_eq!(found.unwrap().kind(), ElementKind::PartDefinition);

        let not_found = model.find_by_qualified_name("DoesNotExist");
        assert!(not_found.is_none());
    }

    #[test]
    fn view_connection_ends() {
        let model = model_from_text(
            r#"package P {
                part def A;
                part def B;
                part a: A;
                part b: B;
                connection c: A connect a to b;
            }"#,
        );

        let conn_views = model.find_by_name("c");
        // Connection may or may not parse into a ConnectionUsage depending on
        // how the parser outputs it. Check that find works at minimum.
        if !conn_views.is_empty() {
            if let Some(conn) = conn_views[0].as_connection() {
                let ends = conn.ends();
                // Ends are populated from is_end flags on owned features
                for end in &ends {
                    assert!(end.is_end(), "end features should have is_end set");
                }
            }
        }
    }

    #[test]
    fn view_requirement_subject() {
        let model = model_from_text(
            r#"package P {
                part def BrakeSubsystem;
                requirement def Safety {
                    subject brakes: BrakeSubsystem;
                    doc /* Braking shall be safe. */
                }
            }"#,
        );

        let req_views = model.find_by_name("Safety");
        if !req_views.is_empty() {
            if let Some(req) = req_views[0].as_requirement() {
                assert_eq!(req.name(), Some("Safety"));
                assert!(req.is_definition());
                // Subject may or may not be extracted depending on HIR
                // extraction depth. The view API is correct regardless.
            }
        }
    }

    #[test]
    fn view_downcast_returns_none_for_wrong_kind() {
        let model = model_from_text("package P { part def A; }");
        let a = model.find_by_name("A");
        assert_eq!(a.len(), 1);

        // A is a PartDefinition, not a Package
        assert!(a[0].as_package().is_none());
        // A is a Definition, not a Usage
        assert!(a[0].as_usage().is_none());
        // A is a Definition
        assert!(a[0].as_definition().is_some());
    }

    #[test]
    fn view_root_views_match_roots() {
        let model = model_from_text("package A; package B;");
        let roots = model.root_views();
        assert_eq!(roots.len(), model.roots.len());
    }
}