syster-base 0.1.12-alpha

Core library for SysML v2 and KerML parsing, AST, and semantic analysis
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
#![allow(clippy::unwrap_used)]
use crate::semantic::resolver::Resolver;

use crate::parser::{SysMLParser, sysml::Rule};
use crate::semantic::adapters::SysmlAdapter;
use crate::semantic::graphs::ReferenceIndex;
use crate::semantic::symbol_table::{Symbol, SymbolTable};
use crate::syntax::sysml::ast::parse_file;

use pest::Parser;

#[test]
fn test_visitor_creates_package_symbol() {
    let source = "package MyPackage;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    assert!(Resolver::new(&symbol_table).resolve("MyPackage").is_some());
}

#[test]
fn test_visitor_creates_definition_symbol() {
    let source = "part def Vehicle;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let symbol = resolver.resolve("Vehicle").unwrap();
    match symbol {
        Symbol::Definition { kind, .. } => assert_eq!(kind, "Part"),
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_qualified_redefinition_does_not_create_duplicate_symbols() {
    let source = r#"
        package TestPkg {
            item def Shell {
                item edges {
                    item vertices;
                }
            }
            
            item def Disc :> Shell {
                item :>> edges {
                    ref item :>> Shell::edges::vertices;
                }
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    // This should not produce duplicate symbol errors
    let result = adapter.populate(&file);
    assert!(
        result.is_ok(),
        "Should not have errors, got: {:?}",
        result.err()
    );

    // Shell should be defined exactly once
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let shell_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "Shell")
        .count();
    assert_eq!(
        shell_count, 1,
        "Shell should be defined exactly once, got {shell_count} definitions"
    );
}

#[test]
fn test_same_name_in_different_namespaces_creates_two_symbols() {
    let source = r#"
        package Namespace1 {
            item def Shell;
        }
        
        package Namespace2 {
            item def Shell;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);
    assert!(
        result.is_ok(),
        "Should not have errors, got: {:?}",
        result.err()
    );

    // Should have two Shell symbols, one in each namespace
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let shell_symbols: Vec<_> = all_symbols
        .iter()
        .filter(|sym| sym.name() == "Shell")
        .collect();

    assert_eq!(
        shell_symbols.len(),
        2,
        "Should have exactly 2 Shell definitions in different namespaces, got {}",
        shell_symbols.len()
    );

    // Verify they have different qualified names
    let qualified_names: Vec<String> = shell_symbols
        .iter()
        .filter_map(|symbol| match symbol {
            Symbol::Definition { qualified_name, .. } => Some(qualified_name.clone()),
            _ => None,
        })
        .collect();

    assert!(qualified_names.contains(&"Namespace1::Shell".to_string()));
    assert!(qualified_names.contains(&"Namespace2::Shell".to_string()));
}

#[test]
fn test_comma_separated_redefinitions_do_not_create_duplicate_symbols() {
    let source = r#"
        package TestPkg {
            item def Disc {
                attribute semiMajorAxis;
                attribute semiMinorAxis;
                item shape {
                    attribute semiMajorAxis;
                    attribute semiMinorAxis;
                }
            }
            
            item def Circle {
                attribute semiMajorAxis;
                attribute semiMinorAxis;
            }
            
            item def CircularDisc :> Disc {
                item :>> shape : Circle {
                    attribute :>> Disc::shape::semiMajorAxis, Circle::semiMajorAxis;
                    attribute :>> Disc::shape::semiMinorAxis, Circle::semiMinorAxis;
                }
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);
    assert!(
        result.is_ok(),
        "Should not have errors from comma-separated redefinitions, got: {:?}",
        result.err()
    );

    // Disc and Circle should each be defined exactly once
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let disc_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "Disc")
        .count();
    let circle_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "Circle")
        .count();

    assert_eq!(
        disc_count, 1,
        "Disc should be defined exactly once, got {disc_count} definitions"
    );
    assert_eq!(
        circle_count, 1,
        "Circle should be defined exactly once, got {circle_count} definitions"
    );
}

#[test]
fn test_attribute_reference_in_expression_not_treated_as_definition() {
    // Pattern: attribute :>> semiMajorAxis [1] = radius;
    // The "radius" in the expression should NOT create a symbol
    // But the anonymous redefinitions (attribute :>> radius) DO create symbols with the inherited name
    let source = r#"
        package TestPkg {
            attribute radius : Real;
            
            item def Circle {
                attribute :>> radius [1];
                attribute :>> semiMajorAxis [1] = radius;
                attribute :>> semiMinorAxis [1] = radius;
            }
            
            item def Sphere {
                attribute :>> radius [1];
                attribute :>> semiAxis1 [1] = radius;
                attribute :>> semiAxis2 [1] = radius;
                attribute :>> semiAxis3 [1] = radius;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);

    // Should succeed without duplicate symbol errors
    assert!(
        result.is_ok(),
        "Should not have duplicate symbol errors, got: {:?}",
        result.err()
    );

    // "radius" appears: once at package level, once in Circle, once in Sphere = 3 total
    // Each redefinition creates a symbol with the inherited name in its own scope
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let radius_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "radius")
        .count();

    assert_eq!(
        radius_count, 3,
        "radius should appear 3 times (package level + Circle + Sphere), got {radius_count}"
    );
}

#[test]
fn test_inline_attribute_definitions_with_same_name_create_duplicates() {
    // Pattern: item :>> shape : Circle { attribute :>> semiMajor, Circle::semiMajor; }
    // Multiple inline body definitions might be creating duplicates
    let source = r#"
        package TestPkg {
            item def Circle {
                attribute radius;
            }
            
            item def CircularDisc {
                item :>> shape : Circle {
                    attribute :>> radius;
                }
                item :>> edges : Circle {
                    attribute :>> radius;
                }
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);

    // Should succeed without duplicate symbol errors
    assert!(
        result.is_ok(),
        "Should not have duplicate symbol errors, got: {:?}",
        result.err()
    );
}

#[test]
fn test_radius_redefinition_in_multiple_items_no_duplicates() {
    // Test case from ShapeItems.sysml: multiple item definitions each redefine "radius"
    // Each creates a symbol with the inherited name in its own scope (no conflict)
    let source = r#"
        package ShapeItems {
            item def CircularDisc {
                attribute :>> radius [1];
            }
            
            item def Sphere {
                attribute :>> radius [1];
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);

    // Should succeed without duplicate symbol errors
    assert!(
        result.is_ok(),
        "Should not have duplicate symbol errors, got: {:?}",
        result.err()
    );

    // Each redefinition creates a symbol "radius" in its own scope
    // CircularDisc::radius and Sphere::radius are different symbols
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let radius_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "radius")
        .count();

    assert_eq!(
        radius_count, 2,
        "Should have 2 radius symbols (one in each item def), got {radius_count}"
    );
}

#[test]
fn test_simple_redefinition_creates_child_symbol() {
    // When you redefine: attribute :>> radius [1];
    // This creates Child::radius that redefines Parent::radius
    let source = r#"
        package TestPkg {
            item def Parent {
                attribute radius;
            }
            
            item def Child :> Parent {
                attribute :>> radius [1];
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);

    assert!(
        result.is_ok(),
        "Should not have errors, got: {:?}",
        result.err()
    );

    // Count radius symbols
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let radius_symbols: Vec<_> = all_symbols
        .iter()
        .filter(|sym| sym.name() == "radius")
        .collect();

    // Should have 2: Parent::radius and Child::radius
    assert_eq!(
        radius_symbols.len(),
        2,
        "Should have 2 radius symbols (Parent::radius and Child::radius), got {}",
        radius_symbols.len()
    );
}

#[test]
fn test_visitor_creates_usage_symbol() {
    let source = "part myCar : Vehicle;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let symbol = resolver.resolve("myCar").unwrap();
    match symbol {
        Symbol::Usage { usage_type, .. } => {
            assert_eq!(usage_type.as_deref(), Some("Vehicle"));
        }
        _ => panic!("Expected Usage symbol"),
    }
}

#[test]
fn test_visitor_records_specialization_relationship() {
    let source = "part def Car :> Vehicle;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    //let specializations = graph.get_sources("Car");
    //assert_eq!(specializations, &["Vehicle"]);
}

#[test]
fn test_visitor_records_typing_relationship() {
    let source = "part myCar : Vehicle;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();
}

#[test]
fn test_visitor_handles_nested_usage() {
    let source = r#"part def Car { attribute mass : Real; }"#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // Check that Car definition exists
    assert!(Resolver::new(&symbol_table).resolve("Car").is_some());

    // Check that mass exists and has the correct qualified name
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let mass_symbol = all_symbols
        .iter()
        .find(|sym| sym.name() == "mass")
        .expect("Should have 'mass' symbol");

    match mass_symbol {
        Symbol::Usage { qualified_name, .. } => {
            assert_eq!(qualified_name, "Car::mass");
        }
        _ => panic!("Expected Usage symbol for mass"),
    }
}

#[test]
fn test_debug_symbol_table_contents() {
    let source = r#"part def Car { attribute mass : Real; }"#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();
    for _symbol in symbol_table.iter_symbols().collect::<Vec<_>>() {}
}

#[test]
fn test_multiple_specializations() {
    let source = "part def ElectricCar :> Car, Electric, Vehicle;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();
}

#[test]
fn test_multiple_symbols_in_same_scope() {
    let source = r#"
        part def Car;
        part def Truck;
        part def Motorcycle;
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    assert!(Resolver::new(&symbol_table).resolve("Car").is_some());
    assert!(Resolver::new(&symbol_table).resolve("Truck").is_some());
    assert!(Resolver::new(&symbol_table).resolve("Motorcycle").is_some());
}

#[test]
fn test_deeply_nested_symbols() {
    let source = r#"
        part def Vehicle {
            part engine {
                attribute cylinders : Integer;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();
    // Check all three levels exist
    assert!(Resolver::new(&symbol_table).resolve("Vehicle").is_some());

    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let engine = all_symbols
        .iter()
        .find(|sym| sym.name() == "engine")
        .expect("Should have 'engine' symbol");

    match engine {
        Symbol::Usage { qualified_name, .. } => {
            assert_eq!(qualified_name, "Vehicle::engine");
        }
        _ => panic!("Expected Usage symbol for engine"),
    }

    let cylinders = all_symbols
        .iter()
        .find(|sym| sym.name() == "cylinders")
        .expect("Should have 'cylinders' symbol");

    match cylinders {
        Symbol::Usage { qualified_name, .. } => {
            assert_eq!(qualified_name, "Vehicle::engine::cylinders");
        }
        _ => panic!("Expected Usage symbol for cylinders"),
    }
}

#[test]
fn test_different_definition_kinds() {
    let source = r#"
        part def PartDef;
        action def ActionDef;
        requirement def ReqDef;
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let part_def = resolver.resolve("PartDef").unwrap();
    match part_def {
        Symbol::Definition { kind, .. } => assert_eq!(kind, "Part"),
        _ => panic!("Expected Definition symbol"),
    }

    let resolver = Resolver::new(&symbol_table);
    let action_def = resolver.resolve("ActionDef").unwrap();
    match action_def {
        Symbol::Definition { kind, .. } => assert_eq!(kind, "Action"),
        _ => panic!("Expected Definition symbol"),
    }

    let resolver = Resolver::new(&symbol_table);
    let req_def = resolver.resolve("ReqDef").unwrap();
    match req_def {
        Symbol::Definition { kind, .. } => assert_eq!(kind, "Requirement"),
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_scoped_symbols_with_same_name() {
    let source = r#"
        part def Car {
            attribute speed : Real;
        }
        part def Plane {
            attribute speed : Real;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // Both should exist with different qualified names
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let speed_symbols: Vec<_> = all_symbols
        .iter()
        .filter(|sym| sym.name() == "speed")
        .collect();

    // We should have exactly 2 symbols named "speed" (this might fail if scoping is wrong!)
    assert_eq!(
        speed_symbols.len(),
        2,
        "Should have 2 'speed' symbols in different scopes"
    );

    let qualified_names: Vec<String> = speed_symbols
        .iter()
        .map(|symbol| match symbol {
            Symbol::Usage { qualified_name, .. } => qualified_name.clone(),
            _ => panic!("Expected Usage symbol"),
        })
        .collect();

    assert!(qualified_names.contains(&"Car::speed".to_string()));
    assert!(qualified_names.contains(&"Plane::speed".to_string()));
}

#[test]
fn test_nested_packages() {
    let source = r#"
        package OuterPackage {
            package InnerPackage {
                part def Component;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    assert!(
        Resolver::new(&symbol_table)
            .resolve("OuterPackage")
            .is_some()
    );

    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let inner = all_symbols
        .iter()
        .find(|sym| sym.name() == "InnerPackage")
        .expect("Should have 'InnerPackage' symbol");

    match inner {
        Symbol::Package {
            documentation: None,
            qualified_name,
            ..
        } => {
            assert_eq!(qualified_name, "OuterPackage::InnerPackage");
        }
        _ => panic!("Expected Package symbol for InnerPackage"),
    }
}

#[test]
fn test_empty_definition() {
    let source = "part def EmptyPart { }";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let symbol = resolver.resolve("EmptyPart").unwrap();
    match symbol {
        Symbol::Definition { name, .. } => assert_eq!(name, "EmptyPart"),
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_usage_without_type() {
    let source = "part untyped;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let symbol = resolver.resolve("untyped").unwrap();
    match symbol {
        Symbol::Usage { usage_type, .. } => {
            assert_eq!(
                usage_type, &None,
                "Usage without type should have None as usage_type"
            );
        }
        _ => panic!("Expected Usage symbol"),
    }
}

#[test]
fn test_qualified_names_are_correct() {
    let source = r#"
        package Vehicles {
            part def Car {
                attribute mass : Real;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let vehicles = resolver.resolve("Vehicles").unwrap();
    match vehicles {
        Symbol::Package {
            documentation: None,
            qualified_name,
            ..
        } => {
            assert_eq!(qualified_name, "Vehicles");
        }
        _ => panic!("Expected Package symbol"),
    }

    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let car = all_symbols
        .iter()
        .find(|sym| sym.name() == "Car")
        .expect("Should have 'Car' symbol");

    match car {
        Symbol::Definition { qualified_name, .. } => {
            assert_eq!(qualified_name, "Vehicles::Car");
        }
        _ => panic!("Expected Definition symbol"),
    }

    let mass = all_symbols
        .iter()
        .find(|sym| sym.name() == "mass")
        .expect("Should have 'mass' symbol");

    match mass {
        Symbol::Usage { qualified_name, .. } => {
            assert_eq!(qualified_name, "Vehicles::Car::mass");
        }
        _ => panic!("Expected Usage symbol"),
    }
}

#[test]
fn test_multiple_usages_of_same_type() {
    let source = r#"
        part car1 : Vehicle;
        part car2 : Vehicle;
        part car3 : Vehicle;
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // All three should exist and have the same typing
    let resolver = Resolver::new(&symbol_table);
    for name in ["car1", "car2", "car3"] {
        let symbol = resolver
            .resolve(name)
            .unwrap_or_else(|| panic!("Should have '{name}' symbol"));
        match symbol {
            Symbol::Usage { usage_type, .. } => {
                assert_eq!(usage_type.as_deref(), Some("Vehicle"));
            }
            _ => panic!("Expected Usage symbol for {name}"),
        }
    }
}

#[test]
fn test_redefinition_relationship() {
    let source = "part def SportsCar :>> Car;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    assert!(Resolver::new(&symbol_table).resolve("SportsCar").is_some());
}

#[test]
fn test_alias_definition() {
    let source = "alias MyAlias for SomeType;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let symbol = symbol_table
        .iter_symbols()
        .collect::<Vec<_>>()
        .into_iter()
        .find(|sym| sym.name() == "MyAlias");
    assert!(symbol.is_some(), "Alias should be in symbol table");

    match symbol.unwrap() {
        Symbol::Alias { target, .. } => {
            assert_eq!(target, "SomeType");
        }
        _ => panic!("Expected Alias symbol"),
    }
}

#[test]
fn test_import_statement() {
    let source = "import Vehicles::*;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // Imports should be recorded in the symbol table's scope
    // This test checks that the adapter processes imports without crashing
}

/// Test that wildcard imports are indexed for hover support.
/// The import path (minus wildcard) should be added to the ReferenceIndex.
#[test]
fn test_import_indexed_for_hover() {
    let source = "package Camera { import PictureTaking::*; }";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    // CRITICAL: set_current_file must be called for references to be indexed
    symbol_table.set_current_file(Some("/test.sysml".to_string()));

    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // The import "PictureTaking::*" should be indexed as target "PictureTaking"
    let targets = graph.targets();
    println!("Indexed targets: {:?}", targets);

    assert!(
        targets.contains(&"PictureTaking"),
        "Import target 'PictureTaking' should be indexed for hover support. Found: {:?}",
        targets
    );

    // Verify the reference has a span
    let refs = graph.get_references("PictureTaking");
    assert!(
        !refs.is_empty(),
        "Should have at least one reference to PictureTaking"
    );

    let ref_info = &refs[0];
    println!(
        "Reference info: source={}, span={:?}",
        ref_info.source_qname, ref_info.span
    );
}

/// Test that imports with quoted names (containing spaces) are indexed correctly.
/// The quotes should be stripped so resolution works properly.
#[test]
fn test_import_quoted_name_indexed_for_hover() {
    let source = r#"package 'Robotic Vacuum Cleaner' { part def Robot; }
package Test { import 'Robotic Vacuum Cleaner'::*; }"#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    symbol_table.set_current_file(Some("/test.sysml".to_string()));

    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // The import "'Robotic Vacuum Cleaner'::*" should be indexed as target "Robotic Vacuum Cleaner"
    // (without the quotes)
    let targets = graph.targets();
    println!("Indexed targets: {:?}", targets);

    assert!(
        targets.contains(&"Robotic Vacuum Cleaner"),
        "Import target 'Robotic Vacuum Cleaner' should be indexed WITHOUT quotes. Found: {:?}",
        targets
    );

    // Should also have the package symbol
    let resolver = Resolver::new(&symbol_table);
    let pkg = resolver.resolve("Robotic Vacuum Cleaner");
    assert!(
        pkg.is_some(),
        "Package 'Robotic Vacuum Cleaner' should be resolvable"
    );
}

#[test]
fn test_port_definition_and_usage() {
    let source = r#"
        port def DataPort;
        part def Component {
            port input : DataPort;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let port_def = resolver.resolve("DataPort").unwrap();
    match port_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Port");
        }
        _ => panic!("Expected Definition symbol"),
    }

    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let input_port = all_symbols
        .iter()
        .find(|sym| sym.name() == "input")
        .expect("Should have 'input' port");

    match input_port {
        Symbol::Usage {
            kind,
            qualified_name,
            ..
        } => {
            assert_eq!(kind, "Port");
            assert_eq!(qualified_name, "Component::input");
        }
        _ => panic!("Expected Usage symbol for port"),
    }
}

#[test]
fn test_action_with_parameters() {
    let source = r#"
        action def ProcessData {
            in item data : String;
            out item result : Integer;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let action_def = resolver.resolve("ProcessData").unwrap();
    match action_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Action");
        }
        _ => panic!("Expected Definition symbol"),
    }

    // Check that parameters exist
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let has_data = all_symbols.iter().any(|sym| sym.name() == "data");
    let has_result = all_symbols.iter().any(|sym| sym.name() == "result");

    assert!(has_data, "Should have 'data' parameter");
    assert!(has_result, "Should have 'result' parameter");
}

#[test]
fn test_constraint_definition() {
    let source = r#"
        constraint def SpeedLimit {
            attribute maxSpeed : Real;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let constraint_def = resolver.resolve("SpeedLimit").unwrap();
    match constraint_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Constraint");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_enumeration_definition() {
    let source = r#"
        enum def Color {
            Red;
            Green;
            Blue;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let enum_def = resolver.resolve("Color").unwrap();
    match enum_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Enumeration");
        }
        _ => panic!("Expected Definition symbol"),
    }

    // Check for enum values
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let has_red = all_symbols.iter().any(|sym| sym.name() == "Red");
    let has_green = all_symbols.iter().any(|sym| sym.name() == "Green");
    let has_blue = all_symbols.iter().any(|sym| sym.name() == "Blue");

    assert!(has_red, "Should have enum value 'Red'");
    assert!(has_green, "Should have enum value 'Green'");
    assert!(has_blue, "Should have enum value 'Blue'");
}

#[test]
fn test_state_definition() {
    let source = r#"
        state def VehicleState {
            entry; then idle;
            state idle;
            state moving;
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let state_def = resolver.resolve("VehicleState").unwrap();
    match state_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "State");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_connection_definition() {
    let source = "connection def DataFlow;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let conn_def = resolver.resolve("DataFlow").unwrap();
    match conn_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Connection");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_interface_definition() {
    let source = "interface def NetworkInterface;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let intf_def = resolver.resolve("NetworkInterface").unwrap();
    match intf_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Interface");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_allocation_definition() {
    let source = "allocation def ResourceAllocation;";
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let alloc_def = resolver.resolve("ResourceAllocation").unwrap();
    match alloc_def {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Allocation");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_mixed_definitions_and_usages() {
    let source = r#"
        part def Engine;
        part def Wheel;
        part def Car {
            part engine : Engine;
            part wheel1 : Wheel;
            part wheel2 : Wheel;
        }
        part myCar : Car;
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // All definitions should exist
    assert!(Resolver::new(&symbol_table).resolve("Engine").is_some());
    assert!(Resolver::new(&symbol_table).resolve("Wheel").is_some());
    assert!(Resolver::new(&symbol_table).resolve("Car").is_some());
    assert!(Resolver::new(&symbol_table).resolve("myCar").is_some());

    // Check nested parts
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    assert!(all_symbols.iter().any(|sym| sym.name() == "engine"));
    assert!(all_symbols.iter().any(|sym| sym.name() == "wheel1"));
    assert!(all_symbols.iter().any(|sym| sym.name() == "wheel2"));
}

#[test]
fn test_concern_and_requirement() {
    let source = r#"
        concern def Safety;
        requirement def SafetyRequirement;
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);
    let concern = resolver.resolve("Safety").unwrap();
    match concern {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "UseCase"); // Concern maps to UseCase
        }
        _ => panic!("Expected Definition symbol"),
    }

    let resolver = Resolver::new(&symbol_table);
    let requirement = resolver.resolve("SafetyRequirement").unwrap();
    match requirement {
        Symbol::Definition { kind, .. } => {
            assert_eq!(kind, "Requirement");
        }
        _ => panic!("Expected Definition symbol"),
    }
}

#[test]
fn test_identifier_in_default_value_not_treated_as_definition() {
    // Reproduces the issue from Performances.kerml where "thisPerformance" in a default value
    // was incorrectly being treated as a feature definition
    let source = r#"
        package TestPkg {
            action def Performance {
                attribute redefines dispatchScope default thisPerformance;
                attribute thisPerformance: Performance [1] default self;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);

    let result = adapter.populate(&file);

    // Should not have duplicate symbol errors
    assert!(
        result.is_ok(),
        "Should not have duplicate symbol errors, got: {:?}",
        result.err()
    );

    // Should have exactly one "thisPerformance" symbol (the actual definition, not the reference)
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let this_perf_count = all_symbols
        .iter()
        .filter(|sym| sym.name() == "thisPerformance")
        .count();

    assert_eq!(
        this_perf_count, 1,
        "Should have exactly one 'thisPerformance' definition, got {this_perf_count}"
    );
}

#[test]
fn test_constraint_def_with_in_parameters_extracts_typing() {
    // Constraint definitions with `in` parameters should extract typing relationships
    let source = r#"
        constraint def MassConstraint {
            in totalMass : MassValue;
            in partMasses : MassValue[0..*];
            
            totalMass == sum(partMasses)
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // Check that the constraint definition was created
    let resolver = Resolver::new(&symbol_table);
    let constraint_def = resolver.resolve("MassConstraint");
    assert!(
        constraint_def.is_some(),
        "Should have MassConstraint definition"
    );

    // Check that parameters are created as usages
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let has_total_mass = all_symbols.iter().any(|sym| sym.name() == "totalMass");
    let has_part_masses = all_symbols.iter().any(|sym| sym.name() == "partMasses");

    assert!(has_total_mass, "Should have 'totalMass' parameter");
    assert!(has_part_masses, "Should have 'partMasses' parameter");
}

#[test]
fn test_assert_constraint_usage_with_in_parameters() {
    // Assert constraint usages with `in` parameter bindings should extract parameters
    let source = r#"
        part def Vehicle5 {
            assert constraint ml : MassLimit {
                in mass = m;
                in maxMass = 2500;
            }
        }
    "#;
    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    // Check that the part definition was created
    let resolver = Resolver::new(&symbol_table);
    assert!(
        resolver.resolve("Vehicle5").is_some(),
        "Should have Vehicle5 definition"
    );

    // Check that the constraint usage 'ml' was created
    assert!(
        resolver.resolve("Vehicle5::ml").is_some(),
        "Should have ml constraint usage"
    );

    // Check that parameters are created as usages inside the constraint usage
    let all_symbols = symbol_table.iter_symbols().collect::<Vec<_>>();
    let has_mass = all_symbols.iter().any(|sym| sym.name() == "mass");
    let has_max_mass = all_symbols.iter().any(|sym| sym.name() == "maxMass");

    assert!(has_mass, "Should have 'mass' parameter");
    assert!(has_max_mass, "Should have 'maxMass' parameter");
}

#[test]
fn test_feature_chain_source_parses_correctly() {
    let source = r#"package Camera {
    action def TakePicture {
        in item focus;
        out item photo;
    }

    part def FocusingSubsystem {
        perform action takePicture : TakePicture {
            in item :>> focus;
        }

        perform action :> takePicture.focus;
    }
}"#;

    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);

    // Debug: print all symbols
    println!("=== All Symbols ===");
    for sym in symbol_table.iter_symbols() {
        println!("  {} (span: {:?})", sym.qualified_name(), sym.span());
    }

    // Verify package is created
    assert!(
        resolver.resolve("Camera").is_some(),
        "Should have Camera package"
    );

    // Verify action def is created
    assert!(
        resolver.resolve("Camera::TakePicture").is_some(),
        "Should have TakePicture action def"
    );

    // Verify part def is created
    assert!(
        resolver.resolve("Camera::FocusingSubsystem").is_some(),
        "Should have FocusingSubsystem part def"
    );

    // Verify focus and photo items are created
    assert!(
        resolver.resolve("Camera::TakePicture::focus").is_some(),
        "Should have focus item"
    );
    assert!(
        resolver.resolve("Camera::TakePicture::photo").is_some(),
        "Should have photo item"
    );

    // Verify takePicture perform usage is created
    assert!(
        resolver
            .resolve("Camera::FocusingSubsystem::takePicture")
            .is_some(),
        "Should have takePicture perform"
    );
}

#[test]
fn test_resolve_member_through_subsets() {
    // Test that resolve_member properly follows subsets relationships
    // to find nested members
    //
    // Structure:
    // - PictureTaking package with takePicture action containing focus/shoot
    // - Camera::takePicture subsets PictureTaking::takePicture
    // - resolve_member("focus", Camera::takePicture) should find PictureTaking::takePicture::focus
    let source = r#"package PictureTaking {
    action def TakePicture {
        action focus;
        action shoot;
    }
    action takePicture : TakePicture;
}

part def Camera {
    perform action takePicture :> PictureTaking::takePicture;
}"#;

    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    let mut symbol_table = SymbolTable::new();
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);

    // Debug: print all symbols
    println!("=== All Symbols ===");
    for sym in symbol_table.iter_symbols() {
        if let Symbol::Usage {
            usage_type,
            subsets,
            ..
        } = sym
        {
            println!(
                "  {} (USAGE - type: {:?}, subsets: {:?})",
                sym.qualified_name(),
                usage_type,
                subsets
            );
        } else {
            println!("  {} (subsets: {:?})", sym.qualified_name(), sym.subsets());
        }
    }

    // Verify the symbols exist
    let camera_takepicture = resolver
        .resolve("Camera::takePicture")
        .expect("Should have Camera::takePicture");
    println!(
        "\nCamera::takePicture subsets: {:?}",
        camera_takepicture.subsets()
    );

    let pt_takepicture = resolver
        .resolve("PictureTaking::takePicture")
        .expect("Should have PictureTaking::takePicture");
    println!(
        "PictureTaking::takePicture: {:?}",
        pt_takepicture.qualified_name()
    );

    let focus_symbol = resolver
        .resolve("PictureTaking::TakePicture::focus")
        .expect("Should have focus in TakePicture action def");
    println!(
        "PictureTaking::TakePicture::focus: {}",
        focus_symbol.qualified_name()
    );

    // Now test resolve_member - this is what the hover uses
    let camera_scope_id = resolver
        .resolve("Camera")
        .expect("Should have Camera")
        .scope_id();

    println!("\n=== Testing resolve_member ===");
    println!(
        "Looking for 'focus' as member of {}",
        camera_takepicture.qualified_name()
    );

    let result = resolver.resolve_member("focus", camera_takepicture, camera_scope_id);

    assert!(
        result.is_some(),
        "resolve_member should find 'focus' through subsets relationship"
    );
    let resolved = result.unwrap();
    println!("Found: {}", resolved.qualified_name());
    assert!(
        resolved.qualified_name().contains("focus"),
        "Resolved symbol should be 'focus'"
    );
}

#[test]
fn test_feature_chain_redefine_indexes_correctly() {
    // Test that feature chain redefinitions like `:>> localClock.currentTime`
    // are properly indexed with chain_context for hover resolution
    let source = r#"package TimeTest {
    part def Clock {
        attribute currentTime;
    }
    
    part def Transport {
        part localClock : Clock;
        attribute :>> localClock.currentTime = 0;
    }
}"#;

    let mut pairs = SysMLParser::parse(Rule::file, source).unwrap();
    let file = parse_file(&mut pairs).unwrap();

    // Debug: print the parsed AST structure
    println!("=== Parsed AST ===");
    for elem in &file.elements {
        match elem {
            crate::syntax::sysml::ast::Element::Package(pkg) => {
                println!("  Package: {:?}", pkg.name);
                for inner_elem in &pkg.elements {
                    if let crate::syntax::sysml::ast::Element::Definition(def) = inner_elem {
                        println!("    Definition: {:?} (kind: {:?})", def.name, def.kind);
                        for body_member in &def.body {
                            match body_member {
                                crate::syntax::sysml::ast::enums::DefinitionMember::Usage(u) => {
                                    println!(
                                        "      Usage: {} (kind: {:?})",
                                        u.name.as_deref().unwrap_or("<anonymous>"),
                                        u.kind
                                    );
                                    println!("        redefines: {:?}", u.relationships.redefines);
                                    println!("        subsets: {:?}", u.relationships.subsets);
                                }
                                crate::syntax::sysml::ast::enums::DefinitionMember::Comment(_c) => {
                                    println!("      Comment");
                                }
                                crate::syntax::sysml::ast::enums::DefinitionMember::Import(i) => {
                                    println!("      Import: {}", i.path);
                                }
                            }
                        }
                    }
                }
            }
            crate::syntax::sysml::ast::Element::Definition(def) => {
                println!("  Definition: {:?} (kind: {:?})", def.name, def.kind);
            }
            _ => {
                println!("  Other element");
            }
        }
    }

    let mut symbol_table = SymbolTable::new();
    // CRITICAL: set_current_file must be called for references to be indexed
    symbol_table.set_current_file(Some("/test.sysml".to_string()));
    let mut graph = ReferenceIndex::new();
    let mut adapter = SysmlAdapter::with_index(&mut symbol_table, &mut graph);
    adapter.populate(&file).unwrap();

    let resolver = Resolver::new(&symbol_table);

    // Debug: print all symbols
    println!("=== All Symbols ===");
    for sym in symbol_table.iter_symbols() {
        println!("  {}", sym.qualified_name());
    }

    // Debug: print all reference targets
    println!("\n=== Reference Targets ===");
    for target in graph.targets() {
        println!("  {}", target);
    }

    // Verify basic symbols exist
    assert!(
        resolver.resolve("TimeTest::Clock").is_some(),
        "Should have Clock"
    );
    assert!(
        resolver.resolve("TimeTest::Clock::currentTime").is_some(),
        "Should have Clock::currentTime"
    );
    assert!(
        resolver.resolve("TimeTest::Transport").is_some(),
        "Should have Transport"
    );
    assert!(
        resolver
            .resolve("TimeTest::Transport::localClock")
            .is_some(),
        "Should have localClock"
    );

    // Check that the feature chain reference was indexed
    // The reference to `localClock` should be indexed
    let localclock_refs = graph.get_references("localClock");
    println!("\n=== References to 'localClock' ===");
    for r in &localclock_refs {
        println!(
            "  source={}, chain_context={:?}",
            r.source_qname, r.chain_context
        );
    }

    // The reference to `currentTime` should be indexed with chain_context
    let currenttime_refs = graph.get_references("currentTime");
    println!("\n=== References to 'currentTime' ===");
    for r in &currenttime_refs {
        println!(
            "  source={}, chain_context={:?}",
            r.source_qname, r.chain_context
        );
    }

    // At least one reference should have chain_context set
    let has_chain_ref = currenttime_refs.iter().any(|r| r.chain_context.is_some());
    assert!(
        has_chain_ref,
        "currentTime reference should have chain_context for feature chain resolution"
    );
}