systemprompt-mcp 0.8.0

use std::collections::HashSet;
use systemprompt_models::mcp::{McpServerType, RegistryConfig};

use crate::error::McpDomainResult;

pub fn validate_registry(config: &RegistryConfig) -> McpDomainResult<()> {
    tracing::info!("Validating registry configuration");

    validate_port_conflicts(config)
        .map_err(|e| crate::error::McpDomainError::RegistryValidation(e.to_string()))?;
    validate_server_configs(config)
        .map_err(|e| crate::error::McpDomainError::RegistryValidation(e.to_string()))?;
    validate_oauth_configs(config)
        .map_err(|e| crate::error::McpDomainError::RegistryValidation(e.to_string()))?;
    validate_server_types(config)
        .map_err(|e| crate::error::McpDomainError::RegistryValidation(e.to_string()))?;

    tracing::info!("Registry validation passed");
    Ok(())
}

fn validate_port_conflicts(config: &RegistryConfig) -> McpDomainResult<()> {
    let mut seen_ports = HashSet::new();

    let conflicts: Vec<_> = config
        .servers
        .iter()
        .filter(|s| s.enabled && s.is_internal())
        .filter(|s| !seen_ports.insert(s.port))
        .map(|s| format!("{}:{}", s.name, s.port))
        .collect();

    if conflicts.is_empty() {
        tracing::debug!(
            enabled_servers = seen_ports.len(),
            "No port conflicts found"
        );
        return Ok(());
    }

    Err(crate::error::McpDomainError::Internal(format!(
        "Port conflicts detected: {}",
        conflicts.join(", ")
    )))
}

fn validate_server_configs(config: &RegistryConfig) -> McpDomainResult<()> {
    let invalid_servers: Vec<String> = config
        .servers
        .iter()
        .filter(|s| s.enabled)
        .flat_map(validate_single_server)
        .collect();

    if invalid_servers.is_empty() {
        tracing::debug!("All server configurations valid");
        return Ok(());
    }

    Err(crate::error::McpDomainError::Internal(format!(
        "Invalid server configurations:\n{}",
        invalid_servers.join("\n")
    )))
}

fn validate_single_server(
    server_config: &systemprompt_models::mcp::McpServerConfig,
) -> Vec<String> {
    let mut errors = Vec::new();
    let name = &server_config.name;

    match server_config.server_type {
        McpServerType::Internal => {
            if server_config.port < 1024 {
                errors.push(format!("{name}: invalid port {}", server_config.port));
                return errors;
            }

            if !server_config.crate_path.exists() {
                errors.push(format!(
                    "{name}: crate path does not exist: {}",
                    server_config.crate_path.display()
                ));
                return errors;
            }
        },
        McpServerType::External => {},
    }

    if server_config.display_name.is_empty() {
        errors.push(format!("{name}: missing display_name"));
    }

    if server_config.description.is_empty() {
        errors.push(format!("{name}: missing description"));
    }

    errors
}

fn validate_oauth_configs(config: &RegistryConfig) -> McpDomainResult<()> {
    let oauth_issues: Vec<_> = config
        .servers
        .iter()
        .filter(|s| s.enabled && s.oauth.required && s.oauth.scopes.is_empty())
        .map(|s| format!("{}: OAuth enabled but no scopes defined", s.name))
        .collect();

    if oauth_issues.is_empty() {
        tracing::debug!("OAuth configurations valid");
        return Ok(());
    }

    Err(crate::error::McpDomainError::Internal(format!(
        "OAuth configuration issues:\n{}",
        oauth_issues.join("\n")
    )))
}

fn validate_server_types(config: &RegistryConfig) -> McpDomainResult<()> {
    let issues: Vec<String> = config
        .servers
        .iter()
        .filter(|s| s.enabled)
        .filter_map(validate_server_type_constraints)
        .collect();

    if issues.is_empty() {
        return Ok(());
    }

    Err(crate::error::McpDomainError::Internal(format!(
        "Server type validation issues:\n{}",
        issues.join("\n")
    )))
}

fn validate_server_type_constraints(
    server: &systemprompt_models::mcp::McpServerConfig,
) -> Option<String> {
    match server.server_type {
        McpServerType::Internal => {
            if server.binary.is_empty() {
                return Some(format!("{}: internal server has no binary", server.name));
            }
            None
        },
        McpServerType::External => {
            if server.remote_endpoint.is_empty() {
                return Some(format!(
                    "{}: external server has no remote endpoint",
                    server.name
                ));
            }
            if !server.binary.is_empty() {
                return Some(format!(
                    "{}: external server should not have a binary",
                    server.name
                ));
            }
            None
        },
    }
}