Skip to main content

synth_backend/
arm_backend.rs

1//! ARM Backend — wraps the instruction selector + optimizer + encoder as a Backend
2//!
3//! This is Synth's custom ARM compiler targeting Cortex-M (Thumb-2).
4//! It's the only backend that supports per-rule formal verification (ASIL D path).
5
6use crate::ArmEncoder;
7use synth_core::backend::{
8    Backend, BackendCapabilities, BackendError, CodeRelocation, CompilationResult, CompileConfig,
9    CompiledFunction, LineMap, SafetyBounds,
10};
11use synth_core::target::{IsaVariant, TargetSpec};
12use synth_core::wasm_decoder::DecodedModule;
13use synth_core::wasm_op::WasmOp;
14use synth_synthesis::{
15    ArmInstruction, ArmOp, BoundsCheckConfig, InstructionSelector, OptimizationConfig,
16    OptimizerBridge, RuleDatabase, validate_instructions,
17};
18
19/// ARM Cortex-M backend using Synth's custom compiler pipeline
20pub struct ArmBackend;
21
22impl ArmBackend {
23    pub fn new() -> Self {
24        Self
25    }
26}
27
28impl Default for ArmBackend {
29    fn default() -> Self {
30        Self::new()
31    }
32}
33
34impl Backend for ArmBackend {
35    fn name(&self) -> &str {
36        "arm"
37    }
38
39    fn capabilities(&self) -> BackendCapabilities {
40        BackendCapabilities {
41            produces_elf: false,
42            supports_rule_verification: true,
43            supports_binary_verification: true,
44            is_external: false,
45        }
46    }
47
48    fn supported_targets(&self) -> Vec<TargetSpec> {
49        vec![
50            TargetSpec::cortex_m3(),
51            TargetSpec::cortex_m4(),
52            TargetSpec::cortex_m4f(),
53            TargetSpec::cortex_m7(),
54            TargetSpec::cortex_m7dp(),
55        ]
56    }
57
58    fn compile_module(
59        &self,
60        module: &DecodedModule,
61        config: &CompileConfig,
62    ) -> Result<CompilationResult, BackendError> {
63        let exports: Vec<_> = module
64            .functions
65            .iter()
66            .filter(|f| f.export_name.is_some())
67            .collect();
68
69        if exports.is_empty() {
70            return Err(BackendError::CompilationFailed(
71                "no exported functions found".into(),
72            ));
73        }
74
75        let mut functions = Vec::new();
76        for func in &exports {
77            let name = func.export_name.clone().unwrap();
78            // #359: copy THIS function's declared param widths into the config so
79            // `compile_function` (which carries no function index) can refuse a
80            // 64-bit param on the AAPCS stack-argument path. Cheap clone only when
81            // a signature table is present and this function has a width entry —
82            // otherwise reuse the shared config (every existing module unchanged).
83            // #509: same per-function pattern for the blocktype-arity side-table
84            // (value-carrying-branch lowering).
85            let params = config
86                .func_params_i64
87                .get(func.index as usize)
88                .filter(|p| !p.is_empty());
89            // #457: THIS function's DECLARED param count (imports-first full
90            // index), so the backend can cap the access-pattern inference that
91            // mistook a read-before-write local for a param. `None` when the
92            // driver supplied no arg-count table (hand-built modules).
93            let declared_params = config.func_arg_counts.get(func.index as usize).copied();
94            // GI-FPU-002 (#619/#369): THIS function's declared f32-param mask.
95            let params_f32 = config
96                .func_params_f32
97                .get(func.index as usize)
98                .filter(|p| !p.is_empty());
99            // GI-FPU-002 phase 2 (#369): THIS function's declared f64-param
100            // mask (hard-float targets decline f64 params loudly).
101            let params_f64 = config
102                .func_params_f64
103                .get(func.index as usize)
104                .filter(|p| !p.is_empty());
105            // GI-FPU-002 phase 2 (#719/#369): THIS function's declared f32/f64
106            // return flag, so the epilogue soundness guard fires on every driver
107            // path (not only the CLI loops).
108            let ret_f32 = config
109                .func_ret_f32
110                .get(func.index as usize)
111                .copied()
112                .unwrap_or(false);
113            let ret_f64 = config
114                .func_ret_f64
115                .get(func.index as usize)
116                .copied()
117                .unwrap_or(false);
118            let func_config = if params.is_some()
119                || params_f32.is_some()
120                || params_f64.is_some()
121                || !func.block_arity.is_empty()
122                || declared_params.is_some()
123                || ret_f32
124                || ret_f64
125            {
126                Some(CompileConfig {
127                    current_func_params_i64: params.cloned().unwrap_or_default(),
128                    current_func_params_f32: params_f32.cloned().unwrap_or_default(),
129                    current_func_params_f64: params_f64.cloned().unwrap_or_default(),
130                    current_func_ret_f32: ret_f32,
131                    current_func_ret_f64: ret_f64,
132                    current_func_block_arity: func.block_arity.clone(),
133                    current_func_param_count: declared_params,
134                    ..config.clone()
135                })
136            } else {
137                None
138            };
139            let cfg = func_config.as_ref().unwrap_or(config);
140            let compiled = self.compile_function(&name, &func.ops, cfg)?;
141            functions.push(compiled);
142        }
143
144        Ok(CompilationResult {
145            functions,
146            elf: None,
147            backend_name: self.name().to_string(),
148        })
149    }
150
151    fn compile_function(
152        &self,
153        name: &str,
154        ops: &[WasmOp],
155        config: &CompileConfig,
156    ) -> Result<CompiledFunction, BackendError> {
157        let (code, relocations, line_map, branch_map, final_instrs) =
158            compile_wasm_to_arm(ops, config).map_err(BackendError::CompilationFailed)?;
159
160        // #778: derive the SOUND static WCET intermediate from the final Thumb-2
161        // stream. Only present for the Thumb-2 path; the core class (from the
162        // triple) decides whether the bound is sound (M3/M4) or declined (M7).
163        // Phase 2: any --wcet-hints entry for THIS function is verified (never
164        // trusted) by the loop analyzer. Phase 3: the intermediate carries the
165        // own-body cycles + direct call sites; the module driver composes it across
166        // the call graph. `wcet` here is the SINGLE-FUNCTION view (unresolved direct
167        // calls decline `call`) — a valid standalone answer, overwritten by the
168        // composed result when the driver runs the second pass.
169        let wcet_intermediate = final_instrs.as_ref().map(|instrs| {
170            let hints = config
171                .wcet_hints
172                .as_ref()
173                .and_then(|h| h.functions.get(name));
174            let self_label = config.current_func_index.map(|i| format!("func_{i}"));
175            crate::wcet::function_wcet_intermediate(
176                name,
177                instrs,
178                &config.target.triple,
179                hints,
180                self_label.as_deref(),
181            )
182        });
183        // The SINGLE-FUNCTION standalone view (unresolved direct calls decline
184        // `call`). Kept as a per-function fallback for any consumer that reads a
185        // lone `CompiledFunction` without running the module composer; the CLI
186        // `--emit-wcet` path IGNORES this and composes `wcet_intermediate` across
187        // the whole call graph instead (its result overwrites the report).
188        let wcet = final_instrs.map(|instrs| {
189            let hints = config
190                .wcet_hints
191                .as_ref()
192                .and_then(|h| h.functions.get(name));
193            crate::wcet::function_wcet_with_hints(name, &instrs, &config.target.triple, hints)
194        });
195
196        Ok(CompiledFunction {
197            name: name.to_string(),
198            code,
199            wasm_ops: ops.to_vec(),
200            relocations,
201            line_map,
202            branch_map,
203            wcet,
204            wcet_intermediate,
205        })
206    }
207
208    fn is_available(&self) -> bool {
209        true // Always available — it's a library backend
210    }
211}
212
213/// Count the number of function parameters by analyzing LocalGet patterns
214/// RQ-58-MIRRORS (#242): was a private copy of the read-before-write param
215/// heuristic, byte-equivalent to the other two backends'. Now the ONE shared
216/// definition in `synth-core`, so a correction reaches every backend.
217fn count_params(wasm_ops: &[WasmOp]) -> u32 {
218    synth_core::count_params_heuristic(wasm_ops)
219}
220
221/// #457/#970: the parameter count the selector is given.
222///
223/// With a DECLARED count from the driver the bound is
224/// `min(`[`synth_core::referenced_locals`]`(ops), declared)` — the highest
225/// local index the body touches, clamped by the signature. That is exact in
226/// both directions: the clamp stops a read-before-write NON-PARAM local (which
227/// WASM zero-initializes) from being homed in an argument register and reading
228/// caller garbage (#457), and taking the max over ALL accesses — writes as well
229/// as reads — stops a PARAM from being demoted to a local.
230///
231/// The previous rule capped [`count_params`] (a READ-FIRST heuristic) with the
232/// declared count, which got the second direction wrong: a param written on ONE
233/// arm of an `if` is "written first" in linear op order, so it was demoted, and
234/// because the demoted local's first access is a WRITE the #457 zero-init
235/// skipped it too. The arm that does NOT write it then read an UNINITIALISED
236/// frame slot — measured under unicorn with the sub-SP stack poisoned,
237/// `cond_write_param(0, 42)` returned the poison word, i.e. previous-frame
238/// bytes rather than 42 (#970; the aarch64 instance was #851).
239///
240/// `min` rather than a plain `declared` override preserves the leniency for a
241/// body that only touches the first few of many declared params.
242///
243/// `None` (no declared signature: hand-built op streams, direct
244/// `compile_function` callers) keeps the legacy pure inference — see the
245/// residual documented on [`CompileConfig::current_func_param_count`].
246fn effective_num_params(wasm_ops: &[WasmOp], config: &CompileConfig) -> u32 {
247    match config.current_func_param_count {
248        Some(declared) => synth_core::referenced_locals(wasm_ops).min(declared),
249        None => count_params(wasm_ops),
250    }
251}
252
253/// #539: fold the `i32.const 0; memory.grow m` idiom to `memory.size m`.
254/// Moved to `synth_core::rewrite_memory_grow_zero` (#242, VCR-SEL-005) so the
255/// ARM and RISC-V backends share ONE implementation and cannot drift; re-export
256/// here keeps the existing `rewrite_memory_grow_zero(...)` call sites working.
257use synth_core::rewrite_memory_grow_zero;
258
259/// #509: does the op stream contain a `br`/`br_if`/`br_table` that CARRIES a
260/// value — i.e. one targeting a result-typed block/if (forward edge with
261/// results > 0) or a parameterized loop header (backward edge with loop
262/// params > 0)?
263///
264/// The optimized path's wasm→IR lowering drops the carried value on such
265/// edges (the taken arm returns the fall-through result — same class as the
266/// #507 `br_table` drop, observed on `pick_br`/`pick_br_fall`), so — like
267/// #507 — the shape is detected on the raw op stream and routed to the direct
268/// selector, whose #509 designated-result-register lowering lands the value
269/// correctly. `block_arity` is the decoder's ordinal blocktype-arity
270/// side-table; when it is empty (hand-built op streams) every block reads as
271/// void and this never fires, keeping the optimized path byte-identical for
272/// every existing caller. Frozen-safe for the same reason as #507: the frozen
273/// fixtures compile `--relocatable` (already direct), and no optimized-path
274/// fixture branches to a result-typed block.
275fn has_value_carrying_branch(wasm_ops: &[WasmOp], block_arity: &[(u8, u8)]) -> bool {
276    // Open control constructs: (is_loop, params, results), innermost last.
277    let mut open: Vec<(bool, u8, u8)> = Vec::new();
278    let mut ctrl_ord = 0usize;
279    // A branch edge carries a value when its target is a result-typed forward
280    // join (block/if) or a parameterized loop header.
281    let carries = |open: &[(bool, u8, u8)], depth: u32| -> bool {
282        let Some(&(is_loop, params, results)) = open
283            .len()
284            .checked_sub(1 + depth as usize)
285            .and_then(|i| open.get(i))
286        else {
287            return false; // function-level target — handled by Return lowering
288        };
289        if is_loop { params > 0 } else { results > 0 }
290    };
291    for op in wasm_ops {
292        match op {
293            WasmOp::Block | WasmOp::If => {
294                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
295                ctrl_ord += 1;
296                open.push((false, p, r));
297            }
298            WasmOp::Loop => {
299                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
300                ctrl_ord += 1;
301                open.push((true, p, r));
302            }
303            WasmOp::End => {
304                open.pop(); // None only at the function-level end — harmless
305            }
306            WasmOp::Br(d) | WasmOp::BrIf(d) if carries(&open, *d) => return true,
307            WasmOp::BrTable { targets, default }
308                if targets
309                    .iter()
310                    .chain(std::iter::once(default))
311                    .any(|d| carries(&open, *d)) =>
312            {
313                return true;
314            }
315            _ => {}
316        }
317    }
318    false
319}
320
321/// Core compilation: WASM ops → ARM machine code bytes + relocations
322///
323/// Returns (code_bytes, relocations) where relocations record BL instructions
324/// that target external symbols (e.g., `__meld_dispatch_import` for import calls).
325type CompileArmOutput = (
326    Vec<u8>,
327    Vec<CodeRelocation>,
328    LineMap,
329    synth_core::backend::BranchMap,
330    // #778: the SOUND static WCET result over the final Thumb-2 stream, computed
331    // by `compile_function` (which knows the function name); `None` for the A32
332    // path. Purely additive metadata — does not touch `code`.
333    Option<Vec<synth_synthesis::ArmInstruction>>,
334);
335
336fn compile_wasm_to_arm(
337    wasm_ops: &[WasmOp],
338    config: &CompileConfig,
339) -> Result<CompileArmOutput, String> {
340    // #1093: a PARAMETER-taking block type (`if`/`block`/`loop (param ..)`,
341    // wasm multi-value) declines LOUDLY here — the single choke point BOTH
342    // ARM codegen paths pass through, so neither the optimized route nor the
343    // #197 direct route can reach the selectors' frame-entry stack
344    // checkpoints, which cannot represent params consumed below them (the
345    // `split_off` panic with an `else`; a silently-wrong false-path value
346    // without one — see `find_param_block_type`). This is the aarch64
347    // VCR-A64-CF-001 frame-open refusal ported, NOT multi-value support.
348    // Checked on the driver's ORIGINAL stream, which is what the ordinal
349    // side-table was built against. Empty side-table (hand-built op streams)
350    // ⇒ never fires ⇒ byte-identical for every existing caller.
351    //
352    // RQ-64-MVLOWER (#1093): the guard is relaxed PER CONSTRUCT and PER PATH,
353    // from the one policy in synth-core (`arm_param_block_lowering`), on the
354    // configuration the #1097 oracle executes — `--relocatable`. The
355    // self-contained image path keeps the full decline: no oracle leg
356    // executes its images, so there is no evidence to relax on.
357    let lowered = synth_core::arm_param_block_lowering(config.relocatable);
358    if let Some((what, ord, arity)) = synth_core::find_unlowered_param_block_type(
359        wasm_ops,
360        &config.current_func_block_arity,
361        lowered,
362    ) {
363        return Err(synth_core::param_block_decline_msg(
364            if config.relocatable {
365                "the ARM direct selector (--relocatable)"
366            } else {
367                "the ARM selector (self-contained image path — no #1097 oracle \
368                 leg executes it)"
369            },
370            what,
371            ord,
372            arity,
373        ));
374    }
375    // #539: `memory.grow(0)` must return the CURRENT page count, not the
376    // fixed-memory `-1` sentinel — growing by zero pages can never fail (WASM
377    // Core §4.4.7), so a guest doing `if (memory.grow(0) < 0) trap;` wrongly
378    // faulted. Every lowering path emitted a delta-agnostic `-1`. `memory.grow(0)`
379    // is semantically identical to `memory.size`, which the backend already
380    // computes from the runtime memory-size register (R10 >> 16 = pages), so fold
381    // the `i32.const 0; memory.grow` idiom to `memory.size` up front — backend-
382    // and path-agnostic. A non-zero delta keeps `-1` (fixed memory genuinely
383    // cannot grow); a runtime delta that happens to be 0 is the documented
384    // follow-up.
385    let rewritten = rewrite_memory_grow_zero(wasm_ops);
386    // #494 phase 2b: the fact-spec guard-elision marks are keyed by op index
387    // into the stream the DRIVER handed us. The memory.grow(0) fold above can
388    // only shift indices AT OR AFTER a `memory.grow` — an op the fact-spec
389    // walk never crosses (it stops at the first untracked op, so no mark can
390    // follow one). Defense in depth: if the fold fired at all, drop the marks
391    // loudly rather than risk keying a guard elision to the wrong op.
392    //
393    // VCR-MEM-004 (#901): scry's externally-proven bounds-guard marks ride the
394    // SAME defensive gate for the SAME reason — they are op-index keyed, so an
395    // index shift would strip the guard off the wrong access. They are unioned
396    // with #494's certificate-discharged marks here (one consumption point,
397    // two authorities; `CompileConfig` keeps them separate so the attestation
398    // can say which one covered each site).
399    let (fact_div_zero_elide, fact_div_ovf_elide, mem_bounds_elide): (
400        &[usize],
401        &[usize],
402        Vec<usize>,
403    ) = if rewritten.len() == wasm_ops.len() {
404        let mut mem = config.fact_mem_bounds_elide.clone();
405        mem.extend_from_slice(&config.proven_safe_mem_elide);
406        mem.sort_unstable();
407        mem.dedup();
408        (&config.fact_div_zero_elide, &config.fact_div_ovf_elide, mem)
409    } else {
410        if !config.fact_div_zero_elide.is_empty()
411            || !config.fact_div_ovf_elide.is_empty()
412            || !config.fact_mem_bounds_elide.is_empty()
413        {
414            eprintln!(
415                "fact-spec: DECLINE guard elision marks dropped — the                      memory.grow(0) fold shifted op indices (#494 defensive gate);                      general lowering emitted"
416            );
417        }
418        if !config.proven_safe_mem_elide.is_empty() {
419            eprintln!(
420                "proven-safe: DECLINE {} bounds-guard elision mark(s) dropped — the \
421                 memory.grow(0) fold shifted op indices, so the (func, pc) keys no longer \
422                 name the accesses scry proved (VCR-MEM-004 defensive gate, #901); every \
423                 guard is retained",
424                config.proven_safe_mem_elide.len()
425            );
426        }
427        (&[], &[], Vec::new())
428    };
429    let wasm_ops: &[WasmOp] = &rewritten;
430
431    // #457: `count_params` INFERS the param count from access patterns (a local
432    // whose first access is a read is assumed to be a param), so a
433    // read-before-write NON-PARAM local — which WASM zero-initializes — was
434    // indistinguishable from a param: it got homed in a parameter register and
435    // read caller garbage instead of 0. The driver supplies the DECLARED count
436    // (`current_func_param_count`, from the module's type section) to settle it.
437    //
438    // #970 (RQ-57-CONDPARAM): see [`effective_num_params`] for the bound and
439    // why the read-first inference is not it.
440    let inferred_params = count_params(wasm_ops);
441    let num_params = effective_num_params(wasm_ops, config);
442    // A read-before-write non-param local exists iff the ACCESS-PATTERN
443    // inference overshot the declared count — the read-first rule can only
444    // exceed it via a read-first index >= the declared count, which is exactly
445    // such a local. (Unchanged by #970: `referenced >= inferred` always, so
446    // `num_params < inferred_params` still holds iff `inferred > declared`;
447    // stated directly here rather than left to that algebra.)
448    let has_rbw_local = match config.current_func_param_count {
449        Some(declared) => inferred_params > declared,
450        None => false,
451    };
452
453    let bounds_config = match config.effective_safety_bounds() {
454        SafetyBounds::None => BoundsCheckConfig::None,
455        SafetyBounds::Mpu => BoundsCheckConfig::Mpu,
456        SafetyBounds::Software => BoundsCheckConfig::Software,
457        SafetyBounds::Mask => {
458            // #651 (mirroring the RISC-V backend's compile-time decline):
459            // index masking wraps `ea & (size-1)` — a modulo only when the
460            // linear-memory size is a power of two. With a non-power-of-two
461            // size the AND would silently REMAP in-bounds addresses (e.g.
462            // 0x18000 & 0x2FFFF = 0x8000 for a 192 KiB memory). Decline
463            // loudly rather than miscompile.
464            //
465            // RQ-57-SENTINEL (#953 sibling): `bytes == 0` used to be EXEMPT
466            // from this check, because 0 was read as "unknown — plain
467            // per-function path, no module context". But 0 is also exactly
468            // what a module declaring `(memory 0)` produces, and for that
469            // module the emitted guard (`SUB R12, R10, #1; AND addr, R12`,
470            // R10 = 0 baked by the startup) computes `0 - 1 = 0xFFFFFFFF` —
471            // an IDENTITY mask. Every access then executes unmasked at
472            // `[R11 + addr]` for any 32-bit addr: an unbounded OOB read/write
473            // in the mode whose purpose is bounding. Same sentinel/value
474            // collision as #932/#953, third backend-mode instance.
475            //
476            // 0 now means what #953 made it mean everywhere: a zero-byte
477            // memory. No mask can bound an access into a memory with no bytes
478            // (wasm semantics: every access traps), and wrap-not-trap has
479            // nothing to wrap into — refuse. Callers with no module context
480            // must state the size (the #953 contract; the CLI single-function
481            // path now threads the module's declared size for all backends).
482            let bytes = config.linear_memory_bytes;
483            if bytes == 0 {
484                return Err("--safety-bounds mask: the linear memory has ZERO bytes \
485                     (`(memory 0)`, or a driver that did not state the size) — \
486                     every access is out of bounds and a mask cannot express a \
487                     trap. Use --safety-bounds software (traps every access) \
488                     or declare a non-zero memory (RQ-57-SENTINEL, #953)"
489                    .to_string());
490            }
491            if !bytes.is_power_of_two() {
492                return Err(format!(
493                    "--safety-bounds mask requires a power-of-two linear-memory \
494                     size, got {bytes} bytes — switch to --safety-bounds software \
495                     for the deterministic check (#651)"
496                ));
497            }
498            BoundsCheckConfig::Masking
499        }
500    };
501
502    // The non-optimized (direct) instruction-selection path. Handles f32 via
503    // VFP/FPU. Used directly when `--no-optimize` is set, and as the fallback
504    // when the optimized path declines a module (see issue #120 below).
505    //
506    // VCR-RA-001 step 3b-lite (#242): a FRESH selector per attempt, with
507    // `spill_on_exhaustion` set only on the retry — the first pass is the
508    // unmodified default, so every function that compiles today is selected by
509    // exactly the code that compiled it yesterday (bit-identity is structural,
510    // not behavioural).
511    let select_direct_attempt = |spill_on_exhaustion: bool,
512                                 param_backing_on_exhaustion: bool,
513                                 local_promote: bool,
514                                 i64_spill_slots: Option<usize>,
515                                 vfp_spill_on_exhaustion: bool,
516                                 vfp_frame_home_locals: bool|
517     -> Result<Vec<ArmInstruction>, synth_core::Error> {
518        let db = RuleDatabase::with_standard_rules();
519        let mut selector =
520            InstructionSelector::with_bounds_check(db.rules().to_vec(), bounds_config);
521        selector.set_target(config.target.fpu, &config.target.triple);
522        if config.num_imports > 0 {
523            selector.set_num_imports(config.num_imports);
524        }
525        // #195: plumb the callee argument-count tables so the direct selector can
526        // marshal call arguments into R0–R3 per AAPCS.
527        selector.set_func_arg_counts(
528            config.func_arg_counts.clone(),
529            config.type_arg_counts.clone(),
530        );
531        // #197: in relocatable host-link mode, emit direct `func_N` BLs for
532        // imports (rewritten to the wasm field name by build_relocatable_elf)
533        // instead of `__meld_dispatch_import`.
534        selector.set_relocatable(config.relocatable);
535        // #642: call_indirect guard inputs (compile-time table size for the
536        // bounds guard + closed-world type verdicts). Without them, every
537        // call_indirect lowering declines loudly.
538        selector.set_call_indirect_guards(config.call_indirect_guards.clone());
539        // #275: on the self-contained image path (NOT --relocatable) the R11
540        // funcref-table dispatch is a silent miscompile — the region is only
541        // populated by an external runtime, which a self-contained ELF does
542        // not have, so the dispatch would read function pointers from
543        // linear-memory data. Two outcomes:
544        //  - the Thumb-2 `--cortex-m` image path (CLI-flagged: the builder
545        //    that emits and patches the flash-resident funcref table will
546        //    run) lowers call_indirect through that table, PC-relative,
547        //    never via R11;
548        //  - every OTHER self-contained configuration (A32/Cortex-R5, the
549        //    simple-ELF builder, imports present) keeps the loud decline.
550        // The host-linked (--relocatable) path keeps the guarded R11
551        // dispatch: there a runtime places the table region at R11.
552        let self_contained_table = config.self_contained_funcref_table
553            && matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb);
554        selector
555            .set_reject_self_contained_call_indirect(!config.relocatable && !self_contained_table);
556        selector.set_self_contained_funcref_table(self_contained_table);
557        // #237: native-pointer ABI — wasm statics become __synth_wasm_data-relative.
558        selector.set_native_pointer_abi(config.native_pointer_abi, config.linear_memory_bytes);
559        // VCR-MEM-002 phase 1 (#406): per-memory initial page counts — enables
560        // the multi-memory arms (memory-0 lowering never reads it; empty ⇒
561        // every multi-memory op declines loudly).
562        selector.set_memory_pages(config.memory_pages.clone());
563        // #311: i64 call results are register PAIRS — tag them.
564        selector.set_result_types(config.func_ret_i64.clone(), config.type_ret_i64.clone());
565        // #359: declared param widths of THIS function, so the AAPCS stack-arg
566        // path can refuse 64-bit params (Ok-or-Err). Empty ⇒ assume i32.
567        selector.set_params_i64(config.current_func_params_i64.clone());
568        // GI-FPU-002 (#619/#369): declared f32-param mask — home hard-float f32
569        // args in S0..S15 (AAPCS-VFP) instead of the R0..R3 integer path.
570        selector.set_params_f32(config.current_func_params_f32.clone());
571        // GI-FPU-002 phase 2 (#369): declared f64-param mask — hard-float
572        // targets decline f64-param functions loudly (no D-register homing yet).
573        selector.set_params_f64(config.current_func_params_f64.clone());
574        // GI-FPU-002 phase 2 (#719/#369): THIS function's f32/f64 return flag, so
575        // the epilogue loudly declines a float result reaching it in a core
576        // register (never a silent integer R0 return where a caller reads S0/D0).
577        selector.set_ret_float(config.current_func_ret_f32, config.current_func_ret_f64);
578        // GI-FPU-002 phase 3 (#369): per-callee float-signature tables. `Call`
579        // marshals the AAPCS-VFP boundary from these (float args into S0../D0..,
580        // float results out of S0/D0); `CallIndirect` still declines a
581        // float-returning static type loudly.
582        selector.set_float_call_signatures(
583            config.func_ret_f32.clone(),
584            config.func_ret_f64.clone(),
585            config.type_ret_f32.clone(),
586            config.type_ret_f64.clone(),
587            config.func_params_f32.clone(),
588            config.func_params_f64.clone(),
589        );
590        // #509: blocktype-arity side-table of THIS function, so value-carrying
591        // br/br_if/br_table land the carried value in the target block's
592        // designated result register instead of dropping it. Empty ⇒ legacy
593        // void-block lowering.
594        selector.set_block_arity(config.current_func_block_arity.clone());
595        // Stack-pointer promotion is meaningful only under the native-pointer ABI;
596        // gating here keeps every non-native compile (all frozen fixtures) on the
597        // legacy R9 globals-table path, bit-identical.
598        if config.native_pointer_abi
599            && let Some((sp_idx, sp_init)) = config.stack_pointer_global
600        {
601            selector.set_native_pointer_stack(sp_idx, sp_init);
602        }
603        // #643: per-global slot widths — i64/f64 globals occupy 8-byte slots
604        // (register-pair store/load) and shift every later global's offset.
605        // Empty for i32-only modules ⇒ the legacy `idx * 4` layout, unchanged.
606        selector.set_global_widths(config.global_widths.clone());
607        selector.set_spill_on_exhaustion(spill_on_exhaustion);
608        selector.set_param_backing_on_exhaustion(param_backing_on_exhaustion);
609        // #881 (VCR-RA-004): VFP register-file spilling, set ONLY on the retry
610        // after an attempt failed with a GI-FPU-002 exhaustion Err — functions
611        // that compile without it keep byte-identical output by construction.
612        selector.set_vfp_spill_on_exhaustion(vfp_spill_on_exhaustion);
613        // #1069: LAST-resort residence lever — set ONLY by the final VFP
614        // retry below, after the plain #881 rung also exhausted, so every
615        // function that compiles through base path or plain rung is produced
616        // by exactly yesterday's path (byte-identity is structural).
617        selector.set_vfp_frame_home_locals(vfp_frame_home_locals);
618        // #587 pool-grow rung: a larger i64 spill-slot pool, set ONLY on the
619        // retry after an attempt failed with the slot-pool-exhausted Err —
620        // functions that compile with the default pool keep their frame
621        // byte-identical by construction.
622        if let Some(slots) = i64_spill_slots {
623            selector.set_i64_spill_slots(slots);
624        }
625        // VCR-RA local promotion (#390, #242): keep eligible non-param i32 locals
626        // in callee-saved registers instead of frame slots — the structural lever
627        // toward native parity. DEFAULT-ON as of v0.14.0: gale's G474RE DWT gate
628        // cleared it as a net win (gust_mix dissolved 58→50 cyc/call −14%, all 5
629        // stack spill/reloads eliminated, correctness bit-identical over [0,2047],
630        // 2.00×→1.72× vs LLVM). Escape hatch: `SYNTH_NO_LOCAL_PROMOTE=1` restores
631        // the frame-slot path. Leaf-only / i32-only / ARM-only (see
632        // compute_local_promotion); the leaf-only lift + i64 locals are follow-ons.
633        // #474: `local_promote` is now a per-attempt parameter so the retry ladder
634        // can drop promotion as an exhaustion-recovery rung (promotion pins r4-r8,
635        // which on a dense function leaves the spill allocator with nothing to
636        // free → the frame-slot path is the escape that restores compilability).
637        selector.set_local_promote(local_promote);
638        // #494 phase 2b: certificate-discharged div/rem trap-guard elision
639        // marks (empty in every compile without SYNTH_FACT_SPEC + facts).
640        selector
641            .set_fact_div_guard_elisions(fact_div_zero_elide.to_vec(), fact_div_ovf_elide.to_vec());
642        // #494 bounds-elision + VCR-MEM-004 (#901): per-site memory
643        // bounds-guard marks, unioned above. Empty in every compile without
644        // SYNTH_FACT_SPEC + facts or --proven-safe.
645        selector.set_fact_mem_bounds_elisions(mem_bounds_elide.clone());
646        selector.select_with_stack(wasm_ops, num_params)
647    };
648    let select_direct = || -> Result<Vec<ArmInstruction>, String> {
649        const SINGLE_EXHAUSTION: &str = "all allocatable registers are live on the stack";
650        const PAIR_EXHAUSTION: &str = "no consecutive pair of free registers for i64";
651        const SLOT_EXHAUSTION: &str = "i64 spill-slot pool exhausted";
652        // The full exhaustion-recovery ladder, parameterized on whether local
653        // promotion is enabled. Each rung is reached only when the previous one
654        // returned a recoverable register-exhaustion Err, so a function that
655        // compiles on the first attempt is untouched by the later rungs. Returns
656        // the result AND which rung produced it (for the #242 measurement below).
657        let recovery_ladder = |promote: bool,
658                               i64_spill_slots: Option<usize>,
659                               vfp_spill: bool,
660                               vfp_frame: bool|
661         -> (
662            Result<Vec<ArmInstruction>, synth_core::Error>,
663            &'static str,
664        ) {
665            let mut attempt =
666                select_direct_attempt(false, false, promote, i64_spill_slots, vfp_spill, vfp_frame);
667            let mut rung = "base";
668            // VCR-RA-001 step 3b-lite (#242): the i32 register-exhaustion
669            // hard-fail is recoverable — retry with spill-on-exhaustion, which
670            // reserves the spill area and spills the deepest stack value when
671            // the pool is full.
672            if let Err(e) = &attempt
673                && e.to_string().contains(SINGLE_EXHAUSTION)
674            {
675                attempt = select_direct_attempt(
676                    true,
677                    false,
678                    promote,
679                    i64_spill_slots,
680                    vfp_spill,
681                    vfp_frame,
682                );
683                rung = "spill";
684            }
685            // VCR-RA-001 acceptance increment (#242): the i64 consecutive-PAIR
686            // exhaustion is recoverable too — not by stack spilling (the pair
687            // allocator already spills stack values, #171) but by frame-backing
688            // the params (#204) so they stop pinning R0-R3, with spill kept on.
689            if let Err(e) = &attempt
690                && e.to_string().contains(PAIR_EXHAUSTION)
691            {
692                attempt = select_direct_attempt(
693                    true,
694                    true,
695                    promote,
696                    i64_spill_slots,
697                    vfp_spill,
698                    vfp_frame,
699                );
700                rung = "param-backing";
701            }
702            (attempt, rung)
703        };
704        // #474: local promotion (default-on since v0.14.0) is an OPTIMIZATION — it
705        // must never be the reason a function fails to compile. Run the full ladder
706        // with promotion first (so every function that compiles today is
707        // bit-identical), and if it still ends in register exhaustion, fall back to
708        // the promotion-off ladder (the v0.12.0 frame-slot lowering — exactly what
709        // the `SYNTH_NO_LOCAL_PROMOTE=1` workaround does, now automatic). Promotion
710        // pins r4-r8 for the locals; on a dense function that leaves the allocator
711        // with nothing to free, so dropping it restores compilability. The fallback
712        // is reached ONLY by functions that exhaust WITH promotion, so promotion-on
713        // output is untouched by construction (frozen byte gate stays green).
714        let promote = std::env::var("SYNTH_NO_LOCAL_PROMOTE").is_err();
715        // The full pre-#587 recovery sequence (promotion-on ladder, then the
716        // #474 promotion-off fallback), parameterized on the pool size so the
717        // pool-grow retry below reruns it verbatim.
718        let full_sequence = |slots: Option<usize>,
719                             vfp_spill: bool,
720                             vfp_frame: bool|
721         -> (
722            Result<Vec<ArmInstruction>, synth_core::Error>,
723            &'static str,
724            bool,
725        ) {
726            let (mut attempt, mut rung) = recovery_ladder(promote, slots, vfp_spill, vfp_frame);
727            let mut promotion_dropped = false;
728            if promote
729                && attempt
730                    .as_ref()
731                    .err()
732                    .is_some_and(|e| e.to_string().contains("register exhaustion"))
733            {
734                let (rescued, off_rung) = recovery_ladder(false, slots, vfp_spill, vfp_frame);
735                if rescued.is_ok() {
736                    attempt = rescued;
737                    rung = off_rung;
738                    promotion_dropped = true;
739                }
740            }
741            (attempt, rung, promotion_dropped)
742        };
743        let (mut attempt, mut rung, mut promotion_dropped) = full_sequence(None, false, false);
744        // #587 pool-grow retry (the falcon func_60/func_73 remainder): the fixed
745        // 8-slot i64 spill pool can exhaust while spilling is otherwise working —
746        // an i64-dense function simply has more values simultaneously live than
747        // the pool holds. Rerun the ENTIRE sequence (every rung, both promotion
748        // modes) with the pool sized from a conservative operand-stack-depth
749        // bound: the number of simultaneously spilled values can never exceed
750        // the operand-stack depth, plus a few transient slots (the arg-move
751        // cycle resolver and call-result parking each borrow one). The selector
752        // clamps the request to its 12-bit-friendly cap; a function that still
753        // exhausts stays an honest loud skip. Deliberately LAST — after the #474
754        // promotion-off fallback — so any function that compiled yesterday
755        // (through any rung or fallback) is produced by exactly yesterday's
756        // path, byte-identical; the grown pool only ever fires for functions
757        // whose every existing escape ended in the slot-pool Err.
758        if attempt
759            .as_ref()
760            .err()
761            .is_some_and(|e| e.to_string().contains(SLOT_EXHAUSTION))
762        {
763            let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
764            let (grown, _, grown_dropped) =
765                full_sequence(Some(depth.saturating_add(4)), false, false);
766            if grown.is_ok() {
767                attempt = grown;
768                rung = "pool-grow";
769                promotion_dropped = grown_dropped;
770            }
771        }
772        // #881 (VCR-RA-004): the GI-FPU-002 VFP register-file exhaustion is
773        // recoverable too — retry the ENTIRE sequence with VFP spilling
774        // enabled (the pre-op pressure guard spills the deepest segment-local
775        // f32/f64 stack value into the shared spill area and reloads spilled
776        // operands before their consumers). Deliberately LAST, after every
777        // integer rung, so any function that compiled yesterday is produced
778        // by exactly yesterday's path; the VFP rung only ever fires for
779        // functions whose every existing escape ended in a GI-FPU-002
780        // exhaustion Err (previously an unconditional loud skip). A VFP-
781        // spilling function can in turn exhaust the shared slot pool — the
782        // #587 pool-grow retry composes inside the rung.
783        const VFP_S_EXHAUSTION: &str = "VFP register file exhausted";
784        const VFP_D_EXHAUSTION: &str = "VFP D-register file exhausted";
785        if attempt.as_ref().err().is_some_and(|e| {
786            let msg = e.to_string();
787            msg.contains(VFP_S_EXHAUSTION) || msg.contains(VFP_D_EXHAUSTION)
788        }) {
789            // Stage 1 — the plain #881 rung, exactly yesterday's path
790            // (sequence, pool sizing and all): any function it rescues is
791            // byte-identical to what it shipped yesterday, by construction.
792            let (vfp, vfp_rung, vfp_dropped) = full_sequence(None, true, false);
793            let (vfp, vfp_rung, vfp_dropped) = if vfp.as_ref().err().is_some_and(|e| {
794                let msg = e.to_string();
795                msg.contains(SLOT_EXHAUSTION) || msg.contains("spilling the VFP register file")
796            }) {
797                let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
798                let (grown, grown_rung, grown_dropped) =
799                    full_sequence(Some(depth.saturating_add(4)), true, false);
800                if grown.is_ok() {
801                    (grown, grown_rung, grown_dropped)
802                } else {
803                    (vfp, vfp_rung, vfp_dropped)
804                }
805            } else {
806                (vfp, vfp_rung, vfp_dropped)
807            };
808            if vfp.is_ok() {
809                attempt = vfp;
810                rung = match vfp_rung {
811                    "base" => "vfp-spill",
812                    _ => "vfp-spill+int",
813                };
814                promotion_dropped = vfp_dropped;
815            } else {
816                // Stage 2 (#1069, RQ-60-VFPPRESSURE increment 2) — LAST
817                // resort: the plain rung ALSO failed, i.e. the pressure is
818                // not (only) operand-stack values but PINNED LOCAL HOMES,
819                // which the #881 victim search rightly never touches (a home
820                // lives for the function's extent). Rerun the entire
821                // sequence with frame-homed overflow locals: a fresh
822                // f32/f64 local whose home grant would pin above the S7/D3
823                // cap lives in the frame from its first def. Reached ONLY by
824                // functions that failed every prior escape, so nothing that
825                // compiles today moves a byte.
826                let (fh, fh_rung, fh_dropped) = full_sequence(None, true, true);
827                let (fh, fh_rung, fh_dropped) = if fh.as_ref().err().is_some_and(|e| {
828                    let msg = e.to_string();
829                    // The frame-homed-local slot demand (a PERMANENT slot per
830                    // frame-resident float local) is a third way the shared
831                    // pool exhausts — its trigger substring is the selector's
832                    // own pub const, not a second copy that could drift (the
833                    // #881 substring-is-control-flow lesson, pinned red-first
834                    // by the live24 fixture test).
835                    msg.contains(SLOT_EXHAUSTION)
836                        || msg.contains("spilling the VFP register file")
837                        || msg.contains(
838                            synth_synthesis::instruction_selector::VFP_FRAME_HOME_SLOT_EXHAUSTION,
839                        )
840                }) {
841                    let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
842                    // Frame-homed locals hold their slots for the function's
843                    // extent, OUTSIDE the operand-stack depth bound — size
844                    // the grown pool for both. Distinct `local.set`/
845                    // `local.tee` targets over-approximate the frame-homed
846                    // local count; the selector clamps the request to its
847                    // cap, and a function that still exhausts stays an
848                    // honest loud skip.
849                    let local_targets: std::collections::HashSet<u32> = wasm_ops
850                        .iter()
851                        .filter_map(|op| match op {
852                            synth_synthesis::WasmOp::LocalSet(i)
853                            | synth_synthesis::WasmOp::LocalTee(i) => Some(*i),
854                            _ => None,
855                        })
856                        .collect();
857                    let (grown, grown_rung, grown_dropped) = full_sequence(
858                        Some(depth.saturating_add(local_targets.len()).saturating_add(4)),
859                        true,
860                        true,
861                    );
862                    if grown.is_ok() {
863                        (grown, grown_rung, grown_dropped)
864                    } else {
865                        (fh, fh_rung, fh_dropped)
866                    }
867                } else {
868                    (fh, fh_rung, fh_dropped)
869                };
870                if fh.is_ok() {
871                    attempt = fh;
872                    rung = match fh_rung {
873                        "base" => "vfp-frame-locals",
874                        _ => "vfp-frame-locals+int",
875                    };
876                    promotion_dropped = fh_dropped;
877                }
878            }
879        }
880        // VCR-RA measurement (#242): log which recovery rung produced the result,
881        // so the per-rung distribution across a corpus can be measured — the size
882        // of the failure surface a verified allocator must subsume (see
883        // scripts/repro/register_exhaustion_recovery_ladder.md). Logging only:
884        // emitted bytes are unchanged, so the frozen byte gate is unaffected.
885        if std::env::var("SYNTH_RECOVERY_STATS").is_ok() {
886            eprintln!(
887                "[recovery-stats] rung={rung}{} result={}",
888                if promotion_dropped {
889                    " promotion-off"
890                } else {
891                    ""
892                },
893                if attempt.is_ok() { "ok" } else { "exhausted" },
894            );
895        }
896        attempt.map_err(|e| format!("instruction selection failed: {}", e))
897    };
898
899    // Instruction selection: optimized or direct.
900    //
901    // #197: `--relocatable` (host-link ET_REL) forces the direct selector. The
902    // optimized path materializes an absolute linmem base (0x20000100) and does
903    // not preserve caller-saved registers across calls — both wrong for a
904    // host-linked object, where the linmem base arrives via `fp` at runtime and
905    // callees follow AAPCS. `select_with_stack` (now i64-spill capable after
906    // #171) handles fp-relative memory + caller-saved preservation correctly.
907    //
908    // #507: `br_table` is DROPPED during the optimized path's wasm→IR lowering
909    // (`optimize_full`), so `ir_to_arm` never sees the dispatch — it emits the
910    // arm bodies in fall-through sequence with no `cmp`/branch on the selector, a
911    // SILENT miscompile (every input hits the last arm). The selector value isn't
912    // even loaded. Because the drop happens before `ir_to_arm`, there's no `Err`
913    // to fall back on; detect it on the raw wasm op stream here and force the
914    // direct selector (`select_with_stack` lowers `br_table` correctly as a
915    // cmp-chain — confirmed on the `--relocatable` path). Same honest-degradation
916    // contract as the issue-#120 f32 decline: the function still compiles
917    // correctly, just without IR-level optimization. Frozen-safe: the frozen
918    // fixtures compile `--relocatable` (already direct), and no optimized-path
919    // fixture (control_step, flight_algo) contains `br_table`.
920    let has_br_table = wasm_ops
921        .iter()
922        .any(|op| matches!(op, WasmOp::BrTable { .. }));
923    // #509: the optimized path also drops the value carried by a `br`/`br_if`
924    // to a result-typed block (the taken edge returns the wrong arm's value —
925    // same silent-miscompile class as the #507 br_table drop). Route the shape
926    // to the direct selector, whose designated-result-register lowering (#509)
927    // lands the carried value at the join. Never fires for void-block control
928    // flow (all frozen/optimized fixtures), so those stay byte-identical.
929    let has_value_carry = has_value_carrying_branch(wasm_ops, &config.current_func_block_arity);
930    // #503-i64/#518: route any signature with a 64-bit (i64/f64) param to the
931    // direct selector. The optimized path's param homing is width-naive — its
932    // #518 decline covers only functions that READ an i64 param (an `I64Load`
933    // from a param index), so a function that reads an i32 param whose AAPCS
934    // home a preceding wide param SHIFTED (e.g. p1 of `(i64 i32)` lives in R2,
935    // not R1; p3 of `(i64 i32 i32 i32)` lives on the stack, not in R3) was
936    // silently miscompiled rather than falling back. The direct selector's
937    // `aapcs_param_layout` homing handles every such shape (i64-param READS
938    // already fell back to it via the ir_to_arm Err, so those functions emit
939    // the same bytes as before). `num_params` counts read-first locals, so a
940    // function that never touches any param keeps the optimized path.
941    let has_wide_param = config
942        .current_func_params_i64
943        .iter()
944        .take(num_params as usize)
945        .any(|&w| w);
946    // #782(b): a HARD-float (FPU) target passes f32 args in VFP S-registers
947    // and returns floats in S0/D0 (AAPCS-VFP) — but the optimized path's
948    // param/return homing is float-naive (integer R0..R3 args, R0 return). A
949    // function whose ops ALL lower on the optimized path but whose SIGNATURE
950    // carries a float — e.g. the pure value-pick
951    // `(param f32 f32 i32) (result f32) select`, no float OP to trip the
952    // issue-#120 ir_to_arm fallback — was silently compiled with the integer
953    // ABI: callers marshal S0/S1, the body reads R0/R1. Route every
954    // float-signature function to the direct selector (AAPCS-VFP homing, or
955    // an honest decline). Soft-float targets (no FPU) keep the optimized
956    // path: the integer treatment IS the ABI there — byte-identical. (f64
957    // params already route direct via `has_wide_param`; this adds f32 params
958    // and f32/f64 returns.)
959    let has_float_sig = config.target.fpu.is_some()
960        && (config.current_func_ret_f32
961            || config.current_func_ret_f64
962            || config
963                .current_func_params_f32
964                .iter()
965                .take(num_params as usize)
966                .any(|&f| f)
967            || config
968                .current_func_params_f64
969                .iter()
970                .take(num_params as usize)
971                .any(|&f| f));
972    // #494 phase 2b: div/rem guard-elision marks are consumed by the DIRECT
973    // selector only — the optimized path's IR passes (const-fold/CSE/DCE)
974    // renumber instructions, so an op-index-keyed mark cannot soundly survive
975    // them. Route marked functions direct (the #507/#509 honest-degradation
976    // pattern). Never fires without SYNTH_FACT_SPEC + facts + a discharged
977    // obligation, so every existing compile keeps its path byte-identical.
978    let has_fact_div_elide = !fact_div_zero_elide.is_empty()
979        || !fact_div_ovf_elide.is_empty()
980        // #494 bounds-elision + VCR-MEM-004 (#901): memory bounds-guard marks
981        // are direct-selector keyed for the same reason (IR passes renumber
982        // instructions). This is ALSO why the optimized path's
983        // `push_software_bounds_guard` sites never need mark plumbing: a
984        // marked function is routed away from that path entirely.
985        || !mem_bounds_elide.is_empty();
986    // #643: the optimized path's global lowering is width-naive — `GlobalGet`/
987    // `GlobalSet` are single-word `[R9, idx*4]` accesses, which (a) silently
988    // dropped the high word of every i64 global and (b) mis-address every
989    // global whose offset an earlier wide (i64/f64) slot shifted. When the
990    // module has any wide global, route every global-touching function to the
991    // direct selector, whose type-aware summed layout pairs the access (or
992    // declines loudly). Modules with only 4-byte globals — every existing
993    // fixture — keep the optimized path byte-identical.
994    let has_wide_global_module = config.global_widths.iter().any(|&w| w > 4);
995    let has_global_access = has_wide_global_module
996        && wasm_ops
997            .iter()
998            .any(|op| matches!(op, WasmOp::GlobalGet(_) | WasmOp::GlobalSet(_)));
999    // VCR-VER-001 (#242): `post_exhaust` scopes the post-exhaustion cleanup
1000    // extensions to functions whose bytes the #580 spill-on-exhaustion
1001    // machinery actually shaped (bridge-reported). Everything else — the
1002    // direct path, non-exhausted optimized functions — stays byte-identical
1003    // flag-on (the `vcr_ver_001_gate_242` lock's contract).
1004    let (arm_instrs, post_exhaust) = if config.no_optimize
1005        || config.relocatable
1006        || has_br_table
1007        || has_value_carry
1008        || has_wide_param
1009        || has_float_sig
1010        || has_global_access
1011        || has_fact_div_elide
1012        // #457: route read-before-write non-param locals to the direct
1013        // selector, whose prologue zero-init lands the wasm-mandated 0.
1014        || has_rbw_local
1015    {
1016        if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
1017            eprintln!("[path-debug] direct (pre-gate)");
1018        }
1019        (select_direct()?, false)
1020    } else {
1021        let opt_config = if config.loom_compat {
1022            OptimizationConfig::loom_compat()
1023        } else {
1024            OptimizationConfig::all()
1025        };
1026
1027        let mut bridge = OptimizerBridge::with_config(opt_config);
1028        // #188: tell the bridge how many imports there are so it declines only
1029        // LOCAL calls (and leaves import calls on the optimized path, keeping
1030        // the #173 field-name relocation rewrite intact).
1031        bridge.set_num_imports(config.num_imports);
1032        // #543 Phase 2: thread the integrator-marked volatile DMA-window ranges
1033        // (`--volatile-segment <base>:<len>`) to the bridge's address-caching
1034        // levers — base-CSE (#468) excludes any access inside a marked range
1035        // from its fold set, and the bridge-level const-CSE declines wholesale
1036        // while any range is marked. Empty (the default) ⇒ byte-identical.
1037        bridge.set_volatile_segments(config.volatile_segments.clone());
1038        // #377: thread `--safety-bounds` to the bridge. Pre-fix the optimized
1039        // path ignored it — `software`/`mask` were SILENT NO-OPS on the path
1040        // that lowers the bulk of a flight loop's i32 loads/stores (byte-
1041        // identical to `none`, while the safety manifest claimed otherwise).
1042        // `Software` now emits the inline guard per access; `Masking` declines
1043        // memory-accessing functions to the direct selector; `None`/`Mpu` are
1044        // byte-identical to before.
1045        bridge.set_bounds_check(bounds_config);
1046        // #687: thread the absolute linear-memory base the optimized path
1047        // materializes. Defaults to 0x2000_0100 (byte-identical);
1048        // `--stack-layout=low` shifts it up by the reserved stack size so
1049        // const-address accesses follow the moved linear memory.
1050        bridge.set_linmem_base(config.linmem_base);
1051        // `ir_to_arm` now returns `Result` — an `Err` means the optimized path
1052        // hit an unmapped vreg (issue-#93-class). Treat it identically to an
1053        // `optimize_full` failure: fall back to the direct selector rather
1054        // than propagating, so the function still compiles correctly.
1055        match bridge
1056            .optimize_full(wasm_ops)
1057            .and_then(|(opt_ir, _cfg, _stats)| bridge.ir_to_arm(&opt_ir, num_params as usize))
1058        {
1059            Ok(arm_ops) => {
1060                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
1061                    eprintln!("[path-debug] optimized (ir_to_arm ok)");
1062                }
1063                (
1064                    arm_ops
1065                        .into_iter()
1066                        .map(|op| ArmInstruction {
1067                            op,
1068                            source_line: None,
1069                        })
1070                        .collect(),
1071                    bridge.spill_on_exhaust_fired(),
1072                )
1073            }
1074            // Issue #120: the optimized path declines modules it cannot lower
1075            // (notably scalar f32/f64 ops — the IR has no float opcodes). Fall
1076            // back to the direct instruction selector, which handles f32 via
1077            // VFP/FPU. This is honest degradation: the function still compiles
1078            // correctly, just without IR-level optimization.
1079            Err(e) => {
1080                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
1081                    eprintln!("[path-debug] direct (fallback: {e})");
1082                }
1083                (select_direct()?, false)
1084            }
1085        }
1086    };
1087
1088    // #257/#277: `mul`+`add`→`mla` fusion is intentionally NOT wired here.
1089    // The transform is correct and ready (`synth_synthesis::liveness::fuse_mul_add`,
1090    // fully tested), but it is **register-allocation-coupled**: over the current
1091    // greedy single-pass selector, folding `mul rM,..; add rD,rM,rX` → `mla`
1092    // extends the live ranges of the mul inputs to the mla point, and the added
1093    // pressure (extra moves/spills) costs more than the single-cycle MLA saves —
1094    // gale measured a +2 cyc on-target REGRESSION (flat_flight 255→257, G474RE)
1095    // even though it removes 2 instructions and the seam stays 0x07FDF307. So the
1096    // fusion stays unwired until the spill-aware allocator (VCR-RA-001) chooses
1097    // registers, at which point it becomes net-positive (per #272's plan and the
1098    // wiring design note). Lesson (#277): a register-pressure-affecting transform
1099    // needs an on-target/allocator-aware gate, not a byte-count gate, before it
1100    // can default on.
1101
1102    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209): moved to run
1103    // LAST, after the immediate-folds — see the apply_const_cse call below
1104    // (#242). Earlier it ran here (before range-realloc and the folds), which is
1105    // what let it grow gale's --relocatable `gust_mix` 90→92 B (#242 burndown,
1106    // 2026-06-26): retargeting a read defeated a *downstream* immediate-fold that
1107    // would otherwise have absorbed the constant. Running CSE-last makes those
1108    // foldable consts already-folded-and-gone, so CSE only ever touches genuinely
1109    // redundant materializations.
1110
1111    // VCR-RA-001 RANGE RE-ALLOCATION (#209/#242, wiring step 3a) — the first
1112    // CONSEQUENTIAL allocator pass: re-colour each maximal straight-line
1113    // segment over the R0-R8 pool with value ranges as the allocation unit
1114    // (segment inputs + per-register live-outs pinned to their original
1115    // registers, reserved R9-R12/SP identity-assigned — each segment is
1116    // independently sound, no cross-segment liveness assumed). Renames
1117    // registers only: never adds, removes, or reorders instructions, so
1118    // labels/branch offsets are unaffected.
1119    //
1120    // DEFAULT-ON since v0.11.36: gale cleared the gate on-target (G474RE,
1121    // #209 2026-06-10) — flag-on output byte-identical to flag-off on
1122    // flat_flight/controller/control_step, fires on the filter family with
1123    // zero cycle delta and a small size win, all selfchecks green on silicon.
1124    // Opt out with `SYNTH_RANGE_REALLOC=0`; per-function stats with
1125    // `SYNTH_REALLOC_STATS=1`.
1126    //
1127    // The companion dead callee-saved-save elimination (gale's "next
1128    // consequential lever", same issue comment) then shrinks the prologue
1129    // `push {r4-r8,lr}` / epilogue `pop {r4-r8,pc}` to the callee-saved
1130    // registers the re-allocated body still touches (leaf-only,
1131    // SP-untouched, even-count-padded — see shrink_callee_saved_saves):
1132    // ~12 cycles of pure save/restore overhead removed on small leaves.
1133    let realloc_on = std::env::var("SYNTH_RANGE_REALLOC").map_or(true, |v| v != "0");
1134    let (arm_instrs, ran_realloc) = if realloc_on {
1135        use synth_synthesis::rules::Reg;
1136        const POOL: [Reg; 9] = [
1137            Reg::R0,
1138            Reg::R1,
1139            Reg::R2,
1140            Reg::R3,
1141            Reg::R4,
1142            Reg::R5,
1143            Reg::R6,
1144            Reg::R7,
1145            Reg::R8,
1146        ];
1147        // VCR-DEC-001 (epic #242, the North Star's first foothold): the
1148        // SYNTH_GRAPH_ALLOC graph-colouring allocator SPIKE. When enabled it
1149        // replaces STEP 1 of the re-allocation (the segment-based
1150        // `reallocate_function`) with a whole-function Chaitin/Briggs colouring
1151        // (`graph_alloc::reallocate`) built against the SAME acceptance oracle
1152        // (`validate_segment_rewrite` trace-equality); the later dead-frame /
1153        // callee-saved-prologue / shrink passes still run on its output, so a
1154        // value it homes in R4-R8 still gets its callee-saved push (the
1155        // invariant the unconditional VCR-RA-003 validator guards). It is
1156        // BOUNDED to whole straight-line functions and DECLINES (returns None)
1157        // to the shipping `reallocate_function` on any control flow, spill, or
1158        // unmodeled op — never a hard-fail. Flag-OFF (`SYNTH_GRAPH_ALLOC` unset)
1159        // never enters this branch, so the shipping bytes are byte-identical
1160        // (the GOLDEN trick — frozen fixtures unchanged). NO default flip: the
1161        // spike ships flag-off; the flip is a later, evidence-gated step.
1162        //
1163        // VCR-VER-001 (#242): on a function the spill-on-exhaustion machinery
1164        // shaped, the terminal segment gets relaxed live-out pinning (only
1165        // R0/R1 are observable past `bx lr` at this pre-prologue position) so
1166        // the colourer can lower R4-R8-homed tails into caller-saved R0-R3 —
1167        // shrinking the `push {r4-r8,lr}` the #580 exhaustion shapes pay for.
1168        // `post_exhaust == false` selects the shipping pass bit for bit.
1169        let (out, stats) = if synth_synthesis::graph_alloc::enabled() {
1170            // RQ-60-RACOST increment 2 (#242): the colourer prices every
1171            // colour choice in REAL-ENCODER bytes. The sizer is the same
1172            // encoder family the emit loop below constructs — Thumb-2 (with
1173            // the target's FPU) or A32 — asked per candidate instruction, so
1174            // there is no hand size table to drift (#936). On the fixed-width
1175            // A32 ISA every candidate ties and the cost model degenerates to
1176            // the identity hint (zero churn).
1177            let sizing_encoder =
1178                if matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb) {
1179                    ArmEncoder::new_thumb2_with_fpu(config.target.fpu)
1180                } else {
1181                    ArmEncoder::new_arm32()
1182                };
1183            let enc = |op: &synth_synthesis::rules::ArmOp| {
1184                sizing_encoder.encode(op).ok().map(|b| b.len())
1185            };
1186            let stats_on = std::env::var("SYNTH_GRAPH_ALLOC_STATS").is_ok();
1187            match synth_synthesis::graph_alloc::reallocate(&arm_instrs, &POOL, &enc) {
1188                // SYNTH_GRAPH_ALLOC_FORCE (test seam, RQ-60-RACOST
1189                // increment 2): ship every validated candidate WITHOUT the
1190                // final-byte arbiter — the pre-arbiter behaviour. Used by
1191                // `vcr_dec_001_join_alloc_execution_differential.py` so the
1192                // unicorn-vs-wasmtime oracle executes the colourer's
1193                // proposals on EVERY reachable shape (call, i64-pair,
1194                // shift-expansion), not only the ones the arbiter lets ship —
1195                // an arbiter-declined candidate is still a candidate a future
1196                // change could promote, and the execution teeth must stay
1197                // ahead of that. Never set in production; the arbiter is the
1198                // shipping behaviour.
1199                Some(candidate)
1200                    if std::env::var("SYNTH_GRAPH_ALLOC_FORCE").is_ok_and(|v| v != "0") =>
1201                {
1202                    if stats_on {
1203                        eprintln!(
1204                            "[graph-alloc] whole-function colouring APPLIED \
1205                             (validated; FORCED — arbiter bypassed)"
1206                        );
1207                    }
1208                    (
1209                        candidate,
1210                        synth_synthesis::liveness::ReallocStats::default(),
1211                    )
1212                }
1213                Some(candidate) => {
1214                    // FINAL-BYTE ARBITER (RQ-60-RACOST increment 2). A
1215                    // colour-time cost model — however faithful its byte sizes
1216                    // — cannot price DOWNSTREAM PASS INTERACTIONS: measured on
1217                    // const_cse.wat::spill12, an identity-shaped colouring
1218                    // that merely PRESERVED the greedy allocator's register
1219                    // rotation defeated const-CSE's canonicalization and grew
1220                    // the function 148 -> 244 B (+96), with not one occurrence
1221                    // priced differently at colour time. So the candidate is
1222                    // sized through the REAL downstream pipeline
1223                    // (`finish_allocated_stream` — the exact passes the
1224                    // shipped stream runs, not a mirror) plus label resolution
1225                    // and the REAL encoder, against the shipping allocator's
1226                    // stream sized identically, and it ships only when it is
1227                    // STRICTLY smaller. A tie or a refusal keeps the shipping
1228                    // bytes — growth on an applied function is structurally
1229                    // impossible, which is exactly the wired
1230                    // vcr_dec_001_graph_alloc_differential no-growth
1231                    // assertion, promoted from a gate into a construction.
1232                    let ship = synth_synthesis::liveness::reallocate_function_post_exhaust(
1233                        &arm_instrs,
1234                        &POOL,
1235                        post_exhaust,
1236                    );
1237                    let size_of = |stream: &[synth_synthesis::ArmInstruction]| -> Option<usize> {
1238                        let finished = match finish_allocated_stream(
1239                            stream.to_vec(),
1240                            config,
1241                            post_exhaust,
1242                            true,
1243                        ) {
1244                            Ok(f) => f,
1245                            Err(e) => {
1246                                if stats_on {
1247                                    // The differential greps for the RA-003
1248                                    // hard-error string to detect a SHIPPED
1249                                    // violation; a candidate refused during
1250                                    // sizing is a decline, not a shipped
1251                                    // violation, so that marker is rewritten.
1252                                    let e = e.replace(
1253                                        "register-allocation validation FAILED",
1254                                        "register-allocation validation refused the candidate",
1255                                    );
1256                                    eprintln!(
1257                                        "[graph-alloc] arbiter: stream refused by the \
1258                                         pipeline/validators: {e}"
1259                                    );
1260                                }
1261                                return None;
1262                            }
1263                        };
1264                        let finished = if matches!(
1265                            config.target.isa,
1266                            IsaVariant::Thumb2 | IsaVariant::Thumb
1267                        ) {
1268                            resolve_label_branches(finished, &sizing_encoder).ok()?
1269                        } else {
1270                            finished
1271                        };
1272                        let mut total = 0usize;
1273                        let mut literals = 0usize;
1274                        for ins in &finished {
1275                            total += sizing_encoder.encode(&ins.op).ok()?.len();
1276                            if matches!(ins.op, synth_synthesis::rules::ArmOp::LdrSym { .. }) {
1277                                literals += 1;
1278                            }
1279                        }
1280                        if literals > 0 {
1281                            // The emit loop 4-aligns the literal pool and
1282                            // appends one word per LdrSym (no dedup — each
1283                            // site carries its own addend).
1284                            total += (4 - total % 4) % 4 + 4 * literals;
1285                        }
1286                        Some(total)
1287                    };
1288                    match (size_of(&candidate), size_of(&ship.0)) {
1289                        (Some(cand), Some(base)) if cand < base => {
1290                            if stats_on {
1291                                eprintln!(
1292                                    "[graph-alloc] whole-function colouring APPLIED \
1293                                     (validated; arbiter: {cand} B < shipping {base} B)"
1294                                );
1295                            }
1296                            (
1297                                candidate,
1298                                synth_synthesis::liveness::ReallocStats::default(),
1299                            )
1300                        }
1301                        (cand, base) => {
1302                            if stats_on {
1303                                eprintln!(
1304                                    "[graph-alloc] arbiter kept shipping bytes \
1305                                     (candidate {cand:?} B vs shipping {base:?} B) → \
1306                                     shipping reallocate_function"
1307                                );
1308                            }
1309                            ship
1310                        }
1311                    }
1312                }
1313                None => {
1314                    if stats_on {
1315                        eprintln!("[graph-alloc] DECLINED → shipping reallocate_function");
1316                    }
1317                    synth_synthesis::liveness::reallocate_function_post_exhaust(
1318                        &arm_instrs,
1319                        &POOL,
1320                        post_exhaust,
1321                    )
1322                }
1323            }
1324        } else {
1325            synth_synthesis::liveness::reallocate_function_post_exhaust(
1326                &arm_instrs,
1327                &POOL,
1328                post_exhaust,
1329            )
1330        };
1331        if std::env::var("SYNTH_REALLOC_STATS").is_ok() {
1332            eprintln!(
1333                "[range-realloc] {} segments: {} reallocated, {} declined ({} validator-rejected), {} need spill (step 4)",
1334                stats.segments,
1335                stats.reallocated,
1336                stats.declined,
1337                stats.validator_rejects,
1338                stats.needs_spill
1339            );
1340        }
1341        // VCR-VER-004 AUDIT (#242) — report-only, opt-in, never gating.
1342        //
1343        // The ABI observable-contract validator is a GATE on the flag-off
1344        // graph-colouring spike. This hook asks the same question of the
1345        // SHIPPING allocator's rewrite, so the answer is a MEASUREMENT rather
1346        // than a claim: how much of the shipping path can a value-level,
1347        // ABI-anchored check actually see today? Report-only DELIBERATELY —
1348        // making it gate here would risk a false rejection on the default
1349        // path, and the honest sequence is measure first, flip on evidence.
1350        // `SYNTH_ABI_CONTRACT_AUDIT=1` prints one verdict per function.
1351        if std::env::var_os("SYNTH_ABI_CONTRACT_AUDIT").is_some() {
1352            eprintln!(
1353                "[abi-contract-audit] {:?}",
1354                synth_synthesis::abi_contract::validate_abi_contract(&arm_instrs, &out)
1355            );
1356        }
1357        (out, true)
1358    } else {
1359        (arm_instrs, false)
1360    };
1361    // RQ-60-RACOST increment 2 (#242): every rewrite pass between the chosen
1362    // allocation and the encoder now lives in `finish_allocated_stream`, so
1363    // the SYNTH_GRAPH_ALLOC final-byte arbiter can size a candidate through
1364    // the REAL pipeline. Flag-off this is the exact pre-extraction sequence,
1365    // called once, in the same place.
1366    let arm_instrs = finish_allocated_stream(arm_instrs, config, post_exhaust, ran_realloc)?;
1367
1368    // Encode to binary — use Thumb-2 for Cortex-M targets
1369    let use_thumb2 = matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb);
1370
1371    let encoder = if use_thumb2 {
1372        ArmEncoder::new_thumb2_with_fpu(config.target.fpu)
1373    } else {
1374        ArmEncoder::new_arm32()
1375    };
1376
1377    // #202: resolve local label branches (Bcc/B/Bhs/Blo) to byte-accurate
1378    // offsets before encoding. `select_with_stack` emits them as label
1379    // placeholders and never resolves them — without this they encode as
1380    // `bne.n #0` and land mid-instruction whenever a 32-bit Thumb-2 instruction
1381    // sits between the branch and its target (UsageFault on real hardware).
1382    // Only meaningful for Thumb-2 (the offset units are halfword/PC+4).
1383    let arm_instrs = if use_thumb2 {
1384        let resolved = resolve_label_branches(arm_instrs, &encoder)?;
1385        // SC-5 (#740/#930): hard-gate every branch target onto the
1386        // instruction-start set of the final stream — both codegen paths
1387        // funnel through here. See `validate_branch_targets`.
1388        validate_branch_targets(&resolved, &encoder)?;
1389        resolved
1390    } else {
1391        arm_instrs
1392    };
1393
1394    // #778: capture the FINAL Thumb-2 instruction stream (post label-resolution,
1395    // the exact list the encode loop below consumes) so `compile_function` can
1396    // derive the sound WCET bound. Cheap clone; frozen-safe (the WCET walk is a
1397    // pure observation and never touches `code`). Only the Thumb-2 path — the A32
1398    // (Cortex-R5) cycle model is a follow-up.
1399    let final_instrs_for_wcet: Option<Vec<synth_synthesis::ArmInstruction>> = if use_thumb2 {
1400        Some(arm_instrs.clone())
1401    } else {
1402        None
1403    };
1404
1405    let mut code = Vec::new();
1406    let mut relocations = Vec::new();
1407
1408    // #345: literal-pool address loads. Each `LdrSym` was encoded as a placeholder
1409    // `LDR.W rd,[pc,#0]`; record where its instruction sits and what it loads so
1410    // we can append a pooled word (carrying the symbol address via R_ARM_ABS32)
1411    // and patch the PC-relative offset once the pool position is known.
1412    struct PendingLiteral {
1413        ldr_offset: u32,
1414        symbol: String,
1415        addend: i32,
1416    }
1417    let mut pending_literals: Vec<PendingLiteral> = Vec::new();
1418
1419    // VCR-DBG-001: per-instruction source map for DWARF `.debug_line`. Captured
1420    // here because `code.len()` immediately before `encode()` is the final
1421    // machine offset of the instruction within this function's `.text` — nothing
1422    // after the loop shifts earlier instructions (the literal pool is appended at
1423    // the end; the LDR patch below is in-place/length-preserving). Purely
1424    // additive: it does not touch `code`, so `.text` is byte-identical.
1425    let mut line_map: LineMap = Vec::new();
1426    // VCR-DEC-003 (#396): object-branch class per emitted instruction, parallel
1427    // to `line_map`. Cheap, additive, does not touch `code`.
1428    let mut branch_map: synth_core::backend::BranchMap = Vec::new();
1429
1430    for instr in &arm_instrs {
1431        // Record a relocation for every BL: the encoder emits `bl #0` and
1432        // relies on a relocation to patch the target. This covers BOTH import
1433        // dispatch stubs (`__meld_*`, undefined externals) AND internal calls
1434        // (`func_N`, defined in this object). Previously only `__meld_*` was
1435        // recorded, so internal `BL func_N` calls were left as unpatched
1436        // `bl #0` placeholders branching to a garbage address (#167).
1437        if let ArmOp::Bl { label } = &instr.op {
1438            // #1040: the relocation type is ISA-STATE-dependent and this is the
1439            // only site that knows the state. An A32 (Cortex-R) `bl` is
1440            // R_ARM_CALL (28); a Thumb `bl` is R_ARM_THM_CALL (10). Emitting
1441            // the Thumb type for an A32 word made any consumer that trusts the
1442            // declared type patch Thumb halfwords into an ARM-state
1443            // instruction. Decided here rather than in the ELF emitter, where
1444            // `config.target` is no longer in scope and the ISA would have to
1445            // be re-derived — the shape that produced the bug.
1446            let kind = if config.target.isa == synth_core::target::IsaVariant::Arm32 {
1447                synth_core::backend::RelocKind::ArmCall
1448            } else {
1449                synth_core::backend::RelocKind::ThmCall
1450            };
1451            relocations.push(CodeRelocation {
1452                offset: code.len() as u32,
1453                symbol: label.clone(),
1454                kind,
1455            });
1456        }
1457        // #237: symbol-relative MOVW/MOVT (the `--native-pointer-abi` static-data
1458        // addressing). The encoder writes the addend in place; record the matching
1459        // R_ARM_MOVW_ABS_NC / R_ARM_MOVT_ABS so the linker adds the symbol address.
1460        if let ArmOp::MovwSym { symbol, .. } = &instr.op {
1461            relocations.push(CodeRelocation {
1462                offset: code.len() as u32,
1463                symbol: symbol.clone(),
1464                kind: synth_core::backend::RelocKind::MovwAbs,
1465            });
1466        }
1467        if let ArmOp::MovtSym { symbol, .. } = &instr.op {
1468            relocations.push(CodeRelocation {
1469                offset: code.len() as u32,
1470                symbol: symbol.clone(),
1471                kind: synth_core::backend::RelocKind::MovtAbs,
1472            });
1473        }
1474        // #345: defer the literal-pool word + reloc + offset patch to the
1475        // post-loop pass (the pool address is not yet known).
1476        if let ArmOp::LdrSym { symbol, addend, .. } = &instr.op {
1477            pending_literals.push(PendingLiteral {
1478                ldr_offset: code.len() as u32,
1479                symbol: symbol.clone(),
1480                addend: *addend,
1481            });
1482        }
1483
1484        // The machine offset of this instruction is the current code length,
1485        // captured before the bytes are appended.
1486        line_map.push((code.len() as u32, instr.source_line));
1487        branch_map.push((code.len() as u32, classify_arm_branch(&instr.op)));
1488
1489        let encoded = encoder
1490            .encode(&instr.op)
1491            .map_err(|e| format!("ARM encoding failed: {}", e))?;
1492        code.extend_from_slice(&encoded);
1493    }
1494
1495    // #345: place the literal pool at the end of this function's `.text`. Gated on
1496    // there being at least one `LdrSym` — functions without one are byte-identical
1497    // to before (no trailing padding, so downstream `func_offsets` are unchanged
1498    // and the frozen differential fixtures stay bit-for-bit equal).
1499    if !pending_literals.is_empty() {
1500        if !use_thumb2 {
1501            return Err("LdrSym literal-pool addressing requires Thumb-2".to_string());
1502        }
1503        // 4-byte align the pool start (Thumb-2 word loads require it, and
1504        // `Align(PC,4)` in the LDR-literal semantics assumes a word-aligned pool).
1505        while code.len() % 4 != 0 {
1506            code.push(0x00);
1507        }
1508        // One distinct pooled word per LdrSym (no dedup: different sites carry
1509        // different addends, and the REL addend lives in the word).
1510        for lit in &pending_literals {
1511            let word_offset = code.len() as u32;
1512
1513            // REL semantics: the linker computes `S + A`, where A is the in-place
1514            // value of the relocated word. Initialize the word to the addend so
1515            // the final loaded address is `symbol + addend`.
1516            code.extend_from_slice(&(lit.addend as u32).to_le_bytes());
1517            relocations.push(CodeRelocation {
1518                offset: word_offset,
1519                symbol: lit.symbol.clone(),
1520                kind: synth_core::backend::RelocKind::Abs32,
1521            });
1522
1523            // Patch the placeholder `LDR.W rd,[pc,#imm12]`. Thumb-2 LDR (literal):
1524            // address = Align(PC,4) + imm12, with PC = ldr_offset + 4. The pool is
1525            // always after the LDR, so U=1 (already set in hw1 = 0xF8DF).
1526            let pc = lit.ldr_offset + 4;
1527            let aligned_pc = pc & !3u32;
1528            let imm12 = word_offset - aligned_pc;
1529            if imm12 > 0xFFF {
1530                // Wide LDR-literal range is ±4 KB; these function bodies are far
1531                // smaller, but fail cleanly rather than miscompile if exceeded.
1532                return Err(format!(
1533                    "LdrSym literal pool out of range (#345): imm12={} > 4095 \
1534                     for symbol {}",
1535                    imm12, lit.symbol
1536                ));
1537            }
1538            let hw2_off = (lit.ldr_offset + 2) as usize;
1539            let mut hw2 = u16::from_le_bytes([code[hw2_off], code[hw2_off + 1]]);
1540            hw2 = (hw2 & 0xF000) | (imm12 as u16); // keep Rt, set imm12
1541            let hw2_bytes = hw2.to_le_bytes();
1542            code[hw2_off] = hw2_bytes[0];
1543            code[hw2_off + 1] = hw2_bytes[1];
1544        }
1545    }
1546
1547    Ok((
1548        code,
1549        relocations,
1550        line_map,
1551        branch_map,
1552        final_instrs_for_wcet,
1553    ))
1554}
1555
1556/// RQ-60-RACOST increment 2 (#242): every rewrite pass between a CHOSEN
1557/// register allocation and the encoder, as ONE reusable sequence.
1558///
1559/// Extracted VERBATIM from `compile_wasm_to_arm` (pure code motion) so the
1560/// `SYNTH_GRAPH_ALLOC` final-byte arbiter can size a candidate allocation
1561/// through the REAL downstream pipeline — the same passes, in the same order,
1562/// reading the same flags — rather than through a hand-mirrored predicate of
1563/// them (the #936 drift class: a hand mirror of the encoder's offset-fold
1564/// threshold was UNSOUND at authoring; a hand mirror of eleven rewrite passes
1565/// would be worse). Flag-off behaviour is byte-identical: the shipping path
1566/// calls this exactly once, on the same stream, in the same place it always
1567/// ran.
1568///
1569/// `ran_realloc` selects the historical branch: the dead-frame /
1570/// callee-saved-prologue / shrink trio runs only downstream of the range
1571/// re-allocation lever (`SYNTH_RANGE_REALLOC` on), exactly as before the
1572/// extraction. Diagnostics inside (SYNTH_FUSE_STATS, SYNTH_SHADOW_ALLOC,
1573/// SYNTH_SPILL_REPORT) print once per CALL, so an arbiter sizing run repeats
1574/// them — measurement noise under two opt-in flags, never a byte change.
1575fn finish_allocated_stream(
1576    arm_instrs: Vec<synth_synthesis::ArmInstruction>,
1577    config: &CompileConfig,
1578    post_exhaust: bool,
1579    ran_realloc: bool,
1580) -> Result<Vec<synth_synthesis::ArmInstruction>, String> {
1581    let arm_instrs = if ran_realloc {
1582        let out = arm_instrs;
1583        // VCR-RA-002 (#390, epic #242): eliminate a provably-dead stack frame
1584        // (`sub sp,#N`/`add sp,#N` reserved by `compute_local_layout` for locals
1585        // that promotion homed in registers, never accessed). Removing it saves
1586        // the two instructions AND restores the SP-untouched precondition that
1587        // `shrink_callee_saved_saves` requires — so it must run FIRST.
1588        // DEFAULT-ON (#242 flag audit flip-wave, #592 audit item): evidence
1589        // basis was the 2-path × repro-corpus sweep — 0 functions grow, 58
1590        // shrink (flight_seam controller_step 250→242 −8 / filter_step 180→168
1591        // −12, native_pointer frame_roundtrip 46→34 −12), locked by the
1592        // `dead_frame_elim_no_grow_corpus_242` cargo gate; execution
1593        // differentials re-run green on the new default bytes BEFORE the
1594        // frozen ARM anchors were re-pinned (leaf_dead_frame, flight_seam,
1595        // frame_slot_dce — see the flip PR). Escape hatch:
1596        // `SYNTH_DEAD_FRAME_ELIM=0` opts out and restores the pre-flip bytes
1597        // (CI-gated in `frozen_codegen_bytes.rs`).
1598        let out = if !std::env::var("SYNTH_DEAD_FRAME_ELIM").is_ok_and(|v| v == "0") {
1599            synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out)
1600        } else {
1601            out
1602        };
1603        // #490 (epic #242): the optimized selector uses r4-r8 as scratch /
1604        // promoted locals but emits no prologue, silently clobbering a caller's
1605        // callee-saved registers. Add the missing `push {r4-r8,lr}` /
1606        // `pop {r4-r8,pc}` HERE — on the post-realloc body, where realloc has
1607        // lowered low-pressure r4-r8 scratch back to r0-r3, so a save is added
1608        // only for registers genuinely clobbered. `shrink_callee_saved_saves`
1609        // (next) then trims it to the used set. No-op on the direct path (it
1610        // already has its own prologue) and on callee-saved-free leaves.
1611        let out = synth_synthesis::liveness::ensure_callee_saved_prologue(&out);
1612        synth_synthesis::liveness::shrink_callee_saved_saves(&out).unwrap_or(out)
1613    } else {
1614        // Range-realloc off (`SYNTH_RANGE_REALLOC=0`): the optimized path still
1615        // must preserve the callee-saved registers it clobbers (#490). No shrink
1616        // (it is coupled to the realloc lever), so the conservative full save
1617        // stays — correct, just not minimised in this debug configuration.
1618        synth_synthesis::liveness::ensure_callee_saved_prologue(&arm_instrs)
1619    };
1620    // VCR-RA-001 SHADOW ALLOCATION (#209/#242): run the register allocator on
1621    // the selected stream and LOG what it finds — without changing a single
1622    // emitted byte. This is the measure-only bridge between the built analysis
1623    // layer and the eventual virtual-register wiring: it shows, per real
1624    // function, whether the allocator can colour it within the R0–R8 pool and
1625    // how much const-CSE / rematerialization headroom exists (#209). Enable with
1626    // `SYNTH_SHADOW_ALLOC=1`; off by default and side-effect-free either way.
1627    if std::env::var("SYNTH_SHADOW_ALLOC").is_ok() {
1628        use synth_synthesis::liveness::{
1629            AllocationOutcome, allocate_function, function_peak_pressure,
1630        };
1631        // R9 globals / R10 mem-size / R11 mem-base / R12 IP-scratch are reserved;
1632        // pin them above the 0..9 allocatable pool so the colourer keeps R0–R8.
1633        let precolored = std::collections::BTreeMap::from([
1634            (synth_synthesis::rules::Reg::R9, 9usize),
1635            (synth_synthesis::rules::Reg::R10, 10),
1636            (synth_synthesis::rules::Reg::R11, 11),
1637            (synth_synthesis::rules::Reg::R12, 12),
1638        ]);
1639        // True VALUE pressure (one node per value, not per reused physical reg):
1640        // a NeedsSpill with peak ≤ 9 is a SPURIOUS physical-register spill — the
1641        // function fits once virtually allocated.
1642        let peak = function_peak_pressure(&arm_instrs);
1643        match allocate_function(&arm_instrs, 9, &precolored) {
1644            AllocationOutcome::Allocated {
1645                remat_opportunities,
1646                coloring,
1647            } => eprintln!(
1648                "[shadow-alloc] OK: {} pregs coloured within R0-R8 pool, peak value-pressure {}, {} const-CSE/remat opportunities",
1649                coloring.len(),
1650                peak,
1651                remat_opportunities
1652            ),
1653            AllocationOutcome::NeedsSpill(s) => eprintln!(
1654                "[shadow-alloc] physical-graph would spill {:?}, but peak value-pressure is {} (≤9 ⇒ spurious; fits once virtually allocated)",
1655                s, peak
1656            ),
1657            AllocationOutcome::Declined => {
1658                eprintln!(
1659                    "[shadow-alloc] declined (unmodeled construct — calls/i64/fp/offset-branch)"
1660                )
1661            }
1662        }
1663    }
1664
1665    // VCR-SEL-004 cmp→select → IT-block predication fusion (#242). The selector
1666    // lowers a `select` whose condition is a comparison to a *materialize then
1667    // re-test* sequence (`cmp a,b; SetCond D,c; cmp D,#0; movne dst,v1; moveq
1668    // dst,v2`); this collapses it onto the comparison's own flags — deleting the
1669    // `SetCond` and the `cmp D,#0` and retargeting the predicated moves to `c` /
1670    // `invert(c)` — yielding the textbook predicated clamp (`cmp a,b; movc dst,v1;
1671    // mov{!c} dst,v2`). −2 instructions per fused select. gale #428 measured this
1672    // as the #1 hot-path size/cycle lever on the gust_mix clamp chain.
1673    //
1674    // Run LATE: after range re-allocation (so the dead-D proof sees final register
1675    // identities) and before encode. Removal-only + rename-only ⇒ no spill
1676    // regression and labels/branch offsets are unaffected. Each fusion is proven
1677    // sound (flags reused only when nothing clobbers them in the window; the
1678    // boolean deleted only when provably dead) — see `fuse_cmp_select`.
1679    //
1680    // DEFAULT-ON as of v0.13.0 (#428): cmp→select fusion ships by default. The
1681    // byte-changing flip is validated by (a) the unicorn execution oracle that runs
1682    // the two-move `mov{invert(c)}` arm (cmp_select_two_move_differential.py), (b)
1683    // gale's gale_decider_diff 10,596-case sweep across all 8 verified primitives
1684    // (native ≡ flag-off ≡ flag-on = 0x88e73178d232bcf5), and (c) the named-anchor
1685    // differentials re-run with fusion ON — control_step still 0x00210A55, flat+
1686    // inlined flight_algo still 0x07FDF307 (results preserved; bytes deliberately
1687    // changed, re-frozen on this commit). Escape hatch: `SYNTH_NO_CMP_SELECT_FUSE=1`
1688    // reverts to the pre-fusion lowering. The on-silicon G474RE DWT no-regression
1689    // check is a tracked post-ship follow-up (gale owns it).
1690    let arm_instrs = if std::env::var("SYNTH_NO_CMP_SELECT_FUSE").is_err() {
1691        // The rewritten stream is identical to `fuse_cmp_select`'s 2-tuple form;
1692        // the extra `two_move` count is diagnostic only (the fusion census /
1693        // blast-radius datum — #7 made that arm reachable).
1694        let (out, fused, two_move) =
1695            synth_synthesis::liveness::fuse_cmp_select_with_stats(&arm_instrs);
1696        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1697            let in_place = fused - two_move;
1698            eprintln!(
1699                "[cmp-select-fuse] {fused} select(s) fused to predicated moves \
1700                 ({two_move} two-move, {in_place} in-place)"
1701            );
1702        }
1703        out
1704    } else {
1705        arm_instrs
1706    };
1707
1708    // Perf lever 1 toward native parity (#390): redundant stack-reload elimination.
1709    // synth lowers every wasm local to a frame slot, so `local.set; local.get` emits
1710    // `str rX,[sp,#N]; … ; ldr rY,[sp,#N]`; when rX still holds the value the reload
1711    // (a ~2-cycle M4 load) becomes `mov rY,rX`. Removal-of-a-load + rename only ⇒ no
1712    // new instruction form and no label/offset change. DEFAULT-ON (#242 feature
1713    // loop): validated bit-identical RESULTS on every frozen anchor (control_step
1714    // 0x00210A55 13/13, flat+inlined flight_algo 0x07FDF307) with .text reduced on
1715    // the shipped --relocatable path, plus 8 unit tests + the frame_slot_dce
1716    // execution differential — the same gated path cmp→select took to default-on in
1717    // v0.13.0 (G474RE silicon confirms perf post-ship). Escape hatch:
1718    // `SYNTH_NO_STACK_FWD=1` restores the frame-resident bytes (frozen-old goldens).
1719    let stack_fwd = std::env::var("SYNTH_NO_STACK_FWD").is_err();
1720    let arm_instrs = if stack_fwd {
1721        let (out, fwd) = synth_synthesis::liveness::forward_stack_reloads(&arm_instrs);
1722        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1723            eprintln!("[stack-fwd] {fwd} stack reload(s) forwarded to register moves");
1724        }
1725        out
1726    } else {
1727        arm_instrs
1728    };
1729
1730    // VCR-RA frame-slot DCE (#242): once `forward_stack_reloads` has turned the
1731    // reloads of a spill slot into register moves, the `str rX,[sp,#N]` that fed
1732    // them is a dead store — its slot is never loaded again. Remove it. Pairs
1733    // with (and only pays after) stack-reload forwarding, so it shares the flag.
1734    let arm_instrs = if stack_fwd {
1735        let (out, n) = synth_synthesis::liveness::eliminate_dead_frame_stores(&arm_instrs);
1736        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1737            eprintln!("[frame-slot-dce] {n} dead frame store(s) removed");
1738        }
1739        out
1740    } else {
1741        arm_instrs
1742    };
1743
1744    // VCR-RA-001 spill re-choice (#242), two stages behind one flag.
1745    // Stage 1 (the #569 spike): slot-value forwarding BETWEEN reloads.
1746    // `forward_stack_reloads` (above) forwards only from a spill store's
1747    // SOURCE register, so when register pressure clobbers that source its
1748    // reloads survive; this stage tracks which registers provably still hold
1749    // a frame slot's value (through earlier reloads and reg-reg moves) and
1750    // turns reload #2..#n into a 1-cycle `mov` (or deletes it when the target
1751    // already holds the value). Stage 2 (the Belady re-choice): where NO
1752    // register still holds the value — the genuine-spill case, flat_flight's
1753    // peak-11 hot segment — the value was usually evicted while a dead
1754    // register existed; the clobbering def(s) are renamed onto a provably-dead
1755    // register (`spill_rechoice_segment`) so the value stays resident and the
1756    // reload dissolves outright. A dissolved reload can leave the feeding
1757    // store dead, so the frame-slot DCE sweep runs once more behind the same
1758    // flag. Per-segment commit gates: executable same-value-flow trace
1759    // equality, strict shrink, pool-pressure fit, sub-word/unknown-slot
1760    // conservatism (see `apply_spill_realloc` / `spill_rechoice_segment`).
1761    // Stage 3 (whole-function slot liveness): the segment-local DCE keeps a
1762    // store whose slot reaches function end ("reach-end ≠ dead" — it cannot
1763    // see other segments); `eliminate_unread_frame_stores` walks the whole
1764    // function (labels/branches/loops, SP-displacement tracked) and drops a
1765    // store whose slot NO reachable instruction can read — flat_flight's two
1766    // surviving stores (#576), completing Belady's 0-load side with a 0-store
1767    // side. Same flag: the three stages are one lever, flipped together.
1768    // DEFAULT-ON (#242 feature loop, the v0.14.0 local-promotion pattern):
1769    // Belady spilling ships by default. Evidence basis for the flip: three
1770    // landed flag-off increments (#569 forwarding, #576 Belady re-choice,
1771    // #579 whole-fn slot liveness), 40+ functions shrink / 0 grow across the
1772    // 68-fixture × 2-path sweep, per-segment executable value-trace equality
1773    // guards, and the unicorn-vs-wasmtime execution differentials re-run
1774    // green on the new default bytes (flat+inlined flight_algo 0x07FDF307,
1775    // const_cse, frame_slot_dce, spill_rung_581, r12_spill_496 — which covers
1776    // control_step_decide vs wasmtime; control_step's .text is byte-identical
1777    // under the flip) BEFORE the frozen goldens were re-pinned. Escape hatch:
1778    // `SYNTH_SPILL_REALLOC=0` is the OPT-OUT — it disables all three stages
1779    // and restores the pre-flip bytes (CI-gated by
1780    // `frozen_fixtures_spill_realloc_escape_hatch_restores_old_bytes`). Any
1781    // other value (or unset) runs the pass.
1782    // VCR-VER-001 post-exhaustion extensions (#242, the PR #659 verdict): with
1783    // `SYNTH_SPILL_ON_EXHAUST` active the #580 allocation-time Belady spill
1784    // keeps exhausted functions on the optimized path, and its slots present
1785    // shapes the shipping pass structurally cannot fire on (fresh-monotonic
1786    // slots defeat the overwrite-only DCE; the eviction store's source is
1787    // redefined immediately, defeating store→reload forwarding; R2/R3 are
1788    // never touched again, so the rename-target deadness proof declines them).
1789    // `post_exhaust` (bridge-scoped, see above) enables const
1790    // rematerialization of spilled constants, R2/R3 exit-dead rename targets,
1791    // and per-pair pressure commit — see `apply_spill_realloc_post_exhaust`.
1792    // Flag off (the default): `false` selects the shipping behavior bit for
1793    // bit.
1794    let arm_instrs = if !std::env::var("SYNTH_SPILL_REALLOC").is_ok_and(|v| v == "0") {
1795        let (out, n) =
1796            synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&arm_instrs, post_exhaust);
1797        let (out, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&out);
1798        let (mut out, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&out);
1799        let (mut tn, mut td, mut tu) = (n, d, u);
1800        // Post-exhaustion only: iterate the triple to a bounded fixpoint. Each
1801        // dissolved spill pair frees registers and removes stores, exposing
1802        // rename windows and holder chains the previous iteration could not
1803        // prove — the allocation-time Belady slots (#580) routinely need two
1804        // or three rounds where the shipping single round suffices for the
1805        // default path's slots. Every iteration is individually gate-proven
1806        // (value-trace equality, pool pressure, strict shrink), so iterating
1807        // composes soundly; the bound keeps compile time deterministic.
1808        if post_exhaust {
1809            let mut progress = n + d + u > 0;
1810            for _ in 0..3 {
1811                if !progress {
1812                    break;
1813                }
1814                let (o, n) =
1815                    synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&out, true);
1816                let (o, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&o);
1817                let (o, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&o);
1818                progress = n + d + u > 0;
1819                (tn, td, tu) = (tn + n, td + d, tu + u);
1820                out = o;
1821            }
1822            // The cleanup can leave the spill frame with zero surviving
1823            // accesses (every reload rematerialized/dissolved, every store
1824            // swept) — the balanced `sub sp,#K`/`add sp,#K` is then pure
1825            // overhead. `elide_dead_frame` proves that and removes the pair;
1826            // its early run (post-realloc) could not, because the spill
1827            // traffic was still in the stream at that point.
1828            out = synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out);
1829        }
1830        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1831            eprintln!(
1832                "[spill-realloc] {tn} reload(s) forwarded/eliminated, {td} newly-dead frame store(s) removed, {tu} unread-slot store(s) removed"
1833            );
1834        }
1835        out
1836    } else {
1837        arm_instrs
1838    };
1839
1840    // VCR-RA immediate-shift folding (#390, #242): a constant shift amount the
1841    // stack selector materialized into a scratch register (`movw rM,#C; lsl rD,rN,rM`)
1842    // folds to the immediate form (`lsl rD,rN,#C`), removing the dead `movw` — −1
1843    // instruction, −1 live register. Removal-only (offset-neutral before branch
1844    // resolution, like the dead-store pass). DEFAULT-ON as of v0.15.0: validated
1845    // bit-identical results + a net cycle win on the dissolved hot path (−2
1846    // cyc/call, .text 100→90 B on gust_mix). Escape hatch: `SYNTH_NO_IMM_SHIFT_FOLD=1`.
1847    let arm_instrs = if std::env::var("SYNTH_NO_IMM_SHIFT_FOLD").is_err() {
1848        let (out, folds) = synth_synthesis::liveness::fold_immediate_shifts(&arm_instrs);
1849        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1850            eprintln!(
1851                "[imm-shift-fold] {folds} register shift(s) folded to immediate, movw dropped"
1852            );
1853        }
1854        out
1855    } else {
1856        arm_instrs
1857    };
1858
1859    // #686: elide the #682 mod-32 shift-amount mask (`and r12,rK,#31` before
1860    // every register-controlled i32 shl/shr) when the amount is STATICALLY
1861    // provable < 32 — a const amount folds to the immediate-shift form
1862    // (reduced mod 32, so >= 32 shrinks too), and an already-masked amount
1863    // (`rK = rX & c`, c < 32) drops the redundant re-mask. gale measured the
1864    // unconditional mask at ~12% cyc/call (+14 B) on gust_mix, whose Q8
1865    // fixed-point shifts are all constants (#686). The mask stays wherever
1866    // the bound is unproven — elision is an optimization, the mask is the
1867    // sound default (`liveness::elide_shift_masks` has the proof
1868    // obligations). Runs after `fold_immediate_shifts` (whose movw→shift
1869    // window the #682 mask intercepts, so it declines every masked const
1870    // shift) and before branch resolution (removal/rewrite-only ⇒
1871    // offset-neutral).
1872    //
1873    // DEFAULT-ON since v0.50.1 (opt-out via `SYNTH_SHIFT_MASK_ELIDE=0`; #846).
1874    // gale's gpio-thin driver regressed +44 B / +9% on synth 0.49 — its pin
1875    // bit-arithmetic (`pin & 31` then a register shift) emits the source
1876    // `and rN,#0x1f` IMMEDIATELY followed by the #682 mod-32 re-mask
1877    // `and r12,rN,#0x1f`; the second is provably redundant (Pattern B: an
1878    // operand produced by `and X,#c`, c<32, is already in [0,31]), so the
1879    // pass drops it. Flipping default-on is a deliberate byte-changing
1880    // refreeze: the elision also moves the frozen anchors (const-amount
1881    // shifts fold back to the immediate form) — control_step −20 B,
1882    // flight_seam −166 B, flight_seam_flat −168 B — all size DECREASES with
1883    // the mask soundly kept for every unproven amount. All differentials were
1884    // re-run on the new bytes and the goldens re-pinned (see #846 PR /
1885    // `frozen_codegen_bytes.rs`). `SYNTH_SHIFT_MASK_ELIDE=0` restores the
1886    // pre-flip bytes (opt-out gate in `shift_mask_elide_686.rs`).
1887    let arm_instrs = if std::env::var("SYNTH_SHIFT_MASK_ELIDE").is_ok_and(|v| v == "0") {
1888        arm_instrs
1889    } else {
1890        let (out, elisions) = synth_synthesis::liveness::elide_shift_masks(&arm_instrs);
1891        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1892            eprintln!(
1893                "[shift-mask-elide] {elisions} provably-<32 shift-amount mask(s) elided (#686)"
1894            );
1895        }
1896        out
1897    };
1898
1899    // VCR-RA uxth/uxtb fold (#428, #242): `movw rM,#0xffff; and rD,rN,rM` →
1900    // `uxth rD,rN` (and the 0xff/uxtb form), removing the dead `movw` — −1
1901    // instruction, −1 live register per 16/8-bit mask. 0xffff/0xff are not Thumb-2
1902    // modified immediates so the selector materializes them into a register; the
1903    // dedicated zero-extend expresses the same masking inline. Removal-only +
1904    // rewrite-in-place (offset-neutral). DEFAULT-ON (#242 flag audit flip-wave,
1905    // #592 audit item): evidence basis was the 2-path × repro-corpus sweep —
1906    // 0 functions grow, 13 shrink (control_step 300→294 −6, gust_mix 38→32 −6,
1907    // uxth_fold pack 36→24 −12), locked by the `uxth_fold_no_grow_corpus_242`
1908    // cargo gate; execution differentials re-run green on the new default
1909    // bytes BEFORE the frozen ARM anchors were re-pinned (uxth_fold,
1910    // control_step — see the flip PR). Escape hatch: `SYNTH_UXTH_FOLD=0` opts
1911    // out and restores the pre-flip bytes (CI-gated in
1912    // `frozen_codegen_bytes.rs`).
1913    let arm_instrs = if !std::env::var("SYNTH_UXTH_FOLD").is_ok_and(|v| v == "0") {
1914        let (out, folds) = synth_synthesis::liveness::fold_uxth(&arm_instrs);
1915        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1916            eprintln!("[uxth-fold] {folds} mask-and folded to uxth/uxtb, movw dropped");
1917        }
1918        out
1919    } else {
1920        arm_instrs
1921    };
1922
1923    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209, #242). Drops a
1924    // `movw`/`mov #imm` that re-materializes a constant already resident in
1925    // another register and retargets the reads — every rewrite proven by the
1926    // liveness analysis. Runs LAST, after every immediate-fold (shift, uxth) and
1927    // range-realloc, but BEFORE branch resolution/encoding (it removes
1928    // instructions, shifting byte offsets). CSE-last is the #242 no-regression
1929    // fix: the folds have already absorbed every foldable constant, so CSE can no
1930    // longer defeat one (the gust_mix 90→92 mechanism). The pass additionally
1931    // size-guards each segment via the byte-estimator — it commits a segment's
1932    // rewrites only if they do not grow its estimated size — so a retarget that
1933    // would flip a 16-bit encoding to 32-bit (higher base register) is declined.
1934    // DEFAULT-ON (#242 flip-wave, the SYNTH_SPILL_REALLOC/SYNTH_BASE_CSE
1935    // template): const-CSE ships by default. The flip prerequisites recorded in
1936    // `const_cse_reduction_242.rs` were retired first — the bridge-level INLINE
1937    // aliasing (the alias-eviction spill-bijection hazard) was DELETED from
1938    // `optimizer_bridge::ir_to_arm`, so this post-hoc, liveness-proven pass is
1939    // the flag's ONLY effect. Evidence basis: 152 fixture×path corpus sweep — 0
1940    // functions grow (size-guarded per segment), 40 shrink (const_cse::spill12
1941    // 236→148 B), total −536 B — and the execution differentials re-run green
1942    // on the new default bytes BEFORE the frozen goldens were re-pinned
1943    // (const_cse, frame_slot_dce, flight_seam 0x07FDF307, spill_rung_581,
1944    // volatile_segment_543, control_step 0x00210A55). Escape hatch:
1945    // `SYNTH_CONST_CSE=0` is the OPT-OUT — it restores the pre-flip bytes
1946    // (CI-gated by `const_cse_escape_hatch_restores_old_bytes_242` and the
1947    // frozen-anchor escape-hatch gate). Any other value (or unset) runs the pass.
1948    //
1949    // #543 Phase 2: const-CSE declines WHOLESALE while any volatile DMA range
1950    // (`--volatile-segment`) is marked. At the ArmOp level a cached constant
1951    // cannot be classified as address-vs-data (a retargeted read may be a
1952    // memory-access base carrying a per-use immediate offset), so the
1953    // conservative stance for statically-unknown addressing is to decline every
1954    // aliasing rewrite — each constant is re-materialized at each occurrence,
1955    // the documented volatile contract (`CompileConfig::volatile_segments`).
1956    let arm_instrs = if !std::env::var("SYNTH_CONST_CSE").is_ok_and(|v| v == "0")
1957        && config.volatile_segments.is_empty()
1958    {
1959        let (out, removed) = synth_synthesis::liveness::apply_const_cse(&arm_instrs);
1960        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1961            eprintln!("[const-cse] {removed} redundant constant materialization(s) removed");
1962        }
1963        out
1964    } else {
1965        arm_instrs
1966    };
1967
1968    // VCR-RA-001 spill-choice REPORT (#242): measure-only, like SYNTH_SHADOW_ALLOC.
1969    // Per straight-line segment, the frame-slot traffic actually emitted vs the
1970    // reload/store count a farthest-next-use (Belady) allocation over the R0-R8
1971    // pool would need — the measured headroom for the full spill-choice rewrite.
1972    // Printed on the FINAL stream (post all rewrite passes), so a flag-off run
1973    // reports the greedy baseline and a flag-on run reports what remains.
1974    if std::env::var("SYNTH_SPILL_REPORT").is_ok() {
1975        for seg in synth_synthesis::liveness::spill_choice_report(&arm_instrs, 9) {
1976            if seg.actual_reloads + seg.actual_spill_stores > 0 || seg.peak_pressure > 9 {
1977                eprintln!(
1978                    "[spill-report] seg@{} len={} peak={} actual={}ld+{}st belady(k=9)={}ld+{}st",
1979                    seg.start,
1980                    seg.len,
1981                    seg.peak_pressure,
1982                    seg.actual_reloads,
1983                    seg.actual_spill_stores,
1984                    seg.belady_reloads,
1985                    seg.belady_spill_stores
1986                );
1987            }
1988        }
1989    }
1990
1991    // ISA feature gate: validate that all generated instructions are supported
1992    // by the target. This catches FPU instructions on no-FPU targets, double-precision
1993    // instructions on single-precision targets, etc.
1994    validate_instructions(&arm_instrs, config.target.fpu, &config.target.triple)
1995        .map_err(|e| format!("ISA validation failed: {}", e))?;
1996
1997    // VCR-RA-003 (epic #242): UNCONDITIONAL per-compilation register-allocation
1998    // validation. The register allocator is the last major unverified codegen
1999    // component; this whole-function checker proves — by construction, on the
2000    // EXACT emitted stream about to be encoded — that the allocation preserves
2001    // FOUR invariants whose reference lives in the stream (or the ABI): (1)
2002    // callee-saved preservation (#490), (2) spill-slot non-aliasing (#331), and
2003    // — PHASE 2 (#49), extending past straight-line — (3) caller-saved
2004    // preservation across calls (a value in R2/R3/R12 live across a `bl` the
2005    // AAPCS boundary destroys), and (4) value availability across control-flow
2006    // joins (a live-in to a join must be defined on every incoming edge). It runs
2007    // on every ARM compile in the DEFAULT shipping build (NOT behind
2008    // `--features verify`; a verify-gated check would be dormant in exactly the
2009    // build that ships — the #757 / VCR-VER-003 lesson) and hard-errors the
2010    // compile on a VIOLATION. A `NotAttempted` verdict (the join check declines
2011    // on an unmodeled-CF function: numeric branch, `BrTable`, etc.) is NON-FATAL
2012    // — the compile proceeds; the other three invariants were still checked and
2013    // held. This is the decline>guess doctrine applied to the checker itself: it
2014    // never claims join coherence it cannot prove, but it also never blocks a
2015    // correct compile for a construct it simply doesn't model yet. Frozen-safe:
2016    // it emits nothing, so `.text` is byte-identical (proven by the frozen suite).
2017    match synth_synthesis::liveness::validate_final_allocation(&arm_instrs) {
2018        synth_synthesis::liveness::RaFinalVerdict::Violation(v) => {
2019            return Err(format!(
2020                "VCR-RA-003: register-allocation validation FAILED — {v:?}. \
2021                 The emitted stream violates a register-allocation invariant \
2022                 (callee-saved preservation #490 / spill-slot non-aliasing #331 \
2023                 / caller-saved-across-call / join-value-availability / the #881 \
2024                 VFP twins); this is a \
2025                 compiler bug, not a program error. Refusing to emit a \
2026                 miscompiled object."
2027            ));
2028        }
2029        // Loud honest decline (join reasoning skipped for an unmodeled-CF
2030        // function). Non-fatal — the straight-line / callee-saved / across-call
2031        // invariants still ran and held; only the across-JOIN availability
2032        // reasoning is skipped. Since the #819 redo the optimized path's
2033        // pre-resolved NUMERIC branches are modeled too (build_join_cfg_numeric
2034        // + the PRESERVED entry-availability discriminator), so this fires only
2035        // on genuinely unmodeled shapes: BrTable, computed Bx, mixed
2036        // label+numeric streams, off-boundary numeric targets.
2037        // Surfaced only under `SYNTH_RA003_VERBOSE` so a production compile stays
2038        // quiet: emitting it unconditionally would print on every branchy
2039        // optimized-path compile (new stderr noise phase 1 never produced), yet
2040        // it must remain observable on demand for the honest-scope audit.
2041        synth_synthesis::liveness::RaFinalVerdict::NotAttempted { reason } => {
2042            if std::env::var_os("SYNTH_RA003_VERBOSE").is_some() {
2043                eprintln!(
2044                    "VCR-RA-003: across-join validation NOT ATTEMPTED ({reason}) — \
2045                     straight-line / callee-saved / across-call invariants held; \
2046                     join-availability reasoning declined on this control-flow shape."
2047                );
2048            }
2049        }
2050        synth_synthesis::liveness::RaFinalVerdict::Consistent => {
2051            if std::env::var_os("SYNTH_RA003_VERBOSE").is_some() {
2052                eprintln!("VCR-RA-003: Consistent");
2053            }
2054        }
2055    }
2056    Ok(arm_instrs)
2057}
2058
2059/// VCR-DEC-003 (#396): classify one emitted `ArmOp` into its object-level
2060/// control-flow role for the `synth-provenance-v1` map. Conditional branches are
2061/// the object decision points MC/DC must reconcile; `SelectMove` is the folded
2062/// (IT-block) predicated form the cmp→select fuse produces — a decision with no
2063/// branch.
2064fn classify_arm_branch(op: &ArmOp) -> synth_core::backend::BranchClass {
2065    use synth_core::backend::BranchClass;
2066    match op {
2067        ArmOp::Bcc { .. } | ArmOp::Bhs { .. } | ArmOp::Blo { .. } | ArmOp::BCondOffset { .. } => {
2068            BranchClass::CondBranch
2069        }
2070        ArmOp::B { .. } | ArmOp::BOffset { .. } => BranchClass::UncondBranch,
2071        ArmOp::SelectMove { .. } => BranchClass::Predicated,
2072        _ => BranchClass::Other,
2073    }
2074}
2075
2076/// Resolve local label branches to byte-accurate offsets (#202).
2077///
2078/// `select_with_stack` emits conditional/unconditional branches as label
2079/// placeholders (`Bcc`/`B`/`Bhs`/`Blo` + `Label`) and never resolves them; the
2080/// encoder then emits a `0xD000`/`0xE000` placeholder with offset 0. Before #197
2081/// this path only ran for `--no-optimize`/declined functions, so the latent bug
2082/// stayed hidden — routing relocatable code through it surfaced branches that
2083/// land mid-instruction (a Cortex-M UsageFault) whenever a 32-bit Thumb-2
2084/// instruction sits between the branch and its target.
2085///
2086/// This pass encodes each instruction to learn its real byte length (so 16- vs
2087/// 32-bit forms and multi-instruction expansions are exact), maps each `Label`
2088/// to its byte position, and rewrites every label branch to the displacement
2089/// the encoder consumes: `(target - branch - 4) / 2` halfwords. A bounded
2090/// fixed-point handles an offset growing a branch from 16- to 32-bit (which
2091/// shifts later positions). `BCondOffset`/`BOffset` already produced inline by
2092/// the optimized path carry no label and are left untouched.
2093fn resolve_label_branches(
2094    arm_instrs: Vec<ArmInstruction>,
2095    encoder: &ArmEncoder,
2096) -> Result<Vec<ArmInstruction>, String> {
2097    use std::collections::HashMap;
2098    use synth_synthesis::Condition;
2099
2100    enum BKind {
2101        Cond(Condition),
2102        Uncond,
2103    }
2104    // Record each label branch ONCE — indices are stable across iterations.
2105    let mut branches: Vec<(usize, BKind, String)> = Vec::new();
2106    for (i, instr) in arm_instrs.iter().enumerate() {
2107        match &instr.op {
2108            ArmOp::Bcc { cond, label } => branches.push((i, BKind::Cond(*cond), label.clone())),
2109            ArmOp::Bhs { label } => branches.push((i, BKind::Cond(Condition::HS), label.clone())),
2110            ArmOp::Blo { label } => branches.push((i, BKind::Cond(Condition::LO), label.clone())),
2111            ArmOp::B { label } => branches.push((i, BKind::Uncond, label.clone())),
2112            _ => {}
2113        }
2114    }
2115    if branches.is_empty() {
2116        return Ok(arm_instrs);
2117    }
2118
2119    let mut resolved = arm_instrs;
2120    // Sizes only grow (16→32-bit), so this converges quickly; cap for safety.
2121    for _ in 0..16 {
2122        // 1. Byte position of each instruction (Label encodes to 0 bytes).
2123        let mut positions = Vec::with_capacity(resolved.len());
2124        let mut pos: i64 = 0;
2125        for instr in &resolved {
2126            positions.push(pos);
2127            pos += encoder
2128                .encode(&instr.op)
2129                .map_err(|e| format!("branch-resolve size probe failed: {}", e))?
2130                .len() as i64;
2131        }
2132        // 2. Label name -> byte position (owned keys so the borrow ends here).
2133        let mut labels: HashMap<String, i64> = HashMap::new();
2134        for (i, instr) in resolved.iter().enumerate() {
2135            if let ArmOp::Label { name } = &instr.op {
2136                labels.insert(name.clone(), positions[i]);
2137            }
2138        }
2139        // 3. Rewrite each branch to its byte-accurate offset.
2140        let mut changed = false;
2141        for (idx, kind, label) in &branches {
2142            // A label not defined locally is an EXTERNAL target (e.g.
2143            // `Trap_Handler` resolved by a relocation / the vector table). Leave
2144            // such branches as their placeholder for the existing relocation
2145            // path — only local control-flow labels are byte-resolved here.
2146            let Some(&target) = labels.get(label) else {
2147                continue;
2148            };
2149            // Encoder consumes the field as (target - branch - 4) / 2 halfwords.
2150            // Positions are always even, so this division is exact.
2151            let halfword_offset = ((target - positions[*idx] - 4) / 2) as i32;
2152            let new_op = match kind {
2153                BKind::Cond(c) => ArmOp::BCondOffset {
2154                    cond: *c,
2155                    offset: halfword_offset,
2156                },
2157                BKind::Uncond => ArmOp::BOffset {
2158                    offset: halfword_offset,
2159                },
2160            };
2161            if resolved[*idx].op != new_op {
2162                resolved[*idx].op = new_op;
2163                changed = true;
2164            }
2165        }
2166        if !changed {
2167            break;
2168        }
2169    }
2170    Ok(resolved)
2171}
2172
2173/// SC-5 branch-target boundary gate (#740, #930): every emitted branch target
2174/// must be a member of the instruction-start set of the final stream.
2175///
2176/// "Branch offset calculation shall account for Thumb instruction alignment
2177/// and variable instruction widths" (`safety/stpa/system-constraints.yaml`
2178/// SC-5). Thumb-2 mixes 16- and 32-bit encodings, so an off-by-one-halfword
2179/// target lands on the SECOND halfword of a wide instruction and the CPU
2180/// executes a halfword that was never an instruction — silent garbage, exit 0
2181/// (#930: the skipped `movw` left the `br_if` condition register at its reset
2182/// value). Both known escapes of that sentence were of this class: #740
2183/// (`B<cond>.W` T3 offset halved) and #930 (inner-block end label never
2184/// emitted, `b #0` placeholder). The encoder knows where every instruction
2185/// starts, so a target outside that set is a hard error here rather than
2186/// silent garbage on target.
2187///
2188/// Runs on the FINAL Thumb-2 stream for BOTH codegen paths — the direct
2189/// (`select_with_stack`, label branches byte-resolved above) and the optimized
2190/// (`optimizer_bridge`, numeric `BOffset`/`BCondOffset` pre-resolved inline) —
2191/// since both funnel through this encode pipeline. Two checks, jointly total
2192/// over local control flow:
2193///
2194/// 1. every numeric branch target is in the instruction-start set;
2195/// 2. no LOCAL (`.L`-prefixed) label branch survives unresolved — the resolver
2196///    deliberately skips labels it cannot find because an external target
2197///    (`Trap_Handler`, `func_N`) is legitimately absent and patched by
2198///    relocation, but a `.L` label is only ever defined in this same stream,
2199///    so an unresolved one is a dropped label (#930), not an external.
2200///
2201/// A32 (Cortex-R5) is fixed-width, so the mid-instruction class needs no gate
2202/// there (and its branches do not flow through the Thumb-2 resolver).
2203fn validate_branch_targets(instrs: &[ArmInstruction], encoder: &ArmEncoder) -> Result<(), String> {
2204    use std::collections::HashSet;
2205
2206    // Byte position of each element (`Label` encodes to 0 bytes, so a label's
2207    // position is exactly the start of the instruction that follows it).
2208    let mut positions = Vec::with_capacity(instrs.len());
2209    let mut pos: i64 = 0;
2210    for instr in instrs {
2211        positions.push(pos);
2212        pos += encoder
2213            .encode(&instr.op)
2214            .map_err(|e| format!("SC-5 branch-target gate: size probe failed: {}", e))?
2215            .len() as i64;
2216    }
2217    let starts: HashSet<i64> = positions.iter().copied().collect();
2218
2219    for (i, instr) in instrs.iter().enumerate() {
2220        let offset = match &instr.op {
2221            ArmOp::BOffset { offset } => *offset,
2222            ArmOp::BCondOffset { offset, .. } => *offset,
2223            ArmOp::B { label }
2224            | ArmOp::Bcc { label, .. }
2225            | ArmOp::Bhs { label }
2226            | ArmOp::Blo { label }
2227                if label.starts_with(".L") =>
2228            {
2229                return Err(format!(
2230                    "SC-5 branch-target gate: local branch label '{}' is not \
2231                     defined anywhere in the emitted stream (branch at byte \
2232                     offset 0x{:x}). A `.L` label is only ever defined locally, \
2233                     so this is a dropped label (the #930 class) — the branch \
2234                     would encode as a `b #0` placeholder and land \
2235                     mid-instruction. Refusing to emit a miscompiled object.",
2236                    label, positions[i]
2237                ));
2238            }
2239            _ => continue,
2240        };
2241        // Thumb branch semantics: target = branch_pc + 4 + 2*offset.
2242        let target = positions[i] + 4 + 2 * offset as i64;
2243        if !starts.contains(&target) {
2244            return Err(format!(
2245                "SC-5 branch-target gate: branch at byte offset 0x{:x} targets \
2246                 0x{:x}, which is not an instruction boundary (instruction-start \
2247                 set violation — the target lands mid-instruction, the \
2248                 #740/#930 class). Refusing to emit a miscompiled object.",
2249                positions[i], target
2250            ));
2251        }
2252    }
2253    Ok(())
2254}
2255
2256#[cfg(test)]
2257mod tests {
2258    use super::*;
2259    use synth_synthesis::{Operand2, Reg};
2260
2261    /// #539: `i32.const 0; memory.grow m` folds to `memory.size m`; other deltas
2262    /// (const non-zero, runtime) are left as `memory.grow` (→ the sound fixed-
2263    /// memory -1). Non-grow ops are untouched, so functions without the idiom are
2264    /// byte-identical.
2265    #[test]
2266    fn test_rewrite_memory_grow_zero_539() {
2267        // the idiom -> memory.size
2268        assert_eq!(
2269            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::MemoryGrow(0)]),
2270            vec![WasmOp::MemorySize(0)]
2271        );
2272        // const non-zero delta: NOT folded
2273        assert_eq!(
2274            rewrite_memory_grow_zero(&[WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]),
2275            vec![WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]
2276        );
2277        // runtime delta (no preceding const): NOT folded
2278        assert_eq!(
2279            rewrite_memory_grow_zero(&[WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]),
2280            vec![WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]
2281        );
2282        // a bare const-0 not feeding a grow is untouched
2283        assert_eq!(
2284            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::I32Add]),
2285            vec![WasmOp::I32Const(0), WasmOp::I32Add]
2286        );
2287        // fold is local: surrounding ops preserved, indices past the fold intact
2288        assert_eq!(
2289            rewrite_memory_grow_zero(&[
2290                WasmOp::LocalGet(0),
2291                WasmOp::I32Const(0),
2292                WasmOp::MemoryGrow(0),
2293                WasmOp::I32Add,
2294            ]),
2295            vec![WasmOp::LocalGet(0), WasmOp::MemorySize(0), WasmOp::I32Add]
2296        );
2297    }
2298
2299    /// SC-5 (#740/#930): the branch-target boundary gate. Every emitted branch
2300    /// target must be a member of the instruction-start set of the final
2301    /// Thumb-2 stream; a `.L`-local label branch surviving unresolved is a
2302    /// dropped label. Red-first: both rejection arms were written against the
2303    /// exact #930 stream shape (a `b #0` placeholder whose pc+4 target falls
2304    /// on the second halfword of a 32-bit `movw`) and fail without the gate.
2305    #[test]
2306    fn test_validate_branch_targets_sc5_930() {
2307        let enc = ArmEncoder::new_thumb2();
2308        let ins = |op: ArmOp| ArmInstruction {
2309            op,
2310            source_line: None,
2311        };
2312
2313        // 1. Boundary-valid stream: b over a wide movw onto the mov — OK.
2314        //    positions: 0 BOffset(2B), 2 Movw(4B), 6 Mov(2B)
2315        //    target = 0 + 4 + 2*1 = 6 = start of Mov.
2316        let good = vec![
2317            ins(ArmOp::BOffset { offset: 1 }),
2318            ins(ArmOp::Movw {
2319                rd: Reg::R3,
2320                imm16: 1,
2321            }),
2322            ins(ArmOp::Mov {
2323                rd: Reg::R0,
2324                op2: Operand2::Reg(Reg::R3),
2325            }),
2326        ];
2327        assert!(validate_branch_targets(&good, &enc).is_ok());
2328
2329        // 2. The exact #930 shape: `b #0` (offset 0) -> target = pc+4 = 4,
2330        //    the SECOND halfword of the 4-byte movw spanning 2..6. Hard error.
2331        let mid = vec![
2332            ins(ArmOp::BOffset { offset: 0 }),
2333            ins(ArmOp::Movw {
2334                rd: Reg::R3,
2335                imm16: 1,
2336            }),
2337            ins(ArmOp::Mov {
2338                rd: Reg::R0,
2339                op2: Operand2::Reg(Reg::R3),
2340            }),
2341        ];
2342        let err = validate_branch_targets(&mid, &enc).unwrap_err();
2343        assert!(err.contains("SC-5"), "boundary violation names SC-5: {err}");
2344        assert!(err.contains("not an instruction boundary"), "{err}");
2345
2346        // 3. Conditional form of the same violation.
2347        let mid_cond = vec![
2348            ins(ArmOp::BCondOffset {
2349                cond: synth_synthesis::Condition::NE,
2350                offset: 0,
2351            }),
2352            ins(ArmOp::Movw {
2353                rd: Reg::R3,
2354                imm16: 1,
2355            }),
2356            ins(ArmOp::Mov {
2357                rd: Reg::R0,
2358                op2: Operand2::Reg(Reg::R3),
2359            }),
2360        ];
2361        assert!(validate_branch_targets(&mid_cond, &enc).is_err());
2362
2363        // 4. A `.L`-local label branch that was never resolved (the dropped
2364        //    end label, #930's mechanism) is a hard error even though it
2365        //    would encode as a well-formed placeholder.
2366        let dropped = vec![
2367            ins(ArmOp::B {
2368                label: ".Lblock_end_3".to_string(),
2369            }),
2370            ins(ArmOp::Movw {
2371                rd: Reg::R3,
2372                imm16: 1,
2373            }),
2374        ];
2375        let err = validate_branch_targets(&dropped, &enc).unwrap_err();
2376        assert!(err.contains(".Lblock_end_3"), "{err}");
2377        assert!(err.contains("dropped label"), "{err}");
2378
2379        // 5. An EXTERNAL label branch (no `.L` prefix) is legitimately absent
2380        //    (patched via relocation / vector table) and must NOT trip the
2381        //    gate — the carve-out that used to swallow #930 stays for real
2382        //    externals only.
2383        let external = vec![
2384            ins(ArmOp::B {
2385                label: "Trap_Handler".to_string(),
2386            }),
2387            ins(ArmOp::Movw {
2388                rd: Reg::R3,
2389                imm16: 1,
2390            }),
2391        ];
2392        assert!(validate_branch_targets(&external, &enc).is_ok());
2393
2394        // 6. Labels are zero-width: a target on a Label position is the start
2395        //    of the instruction that follows it — OK.
2396        let labeled = vec![
2397            ins(ArmOp::BOffset { offset: 1 }),
2398            ins(ArmOp::Movw {
2399                rd: Reg::R3,
2400                imm16: 1,
2401            }),
2402            ins(ArmOp::Label {
2403                name: ".Lend".to_string(),
2404            }),
2405            ins(ArmOp::Mov {
2406                rd: Reg::R0,
2407                op2: Operand2::Reg(Reg::R3),
2408            }),
2409        ];
2410        assert!(validate_branch_targets(&labeled, &enc).is_ok());
2411    }
2412
2413    /// SC-5 (#930) end-to-end at the backend seam: the labels.wast `br_if2`
2414    /// shape — a `br_if` exiting an enclosing block from inside an `if`, its
2415    /// value operand a block-that-branches — must COMPILE (the pre-fix
2416    /// selector dropped the inner block's end label, which the SC-5 gate now
2417    /// turns into a hard error, so compile success proves the label was
2418    /// emitted) and every branch in the emitted bytes must land on an
2419    /// instruction boundary (re-derived from the encoded halfwords, not from
2420    /// the resolver's own bookkeeping).
2421    #[test]
2422    fn test_930_brif2_shape_compiles_and_targets_boundaries() {
2423        let backend = ArmBackend::new();
2424        let ops = vec![
2425            WasmOp::Block, // $l0 (result i32)
2426            WasmOp::I32Const(1),
2427            WasmOp::If,
2428            WasmOp::Block, // $l1 (result i32)
2429            WasmOp::I32Const(1),
2430            WasmOp::Br(0), // br $l1
2431            WasmOp::End,
2432            WasmOp::I32Const(1),
2433            WasmOp::BrIf(1), // br_if $l0
2434            WasmOp::Drop,
2435            WasmOp::End, // end if
2436            WasmOp::I32Const(0),
2437            WasmOp::End, // end $l0
2438            WasmOp::End,
2439        ];
2440        let config = CompileConfig::default();
2441        let func = backend
2442            .compile_function("t", &ops, &config)
2443            .expect("#930 shape must compile (SC-5 gate passes)");
2444
2445        // Walk the encoded halfwords: collect instruction starts, then check
2446        // every narrow/wide B / B<cond> target is a member.
2447        let code = &func.code;
2448        let mut starts = std::collections::HashSet::new();
2449        let mut widths = Vec::new();
2450        let mut off = 0usize;
2451        while off + 2 <= code.len() {
2452            starts.insert(off as i64);
2453            let hw = u16::from_le_bytes([code[off], code[off + 1]]);
2454            let wide = (hw & 0xF800) >= 0xE800; // 0b11101/0b11110/0b11111
2455            widths.push((off, hw, wide));
2456            off += if wide { 4 } else { 2 };
2457        }
2458        for (off, hw, wide) in widths {
2459            let target = if !wide && (hw & 0xF800) == 0xE000 {
2460                // T2 B: imm11, halfwords
2461                let imm = ((hw & 0x7FF) as i32) << 21 >> 21;
2462                Some(off as i64 + 4 + 2 * imm as i64)
2463            } else if !wide && (hw & 0xF000) == 0xD000 && (hw & 0x0F00) < 0x0E00 {
2464                // T1 B<cond>: imm8, halfwords
2465                let imm = ((hw & 0xFF) as i32) << 24 >> 24;
2466                Some(off as i64 + 4 + 2 * imm as i64)
2467            } else {
2468                None
2469            };
2470            if let Some(t) = target {
2471                assert!(
2472                    starts.contains(&t),
2473                    "branch at 0x{off:x} (hw 0x{hw:04x}) targets 0x{t:x}, \
2474                     not an instruction boundary — the #930 miscompile shape"
2475                );
2476            }
2477        }
2478    }
2479
2480    #[test]
2481    fn test_arm_backend_name() {
2482        let backend = ArmBackend::new();
2483        assert_eq!(backend.name(), "arm");
2484        assert!(backend.is_available());
2485    }
2486
2487    #[test]
2488    fn test_arm_backend_capabilities() {
2489        let backend = ArmBackend::new();
2490        let caps = backend.capabilities();
2491        assert!(!caps.produces_elf);
2492        assert!(caps.supports_rule_verification);
2493        assert!(!caps.is_external);
2494    }
2495
2496    #[test]
2497    fn test_compile_add_function() {
2498        let backend = ArmBackend::new();
2499        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
2500        let config = CompileConfig::default();
2501
2502        let result = backend.compile_function("add", &ops, &config);
2503        assert!(result.is_ok());
2504
2505        let func = result.unwrap();
2506        assert_eq!(func.name, "add");
2507        assert!(!func.code.is_empty());
2508        assert_eq!(func.wasm_ops, ops);
2509    }
2510
2511    /// VCR-DBG-001: the per-instruction source map must cover the function with
2512    /// monotonic, in-bounds machine offsets, and must not perturb the emitted
2513    /// code (it is captured at encode time, never serialized here).
2514    #[test]
2515    fn test_line_map_is_wellformed_dbg001() {
2516        let backend = ArmBackend::new();
2517        let ops = vec![
2518            WasmOp::LocalGet(0),
2519            WasmOp::LocalGet(1),
2520            WasmOp::I32Add,
2521            WasmOp::End,
2522        ];
2523        let config = CompileConfig::default();
2524        let func = backend.compile_function("add", &ops, &config).unwrap();
2525
2526        // Non-empty, and the first instruction starts at machine offset 0.
2527        assert!(
2528            !func.line_map.is_empty(),
2529            "a non-trivial function captures a source map"
2530        );
2531        assert_eq!(func.line_map[0].0, 0, "first instruction at offset 0");
2532
2533        // Offsets strictly increase by at least one ARM/Thumb instruction (>= 2
2534        // bytes) and every mapped offset lies inside the emitted `.text`.
2535        for w in func.line_map.windows(2) {
2536            assert!(w[1].0 > w[0].0, "instruction offsets strictly increase");
2537            assert!(
2538                w[1].0 - w[0].0 >= 2,
2539                "each ARM/Thumb instruction is >= 2 bytes"
2540            );
2541        }
2542        let last = func.line_map.last().unwrap().0 as usize;
2543        assert!(
2544            last < func.code.len(),
2545            "every mapped offset lies inside .text"
2546        );
2547
2548        // The side-table is additive: recompiling is deterministic and the map is
2549        // consistent with that exact code (capturing it does not alter output).
2550        let again = backend.compile_function("add", &ops, &config).unwrap();
2551        assert_eq!(
2552            again.code, func.code,
2553            "compilation deterministic; map is additive"
2554        );
2555        assert_eq!(again.line_map, func.line_map);
2556    }
2557
2558    #[test]
2559    fn test_count_params() {
2560        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
2561        assert_eq!(count_params(&ops), 2);
2562
2563        let no_params = vec![WasmOp::I32Const(5), WasmOp::I32Const(3), WasmOp::I32Add];
2564        assert_eq!(count_params(&no_params), 0);
2565    }
2566
2567    /// #457: the declared param count caps the access-pattern inference. The
2568    /// repro shape `(param i32)(local i32) → p0 + local1` reads local 1 before
2569    /// any write, so `count_params` infers 2 — with the declared count (1) the
2570    /// local is reclassified onto the zero-inited frame path instead of being
2571    /// read from R1 (caller garbage).
2572    #[test]
2573    fn declared_param_count_caps_inference_457() {
2574        let ops = vec![
2575            WasmOp::LocalGet(0),
2576            WasmOp::LocalGet(1),
2577            WasmOp::I32Add,
2578            WasmOp::End,
2579        ];
2580        // The inference alone still says 2 (the misclassification this caps).
2581        assert_eq!(count_params(&ops), 2);
2582
2583        let backend = ArmBackend::new();
2584        let inferred = backend
2585            .compile_function("rbw", &ops, &CompileConfig::default())
2586            .unwrap();
2587        let declared = backend
2588            .compile_function(
2589                "rbw",
2590                &ops,
2591                &CompileConfig {
2592                    current_func_param_count: Some(1),
2593                    ..CompileConfig::default()
2594                },
2595            )
2596            .unwrap();
2597        // The cap is consumed: the declared-count compile reclassifies local 1
2598        // and must emit different code than the param-misclassified one.
2599        assert_ne!(
2600            inferred.code, declared.code,
2601            "declared param count must reach the selector"
2602        );
2603        // The zero-init is present: a 16-bit Thumb `movs rN, #0`
2604        // (0x2000 | rd<<8 → LE bytes [0x00, 0x20+rd]) somewhere in the body.
2605        let has_movs_zero = declared
2606            .code
2607            .as_chunks::<2>()
2608            .0
2609            .iter()
2610            .any(|h| h[0] == 0x00 && (0x20..=0x27).contains(&h[1]));
2611        assert!(
2612            has_movs_zero,
2613            "declared-count compile must zero-init the read-before-write local; code: {:02x?}",
2614            declared.code
2615        );
2616        // A declared count that matches (or exceeds) the inference changes
2617        // nothing — byte-identity for every function without rbw locals.
2618        let matching = backend
2619            .compile_function(
2620                "rbw",
2621                &ops,
2622                &CompileConfig {
2623                    current_func_param_count: Some(2),
2624                    ..CompileConfig::default()
2625                },
2626            )
2627            .unwrap();
2628        assert_eq!(
2629            matching.code, inferred.code,
2630            "declared >= inferred must stay byte-identical"
2631        );
2632    }
2633
2634    /// #970: a CONDITIONALLY-written param must stay a param.
2635    ///
2636    /// The read-first heuristic sees `LocalSet(1)` before any `LocalGet(1)` in
2637    /// LINEAR op order and demotes index 1 — even though the `if` means the
2638    /// write may not execute at all. `min(referenced, declared)` keeps it.
2639    /// The RED symptom this pins is not a wrong constant: the demoted local's
2640    /// first access is a WRITE, so the #457 zero-init skips it and the
2641    /// fall-through arm reads an UNINITIALISED frame slot (executed evidence:
2642    /// `scripts/repro/cond_write_param_970_arm_differential.py`).
2643    #[test]
2644    fn conditionally_written_param_stays_a_param_970() {
2645        // (param i32 i32): if (local.get 0) { local.set 1 = 5 }; local.get 1
2646        let ops = vec![
2647            WasmOp::LocalGet(0),
2648            WasmOp::If,
2649            WasmOp::I32Const(5),
2650            WasmOp::LocalSet(1),
2651            WasmOp::End,
2652            WasmOp::LocalGet(1),
2653            WasmOp::End,
2654        ];
2655        let declared = CompileConfig {
2656            current_func_param_count: Some(2),
2657            ..CompileConfig::default()
2658        };
2659        // The old rule: index 1 is written before it is read, so it is not
2660        // counted — this is the undercount that produced the miscompile.
2661        assert_eq!(
2662            count_params(&ops),
2663            1,
2664            "the read-first heuristic must still undercount (this is the defect)"
2665        );
2666        assert_eq!(
2667            effective_num_params(&ops, &declared),
2668            2,
2669            "a conditionally-written param must be counted as a param"
2670        );
2671        // The #457 direction is untouched: a genuine non-param local is still
2672        // clamped away by the declared count.
2673        let rbw = vec![
2674            WasmOp::LocalGet(0),
2675            WasmOp::LocalGet(1),
2676            WasmOp::I32Add,
2677            WasmOp::End,
2678        ];
2679        assert_eq!(
2680            effective_num_params(
2681                &rbw,
2682                &CompileConfig {
2683                    current_func_param_count: Some(1),
2684                    ..CompileConfig::default()
2685                }
2686            ),
2687            1,
2688            "#457: a read-before-write non-param local must NOT become a param"
2689        );
2690        // Leniency: a body touching only the first few of many declared params
2691        // still lowers with the small count (the selector homes at most 4 in
2692        // registers; `min` is what keeps this from becoming `declared`).
2693        assert_eq!(
2694            effective_num_params(
2695                &rbw,
2696                &CompileConfig {
2697                    current_func_param_count: Some(12),
2698                    ..CompileConfig::default()
2699                }
2700            ),
2701            2,
2702            "declared >> referenced must stay at the referenced count"
2703        );
2704        // No declared count: the legacy inference, unchanged (honest residual).
2705        assert_eq!(
2706            effective_num_params(&ops, &CompileConfig::default()),
2707            count_params(&ops)
2708        );
2709    }
2710
2711    #[test]
2712    fn test_arm_backend_register() {
2713        let mut registry = synth_core::BackendRegistry::new();
2714        registry.register(Box::new(ArmBackend::new()));
2715        assert!(registry.get("arm").is_some());
2716        assert_eq!(registry.available().len(), 1);
2717    }
2718
2719    #[test]
2720    fn test_compile_import_call_produces_relocations() {
2721        let backend = ArmBackend::new();
2722        // Simulate a WASM module where func index 0 is an import.
2723        // Call(0) should generate MOV R0, #0; BL __meld_dispatch_import
2724        let ops = vec![WasmOp::Call(0)];
2725        let config = CompileConfig {
2726            num_imports: 1,
2727            no_optimize: true, // Direct instruction selection to preserve Call semantics
2728            ..CompileConfig::default()
2729        };
2730
2731        let result = backend.compile_function("caller", &ops, &config);
2732        assert!(result.is_ok());
2733
2734        let func = result.unwrap();
2735        assert!(!func.code.is_empty());
2736        assert_eq!(func.relocations.len(), 1);
2737        assert_eq!(func.relocations[0].symbol, "__meld_dispatch_import");
2738        // The BL is the second instruction (after MOV R0, #0), so offset should be > 0
2739        assert!(func.relocations[0].offset > 0);
2740    }
2741
2742    /// Regression test for #197: in `relocatable` mode, an import call must
2743    /// relocate against the direct `func_N` symbol (rewritten to the wasm field
2744    /// name by `build_relocatable_elf`), NOT `__meld_dispatch_import`. This is
2745    /// the ABI half of the #197 fix — without it, a host linker cannot resolve
2746    /// the call to the real kernel symbol (e.g. `k_spin_lock`).
2747    #[test]
2748    fn test_compile_relocatable_import_uses_direct_func_symbol_197() {
2749        let backend = ArmBackend::new();
2750        let ops = vec![WasmOp::Call(0)]; // func 0 is an import
2751        let config = CompileConfig {
2752            num_imports: 1,
2753            relocatable: true,
2754            ..CompileConfig::default()
2755        };
2756
2757        let func = backend
2758            .compile_function("caller", &ops, &config)
2759            .expect("relocatable import call compiles");
2760
2761        assert_eq!(func.relocations.len(), 1);
2762        assert_eq!(
2763            func.relocations[0].symbol, "func_0",
2764            "#197: relocatable import must relocate against func_0 (→ field name), not Meld dispatch"
2765        );
2766    }
2767
2768    #[test]
2769    fn test_compile_no_imports_no_relocations() {
2770        let backend = ArmBackend::new();
2771        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
2772        let config = CompileConfig::default();
2773
2774        let func = backend.compile_function("add", &ops, &config).unwrap();
2775        assert!(func.relocations.is_empty());
2776    }
2777
2778    /// Regression test for #167: a call to an INTERNAL function
2779    /// (index `>= num_imports`) must record a relocation against `func_{index}`.
2780    /// Before the fix, only `__meld_*` (import) BLs were relocated, so
2781    /// internal `BL func_N` was emitted as an unpatched `bl #0` branching
2782    /// to a garbage address — making the object non-linkable. This test
2783    /// would have caught that regression.
2784    #[test]
2785    fn test_compile_internal_call_produces_relocation_167() {
2786        let backend = ArmBackend::new();
2787        // num_imports = 1, so Call(2) is an INTERNAL call → `BL func_2`.
2788        let ops = vec![WasmOp::Call(2)];
2789        let config = CompileConfig {
2790            num_imports: 1,
2791            no_optimize: true,
2792            ..CompileConfig::default()
2793        };
2794
2795        let func = backend
2796            .compile_function("caller", &ops, &config)
2797            .expect("internal call compiles");
2798
2799        assert_eq!(
2800            func.relocations.len(),
2801            1,
2802            "an internal call must emit exactly one relocation (#167)"
2803        );
2804        assert_eq!(
2805            func.relocations[0].symbol, "func_2",
2806            "internal call must relocate against the callee's func_{{index}} symbol (#167)"
2807        );
2808    }
2809
2810    // ─── Phase 1 safety-bounds plumbing for ARM ──────────────────────────
2811
2812    #[test]
2813    fn arm_safety_bounds_mpu_emits_same_code_as_none() {
2814        // Mpu mode must not introduce any inline check on ARM — the MPU
2815        // handles faults via hardware. The encoded bytes for an i32.load
2816        // should be identical between None and Mpu.
2817        let backend = ArmBackend::new();
2818        let ops = vec![
2819            WasmOp::LocalGet(0),
2820            WasmOp::I32Load {
2821                offset: 0,
2822                align: 2,
2823            },
2824        ];
2825        let cfg_none = CompileConfig {
2826            no_optimize: true,
2827            ..Default::default()
2828        };
2829        let cfg_mpu = CompileConfig {
2830            no_optimize: true,
2831            safety_bounds: SafetyBounds::Mpu,
2832            ..Default::default()
2833        };
2834        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
2835        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
2836        assert_eq!(
2837            n.code, m.code,
2838            "Mpu and None should produce identical ARM bytes (Mpu relies on hardware)"
2839        );
2840    }
2841
2842    #[test]
2843    fn arm_legacy_bounds_check_still_emits_software_check() {
2844        // Legacy CLI users with `--bounds-check` should keep getting the
2845        // software path even though the new SafetyBounds field defaults to None.
2846        let backend = ArmBackend::new();
2847        let ops = vec![
2848            WasmOp::LocalGet(0),
2849            WasmOp::I32Load {
2850                offset: 0,
2851                align: 2,
2852            },
2853        ];
2854        let cfg_legacy = CompileConfig {
2855            no_optimize: true,
2856            bounds_check: true,
2857            ..Default::default()
2858        };
2859        let cfg_software = CompileConfig {
2860            no_optimize: true,
2861            safety_bounds: SafetyBounds::Software,
2862            ..Default::default()
2863        };
2864        let l = backend.compile_function("ld", &ops, &cfg_legacy).unwrap();
2865        let s = backend.compile_function("ld", &ops, &cfg_software).unwrap();
2866        assert_eq!(
2867            l.code, s.code,
2868            "--bounds-check should produce the same bytes as --safety-bounds=software"
2869        );
2870    }
2871
2872    /// #377: `--safety-bounds software` must be enforced on the OPTIMIZED path
2873    /// too. Pre-fix, `software` was byte-identical to `none` there (a silent
2874    /// no-op while the safety manifest claimed enforcement). The compiled
2875    /// bytes must now (a) differ from `none` and (b) contain the inline
2876    /// `CMP ip, sl` + `UDF` guard.
2877    #[test]
2878    fn arm_safety_bounds_software_enforced_on_optimized_path_377() {
2879        let backend = ArmBackend::new();
2880        // Dynamic-address store+load: the optimized path accepts this shape
2881        // (no calls, no i64 params, ≤4 params).
2882        let ops = vec![
2883            WasmOp::LocalGet(0),
2884            WasmOp::LocalGet(1),
2885            WasmOp::I32Store {
2886                offset: 4,
2887                align: 2,
2888            },
2889            WasmOp::LocalGet(0),
2890            WasmOp::I32Load {
2891                offset: 0,
2892                align: 2,
2893            },
2894        ];
2895        // no_optimize NOT set — this exercises the optimized path.
2896        let cfg_none = CompileConfig::default();
2897        let cfg_sw = CompileConfig {
2898            safety_bounds: SafetyBounds::Software,
2899            ..Default::default()
2900        };
2901        let n = backend.compile_function("st", &ops, &cfg_none).unwrap();
2902        let s = backend.compile_function("st", &ops, &cfg_sw).unwrap();
2903        assert_ne!(
2904            n.code, s.code,
2905            "#377: software bounds must CHANGE optimized-path codegen (was a silent no-op)"
2906        );
2907        // Thumb-2 `UDF #0` is 0xDE00 (LE bytes: 00 DE); the #752
2908        // wraparound-safe guard's borrow check `CMP sl, ip` (16-bit
2909        // high-reg form) is 0x45E2 (LE: E2 45). Both must appear — one
2910        // guard per access, traps inline.
2911        let has_udf = s.code.windows(2).any(|w| w == [0x00, 0xDE]);
2912        let has_cmp_sl_ip = s.code.windows(2).any(|w| w == [0xE2, 0x45]);
2913        assert!(has_udf, "#377: inline UDF trap missing from optimized path");
2914        assert!(
2915            has_cmp_sl_ip,
2916            "#377/#752: CMP sl, ip bounds borrow-check missing from optimized path"
2917        );
2918        // And `none` must contain NO UDF (the function has no other trap).
2919        assert!(
2920            !n.code.windows(2).any(|w| w == [0x00, 0xDE]),
2921            "none must not contain a UDF for this function"
2922        );
2923    }
2924
2925    /// #377: `mpu` on the optimized path is codegen-passthrough — identical
2926    /// bytes to `none` on BOTH paths (hardware enforcement is target-level;
2927    /// synth does not emit MPU region programming — tracked separately in
2928    /// #377's fix-direction discussion). This pins path-parity for `mpu`.
2929    #[test]
2930    fn arm_safety_bounds_mpu_optimized_path_parity_377() {
2931        let backend = ArmBackend::new();
2932        let ops = vec![
2933            WasmOp::LocalGet(0),
2934            WasmOp::I32Load {
2935                offset: 0,
2936                align: 2,
2937            },
2938        ];
2939        let cfg_none = CompileConfig::default();
2940        let cfg_mpu = CompileConfig {
2941            safety_bounds: SafetyBounds::Mpu,
2942            ..Default::default()
2943        };
2944        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
2945        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
2946        assert_eq!(
2947            n.code, m.code,
2948            "Mpu and None must produce identical bytes on the optimized path too"
2949        );
2950    }
2951
2952    /// #377: `mask` on the optimized path declines to the direct selector
2953    /// (honest degradation) — the compiled function must equal the
2954    /// `--no-optimize` masking bytes, i.e. the flag is honored, never dropped.
2955    #[test]
2956    fn arm_safety_bounds_mask_optimized_path_declines_to_direct_377() {
2957        let backend = ArmBackend::new();
2958        let ops = vec![
2959            WasmOp::LocalGet(0),
2960            WasmOp::LocalGet(1),
2961            WasmOp::I32Store {
2962                offset: 0,
2963                align: 2,
2964            },
2965        ];
2966        // RQ-57-SENTINEL: mask now requires a STATED non-zero power-of-two
2967        // size (0 = zero-byte memory = refused), so the test states one —
2968        // exactly what the #953 fix required of the rv32 driver test.
2969        let cfg_mask_opt = CompileConfig {
2970            safety_bounds: SafetyBounds::Mask,
2971            linear_memory_bytes: 64 * 1024,
2972            ..Default::default()
2973        };
2974        let cfg_mask_direct = CompileConfig {
2975            no_optimize: true,
2976            safety_bounds: SafetyBounds::Mask,
2977            linear_memory_bytes: 64 * 1024,
2978            ..Default::default()
2979        };
2980        let o = backend.compile_function("st", &ops, &cfg_mask_opt).unwrap();
2981        let d = backend
2982            .compile_function("st", &ops, &cfg_mask_direct)
2983            .unwrap();
2984        assert_eq!(
2985            o.code, d.code,
2986            "#377: mask on the optimized path must fall back to the direct selector's masking"
2987        );
2988    }
2989
2990    /// RQ-57-SENTINEL (#953 sibling): `--safety-bounds mask` with a ZERO-byte
2991    /// linear memory must REFUSE at compile time. Before this fix, `bytes == 0`
2992    /// was exempt from the power-of-two gate ("0 means unknown"), and the
2993    /// emitted `SUB R12, R10, #1; AND` guard degenerated to an IDENTITY mask
2994    /// at runtime (R10 = 0 baked by the startup for a `(memory 0)` module):
2995    /// an unbounded OOB access in the mode whose purpose is bounding.
2996    /// Red-first: pre-fix this compile SUCCEEDED (verified on the v0.56.1
2997    /// tree: exit 0, `movw r10, #0x0` in the reset handler, AND-masked body).
2998    #[test]
2999    fn arm_safety_bounds_mask_zero_size_refused_rq57() {
3000        let backend = ArmBackend::new();
3001        let ops = vec![
3002            WasmOp::LocalGet(0),
3003            WasmOp::I32Load {
3004                offset: 0,
3005                align: 2,
3006            },
3007        ];
3008        let cfg = CompileConfig {
3009            safety_bounds: SafetyBounds::Mask,
3010            linear_memory_bytes: 0,
3011            ..Default::default()
3012        };
3013        let err = backend
3014            .compile_function("ld", &ops, &cfg)
3015            .expect_err("mask over a zero-byte memory must refuse, not emit an identity mask");
3016        let msg = format!("{err}");
3017        assert!(
3018            msg.contains("ZERO bytes"),
3019            "refusal must name the zero-byte cause, got: {msg}"
3020        );
3021    }
3022
3023    // ========================================================================
3024    // ISA feature gate tests — ensure the compiler never emits unsupported
3025    // instructions for a given target
3026    // ========================================================================
3027
3028    #[test]
3029    fn test_f32_rejected_on_cortex_m3_no_fpu() {
3030        let backend = ArmBackend::new();
3031        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
3032        let config = CompileConfig {
3033            target: TargetSpec::cortex_m3(),
3034            no_optimize: true,
3035            ..CompileConfig::default()
3036        };
3037
3038        let result = backend.compile_function("fadd", &ops, &config);
3039        assert!(
3040            result.is_err(),
3041            "f32 operations should fail on Cortex-M3 (no FPU)"
3042        );
3043    }
3044
3045    #[test]
3046    fn test_f32_accepted_on_cortex_m4f() {
3047        let backend = ArmBackend::new();
3048        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
3049        let config = CompileConfig {
3050            target: TargetSpec::cortex_m4f(),
3051            no_optimize: true,
3052            ..CompileConfig::default()
3053        };
3054
3055        let result = backend.compile_function("fadd", &ops, &config);
3056        assert!(
3057            result.is_ok(),
3058            "f32 operations should succeed on Cortex-M4F, got: {:?}",
3059            result.unwrap_err()
3060        );
3061    }
3062
3063    #[test]
3064    fn test_i32_works_on_all_targets() {
3065        let backend = ArmBackend::new();
3066        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
3067
3068        // Cortex-M3 (no FPU)
3069        let config_m3 = CompileConfig {
3070            target: TargetSpec::cortex_m3(),
3071            no_optimize: true,
3072            ..CompileConfig::default()
3073        };
3074        assert!(
3075            backend.compile_function("add", &ops, &config_m3).is_ok(),
3076            "i32 ops should work on Cortex-M3"
3077        );
3078
3079        // Cortex-M4F (single FPU)
3080        let config_m4f = CompileConfig {
3081            target: TargetSpec::cortex_m4f(),
3082            no_optimize: true,
3083            ..CompileConfig::default()
3084        };
3085        assert!(
3086            backend.compile_function("add", &ops, &config_m4f).is_ok(),
3087            "i32 ops should work on Cortex-M4F"
3088        );
3089
3090        // Cortex-M7DP (double FPU)
3091        let config_m7dp = CompileConfig {
3092            target: TargetSpec::cortex_m7dp(),
3093            no_optimize: true,
3094            ..CompileConfig::default()
3095        };
3096        assert!(
3097            backend.compile_function("add", &ops, &config_m7dp).is_ok(),
3098            "i32 ops should work on Cortex-M7DP"
3099        );
3100    }
3101
3102    #[test]
3103    fn test_f32_rejected_on_cortex_m4_no_fpu() {
3104        // Cortex-M4 (without F suffix) has no FPU
3105        let backend = ArmBackend::new();
3106        let ops = vec![WasmOp::F32Const(1.5), WasmOp::F32Const(2.5), WasmOp::F32Mul];
3107        let config = CompileConfig {
3108            target: TargetSpec::cortex_m4(),
3109            no_optimize: true,
3110            ..CompileConfig::default()
3111        };
3112
3113        let result = backend.compile_function("fmul", &ops, &config);
3114        assert!(
3115            result.is_err(),
3116            "f32 operations should fail on Cortex-M4 (no FPU)"
3117        );
3118    }
3119
3120    // ========================================================================
3121    // Issue #120 — f32 ops in the optimized lowering path
3122    //
3123    // `OptimizerBridge::wasm_to_ir` has no handlers for f32/f64 ops, so a
3124    // value-producing float op fell through to `Opcode::Nop`, leaving a
3125    // downstream consumer with an unmapped vreg and tripping the PR #101
3126    // defensive panic in `ir_to_arm`. Customer reproducer: `compiler_builtins
3127    // float::div` and `gale_compute_ipi_mask` in the `falcon-rate-component`
3128    // module.
3129    //
3130    // Fix: `optimize_full` declines float modules with a typed `Err`;
3131    // `compile_wasm_to_arm` falls back to the non-optimized `select_with_stack`
3132    // path, which handles f32 via VFP/FPU. These tests use the *default*
3133    // (optimized) config — `no_optimize` is NOT set — which is the exact
3134    // configuration that panicked pre-fix.
3135    // ========================================================================
3136
3137    /// Pre-fix: this panicked with "vreg vN has no assigned ARM register and
3138    /// no spill slot" inside `ir_to_arm`. Post-fix: the optimized path declines
3139    /// the module and the backend falls back to direct selection, producing a
3140    /// non-empty f32.div lowering on a Cortex-M4F.
3141    #[test]
3142    fn test_issue120_f32_div_compiles_via_optimized_default() {
3143        let backend = ArmBackend::new();
3144        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
3145        let config = CompileConfig {
3146            target: TargetSpec::cortex_m4f(),
3147            // no_optimize NOT set — this exercises the optimized path that
3148            // panicked in issue #120, then the fallback to direct selection.
3149            // GI-FPU-002: the f32 params must be declared so the direct
3150            // selector homes them in S0/S1 (AAPCS-VFP) rather than declining.
3151            current_func_params_f32: vec![true, true],
3152            ..CompileConfig::default()
3153        };
3154
3155        let result = backend.compile_function("fdiv", &ops, &config);
3156        assert!(
3157            result.is_ok(),
3158            "f32.div must compile on Cortex-M4F via the optimized->direct \
3159             fallback (issue #120), got: {:?}",
3160            result.as_ref().err()
3161        );
3162        assert!(
3163            !result.unwrap().code.is_empty(),
3164            "f32.div must produce non-empty machine code"
3165        );
3166    }
3167
3168    /// A spread of f32 ops, all through the optimized (default) config, must
3169    /// compile via the fallback on an FPU target without panicking.
3170    #[test]
3171    fn test_issue120_assorted_f32_ops_compile_via_optimized_default() {
3172        let backend = ArmBackend::new();
3173        let config = CompileConfig {
3174            target: TargetSpec::cortex_m4f(),
3175            // GI-FPU-002: declare the two f32 params for AAPCS-VFP homing.
3176            current_func_params_f32: vec![true, true],
3177            ..CompileConfig::default()
3178        };
3179
3180        let cases: Vec<(&str, Vec<WasmOp>)> = vec![
3181            (
3182                "fadd",
3183                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Add],
3184            ),
3185            (
3186                "fmul",
3187                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Mul],
3188            ),
3189            (
3190                "fsub",
3191                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Sub],
3192            ),
3193        ];
3194
3195        for (name, ops) in cases {
3196            let result = backend.compile_function(name, &ops, &config);
3197            assert!(
3198                result.is_ok(),
3199                "{name} must compile via the optimized->direct fallback \
3200                 (issue #120), got: {:?}",
3201                result.as_ref().err()
3202            );
3203            assert!(
3204                !result.unwrap().code.is_empty(),
3205                "{name} must produce non-empty machine code"
3206            );
3207        }
3208    }
3209
3210    /// The fallback must still honor the ISA feature gate: f32 on a no-FPU
3211    /// target must fail cleanly (not panic) even on the optimized path.
3212    #[test]
3213    fn test_issue120_f32_div_rejected_on_no_fpu_via_optimized() {
3214        let backend = ArmBackend::new();
3215        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
3216        let config = CompileConfig {
3217            target: TargetSpec::cortex_m3(),
3218            ..CompileConfig::default()
3219        };
3220
3221        let result = backend.compile_function("fdiv", &ops, &config);
3222        assert!(
3223            result.is_err(),
3224            "f32.div must be rejected on Cortex-M3 (no FPU), not panic"
3225        );
3226    }
3227
3228    /// #507: a `br_table` function compiled via the DEFAULT (optimized) config
3229    /// must produce the SAME bytes as the direct (`no_optimize`) selector —
3230    /// i.e. the optimized path declined it to direct, lowering the dispatch as a
3231    /// real cmp-chain instead of silently dropping it (which left all arms in
3232    /// fall-through). Pre-fix the two outputs differed (the optimized one had no
3233    /// selector compare). Execution correctness is gated by
3234    /// `scripts/repro/br_table_507_differential.py`.
3235    #[test]
3236    fn test_507_br_table_declines_to_direct() {
3237        let backend = ArmBackend::new();
3238        // dispatch(sel): br_table over 3 blocks, each storing a marker to mem[0].
3239        let ops = vec![
3240            WasmOp::Block,
3241            WasmOp::Block,
3242            WasmOp::Block,
3243            WasmOp::LocalGet(0),
3244            WasmOp::BrTable {
3245                targets: vec![0, 1, 2],
3246                default: 2,
3247            },
3248            WasmOp::End,
3249            WasmOp::I32Const(0),
3250            WasmOp::I32Const(10),
3251            WasmOp::I32Store {
3252                offset: 0,
3253                align: 2,
3254            },
3255            WasmOp::Return,
3256            WasmOp::End,
3257            WasmOp::I32Const(0),
3258            WasmOp::I32Const(20),
3259            WasmOp::I32Store {
3260                offset: 0,
3261                align: 2,
3262            },
3263            WasmOp::Return,
3264            WasmOp::End,
3265            WasmOp::I32Const(0),
3266            WasmOp::I32Const(30),
3267            WasmOp::I32Store {
3268                offset: 0,
3269                align: 2,
3270            },
3271        ];
3272        let opt = CompileConfig {
3273            target: TargetSpec::cortex_m4(),
3274            ..CompileConfig::default()
3275        };
3276        let direct = CompileConfig {
3277            target: TargetSpec::cortex_m4(),
3278            no_optimize: true,
3279            ..CompileConfig::default()
3280        };
3281        let a = backend
3282            .compile_function("dispatch", &ops, &opt)
3283            .expect("optimized-default must compile br_table (via decline)");
3284        let b = backend
3285            .compile_function("dispatch", &ops, &direct)
3286            .expect("direct must compile br_table");
3287        assert_eq!(
3288            a.code, b.code,
3289            "#507: optimized-default br_table output must be byte-identical to the \
3290             direct selector (i.e. declined to direct), not a dropped dispatch"
3291        );
3292    }
3293
3294    /// Issue #94: end-to-end byte-size check for the canonical u64-packed
3295    /// FFI-return hi32 extract pattern. Compiles two near-identical
3296    /// functions — one with the optimized shift-by-32, one with a generic
3297    /// shift-by-7 — and asserts the optimized form is meaningfully smaller.
3298    #[test]
3299    fn test_issue94_hi32_extract_is_smaller_than_generic_shift() {
3300        let backend = ArmBackend::new();
3301        let config = CompileConfig {
3302            target: TargetSpec::cortex_m4f(),
3303            ..CompileConfig::default()
3304        };
3305
3306        // #518: the i64 value must NOT come from an i64 PARAM — the optimized
3307        // path now declines i64-param functions to the direct selector (it homed
3308        // an i64 param in R4:R5 instead of R0:R1, a silent miscompile this test's
3309        // byte-size-only assertion masked). The canonical #94 case is a u64 from
3310        // an FFI return, not a param, anyway. Source the i64 from a sign-extended
3311        // i32 param (`extend_i32_s`): a runtime, non-constant-foldable i64 that
3312        // stays on the optimized path, so the shift-by-32 hi-extract peephole is
3313        // still exercised on CORRECT code.
3314        // Optimized path: `(i64.extend_i32_s (local.get 0)) >>> 32; wrap_i64`
3315        let ops_hi32 = vec![
3316            WasmOp::LocalGet(0), // i32 param in R0
3317            WasmOp::I64ExtendI32S,
3318            WasmOp::I64Const(32),
3319            WasmOp::I64ShrU,
3320            WasmOp::I32WrapI64,
3321        ];
3322        let func_hi32 = backend
3323            .compile_function("hi32_extract", &ops_hi32, &config)
3324            .unwrap();
3325
3326        // Generic path: `... >>> 7; wrap_i64` — same shape, but the shift amount
3327        // is not a multiple of 32, so it falls through to the runtime shift.
3328        let ops_generic = vec![
3329            WasmOp::LocalGet(0),
3330            WasmOp::I64ExtendI32S,
3331            WasmOp::I64Const(7),
3332            WasmOp::I64ShrU,
3333            WasmOp::I32WrapI64,
3334        ];
3335        let func_generic = backend
3336            .compile_function("generic_shr", &ops_generic, &config)
3337            .unwrap();
3338
3339        let bytes_hi32 = func_hi32.code.len();
3340        let bytes_generic = func_generic.code.len();
3341        println!(
3342            "\n[issue #94] hi32 extract: {} bytes (vs generic shift: {} bytes; saved {})",
3343            bytes_hi32,
3344            bytes_generic,
3345            bytes_generic.saturating_sub(bytes_hi32)
3346        );
3347        let hex: String = func_hi32
3348            .code
3349            .iter()
3350            .map(|b| format!("{:02x}", b))
3351            .collect::<Vec<_>>()
3352            .join(" ");
3353        println!("[issue #94] hi32 bytes: {}", hex);
3354        // We expect the optimized form to be at least 30 bytes smaller than
3355        // the generic 64-bit shift sequence. (Empirically: 14 vs 50 bytes.)
3356        assert!(
3357            bytes_hi32 + 30 <= bytes_generic,
3358            "issue #94: hi32 extract = {} bytes, generic shift = {} bytes; \
3359             expected optimized form to be at least 30 bytes smaller",
3360            bytes_hi32,
3361            bytes_generic,
3362        );
3363    }
3364}