Skip to main content

synth_backend/
arm_backend.rs

1//! ARM Backend — wraps the instruction selector + optimizer + encoder as a Backend
2//!
3//! This is Synth's custom ARM compiler targeting Cortex-M (Thumb-2).
4//! It's the only backend that supports per-rule formal verification (ASIL D path).
5
6use crate::ArmEncoder;
7use synth_core::backend::{
8    Backend, BackendCapabilities, BackendError, CodeRelocation, CompilationResult, CompileConfig,
9    CompiledFunction, LineMap, SafetyBounds,
10};
11use synth_core::target::{IsaVariant, TargetSpec};
12use synth_core::wasm_decoder::DecodedModule;
13use synth_core::wasm_op::WasmOp;
14use synth_synthesis::{
15    ArmInstruction, ArmOp, BoundsCheckConfig, InstructionSelector, OptimizationConfig,
16    OptimizerBridge, RuleDatabase, validate_instructions,
17};
18
19/// ARM Cortex-M backend using Synth's custom compiler pipeline
20pub struct ArmBackend;
21
22impl ArmBackend {
23    pub fn new() -> Self {
24        Self
25    }
26}
27
28impl Default for ArmBackend {
29    fn default() -> Self {
30        Self::new()
31    }
32}
33
34impl Backend for ArmBackend {
35    fn name(&self) -> &str {
36        "arm"
37    }
38
39    fn capabilities(&self) -> BackendCapabilities {
40        BackendCapabilities {
41            produces_elf: false,
42            supports_rule_verification: true,
43            supports_binary_verification: true,
44            is_external: false,
45        }
46    }
47
48    fn supported_targets(&self) -> Vec<TargetSpec> {
49        vec![
50            TargetSpec::cortex_m3(),
51            TargetSpec::cortex_m4(),
52            TargetSpec::cortex_m4f(),
53            TargetSpec::cortex_m7(),
54            TargetSpec::cortex_m7dp(),
55        ]
56    }
57
58    fn compile_module(
59        &self,
60        module: &DecodedModule,
61        config: &CompileConfig,
62    ) -> Result<CompilationResult, BackendError> {
63        let exports: Vec<_> = module
64            .functions
65            .iter()
66            .filter(|f| f.export_name.is_some())
67            .collect();
68
69        if exports.is_empty() {
70            return Err(BackendError::CompilationFailed(
71                "no exported functions found".into(),
72            ));
73        }
74
75        let mut functions = Vec::new();
76        for func in &exports {
77            let name = func.export_name.clone().unwrap();
78            // #359: copy THIS function's declared param widths into the config so
79            // `compile_function` (which carries no function index) can refuse a
80            // 64-bit param on the AAPCS stack-argument path. Cheap clone only when
81            // a signature table is present and this function has a width entry —
82            // otherwise reuse the shared config (every existing module unchanged).
83            // #509: same per-function pattern for the blocktype-arity side-table
84            // (value-carrying-branch lowering).
85            let params = config
86                .func_params_i64
87                .get(func.index as usize)
88                .filter(|p| !p.is_empty());
89            // #457: THIS function's DECLARED param count (imports-first full
90            // index), so the backend can cap the access-pattern inference that
91            // mistook a read-before-write local for a param. `None` when the
92            // driver supplied no arg-count table (hand-built modules).
93            let declared_params = config.func_arg_counts.get(func.index as usize).copied();
94            // GI-FPU-002 (#619/#369): THIS function's declared f32-param mask.
95            let params_f32 = config
96                .func_params_f32
97                .get(func.index as usize)
98                .filter(|p| !p.is_empty());
99            // GI-FPU-002 phase 2 (#369): THIS function's declared f64-param
100            // mask (hard-float targets decline f64 params loudly).
101            let params_f64 = config
102                .func_params_f64
103                .get(func.index as usize)
104                .filter(|p| !p.is_empty());
105            // GI-FPU-002 phase 2 (#719/#369): THIS function's declared f32/f64
106            // return flag, so the epilogue soundness guard fires on every driver
107            // path (not only the CLI loops).
108            let ret_f32 = config
109                .func_ret_f32
110                .get(func.index as usize)
111                .copied()
112                .unwrap_or(false);
113            let ret_f64 = config
114                .func_ret_f64
115                .get(func.index as usize)
116                .copied()
117                .unwrap_or(false);
118            let func_config = if params.is_some()
119                || params_f32.is_some()
120                || params_f64.is_some()
121                || !func.block_arity.is_empty()
122                || declared_params.is_some()
123                || ret_f32
124                || ret_f64
125            {
126                Some(CompileConfig {
127                    current_func_params_i64: params.cloned().unwrap_or_default(),
128                    current_func_params_f32: params_f32.cloned().unwrap_or_default(),
129                    current_func_params_f64: params_f64.cloned().unwrap_or_default(),
130                    current_func_ret_f32: ret_f32,
131                    current_func_ret_f64: ret_f64,
132                    current_func_block_arity: func.block_arity.clone(),
133                    current_func_param_count: declared_params,
134                    ..config.clone()
135                })
136            } else {
137                None
138            };
139            let cfg = func_config.as_ref().unwrap_or(config);
140            let compiled = self.compile_function(&name, &func.ops, cfg)?;
141            functions.push(compiled);
142        }
143
144        Ok(CompilationResult {
145            functions,
146            elf: None,
147            backend_name: self.name().to_string(),
148        })
149    }
150
151    fn compile_function(
152        &self,
153        name: &str,
154        ops: &[WasmOp],
155        config: &CompileConfig,
156    ) -> Result<CompiledFunction, BackendError> {
157        let (code, relocations, line_map) =
158            compile_wasm_to_arm(ops, config).map_err(BackendError::CompilationFailed)?;
159
160        Ok(CompiledFunction {
161            name: name.to_string(),
162            code,
163            wasm_ops: ops.to_vec(),
164            relocations,
165            line_map,
166        })
167    }
168
169    fn is_available(&self) -> bool {
170        true // Always available — it's a library backend
171    }
172}
173
174/// Count the number of function parameters by analyzing LocalGet patterns
175fn count_params(wasm_ops: &[WasmOp]) -> u32 {
176    let mut first_access: std::collections::HashMap<u32, bool> = std::collections::HashMap::new();
177    for op in wasm_ops {
178        match op {
179            WasmOp::LocalGet(idx) => {
180                first_access.entry(*idx).or_insert(true);
181            }
182            WasmOp::LocalSet(idx) | WasmOp::LocalTee(idx) => {
183                first_access.entry(*idx).or_insert(false);
184            }
185            _ => {}
186        }
187    }
188
189    first_access
190        .iter()
191        .filter_map(
192            |(&idx, &is_read_first)| {
193                if is_read_first { Some(idx + 1) } else { None }
194            },
195        )
196        .max()
197        .unwrap_or(0)
198}
199
200/// #539: fold the `i32.const 0; memory.grow m` idiom to `memory.size m`.
201/// `memory.grow(0)` always succeeds and returns the current page count (WASM
202/// Core §4.4.7), which is exactly `memory.size`; the fixed-memory backend
203/// otherwise emits a constant `-1` for every `memory.grow`, so the legal
204/// `memory.grow(0)` "read/validate current size" idiom wrongly reported failure.
205/// Only the ADJACENT const-0 delta is folded (a non-zero delta keeps the sound
206/// `-1` — fixed memory genuinely cannot grow; a runtime-computed 0 is a
207/// documented follow-up). Backend- and path-agnostic: `memory.size` reads the
208/// runtime memory-size register on every selector, so this fixes the optimized
209/// and direct paths at once.
210fn rewrite_memory_grow_zero(wasm_ops: &[WasmOp]) -> Vec<WasmOp> {
211    let mut out = Vec::with_capacity(wasm_ops.len());
212    let mut i = 0;
213    while i < wasm_ops.len() {
214        if matches!(wasm_ops[i], WasmOp::I32Const(0))
215            && let Some(WasmOp::MemoryGrow(m)) = wasm_ops.get(i + 1)
216        {
217            out.push(WasmOp::MemorySize(*m));
218            i += 2;
219        } else {
220            out.push(wasm_ops[i].clone());
221            i += 1;
222        }
223    }
224    out
225}
226
227/// #509: does the op stream contain a `br`/`br_if`/`br_table` that CARRIES a
228/// value — i.e. one targeting a result-typed block/if (forward edge with
229/// results > 0) or a parameterized loop header (backward edge with loop
230/// params > 0)?
231///
232/// The optimized path's wasm→IR lowering drops the carried value on such
233/// edges (the taken arm returns the fall-through result — same class as the
234/// #507 `br_table` drop, observed on `pick_br`/`pick_br_fall`), so — like
235/// #507 — the shape is detected on the raw op stream and routed to the direct
236/// selector, whose #509 designated-result-register lowering lands the value
237/// correctly. `block_arity` is the decoder's ordinal blocktype-arity
238/// side-table; when it is empty (hand-built op streams) every block reads as
239/// void and this never fires, keeping the optimized path byte-identical for
240/// every existing caller. Frozen-safe for the same reason as #507: the frozen
241/// fixtures compile `--relocatable` (already direct), and no optimized-path
242/// fixture branches to a result-typed block.
243fn has_value_carrying_branch(wasm_ops: &[WasmOp], block_arity: &[(u8, u8)]) -> bool {
244    // Open control constructs: (is_loop, params, results), innermost last.
245    let mut open: Vec<(bool, u8, u8)> = Vec::new();
246    let mut ctrl_ord = 0usize;
247    // A branch edge carries a value when its target is a result-typed forward
248    // join (block/if) or a parameterized loop header.
249    let carries = |open: &[(bool, u8, u8)], depth: u32| -> bool {
250        let Some(&(is_loop, params, results)) = open
251            .len()
252            .checked_sub(1 + depth as usize)
253            .and_then(|i| open.get(i))
254        else {
255            return false; // function-level target — handled by Return lowering
256        };
257        if is_loop { params > 0 } else { results > 0 }
258    };
259    for op in wasm_ops {
260        match op {
261            WasmOp::Block | WasmOp::If => {
262                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
263                ctrl_ord += 1;
264                open.push((false, p, r));
265            }
266            WasmOp::Loop => {
267                let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
268                ctrl_ord += 1;
269                open.push((true, p, r));
270            }
271            WasmOp::End => {
272                open.pop(); // None only at the function-level end — harmless
273            }
274            WasmOp::Br(d) | WasmOp::BrIf(d) if carries(&open, *d) => return true,
275            WasmOp::BrTable { targets, default }
276                if targets
277                    .iter()
278                    .chain(std::iter::once(default))
279                    .any(|d| carries(&open, *d)) =>
280            {
281                return true;
282            }
283            _ => {}
284        }
285    }
286    false
287}
288
289/// Core compilation: WASM ops → ARM machine code bytes + relocations
290///
291/// Returns (code_bytes, relocations) where relocations record BL instructions
292/// that target external symbols (e.g., `__meld_dispatch_import` for import calls).
293fn compile_wasm_to_arm(
294    wasm_ops: &[WasmOp],
295    config: &CompileConfig,
296) -> Result<(Vec<u8>, Vec<CodeRelocation>, LineMap), String> {
297    // #539: `memory.grow(0)` must return the CURRENT page count, not the
298    // fixed-memory `-1` sentinel — growing by zero pages can never fail (WASM
299    // Core §4.4.7), so a guest doing `if (memory.grow(0) < 0) trap;` wrongly
300    // faulted. Every lowering path emitted a delta-agnostic `-1`. `memory.grow(0)`
301    // is semantically identical to `memory.size`, which the backend already
302    // computes from the runtime memory-size register (R10 >> 16 = pages), so fold
303    // the `i32.const 0; memory.grow` idiom to `memory.size` up front — backend-
304    // and path-agnostic. A non-zero delta keeps `-1` (fixed memory genuinely
305    // cannot grow); a runtime delta that happens to be 0 is the documented
306    // follow-up.
307    let rewritten = rewrite_memory_grow_zero(wasm_ops);
308    // #494 phase 2b: the fact-spec guard-elision marks are keyed by op index
309    // into the stream the DRIVER handed us. The memory.grow(0) fold above can
310    // only shift indices AT OR AFTER a `memory.grow` — an op the fact-spec
311    // walk never crosses (it stops at the first untracked op, so no mark can
312    // follow one). Defense in depth: if the fold fired at all, drop the marks
313    // loudly rather than risk keying a guard elision to the wrong op.
314    let (fact_div_zero_elide, fact_div_ovf_elide, fact_mem_bounds_elide): (
315        &[usize],
316        &[usize],
317        &[usize],
318    ) = if rewritten.len() == wasm_ops.len() {
319        (
320            &config.fact_div_zero_elide,
321            &config.fact_div_ovf_elide,
322            &config.fact_mem_bounds_elide,
323        )
324    } else {
325        if !config.fact_div_zero_elide.is_empty()
326            || !config.fact_div_ovf_elide.is_empty()
327            || !config.fact_mem_bounds_elide.is_empty()
328        {
329            eprintln!(
330                "fact-spec: DECLINE guard elision marks dropped — the                      memory.grow(0) fold shifted op indices (#494 defensive gate);                      general lowering emitted"
331            );
332        }
333        (&[], &[], &[])
334    };
335    let wasm_ops: &[WasmOp] = &rewritten;
336
337    // #457: `count_params` INFERS the param count from access patterns (a local
338    // whose first access is a read is assumed to be a param), so a
339    // read-before-write NON-PARAM local — which WASM zero-initializes — was
340    // indistinguishable from a param: it got homed in a parameter register and
341    // read caller garbage instead of 0. When the driver supplied the DECLARED
342    // count (`current_func_param_count`, from the module's type section), cap
343    // the inference with it. `min` (not a plain override) keeps every function
344    // whose inference is <= declared byte-identical: the inferred count can only
345    // EXCEED the declared one via a read-first local index >= the declared count
346    // — i.e. exactly the read-before-write locals this issue is about.
347    let inferred_params = count_params(wasm_ops);
348    let num_params = match config.current_func_param_count {
349        Some(declared) => inferred_params.min(declared),
350        None => inferred_params,
351    };
352    // A read-before-write non-param local exists iff the capped count dropped.
353    // Such locals need the wasm-mandated zero-init, which only the direct
354    // selector emits — the optimized path's `ir_to_arm` maps a non-param
355    // local's vreg onto an r4+ temp with no initialization (caller garbage).
356    let has_rbw_local = num_params < inferred_params;
357
358    let bounds_config = match config.effective_safety_bounds() {
359        SafetyBounds::None => BoundsCheckConfig::None,
360        SafetyBounds::Mpu => BoundsCheckConfig::Mpu,
361        SafetyBounds::Software => BoundsCheckConfig::Software,
362        SafetyBounds::Mask => {
363            // #651 (mirroring the RISC-V backend's compile-time decline):
364            // index masking wraps `ea & (size-1)` — a modulo only when the
365            // linear-memory size is a power of two. With a non-power-of-two
366            // size the AND would silently REMAP in-bounds addresses (e.g.
367            // 0x18000 & 0x2FFFF = 0x8000 for a 192 KiB memory). Decline
368            // loudly rather than miscompile. `linear_memory_bytes == 0`
369            // means "unknown" (plain per-function path, no module context)
370            // — the startup default of one 64 KiB page is a power of two.
371            let bytes = config.linear_memory_bytes;
372            if bytes != 0 && !bytes.is_power_of_two() {
373                return Err(format!(
374                    "--safety-bounds mask requires a power-of-two linear-memory \
375                     size, got {bytes} bytes — switch to --safety-bounds software \
376                     for the deterministic check (#651)"
377                ));
378            }
379            BoundsCheckConfig::Masking
380        }
381    };
382
383    // The non-optimized (direct) instruction-selection path. Handles f32 via
384    // VFP/FPU. Used directly when `--no-optimize` is set, and as the fallback
385    // when the optimized path declines a module (see issue #120 below).
386    //
387    // VCR-RA-001 step 3b-lite (#242): a FRESH selector per attempt, with
388    // `spill_on_exhaustion` set only on the retry — the first pass is the
389    // unmodified default, so every function that compiles today is selected by
390    // exactly the code that compiled it yesterday (bit-identity is structural,
391    // not behavioural).
392    let select_direct_attempt = |spill_on_exhaustion: bool,
393                                 param_backing_on_exhaustion: bool,
394                                 local_promote: bool,
395                                 i64_spill_slots: Option<usize>|
396     -> Result<Vec<ArmInstruction>, synth_core::Error> {
397        let db = RuleDatabase::with_standard_rules();
398        let mut selector =
399            InstructionSelector::with_bounds_check(db.rules().to_vec(), bounds_config);
400        selector.set_target(config.target.fpu, &config.target.triple);
401        if config.num_imports > 0 {
402            selector.set_num_imports(config.num_imports);
403        }
404        // #195: plumb the callee argument-count tables so the direct selector can
405        // marshal call arguments into R0–R3 per AAPCS.
406        selector.set_func_arg_counts(
407            config.func_arg_counts.clone(),
408            config.type_arg_counts.clone(),
409        );
410        // #197: in relocatable host-link mode, emit direct `func_N` BLs for
411        // imports (rewritten to the wasm field name by build_relocatable_elf)
412        // instead of `__meld_dispatch_import`.
413        selector.set_relocatable(config.relocatable);
414        // #642: call_indirect guard inputs (compile-time table size for the
415        // bounds guard + closed-world type verdicts). Without them, every
416        // call_indirect lowering declines loudly.
417        selector.set_call_indirect_guards(config.call_indirect_guards.clone());
418        // #275: on the self-contained image path (NOT --relocatable) decline
419        // call_indirect loudly — the R11 funcref-table region is only populated
420        // by an external runtime, which a self-contained ELF does not have, so
421        // the dispatch would read function pointers from linear-memory data (a
422        // silent miscompile). The host-linked (--relocatable) path keeps the
423        // guarded dispatch: there a runtime places the table region at R11.
424        selector.set_reject_self_contained_call_indirect(!config.relocatable);
425        // #237: native-pointer ABI — wasm statics become __synth_wasm_data-relative.
426        selector.set_native_pointer_abi(config.native_pointer_abi, config.linear_memory_bytes);
427        // VCR-MEM-002 phase 1 (#406): per-memory initial page counts — enables
428        // the multi-memory arms (memory-0 lowering never reads it; empty ⇒
429        // every multi-memory op declines loudly).
430        selector.set_memory_pages(config.memory_pages.clone());
431        // #311: i64 call results are register PAIRS — tag them.
432        selector.set_result_types(config.func_ret_i64.clone(), config.type_ret_i64.clone());
433        // #359: declared param widths of THIS function, so the AAPCS stack-arg
434        // path can refuse 64-bit params (Ok-or-Err). Empty ⇒ assume i32.
435        selector.set_params_i64(config.current_func_params_i64.clone());
436        // GI-FPU-002 (#619/#369): declared f32-param mask — home hard-float f32
437        // args in S0..S15 (AAPCS-VFP) instead of the R0..R3 integer path.
438        selector.set_params_f32(config.current_func_params_f32.clone());
439        // GI-FPU-002 phase 2 (#369): declared f64-param mask — hard-float
440        // targets decline f64-param functions loudly (no D-register homing yet).
441        selector.set_params_f64(config.current_func_params_f64.clone());
442        // GI-FPU-002 phase 2 (#719/#369): THIS function's f32/f64 return flag, so
443        // the epilogue loudly declines a float result reaching it in a core
444        // register (never a silent integer R0 return where a caller reads S0/D0).
445        selector.set_ret_float(config.current_func_ret_f32, config.current_func_ret_f64);
446        // GI-FPU-002 phase 3 (#369): per-callee float-signature tables. `Call`
447        // marshals the AAPCS-VFP boundary from these (float args into S0../D0..,
448        // float results out of S0/D0); `CallIndirect` still declines a
449        // float-returning static type loudly.
450        selector.set_float_call_signatures(
451            config.func_ret_f32.clone(),
452            config.func_ret_f64.clone(),
453            config.type_ret_f32.clone(),
454            config.type_ret_f64.clone(),
455            config.func_params_f32.clone(),
456            config.func_params_f64.clone(),
457        );
458        // #509: blocktype-arity side-table of THIS function, so value-carrying
459        // br/br_if/br_table land the carried value in the target block's
460        // designated result register instead of dropping it. Empty ⇒ legacy
461        // void-block lowering.
462        selector.set_block_arity(config.current_func_block_arity.clone());
463        // Stack-pointer promotion is meaningful only under the native-pointer ABI;
464        // gating here keeps every non-native compile (all frozen fixtures) on the
465        // legacy R9 globals-table path, bit-identical.
466        if config.native_pointer_abi
467            && let Some((sp_idx, sp_init)) = config.stack_pointer_global
468        {
469            selector.set_native_pointer_stack(sp_idx, sp_init);
470        }
471        // #643: per-global slot widths — i64/f64 globals occupy 8-byte slots
472        // (register-pair store/load) and shift every later global's offset.
473        // Empty for i32-only modules ⇒ the legacy `idx * 4` layout, unchanged.
474        selector.set_global_widths(config.global_widths.clone());
475        selector.set_spill_on_exhaustion(spill_on_exhaustion);
476        selector.set_param_backing_on_exhaustion(param_backing_on_exhaustion);
477        // #587 pool-grow rung: a larger i64 spill-slot pool, set ONLY on the
478        // retry after an attempt failed with the slot-pool-exhausted Err —
479        // functions that compile with the default pool keep their frame
480        // byte-identical by construction.
481        if let Some(slots) = i64_spill_slots {
482            selector.set_i64_spill_slots(slots);
483        }
484        // VCR-RA local promotion (#390, #242): keep eligible non-param i32 locals
485        // in callee-saved registers instead of frame slots — the structural lever
486        // toward native parity. DEFAULT-ON as of v0.14.0: gale's G474RE DWT gate
487        // cleared it as a net win (gust_mix dissolved 58→50 cyc/call −14%, all 5
488        // stack spill/reloads eliminated, correctness bit-identical over [0,2047],
489        // 2.00×→1.72× vs LLVM). Escape hatch: `SYNTH_NO_LOCAL_PROMOTE=1` restores
490        // the frame-slot path. Leaf-only / i32-only / ARM-only (see
491        // compute_local_promotion); the leaf-only lift + i64 locals are follow-ons.
492        // #474: `local_promote` is now a per-attempt parameter so the retry ladder
493        // can drop promotion as an exhaustion-recovery rung (promotion pins r4-r8,
494        // which on a dense function leaves the spill allocator with nothing to
495        // free → the frame-slot path is the escape that restores compilability).
496        selector.set_local_promote(local_promote);
497        // #494 phase 2b: certificate-discharged div/rem trap-guard elision
498        // marks (empty in every compile without SYNTH_FACT_SPEC + facts).
499        selector
500            .set_fact_div_guard_elisions(fact_div_zero_elide.to_vec(), fact_div_ovf_elide.to_vec());
501        // #494 bounds-elision: certificate-discharged memory bounds-guard
502        // marks (empty in every compile without SYNTH_FACT_SPEC + facts).
503        selector.set_fact_mem_bounds_elisions(fact_mem_bounds_elide.to_vec());
504        selector.select_with_stack(wasm_ops, num_params)
505    };
506    let select_direct = || -> Result<Vec<ArmInstruction>, String> {
507        const SINGLE_EXHAUSTION: &str = "all allocatable registers are live on the stack";
508        const PAIR_EXHAUSTION: &str = "no consecutive pair of free registers for i64";
509        const SLOT_EXHAUSTION: &str = "i64 spill-slot pool exhausted";
510        // The full exhaustion-recovery ladder, parameterized on whether local
511        // promotion is enabled. Each rung is reached only when the previous one
512        // returned a recoverable register-exhaustion Err, so a function that
513        // compiles on the first attempt is untouched by the later rungs. Returns
514        // the result AND which rung produced it (for the #242 measurement below).
515        let recovery_ladder =
516            |promote: bool,
517             i64_spill_slots: Option<usize>|
518             -> (Result<Vec<ArmInstruction>, synth_core::Error>, &'static str) {
519                let mut attempt = select_direct_attempt(false, false, promote, i64_spill_slots);
520                let mut rung = "base";
521                // VCR-RA-001 step 3b-lite (#242): the i32 register-exhaustion
522                // hard-fail is recoverable — retry with spill-on-exhaustion, which
523                // reserves the spill area and spills the deepest stack value when
524                // the pool is full.
525                if let Err(e) = &attempt
526                    && e.to_string().contains(SINGLE_EXHAUSTION)
527                {
528                    attempt = select_direct_attempt(true, false, promote, i64_spill_slots);
529                    rung = "spill";
530                }
531                // VCR-RA-001 acceptance increment (#242): the i64 consecutive-PAIR
532                // exhaustion is recoverable too — not by stack spilling (the pair
533                // allocator already spills stack values, #171) but by frame-backing
534                // the params (#204) so they stop pinning R0-R3, with spill kept on.
535                if let Err(e) = &attempt
536                    && e.to_string().contains(PAIR_EXHAUSTION)
537                {
538                    attempt = select_direct_attempt(true, true, promote, i64_spill_slots);
539                    rung = "param-backing";
540                }
541                (attempt, rung)
542            };
543        // #474: local promotion (default-on since v0.14.0) is an OPTIMIZATION — it
544        // must never be the reason a function fails to compile. Run the full ladder
545        // with promotion first (so every function that compiles today is
546        // bit-identical), and if it still ends in register exhaustion, fall back to
547        // the promotion-off ladder (the v0.12.0 frame-slot lowering — exactly what
548        // the `SYNTH_NO_LOCAL_PROMOTE=1` workaround does, now automatic). Promotion
549        // pins r4-r8 for the locals; on a dense function that leaves the allocator
550        // with nothing to free, so dropping it restores compilability. The fallback
551        // is reached ONLY by functions that exhaust WITH promotion, so promotion-on
552        // output is untouched by construction (frozen byte gate stays green).
553        let promote = std::env::var("SYNTH_NO_LOCAL_PROMOTE").is_err();
554        // The full pre-#587 recovery sequence (promotion-on ladder, then the
555        // #474 promotion-off fallback), parameterized on the pool size so the
556        // pool-grow retry below reruns it verbatim.
557        let full_sequence = |slots: Option<usize>| -> (
558            Result<Vec<ArmInstruction>, synth_core::Error>,
559            &'static str,
560            bool,
561        ) {
562            let (mut attempt, mut rung) = recovery_ladder(promote, slots);
563            let mut promotion_dropped = false;
564            if promote
565                && attempt
566                    .as_ref()
567                    .err()
568                    .is_some_and(|e| e.to_string().contains("register exhaustion"))
569            {
570                let (rescued, off_rung) = recovery_ladder(false, slots);
571                if rescued.is_ok() {
572                    attempt = rescued;
573                    rung = off_rung;
574                    promotion_dropped = true;
575                }
576            }
577            (attempt, rung, promotion_dropped)
578        };
579        let (mut attempt, mut rung, mut promotion_dropped) = full_sequence(None);
580        // #587 pool-grow retry (the falcon func_60/func_73 remainder): the fixed
581        // 8-slot i64 spill pool can exhaust while spilling is otherwise working —
582        // an i64-dense function simply has more values simultaneously live than
583        // the pool holds. Rerun the ENTIRE sequence (every rung, both promotion
584        // modes) with the pool sized from a conservative operand-stack-depth
585        // bound: the number of simultaneously spilled values can never exceed
586        // the operand-stack depth, plus a few transient slots (the arg-move
587        // cycle resolver and call-result parking each borrow one). The selector
588        // clamps the request to its 12-bit-friendly cap; a function that still
589        // exhausts stays an honest loud skip. Deliberately LAST — after the #474
590        // promotion-off fallback — so any function that compiled yesterday
591        // (through any rung or fallback) is produced by exactly yesterday's
592        // path, byte-identical; the grown pool only ever fires for functions
593        // whose every existing escape ended in the slot-pool Err.
594        if attempt
595            .as_ref()
596            .err()
597            .is_some_and(|e| e.to_string().contains(SLOT_EXHAUSTION))
598        {
599            let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
600            let (grown, _, grown_dropped) = full_sequence(Some(depth.saturating_add(4)));
601            if grown.is_ok() {
602                attempt = grown;
603                rung = "pool-grow";
604                promotion_dropped = grown_dropped;
605            }
606        }
607        // VCR-RA measurement (#242): log which recovery rung produced the result,
608        // so the per-rung distribution across a corpus can be measured — the size
609        // of the failure surface a verified allocator must subsume (see
610        // scripts/repro/register_exhaustion_recovery_ladder.md). Logging only:
611        // emitted bytes are unchanged, so the frozen byte gate is unaffected.
612        if std::env::var("SYNTH_RECOVERY_STATS").is_ok() {
613            eprintln!(
614                "[recovery-stats] rung={rung}{} result={}",
615                if promotion_dropped {
616                    " promotion-off"
617                } else {
618                    ""
619                },
620                if attempt.is_ok() { "ok" } else { "exhausted" },
621            );
622        }
623        attempt.map_err(|e| format!("instruction selection failed: {}", e))
624    };
625
626    // Instruction selection: optimized or direct.
627    //
628    // #197: `--relocatable` (host-link ET_REL) forces the direct selector. The
629    // optimized path materializes an absolute linmem base (0x20000100) and does
630    // not preserve caller-saved registers across calls — both wrong for a
631    // host-linked object, where the linmem base arrives via `fp` at runtime and
632    // callees follow AAPCS. `select_with_stack` (now i64-spill capable after
633    // #171) handles fp-relative memory + caller-saved preservation correctly.
634    //
635    // #507: `br_table` is DROPPED during the optimized path's wasm→IR lowering
636    // (`optimize_full`), so `ir_to_arm` never sees the dispatch — it emits the
637    // arm bodies in fall-through sequence with no `cmp`/branch on the selector, a
638    // SILENT miscompile (every input hits the last arm). The selector value isn't
639    // even loaded. Because the drop happens before `ir_to_arm`, there's no `Err`
640    // to fall back on; detect it on the raw wasm op stream here and force the
641    // direct selector (`select_with_stack` lowers `br_table` correctly as a
642    // cmp-chain — confirmed on the `--relocatable` path). Same honest-degradation
643    // contract as the issue-#120 f32 decline: the function still compiles
644    // correctly, just without IR-level optimization. Frozen-safe: the frozen
645    // fixtures compile `--relocatable` (already direct), and no optimized-path
646    // fixture (control_step, flight_algo) contains `br_table`.
647    let has_br_table = wasm_ops
648        .iter()
649        .any(|op| matches!(op, WasmOp::BrTable { .. }));
650    // #509: the optimized path also drops the value carried by a `br`/`br_if`
651    // to a result-typed block (the taken edge returns the wrong arm's value —
652    // same silent-miscompile class as the #507 br_table drop). Route the shape
653    // to the direct selector, whose designated-result-register lowering (#509)
654    // lands the carried value at the join. Never fires for void-block control
655    // flow (all frozen/optimized fixtures), so those stay byte-identical.
656    let has_value_carry = has_value_carrying_branch(wasm_ops, &config.current_func_block_arity);
657    // #503-i64/#518: route any signature with a 64-bit (i64/f64) param to the
658    // direct selector. The optimized path's param homing is width-naive — its
659    // #518 decline covers only functions that READ an i64 param (an `I64Load`
660    // from a param index), so a function that reads an i32 param whose AAPCS
661    // home a preceding wide param SHIFTED (e.g. p1 of `(i64 i32)` lives in R2,
662    // not R1; p3 of `(i64 i32 i32 i32)` lives on the stack, not in R3) was
663    // silently miscompiled rather than falling back. The direct selector's
664    // `aapcs_param_layout` homing handles every such shape (i64-param READS
665    // already fell back to it via the ir_to_arm Err, so those functions emit
666    // the same bytes as before). `num_params` counts read-first locals, so a
667    // function that never touches any param keeps the optimized path.
668    let has_wide_param = config
669        .current_func_params_i64
670        .iter()
671        .take(num_params as usize)
672        .any(|&w| w);
673    // #494 phase 2b: div/rem guard-elision marks are consumed by the DIRECT
674    // selector only — the optimized path's IR passes (const-fold/CSE/DCE)
675    // renumber instructions, so an op-index-keyed mark cannot soundly survive
676    // them. Route marked functions direct (the #507/#509 honest-degradation
677    // pattern). Never fires without SYNTH_FACT_SPEC + facts + a discharged
678    // obligation, so every existing compile keeps its path byte-identical.
679    let has_fact_div_elide = !fact_div_zero_elide.is_empty()
680        || !fact_div_ovf_elide.is_empty()
681        // #494 bounds-elision: memory bounds-guard marks are direct-selector
682        // keyed for the same reason (IR passes renumber instructions).
683        || !fact_mem_bounds_elide.is_empty();
684    // #643: the optimized path's global lowering is width-naive — `GlobalGet`/
685    // `GlobalSet` are single-word `[R9, idx*4]` accesses, which (a) silently
686    // dropped the high word of every i64 global and (b) mis-address every
687    // global whose offset an earlier wide (i64/f64) slot shifted. When the
688    // module has any wide global, route every global-touching function to the
689    // direct selector, whose type-aware summed layout pairs the access (or
690    // declines loudly). Modules with only 4-byte globals — every existing
691    // fixture — keep the optimized path byte-identical.
692    let has_wide_global_module = config.global_widths.iter().any(|&w| w > 4);
693    let has_global_access = has_wide_global_module
694        && wasm_ops
695            .iter()
696            .any(|op| matches!(op, WasmOp::GlobalGet(_) | WasmOp::GlobalSet(_)));
697    // VCR-VER-001 (#242): `post_exhaust` scopes the post-exhaustion cleanup
698    // extensions to functions whose bytes the #580 spill-on-exhaustion
699    // machinery actually shaped (bridge-reported). Everything else — the
700    // direct path, non-exhausted optimized functions — stays byte-identical
701    // flag-on (the `vcr_ver_001_gate_242` lock's contract).
702    let (arm_instrs, post_exhaust) = if config.no_optimize
703        || config.relocatable
704        || has_br_table
705        || has_value_carry
706        || has_wide_param
707        || has_global_access
708        || has_fact_div_elide
709        // #457: route read-before-write non-param locals to the direct
710        // selector, whose prologue zero-init lands the wasm-mandated 0.
711        || has_rbw_local
712    {
713        if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
714            eprintln!("[path-debug] direct (pre-gate)");
715        }
716        (select_direct()?, false)
717    } else {
718        let opt_config = if config.loom_compat {
719            OptimizationConfig::loom_compat()
720        } else {
721            OptimizationConfig::all()
722        };
723
724        let mut bridge = OptimizerBridge::with_config(opt_config);
725        // #188: tell the bridge how many imports there are so it declines only
726        // LOCAL calls (and leaves import calls on the optimized path, keeping
727        // the #173 field-name relocation rewrite intact).
728        bridge.set_num_imports(config.num_imports);
729        // #543 Phase 2: thread the integrator-marked volatile DMA-window ranges
730        // (`--volatile-segment <base>:<len>`) to the bridge's address-caching
731        // levers — base-CSE (#468) excludes any access inside a marked range
732        // from its fold set, and the bridge-level const-CSE declines wholesale
733        // while any range is marked. Empty (the default) ⇒ byte-identical.
734        bridge.set_volatile_segments(config.volatile_segments.clone());
735        // #377: thread `--safety-bounds` to the bridge. Pre-fix the optimized
736        // path ignored it — `software`/`mask` were SILENT NO-OPS on the path
737        // that lowers the bulk of a flight loop's i32 loads/stores (byte-
738        // identical to `none`, while the safety manifest claimed otherwise).
739        // `Software` now emits the inline guard per access; `Masking` declines
740        // memory-accessing functions to the direct selector; `None`/`Mpu` are
741        // byte-identical to before.
742        bridge.set_bounds_check(bounds_config);
743        // #687: thread the absolute linear-memory base the optimized path
744        // materializes. Defaults to 0x2000_0100 (byte-identical);
745        // `--stack-layout=low` shifts it up by the reserved stack size so
746        // const-address accesses follow the moved linear memory.
747        bridge.set_linmem_base(config.linmem_base);
748        // `ir_to_arm` now returns `Result` — an `Err` means the optimized path
749        // hit an unmapped vreg (issue-#93-class). Treat it identically to an
750        // `optimize_full` failure: fall back to the direct selector rather
751        // than propagating, so the function still compiles correctly.
752        match bridge
753            .optimize_full(wasm_ops)
754            .and_then(|(opt_ir, _cfg, _stats)| bridge.ir_to_arm(&opt_ir, num_params as usize))
755        {
756            Ok(arm_ops) => {
757                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
758                    eprintln!("[path-debug] optimized (ir_to_arm ok)");
759                }
760                (
761                    arm_ops
762                        .into_iter()
763                        .map(|op| ArmInstruction {
764                            op,
765                            source_line: None,
766                        })
767                        .collect(),
768                    bridge.spill_on_exhaust_fired(),
769                )
770            }
771            // Issue #120: the optimized path declines modules it cannot lower
772            // (notably scalar f32/f64 ops — the IR has no float opcodes). Fall
773            // back to the direct instruction selector, which handles f32 via
774            // VFP/FPU. This is honest degradation: the function still compiles
775            // correctly, just without IR-level optimization.
776            Err(e) => {
777                if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
778                    eprintln!("[path-debug] direct (fallback: {e})");
779                }
780                (select_direct()?, false)
781            }
782        }
783    };
784
785    // #257/#277: `mul`+`add`→`mla` fusion is intentionally NOT wired here.
786    // The transform is correct and ready (`synth_synthesis::liveness::fuse_mul_add`,
787    // fully tested), but it is **register-allocation-coupled**: over the current
788    // greedy single-pass selector, folding `mul rM,..; add rD,rM,rX` → `mla`
789    // extends the live ranges of the mul inputs to the mla point, and the added
790    // pressure (extra moves/spills) costs more than the single-cycle MLA saves —
791    // gale measured a +2 cyc on-target REGRESSION (flat_flight 255→257, G474RE)
792    // even though it removes 2 instructions and the seam stays 0x07FDF307. So the
793    // fusion stays unwired until the spill-aware allocator (VCR-RA-001) chooses
794    // registers, at which point it becomes net-positive (per #272's plan and the
795    // wiring design note). Lesson (#277): a register-pressure-affecting transform
796    // needs an on-target/allocator-aware gate, not a byte-count gate, before it
797    // can default on.
798
799    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209): moved to run
800    // LAST, after the immediate-folds — see the apply_const_cse call below
801    // (#242). Earlier it ran here (before range-realloc and the folds), which is
802    // what let it grow gale's --relocatable `gust_mix` 90→92 B (#242 burndown,
803    // 2026-06-26): retargeting a read defeated a *downstream* immediate-fold that
804    // would otherwise have absorbed the constant. Running CSE-last makes those
805    // foldable consts already-folded-and-gone, so CSE only ever touches genuinely
806    // redundant materializations.
807
808    // VCR-RA-001 RANGE RE-ALLOCATION (#209/#242, wiring step 3a) — the first
809    // CONSEQUENTIAL allocator pass: re-colour each maximal straight-line
810    // segment over the R0-R8 pool with value ranges as the allocation unit
811    // (segment inputs + per-register live-outs pinned to their original
812    // registers, reserved R9-R12/SP identity-assigned — each segment is
813    // independently sound, no cross-segment liveness assumed). Renames
814    // registers only: never adds, removes, or reorders instructions, so
815    // labels/branch offsets are unaffected.
816    //
817    // DEFAULT-ON since v0.11.36: gale cleared the gate on-target (G474RE,
818    // #209 2026-06-10) — flag-on output byte-identical to flag-off on
819    // flat_flight/controller/control_step, fires on the filter family with
820    // zero cycle delta and a small size win, all selfchecks green on silicon.
821    // Opt out with `SYNTH_RANGE_REALLOC=0`; per-function stats with
822    // `SYNTH_REALLOC_STATS=1`.
823    //
824    // The companion dead callee-saved-save elimination (gale's "next
825    // consequential lever", same issue comment) then shrinks the prologue
826    // `push {r4-r8,lr}` / epilogue `pop {r4-r8,pc}` to the callee-saved
827    // registers the re-allocated body still touches (leaf-only,
828    // SP-untouched, even-count-padded — see shrink_callee_saved_saves):
829    // ~12 cycles of pure save/restore overhead removed on small leaves.
830    let realloc_on = std::env::var("SYNTH_RANGE_REALLOC").map_or(true, |v| v != "0");
831    let arm_instrs = if realloc_on {
832        use synth_synthesis::rules::Reg;
833        const POOL: [Reg; 9] = [
834            Reg::R0,
835            Reg::R1,
836            Reg::R2,
837            Reg::R3,
838            Reg::R4,
839            Reg::R5,
840            Reg::R6,
841            Reg::R7,
842            Reg::R8,
843        ];
844        // VCR-VER-001 (#242): on a function the spill-on-exhaustion machinery
845        // shaped, the terminal segment gets relaxed live-out pinning (only
846        // R0/R1 are observable past `bx lr` at this pre-prologue position) so
847        // the colourer can lower R4-R8-homed tails into caller-saved R0-R3 —
848        // shrinking the `push {r4-r8,lr}` the #580 exhaustion shapes pay for.
849        // `post_exhaust == false` selects the shipping pass bit for bit.
850        let (out, stats) = synth_synthesis::liveness::reallocate_function_post_exhaust(
851            &arm_instrs,
852            &POOL,
853            post_exhaust,
854        );
855        if std::env::var("SYNTH_REALLOC_STATS").is_ok() {
856            eprintln!(
857                "[range-realloc] {} segments: {} reallocated, {} declined ({} validator-rejected), {} need spill (step 4)",
858                stats.segments,
859                stats.reallocated,
860                stats.declined,
861                stats.validator_rejects,
862                stats.needs_spill
863            );
864        }
865        // VCR-RA-002 (#390, epic #242): eliminate a provably-dead stack frame
866        // (`sub sp,#N`/`add sp,#N` reserved by `compute_local_layout` for locals
867        // that promotion homed in registers, never accessed). Removing it saves
868        // the two instructions AND restores the SP-untouched precondition that
869        // `shrink_callee_saved_saves` requires — so it must run FIRST.
870        // DEFAULT-ON (#242 flag audit flip-wave, #592 audit item): evidence
871        // basis was the 2-path × repro-corpus sweep — 0 functions grow, 58
872        // shrink (flight_seam controller_step 250→242 −8 / filter_step 180→168
873        // −12, native_pointer frame_roundtrip 46→34 −12), locked by the
874        // `dead_frame_elim_no_grow_corpus_242` cargo gate; execution
875        // differentials re-run green on the new default bytes BEFORE the
876        // frozen ARM anchors were re-pinned (leaf_dead_frame, flight_seam,
877        // frame_slot_dce — see the flip PR). Escape hatch:
878        // `SYNTH_DEAD_FRAME_ELIM=0` opts out and restores the pre-flip bytes
879        // (CI-gated in `frozen_codegen_bytes.rs`).
880        let out = if !std::env::var("SYNTH_DEAD_FRAME_ELIM").is_ok_and(|v| v == "0") {
881            synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out)
882        } else {
883            out
884        };
885        // #490 (epic #242): the optimized selector uses r4-r8 as scratch /
886        // promoted locals but emits no prologue, silently clobbering a caller's
887        // callee-saved registers. Add the missing `push {r4-r8,lr}` /
888        // `pop {r4-r8,pc}` HERE — on the post-realloc body, where realloc has
889        // lowered low-pressure r4-r8 scratch back to r0-r3, so a save is added
890        // only for registers genuinely clobbered. `shrink_callee_saved_saves`
891        // (next) then trims it to the used set. No-op on the direct path (it
892        // already has its own prologue) and on callee-saved-free leaves.
893        let out = synth_synthesis::liveness::ensure_callee_saved_prologue(&out);
894        synth_synthesis::liveness::shrink_callee_saved_saves(&out).unwrap_or(out)
895    } else {
896        // Range-realloc off (`SYNTH_RANGE_REALLOC=0`): the optimized path still
897        // must preserve the callee-saved registers it clobbers (#490). No shrink
898        // (it is coupled to the realloc lever), so the conservative full save
899        // stays — correct, just not minimised in this debug configuration.
900        synth_synthesis::liveness::ensure_callee_saved_prologue(&arm_instrs)
901    };
902
903    // VCR-RA-001 SHADOW ALLOCATION (#209/#242): run the register allocator on
904    // the selected stream and LOG what it finds — without changing a single
905    // emitted byte. This is the measure-only bridge between the built analysis
906    // layer and the eventual virtual-register wiring: it shows, per real
907    // function, whether the allocator can colour it within the R0–R8 pool and
908    // how much const-CSE / rematerialization headroom exists (#209). Enable with
909    // `SYNTH_SHADOW_ALLOC=1`; off by default and side-effect-free either way.
910    if std::env::var("SYNTH_SHADOW_ALLOC").is_ok() {
911        use synth_synthesis::liveness::{
912            AllocationOutcome, allocate_function, function_peak_pressure,
913        };
914        // R9 globals / R10 mem-size / R11 mem-base / R12 IP-scratch are reserved;
915        // pin them above the 0..9 allocatable pool so the colourer keeps R0–R8.
916        let precolored = std::collections::BTreeMap::from([
917            (synth_synthesis::rules::Reg::R9, 9usize),
918            (synth_synthesis::rules::Reg::R10, 10),
919            (synth_synthesis::rules::Reg::R11, 11),
920            (synth_synthesis::rules::Reg::R12, 12),
921        ]);
922        // True VALUE pressure (one node per value, not per reused physical reg):
923        // a NeedsSpill with peak ≤ 9 is a SPURIOUS physical-register spill — the
924        // function fits once virtually allocated.
925        let peak = function_peak_pressure(&arm_instrs);
926        match allocate_function(&arm_instrs, 9, &precolored) {
927            AllocationOutcome::Allocated {
928                remat_opportunities,
929                coloring,
930            } => eprintln!(
931                "[shadow-alloc] OK: {} pregs coloured within R0-R8 pool, peak value-pressure {}, {} const-CSE/remat opportunities",
932                coloring.len(),
933                peak,
934                remat_opportunities
935            ),
936            AllocationOutcome::NeedsSpill(s) => eprintln!(
937                "[shadow-alloc] physical-graph would spill {:?}, but peak value-pressure is {} (≤9 ⇒ spurious; fits once virtually allocated)",
938                s, peak
939            ),
940            AllocationOutcome::Declined => {
941                eprintln!(
942                    "[shadow-alloc] declined (unmodeled construct — calls/i64/fp/offset-branch)"
943                )
944            }
945        }
946    }
947
948    // VCR-SEL-004 cmp→select → IT-block predication fusion (#242). The selector
949    // lowers a `select` whose condition is a comparison to a *materialize then
950    // re-test* sequence (`cmp a,b; SetCond D,c; cmp D,#0; movne dst,v1; moveq
951    // dst,v2`); this collapses it onto the comparison's own flags — deleting the
952    // `SetCond` and the `cmp D,#0` and retargeting the predicated moves to `c` /
953    // `invert(c)` — yielding the textbook predicated clamp (`cmp a,b; movc dst,v1;
954    // mov{!c} dst,v2`). −2 instructions per fused select. gale #428 measured this
955    // as the #1 hot-path size/cycle lever on the gust_mix clamp chain.
956    //
957    // Run LATE: after range re-allocation (so the dead-D proof sees final register
958    // identities) and before encode. Removal-only + rename-only ⇒ no spill
959    // regression and labels/branch offsets are unaffected. Each fusion is proven
960    // sound (flags reused only when nothing clobbers them in the window; the
961    // boolean deleted only when provably dead) — see `fuse_cmp_select`.
962    //
963    // DEFAULT-ON as of v0.13.0 (#428): cmp→select fusion ships by default. The
964    // byte-changing flip is validated by (a) the unicorn execution oracle that runs
965    // the two-move `mov{invert(c)}` arm (cmp_select_two_move_differential.py), (b)
966    // gale's gale_decider_diff 10,596-case sweep across all 8 verified primitives
967    // (native ≡ flag-off ≡ flag-on = 0x88e73178d232bcf5), and (c) the named-anchor
968    // differentials re-run with fusion ON — control_step still 0x00210A55, flat+
969    // inlined flight_algo still 0x07FDF307 (results preserved; bytes deliberately
970    // changed, re-frozen on this commit). Escape hatch: `SYNTH_NO_CMP_SELECT_FUSE=1`
971    // reverts to the pre-fusion lowering. The on-silicon G474RE DWT no-regression
972    // check is a tracked post-ship follow-up (gale owns it).
973    let arm_instrs = if std::env::var("SYNTH_NO_CMP_SELECT_FUSE").is_err() {
974        // The rewritten stream is identical to `fuse_cmp_select`'s 2-tuple form;
975        // the extra `two_move` count is diagnostic only (the fusion census /
976        // blast-radius datum — #7 made that arm reachable).
977        let (out, fused, two_move) =
978            synth_synthesis::liveness::fuse_cmp_select_with_stats(&arm_instrs);
979        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
980            let in_place = fused - two_move;
981            eprintln!(
982                "[cmp-select-fuse] {fused} select(s) fused to predicated moves \
983                 ({two_move} two-move, {in_place} in-place)"
984            );
985        }
986        out
987    } else {
988        arm_instrs
989    };
990
991    // Perf lever 1 toward native parity (#390): redundant stack-reload elimination.
992    // synth lowers every wasm local to a frame slot, so `local.set; local.get` emits
993    // `str rX,[sp,#N]; … ; ldr rY,[sp,#N]`; when rX still holds the value the reload
994    // (a ~2-cycle M4 load) becomes `mov rY,rX`. Removal-of-a-load + rename only ⇒ no
995    // new instruction form and no label/offset change. DEFAULT-ON (#242 feature
996    // loop): validated bit-identical RESULTS on every frozen anchor (control_step
997    // 0x00210A55 13/13, flat+inlined flight_algo 0x07FDF307) with .text reduced on
998    // the shipped --relocatable path, plus 8 unit tests + the frame_slot_dce
999    // execution differential — the same gated path cmp→select took to default-on in
1000    // v0.13.0 (G474RE silicon confirms perf post-ship). Escape hatch:
1001    // `SYNTH_NO_STACK_FWD=1` restores the frame-resident bytes (frozen-old goldens).
1002    let stack_fwd = std::env::var("SYNTH_NO_STACK_FWD").is_err();
1003    let arm_instrs = if stack_fwd {
1004        let (out, fwd) = synth_synthesis::liveness::forward_stack_reloads(&arm_instrs);
1005        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1006            eprintln!("[stack-fwd] {fwd} stack reload(s) forwarded to register moves");
1007        }
1008        out
1009    } else {
1010        arm_instrs
1011    };
1012
1013    // VCR-RA frame-slot DCE (#242): once `forward_stack_reloads` has turned the
1014    // reloads of a spill slot into register moves, the `str rX,[sp,#N]` that fed
1015    // them is a dead store — its slot is never loaded again. Remove it. Pairs
1016    // with (and only pays after) stack-reload forwarding, so it shares the flag.
1017    let arm_instrs = if stack_fwd {
1018        let (out, n) = synth_synthesis::liveness::eliminate_dead_frame_stores(&arm_instrs);
1019        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1020            eprintln!("[frame-slot-dce] {n} dead frame store(s) removed");
1021        }
1022        out
1023    } else {
1024        arm_instrs
1025    };
1026
1027    // VCR-RA-001 spill re-choice (#242), two stages behind one flag.
1028    // Stage 1 (the #569 spike): slot-value forwarding BETWEEN reloads.
1029    // `forward_stack_reloads` (above) forwards only from a spill store's
1030    // SOURCE register, so when register pressure clobbers that source its
1031    // reloads survive; this stage tracks which registers provably still hold
1032    // a frame slot's value (through earlier reloads and reg-reg moves) and
1033    // turns reload #2..#n into a 1-cycle `mov` (or deletes it when the target
1034    // already holds the value). Stage 2 (the Belady re-choice): where NO
1035    // register still holds the value — the genuine-spill case, flat_flight's
1036    // peak-11 hot segment — the value was usually evicted while a dead
1037    // register existed; the clobbering def(s) are renamed onto a provably-dead
1038    // register (`spill_rechoice_segment`) so the value stays resident and the
1039    // reload dissolves outright. A dissolved reload can leave the feeding
1040    // store dead, so the frame-slot DCE sweep runs once more behind the same
1041    // flag. Per-segment commit gates: executable same-value-flow trace
1042    // equality, strict shrink, pool-pressure fit, sub-word/unknown-slot
1043    // conservatism (see `apply_spill_realloc` / `spill_rechoice_segment`).
1044    // Stage 3 (whole-function slot liveness): the segment-local DCE keeps a
1045    // store whose slot reaches function end ("reach-end ≠ dead" — it cannot
1046    // see other segments); `eliminate_unread_frame_stores` walks the whole
1047    // function (labels/branches/loops, SP-displacement tracked) and drops a
1048    // store whose slot NO reachable instruction can read — flat_flight's two
1049    // surviving stores (#576), completing Belady's 0-load side with a 0-store
1050    // side. Same flag: the three stages are one lever, flipped together.
1051    // DEFAULT-ON (#242 feature loop, the v0.14.0 local-promotion pattern):
1052    // Belady spilling ships by default. Evidence basis for the flip: three
1053    // landed flag-off increments (#569 forwarding, #576 Belady re-choice,
1054    // #579 whole-fn slot liveness), 40+ functions shrink / 0 grow across the
1055    // 68-fixture × 2-path sweep, per-segment executable value-trace equality
1056    // guards, and the unicorn-vs-wasmtime execution differentials re-run
1057    // green on the new default bytes (flat+inlined flight_algo 0x07FDF307,
1058    // const_cse, frame_slot_dce, spill_rung_581, r12_spill_496 — which covers
1059    // control_step_decide vs wasmtime; control_step's .text is byte-identical
1060    // under the flip) BEFORE the frozen goldens were re-pinned. Escape hatch:
1061    // `SYNTH_SPILL_REALLOC=0` is the OPT-OUT — it disables all three stages
1062    // and restores the pre-flip bytes (CI-gated by
1063    // `frozen_fixtures_spill_realloc_escape_hatch_restores_old_bytes`). Any
1064    // other value (or unset) runs the pass.
1065    // VCR-VER-001 post-exhaustion extensions (#242, the PR #659 verdict): with
1066    // `SYNTH_SPILL_ON_EXHAUST` active the #580 allocation-time Belady spill
1067    // keeps exhausted functions on the optimized path, and its slots present
1068    // shapes the shipping pass structurally cannot fire on (fresh-monotonic
1069    // slots defeat the overwrite-only DCE; the eviction store's source is
1070    // redefined immediately, defeating store→reload forwarding; R2/R3 are
1071    // never touched again, so the rename-target deadness proof declines them).
1072    // `post_exhaust` (bridge-scoped, see above) enables const
1073    // rematerialization of spilled constants, R2/R3 exit-dead rename targets,
1074    // and per-pair pressure commit — see `apply_spill_realloc_post_exhaust`.
1075    // Flag off (the default): `false` selects the shipping behavior bit for
1076    // bit.
1077    let arm_instrs = if !std::env::var("SYNTH_SPILL_REALLOC").is_ok_and(|v| v == "0") {
1078        let (out, n) =
1079            synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&arm_instrs, post_exhaust);
1080        let (out, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&out);
1081        let (mut out, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&out);
1082        let (mut tn, mut td, mut tu) = (n, d, u);
1083        // Post-exhaustion only: iterate the triple to a bounded fixpoint. Each
1084        // dissolved spill pair frees registers and removes stores, exposing
1085        // rename windows and holder chains the previous iteration could not
1086        // prove — the allocation-time Belady slots (#580) routinely need two
1087        // or three rounds where the shipping single round suffices for the
1088        // default path's slots. Every iteration is individually gate-proven
1089        // (value-trace equality, pool pressure, strict shrink), so iterating
1090        // composes soundly; the bound keeps compile time deterministic.
1091        if post_exhaust {
1092            let mut progress = n + d + u > 0;
1093            for _ in 0..3 {
1094                if !progress {
1095                    break;
1096                }
1097                let (o, n) =
1098                    synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&out, true);
1099                let (o, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&o);
1100                let (o, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&o);
1101                progress = n + d + u > 0;
1102                (tn, td, tu) = (tn + n, td + d, tu + u);
1103                out = o;
1104            }
1105            // The cleanup can leave the spill frame with zero surviving
1106            // accesses (every reload rematerialized/dissolved, every store
1107            // swept) — the balanced `sub sp,#K`/`add sp,#K` is then pure
1108            // overhead. `elide_dead_frame` proves that and removes the pair;
1109            // its early run (post-realloc) could not, because the spill
1110            // traffic was still in the stream at that point.
1111            out = synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out);
1112        }
1113        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1114            eprintln!(
1115                "[spill-realloc] {tn} reload(s) forwarded/eliminated, {td} newly-dead frame store(s) removed, {tu} unread-slot store(s) removed"
1116            );
1117        }
1118        out
1119    } else {
1120        arm_instrs
1121    };
1122
1123    // VCR-RA immediate-shift folding (#390, #242): a constant shift amount the
1124    // stack selector materialized into a scratch register (`movw rM,#C; lsl rD,rN,rM`)
1125    // folds to the immediate form (`lsl rD,rN,#C`), removing the dead `movw` — −1
1126    // instruction, −1 live register. Removal-only (offset-neutral before branch
1127    // resolution, like the dead-store pass). DEFAULT-ON as of v0.15.0: validated
1128    // bit-identical results + a net cycle win on the dissolved hot path (−2
1129    // cyc/call, .text 100→90 B on gust_mix). Escape hatch: `SYNTH_NO_IMM_SHIFT_FOLD=1`.
1130    let arm_instrs = if std::env::var("SYNTH_NO_IMM_SHIFT_FOLD").is_err() {
1131        let (out, folds) = synth_synthesis::liveness::fold_immediate_shifts(&arm_instrs);
1132        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1133            eprintln!(
1134                "[imm-shift-fold] {folds} register shift(s) folded to immediate, movw dropped"
1135            );
1136        }
1137        out
1138    } else {
1139        arm_instrs
1140    };
1141
1142    // #686: elide the #682 mod-32 shift-amount mask (`and r12,rK,#31` before
1143    // every register-controlled i32 shl/shr) when the amount is STATICALLY
1144    // provable < 32 — a const amount folds to the immediate-shift form
1145    // (reduced mod 32, so >= 32 shrinks too), and an already-masked amount
1146    // (`rK = rX & c`, c < 32) drops the redundant re-mask. gale measured the
1147    // unconditional mask at ~12% cyc/call (+14 B) on gust_mix, whose Q8
1148    // fixed-point shifts are all constants (#686). The mask stays wherever
1149    // the bound is unproven — elision is an optimization, the mask is the
1150    // sound default (`liveness::elide_shift_masks` has the proof
1151    // obligations). Runs after `fold_immediate_shifts` (whose movw→shift
1152    // window the #682 mask intercepts, so it declines every masked const
1153    // shift) and before branch resolution (removal/rewrite-only ⇒
1154    // offset-neutral).
1155    //
1156    // FLAG-OFF (opt-in via `SYNTH_SHIFT_MASK_ELIDE=1`) because the elision
1157    // moves the frozen anchors: const-amount shifts in control_step (−20 B),
1158    // flight_seam (−164 B) and flight_seam_flat (−168 B) fold back to the
1159    // immediate form — byte-shapes the corpus had BEFORE the #682 mask, now
1160    // with the mask soundly kept for every unproven amount. Flipping
1161    // default-on is a deliberate byte-changing refreeze (all differentials
1162    // re-run on the new bytes, goldens re-pinned) owned by the maintainer.
1163    let arm_instrs = if std::env::var("SYNTH_SHIFT_MASK_ELIDE").is_ok_and(|v| v != "0") {
1164        let (out, elisions) = synth_synthesis::liveness::elide_shift_masks(&arm_instrs);
1165        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1166            eprintln!(
1167                "[shift-mask-elide] {elisions} provably-<32 shift-amount mask(s) elided (#686)"
1168            );
1169        }
1170        out
1171    } else {
1172        arm_instrs
1173    };
1174
1175    // VCR-RA uxth/uxtb fold (#428, #242): `movw rM,#0xffff; and rD,rN,rM` →
1176    // `uxth rD,rN` (and the 0xff/uxtb form), removing the dead `movw` — −1
1177    // instruction, −1 live register per 16/8-bit mask. 0xffff/0xff are not Thumb-2
1178    // modified immediates so the selector materializes them into a register; the
1179    // dedicated zero-extend expresses the same masking inline. Removal-only +
1180    // rewrite-in-place (offset-neutral). DEFAULT-ON (#242 flag audit flip-wave,
1181    // #592 audit item): evidence basis was the 2-path × repro-corpus sweep —
1182    // 0 functions grow, 13 shrink (control_step 300→294 −6, gust_mix 38→32 −6,
1183    // uxth_fold pack 36→24 −12), locked by the `uxth_fold_no_grow_corpus_242`
1184    // cargo gate; execution differentials re-run green on the new default
1185    // bytes BEFORE the frozen ARM anchors were re-pinned (uxth_fold,
1186    // control_step — see the flip PR). Escape hatch: `SYNTH_UXTH_FOLD=0` opts
1187    // out and restores the pre-flip bytes (CI-gated in
1188    // `frozen_codegen_bytes.rs`).
1189    let arm_instrs = if !std::env::var("SYNTH_UXTH_FOLD").is_ok_and(|v| v == "0") {
1190        let (out, folds) = synth_synthesis::liveness::fold_uxth(&arm_instrs);
1191        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1192            eprintln!("[uxth-fold] {folds} mask-and folded to uxth/uxtb, movw dropped");
1193        }
1194        out
1195    } else {
1196        arm_instrs
1197    };
1198
1199    // VCR-RA-001 const-CSE / rematerialization-avoidance (#209, #242). Drops a
1200    // `movw`/`mov #imm` that re-materializes a constant already resident in
1201    // another register and retargets the reads — every rewrite proven by the
1202    // liveness analysis. Runs LAST, after every immediate-fold (shift, uxth) and
1203    // range-realloc, but BEFORE branch resolution/encoding (it removes
1204    // instructions, shifting byte offsets). CSE-last is the #242 no-regression
1205    // fix: the folds have already absorbed every foldable constant, so CSE can no
1206    // longer defeat one (the gust_mix 90→92 mechanism). The pass additionally
1207    // size-guards each segment via the byte-estimator — it commits a segment's
1208    // rewrites only if they do not grow its estimated size — so a retarget that
1209    // would flip a 16-bit encoding to 32-bit (higher base register) is declined.
1210    // DEFAULT-ON (#242 flip-wave, the SYNTH_SPILL_REALLOC/SYNTH_BASE_CSE
1211    // template): const-CSE ships by default. The flip prerequisites recorded in
1212    // `const_cse_reduction_242.rs` were retired first — the bridge-level INLINE
1213    // aliasing (the alias-eviction spill-bijection hazard) was DELETED from
1214    // `optimizer_bridge::ir_to_arm`, so this post-hoc, liveness-proven pass is
1215    // the flag's ONLY effect. Evidence basis: 152 fixture×path corpus sweep — 0
1216    // functions grow (size-guarded per segment), 40 shrink (const_cse::spill12
1217    // 236→148 B), total −536 B — and the execution differentials re-run green
1218    // on the new default bytes BEFORE the frozen goldens were re-pinned
1219    // (const_cse, frame_slot_dce, flight_seam 0x07FDF307, spill_rung_581,
1220    // volatile_segment_543, control_step 0x00210A55). Escape hatch:
1221    // `SYNTH_CONST_CSE=0` is the OPT-OUT — it restores the pre-flip bytes
1222    // (CI-gated by `const_cse_escape_hatch_restores_old_bytes_242` and the
1223    // frozen-anchor escape-hatch gate). Any other value (or unset) runs the pass.
1224    //
1225    // #543 Phase 2: const-CSE declines WHOLESALE while any volatile DMA range
1226    // (`--volatile-segment`) is marked. At the ArmOp level a cached constant
1227    // cannot be classified as address-vs-data (a retargeted read may be a
1228    // memory-access base carrying a per-use immediate offset), so the
1229    // conservative stance for statically-unknown addressing is to decline every
1230    // aliasing rewrite — each constant is re-materialized at each occurrence,
1231    // the documented volatile contract (`CompileConfig::volatile_segments`).
1232    let arm_instrs = if !std::env::var("SYNTH_CONST_CSE").is_ok_and(|v| v == "0")
1233        && config.volatile_segments.is_empty()
1234    {
1235        let (out, removed) = synth_synthesis::liveness::apply_const_cse(&arm_instrs);
1236        if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1237            eprintln!("[const-cse] {removed} redundant constant materialization(s) removed");
1238        }
1239        out
1240    } else {
1241        arm_instrs
1242    };
1243
1244    // VCR-RA-001 spill-choice REPORT (#242): measure-only, like SYNTH_SHADOW_ALLOC.
1245    // Per straight-line segment, the frame-slot traffic actually emitted vs the
1246    // reload/store count a farthest-next-use (Belady) allocation over the R0-R8
1247    // pool would need — the measured headroom for the full spill-choice rewrite.
1248    // Printed on the FINAL stream (post all rewrite passes), so a flag-off run
1249    // reports the greedy baseline and a flag-on run reports what remains.
1250    if std::env::var("SYNTH_SPILL_REPORT").is_ok() {
1251        for seg in synth_synthesis::liveness::spill_choice_report(&arm_instrs, 9) {
1252            if seg.actual_reloads + seg.actual_spill_stores > 0 || seg.peak_pressure > 9 {
1253                eprintln!(
1254                    "[spill-report] seg@{} len={} peak={} actual={}ld+{}st belady(k=9)={}ld+{}st",
1255                    seg.start,
1256                    seg.len,
1257                    seg.peak_pressure,
1258                    seg.actual_reloads,
1259                    seg.actual_spill_stores,
1260                    seg.belady_reloads,
1261                    seg.belady_spill_stores
1262                );
1263            }
1264        }
1265    }
1266
1267    // ISA feature gate: validate that all generated instructions are supported
1268    // by the target. This catches FPU instructions on no-FPU targets, double-precision
1269    // instructions on single-precision targets, etc.
1270    validate_instructions(&arm_instrs, config.target.fpu, &config.target.triple)
1271        .map_err(|e| format!("ISA validation failed: {}", e))?;
1272
1273    // Encode to binary — use Thumb-2 for Cortex-M targets
1274    let use_thumb2 = matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb);
1275
1276    let encoder = if use_thumb2 {
1277        ArmEncoder::new_thumb2_with_fpu(config.target.fpu)
1278    } else {
1279        ArmEncoder::new_arm32()
1280    };
1281
1282    // #202: resolve local label branches (Bcc/B/Bhs/Blo) to byte-accurate
1283    // offsets before encoding. `select_with_stack` emits them as label
1284    // placeholders and never resolves them — without this they encode as
1285    // `bne.n #0` and land mid-instruction whenever a 32-bit Thumb-2 instruction
1286    // sits between the branch and its target (UsageFault on real hardware).
1287    // Only meaningful for Thumb-2 (the offset units are halfword/PC+4).
1288    let arm_instrs = if use_thumb2 {
1289        resolve_label_branches(arm_instrs, &encoder)?
1290    } else {
1291        arm_instrs
1292    };
1293
1294    let mut code = Vec::new();
1295    let mut relocations = Vec::new();
1296
1297    // #345: literal-pool address loads. Each `LdrSym` was encoded as a placeholder
1298    // `LDR.W rd,[pc,#0]`; record where its instruction sits and what it loads so
1299    // we can append a pooled word (carrying the symbol address via R_ARM_ABS32)
1300    // and patch the PC-relative offset once the pool position is known.
1301    struct PendingLiteral {
1302        ldr_offset: u32,
1303        symbol: String,
1304        addend: i32,
1305    }
1306    let mut pending_literals: Vec<PendingLiteral> = Vec::new();
1307
1308    // VCR-DBG-001: per-instruction source map for DWARF `.debug_line`. Captured
1309    // here because `code.len()` immediately before `encode()` is the final
1310    // machine offset of the instruction within this function's `.text` — nothing
1311    // after the loop shifts earlier instructions (the literal pool is appended at
1312    // the end; the LDR patch below is in-place/length-preserving). Purely
1313    // additive: it does not touch `code`, so `.text` is byte-identical.
1314    let mut line_map: LineMap = Vec::new();
1315
1316    for instr in &arm_instrs {
1317        // Record a relocation for every BL: the encoder emits `bl #0` and
1318        // relies on a relocation to patch the target. This covers BOTH import
1319        // dispatch stubs (`__meld_*`, undefined externals) AND internal calls
1320        // (`func_N`, defined in this object). Previously only `__meld_*` was
1321        // recorded, so internal `BL func_N` calls were left as unpatched
1322        // `bl #0` placeholders branching to a garbage address (#167).
1323        if let ArmOp::Bl { label } = &instr.op {
1324            relocations.push(CodeRelocation {
1325                offset: code.len() as u32,
1326                symbol: label.clone(),
1327                kind: synth_core::backend::RelocKind::ThmCall,
1328            });
1329        }
1330        // #237: symbol-relative MOVW/MOVT (the `--native-pointer-abi` static-data
1331        // addressing). The encoder writes the addend in place; record the matching
1332        // R_ARM_MOVW_ABS_NC / R_ARM_MOVT_ABS so the linker adds the symbol address.
1333        if let ArmOp::MovwSym { symbol, .. } = &instr.op {
1334            relocations.push(CodeRelocation {
1335                offset: code.len() as u32,
1336                symbol: symbol.clone(),
1337                kind: synth_core::backend::RelocKind::MovwAbs,
1338            });
1339        }
1340        if let ArmOp::MovtSym { symbol, .. } = &instr.op {
1341            relocations.push(CodeRelocation {
1342                offset: code.len() as u32,
1343                symbol: symbol.clone(),
1344                kind: synth_core::backend::RelocKind::MovtAbs,
1345            });
1346        }
1347        // #345: defer the literal-pool word + reloc + offset patch to the
1348        // post-loop pass (the pool address is not yet known).
1349        if let ArmOp::LdrSym { symbol, addend, .. } = &instr.op {
1350            pending_literals.push(PendingLiteral {
1351                ldr_offset: code.len() as u32,
1352                symbol: symbol.clone(),
1353                addend: *addend,
1354            });
1355        }
1356
1357        // The machine offset of this instruction is the current code length,
1358        // captured before the bytes are appended.
1359        line_map.push((code.len() as u32, instr.source_line));
1360
1361        let encoded = encoder
1362            .encode(&instr.op)
1363            .map_err(|e| format!("ARM encoding failed: {}", e))?;
1364        code.extend_from_slice(&encoded);
1365    }
1366
1367    // #345: place the literal pool at the end of this function's `.text`. Gated on
1368    // there being at least one `LdrSym` — functions without one are byte-identical
1369    // to before (no trailing padding, so downstream `func_offsets` are unchanged
1370    // and the frozen differential fixtures stay bit-for-bit equal).
1371    if !pending_literals.is_empty() {
1372        if !use_thumb2 {
1373            return Err("LdrSym literal-pool addressing requires Thumb-2".to_string());
1374        }
1375        // 4-byte align the pool start (Thumb-2 word loads require it, and
1376        // `Align(PC,4)` in the LDR-literal semantics assumes a word-aligned pool).
1377        while code.len() % 4 != 0 {
1378            code.push(0x00);
1379        }
1380        // One distinct pooled word per LdrSym (no dedup: different sites carry
1381        // different addends, and the REL addend lives in the word).
1382        for lit in &pending_literals {
1383            let word_offset = code.len() as u32;
1384
1385            // REL semantics: the linker computes `S + A`, where A is the in-place
1386            // value of the relocated word. Initialize the word to the addend so
1387            // the final loaded address is `symbol + addend`.
1388            code.extend_from_slice(&(lit.addend as u32).to_le_bytes());
1389            relocations.push(CodeRelocation {
1390                offset: word_offset,
1391                symbol: lit.symbol.clone(),
1392                kind: synth_core::backend::RelocKind::Abs32,
1393            });
1394
1395            // Patch the placeholder `LDR.W rd,[pc,#imm12]`. Thumb-2 LDR (literal):
1396            // address = Align(PC,4) + imm12, with PC = ldr_offset + 4. The pool is
1397            // always after the LDR, so U=1 (already set in hw1 = 0xF8DF).
1398            let pc = lit.ldr_offset + 4;
1399            let aligned_pc = pc & !3u32;
1400            let imm12 = word_offset - aligned_pc;
1401            if imm12 > 0xFFF {
1402                // Wide LDR-literal range is ±4 KB; these function bodies are far
1403                // smaller, but fail cleanly rather than miscompile if exceeded.
1404                return Err(format!(
1405                    "LdrSym literal pool out of range (#345): imm12={} > 4095 \
1406                     for symbol {}",
1407                    imm12, lit.symbol
1408                ));
1409            }
1410            let hw2_off = (lit.ldr_offset + 2) as usize;
1411            let mut hw2 = u16::from_le_bytes([code[hw2_off], code[hw2_off + 1]]);
1412            hw2 = (hw2 & 0xF000) | (imm12 as u16); // keep Rt, set imm12
1413            let hw2_bytes = hw2.to_le_bytes();
1414            code[hw2_off] = hw2_bytes[0];
1415            code[hw2_off + 1] = hw2_bytes[1];
1416        }
1417    }
1418
1419    Ok((code, relocations, line_map))
1420}
1421
1422/// Resolve local label branches to byte-accurate offsets (#202).
1423///
1424/// `select_with_stack` emits conditional/unconditional branches as label
1425/// placeholders (`Bcc`/`B`/`Bhs`/`Blo` + `Label`) and never resolves them; the
1426/// encoder then emits a `0xD000`/`0xE000` placeholder with offset 0. Before #197
1427/// this path only ran for `--no-optimize`/declined functions, so the latent bug
1428/// stayed hidden — routing relocatable code through it surfaced branches that
1429/// land mid-instruction (a Cortex-M UsageFault) whenever a 32-bit Thumb-2
1430/// instruction sits between the branch and its target.
1431///
1432/// This pass encodes each instruction to learn its real byte length (so 16- vs
1433/// 32-bit forms and multi-instruction expansions are exact), maps each `Label`
1434/// to its byte position, and rewrites every label branch to the displacement
1435/// the encoder consumes: `(target - branch - 4) / 2` halfwords. A bounded
1436/// fixed-point handles an offset growing a branch from 16- to 32-bit (which
1437/// shifts later positions). `BCondOffset`/`BOffset` already produced inline by
1438/// the optimized path carry no label and are left untouched.
1439fn resolve_label_branches(
1440    arm_instrs: Vec<ArmInstruction>,
1441    encoder: &ArmEncoder,
1442) -> Result<Vec<ArmInstruction>, String> {
1443    use std::collections::HashMap;
1444    use synth_synthesis::Condition;
1445
1446    enum BKind {
1447        Cond(Condition),
1448        Uncond,
1449    }
1450    // Record each label branch ONCE — indices are stable across iterations.
1451    let mut branches: Vec<(usize, BKind, String)> = Vec::new();
1452    for (i, instr) in arm_instrs.iter().enumerate() {
1453        match &instr.op {
1454            ArmOp::Bcc { cond, label } => branches.push((i, BKind::Cond(*cond), label.clone())),
1455            ArmOp::Bhs { label } => branches.push((i, BKind::Cond(Condition::HS), label.clone())),
1456            ArmOp::Blo { label } => branches.push((i, BKind::Cond(Condition::LO), label.clone())),
1457            ArmOp::B { label } => branches.push((i, BKind::Uncond, label.clone())),
1458            _ => {}
1459        }
1460    }
1461    if branches.is_empty() {
1462        return Ok(arm_instrs);
1463    }
1464
1465    let mut resolved = arm_instrs;
1466    // Sizes only grow (16→32-bit), so this converges quickly; cap for safety.
1467    for _ in 0..16 {
1468        // 1. Byte position of each instruction (Label encodes to 0 bytes).
1469        let mut positions = Vec::with_capacity(resolved.len());
1470        let mut pos: i64 = 0;
1471        for instr in &resolved {
1472            positions.push(pos);
1473            pos += encoder
1474                .encode(&instr.op)
1475                .map_err(|e| format!("branch-resolve size probe failed: {}", e))?
1476                .len() as i64;
1477        }
1478        // 2. Label name -> byte position (owned keys so the borrow ends here).
1479        let mut labels: HashMap<String, i64> = HashMap::new();
1480        for (i, instr) in resolved.iter().enumerate() {
1481            if let ArmOp::Label { name } = &instr.op {
1482                labels.insert(name.clone(), positions[i]);
1483            }
1484        }
1485        // 3. Rewrite each branch to its byte-accurate offset.
1486        let mut changed = false;
1487        for (idx, kind, label) in &branches {
1488            // A label not defined locally is an EXTERNAL target (e.g.
1489            // `Trap_Handler` resolved by a relocation / the vector table). Leave
1490            // such branches as their placeholder for the existing relocation
1491            // path — only local control-flow labels are byte-resolved here.
1492            let Some(&target) = labels.get(label) else {
1493                continue;
1494            };
1495            // Encoder consumes the field as (target - branch - 4) / 2 halfwords.
1496            // Positions are always even, so this division is exact.
1497            let halfword_offset = ((target - positions[*idx] - 4) / 2) as i32;
1498            let new_op = match kind {
1499                BKind::Cond(c) => ArmOp::BCondOffset {
1500                    cond: *c,
1501                    offset: halfword_offset,
1502                },
1503                BKind::Uncond => ArmOp::BOffset {
1504                    offset: halfword_offset,
1505                },
1506            };
1507            if resolved[*idx].op != new_op {
1508                resolved[*idx].op = new_op;
1509                changed = true;
1510            }
1511        }
1512        if !changed {
1513            break;
1514        }
1515    }
1516    Ok(resolved)
1517}
1518
1519#[cfg(test)]
1520mod tests {
1521    use super::*;
1522
1523    /// #539: `i32.const 0; memory.grow m` folds to `memory.size m`; other deltas
1524    /// (const non-zero, runtime) are left as `memory.grow` (→ the sound fixed-
1525    /// memory -1). Non-grow ops are untouched, so functions without the idiom are
1526    /// byte-identical.
1527    #[test]
1528    fn test_rewrite_memory_grow_zero_539() {
1529        // the idiom -> memory.size
1530        assert_eq!(
1531            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::MemoryGrow(0)]),
1532            vec![WasmOp::MemorySize(0)]
1533        );
1534        // const non-zero delta: NOT folded
1535        assert_eq!(
1536            rewrite_memory_grow_zero(&[WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]),
1537            vec![WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]
1538        );
1539        // runtime delta (no preceding const): NOT folded
1540        assert_eq!(
1541            rewrite_memory_grow_zero(&[WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]),
1542            vec![WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]
1543        );
1544        // a bare const-0 not feeding a grow is untouched
1545        assert_eq!(
1546            rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::I32Add]),
1547            vec![WasmOp::I32Const(0), WasmOp::I32Add]
1548        );
1549        // fold is local: surrounding ops preserved, indices past the fold intact
1550        assert_eq!(
1551            rewrite_memory_grow_zero(&[
1552                WasmOp::LocalGet(0),
1553                WasmOp::I32Const(0),
1554                WasmOp::MemoryGrow(0),
1555                WasmOp::I32Add,
1556            ]),
1557            vec![WasmOp::LocalGet(0), WasmOp::MemorySize(0), WasmOp::I32Add]
1558        );
1559    }
1560
1561    #[test]
1562    fn test_arm_backend_name() {
1563        let backend = ArmBackend::new();
1564        assert_eq!(backend.name(), "arm");
1565        assert!(backend.is_available());
1566    }
1567
1568    #[test]
1569    fn test_arm_backend_capabilities() {
1570        let backend = ArmBackend::new();
1571        let caps = backend.capabilities();
1572        assert!(!caps.produces_elf);
1573        assert!(caps.supports_rule_verification);
1574        assert!(!caps.is_external);
1575    }
1576
1577    #[test]
1578    fn test_compile_add_function() {
1579        let backend = ArmBackend::new();
1580        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1581        let config = CompileConfig::default();
1582
1583        let result = backend.compile_function("add", &ops, &config);
1584        assert!(result.is_ok());
1585
1586        let func = result.unwrap();
1587        assert_eq!(func.name, "add");
1588        assert!(!func.code.is_empty());
1589        assert_eq!(func.wasm_ops, ops);
1590    }
1591
1592    /// VCR-DBG-001: the per-instruction source map must cover the function with
1593    /// monotonic, in-bounds machine offsets, and must not perturb the emitted
1594    /// code (it is captured at encode time, never serialized here).
1595    #[test]
1596    fn test_line_map_is_wellformed_dbg001() {
1597        let backend = ArmBackend::new();
1598        let ops = vec![
1599            WasmOp::LocalGet(0),
1600            WasmOp::LocalGet(1),
1601            WasmOp::I32Add,
1602            WasmOp::End,
1603        ];
1604        let config = CompileConfig::default();
1605        let func = backend.compile_function("add", &ops, &config).unwrap();
1606
1607        // Non-empty, and the first instruction starts at machine offset 0.
1608        assert!(
1609            !func.line_map.is_empty(),
1610            "a non-trivial function captures a source map"
1611        );
1612        assert_eq!(func.line_map[0].0, 0, "first instruction at offset 0");
1613
1614        // Offsets strictly increase by at least one ARM/Thumb instruction (>= 2
1615        // bytes) and every mapped offset lies inside the emitted `.text`.
1616        for w in func.line_map.windows(2) {
1617            assert!(w[1].0 > w[0].0, "instruction offsets strictly increase");
1618            assert!(
1619                w[1].0 - w[0].0 >= 2,
1620                "each ARM/Thumb instruction is >= 2 bytes"
1621            );
1622        }
1623        let last = func.line_map.last().unwrap().0 as usize;
1624        assert!(
1625            last < func.code.len(),
1626            "every mapped offset lies inside .text"
1627        );
1628
1629        // The side-table is additive: recompiling is deterministic and the map is
1630        // consistent with that exact code (capturing it does not alter output).
1631        let again = backend.compile_function("add", &ops, &config).unwrap();
1632        assert_eq!(
1633            again.code, func.code,
1634            "compilation deterministic; map is additive"
1635        );
1636        assert_eq!(again.line_map, func.line_map);
1637    }
1638
1639    #[test]
1640    fn test_count_params() {
1641        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1642        assert_eq!(count_params(&ops), 2);
1643
1644        let no_params = vec![WasmOp::I32Const(5), WasmOp::I32Const(3), WasmOp::I32Add];
1645        assert_eq!(count_params(&no_params), 0);
1646    }
1647
1648    /// #457: the declared param count caps the access-pattern inference. The
1649    /// repro shape `(param i32)(local i32) → p0 + local1` reads local 1 before
1650    /// any write, so `count_params` infers 2 — with the declared count (1) the
1651    /// local is reclassified onto the zero-inited frame path instead of being
1652    /// read from R1 (caller garbage).
1653    #[test]
1654    fn declared_param_count_caps_inference_457() {
1655        let ops = vec![
1656            WasmOp::LocalGet(0),
1657            WasmOp::LocalGet(1),
1658            WasmOp::I32Add,
1659            WasmOp::End,
1660        ];
1661        // The inference alone still says 2 (the misclassification this caps).
1662        assert_eq!(count_params(&ops), 2);
1663
1664        let backend = ArmBackend::new();
1665        let inferred = backend
1666            .compile_function("rbw", &ops, &CompileConfig::default())
1667            .unwrap();
1668        let declared = backend
1669            .compile_function(
1670                "rbw",
1671                &ops,
1672                &CompileConfig {
1673                    current_func_param_count: Some(1),
1674                    ..CompileConfig::default()
1675                },
1676            )
1677            .unwrap();
1678        // The cap is consumed: the declared-count compile reclassifies local 1
1679        // and must emit different code than the param-misclassified one.
1680        assert_ne!(
1681            inferred.code, declared.code,
1682            "declared param count must reach the selector"
1683        );
1684        // The zero-init is present: a 16-bit Thumb `movs rN, #0`
1685        // (0x2000 | rd<<8 → LE bytes [0x00, 0x20+rd]) somewhere in the body.
1686        let has_movs_zero = declared
1687            .code
1688            .chunks_exact(2)
1689            .any(|h| h[0] == 0x00 && (0x20..=0x27).contains(&h[1]));
1690        assert!(
1691            has_movs_zero,
1692            "declared-count compile must zero-init the read-before-write local; code: {:02x?}",
1693            declared.code
1694        );
1695        // A declared count that matches (or exceeds) the inference changes
1696        // nothing — byte-identity for every function without rbw locals.
1697        let matching = backend
1698            .compile_function(
1699                "rbw",
1700                &ops,
1701                &CompileConfig {
1702                    current_func_param_count: Some(2),
1703                    ..CompileConfig::default()
1704                },
1705            )
1706            .unwrap();
1707        assert_eq!(
1708            matching.code, inferred.code,
1709            "declared >= inferred must stay byte-identical"
1710        );
1711    }
1712
1713    #[test]
1714    fn test_arm_backend_register() {
1715        let mut registry = synth_core::BackendRegistry::new();
1716        registry.register(Box::new(ArmBackend::new()));
1717        assert!(registry.get("arm").is_some());
1718        assert_eq!(registry.available().len(), 1);
1719    }
1720
1721    #[test]
1722    fn test_compile_import_call_produces_relocations() {
1723        let backend = ArmBackend::new();
1724        // Simulate a WASM module where func index 0 is an import.
1725        // Call(0) should generate MOV R0, #0; BL __meld_dispatch_import
1726        let ops = vec![WasmOp::Call(0)];
1727        let config = CompileConfig {
1728            num_imports: 1,
1729            no_optimize: true, // Direct instruction selection to preserve Call semantics
1730            ..CompileConfig::default()
1731        };
1732
1733        let result = backend.compile_function("caller", &ops, &config);
1734        assert!(result.is_ok());
1735
1736        let func = result.unwrap();
1737        assert!(!func.code.is_empty());
1738        assert_eq!(func.relocations.len(), 1);
1739        assert_eq!(func.relocations[0].symbol, "__meld_dispatch_import");
1740        // The BL is the second instruction (after MOV R0, #0), so offset should be > 0
1741        assert!(func.relocations[0].offset > 0);
1742    }
1743
1744    /// Regression test for #197: in `relocatable` mode, an import call must
1745    /// relocate against the direct `func_N` symbol (rewritten to the wasm field
1746    /// name by `build_relocatable_elf`), NOT `__meld_dispatch_import`. This is
1747    /// the ABI half of the #197 fix — without it, a host linker cannot resolve
1748    /// the call to the real kernel symbol (e.g. `k_spin_lock`).
1749    #[test]
1750    fn test_compile_relocatable_import_uses_direct_func_symbol_197() {
1751        let backend = ArmBackend::new();
1752        let ops = vec![WasmOp::Call(0)]; // func 0 is an import
1753        let config = CompileConfig {
1754            num_imports: 1,
1755            relocatable: true,
1756            ..CompileConfig::default()
1757        };
1758
1759        let func = backend
1760            .compile_function("caller", &ops, &config)
1761            .expect("relocatable import call compiles");
1762
1763        assert_eq!(func.relocations.len(), 1);
1764        assert_eq!(
1765            func.relocations[0].symbol, "func_0",
1766            "#197: relocatable import must relocate against func_0 (→ field name), not Meld dispatch"
1767        );
1768    }
1769
1770    #[test]
1771    fn test_compile_no_imports_no_relocations() {
1772        let backend = ArmBackend::new();
1773        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1774        let config = CompileConfig::default();
1775
1776        let func = backend.compile_function("add", &ops, &config).unwrap();
1777        assert!(func.relocations.is_empty());
1778    }
1779
1780    /// Regression test for #167: a call to an INTERNAL function
1781    /// (index `>= num_imports`) must record a relocation against `func_{index}`.
1782    /// Before the fix, only `__meld_*` (import) BLs were relocated, so
1783    /// internal `BL func_N` was emitted as an unpatched `bl #0` branching
1784    /// to a garbage address — making the object non-linkable. This test
1785    /// would have caught that regression.
1786    #[test]
1787    fn test_compile_internal_call_produces_relocation_167() {
1788        let backend = ArmBackend::new();
1789        // num_imports = 1, so Call(2) is an INTERNAL call → `BL func_2`.
1790        let ops = vec![WasmOp::Call(2)];
1791        let config = CompileConfig {
1792            num_imports: 1,
1793            no_optimize: true,
1794            ..CompileConfig::default()
1795        };
1796
1797        let func = backend
1798            .compile_function("caller", &ops, &config)
1799            .expect("internal call compiles");
1800
1801        assert_eq!(
1802            func.relocations.len(),
1803            1,
1804            "an internal call must emit exactly one relocation (#167)"
1805        );
1806        assert_eq!(
1807            func.relocations[0].symbol, "func_2",
1808            "internal call must relocate against the callee's func_{{index}} symbol (#167)"
1809        );
1810    }
1811
1812    // ─── Phase 1 safety-bounds plumbing for ARM ──────────────────────────
1813
1814    #[test]
1815    fn arm_safety_bounds_mpu_emits_same_code_as_none() {
1816        // Mpu mode must not introduce any inline check on ARM — the MPU
1817        // handles faults via hardware. The encoded bytes for an i32.load
1818        // should be identical between None and Mpu.
1819        let backend = ArmBackend::new();
1820        let ops = vec![
1821            WasmOp::LocalGet(0),
1822            WasmOp::I32Load {
1823                offset: 0,
1824                align: 2,
1825            },
1826        ];
1827        let cfg_none = CompileConfig {
1828            no_optimize: true,
1829            ..Default::default()
1830        };
1831        let cfg_mpu = CompileConfig {
1832            no_optimize: true,
1833            safety_bounds: SafetyBounds::Mpu,
1834            ..Default::default()
1835        };
1836        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1837        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1838        assert_eq!(
1839            n.code, m.code,
1840            "Mpu and None should produce identical ARM bytes (Mpu relies on hardware)"
1841        );
1842    }
1843
1844    #[test]
1845    fn arm_legacy_bounds_check_still_emits_software_check() {
1846        // Legacy CLI users with `--bounds-check` should keep getting the
1847        // software path even though the new SafetyBounds field defaults to None.
1848        let backend = ArmBackend::new();
1849        let ops = vec![
1850            WasmOp::LocalGet(0),
1851            WasmOp::I32Load {
1852                offset: 0,
1853                align: 2,
1854            },
1855        ];
1856        let cfg_legacy = CompileConfig {
1857            no_optimize: true,
1858            bounds_check: true,
1859            ..Default::default()
1860        };
1861        let cfg_software = CompileConfig {
1862            no_optimize: true,
1863            safety_bounds: SafetyBounds::Software,
1864            ..Default::default()
1865        };
1866        let l = backend.compile_function("ld", &ops, &cfg_legacy).unwrap();
1867        let s = backend.compile_function("ld", &ops, &cfg_software).unwrap();
1868        assert_eq!(
1869            l.code, s.code,
1870            "--bounds-check should produce the same bytes as --safety-bounds=software"
1871        );
1872    }
1873
1874    /// #377: `--safety-bounds software` must be enforced on the OPTIMIZED path
1875    /// too. Pre-fix, `software` was byte-identical to `none` there (a silent
1876    /// no-op while the safety manifest claimed enforcement). The compiled
1877    /// bytes must now (a) differ from `none` and (b) contain the inline
1878    /// `CMP ip, sl` + `UDF` guard.
1879    #[test]
1880    fn arm_safety_bounds_software_enforced_on_optimized_path_377() {
1881        let backend = ArmBackend::new();
1882        // Dynamic-address store+load: the optimized path accepts this shape
1883        // (no calls, no i64 params, ≤4 params).
1884        let ops = vec![
1885            WasmOp::LocalGet(0),
1886            WasmOp::LocalGet(1),
1887            WasmOp::I32Store {
1888                offset: 4,
1889                align: 2,
1890            },
1891            WasmOp::LocalGet(0),
1892            WasmOp::I32Load {
1893                offset: 0,
1894                align: 2,
1895            },
1896        ];
1897        // no_optimize NOT set — this exercises the optimized path.
1898        let cfg_none = CompileConfig::default();
1899        let cfg_sw = CompileConfig {
1900            safety_bounds: SafetyBounds::Software,
1901            ..Default::default()
1902        };
1903        let n = backend.compile_function("st", &ops, &cfg_none).unwrap();
1904        let s = backend.compile_function("st", &ops, &cfg_sw).unwrap();
1905        assert_ne!(
1906            n.code, s.code,
1907            "#377: software bounds must CHANGE optimized-path codegen (was a silent no-op)"
1908        );
1909        // Thumb-2 `UDF #0` is 0xDE00 (LE bytes: 00 DE); the #752
1910        // wraparound-safe guard's borrow check `CMP sl, ip` (16-bit
1911        // high-reg form) is 0x45E2 (LE: E2 45). Both must appear — one
1912        // guard per access, traps inline.
1913        let has_udf = s.code.windows(2).any(|w| w == [0x00, 0xDE]);
1914        let has_cmp_sl_ip = s.code.windows(2).any(|w| w == [0xE2, 0x45]);
1915        assert!(has_udf, "#377: inline UDF trap missing from optimized path");
1916        assert!(
1917            has_cmp_sl_ip,
1918            "#377/#752: CMP sl, ip bounds borrow-check missing from optimized path"
1919        );
1920        // And `none` must contain NO UDF (the function has no other trap).
1921        assert!(
1922            !n.code.windows(2).any(|w| w == [0x00, 0xDE]),
1923            "none must not contain a UDF for this function"
1924        );
1925    }
1926
1927    /// #377: `mpu` on the optimized path is codegen-passthrough — identical
1928    /// bytes to `none` on BOTH paths (hardware enforcement is target-level;
1929    /// synth does not emit MPU region programming — tracked separately in
1930    /// #377's fix-direction discussion). This pins path-parity for `mpu`.
1931    #[test]
1932    fn arm_safety_bounds_mpu_optimized_path_parity_377() {
1933        let backend = ArmBackend::new();
1934        let ops = vec![
1935            WasmOp::LocalGet(0),
1936            WasmOp::I32Load {
1937                offset: 0,
1938                align: 2,
1939            },
1940        ];
1941        let cfg_none = CompileConfig::default();
1942        let cfg_mpu = CompileConfig {
1943            safety_bounds: SafetyBounds::Mpu,
1944            ..Default::default()
1945        };
1946        let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1947        let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1948        assert_eq!(
1949            n.code, m.code,
1950            "Mpu and None must produce identical bytes on the optimized path too"
1951        );
1952    }
1953
1954    /// #377: `mask` on the optimized path declines to the direct selector
1955    /// (honest degradation) — the compiled function must equal the
1956    /// `--no-optimize` masking bytes, i.e. the flag is honored, never dropped.
1957    #[test]
1958    fn arm_safety_bounds_mask_optimized_path_declines_to_direct_377() {
1959        let backend = ArmBackend::new();
1960        let ops = vec![
1961            WasmOp::LocalGet(0),
1962            WasmOp::LocalGet(1),
1963            WasmOp::I32Store {
1964                offset: 0,
1965                align: 2,
1966            },
1967        ];
1968        let cfg_mask_opt = CompileConfig {
1969            safety_bounds: SafetyBounds::Mask,
1970            ..Default::default()
1971        };
1972        let cfg_mask_direct = CompileConfig {
1973            no_optimize: true,
1974            safety_bounds: SafetyBounds::Mask,
1975            ..Default::default()
1976        };
1977        let o = backend.compile_function("st", &ops, &cfg_mask_opt).unwrap();
1978        let d = backend
1979            .compile_function("st", &ops, &cfg_mask_direct)
1980            .unwrap();
1981        assert_eq!(
1982            o.code, d.code,
1983            "#377: mask on the optimized path must fall back to the direct selector's masking"
1984        );
1985    }
1986
1987    // ========================================================================
1988    // ISA feature gate tests — ensure the compiler never emits unsupported
1989    // instructions for a given target
1990    // ========================================================================
1991
1992    #[test]
1993    fn test_f32_rejected_on_cortex_m3_no_fpu() {
1994        let backend = ArmBackend::new();
1995        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
1996        let config = CompileConfig {
1997            target: TargetSpec::cortex_m3(),
1998            no_optimize: true,
1999            ..CompileConfig::default()
2000        };
2001
2002        let result = backend.compile_function("fadd", &ops, &config);
2003        assert!(
2004            result.is_err(),
2005            "f32 operations should fail on Cortex-M3 (no FPU)"
2006        );
2007    }
2008
2009    #[test]
2010    fn test_f32_accepted_on_cortex_m4f() {
2011        let backend = ArmBackend::new();
2012        let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
2013        let config = CompileConfig {
2014            target: TargetSpec::cortex_m4f(),
2015            no_optimize: true,
2016            ..CompileConfig::default()
2017        };
2018
2019        let result = backend.compile_function("fadd", &ops, &config);
2020        assert!(
2021            result.is_ok(),
2022            "f32 operations should succeed on Cortex-M4F, got: {:?}",
2023            result.unwrap_err()
2024        );
2025    }
2026
2027    #[test]
2028    fn test_i32_works_on_all_targets() {
2029        let backend = ArmBackend::new();
2030        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
2031
2032        // Cortex-M3 (no FPU)
2033        let config_m3 = CompileConfig {
2034            target: TargetSpec::cortex_m3(),
2035            no_optimize: true,
2036            ..CompileConfig::default()
2037        };
2038        assert!(
2039            backend.compile_function("add", &ops, &config_m3).is_ok(),
2040            "i32 ops should work on Cortex-M3"
2041        );
2042
2043        // Cortex-M4F (single FPU)
2044        let config_m4f = CompileConfig {
2045            target: TargetSpec::cortex_m4f(),
2046            no_optimize: true,
2047            ..CompileConfig::default()
2048        };
2049        assert!(
2050            backend.compile_function("add", &ops, &config_m4f).is_ok(),
2051            "i32 ops should work on Cortex-M4F"
2052        );
2053
2054        // Cortex-M7DP (double FPU)
2055        let config_m7dp = CompileConfig {
2056            target: TargetSpec::cortex_m7dp(),
2057            no_optimize: true,
2058            ..CompileConfig::default()
2059        };
2060        assert!(
2061            backend.compile_function("add", &ops, &config_m7dp).is_ok(),
2062            "i32 ops should work on Cortex-M7DP"
2063        );
2064    }
2065
2066    #[test]
2067    fn test_f32_rejected_on_cortex_m4_no_fpu() {
2068        // Cortex-M4 (without F suffix) has no FPU
2069        let backend = ArmBackend::new();
2070        let ops = vec![WasmOp::F32Const(1.5), WasmOp::F32Const(2.5), WasmOp::F32Mul];
2071        let config = CompileConfig {
2072            target: TargetSpec::cortex_m4(),
2073            no_optimize: true,
2074            ..CompileConfig::default()
2075        };
2076
2077        let result = backend.compile_function("fmul", &ops, &config);
2078        assert!(
2079            result.is_err(),
2080            "f32 operations should fail on Cortex-M4 (no FPU)"
2081        );
2082    }
2083
2084    // ========================================================================
2085    // Issue #120 — f32 ops in the optimized lowering path
2086    //
2087    // `OptimizerBridge::wasm_to_ir` has no handlers for f32/f64 ops, so a
2088    // value-producing float op fell through to `Opcode::Nop`, leaving a
2089    // downstream consumer with an unmapped vreg and tripping the PR #101
2090    // defensive panic in `ir_to_arm`. Customer reproducer: `compiler_builtins
2091    // float::div` and `gale_compute_ipi_mask` in the `falcon-rate-component`
2092    // module.
2093    //
2094    // Fix: `optimize_full` declines float modules with a typed `Err`;
2095    // `compile_wasm_to_arm` falls back to the non-optimized `select_with_stack`
2096    // path, which handles f32 via VFP/FPU. These tests use the *default*
2097    // (optimized) config — `no_optimize` is NOT set — which is the exact
2098    // configuration that panicked pre-fix.
2099    // ========================================================================
2100
2101    /// Pre-fix: this panicked with "vreg vN has no assigned ARM register and
2102    /// no spill slot" inside `ir_to_arm`. Post-fix: the optimized path declines
2103    /// the module and the backend falls back to direct selection, producing a
2104    /// non-empty f32.div lowering on a Cortex-M4F.
2105    #[test]
2106    fn test_issue120_f32_div_compiles_via_optimized_default() {
2107        let backend = ArmBackend::new();
2108        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2109        let config = CompileConfig {
2110            target: TargetSpec::cortex_m4f(),
2111            // no_optimize NOT set — this exercises the optimized path that
2112            // panicked in issue #120, then the fallback to direct selection.
2113            // GI-FPU-002: the f32 params must be declared so the direct
2114            // selector homes them in S0/S1 (AAPCS-VFP) rather than declining.
2115            current_func_params_f32: vec![true, true],
2116            ..CompileConfig::default()
2117        };
2118
2119        let result = backend.compile_function("fdiv", &ops, &config);
2120        assert!(
2121            result.is_ok(),
2122            "f32.div must compile on Cortex-M4F via the optimized->direct \
2123             fallback (issue #120), got: {:?}",
2124            result.as_ref().err()
2125        );
2126        assert!(
2127            !result.unwrap().code.is_empty(),
2128            "f32.div must produce non-empty machine code"
2129        );
2130    }
2131
2132    /// A spread of f32 ops, all through the optimized (default) config, must
2133    /// compile via the fallback on an FPU target without panicking.
2134    #[test]
2135    fn test_issue120_assorted_f32_ops_compile_via_optimized_default() {
2136        let backend = ArmBackend::new();
2137        let config = CompileConfig {
2138            target: TargetSpec::cortex_m4f(),
2139            // GI-FPU-002: declare the two f32 params for AAPCS-VFP homing.
2140            current_func_params_f32: vec![true, true],
2141            ..CompileConfig::default()
2142        };
2143
2144        let cases: Vec<(&str, Vec<WasmOp>)> = vec![
2145            (
2146                "fadd",
2147                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Add],
2148            ),
2149            (
2150                "fmul",
2151                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Mul],
2152            ),
2153            (
2154                "fsub",
2155                vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Sub],
2156            ),
2157        ];
2158
2159        for (name, ops) in cases {
2160            let result = backend.compile_function(name, &ops, &config);
2161            assert!(
2162                result.is_ok(),
2163                "{name} must compile via the optimized->direct fallback \
2164                 (issue #120), got: {:?}",
2165                result.as_ref().err()
2166            );
2167            assert!(
2168                !result.unwrap().code.is_empty(),
2169                "{name} must produce non-empty machine code"
2170            );
2171        }
2172    }
2173
2174    /// The fallback must still honor the ISA feature gate: f32 on a no-FPU
2175    /// target must fail cleanly (not panic) even on the optimized path.
2176    #[test]
2177    fn test_issue120_f32_div_rejected_on_no_fpu_via_optimized() {
2178        let backend = ArmBackend::new();
2179        let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2180        let config = CompileConfig {
2181            target: TargetSpec::cortex_m3(),
2182            ..CompileConfig::default()
2183        };
2184
2185        let result = backend.compile_function("fdiv", &ops, &config);
2186        assert!(
2187            result.is_err(),
2188            "f32.div must be rejected on Cortex-M3 (no FPU), not panic"
2189        );
2190    }
2191
2192    /// #507: a `br_table` function compiled via the DEFAULT (optimized) config
2193    /// must produce the SAME bytes as the direct (`no_optimize`) selector —
2194    /// i.e. the optimized path declined it to direct, lowering the dispatch as a
2195    /// real cmp-chain instead of silently dropping it (which left all arms in
2196    /// fall-through). Pre-fix the two outputs differed (the optimized one had no
2197    /// selector compare). Execution correctness is gated by
2198    /// `scripts/repro/br_table_507_differential.py`.
2199    #[test]
2200    fn test_507_br_table_declines_to_direct() {
2201        let backend = ArmBackend::new();
2202        // dispatch(sel): br_table over 3 blocks, each storing a marker to mem[0].
2203        let ops = vec![
2204            WasmOp::Block,
2205            WasmOp::Block,
2206            WasmOp::Block,
2207            WasmOp::LocalGet(0),
2208            WasmOp::BrTable {
2209                targets: vec![0, 1, 2],
2210                default: 2,
2211            },
2212            WasmOp::End,
2213            WasmOp::I32Const(0),
2214            WasmOp::I32Const(10),
2215            WasmOp::I32Store {
2216                offset: 0,
2217                align: 2,
2218            },
2219            WasmOp::Return,
2220            WasmOp::End,
2221            WasmOp::I32Const(0),
2222            WasmOp::I32Const(20),
2223            WasmOp::I32Store {
2224                offset: 0,
2225                align: 2,
2226            },
2227            WasmOp::Return,
2228            WasmOp::End,
2229            WasmOp::I32Const(0),
2230            WasmOp::I32Const(30),
2231            WasmOp::I32Store {
2232                offset: 0,
2233                align: 2,
2234            },
2235        ];
2236        let opt = CompileConfig {
2237            target: TargetSpec::cortex_m4(),
2238            ..CompileConfig::default()
2239        };
2240        let direct = CompileConfig {
2241            target: TargetSpec::cortex_m4(),
2242            no_optimize: true,
2243            ..CompileConfig::default()
2244        };
2245        let a = backend
2246            .compile_function("dispatch", &ops, &opt)
2247            .expect("optimized-default must compile br_table (via decline)");
2248        let b = backend
2249            .compile_function("dispatch", &ops, &direct)
2250            .expect("direct must compile br_table");
2251        assert_eq!(
2252            a.code, b.code,
2253            "#507: optimized-default br_table output must be byte-identical to the \
2254             direct selector (i.e. declined to direct), not a dropped dispatch"
2255        );
2256    }
2257
2258    /// Issue #94: end-to-end byte-size check for the canonical u64-packed
2259    /// FFI-return hi32 extract pattern. Compiles two near-identical
2260    /// functions — one with the optimized shift-by-32, one with a generic
2261    /// shift-by-7 — and asserts the optimized form is meaningfully smaller.
2262    #[test]
2263    fn test_issue94_hi32_extract_is_smaller_than_generic_shift() {
2264        let backend = ArmBackend::new();
2265        let config = CompileConfig {
2266            target: TargetSpec::cortex_m4f(),
2267            ..CompileConfig::default()
2268        };
2269
2270        // #518: the i64 value must NOT come from an i64 PARAM — the optimized
2271        // path now declines i64-param functions to the direct selector (it homed
2272        // an i64 param in R4:R5 instead of R0:R1, a silent miscompile this test's
2273        // byte-size-only assertion masked). The canonical #94 case is a u64 from
2274        // an FFI return, not a param, anyway. Source the i64 from a sign-extended
2275        // i32 param (`extend_i32_s`): a runtime, non-constant-foldable i64 that
2276        // stays on the optimized path, so the shift-by-32 hi-extract peephole is
2277        // still exercised on CORRECT code.
2278        // Optimized path: `(i64.extend_i32_s (local.get 0)) >>> 32; wrap_i64`
2279        let ops_hi32 = vec![
2280            WasmOp::LocalGet(0), // i32 param in R0
2281            WasmOp::I64ExtendI32S,
2282            WasmOp::I64Const(32),
2283            WasmOp::I64ShrU,
2284            WasmOp::I32WrapI64,
2285        ];
2286        let func_hi32 = backend
2287            .compile_function("hi32_extract", &ops_hi32, &config)
2288            .unwrap();
2289
2290        // Generic path: `... >>> 7; wrap_i64` — same shape, but the shift amount
2291        // is not a multiple of 32, so it falls through to the runtime shift.
2292        let ops_generic = vec![
2293            WasmOp::LocalGet(0),
2294            WasmOp::I64ExtendI32S,
2295            WasmOp::I64Const(7),
2296            WasmOp::I64ShrU,
2297            WasmOp::I32WrapI64,
2298        ];
2299        let func_generic = backend
2300            .compile_function("generic_shr", &ops_generic, &config)
2301            .unwrap();
2302
2303        let bytes_hi32 = func_hi32.code.len();
2304        let bytes_generic = func_generic.code.len();
2305        println!(
2306            "\n[issue #94] hi32 extract: {} bytes (vs generic shift: {} bytes; saved {})",
2307            bytes_hi32,
2308            bytes_generic,
2309            bytes_generic.saturating_sub(bytes_hi32)
2310        );
2311        let hex: String = func_hi32
2312            .code
2313            .iter()
2314            .map(|b| format!("{:02x}", b))
2315            .collect::<Vec<_>>()
2316            .join(" ");
2317        println!("[issue #94] hi32 bytes: {}", hex);
2318        // We expect the optimized form to be at least 30 bytes smaller than
2319        // the generic 64-bit shift sequence. (Empirically: 14 vs 50 bytes.)
2320        assert!(
2321            bytes_hi32 + 30 <= bytes_generic,
2322            "issue #94: hi32 extract = {} bytes, generic shift = {} bytes; \
2323             expected optimized form to be at least 30 bytes smaller",
2324            bytes_hi32,
2325            bytes_generic,
2326        );
2327    }
2328}