synth_backend/arm_backend.rs
1//! ARM Backend — wraps the instruction selector + optimizer + encoder as a Backend
2//!
3//! This is Synth's custom ARM compiler targeting Cortex-M (Thumb-2).
4//! It's the only backend that supports per-rule formal verification (ASIL D path).
5
6use crate::ArmEncoder;
7use synth_core::backend::{
8 Backend, BackendCapabilities, BackendError, CodeRelocation, CompilationResult, CompileConfig,
9 CompiledFunction, LineMap, SafetyBounds,
10};
11use synth_core::target::{IsaVariant, TargetSpec};
12use synth_core::wasm_decoder::DecodedModule;
13use synth_core::wasm_op::WasmOp;
14use synth_synthesis::{
15 ArmInstruction, ArmOp, BoundsCheckConfig, InstructionSelector, OptimizationConfig,
16 OptimizerBridge, RuleDatabase, validate_instructions,
17};
18
19/// ARM Cortex-M backend using Synth's custom compiler pipeline
20pub struct ArmBackend;
21
22impl ArmBackend {
23 pub fn new() -> Self {
24 Self
25 }
26}
27
28impl Default for ArmBackend {
29 fn default() -> Self {
30 Self::new()
31 }
32}
33
34impl Backend for ArmBackend {
35 fn name(&self) -> &str {
36 "arm"
37 }
38
39 fn capabilities(&self) -> BackendCapabilities {
40 BackendCapabilities {
41 produces_elf: false,
42 supports_rule_verification: true,
43 supports_binary_verification: true,
44 is_external: false,
45 }
46 }
47
48 fn supported_targets(&self) -> Vec<TargetSpec> {
49 vec![
50 TargetSpec::cortex_m3(),
51 TargetSpec::cortex_m4(),
52 TargetSpec::cortex_m4f(),
53 TargetSpec::cortex_m7(),
54 TargetSpec::cortex_m7dp(),
55 ]
56 }
57
58 fn compile_module(
59 &self,
60 module: &DecodedModule,
61 config: &CompileConfig,
62 ) -> Result<CompilationResult, BackendError> {
63 let exports: Vec<_> = module
64 .functions
65 .iter()
66 .filter(|f| f.export_name.is_some())
67 .collect();
68
69 if exports.is_empty() {
70 return Err(BackendError::CompilationFailed(
71 "no exported functions found".into(),
72 ));
73 }
74
75 let mut functions = Vec::new();
76 for func in &exports {
77 let name = func.export_name.clone().unwrap();
78 // #359: copy THIS function's declared param widths into the config so
79 // `compile_function` (which carries no function index) can refuse a
80 // 64-bit param on the AAPCS stack-argument path. Cheap clone only when
81 // a signature table is present and this function has a width entry —
82 // otherwise reuse the shared config (every existing module unchanged).
83 // #509: same per-function pattern for the blocktype-arity side-table
84 // (value-carrying-branch lowering).
85 let params = config
86 .func_params_i64
87 .get(func.index as usize)
88 .filter(|p| !p.is_empty());
89 // #457: THIS function's DECLARED param count (imports-first full
90 // index), so the backend can cap the access-pattern inference that
91 // mistook a read-before-write local for a param. `None` when the
92 // driver supplied no arg-count table (hand-built modules).
93 let declared_params = config.func_arg_counts.get(func.index as usize).copied();
94 // GI-FPU-002 (#619/#369): THIS function's declared f32-param mask.
95 let params_f32 = config
96 .func_params_f32
97 .get(func.index as usize)
98 .filter(|p| !p.is_empty());
99 let func_config = if params.is_some()
100 || params_f32.is_some()
101 || !func.block_arity.is_empty()
102 || declared_params.is_some()
103 {
104 Some(CompileConfig {
105 current_func_params_i64: params.cloned().unwrap_or_default(),
106 current_func_params_f32: params_f32.cloned().unwrap_or_default(),
107 current_func_block_arity: func.block_arity.clone(),
108 current_func_param_count: declared_params,
109 ..config.clone()
110 })
111 } else {
112 None
113 };
114 let cfg = func_config.as_ref().unwrap_or(config);
115 let compiled = self.compile_function(&name, &func.ops, cfg)?;
116 functions.push(compiled);
117 }
118
119 Ok(CompilationResult {
120 functions,
121 elf: None,
122 backend_name: self.name().to_string(),
123 })
124 }
125
126 fn compile_function(
127 &self,
128 name: &str,
129 ops: &[WasmOp],
130 config: &CompileConfig,
131 ) -> Result<CompiledFunction, BackendError> {
132 let (code, relocations, line_map) =
133 compile_wasm_to_arm(ops, config).map_err(BackendError::CompilationFailed)?;
134
135 Ok(CompiledFunction {
136 name: name.to_string(),
137 code,
138 wasm_ops: ops.to_vec(),
139 relocations,
140 line_map,
141 })
142 }
143
144 fn is_available(&self) -> bool {
145 true // Always available — it's a library backend
146 }
147}
148
149/// Count the number of function parameters by analyzing LocalGet patterns
150fn count_params(wasm_ops: &[WasmOp]) -> u32 {
151 let mut first_access: std::collections::HashMap<u32, bool> = std::collections::HashMap::new();
152 for op in wasm_ops {
153 match op {
154 WasmOp::LocalGet(idx) => {
155 first_access.entry(*idx).or_insert(true);
156 }
157 WasmOp::LocalSet(idx) | WasmOp::LocalTee(idx) => {
158 first_access.entry(*idx).or_insert(false);
159 }
160 _ => {}
161 }
162 }
163
164 first_access
165 .iter()
166 .filter_map(
167 |(&idx, &is_read_first)| {
168 if is_read_first { Some(idx + 1) } else { None }
169 },
170 )
171 .max()
172 .unwrap_or(0)
173}
174
175/// #539: fold the `i32.const 0; memory.grow m` idiom to `memory.size m`.
176/// `memory.grow(0)` always succeeds and returns the current page count (WASM
177/// Core §4.4.7), which is exactly `memory.size`; the fixed-memory backend
178/// otherwise emits a constant `-1` for every `memory.grow`, so the legal
179/// `memory.grow(0)` "read/validate current size" idiom wrongly reported failure.
180/// Only the ADJACENT const-0 delta is folded (a non-zero delta keeps the sound
181/// `-1` — fixed memory genuinely cannot grow; a runtime-computed 0 is a
182/// documented follow-up). Backend- and path-agnostic: `memory.size` reads the
183/// runtime memory-size register on every selector, so this fixes the optimized
184/// and direct paths at once.
185fn rewrite_memory_grow_zero(wasm_ops: &[WasmOp]) -> Vec<WasmOp> {
186 let mut out = Vec::with_capacity(wasm_ops.len());
187 let mut i = 0;
188 while i < wasm_ops.len() {
189 if matches!(wasm_ops[i], WasmOp::I32Const(0))
190 && let Some(WasmOp::MemoryGrow(m)) = wasm_ops.get(i + 1)
191 {
192 out.push(WasmOp::MemorySize(*m));
193 i += 2;
194 } else {
195 out.push(wasm_ops[i].clone());
196 i += 1;
197 }
198 }
199 out
200}
201
202/// #509: does the op stream contain a `br`/`br_if`/`br_table` that CARRIES a
203/// value — i.e. one targeting a result-typed block/if (forward edge with
204/// results > 0) or a parameterized loop header (backward edge with loop
205/// params > 0)?
206///
207/// The optimized path's wasm→IR lowering drops the carried value on such
208/// edges (the taken arm returns the fall-through result — same class as the
209/// #507 `br_table` drop, observed on `pick_br`/`pick_br_fall`), so — like
210/// #507 — the shape is detected on the raw op stream and routed to the direct
211/// selector, whose #509 designated-result-register lowering lands the value
212/// correctly. `block_arity` is the decoder's ordinal blocktype-arity
213/// side-table; when it is empty (hand-built op streams) every block reads as
214/// void and this never fires, keeping the optimized path byte-identical for
215/// every existing caller. Frozen-safe for the same reason as #507: the frozen
216/// fixtures compile `--relocatable` (already direct), and no optimized-path
217/// fixture branches to a result-typed block.
218fn has_value_carrying_branch(wasm_ops: &[WasmOp], block_arity: &[(u8, u8)]) -> bool {
219 // Open control constructs: (is_loop, params, results), innermost last.
220 let mut open: Vec<(bool, u8, u8)> = Vec::new();
221 let mut ctrl_ord = 0usize;
222 // A branch edge carries a value when its target is a result-typed forward
223 // join (block/if) or a parameterized loop header.
224 let carries = |open: &[(bool, u8, u8)], depth: u32| -> bool {
225 let Some(&(is_loop, params, results)) = open
226 .len()
227 .checked_sub(1 + depth as usize)
228 .and_then(|i| open.get(i))
229 else {
230 return false; // function-level target — handled by Return lowering
231 };
232 if is_loop { params > 0 } else { results > 0 }
233 };
234 for op in wasm_ops {
235 match op {
236 WasmOp::Block | WasmOp::If => {
237 let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
238 ctrl_ord += 1;
239 open.push((false, p, r));
240 }
241 WasmOp::Loop => {
242 let (p, r) = block_arity.get(ctrl_ord).copied().unwrap_or((0, 0));
243 ctrl_ord += 1;
244 open.push((true, p, r));
245 }
246 WasmOp::End => {
247 open.pop(); // None only at the function-level end — harmless
248 }
249 WasmOp::Br(d) | WasmOp::BrIf(d) if carries(&open, *d) => return true,
250 WasmOp::BrTable { targets, default }
251 if targets
252 .iter()
253 .chain(std::iter::once(default))
254 .any(|d| carries(&open, *d)) =>
255 {
256 return true;
257 }
258 _ => {}
259 }
260 }
261 false
262}
263
264/// Core compilation: WASM ops → ARM machine code bytes + relocations
265///
266/// Returns (code_bytes, relocations) where relocations record BL instructions
267/// that target external symbols (e.g., `__meld_dispatch_import` for import calls).
268fn compile_wasm_to_arm(
269 wasm_ops: &[WasmOp],
270 config: &CompileConfig,
271) -> Result<(Vec<u8>, Vec<CodeRelocation>, LineMap), String> {
272 // #539: `memory.grow(0)` must return the CURRENT page count, not the
273 // fixed-memory `-1` sentinel — growing by zero pages can never fail (WASM
274 // Core §4.4.7), so a guest doing `if (memory.grow(0) < 0) trap;` wrongly
275 // faulted. Every lowering path emitted a delta-agnostic `-1`. `memory.grow(0)`
276 // is semantically identical to `memory.size`, which the backend already
277 // computes from the runtime memory-size register (R10 >> 16 = pages), so fold
278 // the `i32.const 0; memory.grow` idiom to `memory.size` up front — backend-
279 // and path-agnostic. A non-zero delta keeps `-1` (fixed memory genuinely
280 // cannot grow); a runtime delta that happens to be 0 is the documented
281 // follow-up.
282 let rewritten = rewrite_memory_grow_zero(wasm_ops);
283 // #494 phase 2b: the fact-spec guard-elision marks are keyed by op index
284 // into the stream the DRIVER handed us. The memory.grow(0) fold above can
285 // only shift indices AT OR AFTER a `memory.grow` — an op the fact-spec
286 // walk never crosses (it stops at the first untracked op, so no mark can
287 // follow one). Defense in depth: if the fold fired at all, drop the marks
288 // loudly rather than risk keying a guard elision to the wrong op.
289 let (fact_div_zero_elide, fact_div_ovf_elide): (&[usize], &[usize]) = if rewritten.len()
290 == wasm_ops.len()
291 {
292 (&config.fact_div_zero_elide, &config.fact_div_ovf_elide)
293 } else {
294 if !config.fact_div_zero_elide.is_empty() || !config.fact_div_ovf_elide.is_empty() {
295 eprintln!(
296 "fact-spec: DECLINE div-guard elision marks dropped — the memory.grow(0) fold shifted op indices (#494 defensive gate); general lowering emitted"
297 );
298 }
299 (&[], &[])
300 };
301 let wasm_ops: &[WasmOp] = &rewritten;
302
303 // #457: `count_params` INFERS the param count from access patterns (a local
304 // whose first access is a read is assumed to be a param), so a
305 // read-before-write NON-PARAM local — which WASM zero-initializes — was
306 // indistinguishable from a param: it got homed in a parameter register and
307 // read caller garbage instead of 0. When the driver supplied the DECLARED
308 // count (`current_func_param_count`, from the module's type section), cap
309 // the inference with it. `min` (not a plain override) keeps every function
310 // whose inference is <= declared byte-identical: the inferred count can only
311 // EXCEED the declared one via a read-first local index >= the declared count
312 // — i.e. exactly the read-before-write locals this issue is about.
313 let inferred_params = count_params(wasm_ops);
314 let num_params = match config.current_func_param_count {
315 Some(declared) => inferred_params.min(declared),
316 None => inferred_params,
317 };
318 // A read-before-write non-param local exists iff the capped count dropped.
319 // Such locals need the wasm-mandated zero-init, which only the direct
320 // selector emits — the optimized path's `ir_to_arm` maps a non-param
321 // local's vreg onto an r4+ temp with no initialization (caller garbage).
322 let has_rbw_local = num_params < inferred_params;
323
324 let bounds_config = match config.effective_safety_bounds() {
325 SafetyBounds::None => BoundsCheckConfig::None,
326 SafetyBounds::Mpu => BoundsCheckConfig::Mpu,
327 SafetyBounds::Software => BoundsCheckConfig::Software,
328 SafetyBounds::Mask => {
329 // #651 (mirroring the RISC-V backend's compile-time decline):
330 // index masking wraps `ea & (size-1)` — a modulo only when the
331 // linear-memory size is a power of two. With a non-power-of-two
332 // size the AND would silently REMAP in-bounds addresses (e.g.
333 // 0x18000 & 0x2FFFF = 0x8000 for a 192 KiB memory). Decline
334 // loudly rather than miscompile. `linear_memory_bytes == 0`
335 // means "unknown" (plain per-function path, no module context)
336 // — the startup default of one 64 KiB page is a power of two.
337 let bytes = config.linear_memory_bytes;
338 if bytes != 0 && !bytes.is_power_of_two() {
339 return Err(format!(
340 "--safety-bounds mask requires a power-of-two linear-memory \
341 size, got {bytes} bytes — switch to --safety-bounds software \
342 for the deterministic check (#651)"
343 ));
344 }
345 BoundsCheckConfig::Masking
346 }
347 };
348
349 // The non-optimized (direct) instruction-selection path. Handles f32 via
350 // VFP/FPU. Used directly when `--no-optimize` is set, and as the fallback
351 // when the optimized path declines a module (see issue #120 below).
352 //
353 // VCR-RA-001 step 3b-lite (#242): a FRESH selector per attempt, with
354 // `spill_on_exhaustion` set only on the retry — the first pass is the
355 // unmodified default, so every function that compiles today is selected by
356 // exactly the code that compiled it yesterday (bit-identity is structural,
357 // not behavioural).
358 let select_direct_attempt = |spill_on_exhaustion: bool,
359 param_backing_on_exhaustion: bool,
360 local_promote: bool,
361 i64_spill_slots: Option<usize>|
362 -> Result<Vec<ArmInstruction>, synth_core::Error> {
363 let db = RuleDatabase::with_standard_rules();
364 let mut selector =
365 InstructionSelector::with_bounds_check(db.rules().to_vec(), bounds_config);
366 selector.set_target(config.target.fpu, &config.target.triple);
367 if config.num_imports > 0 {
368 selector.set_num_imports(config.num_imports);
369 }
370 // #195: plumb the callee argument-count tables so the direct selector can
371 // marshal call arguments into R0–R3 per AAPCS.
372 selector.set_func_arg_counts(
373 config.func_arg_counts.clone(),
374 config.type_arg_counts.clone(),
375 );
376 // #197: in relocatable host-link mode, emit direct `func_N` BLs for
377 // imports (rewritten to the wasm field name by build_relocatable_elf)
378 // instead of `__meld_dispatch_import`.
379 selector.set_relocatable(config.relocatable);
380 // #642: call_indirect guard inputs (compile-time table size for the
381 // bounds guard + closed-world type verdicts). Without them, every
382 // call_indirect lowering declines loudly.
383 selector.set_call_indirect_guards(config.call_indirect_guards.clone());
384 // #237: native-pointer ABI — wasm statics become __synth_wasm_data-relative.
385 selector.set_native_pointer_abi(config.native_pointer_abi, config.linear_memory_bytes);
386 // #311: i64 call results are register PAIRS — tag them.
387 selector.set_result_types(config.func_ret_i64.clone(), config.type_ret_i64.clone());
388 // #359: declared param widths of THIS function, so the AAPCS stack-arg
389 // path can refuse 64-bit params (Ok-or-Err). Empty ⇒ assume i32.
390 selector.set_params_i64(config.current_func_params_i64.clone());
391 // GI-FPU-002 (#619/#369): declared f32-param mask — home hard-float f32
392 // args in S0..S15 (AAPCS-VFP) instead of the R0..R3 integer path.
393 selector.set_params_f32(config.current_func_params_f32.clone());
394 // #509: blocktype-arity side-table of THIS function, so value-carrying
395 // br/br_if/br_table land the carried value in the target block's
396 // designated result register instead of dropping it. Empty ⇒ legacy
397 // void-block lowering.
398 selector.set_block_arity(config.current_func_block_arity.clone());
399 // Stack-pointer promotion is meaningful only under the native-pointer ABI;
400 // gating here keeps every non-native compile (all frozen fixtures) on the
401 // legacy R9 globals-table path, bit-identical.
402 if config.native_pointer_abi
403 && let Some((sp_idx, sp_init)) = config.stack_pointer_global
404 {
405 selector.set_native_pointer_stack(sp_idx, sp_init);
406 }
407 // #643: per-global slot widths — i64/f64 globals occupy 8-byte slots
408 // (register-pair store/load) and shift every later global's offset.
409 // Empty for i32-only modules ⇒ the legacy `idx * 4` layout, unchanged.
410 selector.set_global_widths(config.global_widths.clone());
411 selector.set_spill_on_exhaustion(spill_on_exhaustion);
412 selector.set_param_backing_on_exhaustion(param_backing_on_exhaustion);
413 // #587 pool-grow rung: a larger i64 spill-slot pool, set ONLY on the
414 // retry after an attempt failed with the slot-pool-exhausted Err —
415 // functions that compile with the default pool keep their frame
416 // byte-identical by construction.
417 if let Some(slots) = i64_spill_slots {
418 selector.set_i64_spill_slots(slots);
419 }
420 // VCR-RA local promotion (#390, #242): keep eligible non-param i32 locals
421 // in callee-saved registers instead of frame slots — the structural lever
422 // toward native parity. DEFAULT-ON as of v0.14.0: gale's G474RE DWT gate
423 // cleared it as a net win (gust_mix dissolved 58→50 cyc/call −14%, all 5
424 // stack spill/reloads eliminated, correctness bit-identical over [0,2047],
425 // 2.00×→1.72× vs LLVM). Escape hatch: `SYNTH_NO_LOCAL_PROMOTE=1` restores
426 // the frame-slot path. Leaf-only / i32-only / ARM-only (see
427 // compute_local_promotion); the leaf-only lift + i64 locals are follow-ons.
428 // #474: `local_promote` is now a per-attempt parameter so the retry ladder
429 // can drop promotion as an exhaustion-recovery rung (promotion pins r4-r8,
430 // which on a dense function leaves the spill allocator with nothing to
431 // free → the frame-slot path is the escape that restores compilability).
432 selector.set_local_promote(local_promote);
433 // #494 phase 2b: certificate-discharged div/rem trap-guard elision
434 // marks (empty in every compile without SYNTH_FACT_SPEC + facts).
435 selector
436 .set_fact_div_guard_elisions(fact_div_zero_elide.to_vec(), fact_div_ovf_elide.to_vec());
437 selector.select_with_stack(wasm_ops, num_params)
438 };
439 let select_direct = || -> Result<Vec<ArmInstruction>, String> {
440 const SINGLE_EXHAUSTION: &str = "all allocatable registers are live on the stack";
441 const PAIR_EXHAUSTION: &str = "no consecutive pair of free registers for i64";
442 const SLOT_EXHAUSTION: &str = "i64 spill-slot pool exhausted";
443 // The full exhaustion-recovery ladder, parameterized on whether local
444 // promotion is enabled. Each rung is reached only when the previous one
445 // returned a recoverable register-exhaustion Err, so a function that
446 // compiles on the first attempt is untouched by the later rungs. Returns
447 // the result AND which rung produced it (for the #242 measurement below).
448 let recovery_ladder =
449 |promote: bool,
450 i64_spill_slots: Option<usize>|
451 -> (Result<Vec<ArmInstruction>, synth_core::Error>, &'static str) {
452 let mut attempt = select_direct_attempt(false, false, promote, i64_spill_slots);
453 let mut rung = "base";
454 // VCR-RA-001 step 3b-lite (#242): the i32 register-exhaustion
455 // hard-fail is recoverable — retry with spill-on-exhaustion, which
456 // reserves the spill area and spills the deepest stack value when
457 // the pool is full.
458 if let Err(e) = &attempt
459 && e.to_string().contains(SINGLE_EXHAUSTION)
460 {
461 attempt = select_direct_attempt(true, false, promote, i64_spill_slots);
462 rung = "spill";
463 }
464 // VCR-RA-001 acceptance increment (#242): the i64 consecutive-PAIR
465 // exhaustion is recoverable too — not by stack spilling (the pair
466 // allocator already spills stack values, #171) but by frame-backing
467 // the params (#204) so they stop pinning R0-R3, with spill kept on.
468 if let Err(e) = &attempt
469 && e.to_string().contains(PAIR_EXHAUSTION)
470 {
471 attempt = select_direct_attempt(true, true, promote, i64_spill_slots);
472 rung = "param-backing";
473 }
474 (attempt, rung)
475 };
476 // #474: local promotion (default-on since v0.14.0) is an OPTIMIZATION — it
477 // must never be the reason a function fails to compile. Run the full ladder
478 // with promotion first (so every function that compiles today is
479 // bit-identical), and if it still ends in register exhaustion, fall back to
480 // the promotion-off ladder (the v0.12.0 frame-slot lowering — exactly what
481 // the `SYNTH_NO_LOCAL_PROMOTE=1` workaround does, now automatic). Promotion
482 // pins r4-r8 for the locals; on a dense function that leaves the allocator
483 // with nothing to free, so dropping it restores compilability. The fallback
484 // is reached ONLY by functions that exhaust WITH promotion, so promotion-on
485 // output is untouched by construction (frozen byte gate stays green).
486 let promote = std::env::var("SYNTH_NO_LOCAL_PROMOTE").is_err();
487 // The full pre-#587 recovery sequence (promotion-on ladder, then the
488 // #474 promotion-off fallback), parameterized on the pool size so the
489 // pool-grow retry below reruns it verbatim.
490 let full_sequence = |slots: Option<usize>| -> (
491 Result<Vec<ArmInstruction>, synth_core::Error>,
492 &'static str,
493 bool,
494 ) {
495 let (mut attempt, mut rung) = recovery_ladder(promote, slots);
496 let mut promotion_dropped = false;
497 if promote
498 && attempt
499 .as_ref()
500 .err()
501 .is_some_and(|e| e.to_string().contains("register exhaustion"))
502 {
503 let (rescued, off_rung) = recovery_ladder(false, slots);
504 if rescued.is_ok() {
505 attempt = rescued;
506 rung = off_rung;
507 promotion_dropped = true;
508 }
509 }
510 (attempt, rung, promotion_dropped)
511 };
512 let (mut attempt, mut rung, mut promotion_dropped) = full_sequence(None);
513 // #587 pool-grow retry (the falcon func_60/func_73 remainder): the fixed
514 // 8-slot i64 spill pool can exhaust while spilling is otherwise working —
515 // an i64-dense function simply has more values simultaneously live than
516 // the pool holds. Rerun the ENTIRE sequence (every rung, both promotion
517 // modes) with the pool sized from a conservative operand-stack-depth
518 // bound: the number of simultaneously spilled values can never exceed
519 // the operand-stack depth, plus a few transient slots (the arg-move
520 // cycle resolver and call-result parking each borrow one). The selector
521 // clamps the request to its 12-bit-friendly cap; a function that still
522 // exhausts stays an honest loud skip. Deliberately LAST — after the #474
523 // promotion-off fallback — so any function that compiled yesterday
524 // (through any rung or fallback) is produced by exactly yesterday's
525 // path, byte-identical; the grown pool only ever fires for functions
526 // whose every existing escape ended in the slot-pool Err.
527 if attempt
528 .as_ref()
529 .err()
530 .is_some_and(|e| e.to_string().contains(SLOT_EXHAUSTION))
531 {
532 let depth = synth_core::wasm_stack_check::max_depth_bound(wasm_ops) as usize;
533 let (grown, _, grown_dropped) = full_sequence(Some(depth.saturating_add(4)));
534 if grown.is_ok() {
535 attempt = grown;
536 rung = "pool-grow";
537 promotion_dropped = grown_dropped;
538 }
539 }
540 // VCR-RA measurement (#242): log which recovery rung produced the result,
541 // so the per-rung distribution across a corpus can be measured — the size
542 // of the failure surface a verified allocator must subsume (see
543 // scripts/repro/register_exhaustion_recovery_ladder.md). Logging only:
544 // emitted bytes are unchanged, so the frozen byte gate is unaffected.
545 if std::env::var("SYNTH_RECOVERY_STATS").is_ok() {
546 eprintln!(
547 "[recovery-stats] rung={rung}{} result={}",
548 if promotion_dropped {
549 " promotion-off"
550 } else {
551 ""
552 },
553 if attempt.is_ok() { "ok" } else { "exhausted" },
554 );
555 }
556 attempt.map_err(|e| format!("instruction selection failed: {}", e))
557 };
558
559 // Instruction selection: optimized or direct.
560 //
561 // #197: `--relocatable` (host-link ET_REL) forces the direct selector. The
562 // optimized path materializes an absolute linmem base (0x20000100) and does
563 // not preserve caller-saved registers across calls — both wrong for a
564 // host-linked object, where the linmem base arrives via `fp` at runtime and
565 // callees follow AAPCS. `select_with_stack` (now i64-spill capable after
566 // #171) handles fp-relative memory + caller-saved preservation correctly.
567 //
568 // #507: `br_table` is DROPPED during the optimized path's wasm→IR lowering
569 // (`optimize_full`), so `ir_to_arm` never sees the dispatch — it emits the
570 // arm bodies in fall-through sequence with no `cmp`/branch on the selector, a
571 // SILENT miscompile (every input hits the last arm). The selector value isn't
572 // even loaded. Because the drop happens before `ir_to_arm`, there's no `Err`
573 // to fall back on; detect it on the raw wasm op stream here and force the
574 // direct selector (`select_with_stack` lowers `br_table` correctly as a
575 // cmp-chain — confirmed on the `--relocatable` path). Same honest-degradation
576 // contract as the issue-#120 f32 decline: the function still compiles
577 // correctly, just without IR-level optimization. Frozen-safe: the frozen
578 // fixtures compile `--relocatable` (already direct), and no optimized-path
579 // fixture (control_step, flight_algo) contains `br_table`.
580 let has_br_table = wasm_ops
581 .iter()
582 .any(|op| matches!(op, WasmOp::BrTable { .. }));
583 // #509: the optimized path also drops the value carried by a `br`/`br_if`
584 // to a result-typed block (the taken edge returns the wrong arm's value —
585 // same silent-miscompile class as the #507 br_table drop). Route the shape
586 // to the direct selector, whose designated-result-register lowering (#509)
587 // lands the carried value at the join. Never fires for void-block control
588 // flow (all frozen/optimized fixtures), so those stay byte-identical.
589 let has_value_carry = has_value_carrying_branch(wasm_ops, &config.current_func_block_arity);
590 // #503-i64/#518: route any signature with a 64-bit (i64/f64) param to the
591 // direct selector. The optimized path's param homing is width-naive — its
592 // #518 decline covers only functions that READ an i64 param (an `I64Load`
593 // from a param index), so a function that reads an i32 param whose AAPCS
594 // home a preceding wide param SHIFTED (e.g. p1 of `(i64 i32)` lives in R2,
595 // not R1; p3 of `(i64 i32 i32 i32)` lives on the stack, not in R3) was
596 // silently miscompiled rather than falling back. The direct selector's
597 // `aapcs_param_layout` homing handles every such shape (i64-param READS
598 // already fell back to it via the ir_to_arm Err, so those functions emit
599 // the same bytes as before). `num_params` counts read-first locals, so a
600 // function that never touches any param keeps the optimized path.
601 let has_wide_param = config
602 .current_func_params_i64
603 .iter()
604 .take(num_params as usize)
605 .any(|&w| w);
606 // #494 phase 2b: div/rem guard-elision marks are consumed by the DIRECT
607 // selector only — the optimized path's IR passes (const-fold/CSE/DCE)
608 // renumber instructions, so an op-index-keyed mark cannot soundly survive
609 // them. Route marked functions direct (the #507/#509 honest-degradation
610 // pattern). Never fires without SYNTH_FACT_SPEC + facts + a discharged
611 // obligation, so every existing compile keeps its path byte-identical.
612 let has_fact_div_elide = !fact_div_zero_elide.is_empty() || !fact_div_ovf_elide.is_empty();
613 // #643: the optimized path's global lowering is width-naive — `GlobalGet`/
614 // `GlobalSet` are single-word `[R9, idx*4]` accesses, which (a) silently
615 // dropped the high word of every i64 global and (b) mis-address every
616 // global whose offset an earlier wide (i64/f64) slot shifted. When the
617 // module has any wide global, route every global-touching function to the
618 // direct selector, whose type-aware summed layout pairs the access (or
619 // declines loudly). Modules with only 4-byte globals — every existing
620 // fixture — keep the optimized path byte-identical.
621 let has_wide_global_module = config.global_widths.iter().any(|&w| w > 4);
622 let has_global_access = has_wide_global_module
623 && wasm_ops
624 .iter()
625 .any(|op| matches!(op, WasmOp::GlobalGet(_) | WasmOp::GlobalSet(_)));
626 // VCR-VER-001 (#242): `post_exhaust` scopes the post-exhaustion cleanup
627 // extensions to functions whose bytes the #580 spill-on-exhaustion
628 // machinery actually shaped (bridge-reported). Everything else — the
629 // direct path, non-exhausted optimized functions — stays byte-identical
630 // flag-on (the `vcr_ver_001_gate_242` lock's contract).
631 let (arm_instrs, post_exhaust) = if config.no_optimize
632 || config.relocatable
633 || has_br_table
634 || has_value_carry
635 || has_wide_param
636 || has_global_access
637 || has_fact_div_elide
638 // #457: route read-before-write non-param locals to the direct
639 // selector, whose prologue zero-init lands the wasm-mandated 0.
640 || has_rbw_local
641 {
642 if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
643 eprintln!("[path-debug] direct (pre-gate)");
644 }
645 (select_direct()?, false)
646 } else {
647 let opt_config = if config.loom_compat {
648 OptimizationConfig::loom_compat()
649 } else {
650 OptimizationConfig::all()
651 };
652
653 let mut bridge = OptimizerBridge::with_config(opt_config);
654 // #188: tell the bridge how many imports there are so it declines only
655 // LOCAL calls (and leaves import calls on the optimized path, keeping
656 // the #173 field-name relocation rewrite intact).
657 bridge.set_num_imports(config.num_imports);
658 // #543 Phase 2: thread the integrator-marked volatile DMA-window ranges
659 // (`--volatile-segment <base>:<len>`) to the bridge's address-caching
660 // levers — base-CSE (#468) excludes any access inside a marked range
661 // from its fold set, and the bridge-level const-CSE declines wholesale
662 // while any range is marked. Empty (the default) ⇒ byte-identical.
663 bridge.set_volatile_segments(config.volatile_segments.clone());
664 // #377: thread `--safety-bounds` to the bridge. Pre-fix the optimized
665 // path ignored it — `software`/`mask` were SILENT NO-OPS on the path
666 // that lowers the bulk of a flight loop's i32 loads/stores (byte-
667 // identical to `none`, while the safety manifest claimed otherwise).
668 // `Software` now emits the inline guard per access; `Masking` declines
669 // memory-accessing functions to the direct selector; `None`/`Mpu` are
670 // byte-identical to before.
671 bridge.set_bounds_check(bounds_config);
672 // #687: thread the absolute linear-memory base the optimized path
673 // materializes. Defaults to 0x2000_0100 (byte-identical);
674 // `--stack-layout=low` shifts it up by the reserved stack size so
675 // const-address accesses follow the moved linear memory.
676 bridge.set_linmem_base(config.linmem_base);
677 // `ir_to_arm` now returns `Result` — an `Err` means the optimized path
678 // hit an unmapped vreg (issue-#93-class). Treat it identically to an
679 // `optimize_full` failure: fall back to the direct selector rather
680 // than propagating, so the function still compiles correctly.
681 match bridge
682 .optimize_full(wasm_ops)
683 .and_then(|(opt_ir, _cfg, _stats)| bridge.ir_to_arm(&opt_ir, num_params as usize))
684 {
685 Ok(arm_ops) => {
686 if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
687 eprintln!("[path-debug] optimized (ir_to_arm ok)");
688 }
689 (
690 arm_ops
691 .into_iter()
692 .map(|op| ArmInstruction {
693 op,
694 source_line: None,
695 })
696 .collect(),
697 bridge.spill_on_exhaust_fired(),
698 )
699 }
700 // Issue #120: the optimized path declines modules it cannot lower
701 // (notably scalar f32/f64 ops — the IR has no float opcodes). Fall
702 // back to the direct instruction selector, which handles f32 via
703 // VFP/FPU. This is honest degradation: the function still compiles
704 // correctly, just without IR-level optimization.
705 Err(e) => {
706 if std::env::var("SYNTH_PATH_DEBUG").is_ok() {
707 eprintln!("[path-debug] direct (fallback: {e})");
708 }
709 (select_direct()?, false)
710 }
711 }
712 };
713
714 // #257/#277: `mul`+`add`→`mla` fusion is intentionally NOT wired here.
715 // The transform is correct and ready (`synth_synthesis::liveness::fuse_mul_add`,
716 // fully tested), but it is **register-allocation-coupled**: over the current
717 // greedy single-pass selector, folding `mul rM,..; add rD,rM,rX` → `mla`
718 // extends the live ranges of the mul inputs to the mla point, and the added
719 // pressure (extra moves/spills) costs more than the single-cycle MLA saves —
720 // gale measured a +2 cyc on-target REGRESSION (flat_flight 255→257, G474RE)
721 // even though it removes 2 instructions and the seam stays 0x07FDF307. So the
722 // fusion stays unwired until the spill-aware allocator (VCR-RA-001) chooses
723 // registers, at which point it becomes net-positive (per #272's plan and the
724 // wiring design note). Lesson (#277): a register-pressure-affecting transform
725 // needs an on-target/allocator-aware gate, not a byte-count gate, before it
726 // can default on.
727
728 // VCR-RA-001 const-CSE / rematerialization-avoidance (#209): moved to run
729 // LAST, after the immediate-folds — see the apply_const_cse call below
730 // (#242). Earlier it ran here (before range-realloc and the folds), which is
731 // what let it grow gale's --relocatable `gust_mix` 90→92 B (#242 burndown,
732 // 2026-06-26): retargeting a read defeated a *downstream* immediate-fold that
733 // would otherwise have absorbed the constant. Running CSE-last makes those
734 // foldable consts already-folded-and-gone, so CSE only ever touches genuinely
735 // redundant materializations.
736
737 // VCR-RA-001 RANGE RE-ALLOCATION (#209/#242, wiring step 3a) — the first
738 // CONSEQUENTIAL allocator pass: re-colour each maximal straight-line
739 // segment over the R0-R8 pool with value ranges as the allocation unit
740 // (segment inputs + per-register live-outs pinned to their original
741 // registers, reserved R9-R12/SP identity-assigned — each segment is
742 // independently sound, no cross-segment liveness assumed). Renames
743 // registers only: never adds, removes, or reorders instructions, so
744 // labels/branch offsets are unaffected.
745 //
746 // DEFAULT-ON since v0.11.36: gale cleared the gate on-target (G474RE,
747 // #209 2026-06-10) — flag-on output byte-identical to flag-off on
748 // flat_flight/controller/control_step, fires on the filter family with
749 // zero cycle delta and a small size win, all selfchecks green on silicon.
750 // Opt out with `SYNTH_RANGE_REALLOC=0`; per-function stats with
751 // `SYNTH_REALLOC_STATS=1`.
752 //
753 // The companion dead callee-saved-save elimination (gale's "next
754 // consequential lever", same issue comment) then shrinks the prologue
755 // `push {r4-r8,lr}` / epilogue `pop {r4-r8,pc}` to the callee-saved
756 // registers the re-allocated body still touches (leaf-only,
757 // SP-untouched, even-count-padded — see shrink_callee_saved_saves):
758 // ~12 cycles of pure save/restore overhead removed on small leaves.
759 let realloc_on = std::env::var("SYNTH_RANGE_REALLOC").map_or(true, |v| v != "0");
760 let arm_instrs = if realloc_on {
761 use synth_synthesis::rules::Reg;
762 const POOL: [Reg; 9] = [
763 Reg::R0,
764 Reg::R1,
765 Reg::R2,
766 Reg::R3,
767 Reg::R4,
768 Reg::R5,
769 Reg::R6,
770 Reg::R7,
771 Reg::R8,
772 ];
773 // VCR-VER-001 (#242): on a function the spill-on-exhaustion machinery
774 // shaped, the terminal segment gets relaxed live-out pinning (only
775 // R0/R1 are observable past `bx lr` at this pre-prologue position) so
776 // the colourer can lower R4-R8-homed tails into caller-saved R0-R3 —
777 // shrinking the `push {r4-r8,lr}` the #580 exhaustion shapes pay for.
778 // `post_exhaust == false` selects the shipping pass bit for bit.
779 let (out, stats) = synth_synthesis::liveness::reallocate_function_post_exhaust(
780 &arm_instrs,
781 &POOL,
782 post_exhaust,
783 );
784 if std::env::var("SYNTH_REALLOC_STATS").is_ok() {
785 eprintln!(
786 "[range-realloc] {} segments: {} reallocated, {} declined ({} validator-rejected), {} need spill (step 4)",
787 stats.segments,
788 stats.reallocated,
789 stats.declined,
790 stats.validator_rejects,
791 stats.needs_spill
792 );
793 }
794 // VCR-RA-002 (#390, epic #242): eliminate a provably-dead stack frame
795 // (`sub sp,#N`/`add sp,#N` reserved by `compute_local_layout` for locals
796 // that promotion homed in registers, never accessed). Removing it saves
797 // the two instructions AND restores the SP-untouched precondition that
798 // `shrink_callee_saved_saves` requires — so it must run FIRST.
799 // DEFAULT-ON (#242 flag audit flip-wave, #592 audit item): evidence
800 // basis was the 2-path × repro-corpus sweep — 0 functions grow, 58
801 // shrink (flight_seam controller_step 250→242 −8 / filter_step 180→168
802 // −12, native_pointer frame_roundtrip 46→34 −12), locked by the
803 // `dead_frame_elim_no_grow_corpus_242` cargo gate; execution
804 // differentials re-run green on the new default bytes BEFORE the
805 // frozen ARM anchors were re-pinned (leaf_dead_frame, flight_seam,
806 // frame_slot_dce — see the flip PR). Escape hatch:
807 // `SYNTH_DEAD_FRAME_ELIM=0` opts out and restores the pre-flip bytes
808 // (CI-gated in `frozen_codegen_bytes.rs`).
809 let out = if !std::env::var("SYNTH_DEAD_FRAME_ELIM").is_ok_and(|v| v == "0") {
810 synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out)
811 } else {
812 out
813 };
814 // #490 (epic #242): the optimized selector uses r4-r8 as scratch /
815 // promoted locals but emits no prologue, silently clobbering a caller's
816 // callee-saved registers. Add the missing `push {r4-r8,lr}` /
817 // `pop {r4-r8,pc}` HERE — on the post-realloc body, where realloc has
818 // lowered low-pressure r4-r8 scratch back to r0-r3, so a save is added
819 // only for registers genuinely clobbered. `shrink_callee_saved_saves`
820 // (next) then trims it to the used set. No-op on the direct path (it
821 // already has its own prologue) and on callee-saved-free leaves.
822 let out = synth_synthesis::liveness::ensure_callee_saved_prologue(&out);
823 synth_synthesis::liveness::shrink_callee_saved_saves(&out).unwrap_or(out)
824 } else {
825 // Range-realloc off (`SYNTH_RANGE_REALLOC=0`): the optimized path still
826 // must preserve the callee-saved registers it clobbers (#490). No shrink
827 // (it is coupled to the realloc lever), so the conservative full save
828 // stays — correct, just not minimised in this debug configuration.
829 synth_synthesis::liveness::ensure_callee_saved_prologue(&arm_instrs)
830 };
831
832 // VCR-RA-001 SHADOW ALLOCATION (#209/#242): run the register allocator on
833 // the selected stream and LOG what it finds — without changing a single
834 // emitted byte. This is the measure-only bridge between the built analysis
835 // layer and the eventual virtual-register wiring: it shows, per real
836 // function, whether the allocator can colour it within the R0–R8 pool and
837 // how much const-CSE / rematerialization headroom exists (#209). Enable with
838 // `SYNTH_SHADOW_ALLOC=1`; off by default and side-effect-free either way.
839 if std::env::var("SYNTH_SHADOW_ALLOC").is_ok() {
840 use synth_synthesis::liveness::{
841 AllocationOutcome, allocate_function, function_peak_pressure,
842 };
843 // R9 globals / R10 mem-size / R11 mem-base / R12 IP-scratch are reserved;
844 // pin them above the 0..9 allocatable pool so the colourer keeps R0–R8.
845 let precolored = std::collections::BTreeMap::from([
846 (synth_synthesis::rules::Reg::R9, 9usize),
847 (synth_synthesis::rules::Reg::R10, 10),
848 (synth_synthesis::rules::Reg::R11, 11),
849 (synth_synthesis::rules::Reg::R12, 12),
850 ]);
851 // True VALUE pressure (one node per value, not per reused physical reg):
852 // a NeedsSpill with peak ≤ 9 is a SPURIOUS physical-register spill — the
853 // function fits once virtually allocated.
854 let peak = function_peak_pressure(&arm_instrs);
855 match allocate_function(&arm_instrs, 9, &precolored) {
856 AllocationOutcome::Allocated {
857 remat_opportunities,
858 coloring,
859 } => eprintln!(
860 "[shadow-alloc] OK: {} pregs coloured within R0-R8 pool, peak value-pressure {}, {} const-CSE/remat opportunities",
861 coloring.len(),
862 peak,
863 remat_opportunities
864 ),
865 AllocationOutcome::NeedsSpill(s) => eprintln!(
866 "[shadow-alloc] physical-graph would spill {:?}, but peak value-pressure is {} (≤9 ⇒ spurious; fits once virtually allocated)",
867 s, peak
868 ),
869 AllocationOutcome::Declined => {
870 eprintln!(
871 "[shadow-alloc] declined (unmodeled construct — calls/i64/fp/offset-branch)"
872 )
873 }
874 }
875 }
876
877 // VCR-SEL-004 cmp→select → IT-block predication fusion (#242). The selector
878 // lowers a `select` whose condition is a comparison to a *materialize then
879 // re-test* sequence (`cmp a,b; SetCond D,c; cmp D,#0; movne dst,v1; moveq
880 // dst,v2`); this collapses it onto the comparison's own flags — deleting the
881 // `SetCond` and the `cmp D,#0` and retargeting the predicated moves to `c` /
882 // `invert(c)` — yielding the textbook predicated clamp (`cmp a,b; movc dst,v1;
883 // mov{!c} dst,v2`). −2 instructions per fused select. gale #428 measured this
884 // as the #1 hot-path size/cycle lever on the gust_mix clamp chain.
885 //
886 // Run LATE: after range re-allocation (so the dead-D proof sees final register
887 // identities) and before encode. Removal-only + rename-only ⇒ no spill
888 // regression and labels/branch offsets are unaffected. Each fusion is proven
889 // sound (flags reused only when nothing clobbers them in the window; the
890 // boolean deleted only when provably dead) — see `fuse_cmp_select`.
891 //
892 // DEFAULT-ON as of v0.13.0 (#428): cmp→select fusion ships by default. The
893 // byte-changing flip is validated by (a) the unicorn execution oracle that runs
894 // the two-move `mov{invert(c)}` arm (cmp_select_two_move_differential.py), (b)
895 // gale's gale_decider_diff 10,596-case sweep across all 8 verified primitives
896 // (native ≡ flag-off ≡ flag-on = 0x88e73178d232bcf5), and (c) the named-anchor
897 // differentials re-run with fusion ON — control_step still 0x00210A55, flat+
898 // inlined flight_algo still 0x07FDF307 (results preserved; bytes deliberately
899 // changed, re-frozen on this commit). Escape hatch: `SYNTH_NO_CMP_SELECT_FUSE=1`
900 // reverts to the pre-fusion lowering. The on-silicon G474RE DWT no-regression
901 // check is a tracked post-ship follow-up (gale owns it).
902 let arm_instrs = if std::env::var("SYNTH_NO_CMP_SELECT_FUSE").is_err() {
903 // The rewritten stream is identical to `fuse_cmp_select`'s 2-tuple form;
904 // the extra `two_move` count is diagnostic only (the fusion census /
905 // blast-radius datum — #7 made that arm reachable).
906 let (out, fused, two_move) =
907 synth_synthesis::liveness::fuse_cmp_select_with_stats(&arm_instrs);
908 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
909 let in_place = fused - two_move;
910 eprintln!(
911 "[cmp-select-fuse] {fused} select(s) fused to predicated moves \
912 ({two_move} two-move, {in_place} in-place)"
913 );
914 }
915 out
916 } else {
917 arm_instrs
918 };
919
920 // Perf lever 1 toward native parity (#390): redundant stack-reload elimination.
921 // synth lowers every wasm local to a frame slot, so `local.set; local.get` emits
922 // `str rX,[sp,#N]; … ; ldr rY,[sp,#N]`; when rX still holds the value the reload
923 // (a ~2-cycle M4 load) becomes `mov rY,rX`. Removal-of-a-load + rename only ⇒ no
924 // new instruction form and no label/offset change. DEFAULT-ON (#242 feature
925 // loop): validated bit-identical RESULTS on every frozen anchor (control_step
926 // 0x00210A55 13/13, flat+inlined flight_algo 0x07FDF307) with .text reduced on
927 // the shipped --relocatable path, plus 8 unit tests + the frame_slot_dce
928 // execution differential — the same gated path cmp→select took to default-on in
929 // v0.13.0 (G474RE silicon confirms perf post-ship). Escape hatch:
930 // `SYNTH_NO_STACK_FWD=1` restores the frame-resident bytes (frozen-old goldens).
931 let stack_fwd = std::env::var("SYNTH_NO_STACK_FWD").is_err();
932 let arm_instrs = if stack_fwd {
933 let (out, fwd) = synth_synthesis::liveness::forward_stack_reloads(&arm_instrs);
934 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
935 eprintln!("[stack-fwd] {fwd} stack reload(s) forwarded to register moves");
936 }
937 out
938 } else {
939 arm_instrs
940 };
941
942 // VCR-RA frame-slot DCE (#242): once `forward_stack_reloads` has turned the
943 // reloads of a spill slot into register moves, the `str rX,[sp,#N]` that fed
944 // them is a dead store — its slot is never loaded again. Remove it. Pairs
945 // with (and only pays after) stack-reload forwarding, so it shares the flag.
946 let arm_instrs = if stack_fwd {
947 let (out, n) = synth_synthesis::liveness::eliminate_dead_frame_stores(&arm_instrs);
948 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
949 eprintln!("[frame-slot-dce] {n} dead frame store(s) removed");
950 }
951 out
952 } else {
953 arm_instrs
954 };
955
956 // VCR-RA-001 spill re-choice (#242), two stages behind one flag.
957 // Stage 1 (the #569 spike): slot-value forwarding BETWEEN reloads.
958 // `forward_stack_reloads` (above) forwards only from a spill store's
959 // SOURCE register, so when register pressure clobbers that source its
960 // reloads survive; this stage tracks which registers provably still hold
961 // a frame slot's value (through earlier reloads and reg-reg moves) and
962 // turns reload #2..#n into a 1-cycle `mov` (or deletes it when the target
963 // already holds the value). Stage 2 (the Belady re-choice): where NO
964 // register still holds the value — the genuine-spill case, flat_flight's
965 // peak-11 hot segment — the value was usually evicted while a dead
966 // register existed; the clobbering def(s) are renamed onto a provably-dead
967 // register (`spill_rechoice_segment`) so the value stays resident and the
968 // reload dissolves outright. A dissolved reload can leave the feeding
969 // store dead, so the frame-slot DCE sweep runs once more behind the same
970 // flag. Per-segment commit gates: executable same-value-flow trace
971 // equality, strict shrink, pool-pressure fit, sub-word/unknown-slot
972 // conservatism (see `apply_spill_realloc` / `spill_rechoice_segment`).
973 // Stage 3 (whole-function slot liveness): the segment-local DCE keeps a
974 // store whose slot reaches function end ("reach-end ≠ dead" — it cannot
975 // see other segments); `eliminate_unread_frame_stores` walks the whole
976 // function (labels/branches/loops, SP-displacement tracked) and drops a
977 // store whose slot NO reachable instruction can read — flat_flight's two
978 // surviving stores (#576), completing Belady's 0-load side with a 0-store
979 // side. Same flag: the three stages are one lever, flipped together.
980 // DEFAULT-ON (#242 feature loop, the v0.14.0 local-promotion pattern):
981 // Belady spilling ships by default. Evidence basis for the flip: three
982 // landed flag-off increments (#569 forwarding, #576 Belady re-choice,
983 // #579 whole-fn slot liveness), 40+ functions shrink / 0 grow across the
984 // 68-fixture × 2-path sweep, per-segment executable value-trace equality
985 // guards, and the unicorn-vs-wasmtime execution differentials re-run
986 // green on the new default bytes (flat+inlined flight_algo 0x07FDF307,
987 // const_cse, frame_slot_dce, spill_rung_581, r12_spill_496 — which covers
988 // control_step_decide vs wasmtime; control_step's .text is byte-identical
989 // under the flip) BEFORE the frozen goldens were re-pinned. Escape hatch:
990 // `SYNTH_SPILL_REALLOC=0` is the OPT-OUT — it disables all three stages
991 // and restores the pre-flip bytes (CI-gated by
992 // `frozen_fixtures_spill_realloc_escape_hatch_restores_old_bytes`). Any
993 // other value (or unset) runs the pass.
994 // VCR-VER-001 post-exhaustion extensions (#242, the PR #659 verdict): with
995 // `SYNTH_SPILL_ON_EXHAUST` active the #580 allocation-time Belady spill
996 // keeps exhausted functions on the optimized path, and its slots present
997 // shapes the shipping pass structurally cannot fire on (fresh-monotonic
998 // slots defeat the overwrite-only DCE; the eviction store's source is
999 // redefined immediately, defeating store→reload forwarding; R2/R3 are
1000 // never touched again, so the rename-target deadness proof declines them).
1001 // `post_exhaust` (bridge-scoped, see above) enables const
1002 // rematerialization of spilled constants, R2/R3 exit-dead rename targets,
1003 // and per-pair pressure commit — see `apply_spill_realloc_post_exhaust`.
1004 // Flag off (the default): `false` selects the shipping behavior bit for
1005 // bit.
1006 let arm_instrs = if !std::env::var("SYNTH_SPILL_REALLOC").is_ok_and(|v| v == "0") {
1007 let (out, n) =
1008 synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&arm_instrs, post_exhaust);
1009 let (out, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&out);
1010 let (mut out, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&out);
1011 let (mut tn, mut td, mut tu) = (n, d, u);
1012 // Post-exhaustion only: iterate the triple to a bounded fixpoint. Each
1013 // dissolved spill pair frees registers and removes stores, exposing
1014 // rename windows and holder chains the previous iteration could not
1015 // prove — the allocation-time Belady slots (#580) routinely need two
1016 // or three rounds where the shipping single round suffices for the
1017 // default path's slots. Every iteration is individually gate-proven
1018 // (value-trace equality, pool pressure, strict shrink), so iterating
1019 // composes soundly; the bound keeps compile time deterministic.
1020 if post_exhaust {
1021 let mut progress = n + d + u > 0;
1022 for _ in 0..3 {
1023 if !progress {
1024 break;
1025 }
1026 let (o, n) =
1027 synth_synthesis::liveness::apply_spill_realloc_post_exhaust(&out, true);
1028 let (o, d) = synth_synthesis::liveness::eliminate_dead_frame_stores(&o);
1029 let (o, u) = synth_synthesis::liveness::eliminate_unread_frame_stores(&o);
1030 progress = n + d + u > 0;
1031 (tn, td, tu) = (tn + n, td + d, tu + u);
1032 out = o;
1033 }
1034 // The cleanup can leave the spill frame with zero surviving
1035 // accesses (every reload rematerialized/dissolved, every store
1036 // swept) — the balanced `sub sp,#K`/`add sp,#K` is then pure
1037 // overhead. `elide_dead_frame` proves that and removes the pair;
1038 // its early run (post-realloc) could not, because the spill
1039 // traffic was still in the stream at that point.
1040 out = synth_synthesis::liveness::elide_dead_frame(&out).unwrap_or(out);
1041 }
1042 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1043 eprintln!(
1044 "[spill-realloc] {tn} reload(s) forwarded/eliminated, {td} newly-dead frame store(s) removed, {tu} unread-slot store(s) removed"
1045 );
1046 }
1047 out
1048 } else {
1049 arm_instrs
1050 };
1051
1052 // VCR-RA immediate-shift folding (#390, #242): a constant shift amount the
1053 // stack selector materialized into a scratch register (`movw rM,#C; lsl rD,rN,rM`)
1054 // folds to the immediate form (`lsl rD,rN,#C`), removing the dead `movw` — −1
1055 // instruction, −1 live register. Removal-only (offset-neutral before branch
1056 // resolution, like the dead-store pass). DEFAULT-ON as of v0.15.0: validated
1057 // bit-identical results + a net cycle win on the dissolved hot path (−2
1058 // cyc/call, .text 100→90 B on gust_mix). Escape hatch: `SYNTH_NO_IMM_SHIFT_FOLD=1`.
1059 let arm_instrs = if std::env::var("SYNTH_NO_IMM_SHIFT_FOLD").is_err() {
1060 let (out, folds) = synth_synthesis::liveness::fold_immediate_shifts(&arm_instrs);
1061 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1062 eprintln!(
1063 "[imm-shift-fold] {folds} register shift(s) folded to immediate, movw dropped"
1064 );
1065 }
1066 out
1067 } else {
1068 arm_instrs
1069 };
1070
1071 // #686: elide the #682 mod-32 shift-amount mask (`and r12,rK,#31` before
1072 // every register-controlled i32 shl/shr) when the amount is STATICALLY
1073 // provable < 32 — a const amount folds to the immediate-shift form
1074 // (reduced mod 32, so >= 32 shrinks too), and an already-masked amount
1075 // (`rK = rX & c`, c < 32) drops the redundant re-mask. gale measured the
1076 // unconditional mask at ~12% cyc/call (+14 B) on gust_mix, whose Q8
1077 // fixed-point shifts are all constants (#686). The mask stays wherever
1078 // the bound is unproven — elision is an optimization, the mask is the
1079 // sound default (`liveness::elide_shift_masks` has the proof
1080 // obligations). Runs after `fold_immediate_shifts` (whose movw→shift
1081 // window the #682 mask intercepts, so it declines every masked const
1082 // shift) and before branch resolution (removal/rewrite-only ⇒
1083 // offset-neutral).
1084 //
1085 // FLAG-OFF (opt-in via `SYNTH_SHIFT_MASK_ELIDE=1`) because the elision
1086 // moves the frozen anchors: const-amount shifts in control_step (−20 B),
1087 // flight_seam (−164 B) and flight_seam_flat (−168 B) fold back to the
1088 // immediate form — byte-shapes the corpus had BEFORE the #682 mask, now
1089 // with the mask soundly kept for every unproven amount. Flipping
1090 // default-on is a deliberate byte-changing refreeze (all differentials
1091 // re-run on the new bytes, goldens re-pinned) owned by the maintainer.
1092 let arm_instrs = if std::env::var("SYNTH_SHIFT_MASK_ELIDE").is_ok_and(|v| v != "0") {
1093 let (out, elisions) = synth_synthesis::liveness::elide_shift_masks(&arm_instrs);
1094 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1095 eprintln!(
1096 "[shift-mask-elide] {elisions} provably-<32 shift-amount mask(s) elided (#686)"
1097 );
1098 }
1099 out
1100 } else {
1101 arm_instrs
1102 };
1103
1104 // VCR-RA uxth/uxtb fold (#428, #242): `movw rM,#0xffff; and rD,rN,rM` →
1105 // `uxth rD,rN` (and the 0xff/uxtb form), removing the dead `movw` — −1
1106 // instruction, −1 live register per 16/8-bit mask. 0xffff/0xff are not Thumb-2
1107 // modified immediates so the selector materializes them into a register; the
1108 // dedicated zero-extend expresses the same masking inline. Removal-only +
1109 // rewrite-in-place (offset-neutral). DEFAULT-ON (#242 flag audit flip-wave,
1110 // #592 audit item): evidence basis was the 2-path × repro-corpus sweep —
1111 // 0 functions grow, 13 shrink (control_step 300→294 −6, gust_mix 38→32 −6,
1112 // uxth_fold pack 36→24 −12), locked by the `uxth_fold_no_grow_corpus_242`
1113 // cargo gate; execution differentials re-run green on the new default
1114 // bytes BEFORE the frozen ARM anchors were re-pinned (uxth_fold,
1115 // control_step — see the flip PR). Escape hatch: `SYNTH_UXTH_FOLD=0` opts
1116 // out and restores the pre-flip bytes (CI-gated in
1117 // `frozen_codegen_bytes.rs`).
1118 let arm_instrs = if !std::env::var("SYNTH_UXTH_FOLD").is_ok_and(|v| v == "0") {
1119 let (out, folds) = synth_synthesis::liveness::fold_uxth(&arm_instrs);
1120 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1121 eprintln!("[uxth-fold] {folds} mask-and folded to uxth/uxtb, movw dropped");
1122 }
1123 out
1124 } else {
1125 arm_instrs
1126 };
1127
1128 // VCR-RA-001 const-CSE / rematerialization-avoidance (#209, #242). Drops a
1129 // `movw`/`mov #imm` that re-materializes a constant already resident in
1130 // another register and retargets the reads — every rewrite proven by the
1131 // liveness analysis. Runs LAST, after every immediate-fold (shift, uxth) and
1132 // range-realloc, but BEFORE branch resolution/encoding (it removes
1133 // instructions, shifting byte offsets). CSE-last is the #242 no-regression
1134 // fix: the folds have already absorbed every foldable constant, so CSE can no
1135 // longer defeat one (the gust_mix 90→92 mechanism). The pass additionally
1136 // size-guards each segment via the byte-estimator — it commits a segment's
1137 // rewrites only if they do not grow its estimated size — so a retarget that
1138 // would flip a 16-bit encoding to 32-bit (higher base register) is declined.
1139 // DEFAULT-ON (#242 flip-wave, the SYNTH_SPILL_REALLOC/SYNTH_BASE_CSE
1140 // template): const-CSE ships by default. The flip prerequisites recorded in
1141 // `const_cse_reduction_242.rs` were retired first — the bridge-level INLINE
1142 // aliasing (the alias-eviction spill-bijection hazard) was DELETED from
1143 // `optimizer_bridge::ir_to_arm`, so this post-hoc, liveness-proven pass is
1144 // the flag's ONLY effect. Evidence basis: 152 fixture×path corpus sweep — 0
1145 // functions grow (size-guarded per segment), 40 shrink (const_cse::spill12
1146 // 236→148 B), total −536 B — and the execution differentials re-run green
1147 // on the new default bytes BEFORE the frozen goldens were re-pinned
1148 // (const_cse, frame_slot_dce, flight_seam 0x07FDF307, spill_rung_581,
1149 // volatile_segment_543, control_step 0x00210A55). Escape hatch:
1150 // `SYNTH_CONST_CSE=0` is the OPT-OUT — it restores the pre-flip bytes
1151 // (CI-gated by `const_cse_escape_hatch_restores_old_bytes_242` and the
1152 // frozen-anchor escape-hatch gate). Any other value (or unset) runs the pass.
1153 //
1154 // #543 Phase 2: const-CSE declines WHOLESALE while any volatile DMA range
1155 // (`--volatile-segment`) is marked. At the ArmOp level a cached constant
1156 // cannot be classified as address-vs-data (a retargeted read may be a
1157 // memory-access base carrying a per-use immediate offset), so the
1158 // conservative stance for statically-unknown addressing is to decline every
1159 // aliasing rewrite — each constant is re-materialized at each occurrence,
1160 // the documented volatile contract (`CompileConfig::volatile_segments`).
1161 let arm_instrs = if !std::env::var("SYNTH_CONST_CSE").is_ok_and(|v| v == "0")
1162 && config.volatile_segments.is_empty()
1163 {
1164 let (out, removed) = synth_synthesis::liveness::apply_const_cse(&arm_instrs);
1165 if std::env::var("SYNTH_FUSE_STATS").is_ok() {
1166 eprintln!("[const-cse] {removed} redundant constant materialization(s) removed");
1167 }
1168 out
1169 } else {
1170 arm_instrs
1171 };
1172
1173 // VCR-RA-001 spill-choice REPORT (#242): measure-only, like SYNTH_SHADOW_ALLOC.
1174 // Per straight-line segment, the frame-slot traffic actually emitted vs the
1175 // reload/store count a farthest-next-use (Belady) allocation over the R0-R8
1176 // pool would need — the measured headroom for the full spill-choice rewrite.
1177 // Printed on the FINAL stream (post all rewrite passes), so a flag-off run
1178 // reports the greedy baseline and a flag-on run reports what remains.
1179 if std::env::var("SYNTH_SPILL_REPORT").is_ok() {
1180 for seg in synth_synthesis::liveness::spill_choice_report(&arm_instrs, 9) {
1181 if seg.actual_reloads + seg.actual_spill_stores > 0 || seg.peak_pressure > 9 {
1182 eprintln!(
1183 "[spill-report] seg@{} len={} peak={} actual={}ld+{}st belady(k=9)={}ld+{}st",
1184 seg.start,
1185 seg.len,
1186 seg.peak_pressure,
1187 seg.actual_reloads,
1188 seg.actual_spill_stores,
1189 seg.belady_reloads,
1190 seg.belady_spill_stores
1191 );
1192 }
1193 }
1194 }
1195
1196 // ISA feature gate: validate that all generated instructions are supported
1197 // by the target. This catches FPU instructions on no-FPU targets, double-precision
1198 // instructions on single-precision targets, etc.
1199 validate_instructions(&arm_instrs, config.target.fpu, &config.target.triple)
1200 .map_err(|e| format!("ISA validation failed: {}", e))?;
1201
1202 // Encode to binary — use Thumb-2 for Cortex-M targets
1203 let use_thumb2 = matches!(config.target.isa, IsaVariant::Thumb2 | IsaVariant::Thumb);
1204
1205 let encoder = if use_thumb2 {
1206 ArmEncoder::new_thumb2_with_fpu(config.target.fpu)
1207 } else {
1208 ArmEncoder::new_arm32()
1209 };
1210
1211 // #202: resolve local label branches (Bcc/B/Bhs/Blo) to byte-accurate
1212 // offsets before encoding. `select_with_stack` emits them as label
1213 // placeholders and never resolves them — without this they encode as
1214 // `bne.n #0` and land mid-instruction whenever a 32-bit Thumb-2 instruction
1215 // sits between the branch and its target (UsageFault on real hardware).
1216 // Only meaningful for Thumb-2 (the offset units are halfword/PC+4).
1217 let arm_instrs = if use_thumb2 {
1218 resolve_label_branches(arm_instrs, &encoder)?
1219 } else {
1220 arm_instrs
1221 };
1222
1223 let mut code = Vec::new();
1224 let mut relocations = Vec::new();
1225
1226 // #345: literal-pool address loads. Each `LdrSym` was encoded as a placeholder
1227 // `LDR.W rd,[pc,#0]`; record where its instruction sits and what it loads so
1228 // we can append a pooled word (carrying the symbol address via R_ARM_ABS32)
1229 // and patch the PC-relative offset once the pool position is known.
1230 struct PendingLiteral {
1231 ldr_offset: u32,
1232 symbol: String,
1233 addend: i32,
1234 }
1235 let mut pending_literals: Vec<PendingLiteral> = Vec::new();
1236
1237 // VCR-DBG-001: per-instruction source map for DWARF `.debug_line`. Captured
1238 // here because `code.len()` immediately before `encode()` is the final
1239 // machine offset of the instruction within this function's `.text` — nothing
1240 // after the loop shifts earlier instructions (the literal pool is appended at
1241 // the end; the LDR patch below is in-place/length-preserving). Purely
1242 // additive: it does not touch `code`, so `.text` is byte-identical.
1243 let mut line_map: LineMap = Vec::new();
1244
1245 for instr in &arm_instrs {
1246 // Record a relocation for every BL: the encoder emits `bl #0` and
1247 // relies on a relocation to patch the target. This covers BOTH import
1248 // dispatch stubs (`__meld_*`, undefined externals) AND internal calls
1249 // (`func_N`, defined in this object). Previously only `__meld_*` was
1250 // recorded, so internal `BL func_N` calls were left as unpatched
1251 // `bl #0` placeholders branching to a garbage address (#167).
1252 if let ArmOp::Bl { label } = &instr.op {
1253 relocations.push(CodeRelocation {
1254 offset: code.len() as u32,
1255 symbol: label.clone(),
1256 kind: synth_core::backend::RelocKind::ThmCall,
1257 });
1258 }
1259 // #237: symbol-relative MOVW/MOVT (the `--native-pointer-abi` static-data
1260 // addressing). The encoder writes the addend in place; record the matching
1261 // R_ARM_MOVW_ABS_NC / R_ARM_MOVT_ABS so the linker adds the symbol address.
1262 if let ArmOp::MovwSym { symbol, .. } = &instr.op {
1263 relocations.push(CodeRelocation {
1264 offset: code.len() as u32,
1265 symbol: symbol.clone(),
1266 kind: synth_core::backend::RelocKind::MovwAbs,
1267 });
1268 }
1269 if let ArmOp::MovtSym { symbol, .. } = &instr.op {
1270 relocations.push(CodeRelocation {
1271 offset: code.len() as u32,
1272 symbol: symbol.clone(),
1273 kind: synth_core::backend::RelocKind::MovtAbs,
1274 });
1275 }
1276 // #345: defer the literal-pool word + reloc + offset patch to the
1277 // post-loop pass (the pool address is not yet known).
1278 if let ArmOp::LdrSym { symbol, addend, .. } = &instr.op {
1279 pending_literals.push(PendingLiteral {
1280 ldr_offset: code.len() as u32,
1281 symbol: symbol.clone(),
1282 addend: *addend,
1283 });
1284 }
1285
1286 // The machine offset of this instruction is the current code length,
1287 // captured before the bytes are appended.
1288 line_map.push((code.len() as u32, instr.source_line));
1289
1290 let encoded = encoder
1291 .encode(&instr.op)
1292 .map_err(|e| format!("ARM encoding failed: {}", e))?;
1293 code.extend_from_slice(&encoded);
1294 }
1295
1296 // #345: place the literal pool at the end of this function's `.text`. Gated on
1297 // there being at least one `LdrSym` — functions without one are byte-identical
1298 // to before (no trailing padding, so downstream `func_offsets` are unchanged
1299 // and the frozen differential fixtures stay bit-for-bit equal).
1300 if !pending_literals.is_empty() {
1301 if !use_thumb2 {
1302 return Err("LdrSym literal-pool addressing requires Thumb-2".to_string());
1303 }
1304 // 4-byte align the pool start (Thumb-2 word loads require it, and
1305 // `Align(PC,4)` in the LDR-literal semantics assumes a word-aligned pool).
1306 while code.len() % 4 != 0 {
1307 code.push(0x00);
1308 }
1309 // One distinct pooled word per LdrSym (no dedup: different sites carry
1310 // different addends, and the REL addend lives in the word).
1311 for lit in &pending_literals {
1312 let word_offset = code.len() as u32;
1313
1314 // REL semantics: the linker computes `S + A`, where A is the in-place
1315 // value of the relocated word. Initialize the word to the addend so
1316 // the final loaded address is `symbol + addend`.
1317 code.extend_from_slice(&(lit.addend as u32).to_le_bytes());
1318 relocations.push(CodeRelocation {
1319 offset: word_offset,
1320 symbol: lit.symbol.clone(),
1321 kind: synth_core::backend::RelocKind::Abs32,
1322 });
1323
1324 // Patch the placeholder `LDR.W rd,[pc,#imm12]`. Thumb-2 LDR (literal):
1325 // address = Align(PC,4) + imm12, with PC = ldr_offset + 4. The pool is
1326 // always after the LDR, so U=1 (already set in hw1 = 0xF8DF).
1327 let pc = lit.ldr_offset + 4;
1328 let aligned_pc = pc & !3u32;
1329 let imm12 = word_offset - aligned_pc;
1330 if imm12 > 0xFFF {
1331 // Wide LDR-literal range is ±4 KB; these function bodies are far
1332 // smaller, but fail cleanly rather than miscompile if exceeded.
1333 return Err(format!(
1334 "LdrSym literal pool out of range (#345): imm12={} > 4095 \
1335 for symbol {}",
1336 imm12, lit.symbol
1337 ));
1338 }
1339 let hw2_off = (lit.ldr_offset + 2) as usize;
1340 let mut hw2 = u16::from_le_bytes([code[hw2_off], code[hw2_off + 1]]);
1341 hw2 = (hw2 & 0xF000) | (imm12 as u16); // keep Rt, set imm12
1342 let hw2_bytes = hw2.to_le_bytes();
1343 code[hw2_off] = hw2_bytes[0];
1344 code[hw2_off + 1] = hw2_bytes[1];
1345 }
1346 }
1347
1348 Ok((code, relocations, line_map))
1349}
1350
1351/// Resolve local label branches to byte-accurate offsets (#202).
1352///
1353/// `select_with_stack` emits conditional/unconditional branches as label
1354/// placeholders (`Bcc`/`B`/`Bhs`/`Blo` + `Label`) and never resolves them; the
1355/// encoder then emits a `0xD000`/`0xE000` placeholder with offset 0. Before #197
1356/// this path only ran for `--no-optimize`/declined functions, so the latent bug
1357/// stayed hidden — routing relocatable code through it surfaced branches that
1358/// land mid-instruction (a Cortex-M UsageFault) whenever a 32-bit Thumb-2
1359/// instruction sits between the branch and its target.
1360///
1361/// This pass encodes each instruction to learn its real byte length (so 16- vs
1362/// 32-bit forms and multi-instruction expansions are exact), maps each `Label`
1363/// to its byte position, and rewrites every label branch to the displacement
1364/// the encoder consumes: `(target - branch - 4) / 2` halfwords. A bounded
1365/// fixed-point handles an offset growing a branch from 16- to 32-bit (which
1366/// shifts later positions). `BCondOffset`/`BOffset` already produced inline by
1367/// the optimized path carry no label and are left untouched.
1368fn resolve_label_branches(
1369 arm_instrs: Vec<ArmInstruction>,
1370 encoder: &ArmEncoder,
1371) -> Result<Vec<ArmInstruction>, String> {
1372 use std::collections::HashMap;
1373 use synth_synthesis::Condition;
1374
1375 enum BKind {
1376 Cond(Condition),
1377 Uncond,
1378 }
1379 // Record each label branch ONCE — indices are stable across iterations.
1380 let mut branches: Vec<(usize, BKind, String)> = Vec::new();
1381 for (i, instr) in arm_instrs.iter().enumerate() {
1382 match &instr.op {
1383 ArmOp::Bcc { cond, label } => branches.push((i, BKind::Cond(*cond), label.clone())),
1384 ArmOp::Bhs { label } => branches.push((i, BKind::Cond(Condition::HS), label.clone())),
1385 ArmOp::Blo { label } => branches.push((i, BKind::Cond(Condition::LO), label.clone())),
1386 ArmOp::B { label } => branches.push((i, BKind::Uncond, label.clone())),
1387 _ => {}
1388 }
1389 }
1390 if branches.is_empty() {
1391 return Ok(arm_instrs);
1392 }
1393
1394 let mut resolved = arm_instrs;
1395 // Sizes only grow (16→32-bit), so this converges quickly; cap for safety.
1396 for _ in 0..16 {
1397 // 1. Byte position of each instruction (Label encodes to 0 bytes).
1398 let mut positions = Vec::with_capacity(resolved.len());
1399 let mut pos: i64 = 0;
1400 for instr in &resolved {
1401 positions.push(pos);
1402 pos += encoder
1403 .encode(&instr.op)
1404 .map_err(|e| format!("branch-resolve size probe failed: {}", e))?
1405 .len() as i64;
1406 }
1407 // 2. Label name -> byte position (owned keys so the borrow ends here).
1408 let mut labels: HashMap<String, i64> = HashMap::new();
1409 for (i, instr) in resolved.iter().enumerate() {
1410 if let ArmOp::Label { name } = &instr.op {
1411 labels.insert(name.clone(), positions[i]);
1412 }
1413 }
1414 // 3. Rewrite each branch to its byte-accurate offset.
1415 let mut changed = false;
1416 for (idx, kind, label) in &branches {
1417 // A label not defined locally is an EXTERNAL target (e.g.
1418 // `Trap_Handler` resolved by a relocation / the vector table). Leave
1419 // such branches as their placeholder for the existing relocation
1420 // path — only local control-flow labels are byte-resolved here.
1421 let Some(&target) = labels.get(label) else {
1422 continue;
1423 };
1424 // Encoder consumes the field as (target - branch - 4) / 2 halfwords.
1425 // Positions are always even, so this division is exact.
1426 let halfword_offset = ((target - positions[*idx] - 4) / 2) as i32;
1427 let new_op = match kind {
1428 BKind::Cond(c) => ArmOp::BCondOffset {
1429 cond: *c,
1430 offset: halfword_offset,
1431 },
1432 BKind::Uncond => ArmOp::BOffset {
1433 offset: halfword_offset,
1434 },
1435 };
1436 if resolved[*idx].op != new_op {
1437 resolved[*idx].op = new_op;
1438 changed = true;
1439 }
1440 }
1441 if !changed {
1442 break;
1443 }
1444 }
1445 Ok(resolved)
1446}
1447
1448#[cfg(test)]
1449mod tests {
1450 use super::*;
1451
1452 /// #539: `i32.const 0; memory.grow m` folds to `memory.size m`; other deltas
1453 /// (const non-zero, runtime) are left as `memory.grow` (→ the sound fixed-
1454 /// memory -1). Non-grow ops are untouched, so functions without the idiom are
1455 /// byte-identical.
1456 #[test]
1457 fn test_rewrite_memory_grow_zero_539() {
1458 // the idiom -> memory.size
1459 assert_eq!(
1460 rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::MemoryGrow(0)]),
1461 vec![WasmOp::MemorySize(0)]
1462 );
1463 // const non-zero delta: NOT folded
1464 assert_eq!(
1465 rewrite_memory_grow_zero(&[WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]),
1466 vec![WasmOp::I32Const(2), WasmOp::MemoryGrow(0)]
1467 );
1468 // runtime delta (no preceding const): NOT folded
1469 assert_eq!(
1470 rewrite_memory_grow_zero(&[WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]),
1471 vec![WasmOp::LocalGet(0), WasmOp::MemoryGrow(0)]
1472 );
1473 // a bare const-0 not feeding a grow is untouched
1474 assert_eq!(
1475 rewrite_memory_grow_zero(&[WasmOp::I32Const(0), WasmOp::I32Add]),
1476 vec![WasmOp::I32Const(0), WasmOp::I32Add]
1477 );
1478 // fold is local: surrounding ops preserved, indices past the fold intact
1479 assert_eq!(
1480 rewrite_memory_grow_zero(&[
1481 WasmOp::LocalGet(0),
1482 WasmOp::I32Const(0),
1483 WasmOp::MemoryGrow(0),
1484 WasmOp::I32Add,
1485 ]),
1486 vec![WasmOp::LocalGet(0), WasmOp::MemorySize(0), WasmOp::I32Add]
1487 );
1488 }
1489
1490 #[test]
1491 fn test_arm_backend_name() {
1492 let backend = ArmBackend::new();
1493 assert_eq!(backend.name(), "arm");
1494 assert!(backend.is_available());
1495 }
1496
1497 #[test]
1498 fn test_arm_backend_capabilities() {
1499 let backend = ArmBackend::new();
1500 let caps = backend.capabilities();
1501 assert!(!caps.produces_elf);
1502 assert!(caps.supports_rule_verification);
1503 assert!(!caps.is_external);
1504 }
1505
1506 #[test]
1507 fn test_compile_add_function() {
1508 let backend = ArmBackend::new();
1509 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1510 let config = CompileConfig::default();
1511
1512 let result = backend.compile_function("add", &ops, &config);
1513 assert!(result.is_ok());
1514
1515 let func = result.unwrap();
1516 assert_eq!(func.name, "add");
1517 assert!(!func.code.is_empty());
1518 assert_eq!(func.wasm_ops, ops);
1519 }
1520
1521 /// VCR-DBG-001: the per-instruction source map must cover the function with
1522 /// monotonic, in-bounds machine offsets, and must not perturb the emitted
1523 /// code (it is captured at encode time, never serialized here).
1524 #[test]
1525 fn test_line_map_is_wellformed_dbg001() {
1526 let backend = ArmBackend::new();
1527 let ops = vec![
1528 WasmOp::LocalGet(0),
1529 WasmOp::LocalGet(1),
1530 WasmOp::I32Add,
1531 WasmOp::End,
1532 ];
1533 let config = CompileConfig::default();
1534 let func = backend.compile_function("add", &ops, &config).unwrap();
1535
1536 // Non-empty, and the first instruction starts at machine offset 0.
1537 assert!(
1538 !func.line_map.is_empty(),
1539 "a non-trivial function captures a source map"
1540 );
1541 assert_eq!(func.line_map[0].0, 0, "first instruction at offset 0");
1542
1543 // Offsets strictly increase by at least one ARM/Thumb instruction (>= 2
1544 // bytes) and every mapped offset lies inside the emitted `.text`.
1545 for w in func.line_map.windows(2) {
1546 assert!(w[1].0 > w[0].0, "instruction offsets strictly increase");
1547 assert!(
1548 w[1].0 - w[0].0 >= 2,
1549 "each ARM/Thumb instruction is >= 2 bytes"
1550 );
1551 }
1552 let last = func.line_map.last().unwrap().0 as usize;
1553 assert!(
1554 last < func.code.len(),
1555 "every mapped offset lies inside .text"
1556 );
1557
1558 // The side-table is additive: recompiling is deterministic and the map is
1559 // consistent with that exact code (capturing it does not alter output).
1560 let again = backend.compile_function("add", &ops, &config).unwrap();
1561 assert_eq!(
1562 again.code, func.code,
1563 "compilation deterministic; map is additive"
1564 );
1565 assert_eq!(again.line_map, func.line_map);
1566 }
1567
1568 #[test]
1569 fn test_count_params() {
1570 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1571 assert_eq!(count_params(&ops), 2);
1572
1573 let no_params = vec![WasmOp::I32Const(5), WasmOp::I32Const(3), WasmOp::I32Add];
1574 assert_eq!(count_params(&no_params), 0);
1575 }
1576
1577 /// #457: the declared param count caps the access-pattern inference. The
1578 /// repro shape `(param i32)(local i32) → p0 + local1` reads local 1 before
1579 /// any write, so `count_params` infers 2 — with the declared count (1) the
1580 /// local is reclassified onto the zero-inited frame path instead of being
1581 /// read from R1 (caller garbage).
1582 #[test]
1583 fn declared_param_count_caps_inference_457() {
1584 let ops = vec![
1585 WasmOp::LocalGet(0),
1586 WasmOp::LocalGet(1),
1587 WasmOp::I32Add,
1588 WasmOp::End,
1589 ];
1590 // The inference alone still says 2 (the misclassification this caps).
1591 assert_eq!(count_params(&ops), 2);
1592
1593 let backend = ArmBackend::new();
1594 let inferred = backend
1595 .compile_function("rbw", &ops, &CompileConfig::default())
1596 .unwrap();
1597 let declared = backend
1598 .compile_function(
1599 "rbw",
1600 &ops,
1601 &CompileConfig {
1602 current_func_param_count: Some(1),
1603 ..CompileConfig::default()
1604 },
1605 )
1606 .unwrap();
1607 // The cap is consumed: the declared-count compile reclassifies local 1
1608 // and must emit different code than the param-misclassified one.
1609 assert_ne!(
1610 inferred.code, declared.code,
1611 "declared param count must reach the selector"
1612 );
1613 // The zero-init is present: a 16-bit Thumb `movs rN, #0`
1614 // (0x2000 | rd<<8 → LE bytes [0x00, 0x20+rd]) somewhere in the body.
1615 let has_movs_zero = declared
1616 .code
1617 .chunks_exact(2)
1618 .any(|h| h[0] == 0x00 && (0x20..=0x27).contains(&h[1]));
1619 assert!(
1620 has_movs_zero,
1621 "declared-count compile must zero-init the read-before-write local; code: {:02x?}",
1622 declared.code
1623 );
1624 // A declared count that matches (or exceeds) the inference changes
1625 // nothing — byte-identity for every function without rbw locals.
1626 let matching = backend
1627 .compile_function(
1628 "rbw",
1629 &ops,
1630 &CompileConfig {
1631 current_func_param_count: Some(2),
1632 ..CompileConfig::default()
1633 },
1634 )
1635 .unwrap();
1636 assert_eq!(
1637 matching.code, inferred.code,
1638 "declared >= inferred must stay byte-identical"
1639 );
1640 }
1641
1642 #[test]
1643 fn test_arm_backend_register() {
1644 let mut registry = synth_core::BackendRegistry::new();
1645 registry.register(Box::new(ArmBackend::new()));
1646 assert!(registry.get("arm").is_some());
1647 assert_eq!(registry.available().len(), 1);
1648 }
1649
1650 #[test]
1651 fn test_compile_import_call_produces_relocations() {
1652 let backend = ArmBackend::new();
1653 // Simulate a WASM module where func index 0 is an import.
1654 // Call(0) should generate MOV R0, #0; BL __meld_dispatch_import
1655 let ops = vec![WasmOp::Call(0)];
1656 let config = CompileConfig {
1657 num_imports: 1,
1658 no_optimize: true, // Direct instruction selection to preserve Call semantics
1659 ..CompileConfig::default()
1660 };
1661
1662 let result = backend.compile_function("caller", &ops, &config);
1663 assert!(result.is_ok());
1664
1665 let func = result.unwrap();
1666 assert!(!func.code.is_empty());
1667 assert_eq!(func.relocations.len(), 1);
1668 assert_eq!(func.relocations[0].symbol, "__meld_dispatch_import");
1669 // The BL is the second instruction (after MOV R0, #0), so offset should be > 0
1670 assert!(func.relocations[0].offset > 0);
1671 }
1672
1673 /// Regression test for #197: in `relocatable` mode, an import call must
1674 /// relocate against the direct `func_N` symbol (rewritten to the wasm field
1675 /// name by `build_relocatable_elf`), NOT `__meld_dispatch_import`. This is
1676 /// the ABI half of the #197 fix — without it, a host linker cannot resolve
1677 /// the call to the real kernel symbol (e.g. `k_spin_lock`).
1678 #[test]
1679 fn test_compile_relocatable_import_uses_direct_func_symbol_197() {
1680 let backend = ArmBackend::new();
1681 let ops = vec![WasmOp::Call(0)]; // func 0 is an import
1682 let config = CompileConfig {
1683 num_imports: 1,
1684 relocatable: true,
1685 ..CompileConfig::default()
1686 };
1687
1688 let func = backend
1689 .compile_function("caller", &ops, &config)
1690 .expect("relocatable import call compiles");
1691
1692 assert_eq!(func.relocations.len(), 1);
1693 assert_eq!(
1694 func.relocations[0].symbol, "func_0",
1695 "#197: relocatable import must relocate against func_0 (→ field name), not Meld dispatch"
1696 );
1697 }
1698
1699 #[test]
1700 fn test_compile_no_imports_no_relocations() {
1701 let backend = ArmBackend::new();
1702 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1703 let config = CompileConfig::default();
1704
1705 let func = backend.compile_function("add", &ops, &config).unwrap();
1706 assert!(func.relocations.is_empty());
1707 }
1708
1709 /// Regression test for #167: a call to an INTERNAL function
1710 /// (index `>= num_imports`) must record a relocation against `func_{index}`.
1711 /// Before the fix, only `__meld_*` (import) BLs were relocated, so
1712 /// internal `BL func_N` was emitted as an unpatched `bl #0` branching
1713 /// to a garbage address — making the object non-linkable. This test
1714 /// would have caught that regression.
1715 #[test]
1716 fn test_compile_internal_call_produces_relocation_167() {
1717 let backend = ArmBackend::new();
1718 // num_imports = 1, so Call(2) is an INTERNAL call → `BL func_2`.
1719 let ops = vec![WasmOp::Call(2)];
1720 let config = CompileConfig {
1721 num_imports: 1,
1722 no_optimize: true,
1723 ..CompileConfig::default()
1724 };
1725
1726 let func = backend
1727 .compile_function("caller", &ops, &config)
1728 .expect("internal call compiles");
1729
1730 assert_eq!(
1731 func.relocations.len(),
1732 1,
1733 "an internal call must emit exactly one relocation (#167)"
1734 );
1735 assert_eq!(
1736 func.relocations[0].symbol, "func_2",
1737 "internal call must relocate against the callee's func_{{index}} symbol (#167)"
1738 );
1739 }
1740
1741 // ─── Phase 1 safety-bounds plumbing for ARM ──────────────────────────
1742
1743 #[test]
1744 fn arm_safety_bounds_mpu_emits_same_code_as_none() {
1745 // Mpu mode must not introduce any inline check on ARM — the MPU
1746 // handles faults via hardware. The encoded bytes for an i32.load
1747 // should be identical between None and Mpu.
1748 let backend = ArmBackend::new();
1749 let ops = vec![
1750 WasmOp::LocalGet(0),
1751 WasmOp::I32Load {
1752 offset: 0,
1753 align: 2,
1754 },
1755 ];
1756 let cfg_none = CompileConfig {
1757 no_optimize: true,
1758 ..Default::default()
1759 };
1760 let cfg_mpu = CompileConfig {
1761 no_optimize: true,
1762 safety_bounds: SafetyBounds::Mpu,
1763 ..Default::default()
1764 };
1765 let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1766 let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1767 assert_eq!(
1768 n.code, m.code,
1769 "Mpu and None should produce identical ARM bytes (Mpu relies on hardware)"
1770 );
1771 }
1772
1773 #[test]
1774 fn arm_legacy_bounds_check_still_emits_software_check() {
1775 // Legacy CLI users with `--bounds-check` should keep getting the
1776 // software path even though the new SafetyBounds field defaults to None.
1777 let backend = ArmBackend::new();
1778 let ops = vec![
1779 WasmOp::LocalGet(0),
1780 WasmOp::I32Load {
1781 offset: 0,
1782 align: 2,
1783 },
1784 ];
1785 let cfg_legacy = CompileConfig {
1786 no_optimize: true,
1787 bounds_check: true,
1788 ..Default::default()
1789 };
1790 let cfg_software = CompileConfig {
1791 no_optimize: true,
1792 safety_bounds: SafetyBounds::Software,
1793 ..Default::default()
1794 };
1795 let l = backend.compile_function("ld", &ops, &cfg_legacy).unwrap();
1796 let s = backend.compile_function("ld", &ops, &cfg_software).unwrap();
1797 assert_eq!(
1798 l.code, s.code,
1799 "--bounds-check should produce the same bytes as --safety-bounds=software"
1800 );
1801 }
1802
1803 /// #377: `--safety-bounds software` must be enforced on the OPTIMIZED path
1804 /// too. Pre-fix, `software` was byte-identical to `none` there (a silent
1805 /// no-op while the safety manifest claimed enforcement). The compiled
1806 /// bytes must now (a) differ from `none` and (b) contain the inline
1807 /// `CMP ip, sl` + `UDF` guard.
1808 #[test]
1809 fn arm_safety_bounds_software_enforced_on_optimized_path_377() {
1810 let backend = ArmBackend::new();
1811 // Dynamic-address store+load: the optimized path accepts this shape
1812 // (no calls, no i64 params, ≤4 params).
1813 let ops = vec![
1814 WasmOp::LocalGet(0),
1815 WasmOp::LocalGet(1),
1816 WasmOp::I32Store {
1817 offset: 4,
1818 align: 2,
1819 },
1820 WasmOp::LocalGet(0),
1821 WasmOp::I32Load {
1822 offset: 0,
1823 align: 2,
1824 },
1825 ];
1826 // no_optimize NOT set — this exercises the optimized path.
1827 let cfg_none = CompileConfig::default();
1828 let cfg_sw = CompileConfig {
1829 safety_bounds: SafetyBounds::Software,
1830 ..Default::default()
1831 };
1832 let n = backend.compile_function("st", &ops, &cfg_none).unwrap();
1833 let s = backend.compile_function("st", &ops, &cfg_sw).unwrap();
1834 assert_ne!(
1835 n.code, s.code,
1836 "#377: software bounds must CHANGE optimized-path codegen (was a silent no-op)"
1837 );
1838 // Thumb-2 `UDF #0` is 0xDE00 (LE bytes: 00 DE); `CMP ip, sl` (T2
1839 // high-reg) is 0x45D4 (LE: D4 45). Both must appear — one guard per
1840 // access, trap inline.
1841 let has_udf = s.code.windows(2).any(|w| w == [0x00, 0xDE]);
1842 let has_cmp_ip_sl = s.code.windows(2).any(|w| w == [0xD4, 0x45]);
1843 assert!(has_udf, "#377: inline UDF trap missing from optimized path");
1844 assert!(
1845 has_cmp_ip_sl,
1846 "#377: CMP ip, sl bounds compare missing from optimized path"
1847 );
1848 // And `none` must contain NO UDF (the function has no other trap).
1849 assert!(
1850 !n.code.windows(2).any(|w| w == [0x00, 0xDE]),
1851 "none must not contain a UDF for this function"
1852 );
1853 }
1854
1855 /// #377: `mpu` on the optimized path is codegen-passthrough — identical
1856 /// bytes to `none` on BOTH paths (hardware enforcement is target-level;
1857 /// synth does not emit MPU region programming — tracked separately in
1858 /// #377's fix-direction discussion). This pins path-parity for `mpu`.
1859 #[test]
1860 fn arm_safety_bounds_mpu_optimized_path_parity_377() {
1861 let backend = ArmBackend::new();
1862 let ops = vec![
1863 WasmOp::LocalGet(0),
1864 WasmOp::I32Load {
1865 offset: 0,
1866 align: 2,
1867 },
1868 ];
1869 let cfg_none = CompileConfig::default();
1870 let cfg_mpu = CompileConfig {
1871 safety_bounds: SafetyBounds::Mpu,
1872 ..Default::default()
1873 };
1874 let n = backend.compile_function("ld", &ops, &cfg_none).unwrap();
1875 let m = backend.compile_function("ld", &ops, &cfg_mpu).unwrap();
1876 assert_eq!(
1877 n.code, m.code,
1878 "Mpu and None must produce identical bytes on the optimized path too"
1879 );
1880 }
1881
1882 /// #377: `mask` on the optimized path declines to the direct selector
1883 /// (honest degradation) — the compiled function must equal the
1884 /// `--no-optimize` masking bytes, i.e. the flag is honored, never dropped.
1885 #[test]
1886 fn arm_safety_bounds_mask_optimized_path_declines_to_direct_377() {
1887 let backend = ArmBackend::new();
1888 let ops = vec![
1889 WasmOp::LocalGet(0),
1890 WasmOp::LocalGet(1),
1891 WasmOp::I32Store {
1892 offset: 0,
1893 align: 2,
1894 },
1895 ];
1896 let cfg_mask_opt = CompileConfig {
1897 safety_bounds: SafetyBounds::Mask,
1898 ..Default::default()
1899 };
1900 let cfg_mask_direct = CompileConfig {
1901 no_optimize: true,
1902 safety_bounds: SafetyBounds::Mask,
1903 ..Default::default()
1904 };
1905 let o = backend.compile_function("st", &ops, &cfg_mask_opt).unwrap();
1906 let d = backend
1907 .compile_function("st", &ops, &cfg_mask_direct)
1908 .unwrap();
1909 assert_eq!(
1910 o.code, d.code,
1911 "#377: mask on the optimized path must fall back to the direct selector's masking"
1912 );
1913 }
1914
1915 // ========================================================================
1916 // ISA feature gate tests — ensure the compiler never emits unsupported
1917 // instructions for a given target
1918 // ========================================================================
1919
1920 #[test]
1921 fn test_f32_rejected_on_cortex_m3_no_fpu() {
1922 let backend = ArmBackend::new();
1923 let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
1924 let config = CompileConfig {
1925 target: TargetSpec::cortex_m3(),
1926 no_optimize: true,
1927 ..CompileConfig::default()
1928 };
1929
1930 let result = backend.compile_function("fadd", &ops, &config);
1931 assert!(
1932 result.is_err(),
1933 "f32 operations should fail on Cortex-M3 (no FPU)"
1934 );
1935 }
1936
1937 #[test]
1938 fn test_f32_accepted_on_cortex_m4f() {
1939 let backend = ArmBackend::new();
1940 let ops = vec![WasmOp::F32Const(1.0), WasmOp::F32Const(2.0), WasmOp::F32Add];
1941 let config = CompileConfig {
1942 target: TargetSpec::cortex_m4f(),
1943 no_optimize: true,
1944 ..CompileConfig::default()
1945 };
1946
1947 let result = backend.compile_function("fadd", &ops, &config);
1948 assert!(
1949 result.is_ok(),
1950 "f32 operations should succeed on Cortex-M4F, got: {:?}",
1951 result.unwrap_err()
1952 );
1953 }
1954
1955 #[test]
1956 fn test_i32_works_on_all_targets() {
1957 let backend = ArmBackend::new();
1958 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::I32Add];
1959
1960 // Cortex-M3 (no FPU)
1961 let config_m3 = CompileConfig {
1962 target: TargetSpec::cortex_m3(),
1963 no_optimize: true,
1964 ..CompileConfig::default()
1965 };
1966 assert!(
1967 backend.compile_function("add", &ops, &config_m3).is_ok(),
1968 "i32 ops should work on Cortex-M3"
1969 );
1970
1971 // Cortex-M4F (single FPU)
1972 let config_m4f = CompileConfig {
1973 target: TargetSpec::cortex_m4f(),
1974 no_optimize: true,
1975 ..CompileConfig::default()
1976 };
1977 assert!(
1978 backend.compile_function("add", &ops, &config_m4f).is_ok(),
1979 "i32 ops should work on Cortex-M4F"
1980 );
1981
1982 // Cortex-M7DP (double FPU)
1983 let config_m7dp = CompileConfig {
1984 target: TargetSpec::cortex_m7dp(),
1985 no_optimize: true,
1986 ..CompileConfig::default()
1987 };
1988 assert!(
1989 backend.compile_function("add", &ops, &config_m7dp).is_ok(),
1990 "i32 ops should work on Cortex-M7DP"
1991 );
1992 }
1993
1994 #[test]
1995 fn test_f32_rejected_on_cortex_m4_no_fpu() {
1996 // Cortex-M4 (without F suffix) has no FPU
1997 let backend = ArmBackend::new();
1998 let ops = vec![WasmOp::F32Const(1.5), WasmOp::F32Const(2.5), WasmOp::F32Mul];
1999 let config = CompileConfig {
2000 target: TargetSpec::cortex_m4(),
2001 no_optimize: true,
2002 ..CompileConfig::default()
2003 };
2004
2005 let result = backend.compile_function("fmul", &ops, &config);
2006 assert!(
2007 result.is_err(),
2008 "f32 operations should fail on Cortex-M4 (no FPU)"
2009 );
2010 }
2011
2012 // ========================================================================
2013 // Issue #120 — f32 ops in the optimized lowering path
2014 //
2015 // `OptimizerBridge::wasm_to_ir` has no handlers for f32/f64 ops, so a
2016 // value-producing float op fell through to `Opcode::Nop`, leaving a
2017 // downstream consumer with an unmapped vreg and tripping the PR #101
2018 // defensive panic in `ir_to_arm`. Customer reproducer: `compiler_builtins
2019 // float::div` and `gale_compute_ipi_mask` in the `falcon-rate-component`
2020 // module.
2021 //
2022 // Fix: `optimize_full` declines float modules with a typed `Err`;
2023 // `compile_wasm_to_arm` falls back to the non-optimized `select_with_stack`
2024 // path, which handles f32 via VFP/FPU. These tests use the *default*
2025 // (optimized) config — `no_optimize` is NOT set — which is the exact
2026 // configuration that panicked pre-fix.
2027 // ========================================================================
2028
2029 /// Pre-fix: this panicked with "vreg vN has no assigned ARM register and
2030 /// no spill slot" inside `ir_to_arm`. Post-fix: the optimized path declines
2031 /// the module and the backend falls back to direct selection, producing a
2032 /// non-empty f32.div lowering on a Cortex-M4F.
2033 #[test]
2034 fn test_issue120_f32_div_compiles_via_optimized_default() {
2035 let backend = ArmBackend::new();
2036 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2037 let config = CompileConfig {
2038 target: TargetSpec::cortex_m4f(),
2039 // no_optimize NOT set — this exercises the optimized path that
2040 // panicked in issue #120, then the fallback to direct selection.
2041 // GI-FPU-002: the f32 params must be declared so the direct
2042 // selector homes them in S0/S1 (AAPCS-VFP) rather than declining.
2043 current_func_params_f32: vec![true, true],
2044 ..CompileConfig::default()
2045 };
2046
2047 let result = backend.compile_function("fdiv", &ops, &config);
2048 assert!(
2049 result.is_ok(),
2050 "f32.div must compile on Cortex-M4F via the optimized->direct \
2051 fallback (issue #120), got: {:?}",
2052 result.as_ref().err()
2053 );
2054 assert!(
2055 !result.unwrap().code.is_empty(),
2056 "f32.div must produce non-empty machine code"
2057 );
2058 }
2059
2060 /// A spread of f32 ops, all through the optimized (default) config, must
2061 /// compile via the fallback on an FPU target without panicking.
2062 #[test]
2063 fn test_issue120_assorted_f32_ops_compile_via_optimized_default() {
2064 let backend = ArmBackend::new();
2065 let config = CompileConfig {
2066 target: TargetSpec::cortex_m4f(),
2067 // GI-FPU-002: declare the two f32 params for AAPCS-VFP homing.
2068 current_func_params_f32: vec![true, true],
2069 ..CompileConfig::default()
2070 };
2071
2072 let cases: Vec<(&str, Vec<WasmOp>)> = vec![
2073 (
2074 "fadd",
2075 vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Add],
2076 ),
2077 (
2078 "fmul",
2079 vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Mul],
2080 ),
2081 (
2082 "fsub",
2083 vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Sub],
2084 ),
2085 ];
2086
2087 for (name, ops) in cases {
2088 let result = backend.compile_function(name, &ops, &config);
2089 assert!(
2090 result.is_ok(),
2091 "{name} must compile via the optimized->direct fallback \
2092 (issue #120), got: {:?}",
2093 result.as_ref().err()
2094 );
2095 assert!(
2096 !result.unwrap().code.is_empty(),
2097 "{name} must produce non-empty machine code"
2098 );
2099 }
2100 }
2101
2102 /// The fallback must still honor the ISA feature gate: f32 on a no-FPU
2103 /// target must fail cleanly (not panic) even on the optimized path.
2104 #[test]
2105 fn test_issue120_f32_div_rejected_on_no_fpu_via_optimized() {
2106 let backend = ArmBackend::new();
2107 let ops = vec![WasmOp::LocalGet(0), WasmOp::LocalGet(1), WasmOp::F32Div];
2108 let config = CompileConfig {
2109 target: TargetSpec::cortex_m3(),
2110 ..CompileConfig::default()
2111 };
2112
2113 let result = backend.compile_function("fdiv", &ops, &config);
2114 assert!(
2115 result.is_err(),
2116 "f32.div must be rejected on Cortex-M3 (no FPU), not panic"
2117 );
2118 }
2119
2120 /// #507: a `br_table` function compiled via the DEFAULT (optimized) config
2121 /// must produce the SAME bytes as the direct (`no_optimize`) selector —
2122 /// i.e. the optimized path declined it to direct, lowering the dispatch as a
2123 /// real cmp-chain instead of silently dropping it (which left all arms in
2124 /// fall-through). Pre-fix the two outputs differed (the optimized one had no
2125 /// selector compare). Execution correctness is gated by
2126 /// `scripts/repro/br_table_507_differential.py`.
2127 #[test]
2128 fn test_507_br_table_declines_to_direct() {
2129 let backend = ArmBackend::new();
2130 // dispatch(sel): br_table over 3 blocks, each storing a marker to mem[0].
2131 let ops = vec![
2132 WasmOp::Block,
2133 WasmOp::Block,
2134 WasmOp::Block,
2135 WasmOp::LocalGet(0),
2136 WasmOp::BrTable {
2137 targets: vec![0, 1, 2],
2138 default: 2,
2139 },
2140 WasmOp::End,
2141 WasmOp::I32Const(0),
2142 WasmOp::I32Const(10),
2143 WasmOp::I32Store {
2144 offset: 0,
2145 align: 2,
2146 },
2147 WasmOp::Return,
2148 WasmOp::End,
2149 WasmOp::I32Const(0),
2150 WasmOp::I32Const(20),
2151 WasmOp::I32Store {
2152 offset: 0,
2153 align: 2,
2154 },
2155 WasmOp::Return,
2156 WasmOp::End,
2157 WasmOp::I32Const(0),
2158 WasmOp::I32Const(30),
2159 WasmOp::I32Store {
2160 offset: 0,
2161 align: 2,
2162 },
2163 ];
2164 let opt = CompileConfig {
2165 target: TargetSpec::cortex_m4(),
2166 ..CompileConfig::default()
2167 };
2168 let direct = CompileConfig {
2169 target: TargetSpec::cortex_m4(),
2170 no_optimize: true,
2171 ..CompileConfig::default()
2172 };
2173 let a = backend
2174 .compile_function("dispatch", &ops, &opt)
2175 .expect("optimized-default must compile br_table (via decline)");
2176 let b = backend
2177 .compile_function("dispatch", &ops, &direct)
2178 .expect("direct must compile br_table");
2179 assert_eq!(
2180 a.code, b.code,
2181 "#507: optimized-default br_table output must be byte-identical to the \
2182 direct selector (i.e. declined to direct), not a dropped dispatch"
2183 );
2184 }
2185
2186 /// Issue #94: end-to-end byte-size check for the canonical u64-packed
2187 /// FFI-return hi32 extract pattern. Compiles two near-identical
2188 /// functions — one with the optimized shift-by-32, one with a generic
2189 /// shift-by-7 — and asserts the optimized form is meaningfully smaller.
2190 #[test]
2191 fn test_issue94_hi32_extract_is_smaller_than_generic_shift() {
2192 let backend = ArmBackend::new();
2193 let config = CompileConfig {
2194 target: TargetSpec::cortex_m4f(),
2195 ..CompileConfig::default()
2196 };
2197
2198 // #518: the i64 value must NOT come from an i64 PARAM — the optimized
2199 // path now declines i64-param functions to the direct selector (it homed
2200 // an i64 param in R4:R5 instead of R0:R1, a silent miscompile this test's
2201 // byte-size-only assertion masked). The canonical #94 case is a u64 from
2202 // an FFI return, not a param, anyway. Source the i64 from a sign-extended
2203 // i32 param (`extend_i32_s`): a runtime, non-constant-foldable i64 that
2204 // stays on the optimized path, so the shift-by-32 hi-extract peephole is
2205 // still exercised on CORRECT code.
2206 // Optimized path: `(i64.extend_i32_s (local.get 0)) >>> 32; wrap_i64`
2207 let ops_hi32 = vec![
2208 WasmOp::LocalGet(0), // i32 param in R0
2209 WasmOp::I64ExtendI32S,
2210 WasmOp::I64Const(32),
2211 WasmOp::I64ShrU,
2212 WasmOp::I32WrapI64,
2213 ];
2214 let func_hi32 = backend
2215 .compile_function("hi32_extract", &ops_hi32, &config)
2216 .unwrap();
2217
2218 // Generic path: `... >>> 7; wrap_i64` — same shape, but the shift amount
2219 // is not a multiple of 32, so it falls through to the runtime shift.
2220 let ops_generic = vec![
2221 WasmOp::LocalGet(0),
2222 WasmOp::I64ExtendI32S,
2223 WasmOp::I64Const(7),
2224 WasmOp::I64ShrU,
2225 WasmOp::I32WrapI64,
2226 ];
2227 let func_generic = backend
2228 .compile_function("generic_shr", &ops_generic, &config)
2229 .unwrap();
2230
2231 let bytes_hi32 = func_hi32.code.len();
2232 let bytes_generic = func_generic.code.len();
2233 println!(
2234 "\n[issue #94] hi32 extract: {} bytes (vs generic shift: {} bytes; saved {})",
2235 bytes_hi32,
2236 bytes_generic,
2237 bytes_generic.saturating_sub(bytes_hi32)
2238 );
2239 let hex: String = func_hi32
2240 .code
2241 .iter()
2242 .map(|b| format!("{:02x}", b))
2243 .collect::<Vec<_>>()
2244 .join(" ");
2245 println!("[issue #94] hi32 bytes: {}", hex);
2246 // We expect the optimized form to be at least 30 bytes smaller than
2247 // the generic 64-bit shift sequence. (Empirically: 14 vs 50 bytes.)
2248 assert!(
2249 bytes_hi32 + 30 <= bytes_generic,
2250 "issue #94: hi32 extract = {} bytes, generic shift = {} bytes; \
2251 expected optimized form to be at least 30 bytes smaller",
2252 bytes_hi32,
2253 bytes_generic,
2254 );
2255 }
2256}