syncable-cli 0.37.1

A Rust-based CLI that analyzes code repositories and generates Infrastructure as Code configurations
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68

//! DL3015: Avoid additional packages by specifying --no-install-recommends
//!
//! apt-get install should use --no-install-recommends to avoid
//! installing unnecessary packages.

use crate::analyzer::hadolint::parser::instruction::Instruction;
use crate::analyzer::hadolint::rules::{SimpleRule, simple_rule};
use crate::analyzer::hadolint::shell::ParsedShell;
use crate::analyzer::hadolint::types::Severity;

pub fn rule() -> SimpleRule<impl Fn(&Instruction, Option<&ParsedShell>) -> bool + Send + Sync> {
    simple_rule(
        "DL3015",
        Severity::Info,
        "Avoid additional packages by specifying `--no-install-recommends`.",
        |instr, shell| {
            match instr {
                Instruction::Run(_) => {
                    if let Some(shell) = shell {
                        // Check all apt-get install commands
                        !shell.any_command(|cmd| {
                            if cmd.name == "apt-get" && cmd.has_any_arg(&["install"]) {
                                // Must have --no-install-recommends
                                !cmd.has_any_flag(&["no-install-recommends"])
                            } else {
                                false
                            }
                        })
                    } else {
                        true
                    }
                }
                _ => true,
            }
        },
    )
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::analyzer::hadolint::config::HadolintConfig;
    use crate::analyzer::hadolint::lint::{LintResult, lint};

    fn lint_dockerfile(content: &str) -> LintResult {
        lint(content, &HadolintConfig::default())
    }

    #[test]
    fn test_apt_get_without_no_install_recommends() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nRUN apt-get install -y nginx");
        assert!(result.failures.iter().any(|f| f.code.as_str() == "DL3015"));
    }

    #[test]
    fn test_apt_get_with_no_install_recommends() {
        let result = lint_dockerfile(
            "FROM ubuntu:20.04\nRUN apt-get install -y --no-install-recommends nginx",
        );
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL3015"));
    }

    #[test]
    fn test_apt_get_update_no_flag_needed() {
        let result = lint_dockerfile("FROM ubuntu:20.04\nRUN apt-get update");
        assert!(!result.failures.iter().any(|f| f.code.as_str() == "DL3015"));
    }
}