synapse-waf 0.9.1

High-performance WAF and reverse proxy with embedded intelligence — built on Cloudflare Pingora
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
//! Remote shell handler for the tunnel client.

use base64::engine::general_purpose::STANDARD;
use base64::Engine;
use dashmap::DashMap;
use portable_pty::{native_pty_system, CommandBuilder, PtySize};
use std::io::{Read, Write};
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};
use tokio::sync::broadcast;
use tracing::{debug, warn};

use super::client::TunnelClientHandle;
use super::types::LegacyTunnelMessage;
use crate::metrics::MetricsRegistry;

const DEFAULT_COLS: u16 = 80;
const DEFAULT_ROWS: u16 = 24;

/// Dangerous terminal escape sequence prefixes that can be used for terminal injection attacks.
/// These allow arbitrary command injection, clipboard access, or window manipulation.
const DANGEROUS_ESCAPE_PREFIXES: &[&[u8]] = &[
    b"\x1b]", // OSC - Operating System Command (clipboard, window title injection)
    b"\x1bP", // DCS - Device Control String (Sixel, ReGIS, DECRQSS attacks)
    b"\x1b_", // APC - Application Program Command
    b"\x1b^", // PM - Privacy Message
    b"\x1bX", // SOS - Start of String
];

/// Filter dangerous terminal escape sequences from input data.
/// Allows normal CSI sequences (ESC [) for cursor control and colors,
/// but blocks OSC, DCS, APC, PM, and SOS sequences that can be exploited.
fn filter_dangerous_escapes(input: &[u8]) -> Vec<u8> {
    let mut output = Vec::with_capacity(input.len());
    let mut i = 0;

    while i < input.len() {
        // Check for ESC character
        if input[i] == 0x1b && i + 1 < input.len() {
            let next_byte = input[i + 1];

            // Check if this is a dangerous escape sequence
            let is_dangerous = DANGEROUS_ESCAPE_PREFIXES
                .iter()
                .any(|prefix| input[i..].starts_with(prefix));

            if is_dangerous {
                // Skip the dangerous escape sequence
                // Find the sequence terminator (ST = ESC \ or BEL, or end of input)
                let mut j = i + 2;
                while j < input.len() {
                    // String Terminator: ESC \
                    if j + 1 < input.len() && input[j] == 0x1b && input[j + 1] == b'\\' {
                        j += 2;
                        break;
                    }
                    // BEL (often used to terminate OSC)
                    if input[j] == 0x07 {
                        j += 1;
                        break;
                    }
                    j += 1;
                }
                i = j;
                continue;
            } else if next_byte == b'[' {
                // CSI sequence - allowed (cursor control, colors, etc.)
                output.push(input[i]);
                i += 1;
                continue;
            }
        }

        // Normal byte or safe escape - pass through
        output.push(input[i]);
        i += 1;
    }

    output
}

struct ShellSession {
    writer: Arc<Mutex<Box<dyn Write + Send>>>,
    master: Arc<Mutex<Box<dyn portable_pty::MasterPty + Send>>>,
    child: Arc<Mutex<Box<dyn portable_pty::Child + Send>>>,
    shell: String,
}

/// Remote shell handler for tunnel legacy messages.
pub struct TunnelShellService {
    handle: TunnelClientHandle,
    sessions: Arc<DashMap<String, ShellSession>>,
    default_shell: String,
    enabled: bool,
    metrics: Arc<MetricsRegistry>,
}

impl TunnelShellService {
    /// Create a new shell service with the given tunnel handle.
    pub fn new(handle: TunnelClientHandle, enabled: bool, metrics: Arc<MetricsRegistry>) -> Self {
        let default_shell = std::env::var("SHELL").unwrap_or_else(|_| "/bin/bash".to_string());
        Self {
            handle,
            sessions: Arc::new(DashMap::new()),
            default_shell,
            enabled,
            metrics,
        }
    }

    /// Start the shell service (listens for legacy tunnel messages).
    pub async fn run(self, mut shutdown_rx: broadcast::Receiver<()>) {
        if !self.enabled {
            warn!("Remote shell service is disabled by configuration");
            return;
        }

        let mut rx = self.handle.subscribe_legacy();
        loop {
            tokio::select! {
                message = rx.recv() => {
                    match message {
                        Ok(message) => {
                            let started = Instant::now();
                            self.handle_message(message).await;
                            self.metrics
                                .tunnel_metrics()
                                .record_handler_latency_ms(
                                    super::types::TunnelChannel::Shell,
                                    started.elapsed().as_millis() as u64,
                                );
                        }
                        Err(broadcast::error::RecvError::Lagged(count)) => {
                            warn!("Shell service lagged by {} messages", count);
                            continue;
                        }
                        Err(broadcast::error::RecvError::Closed) => {
                            warn!("Shell service channel closed");
                            break;
                        }
                    }
                }
                _ = shutdown_rx.recv() => {
                    debug!("Shell service shutdown signal received");
                    break;
                }
            }
        }

        // Cleanup all active sessions
        let session_ids: Vec<String> = self.sessions.iter().map(|e| e.key().clone()).collect();
        for id in session_ids {
            self.end_session(&id, "service shutdown");
        }
    }

    async fn handle_message(&self, message: LegacyTunnelMessage) {
        if !self.enabled {
            if let Some(session_id) = message.session_id {
                self.send_shell_error(&session_id, "remote shell is disabled on this sensor");
            }
            return;
        }

        match message.message_type.as_str() {
            "shell-data" => {
                self.handle_shell_data(message).await;
            }
            "shell-resize" => {
                self.handle_shell_resize(message).await;
            }
            _ => {}
        }
    }

    async fn handle_shell_data(&self, message: LegacyTunnelMessage) {
        let Some(session_id) = message.session_id.clone() else {
            warn!("shell-data received without sessionId");
            return;
        };

        let payload = message.payload;

        if let Some(action) = payload.get("action").and_then(|value| value.as_str()) {
            match action {
                "start" => {
                    let cols = payload
                        .get("cols")
                        .and_then(|value| value.as_u64())
                        .map(|value| value as u16)
                        .unwrap_or(DEFAULT_COLS);
                    let rows = payload
                        .get("rows")
                        .and_then(|value| value.as_u64())
                        .map(|value| value as u16)
                        .unwrap_or(DEFAULT_ROWS);
                    if let Err(err) = self.start_session(&session_id, cols, rows) {
                        self.send_shell_error(&session_id, err);
                    }
                    return;
                }
                "end" => {
                    self.end_session(&session_id, "session ended");
                    return;
                }
                _ => {}
            }
        }

        if let Some(data) = payload.get("data").and_then(|value| value.as_str()) {
            if let Err(err) = self.write_input(&session_id, data) {
                self.send_shell_error(&session_id, err);
            }
        }
    }

    async fn handle_shell_resize(&self, message: LegacyTunnelMessage) {
        let Some(session_id) = message.session_id.clone() else {
            warn!("shell-resize received without sessionId");
            return;
        };
        let cols = message
            .payload
            .get("cols")
            .and_then(|value| value.as_u64())
            .map(|value| value as u16)
            .unwrap_or(DEFAULT_COLS);
        let rows = message
            .payload
            .get("rows")
            .and_then(|value| value.as_u64())
            .map(|value| value as u16)
            .unwrap_or(DEFAULT_ROWS);

        if let Some(session) = self.sessions.get(&session_id) {
            if let Err(err) = session
                .master
                .lock()
                .unwrap_or_else(|p| p.into_inner())
                .resize(PtySize {
                    rows,
                    cols,
                    pixel_width: 0,
                    pixel_height: 0,
                })
            {
                self.send_shell_error(&session_id, format!("resize failed: {}", err));
            }
        } else {
            warn!("shell-resize for unknown session {}", session_id);
        }
    }

    fn start_session(&self, session_id: &str, cols: u16, rows: u16) -> Result<(), String> {
        if self.sessions.contains_key(session_id) {
            return Err("shell session already active".to_string());
        }

        let pty_system = native_pty_system();
        let pair = pty_system
            .openpty(PtySize {
                rows,
                cols,
                pixel_width: 0,
                pixel_height: 0,
            })
            .map_err(|err| format!("failed to open pty: {}", err))?;

        let shell = self.default_shell.clone();
        let mut cmd = CommandBuilder::new(&shell);
        cmd.env("TERM", "xterm-256color");
        let child = pair
            .slave
            .spawn_command(cmd)
            .map_err(|err| format!("failed to spawn shell: {}", err))?;

        let reader = pair
            .master
            .try_clone_reader()
            .map_err(|err| format!("failed to clone pty reader: {}", err))?;
        let writer = pair
            .master
            .take_writer()
            .map_err(|err| format!("failed to get pty writer: {}", err))?;

        let session = ShellSession {
            writer: Arc::new(Mutex::new(writer)),
            master: Arc::new(Mutex::new(pair.master)),
            child: Arc::new(Mutex::new(child)),
            shell: shell.clone(),
        };

        self.sessions.insert(session_id.to_string(), session);
        self.send_shell_ready(session_id, &shell);

        self.spawn_reader(session_id.to_string(), reader);
        self.spawn_waiter(session_id.to_string());

        Ok(())
    }

    fn spawn_reader(&self, session_id: String, mut reader: Box<dyn Read + Send>) {
        let handle = self.handle.clone();
        let sessions = Arc::clone(&self.sessions);

        tokio::task::spawn_blocking(move || {
            let mut buffer = [0u8; 8192];
            loop {
                // Check if session still exists
                if !sessions.contains_key(&session_id) {
                    break;
                }

                match reader.read(&mut buffer) {
                    Ok(0) => {
                        debug!("shell output closed for {}", session_id);
                        break;
                    }
                    Ok(bytes_read) => {
                        let encoded = STANDARD.encode(&buffer[..bytes_read]);
                        let message = serde_json::json!({
                            "type": "shell-data",
                            "sessionId": session_id,
                            "payload": { "data": encoded },
                            "timestamp": chrono::Utc::now().to_rfc3339(),
                        });
                        // Use sync send for backpressure against PTY reader
                        let _ = handle.send_json_sync(message);
                    }
                    Err(err) => {
                        // Avoid logging error if it's just the session closing
                        if sessions.contains_key(&session_id) {
                            let message = serde_json::json!({
                                "type": "shell-error",
                                "sessionId": session_id,
                                "payload": { "error": format!("shell output error: {}", err) },
                                "timestamp": chrono::Utc::now().to_rfc3339(),
                            });
                            let _ = handle.send_json_sync(message);
                        }
                        break;
                    }
                }
            }
        });
    }

    fn spawn_waiter(&self, session_id: String) {
        let sessions = Arc::clone(&self.sessions);
        let handle = self.handle.clone();

        tokio::task::spawn(async move {
            loop {
                let status = {
                    if let Some(entry) = sessions.get(&session_id) {
                        let mut child = entry.child.lock().unwrap_or_else(|p| p.into_inner());
                        match child.try_wait() {
                            Ok(Some(status)) => Some(Ok(status)),
                            Ok(None) => None,
                            Err(err) => Some(Err(err)),
                        }
                    } else {
                        break;
                    }
                };

                match status {
                    Some(Ok(status)) => {
                        let exit_code = status.exit_code();
                        let message = serde_json::json!({
                            "type": "shell-exit",
                            "sessionId": session_id,
                            "payload": { "code": exit_code },
                            "timestamp": chrono::Utc::now().to_rfc3339(),
                        });
                        let _ = handle.send_json(message).await;
                        sessions.remove(&session_id);
                        break;
                    }
                    Some(Err(err)) => {
                        let message = serde_json::json!({
                            "type": "shell-error",
                            "sessionId": session_id,
                            "payload": { "error": format!("shell wait error: {}", err) },
                            "timestamp": chrono::Utc::now().to_rfc3339(),
                        });
                        let _ = handle.send_json(message).await;
                        sessions.remove(&session_id);
                        break;
                    }
                    None => {
                        // Still running, wait a bit
                        tokio::time::sleep(Duration::from_millis(250)).await;
                    }
                }
            }
        });
    }

    fn write_input(&self, session_id: &str, data: &str) -> Result<(), String> {
        let decoded = STANDARD
            .decode(data.as_bytes())
            .map_err(|err| format!("invalid base64 input: {}", err))?;

        // Filter dangerous terminal escape sequences before writing to PTY
        let sanitized = filter_dangerous_escapes(&decoded);

        if let Some(session) = self.sessions.get(session_id) {
            let mut writer = session.writer.lock().unwrap_or_else(|p| p.into_inner());
            writer
                .write_all(&sanitized)
                .map_err(|err| format!("failed to write to pty: {}", err))?;
            writer
                .flush()
                .map_err(|err| format!("failed to flush pty: {}", err))?;
            Ok(())
        } else {
            Err("shell session not found".to_string())
        }
    }

    fn end_session(&self, session_id: &str, reason: &str) {
        if let Some((_, session)) = self.sessions.remove(session_id) {
            let mut child = session.child.lock().unwrap_or_else(|p| p.into_inner());
            if let Err(err) = child.kill() {
                warn!("Failed to kill shell session {}: {}", session_id, err);
            }
        }

        let message = serde_json::json!({
            "type": "shell-exit",
            "sessionId": session_id,
            "payload": { "code": 0, "reason": reason },
            "timestamp": chrono::Utc::now().to_rfc3339(),
        });
        let _ = self.handle.send_json_blocking(message);
    }

    fn send_shell_ready(&self, session_id: &str, shell: &str) {
        let message = serde_json::json!({
            "type": "shell-ready",
            "sessionId": session_id,
            "payload": { "shell": shell },
            "timestamp": chrono::Utc::now().to_rfc3339(),
        });
        let _ = self.handle.send_json_blocking(message);
    }

    fn send_shell_error(&self, session_id: &str, error_message: impl Into<String>) {
        let message = serde_json::json!({
            "type": "shell-error",
            "sessionId": session_id,
            "payload": { "error": error_message.into() },
            "timestamp": chrono::Utc::now().to_rfc3339(),
        });
        let _ = self.handle.send_json_blocking(message);
    }
}