# Codebase Audit Report
**Generated:** 2026-02-10T19:00:37Z
**Project:** synapse-pingora
## Clippy Analysis
| Warnings | 3 |
| Errors | 0
0 |
<details>
<summary>Clippy Output (click to expand)</summary>
```
src/metrics.rs:8:39: warning: unused import: `CrawlerStatsSnapshot`
src/tui.rs:27:22: warning: unused import: `MetricsRegistry`
src/headers.rs:32:5: warning: type `headers::CompiledHeaderValue` is more private than the item `headers::CompiledHeaderOps::add`: field `headers::CompiledHeaderOps::add` is reachable at visibility `pub(crate)`
src/headers.rs:33:5: warning: type `headers::CompiledHeaderValue` is more private than the item `headers::CompiledHeaderOps::set`: field `headers::CompiledHeaderOps::set` is reachable at visibility `pub(crate)`
src/rules.rs:228:4: warning: function `value_to_match_value` is never used
src/intelligence/signal_manager.rs:126:5: warning: field `end_timestamp_ms` is never read
src/tarpit/manager.rs:75:8: warning: methods `remove` and `clear` are never used
src/tunnel/shell.rs:86:5: warning: field `shell` is never read
src/tui.rs:46:5: warning: fields `block_log` and `start_time` are never read
src/rules.rs:543:9: warning: field assignment outside of initializer for an instance created with Default::default()
src/config_manager.rs:1041:22: warning: redundant closure: help: replace the closure with the tuple variant itself: `ConfigManagerError::Persistence`
src/site_waf.rs:77:1: warning: this `impl` can be derived
src/tls.rs:44:5: warning: struct `SecureString` has a public `len` method, but no `is_empty` method
src/tls.rs:138:5: warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str`
src/utils/circuit_breaker.rs:79:9: warning: this `if` statement can be collapsed
src/utils/path_normalizer.rs:47:38: warning: this `if` has identical blocks
src/utils/path_normalizer.rs:49:49: warning: this `if` has identical blocks
src/utils/path_normalizer.rs:51:51: warning: this `if` has identical blocks
src/admin_server.rs:766:6: warning: the `Err`-variant returned from this function is very large: the `Err`-variant is at least 128 bytes
src/admin_server.rs:867:24: warning: unnecessary closure used to substitute value for `Option::None`
src/admin_server.rs:1632:22: warning: this can be `std::io::Error::other(_)`
src/admin_server.rs:1843:41: warning: this pattern creates a reference to a reference: help: try: `config_mgr`
src/admin_server.rs:1884:9: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
src/admin_server.rs:1883:17: warning: this pattern creates a reference to a reference: help: try: `config_mgr`
src/admin_server.rs:1914:17: warning: this pattern creates a reference to a reference: help: try: `config_mgr`
src/api.rs:702:17: warning: field assignment outside of initializer for an instance created with Default::default()
src/api.rs:799:28: warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
src/metrics.rs:872:9: warning: clamp-like pattern without using clamp function: help: replace with clamp: `pct = pct.clamp(0.0, 1.0);`
src/dlp/scanner.rs:113:1: warning: this `impl` can be derived
src/dlp/scanner.rs:164:1: warning: this `impl` can be derived
src/dlp/scanner.rs:404:5: warning: manual `RangeInclusive::contains` implementation: help: use: `(13..=19).contains(&digit_count)`
src/dlp/scanner.rs:404:62: warning: manual implementation of `.is_multiple_of()`: help: replace with: `sum.is_multiple_of(10)`
src/dlp/scanner.rs:630:8: warning: manual `!RangeInclusive::contains` implementation: help: use: `!(15..=34).contains(&total_len)`
src/dlp/scanner.rs:638:12: warning: taken reference of right operand
src/dlp/scanner.rs:923:59: warning: the borrowed expression implements the required traits
src/entity/store.rs:919:12: warning: manual implementation of `.is_multiple_of()`: help: replace with: `!count.is_multiple_of(100)`
src/fingerprint/ja4.rs:243:8: warning: manual `!RangeInclusive::contains` implementation: help: use: `!(10..=13).contains(&tls_version)`
src/sni_validation.rs:218:33: warning: redundant closure: help: replace the closure with the function itself: `normalize_hostname`
src/sni_validation.rs:219:42: warning: redundant closure: help: replace the closure with the function itself: `normalize_hostname`
src/validation.rs:363:20: warning: this `if` statement can be collapsed
src/validation.rs:704:8: warning: manual `!RangeInclusive::contains` implementation: help: use: `!(0.0..=100.0).contains(&threshold)`
src/persistence/mod.rs:135:16: warning: this `map_or` can be simplified
src/telemetry/auth_coverage_aggregator.rs:55:64: warning: this `if` has identical blocks
src/telemetry/mod.rs:248:16: warning: manual implementation of `.is_multiple_of()`: help: replace with: `dropped.is_multiple_of(100)`
src/telemetry/mod.rs:267:5: warning: struct `TelemetryBuffer` has a public `len` method, but no `is_empty` method
src/correlation/campaign_state.rs:117:1: warning: this `impl` can be derived
src/correlation/campaign_state.rs:626:13: warning: this `if` statement can be collapsed
src/correlation/campaign_state.rs:627:20: warning: this `map_or` can be simplified
src/correlation/detectors/network_proximity.rs:153:28: warning: used consecutive `str::replace` call: help: replace with: `replace(['/', '.'], "-")`
src/actor/manager.rs:365:31: warning: very complex type used. Consider factoring parts into `type` definitions
src/actor/manager.rs:843:12: warning: manual implementation of `.is_multiple_of()`: help: replace with: `!count.is_multiple_of(100)`
src/session/manager.rs:889:12: warning: manual implementation of `.is_multiple_of()`: help: replace with: `!count.is_multiple_of(100)`
src/interrogator/js_challenge_manager.rs:557:20: warning: manually reimplementing `div_ceil`: help: consider using `.div_ceil()`: `len.div_ceil(2)`
src/shadow/rate_limiter.rs:72:12: warning: manual implementation of `.is_multiple_of()`: help: replace with: `ops.is_multiple_of(CAPACITY_CHECK_INTERVAL)`
src/shadow/mod.rs:171:9: warning: this `if` statement can be collapsed
src/profiler/endpoint_profile.rs:56:5: warning: you should consider adding a `Default` implementation for `ParamStats`
src/profiler/patterns.rs:155:12: warning: manual `RangeInclusive::contains` implementation: help: use: `(13..=19).contains(&len)`
src/profiler/patterns.rs:161:8: warning: manual `RangeInclusive::contains` implementation: help: use: `(7..=20).contains(&len)`
src/profiler/patterns.rs:163:9: warning: this `if` statement can be collapsed
src/profiler/profile_store.rs:243:20: warning: length comparison to one: help: using `!is_empty` is clearer and more explicit: `!segment.is_empty()`
src/profiler/mod.rs:451:21: warning: this `if` statement can be collapsed
src/crawler/detector.rs:236:25: warning: very complex type used. Consider factoring parts into `type` definitions
src/crawler/detector.rs:238:25: warning: very complex type used. Consider factoring parts into `type` definitions
src/crawler/detector.rs:300:9: warning: field assignment outside of initializer for an instance created with Default::default()
src/crawler/detector.rs:421:72: warning: this `if` has identical blocks
src/horizon/client.rs:398:1: warning: this function has too many arguments (11/7)
src/horizon/client.rs:630:1: warning: this function has too many arguments (13/7)
src/horizon/client.rs:687:29: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `auth_msg.to_json().unwrap()`
src/horizon/client.rs:720:29: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `SensorMessage::BlocklistSync.to_json().unwrap()`
src/horizon/client.rs:853:58: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `msg.to_json().unwrap()`
src/horizon/client.rs:879:38: warning: you seem to be trying to move all elements into a new `Vec`: help: consider using `mem::take`: `std::mem::take(batch)`
src/horizon/client.rs:899:29: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `msg.to_json()?`
src/horizon/client.rs:934:50: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `json`
src/horizon/client.rs:1342:62: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `json`
src/horizon/client.rs:1419:50: warning: useless conversion to the same type: `std::string::String`: help: consider removing `.into()`: `json`
src/horizon/manager.rs:125:13: warning: this `MutexGuard` is held across an await point
src/horizon/manager.rs:131:13: warning: this `MutexGuard` is held across an await point
src/horizon/manager.rs:143:13: warning: this `MutexGuard` is held across an await point
src/horizon/manager.rs:178:13: warning: this `MutexGuard` is held across an await point
src/horizon/manager.rs:184:13: warning: this `MutexGuard` is held across an await point
src/horizon/manager.rs:208:13: warning: this `MutexGuard` is held across an await point
src/horizon/types.rs:364:1: warning: this `impl` can be derived
src/payload/entity_bandwidth.rs:114:26: warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`: help: consider using: `std::mem::take(&mut self.current_bucket)`
src/trends/anomaly_detector.rs:318:22: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/anomaly_detector.rs:357:22: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/anomaly_detector.rs:406:22: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/anomaly_detector.rs:442:5: warning: this function has too many arguments (8/7)
src/trends/correlation.rs:178:18: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/correlation.rs:288:22: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/manager.rs:23:21: warning: very complex type used. Consider factoring parts into `type` definitions
src/trends/manager.rs:26:1: warning: this `impl` can be derived
src/trends/manager.rs:104:5: warning: this function has too many arguments (9/7)
src/trends/manager.rs:162:5: warning: this function has too many arguments (9/7)
src/trends/signal_extractor.rs:15:5: warning: this function has too many arguments (8/7)
src/trends/signal_extractor.rs:138:34: warning: stripping a prefix manually
src/trends/signal_extractor.rs:140:33: warning: stripping a prefix manually
src/trends/time_store.rs:44:14: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/time_store.rs:109:18: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/trends/time_store.rs:153:22: warning: use of `or_insert_with` to construct default value: help: try: `or_default()`
src/tunnel/client.rs:682:1: warning: this function has too many arguments (8/7)
```
</details>
## Test Results
| Passed | 1466
0
33
0
10
25
18
19
45
10
35
58
48
3
36
33
303
20
36
15
3
15 |
| Failed | 0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
1 |
| Ignored | 4
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
0
1 |
## Summary