symforge 11.18.2

SymForge — in-memory code intelligence MCP server for Claude Code, Codex, and Gemini CLI
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
//! Non-shipping L0 surface probe for Phase 0 §12A schema-byte measurement (A-005 / A-025).
//!
//! Frozen hand-written schemas for A-005 / A-019 measurement artifacts. Production
//! `SYMFORGE_SURFACE=compact` `tools/list` is served from [`crate::stel::compact_surface_tools`]
//! (Phase 1 S3). This module remains for meta-1 A/B, core and full listing, and byte
//! replay against pinned Phase 0 evidence.

use std::borrow::Cow;
use std::future::Future;
use std::sync::Arc;

use rmcp::model::Tool;
use schemars::JsonSchema;
use serde::Deserialize;
use serde_json::{Map, Value, json};

use super::SymForgeServer;

pub use crate::stel::surface::{
    SurfaceProfile, surface_label_from_str, surface_profile_from_label, surface_profile_label,
};

pub fn surface_profile_from_env() -> SurfaceProfile {
    // Default surface is FULL (spike-gate verdict 2026-07-03: no target harness
    // rejected the then-36-tool full `tools/list`; see docs/reviews). The current
    // full surface has 40 tools. `SYMFORGE_SURFACE=compact`
    // is the documented opt-in escape hatch (the compact-3 facade) for token-
    // sensitive setups; `core` (SF-TE-05) lists only `CORE_TOOL_NAMES` and
    // refuses nothing; `meta` keeps its explicit measurement meaning. Unset and
    // unrecognised values resolve to full, and the D23 connection-surface
    // task-local still takes precedence over env.
    match std::env::var("SYMFORGE_SURFACE")
        .ok()
        .map(|v| v.to_ascii_lowercase())
    {
        Some(ref s) if s == "core" => SurfaceProfile::Core,
        Some(ref s) if s == "compact" => SurfaceProfile::Compact,
        Some(ref s) if s == "meta" => SurfaceProfile::Meta,
        _ => SurfaceProfile::Full,
    }
}

/// HTTP header the front-end adapter stamps on every proxied daemon tool call
/// with the surface actually served on THIS connection (D23).
///
/// Out-of-band from the tool params JSON on purpose: the params carry each
/// tool's own typed input, one of which (`get_file_content`) is
/// `#[serde(deny_unknown_fields)]` — an injected params key would make an older
/// daemon's decode reject the call. A header degrades cleanly in BOTH version-
/// skew directions: an old daemon never reads it, a new daemon falls back to its
/// own env when an old adapter never sends it.
pub const CONNECTION_SURFACE_HEADER: &str = "x-symforge-connection-surface";

tokio::task_local! {
    /// Surface served on the connection whose proxied tool call the daemon is
    /// currently rendering (D23). Bound for the duration of ONE daemon-side tool
    /// dispatch by [`with_connection_surface`] from the adapter-supplied
    /// [`CONNECTION_SURFACE_HEADER`]; unset on direct/daemon-less serving, where
    /// this process's env IS the connection surface.
    static CONNECTION_SURFACE: SurfaceProfile;
}

/// Surface to render surface-aware empty-index guards against: the proxied
/// connection surface when a daemon-side proxied call is in flight, else this
/// process's own env (`SYMFORGE_SURFACE`).
///
/// This is the D23 fix point. The empty-index recovery hint must name only
/// tools callable on the AGENT's surface; in the daemon-proxy topology that is
/// the adapter's surface, not the daemon process's env (a compact adapter proxied
/// through a full-env daemon must not be told to call the gated `index_folder`).
pub fn connection_surface_or_env() -> SurfaceProfile {
    CONNECTION_SURFACE
        .try_with(|profile| *profile)
        .unwrap_or_else(|_| surface_profile_from_env())
}

/// Run `future` with the connection surface bound for a daemon-side proxied tool
/// call. `None` (an older adapter, or an unrecognized header) leaves it unbound
/// so [`connection_surface_or_env`] falls back to env — the pre-D23 behavior.
///
/// ponytail: bound to the FUTURE, not the thread — correct across the `.await`s
/// the handler makes on its own task. Guards render inline in each handler, never
/// in a `tokio::spawn`ed sub-task (task-locals do not propagate into those); if a
/// future guard site is ever spawned, thread the profile explicitly instead.
pub async fn with_connection_surface<F, T>(profile: Option<SurfaceProfile>, future: F) -> T
where
    F: Future<Output = T>,
{
    match profile {
        Some(profile) => CONNECTION_SURFACE.scope(profile, future).await,
        None => future.await,
    }
}

/// Central compact-surface dispatch gate (P1-A / FR-008 enforcement).
///
/// `tools/list` already hides legacy tools on the compact surface, but hiding is
/// not enforcement: a client can still name a legacy tool at `tools/call`. This
/// is the pure decision used by the production `ServerHandler::call_tool` (shared
/// by stdio and the HTTP `/mcp` path): on [`SurfaceProfile::Compact`], any tool
/// name NOT in the advertised compact-3 set ([`crate::stel::surface::COMPACT_TOOL_NAMES`])
/// is rejected. `Core`, `Full` and `Meta` are never gated here: the server default
/// is full, and the opt-in core profile only lists fewer tools, it does not
/// refuse the unlisted ones.
pub fn compact_surface_blocks(profile: SurfaceProfile, tool_name: &str) -> bool {
    profile == SurfaceProfile::Compact
        && !crate::stel::surface::COMPACT_TOOL_NAMES.contains(&tool_name)
}

/// Apply the compact-surface gate using the live `SYMFORGE_SURFACE` env profile.
///
/// Returns `Err(InvalidRequest)` when the call must be rejected, else `Ok(())`.
/// Used by the production `call_tool` and asserted directly by the surface
/// conformance test so the test exercises the real gate, not a copy.
pub fn enforce_compact_surface(tool_name: &str) -> Result<(), rmcp::ErrorData> {
    if compact_surface_blocks(surface_profile_from_env(), tool_name) {
        return Err(rmcp::ErrorData::invalid_request(
            format!(
                "tool '{tool_name}' not available on compact surface; unset SYMFORGE_SURFACE or set SYMFORGE_SURFACE=full for the full tool surface"
            ),
            None,
        ));
    }
    Ok(())
}

/// Upper bound for the `initialize` instructions string (SF-ADOPT-04): it is
/// paid on every session, so it stays a routing hint, not a manual.
pub const SERVER_INSTRUCTIONS_MAX_BYTES: usize = 600;

/// Full-surface routing hint. Names only tools the full surface lists.
pub const FULL_SURFACE_INSTRUCTIONS: &str = "SymForge indexes this repository. Start with search_symbols to find a function or type, get_symbol to read its body (pass targets[] to fetch several in one call), and find_references for callers and usages. Use search_text for code text. For exact literal match counts your own grep is fine. Read raw files with get_file_content only for docs, configs or exact bytes. On a daemon with several open projects, the project/projects parameters select one by ID or alias (never a path); omit both for the active project.";

/// Compact-surface routing hint. Names only the three compact tools.
pub const COMPACT_SURFACE_INSTRUCTIONS: &str = "SymForge indexes this repository. Ask code questions (find, read, trace, impact) with symforge, edit a symbol with symforge_edit, and check index state with status. For exact literal match counts your own grep is fine.";

/// Core-profile routing hint (opt-in profile). Names only core tools, and says in
/// one sentence that more exist and how the operator lists them.
pub const CORE_SURFACE_INSTRUCTIONS: &str = "SymForge indexes this repository. Start with search_symbols to find a function or type, get_symbol to read its body (pass targets[] to fetch several in one call), and find_references for callers and usages. Use search_text for code text. For exact literal match counts your own grep is fine. Read raw files with get_file_content only for docs, configs or exact bytes. The project/projects parameters select an open project by ID or alias, never a path. This is the core profile: tool text may name unlisted tools; the operator lists every tool with SYMFORGE_SURFACE=full.";

/// Instructions for the surface this process serves. The meta probe is a
/// measurement surface and gets none.
pub fn server_instructions(profile: SurfaceProfile) -> Option<&'static str> {
    match profile {
        SurfaceProfile::Core => Some(CORE_SURFACE_INSTRUCTIONS),
        SurfaceProfile::Full => Some(FULL_SURFACE_INSTRUCTIONS),
        SurfaceProfile::Compact => Some(COMPACT_SURFACE_INSTRUCTIONS),
        SurfaceProfile::Meta => None,
    }
}

pub fn list_tools_for_profile(profile: SurfaceProfile) -> Vec<Tool> {
    match profile {
        SurfaceProfile::Full => slimmed_router_tools(|name| name != "symforge"),
        SurfaceProfile::Core => {
            slimmed_router_tools(|name| crate::stel::surface::CORE_TOOL_NAMES.contains(&name))
                .into_iter()
                .map(|mut tool| {
                    if let Some((_, text)) = CORE_DESCRIPTIONS
                        .iter()
                        .find(|(name, _)| *name == tool.name)
                    {
                        tool.description = Some(Cow::Borrowed(text));
                    }
                    tool
                })
                .collect()
        }
        SurfaceProfile::Compact => compact_probe_tools(),
        SurfaceProfile::Meta => meta_probe_tools(),
    }
}

/// Core-profile descriptions for the core tools whose full-surface text points
/// at a tool core does not list. Same guidance minus those pointers; the
/// full surface keeps the original text. A test keeps these free of
/// off-core names.
const CORE_DESCRIPTIONS: &[(&str, &str)] = &[
    (
        "get_symbol",
        "Batch-read symbols: targets[] returns several symbols' source plus docs in one call (or name+path for one). Not callers (find_references) or raw files (get_file_content).",
    ),
    (
        "search_symbols",
        "Find functions/types by name (kind and path_prefix filters; omit query to browse). Not code text (search_text).",
    ),
    (
        "index_folder",
        "Open or refresh a directory and make it ACTIVE for this connection (add=true opens without switching).",
    ),
    (
        "find_references",
        "Sites/imports/types; best-effort direct caller/site ranges; may be incomplete. Same-name ambiguity: scope path/symbol_kind. mode=implementations: trait implementors.",
    ),
    (
        "status",
        "STEL trust envelope plus index state summary. Prefer at session start.",
    ),
    (
        "replace_symbol_body",
        "Replace a symbol's entire definition; the index resolves the range (no prior read). Not a small inner edit (edit_within_symbol).",
    ),
    (
        "edit_within_symbol",
        "Find-and-replace inside one symbol's byte range only (replace_all=true for every hit). Not a whole-definition rewrite (replace_symbol_body).",
    ),
    (
        "batch_edit",
        "Apply many symbol-addressed edits atomically across files (all resolve or none write); dry_run=true previews. Not a single-symbol edit (replace_symbol_body).",
    ),
];

/// Registered router tools selected by `keep`, with list-time schema slimming.
fn slimmed_router_tools(keep: impl Fn(&str) -> bool) -> Vec<Tool> {
    SymForgeServer::tool_router()
        .list_all()
        .into_iter()
        .filter(|tool| keep(tool.name.as_ref()))
        .map(|mut tool| {
            // The `#[tool]` macro builds these schemas via schemars, so they
            // carry the same inert `$schema` / `"default": null` bytes the
            // compact surface strips in `schema_object`.
            let mut schema = (*tool.input_schema).clone();
            crate::stel::surface_list::strip_schema_noise(&mut schema);
            shorten_project_selector_text(&mut schema);
            tool.input_schema = Arc::new(schema);
            tool
        })
        .collect()
}

/// One-line text for the `project` selector; the full explanation lives in the
/// server instructions (`get_info`) instead of being repeated on ~30 tools.
const PROJECT_SELECTOR_TEXT: &str =
    "Open-project ID or alias (not a path); omit for the active project.";
/// One-line text for the `projects` multi-project selector.
const PROJECTS_SELECTOR_TEXT: &str =
    "Open-project IDs/aliases, or [\"*\"] for all; daemon only; exclusive with `project`.";

/// SF-TE-05: replace the per-tool `project` / `projects` descriptions with one
/// line each. Only the top-level `properties` are touched, and only the
/// `description` string, so the property set and `required` are unchanged.
fn shorten_project_selector_text(schema: &mut Map<String, Value>) {
    let Some(Value::Object(props)) = schema.get_mut("properties") else {
        return;
    };
    for (name, text) in [
        ("project", PROJECT_SELECTOR_TEXT),
        ("projects", PROJECTS_SELECTOR_TEXT),
    ] {
        if let Some(Value::Object(field)) = props.get_mut(name)
            && field.contains_key("description")
        {
            field.insert("description".to_string(), Value::from(text));
        }
    }
}

fn schema_object(value: Value) -> Arc<Map<String, Value>> {
    Arc::new(
        value
            .as_object()
            .expect("compact probe schema must be a JSON object")
            .clone(),
    )
}

fn probe_tool(name: &'static str, description: &'static str, input_schema: Value) -> Tool {
    let mut tool = Tool::default();
    tool.name = Cow::Borrowed(name);
    tool.description = Some(Cow::Borrowed(description));
    tool.input_schema = schema_object(input_schema);
    tool
}

fn symforge_facade_schema() -> Value {
    json!({
        "type": "object",
        "properties": {
            "query": { "type": "string" },
            "intent": {
                "type": "string",
                "enum": ["auto", "orient", "find", "read", "trace", "impact", "meta"]
            },
            "path": { "type": "string" },
            "symbol": { "type": "string" },
            "max_tokens": { "type": "integer", "minimum": 64 },
            "preview": { "type": "boolean" }
        },
        "required": ["query"]
    })
}

/// Phase 0 A-019 measurement input. `_probe_*` fields are schema-hidden but
/// production-reachable through the source-mutation-safe facade allowlist.
#[derive(Debug, Clone, Deserialize, JsonSchema)]
pub struct StelFacadeProbeInput {
    pub query: String,
    #[serde(default)]
    pub intent: Option<String>,
    #[serde(default)]
    pub path: Option<String>,
    #[serde(default)]
    pub symbol: Option<String>,
    #[serde(default, rename = "_probe_legacy_tool")]
    pub probe_legacy_tool: Option<String>,
    #[serde(default, rename = "_probe_legacy_args")]
    pub probe_legacy_args: Option<Value>,
}

/// Resolve a compact/meta `symforge` facade call to a legacy L3 tool for measurement relay.
pub fn resolve_facade_probe(input: &StelFacadeProbeInput) -> Result<(String, Value), String> {
    let legacy_tool = input.probe_legacy_tool.as_deref().ok_or_else(|| {
        "Phase 0 facade relay requires `_probe_legacy_tool` (A-019 measurement relay)".to_string()
    })?;
    let legacy_args = input.probe_legacy_args.clone().ok_or_else(|| {
        "Phase 0 facade relay requires `_probe_legacy_args` (A-019 measurement relay)".to_string()
    })?;
    Ok((legacy_tool.to_string(), legacy_args))
}

/// Single-tool meta-1 surface for A-019 L0 A/B (measurement only).
pub fn meta_probe_tools() -> Vec<Tool> {
    vec![probe_tool(
        "symforge",
        "STEL meta-tool facade (Phase 0 measurement probe)",
        symforge_facade_schema(),
    )]
}

/// Three-tool compact surface for H1 / A-005 measurement (not STEL runtime).
pub fn compact_probe_tools() -> Vec<Tool> {
    vec![
        probe_tool(
            "symforge",
            "STEL read/explore facade (Phase 0 measurement probe)",
            symforge_facade_schema(),
        ),
        probe_tool(
            "symforge_edit",
            "STEL structural edit facade (Phase 0 measurement probe)",
            json!({
                "type": "object",
                "properties": {
                    "path": { "type": "string" },
                    "symbol": { "type": "string" },
                    "body": { "type": "string" },
                    "intent": { "type": "string", "enum": ["edit"] }
                },
                "required": ["path"]
            }),
        ),
        probe_tool(
            "status",
            "STEL trust envelope / index health (Phase 0 measurement probe)",
            json!({
                "type": "object",
                "properties": {
                    "detail": { "type": "string", "enum": ["compact", "full"] }
                }
            }),
        ),
    ]
}

/// Byte length of `symforge_edit` input schema alone (A-025).
pub fn symforge_edit_schema_bytes() -> usize {
    let edit = compact_probe_tools()
        .into_iter()
        .find(|t| t.name == "symforge_edit")
        .expect("symforge_edit probe tool");
    serde_json::to_string(&edit.input_schema)
        .expect("edit schema serializes")
        .len()
}

/// UTF-8 JSON byte length of `tools/list` payload for the given profile.
pub fn list_tools_schema_bytes(profile: SurfaceProfile) -> (usize, usize) {
    let tools = list_tools_for_profile(profile);
    let payload = json!({ "tools": tools });
    let bytes = serde_json::to_string(&payload)
        .expect("compact probe tools must serialize")
        .len();
    (tools.len(), bytes)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn compact_surface_is_three_tools_under_h1_budget() {
        let (count, bytes) = list_tools_schema_bytes(SurfaceProfile::Compact);
        assert_eq!(count, 3, "compact probe must expose exactly 3 tools");
        assert!(
            bytes <= 5000,
            "compact tools/list JSON must be <= 5000 B (H1); got {bytes} B"
        );
    }

    #[test]
    fn symforge_edit_schema_under_a025_budget() {
        let tools = compact_probe_tools();
        let edit = tools
            .iter()
            .find(|t| t.name == "symforge_edit")
            .expect("symforge_edit must exist");
        let bytes = serde_json::to_string(&edit.input_schema)
            .expect("edit schema must serialize")
            .len();
        assert!(
            bytes <= 1500,
            "symforge_edit input_schema must be <= 1500 B (A-025); got {bytes} B"
        );
    }

    #[test]
    fn full_profile_lists_current_tool_count() {
        let tools = list_tools_for_profile(SurfaceProfile::Full);
        assert_eq!(
            tools.len(),
            40,
            "full surface count changed; update the public inventory with any intentional change"
        );
        assert!(
            !tools.iter().any(|t| t.name == "symforge"),
            "full surface must not advertise symforge facade"
        );
    }

    /// SF-TE-05: the default full surface is paid for by every session before any
    /// call. Measured with the same method as `scripts/measure-schema-bytes.ps1`
    /// (UTF-8 bytes of the serialized `{"tools": [...]}` payload).
    #[test]
    fn full_surface_tools_list_under_byte_budget() {
        // Measured 69,631 B before list-time slimming, 63,106 B after (40 tools).
        // The 30,000 B target is met by the opt-in core profile; this budget
        // guards the full profile against regrowth. Lower it, never raise it
        // without a reviewed reason.
        const FULL_SURFACE_BUDGET_BYTES: usize = 63_500;
        let (count, bytes) = list_tools_schema_bytes(SurfaceProfile::Full);
        eprintln!("full surface tools/list: {count} tools, {bytes} B");
        assert!(
            bytes <= FULL_SURFACE_BUDGET_BYTES,
            "full tools/list JSON must be <= {FULL_SURFACE_BUDGET_BYTES} B; got {bytes} B"
        );
    }

    /// SF-TE-05: the opt-in core profile (`SYMFORGE_SURFACE=core`) stays under
    /// 30,000 B. Same measurement as the full budget test.
    #[test]
    fn core_surface_tools_list_under_byte_budget() {
        const CORE_SURFACE_BUDGET_BYTES: usize = 30_000;
        let (count, bytes) = list_tools_schema_bytes(SurfaceProfile::Core);
        eprintln!("core surface tools/list: {count} tools, {bytes} B");
        assert_eq!(count, crate::stel::surface::CORE_TOOL_NAMES.len());
        assert!(
            bytes <= CORE_SURFACE_BUDGET_BYTES,
            "core tools/list JSON must be <= {CORE_SURFACE_BUDGET_BYTES} B; got {bytes} B"
        );
    }

    /// SF-TE-05: no core tool description sends the agent to a tool core does
    /// not list. Parameter text is reported, not asserted.
    #[test]
    fn core_descriptions_name_no_unlisted_tool() {
        let off_core: Vec<String> = list_tools_for_profile(SurfaceProfile::Full)
            .into_iter()
            .map(|t| t.name.to_string())
            .filter(|n| !crate::stel::surface::CORE_TOOL_NAMES.contains(&n.as_str()))
            .collect();
        let named_in = |text: &str| -> Vec<String> {
            let words: Vec<&str> = text
                .split(|c: char| !(c.is_ascii_alphanumeric() || c == '_'))
                .collect();
            off_core
                .iter()
                .filter(|n| words.contains(&n.as_str()))
                .cloned()
                .collect()
        };
        for (name, _) in CORE_DESCRIPTIONS {
            assert!(
                crate::stel::surface::CORE_TOOL_NAMES.contains(name),
                "{name}"
            );
        }
        for tool in list_tools_for_profile(SurfaceProfile::Core) {
            let named = named_in(tool.description.as_deref().unwrap_or_default());
            assert!(
                named.is_empty(),
                "core `{}` description names {named:?}",
                tool.name
            );
            let schema = serde_json::to_string(tool.input_schema.as_ref()).unwrap();
            let named = named_in(&schema);
            if !named.is_empty() {
                eprintln!(
                    "core `{}` parameter text names off-core {named:?}",
                    tool.name
                );
            }
        }
    }

    /// SF-TE-05: list-time slimming rewrites only what is ADVERTISED. Every tool
    /// keeps its property set and `required` list, no `null` / numeric-format noise
    /// survives, and the server still decodes explicit `null` and absent optionals.
    #[test]
    fn schema_slimming_preserves_accepted_inputs() {
        let raw: std::collections::HashMap<String, Arc<Map<String, Value>>> =
            SymForgeServer::tool_router()
                .list_all()
                .into_iter()
                .map(|t| (t.name.to_string(), t.input_schema))
                .collect();
        for tool in list_tools_for_profile(SurfaceProfile::Full) {
            let name = tool.name.as_ref();
            let before = &raw[name];
            let after = &tool.input_schema;
            let keys = |s: &Map<String, Value>| -> Vec<String> {
                s.get("properties")
                    .and_then(Value::as_object)
                    .map(|p| p.keys().cloned().collect())
                    .unwrap_or_default()
            };
            assert_eq!(keys(before), keys(after), "{name}: property set changed");
            assert_eq!(
                before.get("required"),
                after.get("required"),
                "{name}: required changed"
            );
            let text = serde_json::to_string(after.as_ref()).unwrap();
            for noise in [r#""null""#, r#""format":"uint"#, r#""minimum":0"#] {
                assert!(!text.contains(noise), "{name}: `{noise}` survived slimming");
            }
        }

        // Server-side decode is serde, independent of the advertised schema:
        // explicit null and absence both decode to None.
        let text: crate::protocol::tools::SearchTextInput = serde_json::from_value(json!({
            "query": "x", "limit": null, "include_tests": null, "group_by": null,
            "project": null, "projects": null
        }))
        .expect("explicit nulls still decode");
        assert!(text.limit.is_none() && text.projects.is_none() && text.group_by.is_none());
        let _: crate::protocol::tools::SearchTextInput =
            serde_json::from_value(json!({ "query": "x" })).expect("absent optionals decode");
        let status: crate::stel::types::StelStatusRequest =
            serde_json::from_value(json!({ "detail": null })).expect("null anyOf field decodes");
        assert!(status.detail.is_none());
        let knowledge: crate::protocol::tools::SearchKnowledgeInput =
            serde_json::from_value(json!({ "query": "x", "authority_scope": null, "limit": null }))
                .expect("null anyOf field decodes");
        assert!(knowledge.authority_scope.is_none());
    }

    /// SF-ADOPT-04 snapshot: exact text, byte cap, and every tool name the text
    /// mentions is callable on that surface.
    #[test]
    fn server_instructions_snapshot_cap_and_surface_names() {
        assert_eq!(
            server_instructions(SurfaceProfile::Full),
            Some(
                "SymForge indexes this repository. Start with search_symbols to find a function or type, get_symbol to read its body (pass targets[] to fetch several in one call), and find_references for callers and usages. Use search_text for code text. For exact literal match counts your own grep is fine. Read raw files with get_file_content only for docs, configs or exact bytes. On a daemon with several open projects, the project/projects parameters select one by ID or alias (never a path); omit both for the active project."
            )
        );
        assert_eq!(
            server_instructions(SurfaceProfile::Compact),
            Some(
                "SymForge indexes this repository. Ask code questions (find, read, trace, impact) with symforge, edit a symbol with symforge_edit, and check index state with status. For exact literal match counts your own grep is fine."
            )
        );
        assert_eq!(server_instructions(SurfaceProfile::Meta), None);
        assert_eq!(
            server_instructions(SurfaceProfile::Core),
            Some(CORE_SURFACE_INSTRUCTIONS)
        );
        assert!(CORE_SURFACE_INSTRUCTIONS.contains("SYMFORGE_SURFACE=full"));

        let names = |tools: Vec<Tool>| -> Vec<String> {
            tools.into_iter().map(|t| t.name.to_string()).collect()
        };
        let full = names(list_tools_for_profile(SurfaceProfile::Full));
        let core = names(list_tools_for_profile(SurfaceProfile::Core));
        let compact = names(crate::stel::compact_surface_tools());
        let every: Vec<&String> = full.iter().chain(compact.iter()).collect();
        for (profile, served) in [
            (SurfaceProfile::Full, &full),
            (SurfaceProfile::Core, &core),
            (SurfaceProfile::Compact, &compact),
        ] {
            let text = server_instructions(profile).unwrap();
            assert!(
                text.len() <= SERVER_INSTRUCTIONS_MAX_BYTES,
                "{profile:?}: {} B",
                text.len()
            );
            let words: Vec<&str> = text
                .split(|c: char| !(c.is_ascii_alphanumeric() || c == '_'))
                .collect();
            for name in &every {
                if words.contains(&name.as_str()) {
                    assert!(
                        served.contains(name),
                        "{profile:?} names off-surface tool `{name}`"
                    );
                }
            }
        }
        assert!(
            compact.len() < full.len()
                && server_instructions(SurfaceProfile::Compact).unwrap().len()
                    < server_instructions(SurfaceProfile::Full).unwrap().len()
        );
    }

    #[test]
    fn meta_surface_is_one_tool_under_h1_budget() {
        let (count, bytes) = list_tools_schema_bytes(SurfaceProfile::Meta);
        assert_eq!(count, 1, "meta-1 probe must expose exactly 1 tool");
        assert!(
            bytes <= 5000,
            "meta tools/list JSON must be <= 5000 B (H1); got {bytes} B"
        );
    }

    #[test]
    fn facade_probe_requires_harness_fields() {
        let input = StelFacadeProbeInput {
            query: "x".to_string(),
            intent: None,
            path: None,
            symbol: None,
            probe_legacy_tool: None,
            probe_legacy_args: None,
        };
        assert!(resolve_facade_probe(&input).is_err());
    }

    #[test]
    fn surface_profile_from_label_roundtrips_canonical_and_rejects_junk() {
        assert_eq!(
            surface_profile_from_label("full"),
            Some(SurfaceProfile::Full)
        );
        assert_eq!(
            surface_profile_from_label("compact"),
            Some(SurfaceProfile::Compact)
        );
        assert_eq!(
            surface_profile_from_label("meta"),
            Some(SurfaceProfile::Meta)
        );
        // Non-canonical input (wrong case, arbitrary text, empty) must NOT resolve —
        // it falls back to the daemon's own env instead of trusting adapter garbage.
        assert_eq!(surface_profile_from_label("FULL"), None);
        assert_eq!(surface_profile_from_label("nonsense"), None);
        assert_eq!(surface_profile_from_label(""), None);
    }

    #[tokio::test]
    async fn connection_surface_scope_binds_then_unbinds() {
        // Inside the scope, the bound connection profile is what the guard renderer
        // reads — regardless of this process's env.
        let bound = with_connection_surface(Some(SurfaceProfile::Compact), async {
            connection_surface_or_env()
        })
        .await;
        assert_eq!(bound, SurfaceProfile::Compact);

        // `None` leaves it unbound: `connection_surface_or_env` reads env, and reading
        // an unset task-local must not panic (uses `try_with`, not `with`).
        let unbound = with_connection_surface(None, async { connection_surface_or_env() }).await;
        assert_eq!(unbound, surface_profile_from_env());
    }
}