1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
//! Edit planning: analyzes a target symbol/file and suggests the right
//! sequence of SymForge edit tools to accomplish a change.
use crate::domain::{SymbolKind, SymbolRecord};
use crate::live_index::query::{
SymbolSelectorMatch, resolve_symbol_selector, symbol_belongs_to_type,
};
use crate::live_index::store::{IndexedFile, LiveIndex};
fn split_path_qualified_target(target: &str) -> Option<(&str, &str)> {
if let Some((path, name)) = target.split_once("::") {
let path = path.trim();
let name = name.trim();
if !path.is_empty() && !name.is_empty() {
return Some((path, name));
}
}
None
}
/// Plan an edit operation: analyze impact and suggest tool sequence.
///
/// Rendered symbol line ranges are one-based public selector lines. Internally
/// `SymbolRecord::line_range` remains zero-based.
///
/// `temporal` is the lock-free git temporal snapshot taken from the shared
/// index handle (it does not live on the `LiveIndex` read snapshot). When it is
/// `Ready` and the primary target file has strong co-change partners, the
/// symbol branch emits a single terse `Co-change partners: a, b, c` line;
/// otherwise nothing is emitted (clean silent omission, no placeholder).
pub fn plan_edit(
index: &LiveIndex,
temporal: &crate::live_index::git_temporal::GitTemporalIndex,
target: &str,
) -> String {
let target = target.trim();
let qualified_target = split_path_qualified_target(target);
// Try to find the target as a symbol first
let mut symbol_hits = Vec::new();
let mut file_hit = None;
// AAP-001: populated when a path-shaped bare target matches several files
// by trailing path segment; drives the deterministic pick + ambiguity note.
let mut ambiguous_file_matches: Vec<String> = Vec::new();
if let Some((target_path, target_name)) = qualified_target {
let mut path_matched = false;
for (path, file) in index.all_files() {
if path == target_path || path.ends_with(target_path) {
path_matched = true;
collect_selector_hits(&mut symbol_hits, path, file, target_name);
}
if path.ends_with(target) || path == target {
file_hit = Some(path.clone());
}
}
// Type-name fallback: the left segment matched no indexed file path, so
// interpret it as a TYPE name `X` and resolve `Y` as a method whose
// enclosing impl/type in the same file is `X` (FR-001/FR-002). Every
// other selector form (file-path::symbol, bare name, plain file path)
// is byte-identical because it either matched a path here or takes the
// `else` branch below.
if !path_matched {
collect_type_scoped_hits(&mut symbol_hits, index, target_path, target_name);
}
} else {
// SF-AAP-001: an existing repo-relative path (exact match, or a full
// trailing path-segment suffix like `notes.md` → `docs/notes.md`) is a
// LITERAL path and must beat symbol/generated-path heuristics. Without
// this short-circuit, `find_candidates_cascade` strips `config.json` →
// `json` (qualification stripping) and matches an unrelated symbol, so
// the plan recommended a DIFFERENT path. A literal path routes straight
// to the file plan and never the symbol branch.
// AAP-001: exact `path == target` is a deterministic file hit. A
// PATH-SHAPED target (contains `/` or a dotted extension) resolves
// against a full trailing path segment, collecting ALL matches so a
// duplicate basename picks deterministically (sorted-first) and reports
// the ambiguity instead of a HashMap-order coin flip. A BARE identifier
// (no `.`, no `/`) must NOT short-circuit on a mere suffix match against
// an extensionless file — it falls through to the symbol cascade so
// e.g. `Handler` still resolves `fn Handler` even when `tools/Handler`
// exists.
let exact = index
.all_files()
.find_map(|(path, _)| (path == target).then(|| path.clone()));
if let Some(path) = exact {
file_hit = Some(path);
} else {
let path_shaped = target.contains('/') || target.contains('.');
let mut suffix_matches: Vec<String> = if path_shaped {
let needle = format!("/{target}");
let mut matches: Vec<String> = index
.all_files()
.filter(|(path, _)| path.ends_with(needle.as_str()))
.map(|(path, _)| path.clone())
.collect();
matches.sort();
matches
} else {
Vec::new()
};
match suffix_matches.len() {
// Bare identifier, or a path-shaped target with no literal file:
// run the normal symbol cascade so a symbol is never lost to a
// mere extensionless-file suffix match.
0 => {
for (path, file) in index.all_files() {
collect_selector_hits(&mut symbol_hits, path, file, target);
if path.ends_with(target) || path == target {
file_hit = Some(path.clone());
}
}
}
1 => file_hit = Some(suffix_matches.remove(0)),
_ => {
file_hit = Some(suffix_matches[0].clone());
ambiguous_file_matches = suffix_matches;
}
}
}
}
let symbol_target_name = symbol_hits
.first()
.map(|(_, name, _, _)| name.as_str())
.or_else(|| qualified_target.map(|(_, name)| name))
.unwrap_or(target);
let mut lines = vec!["── Edit Plan ──".to_string()];
if symbol_hits.is_empty() && file_hit.is_none() {
lines.push(format!("Target '{}' not found.", target));
lines.push("Try: search_symbols(query=\"...\") to find the correct name.".to_string());
return lines.join("\n");
}
if !symbol_hits.is_empty() {
lines.push(format!(
"Found {} symbol(s) matching '{}':",
symbol_hits.len(),
target
));
for (path, name, kind, (start, end)) in &symbol_hits {
let public_start = start.saturating_add(1);
let public_end = end.saturating_add(1);
lines.push(format!(
" {:?} {} in {} (lines {}-{})",
kind, name, path, public_start, public_end
));
}
// Count references
let ref_count = index
.find_references_for_name(symbol_target_name, None, false)
.len();
lines.push(format!(
"\nReferences: {} call sites across the project",
ref_count
));
if ref_count > 10 {
lines.push(
"⚠ HIGH IMPACT: >10 callers. Use batch_rename(dry_run=true) to preview."
.to_string(),
);
}
// Terse co-change line for the primary target file. Reuses
// `format::edit_impact_summary` (Ready-gated, forward-slash normalized,
// strong co_changes only, top-K). When temporal is not Ready or the file
// has no strong co-change partners the partner list is empty and we push
// NOTHING — clean silent omission, no placeholder line (unlike
// `analyze_file_impact`, `plan_edit` stays terse).
if let Some((primary_path, _, _, _)) = symbol_hits.first() {
let (_, partners) =
crate::protocol::format::edit_impact_summary(index, temporal, primary_path);
if !partners.is_empty() {
lines.push(format!("Co-change partners: {}", partners.join(", ")));
}
}
lines.push("\nSuggested tool sequence:".to_string());
if symbol_hits.len() == 1 {
let (path, name, _, _) = &symbol_hits[0];
lines.push(format!(" 1. get_symbol_context(name=\"{name}\", path=\"{path}\", bundle=true) — understand full context"));
lines.push(" 2. Choose edit approach:".to_string());
lines.push(format!(" - Small change: edit_within_symbol(path=\"{path}\", name=\"{name}\", old_text=..., new_text=...)"));
lines.push(format!(" - Full rewrite: replace_symbol_body(path=\"{path}\", name=\"{name}\", new_body=...)"));
lines.push(format!(" - Rename: batch_rename(path=\"{path}\", name=\"{name}\", new_name=..., dry_run=true)"));
lines.push(format!(
" - Delete: delete_symbol(path=\"{path}\", name=\"{name}\", dry_run=true)"
));
lines.push(format!(
" 3. analyze_file_impact(path=\"{path}\") — verify changes"
));
} else {
lines.push(" 1. Use symbol_line to disambiguate the target".to_string());
lines.push(" 2. get_symbol_context(bundle=true) on the chosen symbol".to_string());
lines.push(" 3. batch_edit(dry_run=true) for multi-symbol changes".to_string());
}
}
if let Some(path) = file_hit
&& symbol_hits.is_empty()
{
lines.push(format!("Found file: {}", path));
if ambiguous_file_matches.len() > 1 {
lines.push(format!(
"⚠ Ambiguous file target '{}' matched {} paths ({}); selected '{}' (first sorted). Pass a fuller path to disambiguate.",
target,
ambiguous_file_matches.len(),
ambiguous_file_matches.join(", "),
path
));
}
lines.push("\nSuggested approach:".to_string());
lines.push(format!(
" 1. get_file_context(path=\"{path}\", sections=[\"outline\"]) — understand structure"
));
lines.push(format!(
" 2. get_symbol(path=\"{path}\", name=\"<target>\") — read specific symbols"
));
lines.push(" 3. Use edit_within_symbol or replace_symbol_body for changes".to_string());
lines.push(format!(
" 4. analyze_file_impact(path=\"{path}\") — verify"
));
}
lines.join("\n")
}
fn collect_selector_hits(
symbol_hits: &mut Vec<(String, String, crate::domain::SymbolKind, (u32, u32))>,
path: &str,
file: &IndexedFile,
selector: &str,
) {
match resolve_symbol_selector(file, selector, None, None) {
SymbolSelectorMatch::Selected(_, sym) => {
push_symbol_hit(symbol_hits, path, sym);
}
SymbolSelectorMatch::Ambiguous(lines) => {
for line in lines {
let symbol_line = line + 1;
if let SymbolSelectorMatch::Selected(_, sym) =
resolve_symbol_selector(file, selector, None, Some(symbol_line))
{
push_symbol_hit(symbol_hits, path, sym);
}
}
}
SymbolSelectorMatch::NotFound => {}
}
}
/// Type-name fallback for a `Type::method` selector whose left segment matched
/// no indexed file path. Collects every method/function named `method_name`
/// whose enclosing `impl`/type in the same file resolves to `type_name`
/// (range-containment via `symbol_belongs_to_type`). Deterministic: candidates
/// are ordered by `(path, line)` so multiple matches render in a stable order.
fn collect_type_scoped_hits(
symbol_hits: &mut Vec<(String, String, SymbolKind, (u32, u32))>,
index: &LiveIndex,
type_name: &str,
method_name: &str,
) {
let mut hits: Vec<(&String, &SymbolRecord)> = Vec::new();
for (path, file) in index.all_files() {
for sym in &file.symbols {
if sym.name == method_name
&& matches!(sym.kind, SymbolKind::Method | SymbolKind::Function)
&& symbol_belongs_to_type(file, sym, type_name)
{
hits.push((path, sym));
}
}
}
hits.sort_by(|a, b| a.0.cmp(b.0).then(a.1.line_range.0.cmp(&b.1.line_range.0)));
for (path, sym) in hits {
push_symbol_hit(symbol_hits, path, sym);
}
}
fn push_symbol_hit(
symbol_hits: &mut Vec<(String, String, crate::domain::SymbolKind, (u32, u32))>,
path: &str,
sym: &SymbolRecord,
) {
symbol_hits.push((path.to_string(), sym.name.clone(), sym.kind, sym.line_range));
}