symbi-runtime 0.6.1

Agent Runtime System for the Symbi platform
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
//! Local Key Store for Trust-On-First-Use (TOFU) mechanism
//!
//! Provides secure storage and management of public keys for tool providers
//! to prevent man-in-the-middle and key substitution attacks.

use serde_json;
use std::collections::HashMap;
use std::fs::{self, File, OpenOptions};
use std::io::{BufReader, BufWriter, Write};
use std::path::Path;
use std::sync::{Arc, RwLock};

use super::types::{KeyStoreConfig, KeyStoreError, PinnedKey};

/// Thread-safe local key store implementing TOFU mechanism
#[derive(Debug)]
pub struct LocalKeyStore {
    /// Configuration for the key store
    config: KeyStoreConfig,
    /// In-memory cache of pinned keys
    keys: Arc<RwLock<HashMap<String, PinnedKey>>>,
}

impl LocalKeyStore {
    /// Create a new key store with default configuration
    pub fn new() -> Result<Self, KeyStoreError> {
        Self::with_config(KeyStoreConfig::default())
    }

    /// Create a new key store with custom configuration
    pub fn with_config(config: KeyStoreConfig) -> Result<Self, KeyStoreError> {
        let store = Self {
            config,
            keys: Arc::new(RwLock::new(HashMap::new())),
        };

        // Load existing keys from file
        store.load_from_file()?;

        Ok(store)
    }

    /// Pin a new key for the given identifier (TOFU logic)
    /// Returns an error if a different key is already pinned for this identifier
    pub fn pin_key(&self, key: PinnedKey) -> Result<(), KeyStoreError> {
        let mut keys = self.keys.write().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire write lock: {}", e),
        })?;

        // Check if key already exists for this identifier
        if let Some(existing_key) = keys.get(&key.identifier) {
            // TOFU: If key already exists, it must match exactly
            if existing_key.public_key != key.public_key
                || existing_key.fingerprint != key.fingerprint
            {
                return Err(KeyStoreError::KeyMismatch {
                    identifier: key.identifier.clone(),
                });
            }
            // Key already exists and matches - this is fine
            return Ok(());
        }

        // Pin the new key
        keys.insert(key.identifier.clone(), key);
        drop(keys); // Release lock before file I/O

        // Persist to file
        self.save_to_file()
    }

    /// Retrieve a pinned key by identifier
    pub fn get_key(&self, identifier: &str) -> Result<PinnedKey, KeyStoreError> {
        let keys = self.keys.read().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire read lock: {}", e),
        })?;

        keys.get(identifier)
            .cloned()
            .ok_or_else(|| KeyStoreError::KeyNotFound {
                identifier: identifier.to_string(),
            })
    }

    /// Check if a key is pinned for the given identifier
    pub fn has_key(&self, identifier: &str) -> Result<bool, KeyStoreError> {
        let keys = self.keys.read().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire read lock: {}", e),
        })?;

        Ok(keys.contains_key(identifier))
    }

    /// Remove a pinned key by identifier
    pub fn remove_key(&self, identifier: &str) -> Result<Option<PinnedKey>, KeyStoreError> {
        let mut keys = self.keys.write().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire write lock: {}", e),
        })?;

        let removed_key = keys.remove(identifier);
        drop(keys); // Release lock before file I/O

        if removed_key.is_some() {
            self.save_to_file()?;
        }

        Ok(removed_key)
    }

    /// List all pinned key identifiers
    pub fn list_identifiers(&self) -> Result<Vec<String>, KeyStoreError> {
        let keys = self.keys.read().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire read lock: {}", e),
        })?;

        Ok(keys.keys().cloned().collect())
    }

    /// Get all pinned keys
    pub fn list_keys(&self) -> Result<Vec<PinnedKey>, KeyStoreError> {
        let keys = self.keys.read().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire read lock: {}", e),
        })?;

        Ok(keys.values().cloned().collect())
    }

    /// Clear all pinned keys
    pub fn clear(&self) -> Result<(), KeyStoreError> {
        let mut keys = self.keys.write().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire write lock: {}", e),
        })?;

        keys.clear();
        drop(keys); // Release lock before file I/O

        self.save_to_file()
    }

    /// Verify that a key matches the pinned key for an identifier
    pub fn verify_key(
        &self,
        identifier: &str,
        public_key: &str,
        fingerprint: &str,
    ) -> Result<bool, KeyStoreError> {
        let pinned_key = self.get_key(identifier)?;
        Ok(pinned_key.public_key == public_key && pinned_key.fingerprint == fingerprint)
    }

    /// Load keys from the store file
    fn load_from_file(&self) -> Result<(), KeyStoreError> {
        if !self.config.store_path.exists() {
            if self.config.create_if_missing {
                // Create parent directories if they don't exist
                if let Some(parent) = self.config.store_path.parent() {
                    fs::create_dir_all(parent).map_err(|e| KeyStoreError::IoError {
                        reason: format!("Failed to create parent directories: {}", e),
                    })?;
                }
                // Create empty store file
                self.save_to_file()?;
                return Ok(());
            } else {
                return Err(KeyStoreError::StoreFileNotFound {
                    path: self.config.store_path.display().to_string(),
                });
            }
        }

        let file = File::open(&self.config.store_path).map_err(|e| KeyStoreError::ReadFailed {
            reason: format!("Failed to open store file: {}", e),
        })?;

        let reader = BufReader::new(file);
        let loaded_keys: HashMap<String, PinnedKey> =
            serde_json::from_reader(reader).map_err(|e| KeyStoreError::SerializationFailed {
                reason: format!("Failed to deserialize keys: {}", e),
            })?;

        let mut keys = self.keys.write().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire write lock: {}", e),
        })?;

        *keys = loaded_keys;

        Ok(())
    }

    /// Save keys to the store file
    fn save_to_file(&self) -> Result<(), KeyStoreError> {
        let keys = self.keys.read().map_err(|e| KeyStoreError::IoError {
            reason: format!("Failed to acquire read lock: {}", e),
        })?;

        // Create parent directories if they don't exist
        if let Some(parent) = self.config.store_path.parent() {
            fs::create_dir_all(parent).map_err(|e| KeyStoreError::WriteFailed {
                reason: format!("Failed to create parent directories: {}", e),
            })?;
        }

        let file = OpenOptions::new()
            .write(true)
            .create(true)
            .truncate(true)
            .open(&self.config.store_path)
            .map_err(|e| KeyStoreError::WriteFailed {
                reason: format!("Failed to open store file for writing: {}", e),
            })?;

        // Set file permissions on Unix systems
        #[cfg(unix)]
        if let Some(permissions) = self.config.file_permissions {
            use std::os::unix::fs::PermissionsExt;
            let mut perms = file
                .metadata()
                .map_err(|e| KeyStoreError::WriteFailed {
                    reason: format!("Failed to get file metadata: {}", e),
                })?
                .permissions();
            perms.set_mode(permissions);
            fs::set_permissions(&self.config.store_path, perms).map_err(|e| {
                KeyStoreError::PermissionDenied {
                    reason: format!("Failed to set file permissions: {}", e),
                }
            })?;
        }

        let mut writer = BufWriter::new(file);
        serde_json::to_writer_pretty(&mut writer, &*keys).map_err(|e| {
            KeyStoreError::SerializationFailed {
                reason: format!("Failed to serialize keys: {}", e),
            }
        })?;

        writer.flush().map_err(|e| KeyStoreError::WriteFailed {
            reason: format!("Failed to flush writer: {}", e),
        })?;

        Ok(())
    }

    /// Get the path to the store file
    pub fn store_path(&self) -> &Path {
        &self.config.store_path
    }
}

impl Default for LocalKeyStore {
    fn default() -> Self {
        Self::new().expect("Failed to create default key store")
    }
}

// Implement Clone for LocalKeyStore to allow sharing between threads
impl Clone for LocalKeyStore {
    fn clone(&self) -> Self {
        Self {
            config: self.config.clone(),
            keys: Arc::clone(&self.keys),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::collections::HashMap;
    use tempfile::TempDir;

    fn create_test_key_store() -> (LocalKeyStore, TempDir) {
        let temp_dir = TempDir::new().unwrap();
        let store_path = temp_dir.path().join("test_keys.json");

        let config = KeyStoreConfig {
            store_path,
            create_if_missing: true,
            file_permissions: Some(0o600),
        };

        let store = LocalKeyStore::with_config(config).unwrap();
        (store, temp_dir)
    }

    fn create_test_key(identifier: &str) -> PinnedKey {
        PinnedKey::new(
            identifier.to_string(),
            format!("public_key_for_{}", identifier),
            "Ed25519".to_string(),
            format!("fingerprint_for_{}", identifier),
        )
    }

    #[test]
    fn test_pin_and_get_key() {
        let (store, _temp_dir) = create_test_key_store();
        let key = create_test_key("example.com");

        // Pin the key
        store.pin_key(key.clone()).unwrap();

        // Retrieve the key
        let retrieved_key = store.get_key("example.com").unwrap();
        assert_eq!(retrieved_key.identifier, key.identifier);
        assert_eq!(retrieved_key.public_key, key.public_key);
        assert_eq!(retrieved_key.fingerprint, key.fingerprint);
    }

    #[test]
    fn test_tofu_key_mismatch() {
        let (store, _temp_dir) = create_test_key_store();
        let key1 = create_test_key("example.com");
        let mut key2 = create_test_key("example.com");
        key2.public_key = "different_public_key".to_string();

        // Pin the first key
        store.pin_key(key1).unwrap();

        // Try to pin a different key for the same identifier
        let result = store.pin_key(key2);
        assert!(matches!(result, Err(KeyStoreError::KeyMismatch { .. })));
    }

    #[test]
    fn test_tofu_same_key_twice() {
        let (store, _temp_dir) = create_test_key_store();
        let key = create_test_key("example.com");

        // Pin the key twice - should succeed
        store.pin_key(key.clone()).unwrap();
        store.pin_key(key).unwrap();
    }

    #[test]
    fn test_has_key() {
        let (store, _temp_dir) = create_test_key_store();
        let key = create_test_key("example.com");

        assert!(!store.has_key("example.com").unwrap());
        store.pin_key(key).unwrap();
        assert!(store.has_key("example.com").unwrap());
    }

    #[test]
    fn test_remove_key() {
        let (store, _temp_dir) = create_test_key_store();
        let key = create_test_key("example.com");

        store.pin_key(key.clone()).unwrap();
        assert!(store.has_key("example.com").unwrap());

        let removed_key = store.remove_key("example.com").unwrap();
        assert!(removed_key.is_some());
        assert_eq!(removed_key.unwrap().identifier, key.identifier);
        assert!(!store.has_key("example.com").unwrap());
    }

    #[test]
    fn test_list_keys() {
        let (store, _temp_dir) = create_test_key_store();
        let key1 = create_test_key("example.com");
        let key2 = create_test_key("test.org");

        store.pin_key(key1).unwrap();
        store.pin_key(key2).unwrap();

        let identifiers = store.list_identifiers().unwrap();
        assert_eq!(identifiers.len(), 2);
        assert!(identifiers.contains(&"example.com".to_string()));
        assert!(identifiers.contains(&"test.org".to_string()));

        let keys = store.list_keys().unwrap();
        assert_eq!(keys.len(), 2);
    }

    #[test]
    fn test_clear() {
        let (store, _temp_dir) = create_test_key_store();
        let key1 = create_test_key("example.com");
        let key2 = create_test_key("test.org");

        store.pin_key(key1).unwrap();
        store.pin_key(key2).unwrap();
        assert_eq!(store.list_identifiers().unwrap().len(), 2);

        store.clear().unwrap();
        assert_eq!(store.list_identifiers().unwrap().len(), 0);
    }

    #[test]
    fn test_verify_key() {
        let (store, _temp_dir) = create_test_key_store();
        let key = create_test_key("example.com");

        store.pin_key(key.clone()).unwrap();

        // Verify with correct key
        assert!(store
            .verify_key("example.com", &key.public_key, &key.fingerprint)
            .unwrap());

        // Verify with incorrect key
        assert!(!store
            .verify_key("example.com", "wrong_key", &key.fingerprint)
            .unwrap());
        assert!(!store
            .verify_key("example.com", &key.public_key, "wrong_fingerprint")
            .unwrap());
    }

    #[test]
    fn test_persistence() {
        let temp_dir = TempDir::new().unwrap();
        let store_path = temp_dir.path().join("test_keys.json");

        let config = KeyStoreConfig {
            store_path: store_path.clone(),
            create_if_missing: true,
            file_permissions: Some(0o600),
        };

        // Create store and add a key
        {
            let store = LocalKeyStore::with_config(config.clone()).unwrap();
            let key = create_test_key("example.com");
            store.pin_key(key).unwrap();
        }

        // Create new store instance and verify key persisted
        {
            let store = LocalKeyStore::with_config(config).unwrap();
            assert!(store.has_key("example.com").unwrap());
            let retrieved_key = store.get_key("example.com").unwrap();
            assert_eq!(retrieved_key.identifier, "example.com");
        }
    }

    #[test]
    fn test_key_not_found() {
        let (store, _temp_dir) = create_test_key_store();

        let result = store.get_key("nonexistent.com");
        assert!(matches!(result, Err(KeyStoreError::KeyNotFound { .. })));
    }

    #[test]
    fn test_pinned_key_with_metadata() {
        let (store, _temp_dir) = create_test_key_store();

        let mut metadata = HashMap::new();
        metadata.insert(
            "version".to_string(),
            serde_json::Value::String("1.0.0".to_string()),
        );
        metadata.insert(
            "source".to_string(),
            serde_json::Value::String("test".to_string()),
        );

        let key = PinnedKey::with_metadata(
            "example.com".to_string(),
            "test_public_key".to_string(),
            "Ed25519".to_string(),
            "test_fingerprint".to_string(),
            metadata.clone(),
        );

        store.pin_key(key).unwrap();

        let retrieved_key = store.get_key("example.com").unwrap();
        assert!(retrieved_key.metadata.is_some());
        let retrieved_metadata = retrieved_key.metadata.unwrap();
        assert_eq!(retrieved_metadata.get("version"), metadata.get("version"));
        assert_eq!(retrieved_metadata.get("source"), metadata.get("source"));
    }
}