sylva-rs 2.0.0

Terrestrial and airborne laser scanning processing for forest ecology and remote sensing research.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
// Sylva: LiDAR processing for forest ecology and remote sensing research.
// Copyright (C) 2026 Tim Devereux, The University of Queensland.
// Follows AMAPVox (UMR AMAP); see THIRD_PARTY_NOTICES.md.
// Free software under the GNU General Public License v3.0 or later;
// see the LICENSE file. There is no warranty, to the extent permitted by law.
//! Pulse traversal: the accumulation half of the voxelisation.

use std::collections::{BTreeMap, HashMap};
use std::f64::consts::PI;
use std::sync::atomic::{AtomicI32, AtomicU64, AtomicU8, Ordering::Relaxed};

use rayon::prelude::*;

use super::{foliage, unbounded_end, Attenuation, RayVoxels, VoxelInputs, VoxelParams, WeightMethod, F, I};
use crate::transform::{add, norm, scale, sub};
use crate::Point;

/// Grid placement.
#[derive(Debug, Clone)]
pub(crate) struct Geom {
    pub origin: Point,
    pub size: f64,
    pub shape: [usize; 3],
    max: Point,
}

impl Geom {
    pub fn new(origin: Point, size: f64, shape: [usize; 3]) -> Self {
        let max = [origin[0] + shape[0] as f64 * size, origin[1] + shape[1] as f64 * size, origin[2] + shape[2] as f64 * size];
        Geom { origin, size, shape, max }
    }

    #[inline]
    pub fn flat(&self, p: [i64; 3]) -> Option<usize> {
        if (0..3).all(|k| p[k] >= 0 && (p[k] as usize) < self.shape[k]) {
            Some(p[0] as usize + self.shape[0] * (p[1] as usize + self.shape[1] * p[2] as usize))
        } else {
            None
        }
    }

    #[inline]
    pub fn to_vox(&self, p: &Point) -> Point {
        [(p[0] - self.origin[0]) / self.size, (p[1] - self.origin[1]) / self.size, (p[2] - self.origin[2]) / self.size]
    }

    /// The voxel an echo at `p` belongs to: the last one a pulse travelling
    /// along the unit vector `dir` crosses before it stops at `p`. That is
    /// the voxel of `p` itself, except for an echo lying exactly on a voxel
    /// face, which belongs to the voxel the pulse came through and not to the
    /// one beyond the face that it never entered ([`walk_grid`] stops
    /// [`FACE_TOLERANCE`] short of its end for the same reason, so the hit
    /// and the path that led to it land in the same voxel).
    #[inline]
    pub fn hit_cell(&self, p: &Point, dir: Option<&Point>) -> [i64; 3] {
        let v = self.to_vox(p);
        match dir {
            Some(d) => [(v[0] - d[0] * FACE_TOLERANCE).floor() as i64, (v[1] - d[1] * FACE_TOLERANCE).floor() as i64, (v[2] - d[2] * FACE_TOLERANCE).floor() as i64],
            None => [v[0].floor() as i64, v[1].floor() as i64, v[2].floor() as i64],
        }
    }

    fn center(&self, p: [i64; 3]) -> Point {
        [
            self.origin[0] + (p[0] as f64 + 0.5) * self.size,
            self.origin[1] + (p[1] as f64 + 0.5) * self.size,
            self.origin[2] + (p[2] as f64 + 0.5) * self.size,
        ]
    }

    /// Clip a segment to the grid box shrunk by `eps` (raylib `Cuboid::clipRay`).
    /// `None` when the segment misses the box; otherwise whether its far end
    /// was cut off, i.e. whether the segment goes on beyond the grid.
    fn clip(&self, start: &mut Point, end: &mut Point, eps: f64) -> Option<bool> {
        let mut near = 0.0f64;
        let mut far = 1.0f64;
        let dir = sub(end, start);
        for ax in 0..3 {
            let centre = 0.5 * (self.origin[ax] + self.max[ax]);
            let extent = 0.5 * (self.max[ax] - self.origin[ax]) - eps;
            let to_centre = centre - start[ax];
            let s = if dir[ax] > 0.0 { 1.0 } else { -1.0 };
            let (n, f) = (to_centre - s * extent, to_centre + s * extent);
            if dir[ax] != 0.0 {
                near = near.max(n / dir[ax]);
                far = far.min(f / dir[ax]);
            } else if (n > 0.0) == (f > 0.0) {
                return None;
            }
        }
        if far <= near {
            return None;
        }
        let s = add(start, &scale(&dir, near));
        let e = sub(end, &scale(&dir, 1.0 - far));
        *start = s;
        *end = e;
        Some(far < 1.0)
    }
}

/// A box of voxels, `lo` to `lo + shape` (exclusive), that one engine
/// accumulates: a block of a grid traced block by block. Pulses are still
/// walked through the whole grid, so every voxel of the box receives exactly
/// the contributions (and in the same order) that a whole-grid trace gives it.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(crate) struct Window {
    pub lo: [usize; 3],
    pub shape: [usize; 3],
}

impl Window {
    #[inline]
    pub fn local(&self, p: [i64; 3]) -> Option<usize> {
        let mut q = [0usize; 3];
        for k in 0..3 {
            let d = p[k] - self.lo[k] as i64;
            if d < 0 || d as usize >= self.shape[k] {
                return None;
            }
            q[k] = d as usize;
        }
        Some(q[0] + self.shape[0] * (q[1] + self.shape[1] * q[2]))
    }

    pub fn n_voxels(&self) -> usize {
        self.shape[0] * self.shape[1] * self.shape[2]
    }

    /// Whether the segment `a`-`b` (voxel units) passes within `margin` of the box.
    pub fn touches(&self, a: &Point, b: &Point, margin: f64) -> bool {
        let (mut s0, mut s1) = (0.0f64, 1.0f64);
        for k in 0..3 {
            let (lo, hi) = (self.lo[k] as f64 - margin, (self.lo[k] + self.shape[k]) as f64 + margin);
            let d = b[k] - a[k];
            if d == 0.0 {
                if a[k] < lo || a[k] > hi {
                    return false;
                }
                continue;
            }
            let (t0, t1) = ((lo - a[k]) / d, (hi - a[k]) / d);
            s0 = s0.max(t0.min(t1));
            s1 = s1.min(t0.max(t1));
            if s0 > s1 {
                return false;
            }
        }
        true
    }
}

/// How far short of `end` a segment stops, so that one ending exactly on a
/// voxel face does not reach into the voxel beyond it.
const FACE_TOLERANCE: f64 = 1e-10;

/// The voxels a segment crosses, in order: the traversal of Amanatides & Woo
/// (1987). Coordinates are in voxel units, voxel `i` spanning `[i, i + 1)` on
/// each axis. `visit(cell, t_enter, t_exit, length)` receives the distances
/// along the segment at which it enters and leaves `cell` (`t_exit` can pass
/// `length` in the last voxel) and returns `true` to stop.
///
/// `visit: impl FnMut(...) -> bool` is a callback: the caller passes a closure
/// (a lambda), which may hold and change state of its own between calls —
/// several below accumulate into a counter or a bit mask. Writing it this way
/// rather than returning a list of voxels means nothing is allocated per
/// pulse, which matters when there are hundreds of millions of them.
pub(crate) fn walk_grid(start: &Point, end: &Point, mut visit: impl FnMut([i64; 3], f64, f64, f64) -> bool) {
    let span = sub(end, start);
    let full = norm(&span);
    if !(full > 0.0) {
        return;
    }
    let length = full - FACE_TOLERANCE;
    // Per axis (the paper's X, Y, Z): the voxel, the step direction, the
    // distance to the first boundary (tMax) and between boundaries (tDelta).
    let mut cell = [0i64; 3];
    let mut step = [0i64; 3];
    let mut t_max = [f64::INFINITY; 3];
    let mut t_delta = [f64::INFINITY; 3];
    for axis in 0..3 {
        let x = start[axis];
        cell[axis] = x.floor() as i64;
        let cosine = span[axis] / full;
        if cosine > 0.0 {
            step[axis] = 1;
            t_delta[axis] = 1.0 / cosine;
            t_max[axis] = ((cell[axis] + 1) as f64 - x) / cosine;
        } else if cosine < 0.0 {
            step[axis] = -1;
            t_delta[axis] = -1.0 / cosine;
            t_max[axis] = (x - cell[axis] as f64) / -cosine;
        }
    }
    let mut t_enter = 0.0;
    loop {
        // The boundary met first; ties go to the later axis, as in the paper.
        let axis = if t_max[0] < t_max[1] {
            if t_max[0] < t_max[2] { 0 } else { 2 }
        } else if t_max[1] < t_max[2] {
            1
        } else {
            2
        };
        if visit(cell, t_enter, t_max[axis], length) || t_max[axis] >= length {
            return;
        }
        t_enter = t_max[axis];
        cell[axis] += step[axis];
        t_max[axis] += t_delta[axis];
    }
}

/// Effective free path `−ln(1 − λ₁z) / λ₁` (`z` when `λ₁ = 0`).
#[inline]
fn eff_free_path(z: f64, lambda1: f64) -> f64 {
    if lambda1 <= 0.0 {
        return z;
    }
    let x = (lambda1 * z).min(1.0 - 1e-9);
    -(-x).ln_1p() / lambda1
}

/// Sums are kept in `f64` while pulses are added in whatever order the threads
/// get to them, so that the order matters as little as it can: the `f64` sum
/// still depends on it in its last bits, which can move the `f32` result by
/// one unit in the last place between two multi-threaded runs. A trace that
/// must be reproducible to the bit goes block by block
/// ([`super::voxelize_blocks`]), where each block is filled by one thread in
/// pulse order.
///
/// Reading this without Rust: there is no atomic `f64`, so the running sum is
/// kept as the `f64`'s own bit pattern inside an atomic 64-bit integer
/// (`to_bits` / `from_bits` reinterpret, they do not convert). The loop is the
/// usual lock-free update: read the current value, work out what it should
/// become, and swap it in *only if* no other thread has changed it meanwhile.
/// `compare_exchange_weak` returns the value it actually found when that
/// fails, so the loop simply tries again from there. `Relaxed` says we need
/// nothing of the ordering between threads beyond the single value being
/// updated atomically, which is true here: every sum stands alone.
#[inline]
fn fadd(a: &AtomicU64, v: f64) {
    let mut cur = a.load(Relaxed);
    loop {
        let new = (f64::from_bits(cur) + v).to_bits();
        match a.compare_exchange_weak(cur, new, Relaxed, Relaxed) {
            Ok(_) => return,
            Err(c) => cur = c,
        }
    }
}

/// Everything a pulse adds to one voxel, side by side: a traversal touches
/// most fields of each voxel it visits, so a voxel should be one stretch of
/// memory rather than an entry in twenty arrays.
///
/// The fields are fixed-size arrays indexed by the field enums [`F`] (sums,
/// held as bits — see [`fadd`]) and [`I`] (counts), so `F::PathLength as usize`
/// is simply a slot number.
pub(crate) struct Cell {
    f: [AtomicU64; F::COUNT],
    i: [AtomicI32; I::COUNT],
}

/// Shared accumulators, written concurrently.
///
/// Threads trace different pulses into the same grid at the same time. Rather
/// than lock a voxel, every slot is an atomic the hardware updates on its own,
/// which is why `addf` and `addi` below take `&self` (a shared reference) and
/// not `&mut self`: nothing here is exclusively borrowed, so any number of
/// threads may hold it at once.
struct Accum {
    cells: Vec<Cell>,
    /// Sub-voxel occupancy, `n_sub` slots per voxel laid end to end, so voxel
    /// `idx`'s slots start at `idx * n_sub`.
    sub: Vec<AtomicU8>,
}

impl Accum {
    #[inline]
    fn addf(&self, field: F, idx: usize, v: f64) {
        fadd(&self.cells[idx].f[field as usize], v);
    }

    #[inline]
    fn addi(&self, field: I, idx: usize) {
        self.cells[idx].i[field as usize].fetch_add(1, Relaxed);
    }
}

#[derive(Clone, Copy)]
pub(crate) struct Ret {
    pos: Point,
    range: f64,
    bound: bool,
    intensity: f64,
    foliage: u8,
}

/// One intercepted beam for the exact PPL solve.
struct PplHit {
    voxel: usize,
    chord: f32,
    section: f32,
}

struct Tracer<'a> {
    geom: &'a Geom,
    /// Only this box is accumulated (indices are then local to it).
    window: Option<&'a Window>,
    acc: &'a Accum,
    params: &'a VoxelParams,
    peaks: Option<&'a [f64]>,
    ground: Option<&'a [f64]>,
    tan_half_div: f64,
    beam_diameter: f64,
    lambda1: f64,
    ppl: bool,
}

#[derive(Clone, Copy, PartialEq)]
enum Pass {
    /// Whole pulse, unit weight: counts and potential path length.
    Full,
    /// One echo segment carrying `weight` of the pulse.
    Segment,
    /// `Full` and `Segment` in one walk, for a pulse with a single segment.
    Both,
    Occluded,
}

struct Ray {
    vox_start: Point,
    vox_dir: Point,
    beam_origin: Point,
    unbound: bool,
    foliage: u8,
    weight: f64,
    /// The segment goes on beyond the grid: it leaves its last voxel too.
    open_end: bool,
    /// Voxel of the echo this segment starts at (none for one starting at
    /// the scanner): the pulse entered it on the segment before.
    entered: Option<[i64; 3]>,
}

/// Margin (voxels) within which a segment counts as reaching a window.
const WINDOW_MARGIN: f64 = 1e-6;

impl Tracer<'_> {
    /// Index of a voxel in the accumulators: flat in the grid, or in the window.
    #[inline]
    fn index(&self, cell: [i64; 3]) -> Option<usize> {
        match self.window {
            None => self.geom.flat(cell),
            Some(w) => w.local(cell),
        }
    }

    fn section(&self, origin: &Point, cell: [i64; 3]) -> f64 {
        let r = self.tan_half_div * norm(&sub(&self.geom.center(cell), origin)) + 0.5 * self.beam_diameter;
        PI * r * r
    }

    #[allow(clippy::too_many_arguments)]
    fn walk(&self, start: &Point, end: &Point, beam_origin: &Point, pass: Pass, weight: f64, unbound: bool, fol: u8, entered: Option<[i64; 3]>) {
        let (mut cs, mut ce) = (*start, *end);
        let Some(open_end) = self.geom.clip(&mut cs, &mut ce, 1e-10) else { return };
        let (vs, ve) = (self.geom.to_vox(&cs), self.geom.to_vox(&ce));
        let d = sub(&ve, &vs);
        let len = norm(&d);
        if !(len > 0.0) {
            return;
        }
        if self.window.is_some_and(|w| !w.touches(&vs, &ve, WINDOW_MARGIN)) {
            return;
        }
        let ray = Ray { vox_start: vs, vox_dir: scale(&d, 1.0 / len), beam_origin: *beam_origin, unbound, foliage: fol, weight, open_end, entered };
        // Angle of the beam from the vertical, whichever way it travels: a
        // beam going down at 170 degrees meets the leaves as one going up at
        // 10 degrees does, and the two must not average to a horizontal one.
        let zenith = ray.vox_dir[2].abs().min(1.0).acos();
        let az = ray.vox_dir[0].atan2(ray.vox_dir[1]);
        let (sin_az, cos_az) = az.sin_cos();
        // The walk is the whole-grid one; with a window it stops once it has
        // left the box (every coordinate is monotone, so it cannot come back).
        let mut inside = false;
        walk_grid(&vs, &ve, |cell, in_len, out_len, max_len| {
            // `index` gives `None` for a voxel outside the grid (or outside the
            // window being accumulated); `let ... else` takes the value when
            // there is one and otherwise runs the block, which here ends the
            // walk once the ray has crossed the window and left it again.
            let Some(idx) = self.index(cell) else { return inside && self.window.is_some() };
            inside = true;
            self.visit(&ray, pass, zenith, sin_az, cos_az, cell, idx, in_len, out_len, max_len);
            false
        });
    }

    #[allow(clippy::too_many_arguments)]
    fn visit(&self, ray: &Ray, pass: Pass, zenith: f64, sin_az: f64, cos_az: f64, cell: [i64; 3], idx: usize, mut in_len: f64, out_len: f64, max_len: f64) {
        let end_len = out_len.min(max_len);
        let column = cell[0] as usize + self.geom.shape[0] * cell[1] as usize;

        if pass != Pass::Occluded {
            if let Some(peaks) = self.peaks {
                let peak = peaks[column];
                let in_h = ray.vox_start[2] + ray.vox_dir[2] * in_len;
                let end_h = ray.vox_start[2] + ray.vox_dir[2] * end_len;
                if ray.vox_dir[2] < 0.0 && in_h > peak && end_h <= peak {
                    let t = (in_h - peak) / (in_h - end_h);
                    in_len += (end_len - in_len) * t.clamp(0.0, 0.99);
                }
            }
        }
        let size = self.geom.size;
        let length = (end_len - in_len) * size;
        let chord = (out_len - in_len) * size;
        // The pulse leaves this voxel unless the walk ends in it; a walk cut
        // off at the grid's edge goes on, and so leaves its last voxel too.
        let exits = out_len < max_len || ray.open_end;
        let a = self.acc;

        if pass == Pass::Occluded {
            if let Some(g) = self.ground {
                if self.geom.center(cell)[2] < g[column] {
                    return;
                }
            }
            a.addi(I::NumRaysOccluded, idx);
            a.addf(F::PathLengthOccluded, idx, length * ray.weight);
            return;
        }
        if pass != Pass::Segment {
            a.addi(I::NumBeams, idx);
            a.addf(F::PathLength, idx, chord);
            a.addf(F::PathLengthSq, idx, chord * chord);
            let split = self.params.subvoxel_split;
            if split > 0 {
                let local = |l: f64| {
                    let mut p = [0.0; 3];
                    for k in 0..3 {
                        p[k] = (ray.vox_start[k] + ray.vox_dir[k] * l - cell[k] as f64) * split as f64;
                    }
                    p
                };
                // Which of the voxel's own sub-cells this pulse crossed. A
                // sub-cell is counted once however long the pulse spent in it,
                // so the crossing is recorded as one bit per sub-cell in a
                // 64-bit mask (`split` is at most 4, so at most 64 of them).
                let mut bits = 0u64;
                let s = split as i64;
                walk_grid(&local(in_len), &local(end_len), |c, _, _, _| {
                    if (0..3).all(|k| c[k] >= 0 && c[k] < s) {
                        bits |= 1 << (c[0] + s * (c[1] + s * c[2]));
                    }
                    false
                });
                let n_sub = split * split * split;
                // Walk the bits that are set: `trailing_zeros` is the lowest
                // one, and `bits &= bits - 1` clears it, so the loop runs once
                // per crossed sub-cell rather than once per sub-cell.
                while bits != 0 {
                    let b = bits.trailing_zeros() as usize;
                    bits &= bits - 1;
                    // The counters are single bytes, so a sub-cell crossed more
                    // than 255 times stops counting rather than wrapping to 0:
                    // `checked_add` gives `None` at the ceiling and
                    // `fetch_update` then leaves the value alone.
                    let _ = a.sub[idx * n_sub + b].fetch_update(Relaxed, Relaxed, |v| v.checked_add(1));
                }
            }
            if exits {
                if !ray.unbound {
                    a.addi(I::NumMissRays, idx);
                }
                a.addf(F::SumMissDelta, idx, chord);
            }
        }
        if pass != Pass::Full {
            let w = ray.weight;
            // A segment that starts at an echo starts inside the voxel the
            // pulse entered on the segment before: what is left of the pulse
            // travels on through it (the path lengths below), but does not
            // enter it a second time.
            let enters = ray.entered != Some(cell);
            if enters {
                a.addf(F::NumBeamsWeighted, idx, w);
            }
            a.addf(F::FreePathLength, idx, length * w);
            match ray.foliage {
                foliage::PLANT => a.addf(F::FreePathLengthPlant, idx, length * w),
                foliage::LEAF => a.addf(F::FreePathLengthLeaf, idx, length * w),
                foliage::WOOD => a.addf(F::FreePathLengthWood, idx, length * w),
                _ => {}
            }
            let eff = eff_free_path(length, self.lambda1);
            a.addf(F::EffectiveFreePathLength, idx, eff * w);
            if enters {
                a.addf(F::SumOfAngles, idx, zenith * w);
                a.addf(F::SumSinAzimuth, idx, sin_az * w);
                a.addf(F::SumCosAzimuth, idx, cos_az * w);
                // Distance from the scanner, not from the previous echo.
                a.addf(F::SumOfLaserDistances, idx, norm(&sub(&self.geom.center(cell), &ray.beam_origin)) * w);
            }
            if self.params.beam.is_some() {
                let bs = self.section(&ray.beam_origin, cell) * w;
                if enters {
                    a.addf(F::BsEntering, idx, bs);
                }
                a.addf(F::BsFreePath, idx, bs * length);
                a.addf(F::BsEffectiveFreePath, idx, bs * eff);
                if exits {
                    a.addf(F::BsPotential, idx, bs);
                }
            }
            if ray.unbound {
                a.addi(I::NumUnboundRays, idx);
                a.addf(F::PathLengthUnbound, idx, length * w);
            }
        }
    }

    fn echo_weights(&self, rets: &[Ret], w: &mut Vec<f32>) {
        let n = rets.len();
        w.clear();
        w.resize(n, 0.0);
        let equal = |w: &mut Vec<f32>| w.iter_mut().for_each(|v| *v = 1.0 / n as f32);
        match self.params.weighting {
            WeightMethod::Equal => equal(w),
            WeightMethod::Full => w[n - 1] = 1.0,
            // A pulse whose first return is a miss or the ground still samples
            // every voxel it crosses; only its hit is not counted.
            WeightMethod::First => w[0] = 1.0,
            WeightMethod::Relative => {
                let sum: f64 = rets.iter().map(|r| r.intensity).sum();
                if sum > 0.0 {
                    for (v, r) in w.iter_mut().zip(rets) {
                        *v = (r.intensity / sum) as f32;
                    }
                } else {
                    equal(w);
                }
            }
            WeightMethod::Strongest => {
                let mut best = 0;
                for k in 1..n {
                    if rets[k].intensity > rets[best].intensity {
                        best = k;
                    }
                }
                w[best] = 1.0;
            }
        }
    }

    /// All echoes of one pulse, nearest first.
    fn process(&self, origin: &Point, rets: &[Ret], echo_w: &mut Vec<f32>, seg_w: &mut Vec<f32>, ppl_hits: &mut Vec<PplHit>) {
        let n = rets.len();
        if n == 0 {
            return;
        }
        self.echo_weights(rets, echo_w);
        // Fraction of the pulse still travelling along each segment.
        seg_w.clear();
        seg_w.resize(n, 0.0);
        let mut run = 0.0f32;
        for k in (0..n).rev() {
            run += echo_w[k];
            seg_w[k] = run;
        }
        let last_seg = (0..n).rev().find(|&k| seg_w[k] > 0.0);
        let far = &rets[n - 1];
        let ray_vec = sub(&far.pos, origin);
        let ray_len = norm(&ray_vec);

        let dir = (ray_len > 1e-12).then(|| scale(&ray_vec, 1.0 / ray_len));
        if let Some(last) = last_seg {
            if n == 1 && ray_len >= 1e-6 {
                // The whole pulse is its only segment: one walk does both passes.
                self.walk(origin, &far.pos, origin, Pass::Both, seg_w[0] as f64, !far.bound, far.foliage, None);
            } else if ray_len >= 1e-6 {
                self.walk(origin, &rets[last].pos, origin, Pass::Full, 1.0, !rets[last].bound, 0, None);
            }
            let mut seg_start = *origin;
            let mut entered = None;
            for (k, r) in rets.iter().enumerate().take(if n == 1 { 0 } else { last + 1 }) {
                if norm(&sub(&r.pos, &seg_start)) >= 1e-6 {
                    self.walk(&seg_start, &r.pos, origin, Pass::Segment, seg_w[k] as f64, !r.bound, r.foliage, entered);
                }
                seg_start = r.pos;
                entered = Some(self.geom.hit_cell(&r.pos, dir.as_ref()));
            }
        }

        let a = self.acc;
        for (k, r) in rets.iter().enumerate() {
            if !r.bound || seg_w[k] <= 0.0 {
                continue;
            }
            let cell = self.geom.hit_cell(&r.pos, dir.as_ref());
            let Some(idx) = self.index(cell) else { continue };
            // Full chord of the hit voxel and the free path from its entry to the echo.
            let (mut chord, mut free) = (0.0, 0.0);
            if let Some(d) = dir {
                let (mut t_in, mut t_out) = (0.0f64, 1e30f64);
                for ax in 0..3 {
                    if d[ax].abs() > 1e-15 {
                        let lo = self.geom.origin[ax] + cell[ax] as f64 * self.geom.size;
                        let t1 = (lo - origin[ax]) / d[ax];
                        let t2 = (lo + self.geom.size - origin[ax]) / d[ax];
                        t_in = t_in.max(t1.min(t2));
                        t_out = t_out.min(t1.max(t2));
                    }
                }
                chord = (t_out - t_in).max(0.0);
                free = (r.range - t_in).min(chord).max(0.0);
            }
            a.addi(I::NumHits, idx);
            a.addf(F::HitsWeighted, idx, echo_w[k] as f64);
            a.addf(F::SumHitDelta, idx, chord);
            match r.foliage {
                foliage::LEAF => a.addi(I::NumHitLeaf, idx),
                foliage::WOOD => a.addi(I::NumHitWood, idx),
                _ => {}
            }
            if r.foliage != foliage::EXCLUDED {
                a.addi(I::NumHitPlant, idx);
            }
            if self.params.beam.is_some() {
                // This echo's own share of the pulse, not the cumulative segment weight.
                let bs = self.section(origin, cell) * echo_w[k] as f64;
                a.addf(F::BsIntercepted, idx, bs);
                a.addf(F::BsEffFreePathHits, idx, bs * eff_free_path(free, self.lambda1));
            }
        }

        if self.params.occlusion && far.bound && ray_len >= 1e-6 {
            let mut diag = 0.0;
            for k in 0..3 {
                diag += (self.geom.shape[k] as f64 * self.geom.size).powi(2);
            }
            let end = add(&far.pos, &scale(&ray_vec, 2.0 * diag.sqrt() / ray_len));
            self.walk(&far.pos, &end, origin, Pass::Occluded, 1.0, false, 0, None);
        }

        if self.ppl {
            self.accumulate_ppl(origin, rets, echo_w, ppl_hits);
        }
    }

    /// Exact PPL: one record per intercepted echo (potential path = full
    /// chord), and the leaving fraction × section × chord per voxel.
    fn accumulate_ppl(&self, origin: &Point, rets: &[Ret], echo_w: &[f32], out: &mut Vec<PplHit>) {
        let (mut cs, mut ce) = (*origin, rets[rets.len() - 1].pos);
        if self.geom.clip(&mut cs, &mut ce, 1e-10).is_none() {
            return;
        }
        let ray_vec = sub(&rets[rets.len() - 1].pos, origin);
        let ray_len = norm(&ray_vec);
        let dir = (ray_len > 1e-12).then(|| scale(&ray_vec, 1.0 / ray_len));
        let (vs, ve) = (self.geom.to_vox(&cs), self.geom.to_vox(&ce));
        if self.window.is_some_and(|w| !w.touches(&vs, &ve, WINDOW_MARGIN)) {
            return;
        }
        // The share of the pulse still travelling depends on every voxel
        // before this one, so a window walks (without recording) from the start.
        let mut f_in = 1.0f64;
        let mut inside = false;
        walk_grid(&vs, &ve, |cell, in_len, out_len, _| {
            if self.geom.flat(cell).is_none() {
                return false;
            }
            let idx = self.index(cell);
            if idx.is_none() && inside {
                return true;
            }
            inside |= idx.is_some();
            let chord = (out_len - in_len) * self.geom.size;
            if chord <= 0.0 {
                return false;
            }
            let section = if self.params.beam.is_some() { self.section(origin, cell) } else { 1.0 };
            let mut intercepted = 0.0;
            for (r, &w) in rets.iter().zip(echo_w) {
                if r.bound && self.geom.hit_cell(&r.pos, dir.as_ref()) == cell {
                    intercepted += w as f64;
                    if let Some(idx) = idx {
                        out.push(PplHit { voxel: idx, chord: chord as f32, section: (w as f64 * section) as f32 });
                    }
                }
            }
            if let Some(idx) = idx {
                let leaving = f_in - intercepted;
                if leaving > 0.0 {
                    self.acc.addf(F::PplMissWl, idx, leaving * section * chord);
                }
            }
            f_in -= intercepted;
            f_in < 1e-6
        });
    }
}

/// Per voxel, solve `Σ_hits bs·L / (e^{kL} − 1) = ppl_miss_wl` for `k`
/// (the exact PPL maximum-likelihood estimate, capped at 20 m⁻¹).
fn solve_ppl(hits: Vec<PplHit>, miss: &[f32], n: usize) -> Vec<f32> {
    const K_MAX: f64 = 20.0;
    const EPS: f64 = 1e-12;
    let mut by_voxel: HashMap<usize, Vec<(f64, f64)>> = HashMap::new();
    for h in hits {
        by_voxel.entry(h.voxel).or_default().push((h.chord as f64, h.section as f64));
    }
    let solved: Vec<(usize, f32)> = by_voxel
        .par_iter()
        .map(|(&idx, recs)| {
            let target = miss[idx] as f64;
            let f = |k: f64| recs.iter().map(|&(l, bs)| { let e = (k * l).exp() - 1.0; if e > EPS { bs * l / e } else { 0.0 } }).sum::<f64>();
            // No beam left the voxel, or the root lies beyond the cap.
            if target <= EPS || f(K_MAX) >= target {
                return (idx, K_MAX as f32);
            }
            let (mut lo, mut hi) = (EPS, K_MAX);
            for _ in 0..100 {
                let mid = 0.5 * (lo + hi);
                if f(mid) > target { lo = mid } else { hi = mid }
            }
            (idx, (0.5 * (lo + hi)) as f32)
        })
        .collect();
    let mut out = vec![-1.0f32; n];
    for (idx, k) in solved {
        out[idx] = k;
    }
    out
}

/// The echoes of pulse `s` as traced (a pulse without one gets a far end).
fn pulse_rets(inputs: &VoxelInputs, s: usize, geom: &Geom, params: &VoxelParams, rets: &mut Vec<Ret>) {
    let shots = inputs.shots;
    let (o, d) = (shots.origin[s], shots.direction[s]);
    let first = shots.echo_start[s];
    rets.clear();
    for e in first..first + shots.echo_count[s] as usize {
        let range = shots.echo_range[e];
        let is_ground = inputs.ground.is_some_and(|g| g[e]);
        rets.push(Ret {
            pos: add(&o, &scale(&d, range)),
            range,
            bound: !is_ground,
            intensity: inputs.intensity.map_or(0.0, |v| v[e]),
            foliage: if is_ground { foliage::EXCLUDED } else { inputs.foliage.map_or(foliage::PLANT, |f| f[e]) },
        });
    }
    if rets.is_empty() {
        let end = unbounded_end(&o, &d, geom, params.unbounded_range);
        rets.push(Ret { pos: end, range: norm(&sub(&end, &o)), bound: false, intensity: 0.0, foliage: foliage::EXCLUDED });
    }
}

/// The segment of pulse `s` that any of its walks can reach, in voxel
/// units: from its origin to its farthest echo, or to the end of the
/// occlusion ray beyond it. `rets` is scratch space.
pub(crate) fn pulse_extent(inputs: &VoxelInputs, s: usize, geom: &Geom, params: &VoxelParams, rets: &mut Vec<Ret>) -> (Point, Point) {
    pulse_rets(inputs, s, geom, params, rets);
    let o = inputs.shots.origin[s];
    let far = &rets[rets.len() - 1];
    let ray_vec = sub(&far.pos, &o);
    let ray_len = norm(&ray_vec);
    let mut ends: Vec<Point> = rets.iter().map(|r| r.pos).collect();
    if params.occlusion && far.bound && ray_len >= 1e-6 {
        let mut diag = 0.0;
        for k in 0..3 {
            diag += (geom.shape[k] as f64 * geom.size).powi(2);
        }
        ends.push(add(&far.pos, &scale(&ray_vec, 2.0 * diag.sqrt() / ray_len)));
    }
    // Every walk lies on the line through the origin; take its span.
    let dir = if ray_len > 0.0 { scale(&ray_vec, 1.0 / ray_len) } else { inputs.shots.direction[s] };
    let (mut t0, mut t1) = (0.0f64, 0.0f64);
    for p in &ends {
        let v = sub(p, &o);
        let t = v[0] * dir[0] + v[1] * dir[1] + v[2] * dir[2];
        t0 = t0.min(t);
        t1 = t1.max(t);
    }
    (geom.to_vox(&add(&o, &scale(&dir, t0))), geom.to_vox(&add(&o, &scale(&dir, t1))))
}

/// Reusable per-pulse buffers.
#[derive(Default)]
pub(crate) struct Scratch {
    pub rets: Vec<Ret>,
    echo_w: Vec<f32>,
    seg_w: Vec<f32>,
}

/// Accumulators for one grid, filled by any number of [`Engine::add`] calls.
pub(crate) struct Engine {
    pub geom: Geom,
    pub params: VoxelParams,
    /// Only this box of the grid is accumulated.
    window: Option<Window>,
    acc: Accum,
    hits: Vec<PplHit>,
    ppl: bool,
}

impl Engine {
    pub fn new(params: &VoxelParams, geom: Geom) -> Self {
        Self::build(params, geom, None)
    }

    /// Accumulators for the voxels of `window` only; pulses are traced
    /// through the whole of `geom` so that the box gets exactly what a
    /// whole-grid trace would give it.
    pub fn new_window(params: &VoxelParams, geom: Geom, window: Window) -> Self {
        Self::build(params, geom, Some(window))
    }

    fn build(params: &VoxelParams, geom: Geom, window: Option<Window>) -> Self {
        let n = window.map_or(geom.shape[0] * geom.shape[1] * geom.shape[2], |w| w.n_voxels());
        let ppl = params.attenuation.contains(&Attenuation::Ppl);
        let n_sub = params.subvoxel_split.pow(3);
        let acc = Accum {
            cells: std::iter::repeat_with(|| Cell { f: std::array::from_fn(|_| AtomicU64::new(0)), i: std::array::from_fn(|_| AtomicI32::new(0)) }).take(n).collect(),
            sub: std::iter::repeat_with(|| AtomicU8::new(0)).take(n * n_sub).collect(),
        };
        Engine { geom, params: params.clone(), window, acc, hits: Vec::new(), ppl }
    }

    fn tracer<'a>(&'a self, peaks: Option<&'a [f64]>, ground: Option<&'a [f64]>) -> Tracer<'a> {
        let params = &self.params;
        let beam = params.beam.unwrap_or(super::BeamSpec { diameter: 0.0, divergence: 0.0 });
        Tracer {
            geom: &self.geom,
            window: self.window.as_ref(),
            acc: &self.acc,
            params,
            peaks,
            ground,
            tan_half_div: (0.5 * beam.divergence).tan(),
            beam_diameter: beam.diameter,
            lambda1: if params.average_leaf_area > 0.0 { 0.25 * params.average_leaf_area / params.voxel_size.powi(3) } else { 0.0 },
            ppl: self.ppl,
        }
    }

    pub fn add(&mut self, inputs: &VoxelInputs, peaks: Option<&[f64]>, ground: Option<&[f64]>) {
        let params = &self.params;
        let geom = &self.geom;
        let tracer = self.tracer(peaks, ground);
        let shots = inputs.shots;
        struct Local {
            scratch: Scratch,
            hits: Vec<PplHit>,
            done: u64,
        }
        let task = crate::util::progress::start("tracing pulses", shots.n_shots() as u64);
        // Trace every pulse, on as many threads as the machine has. Reading
        // this without Rust: `into_par_iter` turns the range of pulse numbers
        // into a parallel loop (rayon), `with_min_len(256)` hands out work in
        // chunks of at least that many so the bookkeeping does not cost more
        // than the tracing, and `fold` gives each thread its own `Local` —
        // reusable buffers, and the hits it finds — so the threads share
        // nothing but the grid's atomics. `reduce` then joins those per-thread
        // lists into one. The grid itself is written as the tracing goes, by
        // the atomic adds in [`Accum`]; only the PPL hits have to be collected.
        let mut hits: Vec<PplHit> = (0..shots.n_shots())
            .into_par_iter()
            .with_min_len(256)
            .fold(
                || Local { scratch: Scratch::default(), hits: Vec::new(), done: 0 },
                |mut l, s| {
                    // Checked before the first pulse of each piece of work as
                    // well, or a cancelled run would still trace 256 pulses
                    // in every piece rayon has yet to start.
                    if l.done % 256 == 0 {
                        crate::util::progress::check();
                    }
                    let sc = &mut l.scratch;
                    pulse_rets(inputs, s, geom, params, &mut sc.rets);
                    tracer.process(&shots.origin[s], &sc.rets, &mut sc.echo_w, &mut sc.seg_w, &mut l.hits);
                    l.done += 1;
                    // Each thread's `Local` may see as few as 256 pulses (the
                    // least rayon hands out), so the count, and with it the
                    // check for a cancelled run, is made at that interval.
                    if l.done % 256 == 0 {
                        task.inc(256);
                    }
                    l
                },
            )
            .map(|l| l.hits)
            .reduce(Vec::new, |mut a, mut b| {
                a.append(&mut b);
                a
            });
        self.hits.append(&mut hits);
    }

    /// Trace the pulses `pulses` of `inputs` one after another, in the order given.
    pub fn add_sequential(&mut self, inputs: &VoxelInputs, pulses: &[u32], peaks: Option<&[f64]>, ground: Option<&[f64]>, scratch: &mut Scratch) {
        let tracer = self.tracer(peaks, ground);
        let mut hits = Vec::new();
        for (k, &s) in pulses.iter().enumerate() {
            // A cancelled run (Ctrl-C from Python) stops here, not only at
            // the end of the block's list.
            if k % 256 == 0 {
                crate::util::progress::check();
            }
            let s = s as usize;
            pulse_rets(inputs, s, &self.geom, &self.params, &mut scratch.rets);
            tracer.process(&inputs.shots.origin[s], &scratch.rets, &mut scratch.echo_w, &mut scratch.seg_w, &mut hits);
        }
        self.hits.append(&mut hits);
    }

    /// Voxels held.
    pub fn n_cells(&self) -> usize {
        self.acc.cells.len()
    }

    pub fn finish(self) -> RayVoxels {
        let (origin, shape) = match self.window {
            None => (self.geom.origin, self.geom.shape),
            Some(w) => (std::array::from_fn(|k| self.geom.origin[k] + w.lo[k] as f64 * self.geom.size), w.shape),
        };
        let n = shape[0] * shape[1] * shape[2];
        let n_sub = self.params.subvoxel_split.pow(3);
        // Unused groups stay empty (they read as 0).
        let cells = &self.acc.cells;
        let f: Vec<Vec<f32>> = F::ALL
            .iter()
            .map(|fld| {
                let on = if fld.is_beam() { self.params.beam.is_some() } else if *fld == F::PplMissWl { self.ppl } else { true };
                if on { cells.par_iter().map(|c| f64::from_bits(c.f[*fld as usize].load(Relaxed)) as f32).collect() } else { Vec::new() }
            })
            .collect();
        let i: Vec<Vec<i32>> = I::ALL.iter().map(|fld| cells.par_iter().map(|c| c.i[*fld as usize].load(Relaxed)).collect()).collect();
        let ppl_lambda = self.ppl.then(|| solve_ppl(self.hits, &f[F::PplMissWl as usize], n));
        RayVoxels {
            origin,
            voxel_size: self.geom.size,
            shape,
            params: self.params,
            has_leaf: false,
            has_wood: false,
            f,
            i,
            ppl_lambda,
            subvoxel_counts: (n_sub > 0).then(|| self.acc.sub.into_iter().map(AtomicU8::into_inner).collect()),
            ground_height: None,
            wood_volume: None,
            predominant_tree: None,
            tree_iad: BTreeMap::new(),
        }
    }
}

#[cfg(test)]
mod tests {
    use crate::voxel::{voxelize, voxelize_blocks, Attenuation, BeamSpec, BlockOptions, Lad, Pulses, RayVoxels, VoxelInputs, VoxelParams, F, I};
    use crate::{Point, Shots};

    /// Pulses `(origin, direction, echo ranges)` as shots.
    fn shots(pulses: &[(Point, Point, Vec<f64>)]) -> Shots {
        let mut s = Shots::default();
        for (o, d, ranges) in pulses {
            s.origin.push(*o);
            s.direction.push(*d);
            s.echo_start.push(s.echo_range.len());
            s.echo_count.push(ranges.len() as u32);
            s.echo_range.extend(ranges);
        }
        s
    }

    /// A 1 x 1 m column of voxels from z = 0 to `top`.
    fn column(voxel_size: f64, top: f64) -> VoxelParams {
        VoxelParams { voxel_size, bounds: Some(([0.0; 3], [1.0, 1.0, top])), ..Default::default() }
    }

    fn trace(s: &Shots, p: &VoxelParams) -> RayVoxels {
        voxelize(&VoxelInputs::new(s), p).unwrap()
    }

    const UP: Point = [0.0, 0.0, 1.0];
    const DOWN: Point = [0.0, 0.0, -1.0];

    /// Vertical pulses through a turbid layer of attenuation `lambda` (m⁻¹)
    /// filling z = 0 to 4 m: free paths are exponential, drawn from a fixed
    /// sequence, and a pulse whose free path passes 4 m has no echo.
    fn slab(lambda: f64, n: usize) -> Shots {
        let mut state = 0x2545_F491_4F6C_DD1Du64;
        let mut uniform = || {
            state = state.wrapping_mul(6364136223846793005).wrapping_add(1442695040888963407);
            ((state >> 11) as f64 + 0.5) / (1u64 << 53) as f64
        };
        let pulses: Vec<(Point, Point, Vec<f64>)> = (0..n)
            .map(|_| {
                let o = [0.05 + 0.9 * uniform(), 0.05 + 0.9 * uniform(), -1.0];
                let free = -uniform().ln() / lambda;
                (o, UP, if free < 4.0 { vec![1.0 + free] } else { vec![] })
            })
            .collect();
        shots(&pulses)
    }

    #[test]
    fn transmittance_attenuation_does_not_depend_on_voxel_size() {
        let lambda = 0.5;
        let s = slab(lambda, 60_000);
        for beam in [None, Some(BeamSpec { diameter: 0.007, divergence: 0.00035 })] {
            for size in [1.0, 0.5, 0.25] {
                let p = VoxelParams { attenuation: vec![Attenuation::Transmittance, Attenuation::Fpl], beam, unbounded_range: 10.0, ..column(size, 4.0) };
                let g = trace(&s, &p);
                let n = g.n_voxels();
                let mean = |f: &dyn Fn(usize) -> f64| (0..n).map(f).sum::<f64>() / n as f64;
                let t = mean(&|i| g.attenuation(i, Attenuation::Transmittance));
                assert!((t - lambda).abs() < 0.03, "voxel {size} m, beam {}: transmittance attenuation {t}", beam.is_some());
                // Area density follows: lambda / G with G = 0.5.
                let pad = mean(&|i| g.area_density(i, Attenuation::Transmittance).pad);
                assert!((pad - 2.0 * lambda).abs() < 0.06, "voxel {size} m: pad {pad}");
                // The `transmittance` metric is over one metre of path, at any voxel size.
                if beam.is_some() {
                    let per_metre = mean(&|i| g.transmittance(i));
                    assert!((per_metre - (-lambda).exp()).abs() < 0.03, "voxel {size} m: transmittance {per_metre}");
                }
            }
        }
    }

    #[test]
    fn a_pulse_enters_the_voxel_of_an_echo_once() {
        // Two echoes of half the pulse each, in voxels 1 and 3 of a column.
        let s = shots(&[([0.5, 0.5, -1.0], UP, vec![2.5, 4.5])]);
        let beam = Some(BeamSpec { diameter: 0.007, divergence: 0.00035 });
        let g = trace(&s, &VoxelParams { beam, attenuation: vec![Attenuation::Transmittance], ..column(1.0, 5.0) });
        assert_eq!(g.f[F::NumBeamsWeighted as usize], vec![1.0, 1.0, 0.5, 0.5, 0.0]);
        assert_eq!(g.f[F::HitsWeighted as usize], vec![0.0, 0.5, 0.0, 0.5, 0.0]);
        // The paths are those of the fractions: all of it to the first echo, half beyond.
        assert_eq!(g.f[F::FreePathLength as usize], vec![1.0, 0.75, 0.5, 0.25, 0.0]);
        // Half of the entering section is intercepted in voxel 1, all of it in voxel 3.
        let ratio = |i: usize| g.get_f(F::BsIntercepted, i) as f64 / g.get_f(F::BsEntering, i) as f64;
        assert!((ratio(1) - 0.5).abs() < 1e-6 && (ratio(3) - 1.0).abs() < 1e-6, "{} {}", ratio(1), ratio(3));
        assert!((g.attenuation(1, Attenuation::Transmittance) - 2f64.ln()).abs() < 1e-5);
        // Mean angles and distances are weighted the same way.
        assert!(g.mean_zenith(1).abs() < 1e-6);
        assert!((g.mean_laser_distance(1) - 2.5).abs() < 1e-5);

        // Both echoes in one voxel: one pulse entered, all of it stopped there.
        let s = shots(&[([0.5, 0.5, -1.0], UP, vec![2.2, 2.8])]);
        let g = trace(&s, &column(1.0, 5.0));
        assert_eq!(g.f[F::NumBeamsWeighted as usize], vec![1.0, 1.0, 0.0, 0.0, 0.0]);
        assert_eq!(g.f[F::HitsWeighted as usize], vec![0.0, 1.0, 0.0, 0.0, 0.0]);
        assert_eq!(g.i[I::NumBeams as usize], vec![1, 1, 0, 0, 0]);
    }

    #[test]
    fn beams_from_above_and_below_share_a_zenith() {
        // The same line travelled both ways: vertical beams, not horizontal ones.
        let mut pulses = Vec::new();
        for _ in 0..50 {
            pulses.push(([0.5, 0.5, -1.0], UP, vec![3.5]));
            pulses.push(([0.5, 0.5, 6.0], DOWN, vec![3.5]));
        }
        let g = trace(&shots(&pulses), &VoxelParams { lad: Lad::Planophile, ..column(1.0, 5.0) });
        for i in 0..5 {
            assert!(g.mean_zenith(i).abs() < 1e-6, "voxel {i}: {}", g.mean_zenith(i));
        }
        let lambda = g.attenuation_corrected(2, Attenuation::Fpl);
        assert!((lambda - 2.0).abs() < 1e-5);
        let g_vertical = crate::voxel::compute_g(0.0, &Lad::Planophile);
        assert!((g.pad_g_corrected(2) - lambda / g_vertical).abs() < 1e-5, "{}", g.pad_g_corrected(2));
        // A beam at 170 degrees from the upward vertical is one at 10 degrees.
        let tilt = 10f64.to_radians();
        let d = [tilt.sin(), 0.0, -tilt.cos()];
        let g = trace(&shots(&[([0.2, 0.5, 6.0], d, vec![3.0])]), &column(1.0, 5.0));
        assert!((g.mean_zenith(4) - tilt).abs() < 1e-6, "{}", g.mean_zenith(4));
    }

    #[test]
    fn an_echo_on_a_voxel_face_is_a_hit_in_the_voxel_it_came_through() {
        let p = VoxelParams { attenuation: vec![Attenuation::Fpl, Attenuation::Ppl], ..column(1.0, 5.0) };
        // Upwards to z = 2 exactly: the pulse stops at the top of voxel 1.
        let up: Vec<_> = (0..10).map(|_| ([0.5, 0.5, -1.0], UP, vec![3.0])).collect();
        let g = trace(&shots(&up), &p);
        assert_eq!(g.i[I::NumHits as usize], vec![0, 10, 0, 0, 0]);
        assert_eq!(g.i[I::NumBeams as usize], vec![10, 10, 0, 0, 0]);
        // It crossed voxel 0 and ended in voxel 1: a miss in the first only.
        assert_eq!(g.i[I::NumMissRays as usize], vec![10, 0, 0, 0, 0]);
        assert_eq!(g.f[F::SumMissDelta as usize], vec![10.0, 0.0, 0.0, 0.0, 0.0]);
        assert!((g.attenuation(1, Attenuation::Fpl) - 1.0).abs() < 1e-6);
        // Every pulse was stopped: the exact PPL solve is at its cap, and voxel 2 saw nothing.
        assert_eq!(g.ppl_lambda.as_ref().unwrap()[1], 20.0);
        assert_eq!(g.attenuation(2, Attenuation::Ppl), 0.0);
        // Downwards to the same face: it came through voxel 2.
        let down: Vec<_> = (0..10).map(|_| ([0.5, 0.5, 6.0], DOWN, vec![4.0])).collect();
        let g = trace(&shots(&down), &p);
        assert_eq!(g.i[I::NumHits as usize], vec![0, 0, 10, 0, 0]);
        assert_eq!(g.i[I::NumBeams as usize], vec![0, 0, 10, 10, 10]);
        assert_eq!(g.i[I::NumMissRays as usize], vec![0, 0, 0, 10, 10]);
        // A second echo beyond a first one on a face enters the next voxel once.
        let g = trace(&shots(&[([0.5, 0.5, -1.0], UP, vec![3.0, 4.5])]), &column(1.0, 5.0));
        assert_eq!(g.f[F::NumBeamsWeighted as usize], vec![1.0, 1.0, 0.5, 0.5, 0.0]);
        assert_eq!(g.f[F::HitsWeighted as usize], vec![0.0, 0.5, 0.0, 0.5, 0.0]);
    }

    #[test]
    fn echoes_without_a_finite_range_are_refused() {
        for bad in [f64::NAN, f64::INFINITY] {
            let s = shots(&[([2.5, 2.5, -1.0], UP, vec![2.5]), ([2.5, 2.5, -1.0], UP, vec![bad])]);
            let p = VoxelParams { voxel_size: 1.0, bounds: Some(([0.0; 3], [5.0; 3])), ..Default::default() };
            let err = voxelize(&VoxelInputs::new(&s), &p).unwrap_err().to_string();
            assert!(err.contains("echo 1") && err.contains("finite"), "{err}");
            let blocked = voxelize_blocks(&Pulses::Memory(VoxelInputs::new(&s)), &p, None, &BlockOptions { block: [2, 2, 2], ..Default::default() }, None);
            assert!(blocked.unwrap_err().to_string().contains("finite"));
        }
    }

    #[test]
    fn miss_chords_cover_more_pulses_than_miss_rays() {
        // One pulse to an echo in voxel 2, one that leaves the column without an echo.
        let s = shots(&[([0.5, 0.5, -1.0], UP, vec![3.5]), ([0.5, 0.5, -1.0], UP, vec![])]);
        let g = trace(&s, &column(1.0, 5.0));
        // Both crossed voxels 0 and 1; only the first is a miss ray there.
        assert_eq!(g.i[I::NumMissRays as usize], vec![1, 1, 0, 0, 0]);
        assert_eq!(g.f[F::SumMissDelta as usize], vec![2.0, 2.0, 1.0, 1.0, 1.0]);
        assert_eq!(g.i[I::NumUnboundRays as usize], vec![1, 1, 1, 1, 1]);
    }
}