swink-agent 0.13.2

Core scaffolding for running LLM-powered agentic loops
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
//! Tests for `transfer`.
#![cfg(test)]

use super::*;

// T007: TransferSignal constructors, accessors, and serde round-trip

#[test]
fn transfer_signal_new_sets_target_and_reason() {
    let signal = TransferSignal::new("billing", "billing issue");
    assert_eq!(signal.target_agent(), "billing");
    assert_eq!(signal.reason(), "billing issue");
    assert_eq!(signal.context_summary(), None);
    assert!(signal.conversation_history().is_empty());
    assert!(signal.transfer_chain().is_none());
}

#[test]
fn transfer_signal_with_context_summary() {
    let signal = TransferSignal::new("billing", "billing issue")
        .with_context_summary("User has a $50 charge they dispute");
    assert_eq!(
        signal.context_summary(),
        Some("User has a $50 charge they dispute")
    );
}

#[test]
fn transfer_signal_with_conversation_history() {
    use crate::types::{ContentBlock, UserMessage};

    let msg = LlmMessage::User(UserMessage {
        content: vec![ContentBlock::Text {
            text: "hello".into(),
        }],
        timestamp: 0,
        cache_hint: None,
    });
    let signal = TransferSignal::new("tech", "tech issue").with_conversation_history(vec![msg]);
    assert_eq!(signal.conversation_history().len(), 1);
}

#[test]
fn transfer_signal_serde_roundtrip() {
    let mut chain = TransferChain::new(3);
    chain.push("support").unwrap();
    chain.push("billing").unwrap();
    let signal = TransferSignal::new("billing", "billing issue")
        .with_context_summary("User disputes charge")
        .with_transfer_chain(chain);
    let json = serde_json::to_string(&signal).unwrap();
    let parsed: TransferSignal = serde_json::from_str(&json).unwrap();
    assert_eq!(parsed.target_agent(), "billing");
    assert_eq!(parsed.reason(), "billing issue");
    assert_eq!(parsed.context_summary(), Some("User disputes charge"));
    assert!(parsed.conversation_history().is_empty());
    let chain = parsed.transfer_chain().expect("expected transfer chain");
    assert_eq!(chain.chain(), &["support", "billing"]);
}

#[test]
fn transfer_signal_deserialize_without_optional_fields() {
    let json = r#"{"target_agent":"billing","reason":"billing issue"}"#;
    let parsed: TransferSignal = serde_json::from_str(json).unwrap();
    assert_eq!(parsed.target_agent(), "billing");
    assert_eq!(parsed.reason(), "billing issue");
    assert_eq!(parsed.context_summary(), None);
    assert!(parsed.conversation_history().is_empty());
    assert!(parsed.transfer_chain().is_none());
}

#[test]
fn transfer_signal_serde_skips_none_context_summary() {
    let signal = TransferSignal::new("billing", "billing issue");
    let json = serde_json::to_value(&signal).unwrap();
    assert!(!json.as_object().unwrap().contains_key("context_summary"));
    assert!(!json.as_object().unwrap().contains_key("transfer_chain"));
}

#[test]
fn transfer_signal_builder_chain() {
    let signal = TransferSignal::new("target", "reason")
        .with_context_summary("summary")
        .with_conversation_history(vec![]);
    assert_eq!(signal.target_agent(), "target");
    assert_eq!(signal.reason(), "reason");
    assert_eq!(signal.context_summary(), Some("summary"));
    assert!(signal.conversation_history().is_empty());
}

// T025: TransferChain rejects circular transfer
#[test]
fn transfer_chain_rejects_circular() {
    let mut chain = TransferChain::default();
    chain.push("agent-a").unwrap();
    chain.push("agent-b").unwrap();
    let err = chain.push("agent-a").unwrap_err();
    assert!(matches!(err, TransferError::CircularTransfer { .. }));
}

// T026: TransferChain rejects when max_depth exceeded
#[test]
fn transfer_chain_rejects_max_depth() {
    let mut chain = TransferChain::new(2);
    chain.push("a").unwrap();
    chain.push("b").unwrap();
    let err = chain.push("c").unwrap_err();
    assert!(matches!(
        err,
        TransferError::MaxDepthExceeded { depth: 2, max: 2 }
    ));
}

// T027: TransferChain allows push of new agent
#[test]
fn transfer_chain_allows_new_agent() {
    let mut chain = TransferChain::default();
    assert!(chain.push("agent-a").is_ok());
    assert!(chain.push("agent-b").is_ok());
    assert!(chain.push("agent-c").is_ok());
}

// T028: TransferChain::default() has max_depth 5
#[test]
fn transfer_chain_default_max_depth() {
    let mut chain = TransferChain::default();
    // Push 5 agents, all should succeed
    for i in 0..5 {
        chain.push(format!("agent-{i}")).unwrap();
    }
    // 6th should fail
    let err = chain.push("agent-5").unwrap_err();
    assert!(matches!(err, TransferError::MaxDepthExceeded { .. }));
}

// T029: TransferChain::contains() and depth()
#[test]
fn transfer_chain_contains_and_depth() {
    let mut chain = TransferChain::default();
    assert_eq!(chain.depth(), 0);
    assert!(!chain.contains("a"));

    chain.push("a").unwrap();
    assert_eq!(chain.depth(), 1);
    assert!(chain.contains("a"));
    assert!(!chain.contains("b"));

    chain.push("b").unwrap();
    assert_eq!(chain.depth(), 2);
    assert!(chain.contains("b"));
    assert_eq!(chain.chain(), &["a", "b"]);
}

// T030: Self-transfer is always circular
#[test]
fn transfer_chain_self_transfer_is_circular() {
    let mut chain = TransferChain::default();
    chain.push("support").unwrap();
    // Trying to push the same agent that's already first (self-transfer)
    let err = chain.push("support").unwrap_err();
    assert!(
        matches!(err, TransferError::CircularTransfer { agent_name, .. } if agent_name == "support")
    );
}

// T036: TransferSignal has target, reason, context_summary
#[test]
fn transfer_signal_carries_full_context() {
    let signal = TransferSignal::new("billing", "billing question")
        .with_context_summary("User asked about invoice #123");
    assert_eq!(signal.target_agent(), "billing");
    assert_eq!(signal.reason(), "billing question");
    assert_eq!(
        signal.context_summary(),
        Some("User asked about invoice #123")
    );
}

// ── TransferToAgentTool tests (T011-T015) ────────────────────────────

#[cfg(feature = "testkit")]
mod transfer_tool_tests {
    use super::*;
    use crate::agent::{Agent, AgentOptions};
    use crate::registry::AgentRegistry;
    use crate::testing::SimpleMockStreamFn;
    use crate::tool::AgentTool;
    use crate::types::ModelSpec;
    use tokio_util::sync::CancellationToken;

    /// Build a minimal Agent suitable for registering in the registry.
    fn dummy_agent() -> Agent {
        Agent::new(AgentOptions::new(
            "test",
            ModelSpec::new("test", "test-model"),
            std::sync::Arc::new(SimpleMockStreamFn::from_text("hi")),
            crate::agent::default_convert,
        ))
    }

    // T011: TransferToAgentTool validates target exists, returns transfer signal
    #[tokio::test]
    async fn transfer_tool_validates_target_and_returns_signal() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        let tool = TransferToAgentTool::new(registry);
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "billing question"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(!result.is_error);
        assert!(result.is_transfer());
        let signal = result.transfer_signal.unwrap();
        assert_eq!(signal.target_agent(), "billing");
        assert_eq!(signal.reason(), "billing question");
        assert_eq!(signal.context_summary(), None);
        // History is empty — loop enriches it later
        assert!(signal.conversation_history().is_empty());
    }

    // T012: Target not in registry returns error
    #[tokio::test]
    async fn transfer_tool_target_not_found_returns_error() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        // Registry is empty — no agents registered

        let tool = TransferToAgentTool::new(registry);
        let params = serde_json::json!({
            "agent_name": "nonexistent",
            "reason": "test"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(result.is_error);
        assert!(!result.is_transfer());
        let text = &result.content[0];
        match text {
            crate::types::ContentBlock::Text { text } => {
                assert!(
                    text.contains("not found in registry"),
                    "expected 'not found in registry', got: {text}"
                );
            }
            _ => panic!("expected text content block"),
        }
    }

    // T013: context_summary included in signal when provided
    #[tokio::test]
    async fn transfer_tool_includes_context_summary() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        let tool = TransferToAgentTool::new(registry);
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "billing dispute",
            "context_summary": "User has a $50 charge they want to dispute"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(!result.is_error);
        let signal = result.transfer_signal.unwrap();
        assert_eq!(
            signal.context_summary(),
            Some("User has a $50 charge they want to dispute")
        );
    }

    // T015: Result text is "Transfer to {agent_name} initiated."
    #[tokio::test]
    async fn transfer_tool_result_text_format() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        let tool = TransferToAgentTool::new(registry);
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "billing question"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        let text = &result.content[0];
        match text {
            crate::types::ContentBlock::Text { text } => {
                assert_eq!(text, "Transfer to billing initiated.");
            }
            _ => panic!("expected text content block"),
        }
    }

    // Additional: allowed_targets restricts transfers
    #[tokio::test]
    async fn transfer_tool_allowed_targets_restricts() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());
        registry.register("tech", dummy_agent());

        // Only allow billing
        let tool = TransferToAgentTool::with_allowed_targets(registry, vec!["billing"]);
        let params = serde_json::json!({
            "agent_name": "tech",
            "reason": "tech question"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(result.is_error);
        let text = &result.content[0];
        match text {
            crate::types::ContentBlock::Text { text } => {
                assert!(
                    text.contains("not allowed"),
                    "expected 'not allowed', got: {text}"
                );
            }
            _ => panic!("expected text content block"),
        }
    }

    // Additional: allowed_targets permits valid target
    #[tokio::test]
    async fn transfer_tool_allowed_targets_permits() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        let tool = TransferToAgentTool::with_allowed_targets(registry, vec!["billing"]);
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "billing question"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(!result.is_error);
        assert!(result.is_transfer());
    }

    // T022: Empty allowed_targets set rejects all transfers
    #[tokio::test]
    async fn transfer_tool_empty_allowed_targets_rejects_all() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        // Empty allowed targets = nothing allowed
        let tool = TransferToAgentTool::with_allowed_targets(
            std::sync::Arc::clone(&registry),
            std::iter::empty::<String>(),
        );
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "test"
        });

        let result = tool
            .execute(
                "tc-1",
                params,
                CancellationToken::new(),
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(result.is_error);
        let text = &result.content[0];
        match text {
            crate::types::ContentBlock::Text { text } => {
                assert!(
                    text.contains("not allowed"),
                    "expected 'not allowed', got: {text}"
                );
            }
            _ => panic!("expected text content block"),
        }
    }

    // Additional: cancellation token respected
    #[tokio::test]
    async fn transfer_tool_respects_cancellation() {
        let registry = std::sync::Arc::new(AgentRegistry::new());
        registry.register("billing", dummy_agent());

        let tool = TransferToAgentTool::new(registry);
        let params = serde_json::json!({
            "agent_name": "billing",
            "reason": "test"
        });

        let token = CancellationToken::new();
        token.cancel();

        let result = tool
            .execute(
                "tc-1",
                params,
                token,
                None,
                std::sync::Arc::new(std::sync::RwLock::new(crate::SessionState::default())),
                None,
            )
            .await;

        assert!(result.is_error);
        let text = &result.content[0];
        match text {
            crate::types::ContentBlock::Text { text } => {
                assert_eq!(text, "cancelled");
            }
            _ => panic!("expected text content block"),
        }
    }
}