swink-agent-memory 0.14.3

Session persistence and memory management for swink-agent
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177

//! Integration tests for JSONL format and corruption recovery (US5).

use crate::common;

use swink_agent_memory::{JsonlSessionStore, SessionStore};

use common::{assistant_message, sample_meta, user_message};

#[test]
fn jsonl_file_is_human_readable() {
    let tmp = tempfile::tempdir().unwrap();
    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();

    let meta = sample_meta("readable_test", "Readable");
    let messages = vec![
        user_message("hello"),
        assistant_message("hi"),
        user_message("bye"),
    ];
    store.save("readable_test", &meta, &messages).unwrap();

    // Read raw file and verify each line is independently parseable JSON
    let content = std::fs::read_to_string(tmp.path().join("readable_test.jsonl")).unwrap();
    let lines: Vec<&str> = content.lines().collect();

    assert_eq!(lines.len(), 4); // 1 meta + 3 messages
    for (i, line) in lines.iter().enumerate() {
        let parsed: Result<serde_json::Value, _> = serde_json::from_str(line);
        assert!(parsed.is_ok(), "line {i} is not valid JSON: {line}");
    }
}

#[test]
fn corrupted_line_recovers_remaining_messages() {
    let tmp = tempfile::tempdir().unwrap();
    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();

    let meta = sample_meta("corrupt_test", "Corrupt test");
    let messages = vec![
        user_message("msg1"),
        user_message("msg2"),
        user_message("msg3"),
        user_message("msg4"),
        user_message("msg5"),
    ];
    store.save("corrupt_test", &meta, &messages).unwrap();

    // Read file, corrupt the 3rd message line (line index 3 = 4th line)
    let path = tmp.path().join("corrupt_test.jsonl");
    let content = std::fs::read_to_string(&path).unwrap();
    let mut lines: Vec<String> = content.lines().map(String::from).collect();
    assert_eq!(lines.len(), 6); // 1 meta + 5 messages
    lines[3] = "THIS IS CORRUPTED GARBAGE".to_string();
    std::fs::write(&path, lines.join("\n")).unwrap();

    // Load should recover 4 of 5 messages
    let (loaded_meta, loaded_msgs) = store.load("corrupt_test", None).unwrap();
    assert_eq!(loaded_meta.id, "corrupt_test");
    assert_eq!(loaded_msgs.len(), 4);
}

#[test]
fn truncated_utf8_tail_line_recovers_remaining_messages() {
    // Regression for #1067: a crash mid-append can leave the final line
    // truncated inside a multi-byte UTF-8 sequence. Unlike malformed-but-
    // valid-UTF-8 JSON, this used to abort the entire load with an
    // `io::Error` before per-line classification ran.
    let tmp = tempfile::tempdir().unwrap();
    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();

    let meta = sample_meta("truncated_tail", "Truncated tail");
    let messages = vec![
        user_message("msg1"),
        user_message("msg2"),
        user_message("msg3"),
        user_message("msg4"),
        user_message("msg5"),
    ];
    store.save("truncated_tail", &meta, &messages).unwrap();

    // Simulate a partially flushed 6th message: a valid JSON prefix whose
    // text ends in the first byte of the two-byte UTF-8 encoding of 'é'
    // (0xC3 0xA9), with the second byte and the newline lost in the crash.
    let path = tmp.path().join("truncated_tail.jsonl");
    let mut bytes = std::fs::read(&path).unwrap();
    bytes.extend_from_slice(br#"{"type":"user","content":[{"type":"text","text":"caf"#);
    bytes.push(0xC3);
    std::fs::write(&path, &bytes).unwrap();

    // Load should skip the truncated tail line and recover all 5 messages.
    let (loaded_meta, loaded_msgs) = store.load("truncated_tail", None).unwrap();
    assert_eq!(loaded_meta.id, "truncated_tail");
    assert_eq!(loaded_msgs.len(), 5);
}

#[test]
fn invalid_utf8_middle_line_recovers_remaining_messages() {
    // Invalid UTF-8 is tolerated per-line, not only at the tail: lines after
    // the corrupt one must still be classified and recovered.
    let tmp = tempfile::tempdir().unwrap();
    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();

    let meta = sample_meta("utf8_middle", "UTF-8 middle");
    let messages = vec![
        user_message("msg1"),
        user_message("msg2"),
        user_message("msg3"),
    ];
    store.save("utf8_middle", &meta, &messages).unwrap();

    // Corrupt the 2nd message line (line index 2) with a lone continuation
    // byte, keeping the following lines intact.
    let path = tmp.path().join("utf8_middle.jsonl");
    let content = std::fs::read(&path).unwrap();
    let mut lines: Vec<Vec<u8>> = content
        .split(|&b| b == b'\n')
        .filter(|line| !line.is_empty())
        .map(<[u8]>::to_vec)
        .collect();
    assert_eq!(lines.len(), 4); // 1 meta + 3 messages
    lines[2] = vec![b'{', 0xBF, b'}'];
    let mut rewritten = lines.join(&b'\n');
    rewritten.push(b'\n');
    std::fs::write(&path, &rewritten).unwrap();

    let (loaded_meta, loaded_msgs) = store.load("utf8_middle", None).unwrap();
    assert_eq!(loaded_meta.id, "utf8_middle");
    assert_eq!(loaded_msgs.len(), 2);
}

#[test]
fn all_message_lines_corrupted_returns_empty_messages() {
    let tmp = tempfile::tempdir().unwrap();

    let meta = sample_meta("all_corrupt", "All corrupt");
    let meta_json = serde_json::to_string(&meta).unwrap();

    // Write valid meta + all corrupted message lines
    let content = format!("{meta_json}\nGARBAGE1\nGARBAGE2\nGARBAGE3\n");
    std::fs::write(tmp.path().join("all_corrupt.jsonl"), &content).unwrap();

    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();
    let (loaded_meta, loaded_msgs) = store.load("all_corrupt", None).unwrap();
    assert_eq!(loaded_meta.id, "all_corrupt");
    assert!(loaded_msgs.is_empty());
}

#[test]
fn append_does_not_rewrite_file() {
    let tmp = tempfile::tempdir().unwrap();
    let store = JsonlSessionStore::new(tmp.path().to_path_buf()).unwrap();

    let meta = sample_meta("append_test", "Append test");
    let initial_msgs = vec![
        user_message("msg1"),
        user_message("msg2"),
        user_message("msg3"),
    ];
    store.save("append_test", &meta, &initial_msgs).unwrap();

    let path = tmp.path().join("append_test.jsonl");
    let size_before = std::fs::metadata(&path).unwrap().len();

    // Append 2 more messages
    let new_msgs = vec![user_message("msg4"), user_message("msg5")];
    store.append("append_test", &new_msgs).unwrap();

    let size_after = std::fs::metadata(&path).unwrap().len();
    assert!(
        size_after > size_before,
        "file should have grown: {size_before} -> {size_after}"
    );

    // Verify all 5 messages are present
    let (_, loaded_msgs) = store.load("append_test", None).unwrap();
    assert_eq!(loaded_msgs.len(), 5);
}